From b2c2616ab4322e6894d6d5b2376e7377609f3d9a Mon Sep 17 00:00:00 2001
From: Mhd Ghaith Al Abtah
 <141250866+mhd-ghaith-abtah@users.noreply.github.com>
Date: Tue, 19 May 2026 19:50:48 +0400
Subject: [PATCH] test(install-targets): add positive rules assertion to
 claude-project foreign-path test

Addresses CodeRabbit review: the negative-only assertions could have
passed on an empty plan. Add a positive assertion that the non-foreign
'rules' path is still planned under .claude/rules/ecc so regression to
zero ops would fail loudly.
---
 tests/lib/install-targets.test.js | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/tests/lib/install-targets.test.js b/tests/lib/install-targets.test.js
index 6fa7b1bf..d74d95aa 100644
--- a/tests/lib/install-targets.test.js
+++ b/tests/lib/install-targets.test.js
@@ -943,6 +943,13 @@ function runTests() {
       ],
     });
 
+    assert.ok(
+      plan.operations.some(operation => (
+        normalizedRelativePath(operation.sourceRelativePath) === 'rules'
+        && operation.destinationPath === path.join(projectRoot, '.claude', 'rules', 'ecc')
+      )),
+      'Should still include non-foreign rules path (guards against empty-plan regression)'
+    );
     assert.ok(
       !plan.operations.some(operation => (
         normalizedRelativePath(operation.sourceRelativePath) === '.cursor'