/** * Module-qualified symbol lookup (`stage_apply::run`, `Session.request`, * `configurator/stage_apply`). * * Pinned because the lookup vocabulary is what makes codegraph useful * in workspaces with same-named symbols across modules — Rust * sub-pipelines, Python `__init__.py` packages, Java packages, etc. * See #173 for the original report: a `run` function in * `src/configurator/stage_apply.rs` was indexed but `stage_apply::run` * returned "not found" because (a) FTS strips colons to nothing, * leaving a useless query, and (b) `matchesSymbol` only understood * `.`-style qualifiers. */ import { describe, it, expect, beforeAll, beforeEach, afterEach } from 'vitest'; import * as fs from 'fs'; import * as path from 'path'; import * as os from 'os'; import { initGrammars, loadAllGrammars } from '../src/extraction/grammars'; beforeAll(async () => { await initGrammars(); await loadAllGrammars(); }); function hasSqliteBindings(): boolean { try { const Database = require('better-sqlite3'); const db = new Database(':memory:'); db.close(); return true; } catch { return false; } } const HAS_SQLITE = hasSqliteBindings(); function tmpRoot(): string { return fs.mkdtempSync(path.join(os.tmpdir(), 'codegraph-symbol-lookup-')); } function rmTree(dir: string): void { if (fs.existsSync(dir)) fs.rmSync(dir, { recursive: true, force: true }); } async function buildRustWorkspace(): Promise { const root = tmpRoot(); const cfgDir = path.join(root, 'src', 'configurator'); fs.mkdirSync(cfgDir, { recursive: true }); fs.writeFileSync( path.join(root, 'Cargo.toml'), `[package]\nname = "fixture"\nversion = "0.1.0"\nedition = "2021"\n[lib]\npath = "src/lib.rs"\n` ); fs.writeFileSync(path.join(root, 'src', 'lib.rs'), `pub mod configurator;\npub mod scheduler;\n`); fs.writeFileSync( path.join(cfgDir, 'mod.rs'), `pub mod stage_apply;\npub mod stage_detect;\n` ); fs.writeFileSync( path.join(cfgDir, 'stage_apply.rs'), `pub async fn run() -> Result<(), ()> {\n render_and_write();\n Ok(())\n}\n\nfn render_and_write() {}\n` ); fs.writeFileSync( path.join(cfgDir, 'stage_detect.rs'), `pub async fn run() -> Result<(), ()> { Ok(()) }\n` ); fs.writeFileSync( path.join(root, 'src', 'scheduler.rs'), `pub fn run_due_tasks() -> Result<(), ()> { Ok(()) }\n` ); return root; } describe.skipIf(!HAS_SQLITE)('matchesSymbol — module-qualified lookups (#173)', () => { let projectRoot: string; let cg: any; let handler: any; let findSymbol: (cg: any, s: string) => { node: any; note: string } | null; let findAllSymbols: (cg: any, s: string) => { nodes: any[]; note: string }; beforeEach(async () => { projectRoot = await buildRustWorkspace(); const CodeGraph = (await import('../src/index')).default; const { ToolHandler } = await import('../src/mcp/tools'); cg = CodeGraph.initSync(projectRoot, { config: { include: ['**/*.rs'], exclude: [] }, }); await cg.indexAll(); handler = new ToolHandler(cg); findSymbol = (handler as any).findSymbol.bind(handler); findAllSymbols = (handler as any).findAllSymbols.bind(handler); }); afterEach(() => { handler?.closeAll(); cg?.destroy(); rmTree(projectRoot); }); it('resolves `stage_apply::run` to the run in stage_apply.rs (not stage_detect.rs)', () => { const match = findSymbol(cg, 'stage_apply::run'); expect(match).not.toBeNull(); expect(match!.node.name).toBe('run'); expect(match!.node.filePath).toMatch(/configurator\/stage_apply\.rs$/); }); it('rejects `stage_apply::run` for the same-named function in a different module', () => { const all = findAllSymbols(cg, 'stage_apply::run'); // All returned nodes must be in stage_apply.rs — never in stage_detect.rs for (const node of all.nodes) { expect(node.filePath).toMatch(/stage_apply\.rs$/); } expect(all.nodes.length).toBeGreaterThan(0); }); it('resolves `configurator::stage_apply::run` (multi-level qualifier)', () => { const match = findSymbol(cg, 'configurator::stage_apply::run'); expect(match).not.toBeNull(); expect(match!.node.name).toBe('run'); expect(match!.node.filePath).toMatch(/configurator\/stage_apply\.rs$/); }); it('resolves `crate::configurator::stage_apply::run` (Rust path prefix stripped)', () => { const match = findSymbol(cg, 'crate::configurator::stage_apply::run'); expect(match).not.toBeNull(); expect(match!.node.filePath).toMatch(/configurator\/stage_apply\.rs$/); }); it('resolves `configurator/stage_apply` (slash qualifier)', () => { const match = findSymbol(cg, 'configurator/stage_apply/run'); expect(match).not.toBeNull(); expect(match!.node.filePath).toMatch(/configurator\/stage_apply\.rs$/); }); it('does not silently collide bare `run` with `run_due_tasks`', () => { const match = findSymbol(cg, 'run'); expect(match).not.toBeNull(); // Whatever it picks, it must be an exact-name match, not a partial. expect(match!.node.name).toBe('run'); }); it('aggregates all bare-name `run` matches across modules', () => { const all = findAllSymbols(cg, 'run'); const names = all.nodes.map((n: any) => n.name); expect(names.every((n: string) => n === 'run')).toBe(true); expect(all.nodes.length).toBeGreaterThanOrEqual(2); // stage_apply + stage_detect // The note should call out the ambiguity. expect(all.note).toMatch(/Aggregated|symbols named "run"/); }); it('still returns null for genuinely unknown qualified lookups', () => { const match = findSymbol(cg, 'stage_apply::nonexistent_fn'); expect(match).toBeNull(); }); }); describe.skipIf(!HAS_SQLITE)('matchesSymbol — dotted lookups (regression for #173 fix)', () => { let projectRoot: string; let cg: any; let handler: any; let findSymbol: (cg: any, s: string) => { node: any; note: string } | null; beforeEach(async () => { projectRoot = tmpRoot(); const src = path.join(projectRoot, 'src'); fs.mkdirSync(src, { recursive: true }); fs.writeFileSync( path.join(src, 'session.ts'), `export class Session {\n request(): void {}\n}\nexport function request(): void {}\n` ); const CodeGraph = (await import('../src/index')).default; const { ToolHandler } = await import('../src/mcp/tools'); cg = CodeGraph.initSync(projectRoot, { config: { include: ['src/**/*.ts'], exclude: [] }, }); await cg.indexAll(); handler = new ToolHandler(cg); findSymbol = (handler as any).findSymbol.bind(handler); }); afterEach(() => { handler?.closeAll(); cg?.destroy(); rmTree(projectRoot); }); it('`Session.request` resolves to the method, not the bare function', () => { const match = findSymbol(cg, 'Session.request'); expect(match).not.toBeNull(); expect(match!.node.kind).toBe('method'); expect(match!.node.qualifiedName).toContain('Session::request'); }); });