resolution.test.ts 225 KB

12345678910111213141516171819202122232425262728293031323334353637383940414243444546474849505152535455565758596061626364656667686970717273747576777879808182838485868788899091929394959697989910010110210310410510610710810911011111211311411511611711811912012112212312412512612712812913013113213313413513613713813914014114214314414514614714814915015115215315415515615715815916016116216316416516616716816917017117217317417517617717817918018118218318418518618718818919019119219319419519619719819920020120220320420520620720820921021121221321421521621721821922022122222322422522622722822923023123223323423523623723823924024124224324424524624724824925025125225325425525625725825926026126226326426526626726826927027127227327427527627727827928028128228328428528628728828929029129229329429529629729829930030130230330430530630730830931031131231331431531631731831932032132232332432532632732832933033133233333433533633733833934034134234334434534634734834935035135235335435535635735835936036136236336436536636736836937037137237337437537637737837938038138238338438538638738838939039139239339439539639739839940040140240340440540640740840941041141241341441541641741841942042142242342442542642742842943043143243343443543643743843944044144244344444544644744844945045145245345445545645745845946046146246346446546646746846947047147247347447547647747847948048148248348448548648748848949049149249349449549649749849950050150250350450550650750850951051151251351451551651751851952052152252352452552652752852953053153253353453553653753853954054154254354454554654754854955055155255355455555655755855956056156256356456556656756856957057157257357457557657757857958058158258358458558658758858959059159259359459559659759859960060160260360460560660760860961061161261361461561661761861962062162262362462562662762862963063163263363463563663763863964064164264364464564664764864965065165265365465565665765865966066166266366466566666766866967067167267367467567667767867968068168268368468568668768868969069169269369469569669769869970070170270370470570670770870971071171271371471571671771871972072172272372472572672772872973073173273373473573673773873974074174274374474574674774874975075175275375475575675775875976076176276376476576676776876977077177277377477577677777877978078178278378478578678778878979079179279379479579679779879980080180280380480580680780880981081181281381481581681781881982082182282382482582682782882983083183283383483583683783883984084184284384484584684784884985085185285385485585685785885986086186286386486586686786886987087187287387487587687787887988088188288388488588688788888989089189289389489589689789889990090190290390490590690790890991091191291391491591691791891992092192292392492592692792892993093193293393493593693793893994094194294394494594694794894995095195295395495595695795895996096196296396496596696796896997097197297397497597697797897998098198298398498598698798898999099199299399499599699799899910001001100210031004100510061007100810091010101110121013101410151016101710181019102010211022102310241025102610271028102910301031103210331034103510361037103810391040104110421043104410451046104710481049105010511052105310541055105610571058105910601061106210631064106510661067106810691070107110721073107410751076107710781079108010811082108310841085108610871088108910901091109210931094109510961097109810991100110111021103110411051106110711081109111011111112111311141115111611171118111911201121112211231124112511261127112811291130113111321133113411351136113711381139114011411142114311441145114611471148114911501151115211531154115511561157115811591160116111621163116411651166116711681169117011711172117311741175117611771178117911801181118211831184118511861187118811891190119111921193119411951196119711981199120012011202120312041205120612071208120912101211121212131214121512161217121812191220122112221223122412251226122712281229123012311232123312341235123612371238123912401241124212431244124512461247124812491250125112521253125412551256125712581259126012611262126312641265126612671268126912701271127212731274127512761277127812791280128112821283128412851286128712881289129012911292129312941295129612971298129913001301130213031304130513061307130813091310131113121313131413151316131713181319132013211322132313241325132613271328132913301331133213331334133513361337133813391340134113421343134413451346134713481349135013511352135313541355135613571358135913601361136213631364136513661367136813691370137113721373137413751376137713781379138013811382138313841385138613871388138913901391139213931394139513961397139813991400140114021403140414051406140714081409141014111412141314141415141614171418141914201421142214231424142514261427142814291430143114321433143414351436143714381439144014411442144314441445144614471448144914501451145214531454145514561457145814591460146114621463146414651466146714681469147014711472147314741475147614771478147914801481148214831484148514861487148814891490149114921493149414951496149714981499150015011502150315041505150615071508150915101511151215131514151515161517151815191520152115221523152415251526152715281529153015311532153315341535153615371538153915401541154215431544154515461547154815491550155115521553155415551556155715581559156015611562156315641565156615671568156915701571157215731574157515761577157815791580158115821583158415851586158715881589159015911592159315941595159615971598159916001601160216031604160516061607160816091610161116121613161416151616161716181619162016211622162316241625162616271628162916301631163216331634163516361637163816391640164116421643164416451646164716481649165016511652165316541655165616571658165916601661166216631664166516661667166816691670167116721673167416751676167716781679168016811682168316841685168616871688168916901691169216931694169516961697169816991700170117021703170417051706170717081709171017111712171317141715171617171718171917201721172217231724172517261727172817291730173117321733173417351736173717381739174017411742174317441745174617471748174917501751175217531754175517561757175817591760176117621763176417651766176717681769177017711772177317741775177617771778177917801781178217831784178517861787178817891790179117921793179417951796179717981799180018011802180318041805180618071808180918101811181218131814181518161817181818191820182118221823182418251826182718281829183018311832183318341835183618371838183918401841184218431844184518461847184818491850185118521853185418551856185718581859186018611862186318641865186618671868186918701871187218731874187518761877187818791880188118821883188418851886188718881889189018911892189318941895189618971898189919001901190219031904190519061907190819091910191119121913191419151916191719181919192019211922192319241925192619271928192919301931193219331934193519361937193819391940194119421943194419451946194719481949195019511952195319541955195619571958195919601961196219631964196519661967196819691970197119721973197419751976197719781979198019811982198319841985198619871988198919901991199219931994199519961997199819992000200120022003200420052006200720082009201020112012201320142015201620172018201920202021202220232024202520262027202820292030203120322033203420352036203720382039204020412042204320442045204620472048204920502051205220532054205520562057205820592060206120622063206420652066206720682069207020712072207320742075207620772078207920802081208220832084208520862087208820892090209120922093209420952096209720982099210021012102210321042105210621072108210921102111211221132114211521162117211821192120212121222123212421252126212721282129213021312132213321342135213621372138213921402141214221432144214521462147214821492150215121522153215421552156215721582159216021612162216321642165216621672168216921702171217221732174217521762177217821792180218121822183218421852186218721882189219021912192219321942195219621972198219922002201220222032204220522062207220822092210221122122213221422152216221722182219222022212222222322242225222622272228222922302231223222332234223522362237223822392240224122422243224422452246224722482249225022512252225322542255225622572258225922602261226222632264226522662267226822692270227122722273227422752276227722782279228022812282228322842285228622872288228922902291229222932294229522962297229822992300230123022303230423052306230723082309231023112312231323142315231623172318231923202321232223232324232523262327232823292330233123322333233423352336233723382339234023412342234323442345234623472348234923502351235223532354235523562357235823592360236123622363236423652366236723682369237023712372237323742375237623772378237923802381238223832384238523862387238823892390239123922393239423952396239723982399240024012402240324042405240624072408240924102411241224132414241524162417241824192420242124222423242424252426242724282429243024312432243324342435243624372438243924402441244224432444244524462447244824492450245124522453245424552456245724582459246024612462246324642465246624672468246924702471247224732474247524762477247824792480248124822483248424852486248724882489249024912492249324942495249624972498249925002501250225032504250525062507250825092510251125122513251425152516251725182519252025212522252325242525252625272528252925302531253225332534253525362537253825392540254125422543254425452546254725482549255025512552255325542555255625572558255925602561256225632564256525662567256825692570257125722573257425752576257725782579258025812582258325842585258625872588258925902591259225932594259525962597259825992600260126022603260426052606260726082609261026112612261326142615261626172618261926202621262226232624262526262627262826292630263126322633263426352636263726382639264026412642264326442645264626472648264926502651265226532654265526562657265826592660266126622663266426652666266726682669267026712672267326742675267626772678267926802681268226832684268526862687268826892690269126922693269426952696269726982699270027012702270327042705270627072708270927102711271227132714271527162717271827192720272127222723272427252726272727282729273027312732273327342735273627372738273927402741274227432744274527462747274827492750275127522753275427552756275727582759276027612762276327642765276627672768276927702771277227732774277527762777277827792780278127822783278427852786278727882789279027912792279327942795279627972798279928002801280228032804280528062807280828092810281128122813281428152816281728182819282028212822282328242825282628272828282928302831283228332834283528362837283828392840284128422843284428452846284728482849285028512852285328542855285628572858285928602861286228632864286528662867286828692870287128722873287428752876287728782879288028812882288328842885288628872888288928902891289228932894289528962897289828992900290129022903290429052906290729082909291029112912291329142915291629172918291929202921292229232924292529262927292829292930293129322933293429352936293729382939294029412942294329442945294629472948294929502951295229532954295529562957295829592960296129622963296429652966296729682969297029712972297329742975297629772978297929802981298229832984298529862987298829892990299129922993299429952996299729982999300030013002300330043005300630073008300930103011301230133014301530163017301830193020302130223023302430253026302730283029303030313032303330343035303630373038303930403041304230433044304530463047304830493050305130523053305430553056305730583059306030613062306330643065306630673068306930703071307230733074307530763077307830793080308130823083308430853086308730883089309030913092309330943095309630973098309931003101310231033104310531063107310831093110311131123113311431153116311731183119312031213122312331243125312631273128312931303131313231333134313531363137313831393140314131423143314431453146314731483149315031513152315331543155315631573158315931603161316231633164316531663167316831693170317131723173317431753176317731783179318031813182318331843185318631873188318931903191319231933194319531963197319831993200320132023203320432053206320732083209321032113212321332143215321632173218321932203221322232233224322532263227322832293230323132323233323432353236323732383239324032413242324332443245324632473248324932503251325232533254325532563257325832593260326132623263326432653266326732683269327032713272327332743275327632773278327932803281328232833284328532863287328832893290329132923293329432953296329732983299330033013302330333043305330633073308330933103311331233133314331533163317331833193320332133223323332433253326332733283329333033313332333333343335333633373338333933403341334233433344334533463347334833493350335133523353335433553356335733583359336033613362336333643365336633673368336933703371337233733374337533763377337833793380338133823383338433853386338733883389339033913392339333943395339633973398339934003401340234033404340534063407340834093410341134123413341434153416341734183419342034213422342334243425342634273428342934303431343234333434343534363437343834393440344134423443344434453446344734483449345034513452345334543455345634573458345934603461346234633464346534663467346834693470347134723473347434753476347734783479348034813482348334843485348634873488348934903491349234933494349534963497349834993500350135023503350435053506350735083509351035113512351335143515351635173518351935203521352235233524352535263527352835293530353135323533353435353536353735383539354035413542354335443545354635473548354935503551355235533554355535563557355835593560356135623563356435653566356735683569357035713572357335743575357635773578357935803581358235833584358535863587358835893590359135923593359435953596359735983599360036013602360336043605360636073608360936103611361236133614361536163617361836193620362136223623362436253626362736283629363036313632363336343635363636373638363936403641364236433644364536463647364836493650365136523653365436553656365736583659366036613662366336643665366636673668366936703671367236733674367536763677367836793680368136823683368436853686368736883689369036913692369336943695369636973698369937003701370237033704370537063707370837093710371137123713371437153716371737183719372037213722372337243725372637273728372937303731373237333734373537363737373837393740374137423743374437453746374737483749375037513752375337543755375637573758375937603761376237633764376537663767376837693770377137723773377437753776377737783779378037813782378337843785378637873788378937903791379237933794379537963797379837993800380138023803380438053806380738083809381038113812381338143815381638173818381938203821382238233824382538263827382838293830383138323833383438353836383738383839384038413842384338443845384638473848384938503851385238533854385538563857385838593860386138623863386438653866386738683869387038713872387338743875387638773878387938803881388238833884388538863887388838893890389138923893389438953896389738983899390039013902390339043905390639073908390939103911391239133914391539163917391839193920392139223923392439253926392739283929393039313932393339343935393639373938393939403941394239433944394539463947394839493950395139523953395439553956395739583959396039613962396339643965396639673968396939703971397239733974397539763977397839793980398139823983398439853986398739883989399039913992399339943995399639973998399940004001400240034004400540064007400840094010401140124013401440154016401740184019402040214022402340244025402640274028402940304031403240334034403540364037403840394040404140424043404440454046404740484049405040514052405340544055405640574058405940604061406240634064406540664067406840694070407140724073407440754076407740784079408040814082408340844085408640874088408940904091409240934094409540964097409840994100410141024103410441054106410741084109411041114112411341144115411641174118411941204121412241234124412541264127412841294130413141324133413441354136413741384139414041414142414341444145414641474148414941504151415241534154415541564157415841594160416141624163416441654166416741684169417041714172417341744175417641774178417941804181418241834184418541864187418841894190419141924193419441954196419741984199420042014202420342044205420642074208420942104211421242134214421542164217421842194220422142224223422442254226422742284229423042314232423342344235423642374238423942404241424242434244424542464247424842494250425142524253425442554256425742584259426042614262426342644265426642674268426942704271427242734274427542764277427842794280428142824283428442854286428742884289429042914292429342944295429642974298429943004301430243034304430543064307430843094310431143124313431443154316431743184319432043214322432343244325432643274328432943304331433243334334433543364337433843394340434143424343434443454346434743484349435043514352435343544355435643574358435943604361436243634364436543664367436843694370437143724373437443754376437743784379438043814382438343844385438643874388438943904391439243934394439543964397439843994400440144024403440444054406440744084409441044114412441344144415441644174418441944204421442244234424442544264427442844294430443144324433443444354436443744384439444044414442444344444445444644474448444944504451445244534454445544564457445844594460446144624463446444654466446744684469447044714472447344744475447644774478447944804481448244834484448544864487448844894490449144924493449444954496449744984499450045014502450345044505450645074508450945104511451245134514451545164517451845194520452145224523452445254526452745284529453045314532453345344535453645374538453945404541454245434544454545464547454845494550455145524553455445554556455745584559456045614562456345644565456645674568456945704571457245734574457545764577457845794580458145824583458445854586458745884589459045914592459345944595459645974598459946004601460246034604460546064607460846094610461146124613461446154616461746184619462046214622462346244625462646274628462946304631463246334634463546364637463846394640464146424643464446454646464746484649465046514652465346544655465646574658465946604661466246634664466546664667466846694670467146724673467446754676467746784679468046814682468346844685468646874688468946904691469246934694469546964697469846994700470147024703470447054706470747084709471047114712471347144715471647174718471947204721472247234724472547264727472847294730473147324733473447354736473747384739474047414742474347444745474647474748474947504751475247534754475547564757475847594760476147624763476447654766476747684769477047714772477347744775477647774778477947804781478247834784478547864787478847894790479147924793479447954796479747984799480048014802480348044805480648074808480948104811481248134814481548164817481848194820482148224823482448254826482748284829483048314832483348344835483648374838483948404841484248434844484548464847484848494850485148524853485448554856485748584859486048614862486348644865486648674868486948704871487248734874487548764877487848794880488148824883488448854886488748884889489048914892489348944895489648974898489949004901490249034904490549064907490849094910491149124913491449154916491749184919492049214922492349244925492649274928492949304931493249334934493549364937493849394940494149424943494449454946494749484949495049514952495349544955495649574958495949604961496249634964496549664967496849694970497149724973497449754976497749784979498049814982498349844985498649874988498949904991499249934994499549964997499849995000500150025003500450055006500750085009501050115012501350145015501650175018501950205021502250235024502550265027502850295030503150325033503450355036503750385039504050415042504350445045504650475048504950505051505250535054505550565057505850595060506150625063506450655066506750685069507050715072507350745075507650775078507950805081508250835084508550865087508850895090509150925093509450955096509750985099510051015102510351045105510651075108510951105111511251135114511551165117511851195120512151225123512451255126512751285129513051315132513351345135513651375138513951405141514251435144514551465147514851495150515151525153515451555156515751585159516051615162516351645165516651675168516951705171517251735174517551765177517851795180518151825183518451855186518751885189519051915192519351945195519651975198519952005201520252035204520552065207520852095210521152125213521452155216521752185219522052215222522352245225522652275228522952305231523252335234523552365237523852395240524152425243524452455246524752485249525052515252525352545255525652575258525952605261526252635264526552665267526852695270527152725273527452755276527752785279528052815282528352845285528652875288528952905291529252935294529552965297529852995300530153025303530453055306530753085309531053115312531353145315531653175318531953205321532253235324532553265327532853295330533153325333533453355336533753385339534053415342534353445345534653475348534953505351535253535354535553565357535853595360536153625363536453655366536753685369537053715372537353745375537653775378537953805381538253835384538553865387538853895390539153925393539453955396539753985399540054015402540354045405540654075408540954105411541254135414541554165417541854195420542154225423542454255426542754285429543054315432543354345435543654375438543954405441544254435444544554465447544854495450545154525453545454555456545754585459546054615462546354645465546654675468546954705471547254735474547554765477547854795480548154825483548454855486548754885489549054915492549354945495549654975498549955005501550255035504550555065507550855095510551155125513551455155516551755185519552055215522552355245525552655275528552955305531553255335534553555365537553855395540554155425543554455455546554755485549555055515552555355545555555655575558555955605561556255635564556555665567556855695570557155725573557455755576557755785579558055815582558355845585558655875588558955905591559255935594559555965597559855995600560156025603560456055606560756085609561056115612561356145615561656175618561956205621562256235624562556265627562856295630563156325633563456355636563756385639564056415642564356445645564656475648564956505651565256535654565556565657565856595660566156625663566456655666566756685669567056715672567356745675567656775678567956805681568256835684568556865687568856895690569156925693569456955696569756985699570057015702570357045705570657075708
  1. /**
  2. * Resolution Module Tests
  3. *
  4. * Tests for Phase 3: Reference Resolution
  5. */
  6. import { describe, it, expect, beforeEach, afterEach } from 'vitest';
  7. import * as fs from 'fs';
  8. import * as path from 'path';
  9. import * as os from 'os';
  10. import { CodeGraph } from '../src';
  11. import { Node, UnresolvedReference } from '../src/types';
  12. import { ReferenceResolver, createResolver, ResolutionContext } from '../src/resolution';
  13. import { matchReference, resolveMethodOnType, matchByQualifiedName, matchByExactName, preferCallSiteFile, matchMethodCall } from '../src/resolution/name-matcher';
  14. import { resolveImportPath, extractImportMappings, resolveJvmImport, loadCppIncludeDirs, clearCppIncludeDirCache, isPhpIncludePathRef } from '../src/resolution/import-resolver';
  15. import type { UnresolvedRef } from '../src/resolution/types';
  16. import { detectFrameworks, getAllFrameworkResolvers } from '../src/resolution/frameworks';
  17. import { QueryBuilder } from '../src/db/queries';
  18. import { DatabaseConnection } from '../src/db';
  19. describe('Resolution Module', () => {
  20. let tempDir: string;
  21. let cg: CodeGraph;
  22. beforeEach(() => {
  23. // Create temp directory
  24. tempDir = fs.mkdtempSync(path.join(os.tmpdir(), 'codegraph-resolution-test-'));
  25. });
  26. afterEach(() => {
  27. // Clean up
  28. if (cg) {
  29. cg.destroy();
  30. } else if (fs.existsSync(tempDir)) {
  31. fs.rmSync(tempDir, { recursive: true });
  32. }
  33. });
  34. describe('Name Matcher', () => {
  35. it('should match exact name references', () => {
  36. // Create a mock context
  37. const mockNodes: Node[] = [
  38. {
  39. id: 'func:test.ts:myFunction:10',
  40. kind: 'function',
  41. name: 'myFunction',
  42. qualifiedName: 'test.ts::myFunction',
  43. filePath: 'test.ts',
  44. language: 'typescript',
  45. startLine: 10,
  46. endLine: 20,
  47. startColumn: 0,
  48. endColumn: 0,
  49. updatedAt: Date.now(),
  50. },
  51. ];
  52. const context: ResolutionContext = {
  53. getNodesInFile: () => mockNodes,
  54. getNodesByName: (name) => mockNodes.filter((n) => n.name === name),
  55. getNodesByQualifiedName: () => [],
  56. getNodesByKind: () => [],
  57. fileExists: () => true,
  58. readFile: () => null,
  59. getProjectRoot: () => '/test',
  60. getAllFiles: () => ['test.ts'],
  61. };
  62. const ref = {
  63. fromNodeId: 'caller:main.ts:caller:5',
  64. referenceName: 'myFunction',
  65. referenceKind: 'calls' as const,
  66. line: 5,
  67. column: 10,
  68. filePath: 'main.ts',
  69. language: 'typescript' as const,
  70. };
  71. const result = matchReference(ref, context);
  72. expect(result).not.toBeNull();
  73. expect(result?.targetNodeId).toBe('func:test.ts:myFunction:10');
  74. expect(result?.resolvedBy).toBe('exact-match');
  75. });
  76. it('should resolve Erlang -behaviour refs only to module namespaces', () => {
  77. // On emqx, `-behaviour(supervisor)` (OTP behaviour, not in the repo)
  78. // fell through to bare-name matching and resolved to a
  79. // `-define(supervisor, ...)` macro constant in an unrelated app.
  80. const macroConstant: Node = {
  81. id: 'constant:apps/bridge/src/impl.erl:supervisor:61',
  82. kind: 'constant',
  83. name: 'supervisor',
  84. qualifiedName: 'impl::supervisor',
  85. filePath: 'apps/bridge/src/impl.erl',
  86. language: 'erlang',
  87. startLine: 61,
  88. endLine: 61,
  89. startColumn: 0,
  90. endColumn: 0,
  91. updatedAt: Date.now(),
  92. };
  93. const behaviourModule: Node = {
  94. id: 'namespace:src/my_behaviour.erl:my_behaviour:1',
  95. kind: 'namespace',
  96. name: 'my_behaviour',
  97. qualifiedName: 'my_behaviour',
  98. filePath: 'src/my_behaviour.erl',
  99. language: 'erlang',
  100. startLine: 1,
  101. endLine: 1,
  102. startColumn: 0,
  103. endColumn: 0,
  104. updatedAt: Date.now(),
  105. };
  106. const nodes = [macroConstant, behaviourModule];
  107. const context: ResolutionContext = {
  108. getNodesInFile: () => [],
  109. getNodesByName: (name) => nodes.filter((n) => n.name === name),
  110. getNodesByQualifiedName: () => [],
  111. getNodesByKind: () => [],
  112. fileExists: () => false,
  113. readFile: () => null,
  114. getProjectRoot: () => '/test',
  115. getAllFiles: () => [],
  116. getNodesByLowerName: () => [],
  117. getImportMappings: () => [],
  118. };
  119. const mkRef = (name: string) => ({
  120. fromNodeId: 'namespace:src/worker.erl:worker:1',
  121. referenceName: name,
  122. referenceKind: 'implements' as const,
  123. line: 2,
  124. column: 0,
  125. filePath: 'src/worker.erl',
  126. language: 'erlang' as const,
  127. });
  128. // Out-of-repo behaviour whose name collides with a macro constant:
  129. // stays unresolved instead of linking the constant.
  130. expect(matchReference(mkRef('supervisor'), context)).toBeNull();
  131. // In-repo behaviour module resolves to its namespace.
  132. const resolved = matchReference(mkRef('my_behaviour'), context);
  133. expect(resolved?.targetNodeId).toBe(behaviourModule.id);
  134. // The same module-only rule covers refs emitted by .app/.app.src
  135. // resource files: on emqx, the `ssl` OTP app dependency resolved to a
  136. // test helper FUNCTION named ssl. A colliding non-module name stays
  137. // unresolved; a real umbrella-sibling module resolves.
  138. nodes.push({
  139. id: 'function:test/ldap_SUITE.erl:ssl:12',
  140. kind: 'function',
  141. name: 'ssl',
  142. qualifiedName: 'ldap_SUITE::ssl',
  143. filePath: 'test/ldap_SUITE.erl',
  144. language: 'erlang',
  145. startLine: 12,
  146. endLine: 14,
  147. startColumn: 0,
  148. endColumn: 0,
  149. updatedAt: Date.now(),
  150. });
  151. const appRef = (name: string) => ({
  152. fromNodeId: 'file:src/myapp.app.src',
  153. referenceName: name,
  154. referenceKind: 'imports' as const,
  155. line: 6,
  156. column: 0,
  157. filePath: 'src/myapp.app.src',
  158. language: 'erlang' as const,
  159. });
  160. expect(matchReference(appRef('ssl'), context)).toBeNull();
  161. expect(matchReference(appRef('my_behaviour'), context)?.targetNodeId).toBe(behaviourModule.id);
  162. });
  163. it('should prefer same-module candidates over cross-module matches', () => {
  164. // Simulates a Python monorepo where multiple apps define navigate()
  165. const candidateA: Node = {
  166. id: 'func:apps/app_a/src/server.py:navigate:10',
  167. kind: 'function',
  168. name: 'navigate',
  169. qualifiedName: 'apps/app_a/src/server.py::navigate',
  170. filePath: 'apps/app_a/src/server.py',
  171. language: 'python',
  172. startLine: 10,
  173. endLine: 20,
  174. startColumn: 0,
  175. endColumn: 0,
  176. updatedAt: Date.now(),
  177. };
  178. const candidateB: Node = {
  179. id: 'func:apps/app_b/src/server.py:navigate:15',
  180. kind: 'function',
  181. name: 'navigate',
  182. qualifiedName: 'apps/app_b/src/server.py::navigate',
  183. filePath: 'apps/app_b/src/server.py',
  184. language: 'python',
  185. startLine: 15,
  186. endLine: 25,
  187. startColumn: 0,
  188. endColumn: 0,
  189. updatedAt: Date.now(),
  190. };
  191. const context: ResolutionContext = {
  192. getNodesInFile: () => [],
  193. getNodesByName: (name) => name === 'navigate' ? [candidateA, candidateB] : [],
  194. getNodesByQualifiedName: () => [],
  195. getNodesByKind: () => [],
  196. fileExists: () => true,
  197. readFile: () => null,
  198. getProjectRoot: () => '/test',
  199. getAllFiles: () => [],
  200. getNodesByLowerName: () => [],
  201. getImportMappings: () => [],
  202. };
  203. // Reference from app_a should resolve to app_a's navigate, not app_b's
  204. const ref = {
  205. fromNodeId: 'func:apps/app_a/src/handler.py:handler:5',
  206. referenceName: 'navigate',
  207. referenceKind: 'calls' as const,
  208. line: 5,
  209. column: 10,
  210. filePath: 'apps/app_a/src/handler.py',
  211. language: 'python' as const,
  212. };
  213. const result = matchReference(ref, context);
  214. expect(result).not.toBeNull();
  215. expect(result?.targetNodeId).toBe('func:apps/app_a/src/server.py:navigate:10');
  216. expect(result?.resolvedBy).toBe('exact-match');
  217. });
  218. it('should lower confidence for cross-module exact matches', () => {
  219. // Only one candidate but in a completely different module
  220. const candidates: Node[] = [
  221. {
  222. id: 'func:apps/app_b/src/server.py:navigate:10',
  223. kind: 'function',
  224. name: 'navigate',
  225. qualifiedName: 'apps/app_b/src/server.py::navigate',
  226. filePath: 'apps/app_b/src/server.py',
  227. language: 'python',
  228. startLine: 10,
  229. endLine: 20,
  230. startColumn: 0,
  231. endColumn: 0,
  232. updatedAt: Date.now(),
  233. },
  234. {
  235. id: 'func:apps/app_c/src/server.py:navigate:10',
  236. kind: 'function',
  237. name: 'navigate',
  238. qualifiedName: 'apps/app_c/src/server.py::navigate',
  239. filePath: 'apps/app_c/src/server.py',
  240. language: 'python',
  241. startLine: 10,
  242. endLine: 20,
  243. startColumn: 0,
  244. endColumn: 0,
  245. updatedAt: Date.now(),
  246. },
  247. ];
  248. const context: ResolutionContext = {
  249. getNodesInFile: () => [],
  250. getNodesByName: (name) => name === 'navigate' ? candidates : [],
  251. getNodesByQualifiedName: () => [],
  252. getNodesByKind: () => [],
  253. fileExists: () => true,
  254. readFile: () => null,
  255. getProjectRoot: () => '/test',
  256. getAllFiles: () => [],
  257. getNodesByLowerName: () => [],
  258. getImportMappings: () => [],
  259. };
  260. // Reference from app_a — neither candidate is in the same module
  261. const ref = {
  262. fromNodeId: 'func:apps/app_a/src/handler.py:handler:5',
  263. referenceName: 'navigate',
  264. referenceKind: 'calls' as const,
  265. line: 5,
  266. column: 10,
  267. filePath: 'apps/app_a/src/handler.py',
  268. language: 'python' as const,
  269. };
  270. const result = matchReference(ref, context);
  271. // Should still resolve but with low confidence
  272. expect(result).not.toBeNull();
  273. expect(result?.confidence).toBeLessThanOrEqual(0.4);
  274. });
  275. it('should match qualified name references', () => {
  276. const mockClassNode: Node = {
  277. id: 'class:user.ts:User:5',
  278. kind: 'class',
  279. name: 'User',
  280. qualifiedName: 'user.ts::User',
  281. filePath: 'user.ts',
  282. language: 'typescript',
  283. startLine: 5,
  284. endLine: 30,
  285. startColumn: 0,
  286. endColumn: 0,
  287. updatedAt: Date.now(),
  288. };
  289. const mockMethodNode: Node = {
  290. id: 'method:user.ts:User.save:15',
  291. kind: 'method',
  292. name: 'save',
  293. qualifiedName: 'user.ts::User::save',
  294. filePath: 'user.ts',
  295. language: 'typescript',
  296. startLine: 15,
  297. endLine: 25,
  298. startColumn: 0,
  299. endColumn: 0,
  300. updatedAt: Date.now(),
  301. };
  302. const context: ResolutionContext = {
  303. getNodesInFile: (fp) => fp === 'user.ts' ? [mockClassNode, mockMethodNode] : [],
  304. getNodesByName: (name) => {
  305. if (name === 'User') return [mockClassNode];
  306. if (name === 'save') return [mockMethodNode];
  307. return [];
  308. },
  309. getNodesByQualifiedName: (qn) => {
  310. if (qn === 'user.ts::User::save') return [mockMethodNode];
  311. return [];
  312. },
  313. getNodesByKind: () => [],
  314. fileExists: () => true,
  315. readFile: () => null,
  316. getProjectRoot: () => '/test',
  317. getAllFiles: () => ['user.ts'],
  318. };
  319. const ref = {
  320. fromNodeId: 'caller:main.ts:main:5',
  321. referenceName: 'User.save',
  322. referenceKind: 'calls' as const,
  323. line: 5,
  324. column: 10,
  325. filePath: 'main.ts',
  326. language: 'typescript' as const,
  327. };
  328. const result = matchReference(ref, context);
  329. expect(result).not.toBeNull();
  330. expect(result?.targetNodeId).toBe('method:user.ts:User.save:15');
  331. });
  332. });
  333. describe('Ubiquitous-name ceiling (#999)', () => {
  334. // A vendored theme/SDK re-declares the same method name across thousands of
  335. // files (Metronic's `init`/`update`/… on every widget). The fuzzy strategies
  336. // used to score every same-named candidate per ref — O(K) per ref, O(K²)
  337. // total — which pinned a core for 15-28 min at "Resolving refs … 94%". Above
  338. // the ceiling they must DECLINE instead, since no proximity/word-overlap
  339. // score can pick the one true target among thousands anyway.
  340. const CEILING = 500;
  341. // A spy context: counts how many nodes the strategy actually inspects, so we
  342. // can assert the cap short-circuits BEFORE the O(K) scoring (not just that it
  343. // returns null).
  344. const makeManyMethods = (n: number, name: string): Node[] =>
  345. Array.from({ length: n }, (_, i) => ({
  346. id: `method:widget${i}.js:Widget${i}.${name}:1`,
  347. kind: 'method' as const,
  348. name,
  349. qualifiedName: `widget${i}.js::Widget${i}::${name}`,
  350. filePath: `static/theme/widget${i}.js`,
  351. language: 'javascript' as const,
  352. startLine: 1,
  353. endLine: 5,
  354. startColumn: 0,
  355. endColumn: 0,
  356. updatedAt: Date.now(),
  357. }));
  358. const spyContext = (nodes: Node[]): { ctx: ResolutionContext; lookups: () => number } => {
  359. let scanned = 0;
  360. const ctx: ResolutionContext = {
  361. getNodesInFile: () => [],
  362. getNodesByName: (name) => {
  363. const hit = nodes.filter((n) => n.name === name);
  364. scanned += hit.length;
  365. return hit;
  366. },
  367. getNodesByQualifiedName: () => [],
  368. getNodesByKind: () => [],
  369. fileExists: () => true,
  370. readFile: () => null,
  371. getProjectRoot: () => '/test',
  372. getAllFiles: () => [],
  373. getNodesByLowerName: () => [],
  374. getImportMappings: () => [],
  375. };
  376. return { ctx, lookups: () => scanned };
  377. };
  378. it('declines a method call (`obj.init`) above the ceiling instead of scoring K candidates', () => {
  379. const { ctx } = spyContext(makeManyMethods(CEILING + 1, 'init'));
  380. const ref = {
  381. fromNodeId: 'method:caller.js:caller:1',
  382. referenceName: 'widget.init',
  383. referenceKind: 'calls' as const,
  384. line: 2,
  385. column: 4,
  386. filePath: 'static/theme/caller.js',
  387. language: 'javascript' as const,
  388. };
  389. expect(matchReference(ref, ctx)).toBeNull();
  390. });
  391. it('declines a bare exact-name ref above the ceiling', () => {
  392. const { ctx } = spyContext(makeManyMethods(CEILING + 1, 'render'));
  393. const ref = {
  394. fromNodeId: 'method:caller.js:caller:1',
  395. referenceName: 'render',
  396. referenceKind: 'calls' as const,
  397. line: 2,
  398. column: 4,
  399. filePath: 'static/theme/caller.js',
  400. language: 'javascript' as const,
  401. };
  402. expect(matchReference(ref, ctx)).toBeNull();
  403. });
  404. it('still resolves a SAME-FILE definition when one exists (precise path unaffected)', () => {
  405. // Strategy 1 (class-name) and same-file matching are precise — a ubiquitous
  406. // name with an unambiguous local target still resolves.
  407. const nodes = makeManyMethods(CEILING + 1, 'init');
  408. const local: Node = {
  409. id: 'class:static/theme/caller.js:Widgetly:1',
  410. kind: 'class',
  411. name: 'Widgetly',
  412. qualifiedName: 'static/theme/caller.js::Widgetly',
  413. filePath: 'static/theme/caller.js',
  414. language: 'javascript',
  415. startLine: 1, endLine: 9, startColumn: 0, endColumn: 0, updatedAt: Date.now(),
  416. };
  417. const localMethod: Node = {
  418. id: 'method:static/theme/caller.js:Widgetly.init:2',
  419. kind: 'method',
  420. name: 'init',
  421. qualifiedName: 'static/theme/caller.js::Widgetly::init',
  422. filePath: 'static/theme/caller.js',
  423. language: 'javascript',
  424. startLine: 2, endLine: 4, startColumn: 0, endColumn: 0, updatedAt: Date.now(),
  425. };
  426. const all = [...nodes, local, localMethod];
  427. const ctx: ResolutionContext = {
  428. getNodesInFile: (fp) => all.filter((n) => n.filePath === fp),
  429. getNodesByName: (name) => all.filter((n) => n.name === name),
  430. getNodesByQualifiedName: () => [],
  431. getNodesByKind: () => [],
  432. fileExists: () => true,
  433. readFile: () => null,
  434. getProjectRoot: () => '/test',
  435. getAllFiles: () => [],
  436. getNodesByLowerName: () => [],
  437. getImportMappings: () => [],
  438. };
  439. // `Widgetly.init` names the class explicitly → Strategy 1 resolves it.
  440. const ref = {
  441. fromNodeId: 'method:static/theme/caller.js:caller:6',
  442. referenceName: 'Widgetly.init',
  443. referenceKind: 'calls' as const,
  444. line: 6,
  445. column: 4,
  446. filePath: 'static/theme/caller.js',
  447. language: 'javascript' as const,
  448. };
  449. const result = matchReference(ref, ctx);
  450. expect(result?.targetNodeId).toBe('method:static/theme/caller.js:Widgetly.init:2');
  451. });
  452. it('still scores normally JUST below the ceiling (no behavior change for normal repos)', () => {
  453. // Real repos top out near ~40 same-named methods; this proves a sub-ceiling
  454. // collision still resolves via proximity, so the cap is invisible to them.
  455. const nodes = makeManyMethods(CEILING - 1, 'update');
  456. // Make ONE candidate share the caller's directory so proximity picks it.
  457. nodes[0] = {
  458. ...nodes[0]!,
  459. id: 'method:static/theme/app/Widget0.update:1',
  460. qualifiedName: 'static/theme/app/widget.js::Widget0::update',
  461. filePath: 'static/theme/app/widget.js',
  462. };
  463. const ctx: ResolutionContext = {
  464. getNodesInFile: () => [],
  465. getNodesByName: (name) => nodes.filter((n) => n.name === name),
  466. getNodesByQualifiedName: () => [],
  467. getNodesByKind: () => [],
  468. fileExists: () => true,
  469. readFile: () => null,
  470. getProjectRoot: () => '/test',
  471. getAllFiles: () => [],
  472. getNodesByLowerName: () => [],
  473. getImportMappings: () => [],
  474. };
  475. const ref = {
  476. fromNodeId: 'method:static/theme/app/caller.js:caller:1',
  477. referenceName: 'update',
  478. referenceKind: 'calls' as const,
  479. line: 2,
  480. column: 4,
  481. filePath: 'static/theme/app/caller.js',
  482. language: 'javascript' as const,
  483. };
  484. // Below the ceiling the fuzzy path runs and resolves SOMETHING (not capped).
  485. expect(matchReference(ref, ctx)).not.toBeNull();
  486. });
  487. });
  488. describe('Import Resolver', () => {
  489. it('should resolve relative import paths', () => {
  490. const context: ResolutionContext = {
  491. getNodesInFile: () => [],
  492. getNodesByName: () => [],
  493. getNodesByQualifiedName: () => [],
  494. getNodesByKind: () => [],
  495. fileExists: (p) => p === 'src/components/utils.ts' || p === 'src/components/utils/index.ts',
  496. readFile: () => null,
  497. getProjectRoot: () => '',
  498. getAllFiles: () => ['src/components/utils.ts', 'src/components/utils/index.ts'],
  499. };
  500. const result = resolveImportPath(
  501. './utils',
  502. 'src/components/Button.ts',
  503. 'typescript',
  504. context
  505. );
  506. expect(result).toBe('src/components/utils.ts');
  507. });
  508. it('should resolve parent directory imports', () => {
  509. const context: ResolutionContext = {
  510. getNodesInFile: () => [],
  511. getNodesByName: () => [],
  512. getNodesByQualifiedName: () => [],
  513. getNodesByKind: () => [],
  514. fileExists: (p) => p === 'src/helpers.ts' || p === 'src/helpers/index.ts',
  515. readFile: () => null,
  516. getProjectRoot: () => '',
  517. getAllFiles: () => ['src/helpers.ts', 'src/helpers/index.ts'],
  518. };
  519. const result = resolveImportPath(
  520. '../helpers',
  521. 'src/components/Button.ts',
  522. 'typescript',
  523. context
  524. );
  525. expect(result).toBe('src/helpers.ts');
  526. });
  527. it('should extract JS/TS import mappings', () => {
  528. const content = `
  529. import { foo } from './foo';
  530. import bar from '../bar';
  531. import * as utils from './utils';
  532. import { baz, qux } from './baz';
  533. `;
  534. const mappings = extractImportMappings(
  535. 'src/index.ts',
  536. content,
  537. 'typescript'
  538. );
  539. expect(mappings.length).toBeGreaterThan(0);
  540. expect(mappings.some((m) => m.localName === 'foo')).toBe(true);
  541. expect(mappings.some((m) => m.localName === 'bar')).toBe(true);
  542. });
  543. it('should extract Python import mappings', () => {
  544. const content = `
  545. from utils import helper
  546. from .models import User
  547. import os
  548. from ..services import auth_service
  549. `;
  550. const mappings = extractImportMappings(
  551. 'src/main.py',
  552. content,
  553. 'python'
  554. );
  555. expect(mappings.length).toBeGreaterThan(0);
  556. expect(mappings.some((m) => m.localName === 'helper')).toBe(true);
  557. expect(mappings.some((m) => m.localName === 'User')).toBe(true);
  558. });
  559. });
  560. describe('JVM FQN Import Resolution', () => {
  561. // Build a ResolutionContext stub whose getNodesByQualifiedName answers
  562. // from a fixed table — the only context method resolveJvmImport touches.
  563. const makeContext = (byQName: Record<string, Node[]>): ResolutionContext => ({
  564. getNodesInFile: () => [],
  565. getNodesByName: () => [],
  566. getNodesByQualifiedName: (q) => byQName[q] ?? [],
  567. getNodesByKind: () => [],
  568. fileExists: () => false,
  569. readFile: () => null,
  570. getProjectRoot: () => '',
  571. getAllFiles: () => [],
  572. });
  573. const node = (id: string, name: string, qualifiedName: string, kind: Node['kind'] = 'class', language: Node['language'] = 'kotlin'): Node => ({
  574. id, kind, name, qualifiedName,
  575. filePath: 'Models.kt', language,
  576. startLine: 1, endLine: 1, startColumn: 0, endColumn: 0,
  577. updatedAt: 0,
  578. });
  579. const importRef = (referenceName: string, language: Node['language'] = 'kotlin'): UnresolvedRef => ({
  580. fromNodeId: 'caller',
  581. referenceName,
  582. referenceKind: 'imports',
  583. line: 1, column: 0,
  584. filePath: 'Caller.kt',
  585. language,
  586. });
  587. it('resolves a Kotlin class import by FQN regardless of filename', () => {
  588. const target = node('n1', 'Bar', 'com.example.foo::Bar');
  589. const ctx = makeContext({ 'com.example.foo::Bar': [target] });
  590. const result = resolveJvmImport(importRef('com.example.foo.Bar'), ctx);
  591. expect(result?.targetNodeId).toBe('n1');
  592. expect(result?.resolvedBy).toBe('import');
  593. });
  594. it('resolves a Kotlin top-level function import by FQN', () => {
  595. const util = node('n2', 'util', 'com.example.foo::util', 'function');
  596. const ctx = makeContext({ 'com.example.foo::util': [util] });
  597. const result = resolveJvmImport(importRef('com.example.foo.util'), ctx);
  598. expect(result?.targetNodeId).toBe('n2');
  599. });
  600. it('resolves a Java import by FQN', () => {
  601. const target = node('n3', 'Bar', 'com.example.foo::Bar', 'class', 'java');
  602. const ctx = makeContext({ 'com.example.foo::Bar': [target] });
  603. const result = resolveJvmImport(importRef('com.example.foo.Bar', 'java'), ctx);
  604. expect(result?.targetNodeId).toBe('n3');
  605. });
  606. it('resolves cross-language: Kotlin importing a Java class', () => {
  607. // The Kotlin file declares `import com.example.JavaBar` — the target is
  608. // a Java class node. JVM interop means the resolver doesn't care about
  609. // the source language of the target, only that the FQN matches.
  610. const target = node('n4', 'JavaBar', 'com.example::JavaBar', 'class', 'java');
  611. const ctx = makeContext({ 'com.example::JavaBar': [target] });
  612. const result = resolveJvmImport(importRef('com.example.JavaBar'), ctx);
  613. expect(result?.targetNodeId).toBe('n4');
  614. });
  615. it('disambiguates a name collision across packages', () => {
  616. // Two classes named `Bar` in different packages. Each import resolves
  617. // to the one whose FQN matches — not to "whichever was found first".
  618. const barA = node('n5a', 'Bar', 'com.example.alpha::Bar');
  619. const barB = node('n5b', 'Bar', 'com.example.beta::Bar');
  620. const ctx = makeContext({
  621. 'com.example.alpha::Bar': [barA],
  622. 'com.example.beta::Bar': [barB],
  623. });
  624. expect(resolveJvmImport(importRef('com.example.alpha.Bar'), ctx)?.targetNodeId).toBe('n5a');
  625. expect(resolveJvmImport(importRef('com.example.beta.Bar'), ctx)?.targetNodeId).toBe('n5b');
  626. });
  627. it('returns null for wildcard imports', () => {
  628. const ctx = makeContext({});
  629. expect(resolveJvmImport(importRef('com.example.foo.*'), ctx)).toBeNull();
  630. });
  631. it('returns null for unqualified names', () => {
  632. // A single-segment name has no package; nothing to look up by FQN.
  633. const ctx = makeContext({ 'Bar': [node('n6', 'Bar', 'Bar')] });
  634. expect(resolveJvmImport(importRef('Bar'), ctx)).toBeNull();
  635. });
  636. it('returns null for non-JVM languages', () => {
  637. const target = node('n7', 'Bar', 'com.example::Bar');
  638. const ctx = makeContext({ 'com.example::Bar': [target] });
  639. expect(resolveJvmImport(importRef('com.example.Bar', 'typescript'), ctx)).toBeNull();
  640. });
  641. it('returns null for non-imports reference kinds', () => {
  642. // The resolver intentionally only acts on `imports` refs; ordinary
  643. // `calls`/`extends` refs fall through to the framework + name-matcher
  644. // strategies.
  645. const target = node('n8', 'Bar', 'com.example::Bar');
  646. const ctx = makeContext({ 'com.example::Bar': [target] });
  647. const ref: UnresolvedRef = {
  648. fromNodeId: 'caller', referenceName: 'com.example.Bar',
  649. referenceKind: 'calls', line: 1, column: 0,
  650. filePath: 'Caller.kt', language: 'kotlin',
  651. };
  652. expect(resolveJvmImport(ref, ctx)).toBeNull();
  653. });
  654. it('returns null when the FQN is not in the index', () => {
  655. const ctx = makeContext({});
  656. expect(resolveJvmImport(importRef('com.example.Unknown'), ctx)).toBeNull();
  657. });
  658. });
  659. describe('Framework Detection', () => {
  660. it('should detect React framework', () => {
  661. const context: ResolutionContext = {
  662. getNodesInFile: () => [],
  663. getNodesByName: () => [],
  664. getNodesByQualifiedName: () => [],
  665. getNodesByKind: () => [],
  666. fileExists: () => false,
  667. readFile: (p) => {
  668. if (p === 'package.json') {
  669. return JSON.stringify({
  670. dependencies: { react: '^18.0.0' },
  671. });
  672. }
  673. return null;
  674. },
  675. getProjectRoot: () => '/test',
  676. getAllFiles: () => ['package.json', 'src/App.tsx'],
  677. };
  678. const frameworks = detectFrameworks(context);
  679. expect(frameworks.some((f) => f.name === 'react')).toBe(true);
  680. });
  681. it('should detect Express framework', () => {
  682. const context: ResolutionContext = {
  683. getNodesInFile: () => [],
  684. getNodesByName: () => [],
  685. getNodesByQualifiedName: () => [],
  686. getNodesByKind: () => [],
  687. fileExists: () => false,
  688. readFile: (p) => {
  689. if (p === 'package.json') {
  690. return JSON.stringify({
  691. dependencies: { express: '^4.18.0' },
  692. });
  693. }
  694. return null;
  695. },
  696. getProjectRoot: () => '/test',
  697. getAllFiles: () => ['package.json', 'src/app.js'],
  698. };
  699. const frameworks = detectFrameworks(context);
  700. expect(frameworks.some((f) => f.name === 'express')).toBe(true);
  701. });
  702. it('should detect Laravel framework', () => {
  703. const context: ResolutionContext = {
  704. getNodesInFile: () => [],
  705. getNodesByName: () => [],
  706. getNodesByQualifiedName: () => [],
  707. getNodesByKind: () => [],
  708. fileExists: (p) => p === 'artisan',
  709. readFile: () => null,
  710. getProjectRoot: () => '/test',
  711. getAllFiles: () => ['artisan', 'app/Http/Kernel.php'],
  712. };
  713. const frameworks = detectFrameworks(context);
  714. expect(frameworks.some((f) => f.name === 'laravel')).toBe(true);
  715. });
  716. it('should return all framework resolvers', () => {
  717. const resolvers = getAllFrameworkResolvers();
  718. expect(resolvers.length).toBeGreaterThan(0);
  719. expect(resolvers.some((r) => r.name === 'react')).toBe(true);
  720. expect(resolvers.some((r) => r.name === 'express')).toBe(true);
  721. expect(resolvers.some((r) => r.name === 'laravel')).toBe(true);
  722. });
  723. });
  724. describe('React Framework Resolver', () => {
  725. it('should resolve React component references', () => {
  726. const mockNodes: Node[] = [
  727. {
  728. id: 'component:src/Button.tsx:Button:5',
  729. kind: 'component',
  730. name: 'Button',
  731. qualifiedName: 'src/Button.tsx::Button',
  732. filePath: 'src/Button.tsx',
  733. language: 'tsx',
  734. startLine: 5,
  735. endLine: 20,
  736. startColumn: 0,
  737. endColumn: 0,
  738. updatedAt: Date.now(),
  739. },
  740. ];
  741. const context: ResolutionContext = {
  742. getNodesInFile: (fp) => (fp === 'src/Button.tsx' ? mockNodes : []),
  743. getNodesByName: () => mockNodes,
  744. getNodesByQualifiedName: () => [],
  745. getNodesByKind: () => [],
  746. fileExists: () => false,
  747. readFile: (p) => {
  748. if (p === 'package.json') {
  749. return JSON.stringify({ dependencies: { react: '^18.0.0' } });
  750. }
  751. return null;
  752. },
  753. getProjectRoot: () => '/test',
  754. getAllFiles: () => ['package.json', 'src/Button.tsx', 'src/App.tsx'],
  755. };
  756. const frameworks = detectFrameworks(context);
  757. const reactResolver = frameworks.find((f) => f.name === 'react');
  758. expect(reactResolver).toBeDefined();
  759. const ref = {
  760. fromNodeId: 'component:src/App.tsx:App:1',
  761. referenceName: 'Button',
  762. referenceKind: 'renders' as const,
  763. line: 10,
  764. column: 5,
  765. filePath: 'src/App.tsx',
  766. // Refs extracted from .tsx files carry language 'tsx' — component
  767. // resolution is gated to JSX-capable refs (#764: PascalCase TYPE refs
  768. // from plain .ts files were resolving to arbitrary same-named classes).
  769. language: 'tsx' as const,
  770. };
  771. const result = reactResolver!.resolve(ref, context);
  772. expect(result).not.toBeNull();
  773. expect(result?.targetNodeId).toBe('component:src/Button.tsx:Button:5');
  774. // The same PascalCase name referenced from a plain .ts file is a TYPE
  775. // reference, not a component usage — component resolution must decline
  776. // and leave it to proximity-aware name matching (#764: a .ts GraphQL
  777. // types file's own `Account` alias was losing to an arbitrary same-named
  778. // class in another monorepo package).
  779. const tsRef = { ...ref, filePath: 'src/models.ts', language: 'typescript' as const };
  780. expect(reactResolver!.resolve(tsRef, context)).toBeNull();
  781. });
  782. it('should resolve custom hook references', () => {
  783. const mockNodes: Node[] = [
  784. {
  785. id: 'hook:src/hooks/useAuth.ts:useAuth:1',
  786. kind: 'function',
  787. name: 'useAuth',
  788. qualifiedName: 'src/hooks/useAuth.ts::useAuth',
  789. filePath: 'src/hooks/useAuth.ts',
  790. language: 'typescript',
  791. startLine: 1,
  792. endLine: 20,
  793. startColumn: 0,
  794. endColumn: 0,
  795. updatedAt: Date.now(),
  796. },
  797. ];
  798. const context: ResolutionContext = {
  799. getNodesInFile: (fp) => (fp.includes('useAuth') ? mockNodes : []),
  800. getNodesByName: () => mockNodes,
  801. getNodesByQualifiedName: () => [],
  802. getNodesByKind: () => [],
  803. fileExists: () => false,
  804. readFile: (p) => {
  805. if (p === 'package.json') {
  806. return JSON.stringify({ dependencies: { react: '^18.0.0' } });
  807. }
  808. return null;
  809. },
  810. getProjectRoot: () => '/test',
  811. getAllFiles: () => ['package.json', 'src/hooks/useAuth.ts'],
  812. };
  813. const frameworks = detectFrameworks(context);
  814. const reactResolver = frameworks.find((f) => f.name === 'react');
  815. const ref = {
  816. fromNodeId: 'component:src/App.tsx:App:1',
  817. referenceName: 'useAuth',
  818. referenceKind: 'calls' as const,
  819. line: 5,
  820. column: 10,
  821. filePath: 'src/App.tsx',
  822. language: 'typescript' as const,
  823. };
  824. const result = reactResolver!.resolve(ref, context);
  825. expect(result).not.toBeNull();
  826. expect(result?.targetNodeId).toBe('hook:src/hooks/useAuth.ts:useAuth:1');
  827. });
  828. });
  829. describe('Integration Tests', () => {
  830. it('should create resolver from CodeGraph instance', async () => {
  831. // Create a simple TypeScript project
  832. fs.writeFileSync(
  833. path.join(tempDir, 'package.json'),
  834. JSON.stringify({ name: 'test', dependencies: { react: '^18.0.0' } })
  835. );
  836. const srcDir = path.join(tempDir, 'src');
  837. fs.mkdirSync(srcDir);
  838. // Create utility file
  839. fs.writeFileSync(
  840. path.join(srcDir, 'utils.ts'),
  841. `export function formatDate(date: Date): string {
  842. return date.toISOString();
  843. }
  844. export function parseDate(str: string): Date {
  845. return new Date(str);
  846. }`
  847. );
  848. // Create main file that uses utils
  849. fs.writeFileSync(
  850. path.join(srcDir, 'main.ts'),
  851. `import { formatDate, parseDate } from './utils';
  852. function processDate(input: string): string {
  853. const date = parseDate(input);
  854. return formatDate(date);
  855. }`
  856. );
  857. // Initialize and index
  858. cg = await CodeGraph.init(tempDir, { index: true });
  859. // Check that resolver detected React framework
  860. const frameworks = cg.getDetectedFrameworks();
  861. expect(frameworks).toContain('react');
  862. // Get stats to verify indexing worked
  863. const stats = cg.getStats();
  864. expect(stats.fileCount).toBe(2);
  865. expect(stats.nodeCount).toBeGreaterThan(0);
  866. });
  867. it('should resolve references after indexing', async () => {
  868. // Create a project with references
  869. const srcDir = path.join(tempDir, 'src');
  870. fs.mkdirSync(srcDir, { recursive: true });
  871. fs.writeFileSync(
  872. path.join(srcDir, 'helper.ts'),
  873. `export function helperFunction(): void {
  874. console.log('helper');
  875. }`
  876. );
  877. fs.writeFileSync(
  878. path.join(srcDir, 'main.ts'),
  879. `import { helperFunction } from './helper';
  880. function main(): void {
  881. helperFunction();
  882. }`
  883. );
  884. cg = await CodeGraph.init(tempDir, { index: true });
  885. // Run reference resolution
  886. const result = cg.resolveReferences();
  887. // Should have attempted resolution
  888. expect(result.stats.total).toBeGreaterThanOrEqual(0);
  889. });
  890. it('promotes calls→instantiates when target resolves to a class (Python)', async () => {
  891. // Python has no `new` keyword — `Foo()` is the standard
  892. // instantiation syntax. Extraction can't tell that apart from
  893. // a function call without symbol info, so it emits a `calls`
  894. // ref. Resolution promotes it to `instantiates` once the
  895. // target is known to be a class.
  896. const srcDir = path.join(tempDir, 'src');
  897. fs.mkdirSync(srcDir, { recursive: true });
  898. fs.writeFileSync(
  899. path.join(srcDir, 'app.py'),
  900. `class UserService:
  901. def __init__(self):
  902. self.db = None
  903. def bootstrap():
  904. return UserService()
  905. `
  906. );
  907. cg = await CodeGraph.init(tempDir, { index: true });
  908. cg.resolveReferences();
  909. const bootstrap = cg
  910. .getNodesByKind('function')
  911. .find((n) => n.name === 'bootstrap');
  912. expect(bootstrap).toBeDefined();
  913. const outgoing = cg.getOutgoingEdges(bootstrap!.id);
  914. const instantiates = outgoing.find((e) => e.kind === 'instantiates');
  915. expect(instantiates).toBeDefined();
  916. // Same edge must NOT also appear as a `calls` edge — promotion
  917. // replaces the kind, doesn't duplicate.
  918. const callsToUserService = outgoing.filter(
  919. (e) => e.kind === 'calls' && e.target === instantiates!.target
  920. );
  921. expect(callsToUserService).toHaveLength(0);
  922. });
  923. it('promotes calls→instantiates when target resolves to a C++ union', async () => {
  924. // `Packet()` value-initializes the union. The extractor emits a calls
  925. // reference for that expression, so resolution must preserve the
  926. // class-like promotion that unions received when they were structs.
  927. fs.writeFileSync(
  928. path.join(tempDir, 'packet.cpp'),
  929. `union Packet { unsigned int raw; };
  930. void initialize() { Packet(); }
  931. `
  932. );
  933. cg = await CodeGraph.init(tempDir, { index: true });
  934. cg.resolveReferences();
  935. const packet = cg.getNodesByKind('union').find((n) => n.name === 'Packet');
  936. const initialize = cg.getNodesByKind('function').find((n) => n.name === 'initialize');
  937. expect(packet).toBeDefined();
  938. expect(initialize).toBeDefined();
  939. const outgoing = cg.getOutgoingEdges(initialize!.id);
  940. expect(outgoing.some((e) => e.kind === 'instantiates' && e.target === packet!.id)).toBe(true);
  941. expect(outgoing.some((e) => e.kind === 'calls' && e.target === packet!.id)).toBe(false);
  942. });
  943. it('resolves a static call through an imported C++ union to its member', async () => {
  944. fs.writeFileSync(
  945. path.join(tempDir, 'ops.hpp'),
  946. `union Ops {
  947. static int run() { return 1; }
  948. };
  949. `
  950. );
  951. fs.writeFileSync(
  952. path.join(tempDir, 'main.cpp'),
  953. `#include "ops.hpp"
  954. int invoke() { return Ops::run(); }
  955. `
  956. );
  957. cg = await CodeGraph.init(tempDir, { index: true });
  958. cg.resolveReferences();
  959. const invoke = cg.getNodesByKind('function').find((n) => n.name === 'invoke');
  960. const run = cg.getNodesByKind('method').find((n) => n.name === 'run');
  961. expect(invoke).toBeDefined();
  962. expect(run).toBeDefined();
  963. const outgoing = cg.getOutgoingEdges(invoke!.id);
  964. expect(outgoing.some((e) => e.kind === 'calls' && e.target === run!.id)).toBe(true);
  965. });
  966. it('bridges a Rust trait method to a union implementor (interface-impl)', async () => {
  967. // A Rust union can `impl Trait` exactly as a struct can. Trait-dispatch
  968. // synthesis enumerates concrete kinds explicitly, so a union implementor
  969. // only becomes a candidate if `union` is in that list. Making unions
  970. // first-class nodes is not enough on its own: without this, `Reg` has an
  971. // `implements` edge and is still silently dropped from the fan-out, so
  972. // "who implements this trait" answers wrongly rather than incompletely
  973. // — the struct beside it resolves and the union does not (#1515).
  974. fs.writeFileSync(
  975. path.join(tempDir, 'lib.rs'),
  976. `pub union Reg { pub raw: u32 }
  977. pub struct Ctl { pub n: u32 }
  978. pub trait Describe { fn describe(&self) -> String; }
  979. impl Describe for Reg { fn describe(&self) -> String { "reg".into() } }
  980. impl Describe for Ctl { fn describe(&self) -> String { "ctl".into() } }
  981. `
  982. );
  983. cg = await CodeGraph.init(tempDir, { index: true });
  984. const methods = cg.getNodesByKind('method');
  985. const traitMethod = methods.find((n) => n.qualifiedName === 'Describe::describe');
  986. const unionImpl = methods.find((n) => n.qualifiedName === 'Reg::describe');
  987. const structImpl = methods.find((n) => n.qualifiedName === 'Ctl::describe');
  988. expect(traitMethod, 'trait method should be in the graph').toBeDefined();
  989. expect(unionImpl, 'union impl method should be in the graph').toBeDefined();
  990. expect(structImpl, 'struct impl method should be in the graph').toBeDefined();
  991. const synth = cg
  992. .getOutgoingEdges(traitMethod!.id)
  993. .filter((e) => e.kind === 'calls' && e.provenance === 'heuristic');
  994. const targets = new Set(synth.map((e) => e.target));
  995. // The struct implementor bridged before unions were nodes at all; it is
  996. // the control that proves the synthesizer ran for this trait.
  997. expect(targets.has(structImpl!.id), 'struct implementor should bridge').toBe(true);
  998. expect(targets.has(unionImpl!.id), 'union implementor should bridge').toBe(true);
  999. const unionEdge = synth.find((e) => e.target === unionImpl!.id);
  1000. expect(
  1001. (unionEdge!.metadata as { synthesizedBy?: string } | undefined)?.synthesizedBy
  1002. ).toBe('interface-impl');
  1003. });
  1004. it('qualifies a generic impl by its type, so trait dispatch reaches it and no edge is invented from its body (#1588)', async () => {
  1005. // `impl<T> Source for BufSource<T>`: the implementing type parses as a
  1006. // generic_type, so the old positional receiver scan picked the TRAIT.
  1007. // The impl's `read` was recorded as `Source::read` — unaddressable as
  1008. // `BufSource::read` — and, carrying the trait's name, the interface-impl
  1009. // synthesizer treated its body (`{ 0 }`, no call at all) as a second
  1010. // declaration and gave it a dispatch edge to FileSource's implementation.
  1011. fs.writeFileSync(
  1012. path.join(tempDir, 'lib.rs'),
  1013. `pub trait Source {
  1014. fn read(&mut self) -> usize;
  1015. }
  1016. pub struct FileSource { pub n: usize }
  1017. impl Source for FileSource {
  1018. fn read(&mut self) -> usize { self.n }
  1019. }
  1020. pub struct BufSource<T> { pub inner: T }
  1021. impl<T> Source for BufSource<T> {
  1022. fn read(&mut self) -> usize { 0 }
  1023. }
  1024. `
  1025. );
  1026. cg = await CodeGraph.init(tempDir, { index: true });
  1027. const methods = cg.getNodesByKind('method');
  1028. const traitDecls = methods.filter((n) => n.qualifiedName === 'Source::read');
  1029. expect(traitDecls, 'only the declaration carries the trait-qualified name').toHaveLength(1);
  1030. const traitMethod = traitDecls[0]!;
  1031. expect(traitMethod.startLine).toBe(2);
  1032. const fileImpl = methods.find((n) => n.qualifiedName === 'FileSource::read');
  1033. const bufImpl = methods.find((n) => n.qualifiedName === 'BufSource::read');
  1034. expect(fileImpl).toBeDefined();
  1035. expect(bufImpl, 'the generic impl is addressable by its type').toBeDefined();
  1036. const synth = (id: string) =>
  1037. cg.getOutgoingEdges(id).filter((e) => e.kind === 'calls' && e.provenance === 'heuristic');
  1038. // Dispatch fans out from the declaration to BOTH implementations…
  1039. const fromTrait = synth(traitMethod.id);
  1040. expect(new Set(fromTrait.map((e) => e.target))).toEqual(new Set([fileImpl!.id, bufImpl!.id]));
  1041. for (const e of fromTrait) {
  1042. expect(
  1043. (e.metadata as { synthesizedBy?: string } | undefined)?.synthesizedBy
  1044. ).toBe('interface-impl');
  1045. expect(e.line, 'registered at the declaration, never at an impl body').toBe(2);
  1046. }
  1047. // …and neither implementation body sprouts a synthesized call of its own.
  1048. expect(synth(fileImpl!.id)).toHaveLength(0);
  1049. expect(synth(bufImpl!.id)).toHaveLength(0);
  1050. });
  1051. // ── Rust `self.<field>.<method>()` receivers (#1585) ───────────────────
  1052. // A Cargo layout (Cargo.toml + src/) so `use crate::…` paths resolve.
  1053. function writeRustCrate(root: string, files: Record<string, string>): void {
  1054. fs.writeFileSync(
  1055. path.join(root, 'Cargo.toml'),
  1056. '[package]\nname = "repro"\nversion = "0.1.0"\nedition = "2021"\n'
  1057. );
  1058. fs.mkdirSync(path.join(root, 'src'), { recursive: true });
  1059. for (const [rel, content] of Object.entries(files)) {
  1060. fs.writeFileSync(path.join(root, 'src', rel), content);
  1061. }
  1062. }
  1063. const callsFrom = (qualifiedName: string) => {
  1064. const from = cg.getNodesByKind('method').find((n) => n.qualifiedName === qualifiedName);
  1065. expect(from, qualifiedName).toBeDefined();
  1066. return cg
  1067. .getOutgoingEdges(from!.id)
  1068. .filter((e) => e.kind === 'calls')
  1069. .map((e) => ({
  1070. target: cg.getNode(e.target)?.qualifiedName,
  1071. resolvedBy: (e.metadata as { resolvedBy?: string } | undefined)?.resolvedBy,
  1072. provenance: e.provenance ?? undefined, // a resolved (non-synthesized) edge stores NULL
  1073. }));
  1074. };
  1075. it("resolves `self.field.method()` to the method on the field's declared type, never to the caller itself (#1585)", async () => {
  1076. // The issue's repro: `Outer::run` forwards to `Inner::run` through the
  1077. // typed field `inner`. The call used to collapse to the bare name `run`
  1078. // and exact-match the nearest same-named method — the calling method —
  1079. // recording recursion the source does not contain.
  1080. writeRustCrate(tempDir, {
  1081. 'lib.rs': 'pub mod inner;\npub mod outer;\n',
  1082. 'inner.rs': 'pub struct Inner {\n pub n: usize,\n}\n\nimpl Inner {\n pub fn run(&mut self) {\n self.n += 1;\n }\n}\n',
  1083. 'outer.rs': 'use crate::inner::Inner;\n\npub struct Outer {\n pub inner: Inner,\n}\n\nimpl Outer {\n pub fn run(&mut self) {\n self.inner.run();\n }\n}\n',
  1084. });
  1085. cg = await CodeGraph.init(tempDir, { index: true });
  1086. expect(callsFrom('Outer::run')).toEqual([
  1087. { target: 'Inner::run', resolvedBy: 'instance-method', provenance: undefined },
  1088. ]);
  1089. });
  1090. it('leaves a `self.field.method()` call unresolved when the field type is external, instead of guessing a same-named local method', async () => {
  1091. // `its` is a std type with no project node. Before, `self.its.next()`
  1092. // became the bare `next`, which exact-matched a local `next` — the
  1093. // calling method (self-edge) or the unrelated `Other::next` decoy.
  1094. writeRustCrate(tempDir, {
  1095. 'lib.rs':
  1096. 'pub struct Scanner {\n its: std::vec::IntoIter<u8>,\n}\n\nimpl Scanner {\n pub fn next(&mut self) -> Option<u8> {\n self.its.next()\n }\n}\n\n' +
  1097. 'pub struct Other { pub n: u8 }\nimpl Other {\n pub fn next(&mut self) -> Option<u8> {\n None\n }\n}\n',
  1098. });
  1099. cg = await CodeGraph.init(tempDir, { index: true });
  1100. expect(callsFrom('Scanner::next')).toEqual([]);
  1101. });
  1102. it('looks through references and owning smart pointers, but not through containers (#1585)', async () => {
  1103. // Method-call auto-deref reaches the pointee of `Box`/`&mut`, so those
  1104. // fields resolve to `Inner::run`. `Option<Inner>` does not auto-deref —
  1105. // `self.inner.take()` is Option's method, so it must NOT become
  1106. // `Inner::take` even though Inner declares a `take` too.
  1107. writeRustCrate(tempDir, {
  1108. 'lib.rs':
  1109. 'pub struct Inner { pub n: usize }\nimpl Inner {\n pub fn run(&mut self) { self.n += 1; }\n pub fn take(&mut self) {}\n}\n\n' +
  1110. 'pub struct Boxed { inner: Box<Inner> }\nimpl Boxed {\n pub fn go(&mut self) { self.inner.run(); }\n}\n\n' +
  1111. "pub struct Borrowed<'a> { inner: &'a mut Inner }\nimpl<'a> Borrowed<'a> {\n pub fn go(&mut self) { self.inner.run(); }\n}\n\n" +
  1112. 'pub struct Optional { inner: Option<Inner> }\nimpl Optional {\n pub fn go(&mut self) { self.inner.take(); }\n}\n',
  1113. });
  1114. cg = await CodeGraph.init(tempDir, { index: true });
  1115. expect(callsFrom('Boxed::go').map((c) => c.target)).toEqual(['Inner::run']);
  1116. expect(callsFrom('Borrowed::go').map((c) => c.target)).toEqual(['Inner::run']);
  1117. expect(callsFrom('Optional::go')).toEqual([]);
  1118. });
  1119. it('leaves a call through a generic-typed field unresolved, and keeps genuine `self.method()` recursion (#1585)', async () => {
  1120. writeRustCrate(tempDir, {
  1121. 'lib.rs':
  1122. 'pub struct Inner { pub n: usize }\nimpl Inner {\n pub fn run(&mut self) {}\n}\n\n' +
  1123. 'pub struct Holder<T> { item: T }\nimpl<T> Holder<T> {\n pub fn go(&mut self) { self.item.run(); }\n}\n\n' +
  1124. 'pub struct Countdown { pub n: usize }\nimpl Countdown {\n pub fn run(&mut self) {\n if self.n > 0 {\n self.n -= 1;\n self.run();\n }\n }\n}\n',
  1125. });
  1126. cg = await CodeGraph.init(tempDir, { index: true });
  1127. // `T` names no project type: no edge, and in particular not `Inner::run`.
  1128. expect(callsFrom('Holder::go')).toEqual([]);
  1129. // A bare `self` receiver is untouched — real recursion stays a self-edge.
  1130. expect(callsFrom('Countdown::run').map((c) => c.target)).toEqual(['Countdown::run']);
  1131. });
  1132. it('resolves a trait-object field to the trait method and typed fields to the right implementation (#1585, #1588)', async () => {
  1133. // The #1588 repro's second half: `UsesFile::go` / `UsesBuf::go` each
  1134. // forward through a typed field, and a `Box<dyn Source>` field lands on
  1135. // the trait's declaration — from which the interface-impl synthesizer
  1136. // fans out to every implementation.
  1137. writeRustCrate(tempDir, {
  1138. 'lib.rs':
  1139. 'pub trait Source {\n fn read(&mut self) -> usize;\n}\n\n' +
  1140. 'pub struct FileSource { pub n: usize }\nimpl Source for FileSource {\n fn read(&mut self) -> usize { self.n }\n}\n\n' +
  1141. 'pub struct BufSource<T> { pub inner: T }\nimpl<T> Source for BufSource<T> {\n fn read(&mut self) -> usize { 0 }\n}\n\n' +
  1142. 'pub struct UsesFile { pub src: FileSource }\nimpl UsesFile {\n pub fn go(&mut self) -> usize { self.src.read() }\n}\n\n' +
  1143. 'pub struct UsesBuf { pub src: BufSource<u8> }\nimpl UsesBuf {\n pub fn go(&mut self) -> usize { self.src.read() }\n}\n\n' +
  1144. 'pub struct UsesDyn { pub src: Box<dyn Source> }\nimpl UsesDyn {\n pub fn go(&mut self) -> usize { self.src.read() }\n}\n',
  1145. });
  1146. cg = await CodeGraph.init(tempDir, { index: true });
  1147. expect(callsFrom('UsesFile::go').map((c) => c.target)).toEqual(['FileSource::read']);
  1148. expect(callsFrom('UsesBuf::go').map((c) => c.target)).toEqual(['BufSource::read']);
  1149. expect(callsFrom('UsesDyn::go').map((c) => c.target)).toEqual(['Source::read']);
  1150. // …and dispatch continues from the trait declaration to both impls.
  1151. const fanOut = callsFrom('Source::read').filter((c) => c.provenance === 'heuristic').map((c) => c.target).sort();
  1152. expect(fanOut).toEqual(['BufSource::read', 'FileSource::read']);
  1153. });
  1154. it('records instantiates for C++ stack/brace construction, targeting the class (#1035)', async () => {
  1155. // `Calculator calc(0)` (direct-init) and `Widget w{1, 2}` (brace-init)
  1156. // carry the constructor args directly on the declarator — there's no
  1157. // call/new node — so they recorded no `instantiates` edge, while heap
  1158. // `new Calculator(0)` did. Both stack forms now do.
  1159. fs.writeFileSync(
  1160. path.join(tempDir, 'm.cpp'),
  1161. `class Calculator { public: Calculator(int seed) {} int add(int a, int b){ return a+b; } };
  1162. class Widget { public: Widget(int a, int b) {} };
  1163. int runStack(int a, int b) { Calculator calc(0); return calc.add(a, b); }
  1164. int runBrace() { Widget w{1, 2}; return 0; }
  1165. int runHeap(int a, int b) { Calculator* c = new Calculator(0); return c->add(a, b); }
  1166. void noise() { int x(5); int y{6}; Calculator deferred; }
  1167. `
  1168. );
  1169. cg = await CodeGraph.init(tempDir, { index: true });
  1170. const fn = (name: string) => cg.getNodesByKind('function').find((n) => n.name === name)!;
  1171. const instTargets = (name: string) =>
  1172. cg
  1173. .getOutgoingEdges(fn(name).id)
  1174. .filter((e) => e.kind === 'instantiates')
  1175. .map((e) => cg.getNode(e.target)!);
  1176. // Direct-init (the issue) and brace-init both instantiate, targeting the
  1177. // CLASS node — not the same-named constructor method.
  1178. const stack = instTargets('runStack');
  1179. expect(stack.map((n) => `${n.kind}:${n.name}`)).toContain('class:Calculator');
  1180. expect(instTargets('runBrace').map((n) => `${n.kind}:${n.name}`)).toContain('class:Widget');
  1181. // Heap still works (regression guard).
  1182. expect(instTargets('runHeap').map((n) => `${n.kind}:${n.name}`)).toContain('class:Calculator');
  1183. // Primitives (`int x(0)`/`int y{6}`) and bare default construction
  1184. // (`Calculator deferred;`) must NOT mint an instantiates edge.
  1185. expect(instTargets('noise')).toHaveLength(0);
  1186. });
  1187. it('resolves a cross-file static method call to the method, not the class (#825)', async () => {
  1188. // `Foo.bar()` where `Foo` is an imported class must link to the static
  1189. // method `Foo::bar`, NOT to the class `Foo`. Previously the import
  1190. // resolver dropped the `.bar` member and resolved to `Foo`, which the
  1191. // calls→instantiates promotion then turned into `run instantiates Foo`,
  1192. // leaving the static method with zero callers and a hollow impact radius.
  1193. fs.writeFileSync(
  1194. path.join(tempDir, 'helpers.ts'),
  1195. `export class Foo {\n static bar(x: number) { return x + 1; }\n}\n`
  1196. );
  1197. fs.writeFileSync(
  1198. path.join(tempDir, 'caller.ts'),
  1199. `import { Foo } from './helpers';\nexport function run() { return Foo.bar(41); }\n`
  1200. );
  1201. cg = await CodeGraph.init(tempDir, { index: true });
  1202. cg.resolveReferences();
  1203. const bar = cg.getNodesByKind('method').find((n) => n.name === 'bar');
  1204. const foo = cg.getNodesByKind('class').find((n) => n.name === 'Foo');
  1205. const run = cg.getNodesByKind('function').find((n) => n.name === 'run');
  1206. expect(bar).toBeDefined();
  1207. expect(foo).toBeDefined();
  1208. expect(run).toBeDefined();
  1209. // `run` is reported as a caller of the static method `Foo.bar`.
  1210. const barCallers = cg.getCallers(bar!.id).map((c) => c.node.name);
  1211. expect(barCallers).toContain('run');
  1212. // And the call is NOT mis-promoted to `run instantiates Foo`.
  1213. const outgoing = cg.getOutgoingEdges(run!.id);
  1214. expect(
  1215. outgoing.filter((e) => e.kind === 'instantiates' && e.target === foo!.id)
  1216. ).toHaveLength(0);
  1217. // The real edge is a `calls` edge to the method.
  1218. expect(
  1219. outgoing.some((e) => e.kind === 'calls' && e.target === bar!.id)
  1220. ).toBe(true);
  1221. });
  1222. it('resolves Go cross-package qualified calls via go.mod module path (#388)', async () => {
  1223. // Pre-#388, every `pkga.FuncX(...)` call in a Go monorepo was flagged
  1224. // external (isExternalImport returned true for any non-`/internal/`
  1225. // import without `.`-prefix) and resolution fell through to name-match
  1226. // with path proximity — recall on cross-package callers was ~<1%.
  1227. fs.writeFileSync(
  1228. path.join(tempDir, 'go.mod'),
  1229. 'module github.com/example/myproject\n\ngo 1.21\n'
  1230. );
  1231. const pkgaDir = path.join(tempDir, 'pkga');
  1232. const pkgbDir = path.join(tempDir, 'pkgb');
  1233. const pkgcDir = path.join(tempDir, 'pkgc');
  1234. fs.mkdirSync(pkgaDir);
  1235. fs.mkdirSync(pkgbDir);
  1236. fs.mkdirSync(pkgcDir);
  1237. // Same-name exported function in two packages — only the imported one
  1238. // should resolve. Exercises disambiguation, not just connectivity.
  1239. fs.writeFileSync(
  1240. path.join(pkgaDir, 'conv.go'),
  1241. 'package pkga\nfunc Convert(x int) int { return x * 2 }\n'
  1242. );
  1243. fs.writeFileSync(
  1244. path.join(pkgbDir, 'conv.go'),
  1245. 'package pkgb\nfunc Convert(x int) int { return x + 1 }\n'
  1246. );
  1247. fs.writeFileSync(
  1248. path.join(pkgcDir, 'use.go'),
  1249. `package pkgc
  1250. import "github.com/example/myproject/pkga"
  1251. func UsePkga() {
  1252. pkga.Convert(5)
  1253. }
  1254. `
  1255. );
  1256. cg = await CodeGraph.init(tempDir, { index: true });
  1257. const usePkga = cg.getNodesByKind('function').filter((n) => n.name ==='UsePkga')[0];
  1258. expect(usePkga).toBeDefined();
  1259. const outgoing = cg.getOutgoingEdges(usePkga!.id);
  1260. const callEdges = outgoing.filter((e) => e.kind === 'calls');
  1261. expect(callEdges).toHaveLength(1);
  1262. const target = cg.getNode(callEdges[0]!.target);
  1263. expect(target?.name).toBe('Convert');
  1264. // Critical: the resolver must pick the imported pkga's Convert,
  1265. // not pkgb's. With the broken (pre-fix) resolver this lands on
  1266. // whichever Convert happens to be cheaper under path proximity.
  1267. expect(target?.filePath.replace(/\\/g, '/')).toBe('pkga/conv.go');
  1268. });
  1269. it('resolves Go aliased imports across packages (#388)', async () => {
  1270. fs.writeFileSync(
  1271. path.join(tempDir, 'go.mod'),
  1272. 'module github.com/example/myproject\n\ngo 1.21\n'
  1273. );
  1274. fs.mkdirSync(path.join(tempDir, 'pkgb'));
  1275. fs.mkdirSync(path.join(tempDir, 'pkgd'));
  1276. fs.writeFileSync(
  1277. path.join(tempDir, 'pkgb', 'lib.go'),
  1278. 'package pkgb\nfunc Compute(x int) int { return x }\n'
  1279. );
  1280. fs.writeFileSync(
  1281. path.join(tempDir, 'pkgd', 'use.go'),
  1282. `package pkgd
  1283. import (
  1284. "fmt"
  1285. alias "github.com/example/myproject/pkgb"
  1286. )
  1287. func UseAliased() {
  1288. fmt.Println("hi")
  1289. alias.Compute(3)
  1290. }
  1291. `
  1292. );
  1293. cg = await CodeGraph.init(tempDir, { index: true });
  1294. const useAliased = cg.getNodesByKind('function').filter((n) => n.name ==='UseAliased')[0];
  1295. expect(useAliased).toBeDefined();
  1296. const calls = cg.getOutgoingEdges(useAliased!.id).filter((e) => e.kind === 'calls');
  1297. // fmt.Println is stdlib — must stay external. alias.Compute must resolve.
  1298. expect(calls).toHaveLength(1);
  1299. const target = cg.getNode(calls[0]!.target);
  1300. expect(target?.name).toBe('Compute');
  1301. expect(target?.filePath.replace(/\\/g, '/')).toBe('pkgb/lib.go');
  1302. });
  1303. it('resolves Python module-attribute calls after `from pkg import module` (#578)', async () => {
  1304. // Pre-#578, a `module.func()` call where `module` was bound via
  1305. // `from pkg import module` dropped its `calls` edge. The file→file import
  1306. // edge resolved (resolveModuleImportToFile falls back to a dotted-module
  1307. // file lookup for absolute package paths), but resolvePythonModuleMember
  1308. // had no such fallback — resolveImportPath returns null for an absolute
  1309. // package path like `pkg.module`, so the member never resolved and
  1310. // callers/callees/impact on the target came back empty. Same root-cause
  1311. // class as the Go cross-package qualified call (#388).
  1312. fs.mkdirSync(path.join(tempDir, 'pkg'));
  1313. fs.writeFileSync(path.join(tempDir, 'pkg', '__init__.py'), '');
  1314. fs.writeFileSync(
  1315. path.join(tempDir, 'pkg', 'module.py'),
  1316. 'def func():\n return 1\n'
  1317. );
  1318. fs.writeFileSync(
  1319. path.join(tempDir, 'main.py'),
  1320. `from pkg import module
  1321. import os
  1322. def caller():
  1323. return module.func()
  1324. def external_caller():
  1325. return os.getcwd()
  1326. `
  1327. );
  1328. cg = await CodeGraph.init(tempDir, { index: true });
  1329. const caller = cg.getNodesByKind('function').filter((n) => n.name === 'caller')[0];
  1330. expect(caller).toBeDefined();
  1331. const calls = cg.getOutgoingEdges(caller!.id).filter((e) => e.kind === 'calls');
  1332. // module.func() must resolve to the real function in the submodule file.
  1333. expect(calls).toHaveLength(1);
  1334. const target = cg.getNode(calls[0]!.target);
  1335. expect(target?.name).toBe('func');
  1336. expect(target?.filePath.replace(/\\/g, '/')).toBe('pkg/module.py');
  1337. // The flip side of the fix: an attribute call through a *stdlib* module
  1338. // (`os.getcwd()`) must still create no edge — the fallback only matches
  1339. // real in-repo module files.
  1340. const externalCaller = cg.getNodesByKind('function').filter((n) => n.name === 'external_caller')[0];
  1341. expect(externalCaller).toBeDefined();
  1342. const externalCalls = cg.getOutgoingEdges(externalCaller!.id).filter((e) => e.kind === 'calls');
  1343. expect(externalCalls).toHaveLength(0);
  1344. });
  1345. it('resolves a module-qualified call to a function whose name collides with a builtin collection method, and does not fabricate one from an unrelated chained receiver (#1681)', async () => {
  1346. // `ledger.append(row)` (module imported, method name `append`) previously
  1347. // never reached resolution: isBuiltInOrExternal's Python built-in-method
  1348. // filter treated ANY `x.append(...)` as `list.append` unless `X` matched a
  1349. // known CLASS, so a real MODULE export named `append` was dropped before
  1350. // resolveViaImport ever ran. Separately, `d.setdefault(k, []).append(x)` —
  1351. // a non-identifier (call-chain) receiver — used to degrade at extraction
  1352. // to a BARE `append` ref and exact-match ledger.append (#1683/#1748 fixed
  1353. // that half; assert both directions here).
  1354. fs.writeFileSync(
  1355. path.join(tempDir, 'ledger.py'),
  1356. 'def append(row):\n return True\n\n\ndef path():\n return "ledger.jsonl"\n'
  1357. );
  1358. fs.writeFileSync(
  1359. path.join(tempDir, 'record.py'),
  1360. `from . import ledger
  1361. def add_outcome(row):
  1362. if not ledger.append(row):
  1363. return None
  1364. return ledger.path()
  1365. `
  1366. );
  1367. fs.writeFileSync(
  1368. path.join(tempDir, 'unrelated.py'),
  1369. `def build_map():
  1370. rows_by_file = {}
  1371. rows_by_file.setdefault("f", []).append({"x": 1})
  1372. return rows_by_file
  1373. `
  1374. );
  1375. cg = await CodeGraph.init(tempDir, { index: true });
  1376. const ledgerAppend = cg
  1377. .getNodesByKind('function')
  1378. .find((n) => n.name === 'append' && n.filePath.replace(/\\/g, '/') === 'ledger.py');
  1379. expect(ledgerAppend).toBeDefined();
  1380. // The real, import-qualified call must resolve.
  1381. const addOutcome = cg.getNodesByKind('function').find((n) => n.name === 'add_outcome');
  1382. expect(addOutcome).toBeDefined();
  1383. const addOutcomeCalls = cg.getOutgoingEdges(addOutcome!.id).filter((e) => e.kind === 'calls');
  1384. expect(addOutcomeCalls.map((e) => e.target)).toContain(ledgerAppend!.id);
  1385. // The unrelated dict/list `.append()` on a chained receiver must NOT
  1386. // fabricate an edge to ledger.py's append.
  1387. const buildMap = cg.getNodesByKind('function').find((n) => n.name === 'build_map');
  1388. expect(buildMap).toBeDefined();
  1389. const buildMapCalls = cg.getOutgoingEdges(buildMap!.id).filter((e) => e.kind === 'calls');
  1390. expect(buildMapCalls.map((e) => e.target)).not.toContain(ledgerAppend!.id);
  1391. });
  1392. it('attaches Go methods to their receiver type across files (#583, cross-file half)', async () => {
  1393. // In Go a type's methods are commonly declared in a different file from the
  1394. // `type` declaration (`type Box` in box.go, `func (b *Box) Get()` in
  1395. // box_methods.go). Extraction only attaches the struct→method `contains`
  1396. // edge when the type is in the SAME file (the owner lookup is file-scoped),
  1397. // so a cross-file method was orphaned from its struct — breaking member
  1398. // outlines and any callers/callees/impact traversal through `contains`. A
  1399. // resolution-phase pass now links them within the package (= directory).
  1400. fs.writeFileSync(
  1401. path.join(tempDir, 'box.go'),
  1402. 'package main\n\ntype Box struct{ v int }\n'
  1403. );
  1404. fs.writeFileSync(
  1405. path.join(tempDir, 'box_methods.go'),
  1406. 'package main\n\nfunc (b *Box) Get() int { return b.v }\nfunc (b *Box) Set(x int) { b.v = x }\n'
  1407. );
  1408. // Generic receiver declared cross-file too — exercises #583 half A
  1409. // (generic `*Stack[T]` receiver parsing) and half B (cross-file) together.
  1410. fs.writeFileSync(
  1411. path.join(tempDir, 'stack.go'),
  1412. 'package main\n\ntype Stack[T any] struct {\n\titems []T\n}\n'
  1413. );
  1414. fs.writeFileSync(
  1415. path.join(tempDir, 'stack_push.go'),
  1416. 'package main\n\nfunc (s *Stack[T]) Push(v T) { s.items = append(s.items, v) }\n'
  1417. );
  1418. // A same-named type in another package must NOT capture this package's
  1419. // methods — the link is scoped to the receiver type's own directory.
  1420. fs.mkdirSync(path.join(tempDir, 'other'));
  1421. fs.writeFileSync(
  1422. path.join(tempDir, 'other', 'box.go'),
  1423. 'package other\n\ntype Box struct{ w int }\n'
  1424. );
  1425. cg = await CodeGraph.init(tempDir, { index: true });
  1426. const methodsOf = (typeName: string, file: string): string[] => {
  1427. const node = cg
  1428. .getNodesByKind('struct')
  1429. .find((n) => n.name === typeName && n.filePath.replace(/\\/g, '/') === file);
  1430. expect(node, `${typeName} @ ${file}`).toBeDefined();
  1431. return cg
  1432. .getOutgoingEdges(node!.id)
  1433. .filter((e) => e.kind === 'contains')
  1434. .map((e) => cg.getNode(e.target))
  1435. .filter((n) => !!n && n.kind === 'method')
  1436. .map((n) => n!.name)
  1437. .sort();
  1438. };
  1439. // Cross-file (non-generic) methods now attach to their struct.
  1440. expect(methodsOf('Box', 'box.go')).toEqual(['Get', 'Set']);
  1441. // Generic + cross-file.
  1442. expect(methodsOf('Stack', 'stack.go')).toEqual(['Push']);
  1443. // Cross-package isolation: other/Box defines no methods of its own.
  1444. expect(methodsOf('Box', 'other/box.go')).toEqual([]);
  1445. });
  1446. it('TS type_alias object-shape members resolve method calls (#359)', async () => {
  1447. // Pre-#359, `recorder.stop()` (recorder: RecorderHandle) attached
  1448. // to `StdioMcpClient.stop` in a sibling directory via path-proximity
  1449. // because the type_alias had no `stop` node — only the unrelated
  1450. // class did. Now type_alias produces member nodes (property/method),
  1451. // so the camelCase receiver↔type word overlap pulls the call to
  1452. // `RecorderHandle::stop` instead of the look-alike class.
  1453. fs.mkdirSync(path.join(tempDir, 'voice'));
  1454. fs.mkdirSync(path.join(tempDir, 'codegraph'));
  1455. fs.writeFileSync(
  1456. path.join(tempDir, 'voice', 'recorder.ts'),
  1457. `export type RecorderHandle = {
  1458. wavPath: string;
  1459. stop: () => Promise<{ ok: true }>;
  1460. };
  1461. `
  1462. );
  1463. fs.writeFileSync(
  1464. path.join(tempDir, 'voice', 'controller.ts'),
  1465. `import type { RecorderHandle } from "./recorder";
  1466. export async function finaliseRecording(recorder: RecorderHandle) {
  1467. return await recorder.stop();
  1468. }
  1469. `
  1470. );
  1471. fs.writeFileSync(
  1472. path.join(tempDir, 'codegraph', 'stdio-client.ts'),
  1473. `export class StdioMcpClient {
  1474. private stopped = false;
  1475. async stop(): Promise<void> { this.stopped = true; }
  1476. }
  1477. `
  1478. );
  1479. cg = await CodeGraph.init(tempDir, { index: true });
  1480. const handleStop = cg
  1481. .getNodesByKind('method')
  1482. .find((n) => n.qualifiedName === 'RecorderHandle::stop');
  1483. expect(handleStop).toBeDefined();
  1484. const clientStop = cg
  1485. .getNodesByKind('method')
  1486. .find((n) => n.qualifiedName === 'StdioMcpClient::stop');
  1487. expect(clientStop).toBeDefined();
  1488. const handleCallers = cg.getIncomingEdges(handleStop!.id).filter((e) => e.kind === 'calls');
  1489. const clientCallers = cg.getIncomingEdges(clientStop!.id).filter((e) => e.kind === 'calls');
  1490. expect(handleCallers.length).toBeGreaterThanOrEqual(1);
  1491. // The class method must have NO callers — voice/'s call must NOT
  1492. // mis-attribute. A non-empty list would mean the false-positive
  1493. // path is still firing.
  1494. expect(clientCallers).toHaveLength(0);
  1495. // Function-typed property surfaces as a `method` node, not `property`,
  1496. // because `stop()` semantics at the call site are method semantics.
  1497. expect(handleStop!.kind).toBe('method');
  1498. });
  1499. it('Java import disambiguates same-name classes across modules (#314)', async () => {
  1500. // Pre-#314 the import resolver had no Java branch at all, so a
  1501. // multi-module Maven repo where `dao/converter/FooConverter` and
  1502. // `service/converter/FooConverter` both export a `convert` method
  1503. // resolved by file-path proximity — picking whichever class was
  1504. // closer to the caller, which is wrong any time the caller lives
  1505. // in an equidistant cross-cutting module.
  1506. const daoDir = path.join(tempDir, 'dao/src/main/java/com/example/dao/converter');
  1507. const serviceDir = path.join(tempDir, 'service/src/main/java/com/example/service/converter');
  1508. const webDir = path.join(tempDir, 'web/src/main/java/com/example/web');
  1509. fs.mkdirSync(daoDir, { recursive: true });
  1510. fs.mkdirSync(serviceDir, { recursive: true });
  1511. fs.mkdirSync(webDir, { recursive: true });
  1512. fs.writeFileSync(
  1513. path.join(daoDir, 'FooConverter.java'),
  1514. `package com.example.dao.converter;
  1515. public class FooConverter { public String convert(String x) { return "dao:" + x; } }
  1516. `
  1517. );
  1518. fs.writeFileSync(
  1519. path.join(serviceDir, 'FooConverter.java'),
  1520. `package com.example.service.converter;
  1521. public class FooConverter { public String convert(String x) { return "svc:" + x; } }
  1522. `
  1523. );
  1524. // The caller imports the SERVICE version — even though dao is
  1525. // alphabetically/lexically first in the candidate list, the
  1526. // import must trump that order.
  1527. fs.writeFileSync(
  1528. path.join(webDir, 'Handler.java'),
  1529. `package com.example.web;
  1530. import com.example.service.converter.FooConverter;
  1531. public class Handler {
  1532. private FooConverter fooConverter;
  1533. public String use() { return fooConverter.convert("input"); }
  1534. }
  1535. `
  1536. );
  1537. cg = await CodeGraph.init(tempDir, { index: true });
  1538. const use = cg
  1539. .getNodesByKind('method')
  1540. .find((n) => n.qualifiedName === 'com.example.web::Handler::use');
  1541. expect(use).toBeDefined();
  1542. const calls = cg.getOutgoingEdges(use!.id).filter((e) => e.kind === 'calls');
  1543. expect(calls.length).toBeGreaterThanOrEqual(1);
  1544. const target = cg.getNode(calls[0]!.target);
  1545. expect(target?.name).toBe('convert');
  1546. expect(target?.filePath.replace(/\\/g, '/')).toBe(
  1547. 'service/src/main/java/com/example/service/converter/FooConverter.java'
  1548. );
  1549. });
  1550. it('C# extracts references from method/property/field types (#381)', async () => {
  1551. // Pre-#381, every C# project produced ZERO `references` edges:
  1552. // csharp.ts was missing returnField, and the type-leaf walker
  1553. // only recognized TS/Java's `type_identifier` nodes — C# uses
  1554. // `identifier`/`predefined_type`/`qualified_name`/`generic_name`.
  1555. const srcDir = path.join(tempDir, 'src');
  1556. fs.mkdirSync(srcDir, { recursive: true });
  1557. fs.writeFileSync(
  1558. path.join(srcDir, 'Dtos.cs'),
  1559. `namespace MyApp;
  1560. public class SessionInfoDto { public string Id { get; set; } = ""; }
  1561. public class UserDto { public string Name { get; set; } = ""; }
  1562. `
  1563. );
  1564. fs.writeFileSync(
  1565. path.join(srcDir, 'Service.cs'),
  1566. `using System.Threading.Tasks;
  1567. namespace MyApp;
  1568. public class DataExporter
  1569. {
  1570. public SessionInfoDto Build(UserDto user, SessionInfoDto session) { return session; }
  1571. public Task<SessionInfoDto> BuildAsync(UserDto user) { return Task.FromResult(new SessionInfoDto()); }
  1572. public SessionInfoDto Latest { get; set; } = new();
  1573. private UserDto _cached;
  1574. }
  1575. `
  1576. );
  1577. cg = await CodeGraph.init(tempDir, { index: true });
  1578. const sessionDto = cg
  1579. .getNodesByKind('class')
  1580. .find((n) => n.name === 'SessionInfoDto');
  1581. const userDto = cg
  1582. .getNodesByKind('class')
  1583. .find((n) => n.name === 'UserDto');
  1584. expect(sessionDto).toBeDefined();
  1585. expect(userDto).toBeDefined();
  1586. const sessionIncoming = cg
  1587. .getIncomingEdges(sessionDto!.id)
  1588. .filter((e) => e.kind === 'references');
  1589. const userIncoming = cg
  1590. .getIncomingEdges(userDto!.id)
  1591. .filter((e) => e.kind === 'references');
  1592. // SessionInfoDto: Build return, Build param, BuildAsync return (inside Task<>), Latest property.
  1593. // UserDto: Build param, BuildAsync param, _cached field.
  1594. expect(sessionIncoming.length).toBeGreaterThanOrEqual(4);
  1595. expect(userIncoming.length).toBeGreaterThanOrEqual(3);
  1596. });
  1597. it('C# primary-constructor parameters record their type dependencies (#237)', async () => {
  1598. // C# 12 primary constructors declare a type's injected dependencies inline
  1599. // (`class Svc(IRepo repo, [FromKeyedServices("k")] ICache cache)`). Each
  1600. // ctor parameter's type is recorded as a `references` edge from the class,
  1601. // so a DI-registered contract reached only through a primary ctor is no
  1602. // longer reported as having no dependents.
  1603. fs.mkdirSync(path.join(tempDir, 'src'), { recursive: true });
  1604. fs.writeFileSync(
  1605. path.join(tempDir, 'src', 'Contracts.cs'),
  1606. `namespace App;
  1607. public interface IRepo { }
  1608. public class ICache { }
  1609. `
  1610. );
  1611. fs.writeFileSync(
  1612. path.join(tempDir, 'src', 'OrderService.cs'),
  1613. `namespace App;
  1614. public sealed class OrderService(IRepo repo, [FromKeyedServices("primary")] ICache cache)
  1615. {
  1616. public void Run() { }
  1617. }
  1618. `
  1619. );
  1620. cg = await CodeGraph.init(tempDir, { index: true });
  1621. const svc = cg.getNodesByKind('class').find((n) => n.name === 'OrderService');
  1622. expect(svc).toBeDefined();
  1623. // The class itself must index (it used to vanish under the old grammar).
  1624. const out = cg.getOutgoingEdges(svc!.id).filter((e) => e.kind === 'references');
  1625. const depNames = out.map((e) => cg.getNode(e.target)?.name);
  1626. expect(depNames).toContain('IRepo');
  1627. expect(depNames).toContain('ICache'); // the keyed-DI ([FromKeyedServices]) dependency
  1628. });
  1629. it('Go: leaves stdlib calls (fmt.Println, etc.) external', async () => {
  1630. fs.writeFileSync(
  1631. path.join(tempDir, 'go.mod'),
  1632. 'module github.com/example/myproject\n\ngo 1.21\n'
  1633. );
  1634. fs.writeFileSync(
  1635. path.join(tempDir, 'main.go'),
  1636. `package main
  1637. import "fmt"
  1638. func main() {
  1639. fmt.Println("hi")
  1640. }
  1641. `
  1642. );
  1643. cg = await CodeGraph.init(tempDir, { index: true });
  1644. const mainFn = cg.getNodesByKind('function').filter((n) => n.name ==='main')[0];
  1645. const calls = cg.getOutgoingEdges(mainFn!.id).filter((e) => e.kind === 'calls');
  1646. // No spurious in-project edge — fmt.* must stay unresolved/external.
  1647. expect(calls).toHaveLength(0);
  1648. });
  1649. });
  1650. describe('Same-name method disambiguation (#1079)', () => {
  1651. // resolveMethodOnType picks among several methods that share a
  1652. // `Type::method` qualifiedName. The precedence is:
  1653. // 1. preferredFqn (Java/Kotlin import — target is intentionally in
  1654. // ANOTHER file, #314),
  1655. // 2. the call site's OWN file (language-agnostic, #1079),
  1656. // 3. matches[0] (first-indexed) as a last resort.
  1657. const methodNode = (
  1658. id: string,
  1659. filePath: string,
  1660. language: Node['language'] = 'cpp',
  1661. qualifiedName = 'Logger::log',
  1662. name = 'log',
  1663. ): Node => ({
  1664. id, kind: 'method', name, qualifiedName, filePath, language,
  1665. startLine: 1, endLine: 1, startColumn: 0, endColumn: 0, updatedAt: 0,
  1666. });
  1667. const callRef = (filePath: string, language: Node['language'] = 'cpp'): UnresolvedRef => ({
  1668. fromNodeId: 'caller', referenceName: 'lg.log', referenceKind: 'calls',
  1669. line: 2, column: 0, filePath, language,
  1670. });
  1671. const ctxFor = (candidates: Node[]): ResolutionContext => ({
  1672. getNodesInFile: () => [],
  1673. getNodesByName: (name) => candidates.filter((c) => c.name === name),
  1674. getNodesByQualifiedName: () => [],
  1675. getNodesByKind: () => [],
  1676. fileExists: () => false,
  1677. readFile: () => null,
  1678. getProjectRoot: () => '',
  1679. getAllFiles: () => [],
  1680. });
  1681. it('prefers the definition in the call site\'s own file (#1079)', () => {
  1682. // matches[0] is the a/ definition; the call comes from b/, so it must
  1683. // resolve to b/ — not collapse onto the first-indexed match.
  1684. const logA = methodNode('m:a', 'a/svc.cpp');
  1685. const logB = methodNode('m:b', 'b/svc.cpp');
  1686. const result = resolveMethodOnType(
  1687. 'Logger', 'log', callRef('b/svc.cpp'), ctxFor([logA, logB]), 0.9, 'instance-method',
  1688. );
  1689. expect(result?.targetNodeId).toBe('m:b');
  1690. });
  1691. it('lets an import FQN pin a cross-file target over the same-file preference (#314)', () => {
  1692. // Java: two `Bar::doIt` in different packages. The import FQN pins the
  1693. // alpha package; even though the call site lives in beta's file, the FQN
  1694. // must win — the same-file preference runs only AFTER preferredFqn.
  1695. const alpha = methodNode('m:alpha', 'com/example/alpha/Bar.java', 'java', 'Bar::doIt', 'doIt');
  1696. const beta = methodNode('m:beta', 'com/example/beta/Bar.java', 'java', 'Bar::doIt', 'doIt');
  1697. const result = resolveMethodOnType(
  1698. 'Bar', 'doIt', callRef('com/example/beta/Bar.java', 'java'),
  1699. ctxFor([alpha, beta]), 0.9, 'instance-method', 'com.example.alpha.Bar',
  1700. );
  1701. expect(result?.targetNodeId).toBe('m:alpha');
  1702. });
  1703. it('falls back to the first match when nothing disambiguates', () => {
  1704. // Call site is a third file: no FQN, no same-file candidate → matches[0].
  1705. const logA = methodNode('m:a', 'a/svc.cpp');
  1706. const logB = methodNode('m:b', 'b/svc.cpp');
  1707. const result = resolveMethodOnType(
  1708. 'Logger', 'log', callRef('c/other.cpp'), ctxFor([logA, logB]), 0.9, 'instance-method',
  1709. );
  1710. expect(result?.targetNodeId).toBe('m:a');
  1711. });
  1712. it('resolves C++ calls end-to-end to same-named classes in different files (#1079)', async () => {
  1713. // The exact repro from the issue: two files, each with its own
  1714. // `Logger::log`. Before the fix both callers pointed at the first def.
  1715. fs.mkdirSync(path.join(tempDir, 'a'), { recursive: true });
  1716. fs.mkdirSync(path.join(tempDir, 'b'), { recursive: true });
  1717. fs.writeFileSync(
  1718. path.join(tempDir, 'a', 'svc.cpp'),
  1719. `class Logger { public: void log() { int a = 1; } };\nvoid useA() { Logger lg; lg.log(); }\n`,
  1720. );
  1721. fs.writeFileSync(
  1722. path.join(tempDir, 'b', 'svc.cpp'),
  1723. `class Logger { public: void log() { int b = 2; } };\nvoid useB() { Logger lg; lg.log(); }\n`,
  1724. );
  1725. cg = await CodeGraph.init(tempDir, { index: true });
  1726. cg.resolveReferences();
  1727. const logInDir = (dir: string) =>
  1728. cg.getNodesByKind('method').find(
  1729. (n) => n.name === 'log' && n.filePath.replace(/\\/g, '/').endsWith(`${dir}/svc.cpp`),
  1730. )!;
  1731. const callTargets = (fnName: string) =>
  1732. cg
  1733. .getOutgoingEdges(cg.getNodesByKind('function').find((n) => n.name === fnName)!.id)
  1734. .filter((e) => e.kind === 'calls')
  1735. .map((e) => e.target);
  1736. const logA = logInDir('a');
  1737. const logB = logInDir('b');
  1738. expect(logA).toBeDefined();
  1739. expect(logB).toBeDefined();
  1740. expect(logA.id).not.toBe(logB.id);
  1741. // Each caller resolves to the Logger::log in its OWN file.
  1742. expect(callTargets('useA')).toContain(logA.id);
  1743. expect(callTargets('useB')).toContain(logB.id);
  1744. });
  1745. it('preferCallSiteFile puts same-file candidates first and is otherwise a no-op', () => {
  1746. const a = methodNode('m:a', 'a/svc.cpp');
  1747. const b = methodNode('m:b', 'b/svc.cpp');
  1748. // Same-file first; the rest keep their original order (stable).
  1749. expect(preferCallSiteFile([a, b], 'b/svc.cpp').map((n) => n.id)).toEqual(['m:b', 'm:a']);
  1750. expect(preferCallSiteFile([a, b], 'a/svc.cpp').map((n) => n.id)).toEqual(['m:a', 'm:b']);
  1751. // No same-file match → unchanged; <2 candidates → returned as-is.
  1752. expect(preferCallSiteFile([a, b], 'c/other.cpp').map((n) => n.id)).toEqual(['m:a', 'm:b']);
  1753. expect(preferCallSiteFile([a], 'z/none.cpp')).toHaveLength(1);
  1754. });
  1755. it('matchByQualifiedName prefers the same-file target when a qualified name is ambiguous (#1079)', () => {
  1756. // Two `Logger::log` definitions; an explicit `Logger::log()` call from b/
  1757. // must resolve to b/'s definition, not the first-indexed one.
  1758. const a = methodNode('m:a', 'a/svc.cpp');
  1759. const b = methodNode('m:b', 'b/svc.cpp');
  1760. const ctx: ResolutionContext = {
  1761. getNodesInFile: () => [],
  1762. getNodesByName: (name) => [a, b].filter((n) => n.name === name),
  1763. getNodesByQualifiedName: (q) => (q === 'Logger::log' ? [a, b] : []),
  1764. getNodesByKind: () => [],
  1765. fileExists: () => false,
  1766. readFile: () => null,
  1767. getProjectRoot: () => '',
  1768. getAllFiles: () => [],
  1769. };
  1770. const ref: UnresolvedRef = {
  1771. fromNodeId: 'caller', referenceName: 'Logger::log', referenceKind: 'calls',
  1772. line: 2, column: 0, filePath: 'b/svc.cpp', language: 'cpp',
  1773. };
  1774. expect(matchByQualifiedName(ref, ctx)?.targetNodeId).toBe('m:b');
  1775. });
  1776. it('resolves a static/class-receiver call to the class in the caller\'s file (#1079)', async () => {
  1777. // `Logger.log()` — the receiver is the class NAME, so this routes through
  1778. // the class-name-receiver strategy (not the C++ instance path). It was
  1779. // file-blind across languages; verified here on TypeScript.
  1780. fs.mkdirSync(path.join(tempDir, 'a'), { recursive: true });
  1781. fs.mkdirSync(path.join(tempDir, 'b'), { recursive: true });
  1782. fs.writeFileSync(
  1783. path.join(tempDir, 'a', 'svc.ts'),
  1784. `class Logger { static log() { return 1; } }\nexport function useA() { return Logger.log(); }\n`,
  1785. );
  1786. fs.writeFileSync(
  1787. path.join(tempDir, 'b', 'svc.ts'),
  1788. `class Logger { static log() { return 2; } }\nexport function useB() { return Logger.log(); }\n`,
  1789. );
  1790. cg = await CodeGraph.init(tempDir, { index: true });
  1791. cg.resolveReferences();
  1792. const logInDir = (dir: string) =>
  1793. cg.getNodesByKind('method').find(
  1794. (n) => n.name === 'log' && n.filePath.replace(/\\/g, '/').endsWith(`${dir}/svc.ts`),
  1795. )!;
  1796. const callTargets = (fnName: string) =>
  1797. cg
  1798. .getOutgoingEdges(cg.getNodesByKind('function').find((n) => n.name === fnName)!.id)
  1799. .filter((e) => e.kind === 'calls')
  1800. .map((e) => e.target);
  1801. const logA = logInDir('a');
  1802. const logB = logInDir('b');
  1803. expect(logA?.id).not.toBe(logB?.id);
  1804. expect(callTargets('useA')).toContain(logA.id);
  1805. expect(callTargets('useB')).toContain(logB.id);
  1806. });
  1807. it('resolves an explicitly-qualified call to the definition in the caller\'s file (#1079)', async () => {
  1808. // `Logger::log()` with two `Logger::log` definitions routes through the
  1809. // qualified-name strategy, whose partial match previously picked the first.
  1810. fs.mkdirSync(path.join(tempDir, 'a'), { recursive: true });
  1811. fs.mkdirSync(path.join(tempDir, 'b'), { recursive: true });
  1812. fs.writeFileSync(
  1813. path.join(tempDir, 'a', 'svc.cpp'),
  1814. `class Logger { public: static void log() { int a = 1; } };\nvoid useA() { Logger::log(); }\n`,
  1815. );
  1816. fs.writeFileSync(
  1817. path.join(tempDir, 'b', 'svc.cpp'),
  1818. `class Logger { public: static void log() { int b = 2; } };\nvoid useB() { Logger::log(); }\n`,
  1819. );
  1820. cg = await CodeGraph.init(tempDir, { index: true });
  1821. cg.resolveReferences();
  1822. const logInDir = (dir: string) =>
  1823. cg.getNodesByKind('method').find(
  1824. (n) => n.name === 'log' && n.filePath.replace(/\\/g, '/').endsWith(`${dir}/svc.cpp`),
  1825. )!;
  1826. const callTargets = (fnName: string) =>
  1827. cg
  1828. .getOutgoingEdges(cg.getNodesByKind('function').find((n) => n.name === fnName)!.id)
  1829. .filter((e) => e.kind === 'calls')
  1830. .map((e) => e.target);
  1831. const logA = logInDir('a');
  1832. const logB = logInDir('b');
  1833. expect(logA?.id).not.toBe(logB?.id);
  1834. expect(callTargets('useA')).toContain(logA.id);
  1835. expect(callTargets('useB')).toContain(logB.id);
  1836. });
  1837. });
  1838. describe('Watchdog-safe resolution on collision-heavy repos (#1122)', () => {
  1839. // On a large Java-style repo, per-ref resolution cost is unbounded in the
  1840. // worst case (a colliding method name whose candidate set misses the LRU
  1841. // re-fetches tens of thousands of rows, and receiver inference re-splits
  1842. // the whole source file). v1.2.0 yielded only every 500 refs, so a dense
  1843. // pocket multiplied that cost past the #850 watchdog window and a VALID
  1844. // `init` was SIGKILLed at "Resolving refs". These pin the three guards:
  1845. // per-ref yield checkpoints, the (type, method) match memo, and the
  1846. // per-file lines cache with its generated/minified-line skip.
  1847. const methodNode = (
  1848. id: string,
  1849. filePath: string,
  1850. qualifiedName: string,
  1851. name: string,
  1852. language: Node['language'] = 'typescript',
  1853. kind: Node['kind'] = 'method',
  1854. ): Node => ({
  1855. id, kind, name, qualifiedName, filePath, language,
  1856. startLine: 1, endLine: 1, startColumn: 0, endColumn: 0, updatedAt: 0,
  1857. });
  1858. it('resolveMethodOnType consults the method-match memo and still disambiguates per call site', () => {
  1859. const logA = methodNode('m:a', 'a/svc.ts', 'Logger::log', 'log');
  1860. const logB = methodNode('m:b', 'b/svc.ts', 'Logger::log', 'log');
  1861. const shared = [logA, logB]; // one cached array served to every caller
  1862. let memoCalls = 0;
  1863. let rawNameLookups = 0;
  1864. const ctx: ResolutionContext = {
  1865. getNodesInFile: () => [],
  1866. getNodesByName: () => { rawNameLookups++; return shared; },
  1867. getMethodMatches: () => { memoCalls++; return shared; },
  1868. getNodesByQualifiedName: () => [],
  1869. getNodesByKind: () => [],
  1870. fileExists: () => false,
  1871. readFile: () => null,
  1872. getProjectRoot: () => '',
  1873. getAllFiles: () => [],
  1874. };
  1875. const refFrom = (filePath: string): UnresolvedRef => ({
  1876. fromNodeId: 'caller', referenceName: 'lg.log', referenceKind: 'calls',
  1877. line: 2, column: 0, filePath, language: 'typescript',
  1878. });
  1879. // Both call sites read the SAME memoized array, yet each still resolves
  1880. // to its own file — per-ref disambiguation runs after the memo (#1079).
  1881. const fromA = resolveMethodOnType('Logger', 'log', refFrom('a/svc.ts'), ctx, 0.9, 'instance-method');
  1882. const fromB = resolveMethodOnType('Logger', 'log', refFrom('b/svc.ts'), ctx, 0.9, 'instance-method');
  1883. expect(fromA?.targetNodeId).toBe('m:a');
  1884. expect(fromB?.targetNodeId).toBe('m:b');
  1885. expect(memoCalls).toBe(2);
  1886. expect(rawNameLookups).toBe(0); // memo bypasses the unbounded name fetch
  1887. });
  1888. it('the production resolver context memoizes method matches per (language, type, method)', async () => {
  1889. fs.writeFileSync(
  1890. path.join(tempDir, 'svc.ts'),
  1891. `class Logger { log() { return 1; } }\nexport function use() { const lg = new Logger(); return lg.log(); }\n`,
  1892. );
  1893. cg = await CodeGraph.init(tempDir, { index: true });
  1894. const resolver = (cg as unknown as { resolver: ReferenceResolver }).resolver;
  1895. const ctx = (resolver as unknown as { context: ResolutionContext }).context;
  1896. const first = ctx.getMethodMatches!('Logger', 'log', 'typescript');
  1897. const second = ctx.getMethodMatches!('Logger', 'log', 'typescript');
  1898. expect(first.map((n) => n.qualifiedName)).toEqual(['Logger::log']);
  1899. // Same array instance = served from the memo, not recomputed.
  1900. expect(second).toBe(first);
  1901. resolver.clearCaches();
  1902. const afterClear = ctx.getMethodMatches!('Logger', 'log', 'typescript');
  1903. expect(afterClear).not.toBe(first);
  1904. expect(afterClear.map((n) => n.qualifiedName)).toEqual(['Logger::log']);
  1905. });
  1906. it('resolveBatchYielding offers a yield checkpoint for every ref', async () => {
  1907. fs.writeFileSync(
  1908. path.join(tempDir, 'a.ts'),
  1909. `export function fnA() { return 1; }\nexport function fnB() { return fnA(); }\nexport function fnC() { return fnB(); }\n`,
  1910. );
  1911. fs.writeFileSync(
  1912. path.join(tempDir, 'b.ts'),
  1913. `import { fnA } from './a';\nexport function fnD() { return fnA(); }\n`,
  1914. );
  1915. cg = await CodeGraph.init(tempDir, { index: true });
  1916. const resolver = (cg as unknown as { resolver: ReferenceResolver }).resolver;
  1917. // `init({ index: true })` already ran resolution, so feed the batch
  1918. // directly — resolveBatchYielding takes it as an argument; whether each
  1919. // ref resolves is irrelevant to the checkpoint contract.
  1920. const refs: UnresolvedReference[] = ['fnA', 'fnB', 'nosuchFn', 'fnA', 'alsoMissing'].map((name, i) => ({
  1921. fromNodeId: `caller-${i}`,
  1922. referenceName: name,
  1923. referenceKind: 'calls',
  1924. line: i + 1,
  1925. column: 0,
  1926. filePath: 'a.ts',
  1927. language: 'typescript',
  1928. }));
  1929. let checkpoints = 0;
  1930. const countingYield = async () => { checkpoints++; };
  1931. const result = await (resolver as unknown as {
  1932. resolveBatchYielding(batch: UnresolvedReference[], maybeYield: () => Promise<void>): Promise<{ stats: { total: number } }>;
  1933. }).resolveBatchYielding(refs, countingYield);
  1934. // One checkpoint per ref: a pocket of pathologically slow refs can never
  1935. // run more than ONE ref past the yield budget before the heartbeat gets
  1936. // a window — the #1122 kill required 500.
  1937. expect(checkpoints).toBe(refs.length);
  1938. expect(result.stats.total).toBe(refs.length);
  1939. });
  1940. it('receiver inference reads lines through getFileLines when the context provides it', () => {
  1941. const loggerClass = methodNode('c:logger', 'svc.ts', 'Logger', 'Logger', 'typescript', 'class');
  1942. const logMethod = methodNode('m:log', 'svc.ts', 'Logger::log', 'log');
  1943. const otherLog = methodNode('m:other', 'other.ts', 'Other::log', 'log');
  1944. const byName: Record<string, Node[]> = {
  1945. Logger: [loggerClass],
  1946. log: [logMethod, otherLog], // ambiguous bare name → only inference can resolve
  1947. };
  1948. const lines = ['const lg = new Logger();', 'lg.log();'];
  1949. const ctx: ResolutionContext = {
  1950. getNodesInFile: () => [],
  1951. getNodesByName: (name) => byName[name] ?? [],
  1952. getNodesByQualifiedName: () => [],
  1953. getNodesByKind: () => [],
  1954. fileExists: () => false,
  1955. // Reading the raw source must not be needed when lines are provided.
  1956. readFile: () => { throw new Error('readFile must not be called when getFileLines exists'); },
  1957. getFileLines: () => lines,
  1958. getProjectRoot: () => '',
  1959. getAllFiles: () => [],
  1960. };
  1961. const ref: UnresolvedRef = {
  1962. fromNodeId: 'caller', referenceName: 'lg.log', referenceKind: 'calls',
  1963. line: 2, column: 0, filePath: 'svc.ts', language: 'typescript',
  1964. };
  1965. expect(matchMethodCall(ref, ctx)?.targetNodeId).toBe('m:log');
  1966. });
  1967. it('receiver inference skips generated/minified lines instead of regex-scanning them', () => {
  1968. const loggerClass = methodNode('c:logger', 'svc.ts', 'Logger', 'Logger', 'typescript', 'class');
  1969. const logMethod = methodNode('m:log', 'svc.ts', 'Logger::log', 'log');
  1970. const otherLog = methodNode('m:other', 'other.ts', 'Other::log', 'log');
  1971. const byName: Record<string, Node[]> = {
  1972. Logger: [loggerClass],
  1973. log: [logMethod, otherLog],
  1974. };
  1975. const ctxWithLines = (lines: string[]): ResolutionContext => ({
  1976. getNodesInFile: () => [],
  1977. getNodesByName: (name) => byName[name] ?? [],
  1978. getNodesByQualifiedName: () => [],
  1979. getNodesByKind: () => [],
  1980. fileExists: () => false,
  1981. readFile: () => null,
  1982. getFileLines: () => lines,
  1983. getProjectRoot: () => '',
  1984. getAllFiles: () => [],
  1985. });
  1986. const ref: UnresolvedRef = {
  1987. fromNodeId: 'caller', referenceName: 'lg.log', referenceKind: 'calls',
  1988. line: 1, column: 0, filePath: 'svc.ts', language: 'typescript',
  1989. };
  1990. // Control: the declaration on a normal-length line resolves.
  1991. const normal = matchMethodCall(ref, ctxWithLines(['const lg = new Logger(); lg.log();']));
  1992. expect(normal?.targetNodeId).toBe('m:log');
  1993. // The same declaration buried in a >10K-char generated/minified line is
  1994. // skipped — no resolution, and no per-ref regex pass over the huge line.
  1995. const minified = 'var pad="' + 'x'.repeat(10_000) + '";const lg = new Logger(); lg.log();';
  1996. expect(matchMethodCall(ref, ctxWithLines([minified]))).toBeNull();
  1997. });
  1998. });
  1999. describe('Local-variable receiver-type inference (#1108)', () => {
  2000. // `lg.log()` where `lg` is a local whose type is inferred from its
  2001. // declaration/initializer. Before this, only C++ resolved these; every
  2002. // other language produced no method edge. Each case is one file with a
  2003. // single Logger + a caller using a local-variable receiver — a correct
  2004. // resolution makes the caller a caller of `log`.
  2005. const cases: Array<{ lang: string; file: string; src: string }> = [
  2006. { lang: 'TypeScript (= new T)', file: 'svc.ts',
  2007. src: `class Logger { log() { return 1; } }\nexport function use() { const lg = new Logger(); return lg.log(); }\n` },
  2008. { lang: 'JavaScript (= new T)', file: 'svc.js',
  2009. src: `class Logger { log() { return 1; } }\nexport function use() { const lg = new Logger(); return lg.log(); }\n` },
  2010. { lang: 'Python (= T())', file: 'svc.py',
  2011. src: `class Logger:\n def log(self):\n return 1\ndef use():\n lg = Logger()\n return lg.log()\n` },
  2012. { lang: 'Java (T x = new T)', file: 'Svc.java',
  2013. src: `class Logger { void log() { int a = 1; } }\nclass Use { void run() { Logger lg = new Logger(); lg.log(); } }\n` },
  2014. { lang: 'C# (var x = new T)', file: 'Svc.cs',
  2015. src: `class Logger { void Log() { int a = 1; } }\nclass Use { void Run() { var lg = new Logger(); lg.Log(); } }\n` },
  2016. { lang: 'Kotlin (val x = T())', file: 'Svc.kt',
  2017. src: `class Logger { fun log(): Int { return 1 } }\nfun use(): Int { val lg = Logger(); return lg.log() }\n` },
  2018. { lang: 'Swift (let x = T())', file: 'svc.swift',
  2019. src: `class Logger { func log() -> Int { return 1 } }\nfunc use() -> Int { let lg = Logger(); return lg.log() }\n` },
  2020. { lang: 'Go (x := T{})', file: 'svc.go',
  2021. src: `package a\ntype Logger struct{}\nfunc (l Logger) Log() int { return 1 }\nfunc Use() int { lg := Logger{}; return lg.Log() }\n` },
  2022. { lang: 'Rust (let x = T{})', file: 'svc.rs',
  2023. src: `pub struct Logger { n: i32 }\nimpl Logger { pub fn log(&self) -> i32 { self.n } }\npub fn use_it() -> i32 { let lg = Logger { n: 1 }; lg.log() }\n` },
  2024. { lang: 'Dart (var x = T())', file: 'svc.dart',
  2025. src: `class Logger { int log() { return 1; } }\nint use() { var lg = Logger(); return lg.log(); }\n` },
  2026. { lang: 'PHP ($x = new T)', file: 'svc.php',
  2027. src: `<?php\nclass Logger { function log() { return 1; } }\nfunction useIt() { $lg = new Logger(); return $lg->log(); }\n` },
  2028. { lang: 'Scala (val x = new T)', file: 'Svc.scala',
  2029. src: `class Logger { def log(): Int = 1 }\nobject A { def use(): Int = { val lg = new Logger(); lg.log() } }\n` },
  2030. { lang: 'Ruby (x = T.new)', file: 'svc.rb',
  2031. src: `class Logger\n def log\n 1\n end\nend\ndef use\n lg = Logger.new\n lg.log\nend\n` },
  2032. { lang: 'Lua (x = T.new(); x:log())', file: 'svc.lua',
  2033. src: `local Logger = {}\nLogger.__index = Logger\nfunction Logger.new() return setmetatable({}, Logger) end\nfunction Logger:log() return 1 end\nlocal function use() local lg = Logger.new(); return lg:log() end\nreturn use\n` },
  2034. { lang: 'Luau (x = T.new(); x:log())', file: 'svc.luau',
  2035. src: `local Logger = {}\nLogger.__index = Logger\nfunction Logger.new() return setmetatable({}, Logger) end\nfunction Logger:log(): number return 1 end\nlocal function use(): number local lg = Logger.new(); return lg:log() end\nreturn use\n` },
  2036. { lang: 'R (x <- T$new(); x$log())', file: 'svc.R',
  2037. src: `Logger <- R6::R6Class("Logger", public = list(log = function() 1))\nuse <- function() { lg <- Logger$new(); lg$log() }\n` },
  2038. { lang: 'Pascal (var x: T; x.Method)', file: 'svc.pas',
  2039. src: `unit A;\ninterface\ntype TLogger = class function Log: Integer; end;\nimplementation\nfunction TLogger.Log: Integer; begin Result := 1; end;\nprocedure Use;\nvar lg: TLogger;\nbegin\n lg := TLogger.Create;\n lg.Log;\nend;\nend.\n` },
  2040. ];
  2041. for (const c of cases) {
  2042. it(`resolves a local-variable method call — ${c.lang}`, async () => {
  2043. fs.writeFileSync(path.join(tempDir, c.file), c.src);
  2044. cg = await CodeGraph.init(tempDir, { index: true });
  2045. cg.resolveReferences();
  2046. const logMethod = cg
  2047. .getNodesByKind('method')
  2048. .find((n) => n.name.toLowerCase() === 'log');
  2049. expect(logMethod, `${c.lang}: log method should be indexed`).toBeDefined();
  2050. // The enclosing caller resolves through the local variable to `log`.
  2051. const callers = cg.getCallers(logMethod!.id).map((x) => x.node.name);
  2052. expect(
  2053. callers.length,
  2054. `${c.lang}: log should have a caller (got [${callers.join(', ')}])`,
  2055. ).toBeGreaterThan(0);
  2056. });
  2057. }
  2058. it('Ruby: builds receiver.method and keeps Foo.new as an instantiation', async () => {
  2059. // The Ruby extractor previously took the receiver as the callee and
  2060. // dropped the method name (`lg.log()` -> a call to `lg`). Now it builds
  2061. // `lg.log`, while `Logger.new` must still record an instantiation.
  2062. fs.writeFileSync(
  2063. path.join(tempDir, 'svc.rb'),
  2064. `class Logger\n def log\n 1\n end\nend\ndef run\n lg = Logger.new\n lg.log\nend\n`,
  2065. );
  2066. cg = await CodeGraph.init(tempDir, { index: true });
  2067. cg.resolveReferences();
  2068. const run = cg.getNodesByKind('function').find((n) => n.name === 'run')!;
  2069. const logMethod = cg.getNodesByKind('method').find((n) => n.name === 'log')!;
  2070. const logger = cg.getNodesByKind('class').find((n) => n.name === 'Logger')!;
  2071. const out = cg.getOutgoingEdges(run.id);
  2072. // lg.log resolved to the method (the receiver-type inference kicked in).
  2073. expect(out.some((e) => e.kind === 'calls' && e.target === logMethod.id)).toBe(true);
  2074. // Logger.new is still an instantiation of the class.
  2075. expect(out.some((e) => e.kind === 'instantiates' && e.target === logger.id)).toBe(true);
  2076. });
  2077. it('TypeScript: infers a typed-parameter receiver, disambiguating same-named methods (#1125)', async () => {
  2078. // A typed function parameter used as a receiver — `function use(lg: Logger)`
  2079. // — never matched the old TS/JS pattern (it required a const|let|var
  2080. // prefix), so `lg.log()` fell through to no edge once a second class shared
  2081. // the method name. Two ambiguous classes are load-bearing here: a
  2082. // single-class version resolves via a same-name fallback even without
  2083. // inference, so only the collision proves type inference actually fired.
  2084. fs.writeFileSync(
  2085. path.join(tempDir, 'svc.ts'),
  2086. `class Logger { log() { return 1; } }\n` +
  2087. `class Other { log() { return 2; } }\n` +
  2088. `export function use(lg: Logger) { return lg.log(); }\n` +
  2089. `export function useOther(o: Other) { return o.log(); }\n`,
  2090. );
  2091. cg = await CodeGraph.init(tempDir, { index: true });
  2092. cg.resolveReferences();
  2093. const classes = cg.getNodesByKind('class');
  2094. const logger = classes.find((n) => n.name === 'Logger')!;
  2095. const other = classes.find((n) => n.name === 'Other')!;
  2096. const logs = cg.getNodesByKind('method').filter((n) => n.name === 'log');
  2097. expect(logs.length, 'both log methods should be indexed').toBe(2);
  2098. // Associate each same-named `log` with its class by line containment.
  2099. const inClass = (m: (typeof logs)[number], c: typeof logger) =>
  2100. m.startLine >= c.startLine && m.startLine <= (c.endLine ?? c.startLine);
  2101. const loggerLog = logs.find((m) => inClass(m, logger))!;
  2102. const otherLog = logs.find((m) => inClass(m, other))!;
  2103. expect(loggerLog, "Logger's log").toBeDefined();
  2104. expect(otherLog, "Other's log").toBeDefined();
  2105. const loggerCallers = cg.getCallers(loggerLog.id).map((x) => x.node.name);
  2106. const otherCallers = cg.getCallers(otherLog.id).map((x) => x.node.name);
  2107. // Each typed-param call routes to its OWN class's method, not the other's.
  2108. expect(loggerCallers).toContain('use');
  2109. expect(loggerCallers).not.toContain('useOther');
  2110. expect(otherCallers).toContain('useOther');
  2111. expect(otherCallers).not.toContain('use');
  2112. });
  2113. // The same typed-parameter gap existed in every language whose pattern set
  2114. // only matched keyword-anchored locals (let/var/:=/= new), not the bare
  2115. // parameter form — Rust, Go, Dart, PHP (#1125). Each case: two classes
  2116. // sharing a method name + two functions taking one as a typed param; a
  2117. // correct fix routes each call to its OWN type's method (the collision is
  2118. // load-bearing — a single class resolves via the same-name fallback either
  2119. // way). Method↔type association is by qualifiedName, robust where the method
  2120. // lives outside the type's line range (Rust `impl`, Go method decl).
  2121. const typedParamCases: Array<{
  2122. lang: string; file: string; method: string; callerA: string; callerB: string; src: string;
  2123. }> = [
  2124. { lang: 'Rust (fn f(x: &T))', file: 'svc.rs', method: 'log', callerA: 'use_it', callerB: 'use_other',
  2125. src: `pub struct Logger { n: i32 }\nimpl Logger { pub fn log(&self) -> i32 { self.n } }\npub struct Other { n: i32 }\nimpl Other { pub fn log(&self) -> i32 { self.n } }\npub fn use_it(lg: &Logger) -> i32 { lg.log() }\npub fn use_other(o: &Other) -> i32 { o.log() }\n` },
  2126. { lang: 'Go (func f(x T))', file: 'svc.go', method: 'Log', callerA: 'UseIt', callerB: 'UseOther',
  2127. src: `package a\ntype Logger struct{}\nfunc (l Logger) Log() int { return 1 }\ntype Other struct{}\nfunc (o Other) Log() int { return 2 }\nfunc UseIt(lg Logger) int { return lg.Log() }\nfunc UseOther(o Other) int { return o.Log() }\n` },
  2128. { lang: 'Dart (T f(U x))', file: 'svc.dart', method: 'log', callerA: 'useIt', callerB: 'useOther',
  2129. src: `class Logger { int log() { return 1; } }\nclass Other { int log() { return 2; } }\nint useIt(Logger lg) { return lg.log(); }\nint useOther(Other o) { return o.log(); }\n` },
  2130. { lang: 'PHP (f(T $x))', file: 'svc.php', method: 'log', callerA: 'useIt', callerB: 'useOther',
  2131. src: `<?php\nclass Logger { function log() { return 1; } }\nclass Other { function log() { return 2; } }\nfunction useIt(Logger $lg) { return $lg->log(); }\nfunction useOther(Other $o) { return $o->log(); }\n` },
  2132. ];
  2133. for (const c of typedParamCases) {
  2134. it(`infers a typed-parameter receiver, disambiguating same-named methods — ${c.lang} (#1125)`, async () => {
  2135. fs.writeFileSync(path.join(tempDir, c.file), c.src);
  2136. cg = await CodeGraph.init(tempDir, { index: true });
  2137. cg.resolveReferences();
  2138. const methods = cg.getNodesByKind('method').filter((n) => n.name === c.method);
  2139. expect(methods.length, `${c.lang}: both ${c.method} methods indexed`).toBe(2);
  2140. const loggerLog = methods.find((m) => /Logger/.test(m.qualifiedName ?? ''));
  2141. const otherLog = methods.find((m) => /Other/.test(m.qualifiedName ?? ''));
  2142. expect(loggerLog, `${c.lang}: Logger's ${c.method}`).toBeDefined();
  2143. expect(otherLog, `${c.lang}: Other's ${c.method}`).toBeDefined();
  2144. const loggerCallers = cg.getCallers(loggerLog!.id).map((x) => x.node.name);
  2145. const otherCallers = cg.getCallers(otherLog!.id).map((x) => x.node.name);
  2146. expect(loggerCallers, `${c.lang}: Logger callers`).toContain(c.callerA);
  2147. expect(loggerCallers, `${c.lang}: Logger callers`).not.toContain(c.callerB);
  2148. expect(otherCallers, `${c.lang}: Other callers`).toContain(c.callerB);
  2149. expect(otherCallers, `${c.lang}: Other callers`).not.toContain(c.callerA);
  2150. });
  2151. }
  2152. // Lua/Luau: a PascalCase method call (`lg:Log()`, the Roblox convention)
  2153. // is the identical `receiver:Name` shape as a Luau type annotation, so it
  2154. // self-matched the annotation pattern on the call's own line and inferred
  2155. // "type = Log" (#1124). Two things are load-bearing in these fixtures:
  2156. // the declaration sits on an EARLIER line than the call (on one line,
  2157. // pattern order resolves it — the `.new` pattern wins first), and TWO
  2158. // classes share the method name (a single class resolves via the
  2159. // same-name fallback even when inference misfires). Luau's `useLogger`
  2160. // takes a typed param instead of calling `.new()`, pinning that the
  2161. // gated pattern still matches a genuine annotation.
  2162. const pascalMethodCases: Array<{ lang: string; file: string; src: string }> = [
  2163. { lang: 'Lua', file: 'svc.lua',
  2164. src: `local Logger = {}\nLogger.__index = Logger\nfunction Logger.new() return setmetatable({}, Logger) end\nfunction Logger:Log() return 1 end\n\nlocal Other = {}\nOther.__index = Other\nfunction Other.new() return setmetatable({}, Other) end\nfunction Other:Log() return 2 end\n\nlocal function useLogger()\n\tlocal lg = Logger.new()\n\treturn lg:Log()\nend\n\nlocal function useOther()\n\tlocal o = Other.new()\n\treturn o:Log()\nend\n\nreturn useLogger, useOther\n` },
  2165. { lang: 'Luau', file: 'svc.luau',
  2166. src: `local Logger = {}\nLogger.__index = Logger\nfunction Logger.new() return setmetatable({}, Logger) end\nfunction Logger:Log(): number return 1 end\n\nlocal Other = {}\nOther.__index = Other\nfunction Other.new() return setmetatable({}, Other) end\nfunction Other:Log(): number return 2 end\n\nlocal function useLogger(lg: Logger): number\n\treturn lg:Log()\nend\n\nlocal function useOther(): number\n\tlocal o = Other.new()\n\treturn o:Log()\nend\n\nreturn useLogger, useOther\n` },
  2167. ];
  2168. for (const c of pascalMethodCases) {
  2169. it(`resolves a PascalCase method call without self-matching the annotation pattern — ${c.lang} (#1124)`, async () => {
  2170. fs.writeFileSync(path.join(tempDir, c.file), c.src);
  2171. cg = await CodeGraph.init(tempDir, { index: true });
  2172. cg.resolveReferences();
  2173. const methods = cg.getNodesByKind('method').filter((n) => n.name === 'Log');
  2174. expect(methods.length, `${c.lang}: both Log methods indexed`).toBe(2);
  2175. const loggerLog = methods.find((m) => /Logger/.test(m.qualifiedName ?? ''));
  2176. const otherLog = methods.find((m) => /Other/.test(m.qualifiedName ?? ''));
  2177. expect(loggerLog, `${c.lang}: Logger's Log`).toBeDefined();
  2178. expect(otherLog, `${c.lang}: Other's Log`).toBeDefined();
  2179. const loggerCallers = cg.getCallers(loggerLog!.id).map((x) => x.node.name);
  2180. const otherCallers = cg.getCallers(otherLog!.id).map((x) => x.node.name);
  2181. expect(loggerCallers, `${c.lang}: Logger callers`).toContain('useLogger');
  2182. expect(loggerCallers, `${c.lang}: Logger callers`).not.toContain('useOther');
  2183. expect(otherCallers, `${c.lang}: Other callers`).toContain('useOther');
  2184. expect(otherCallers, `${c.lang}: Other callers`).not.toContain('useLogger');
  2185. });
  2186. }
  2187. });
  2188. describe('Name Matcher: kind bias for new ref kinds', () => {
  2189. const baseContext = (candidates: Node[]): ResolutionContext => ({
  2190. getNodesInFile: () => [],
  2191. getNodesByName: (name) => candidates.filter((c) => c.name === name),
  2192. getNodesByQualifiedName: () => [],
  2193. getNodesByKind: () => [],
  2194. fileExists: () => true,
  2195. readFile: () => null,
  2196. getProjectRoot: () => '/test',
  2197. getAllFiles: () => [],
  2198. getNodesByLowerName: () => [],
  2199. getImportMappings: () => [],
  2200. });
  2201. it('prefers a class candidate over a function for `instantiates` refs', () => {
  2202. // A class and a function share a name across the codebase.
  2203. // Without the kind bias, the function (which gets the +25 `calls`
  2204. // bonus historically applied to all candidates of that kind) would
  2205. // win. Now the instantiates branch reverses it.
  2206. const fn: Node = {
  2207. id: 'func:utils.ts:Logger:5', kind: 'function', name: 'Logger',
  2208. qualifiedName: 'utils.ts::Logger', filePath: 'utils.ts', language: 'typescript',
  2209. startLine: 5, endLine: 7, startColumn: 0, endColumn: 0, updatedAt: Date.now(),
  2210. };
  2211. const cls: Node = {
  2212. id: 'class:logger.ts:Logger:10', kind: 'class', name: 'Logger',
  2213. qualifiedName: 'logger.ts::Logger', filePath: 'logger.ts', language: 'typescript',
  2214. startLine: 10, endLine: 30, startColumn: 0, endColumn: 0, updatedAt: Date.now(),
  2215. };
  2216. const ref = {
  2217. fromNodeId: 'func:main.ts:bootstrap:1',
  2218. referenceName: 'Logger',
  2219. referenceKind: 'instantiates' as const,
  2220. line: 5, column: 0, filePath: 'main.ts', language: 'typescript' as const,
  2221. };
  2222. const result = matchReference(ref, baseContext([fn, cls]));
  2223. expect(result?.targetNodeId).toBe('class:logger.ts:Logger:10');
  2224. });
  2225. it('prefers a union candidate over a function for `instantiates` refs', () => {
  2226. const fn: Node = {
  2227. id: 'func:packet.cpp:Packet:5', kind: 'function', name: 'Packet',
  2228. qualifiedName: 'packet.cpp::Packet', filePath: 'packet.cpp', language: 'cpp',
  2229. startLine: 5, endLine: 7, startColumn: 0, endColumn: 0, updatedAt: Date.now(),
  2230. };
  2231. const union: Node = {
  2232. id: 'union:packet.hpp:Packet:10', kind: 'union', name: 'Packet',
  2233. qualifiedName: 'packet.hpp::Packet', filePath: 'packet.hpp', language: 'cpp',
  2234. startLine: 10, endLine: 14, startColumn: 0, endColumn: 0, updatedAt: Date.now(),
  2235. };
  2236. const ref = {
  2237. fromNodeId: 'func:main.cpp:initialize:1',
  2238. referenceName: 'Packet',
  2239. referenceKind: 'instantiates' as const,
  2240. line: 5, column: 0, filePath: 'main.cpp', language: 'cpp' as const,
  2241. };
  2242. const result = matchReference(ref, baseContext([fn, union]));
  2243. expect(result?.targetNodeId).toBe('union:packet.hpp:Packet:10');
  2244. });
  2245. it('prefers a function candidate over a non-function for `decorates` refs', () => {
  2246. const variable: Node = {
  2247. id: 'var:config.ts:Inject:5', kind: 'variable', name: 'Inject',
  2248. qualifiedName: 'config.ts::Inject', filePath: 'config.ts', language: 'typescript',
  2249. startLine: 5, endLine: 5, startColumn: 0, endColumn: 0, updatedAt: Date.now(),
  2250. };
  2251. const decorator: Node = {
  2252. id: 'func:di.ts:Inject:10', kind: 'function', name: 'Inject',
  2253. qualifiedName: 'di.ts::Inject', filePath: 'di.ts', language: 'typescript',
  2254. startLine: 10, endLine: 20, startColumn: 0, endColumn: 0, updatedAt: Date.now(),
  2255. };
  2256. const ref = {
  2257. fromNodeId: 'class:svc.ts:UserService:1',
  2258. referenceName: 'Inject',
  2259. referenceKind: 'decorates' as const,
  2260. line: 5, column: 0, filePath: 'svc.ts', language: 'typescript' as const,
  2261. };
  2262. const result = matchReference(ref, baseContext([variable, decorator]));
  2263. expect(result?.targetNodeId).toBe('func:di.ts:Inject:10');
  2264. });
  2265. });
  2266. describe('tsconfig path aliases', () => {
  2267. it('resolves an aliased import to the alias-mapped file (not a same-named file elsewhere)', async () => {
  2268. // Two same-named exports in different directories. Without alias
  2269. // resolution, name-matcher would pick whichever it finds first;
  2270. // with alias resolution, the import path uniquely picks one.
  2271. fs.mkdirSync(path.join(tempDir, 'src/utils'), { recursive: true });
  2272. fs.mkdirSync(path.join(tempDir, 'src/legacy'), { recursive: true });
  2273. fs.writeFileSync(
  2274. path.join(tempDir, 'src/utils/format.ts'),
  2275. `export function pickMe(): number { return 1; }\n`
  2276. );
  2277. fs.writeFileSync(
  2278. path.join(tempDir, 'src/legacy/format.ts'),
  2279. `export function pickMe(): number { return 99; }\n`
  2280. );
  2281. fs.writeFileSync(
  2282. path.join(tempDir, 'src/main.ts'),
  2283. `import { pickMe } from '@utils/format';\nexport function go(): number { return pickMe(); }\n`
  2284. );
  2285. fs.writeFileSync(
  2286. path.join(tempDir, 'tsconfig.json'),
  2287. JSON.stringify({
  2288. compilerOptions: {
  2289. baseUrl: './src',
  2290. paths: { '@utils/*': ['utils/*'] },
  2291. },
  2292. })
  2293. );
  2294. cg = await CodeGraph.init(tempDir, { index: true });
  2295. cg.resolveReferences();
  2296. // The two pickMe nodes live in different files. The aliased
  2297. // import should attach the call edge to the @utils-mapped one,
  2298. // not the legacy duplicate.
  2299. const all = cg.getNodesByKind('function').filter((n) => n.name === 'pickMe');
  2300. const utilsNode = all.find((n) => n.filePath === 'src/utils/format.ts');
  2301. const legacyNode = all.find((n) => n.filePath === 'src/legacy/format.ts');
  2302. expect(utilsNode).toBeDefined();
  2303. expect(legacyNode).toBeDefined();
  2304. const utilsCallers = cg.getCallers(utilsNode!.id);
  2305. const legacyCallers = cg.getCallers(legacyNode!.id);
  2306. expect(utilsCallers.length).toBeGreaterThan(0);
  2307. expect(utilsCallers.some((c) => c.node.filePath === 'src/main.ts')).toBe(true);
  2308. // The legacy node should NOT have a caller from src/main.ts —
  2309. // the alias correctly picked the utils version.
  2310. expect(legacyCallers.some((c) => c.node.filePath === 'src/main.ts')).toBe(false);
  2311. });
  2312. it('falls back gracefully when tsconfig is absent', async () => {
  2313. fs.mkdirSync(path.join(tempDir, 'src'), { recursive: true });
  2314. fs.writeFileSync(
  2315. path.join(tempDir, 'src/a.ts'),
  2316. `export function aFn(): void {}\n`
  2317. );
  2318. fs.writeFileSync(
  2319. path.join(tempDir, 'src/b.ts'),
  2320. `import { aFn } from './a';\nexport function bFn(): void { aFn(); }\n`
  2321. );
  2322. cg = await CodeGraph.init(tempDir, { index: true });
  2323. // No tsconfig present — index should still complete and the
  2324. // relative-import-based call edge should be created.
  2325. const aFn = cg.getNodesByKind('function').find((n) => n.name === 'aFn');
  2326. expect(aFn).toBeDefined();
  2327. const callers = cg.getCallers(aFn!.id);
  2328. expect(callers.some((c) => c.node.filePath === 'src/b.ts')).toBe(true);
  2329. });
  2330. });
  2331. describe('re-export chain following', () => {
  2332. it('chases a 3-hop barrel chain (wildcard → named → declaration)', async () => {
  2333. // main.ts → all.ts (wildcard) → index.ts (named) → auth.ts (declaration).
  2334. // Without chain following, `signIn` resolves to nothing because
  2335. // none of the barrel files declare it directly.
  2336. fs.mkdirSync(path.join(tempDir, 'src/services'), { recursive: true });
  2337. fs.writeFileSync(
  2338. path.join(tempDir, 'src/services/auth.ts'),
  2339. `export function signIn(): void {}\n`
  2340. );
  2341. fs.writeFileSync(
  2342. path.join(tempDir, 'src/services/index.ts'),
  2343. `export { signIn } from './auth';\n`
  2344. );
  2345. fs.writeFileSync(
  2346. path.join(tempDir, 'src/all.ts'),
  2347. `export * from './services/index';\n`
  2348. );
  2349. fs.writeFileSync(
  2350. path.join(tempDir, 'src/main.ts'),
  2351. `import { signIn } from './all';\nexport function go(): void { signIn(); }\n`
  2352. );
  2353. cg = await CodeGraph.init(tempDir, { index: true });
  2354. cg.resolveReferences();
  2355. const signInNode = cg
  2356. .getNodesByKind('function')
  2357. .find((n) => n.name === 'signIn' && n.filePath === 'src/services/auth.ts');
  2358. expect(signInNode).toBeDefined();
  2359. const callers = cg.getCallers(signInNode!.id);
  2360. expect(callers.some((c) => c.node.filePath === 'src/main.ts')).toBe(true);
  2361. });
  2362. it('follows a renamed named re-export (export { foo as bar } from ...)', async () => {
  2363. // The chase has to look up `foo` in the upstream module even
  2364. // though the importer asked for `bar` — exercises the rename
  2365. // branch of findExportedSymbol.
  2366. fs.mkdirSync(path.join(tempDir, 'src'), { recursive: true });
  2367. fs.writeFileSync(
  2368. path.join(tempDir, 'src/auth.ts'),
  2369. `export function signIn(): void {}\n`
  2370. );
  2371. fs.writeFileSync(
  2372. path.join(tempDir, 'src/index.ts'),
  2373. `export { signIn as login } from './auth';\n`
  2374. );
  2375. fs.writeFileSync(
  2376. path.join(tempDir, 'src/main.ts'),
  2377. `import { login } from './index';\nexport function go(): void { login(); }\n`
  2378. );
  2379. cg = await CodeGraph.init(tempDir, { index: true });
  2380. cg.resolveReferences();
  2381. const signInNode = cg
  2382. .getNodesByKind('function')
  2383. .find((n) => n.name === 'signIn' && n.filePath === 'src/auth.ts');
  2384. expect(signInNode).toBeDefined();
  2385. const callers = cg.getCallers(signInNode!.id);
  2386. expect(callers.some((c) => c.node.filePath === 'src/main.ts')).toBe(true);
  2387. });
  2388. it('follows a default re-export of a .svelte component (export { default as Foo } from ./RealButton.svelte) (#629)', async () => {
  2389. // The ubiquitous Svelte/React component-barrel form. The leaf is a
  2390. // .svelte component (extracted as kind 'component', the default
  2391. // export). The re-export ALIAS (`Foo`) deliberately differs from the
  2392. // component's real name (`RealButton`) so the name-matcher fallback
  2393. // can't coincidentally connect them — the only path to the edge is
  2394. // the import-chase, which must match a `component` (not just
  2395. // function/class) for the default export. Otherwise the
  2396. // consumer↔component edge is never created and `callers` returns a
  2397. // false 0.
  2398. fs.mkdirSync(path.join(tempDir, 'src/lib'), { recursive: true });
  2399. fs.writeFileSync(
  2400. path.join(tempDir, 'src/lib/RealButton.svelte'),
  2401. `<script lang="ts">\n export let label: string = '';\n</script>\n\n<button>{label}</button>\n`
  2402. );
  2403. fs.writeFileSync(
  2404. path.join(tempDir, 'src/lib/index.ts'),
  2405. `export { default as Foo } from './RealButton.svelte';\n`
  2406. );
  2407. fs.writeFileSync(
  2408. path.join(tempDir, 'src/Bar.svelte'),
  2409. `<script lang="ts">\n import { Foo } from './lib';\n</script>\n\n<Foo />\n`
  2410. );
  2411. cg = await CodeGraph.init(tempDir, { index: true });
  2412. cg.resolveReferences();
  2413. const fooNode = cg
  2414. .getNodesByKind('component')
  2415. .find((n) => n.name === 'RealButton' && n.filePath === 'src/lib/RealButton.svelte');
  2416. expect(fooNode).toBeDefined();
  2417. const callers = cg.getCallers(fooNode!.id);
  2418. expect(callers.some((c) => c.node.filePath === 'src/Bar.svelte')).toBe(true);
  2419. });
  2420. it('links an .astro page to the component and TS util it uses (#768)', async () => {
  2421. // The canonical Astro shape: a page imports a layout/component in
  2422. // frontmatter and uses it as a template tag; the component's template
  2423. // calls an imported .ts util. Both hops must produce graph edges or
  2424. // an Astro project is invisible to callers/impact.
  2425. fs.mkdirSync(path.join(tempDir, 'src/components'), { recursive: true });
  2426. fs.mkdirSync(path.join(tempDir, 'src/utils'), { recursive: true });
  2427. fs.mkdirSync(path.join(tempDir, 'src/pages'), { recursive: true });
  2428. fs.writeFileSync(
  2429. path.join(tempDir, 'src/utils/format.ts'),
  2430. `export function formatDate(d: Date): string { return d.toISOString(); }\n`
  2431. );
  2432. fs.writeFileSync(
  2433. path.join(tempDir, 'src/components/PostCard.astro'),
  2434. `---\nimport { formatDate } from '../utils/format';\nconst { date } = Astro.props;\n---\n<time>{formatDate(date)}</time>\n`
  2435. );
  2436. fs.writeFileSync(
  2437. path.join(tempDir, 'src/pages/index.astro'),
  2438. `---\nimport PostCard from '../components/PostCard.astro';\n---\n<PostCard date={new Date()} />\n`
  2439. );
  2440. cg = await CodeGraph.init(tempDir, { index: true });
  2441. cg.resolveReferences();
  2442. // Hop 1: page → component (template tag through the frontmatter import)
  2443. const cardNode = cg
  2444. .getNodesByKind('component')
  2445. .find((n) => n.name === 'PostCard' && n.filePath === 'src/components/PostCard.astro');
  2446. expect(cardNode).toBeDefined();
  2447. const cardCallers = cg.getCallers(cardNode!.id);
  2448. expect(cardCallers.some((c) => c.node.filePath === 'src/pages/index.astro')).toBe(true);
  2449. // Hop 2: component template call → .ts util
  2450. const fmtNode = cg
  2451. .getNodesByKind('function')
  2452. .find((n) => n.name === 'formatDate' && n.filePath === 'src/utils/format.ts');
  2453. expect(fmtNode).toBeDefined();
  2454. const fmtCallers = cg.getCallers(fmtNode!.id);
  2455. expect(fmtCallers.some((c) => c.node.filePath === 'src/components/PostCard.astro')).toBe(true);
  2456. });
  2457. it('resolves a bare directory import (import { x } from "." / "./") to index.ts (#629)', async () => {
  2458. // `import { helper } from '.'` (or './') must map to the
  2459. // directory's index.ts before the re-export chase can run. The
  2460. // barrel renames `realHelper` → `helper` so the name-matcher can't
  2461. // mask a path-resolution failure: only the bare-dir resolution +
  2462. // rename chase can connect the edge.
  2463. fs.mkdirSync(path.join(tempDir, 'src'), { recursive: true });
  2464. fs.writeFileSync(
  2465. path.join(tempDir, 'src/util.ts'),
  2466. `export function realHelper(): void {}\n`
  2467. );
  2468. fs.writeFileSync(
  2469. path.join(tempDir, 'src/index.ts'),
  2470. `export { realHelper as helper } from './util';\n`
  2471. );
  2472. fs.writeFileSync(
  2473. path.join(tempDir, 'src/main.ts'),
  2474. `import { helper } from '.';\nexport function go(): void { helper(); }\n`
  2475. );
  2476. fs.writeFileSync(
  2477. path.join(tempDir, 'src/main2.ts'),
  2478. `import { helper } from './';\nexport function go2(): void { helper(); }\n`
  2479. );
  2480. cg = await CodeGraph.init(tempDir, { index: true });
  2481. cg.resolveReferences();
  2482. const helperNode = cg
  2483. .getNodesByKind('function')
  2484. .find((n) => n.name === 'realHelper' && n.filePath === 'src/util.ts');
  2485. expect(helperNode).toBeDefined();
  2486. const callers = cg.getCallers(helperNode!.id);
  2487. expect(callers.some((c) => c.node.filePath === 'src/main.ts')).toBe(true);
  2488. expect(callers.some((c) => c.node.filePath === 'src/main2.ts')).toBe(true);
  2489. });
  2490. it('resolves a workspace package-subpath barrel (@scope/pkg/sub) to its index (#629)', async () => {
  2491. // bun/npm/pnpm workspace: `@scope/ui/widgets` → the `ui` package's
  2492. // `widgets/` subdir index, which re-exports a .svelte component.
  2493. // Alias `Thing` ≠ component `Widget` defeats the name-matcher, so
  2494. // only workspace-package resolution can connect the edge.
  2495. fs.mkdirSync(path.join(tempDir, 'packages/ui/widgets'), { recursive: true });
  2496. fs.writeFileSync(
  2497. path.join(tempDir, 'package.json'),
  2498. JSON.stringify({ name: 'root', private: true, workspaces: ['packages/*'] }, null, 2)
  2499. );
  2500. fs.writeFileSync(
  2501. path.join(tempDir, 'packages/ui/package.json'),
  2502. JSON.stringify({ name: '@scope/ui', version: '1.0.0' }, null, 2)
  2503. );
  2504. fs.writeFileSync(
  2505. path.join(tempDir, 'packages/ui/widgets/Widget.svelte'),
  2506. `<script lang="ts">\n export let label: string = '';\n</script>\n\n<button>{label}</button>\n`
  2507. );
  2508. fs.writeFileSync(
  2509. path.join(tempDir, 'packages/ui/widgets/index.ts'),
  2510. `export { default as Thing } from './Widget.svelte';\n`
  2511. );
  2512. fs.mkdirSync(path.join(tempDir, 'app'), { recursive: true });
  2513. fs.writeFileSync(
  2514. path.join(tempDir, 'app/App.svelte'),
  2515. `<script lang="ts">\n import { Thing } from '@scope/ui/widgets';\n</script>\n\n<Thing />\n`
  2516. );
  2517. cg = await CodeGraph.init(tempDir, { index: true });
  2518. cg.resolveReferences();
  2519. const buttonNode = cg
  2520. .getNodesByKind('component')
  2521. .find((n) => n.name === 'Widget' && n.filePath === 'packages/ui/widgets/Widget.svelte');
  2522. expect(buttonNode).toBeDefined();
  2523. const callers = cg.getCallers(buttonNode!.id);
  2524. expect(callers.some((c) => c.node.filePath === 'app/App.svelte')).toBe(true);
  2525. });
  2526. it('resolves a barrel import from a Vue SFC <script> block (#629)', async () => {
  2527. // The same import-resolution gaps (no SFC import mappings, no SFC
  2528. // extension list, barrel parsed in the consumer's language) broke
  2529. // Vue SFCs too. Guards the resolver-side generalization to `.vue`.
  2530. // The barrel renames `realRun` → `run` so only the import-chase (not
  2531. // the name-matcher) can connect the call.
  2532. fs.mkdirSync(path.join(tempDir, 'src'), { recursive: true });
  2533. fs.writeFileSync(
  2534. path.join(tempDir, 'src/util.ts'),
  2535. `export function realRun(): void {}\n`
  2536. );
  2537. fs.writeFileSync(
  2538. path.join(tempDir, 'src/index.ts'),
  2539. `export { realRun as run } from './util';\n`
  2540. );
  2541. fs.writeFileSync(
  2542. path.join(tempDir, 'src/App.vue'),
  2543. `<script lang="ts">\nimport { run } from './';\nexport default { mounted() { run(); } };\n</script>\n<template><div/></template>\n`
  2544. );
  2545. cg = await CodeGraph.init(tempDir, { index: true });
  2546. cg.resolveReferences();
  2547. const runNode = cg
  2548. .getNodesByKind('function')
  2549. .find((n) => n.name === 'realRun' && n.filePath === 'src/util.ts');
  2550. expect(runNode).toBeDefined();
  2551. const callers = cg.getCallers(runNode!.id);
  2552. expect(callers.some((c) => c.node.filePath === 'src/App.vue')).toBe(true);
  2553. });
  2554. it('follows a Vue component used in a <template> through a default re-export barrel (#629)', async () => {
  2555. // End-to-end Vue analogue of the Svelte case: the leaf is a `.vue`
  2556. // component re-exported under an alias (`Thing`) that differs from its
  2557. // real name (`Widget`), and the consumer uses it ONLY in markup
  2558. // (`<Thing />`). Requires both the new template-tag extraction AND the
  2559. // barrel default-export chase to connect the edge.
  2560. fs.mkdirSync(path.join(tempDir, 'src/lib'), { recursive: true });
  2561. fs.writeFileSync(
  2562. path.join(tempDir, 'src/lib/Widget.vue'),
  2563. `<script setup lang="ts">\ndefineProps<{ label?: string }>();\n</script>\n<template><button>x</button></template>\n`
  2564. );
  2565. fs.writeFileSync(
  2566. path.join(tempDir, 'src/lib/index.ts'),
  2567. `export { default as Thing } from './Widget.vue';\n`
  2568. );
  2569. fs.writeFileSync(
  2570. path.join(tempDir, 'src/App.vue'),
  2571. `<script setup lang="ts">\nimport { Thing } from './lib';\n</script>\n<template>\n <Thing />\n</template>\n`
  2572. );
  2573. cg = await CodeGraph.init(tempDir, { index: true });
  2574. cg.resolveReferences();
  2575. const widgetNode = cg
  2576. .getNodesByKind('component')
  2577. .find((n) => n.name === 'Widget' && n.filePath === 'src/lib/Widget.vue');
  2578. expect(widgetNode).toBeDefined();
  2579. const callers = cg.getCallers(widgetNode!.id);
  2580. expect(callers.some((c) => c.node.filePath === 'src/App.vue')).toBe(true);
  2581. });
  2582. });
  2583. describe('Literal receivers and nested-local scope (#1230)', () => {
  2584. // Two stacked fabrications: `", ".join(...)` (a builtin on a string
  2585. // literal) exact-matched a project function named `join` — one that was
  2586. // moreover nested inside a DIFFERENT function and thus lexically
  2587. // unreachable. Literal receivers now emit no call ref at all, and
  2588. // exact-match refuses candidates nested in a function the ref isn't in.
  2589. it("str-literal builtin calls don't bind to project symbols; nested locals only resolve from inside their container", async () => {
  2590. const tmpDir = fs.mkdtempSync(path.join(os.tmpdir(), 'codegraph-1230-'));
  2591. try {
  2592. fs.writeFileSync(
  2593. path.join(tmpDir, 'repro.py'),
  2594. `def format_fields(values):
  2595. def join(vals):
  2596. return "-".join(sorted(vals))
  2597. return join(values)
  2598. def report_missing(unresolved):
  2599. missing_list = ", ".join(sorted(unresolved))
  2600. return f"Could not resolve: {missing_list}"
  2601. `
  2602. );
  2603. const cg = CodeGraph.initSync(tmpDir);
  2604. await cg.indexAll();
  2605. const join = (await cg.searchNodes('join', { limit: 5 })).find(
  2606. (r) => r.node.kind === 'function' && r.node.name === 'join'
  2607. );
  2608. expect(join).toBeDefined();
  2609. // Exactly one caller: the enclosing format_fields. Neither
  2610. // report_missing (literal receiver) nor join itself (its own literal
  2611. // "-".join) may appear.
  2612. const callers = await cg.getCallers(join!.node.id);
  2613. expect(callers.map((c) => c.node.name)).toEqual(['format_fields']);
  2614. // report_missing has zero project callees.
  2615. const reportMissing = (await cg.searchNodes('report_missing', { limit: 5 })).find(
  2616. (r) => r.node.kind === 'function'
  2617. );
  2618. const callees = await cg.getCallees(reportMissing!.node.id);
  2619. expect(callees.filter((c) => c.node.name === 'join')).toHaveLength(0);
  2620. cg.close();
  2621. } finally {
  2622. fs.rmSync(tmpDir, { recursive: true, force: true });
  2623. }
  2624. }, 30000);
  2625. });
  2626. describe('Go field-chain receiver calls (#1276)', () => {
  2627. // `target.conn.Exec(...)` where `conn *sql.DB` used to emit a BARE `Exec`
  2628. // ref, which exact-matched the only local `Exec` — an unrelated
  2629. // interface's method — fabricating an internal dependency. Chained Go
  2630. // receivers now resolve exclusively via validated field-hop inference:
  2631. // external field types produce NO edge; in-project ones produce the
  2632. // correct edge (new recall).
  2633. it('external receiver types produce no edge; in-project field chains resolve correctly', async () => {
  2634. const tmpDir = fs.mkdtempSync(path.join(os.tmpdir(), 'codegraph-1276-'));
  2635. try {
  2636. fs.writeFileSync(path.join(tmpDir, 'go.mod'), 'module example.com/app\n\ngo 1.22\n');
  2637. fs.mkdirSync(path.join(tmpDir, 'flow'));
  2638. fs.writeFileSync(
  2639. path.join(tmpDir, 'flow', 'flow.go'),
  2640. `package flow
  2641. import "database/sql"
  2642. type InternalStore interface {
  2643. Exec(string, ...any) (sql.Result, error)
  2644. QueryRow(string, ...any) *sql.Row
  2645. }
  2646. type Target struct{ conn *sql.DB }
  2647. func (target *Target) Write() error {
  2648. _, err := target.conn.Exec("insert")
  2649. return err
  2650. }
  2651. func (target *Target) Read() *sql.Row {
  2652. return target.conn.QueryRow("select")
  2653. }
  2654. type Store struct{}
  2655. func (s *Store) Put(key string) {}
  2656. type Repo struct{ db *Store }
  2657. func (r *Repo) Save() {
  2658. r.db.Put("k")
  2659. }
  2660. `
  2661. );
  2662. const cg = CodeGraph.initSync(tmpDir);
  2663. await cg.indexAll();
  2664. // The unrelated local interface's methods have NO callers — the
  2665. // external sql.DB calls must not bind to them.
  2666. const execDecl = (await cg.searchNodes('Exec', { limit: 10 })).find(
  2667. (r) => r.node.kind === 'method'
  2668. );
  2669. if (execDecl) {
  2670. const execCallers = await cg.getCallers(execDecl.node.id);
  2671. expect(execCallers.map((c) => c.node.name)).not.toContain('Write');
  2672. }
  2673. const qrDecl = (await cg.searchNodes('QueryRow', { limit: 10 })).find(
  2674. (r) => r.node.kind === 'method'
  2675. );
  2676. if (qrDecl) {
  2677. const qrCallers = await cg.getCallers(qrDecl.node.id);
  2678. expect(qrCallers.map((c) => c.node.name)).not.toContain('Read');
  2679. }
  2680. // The in-project field chain resolves (validated), gaining an edge the
  2681. // bare-name era never produced.
  2682. const put = (await cg.searchNodes('Put', { limit: 10 })).find(
  2683. (r) => r.node.kind === 'method' && r.node.qualifiedName?.includes('Store')
  2684. );
  2685. expect(put).toBeDefined();
  2686. const putCallers = await cg.getCallers(put!.node.id);
  2687. expect(putCallers.map((c) => c.node.name)).toContain('Save');
  2688. cg.close();
  2689. } finally {
  2690. fs.rmSync(tmpDir, { recursive: true, force: true });
  2691. }
  2692. }, 30000);
  2693. it('unexported field types resolve; stdlib-qualified types never bind a same-named local decoy', async () => {
  2694. const tmpDir = fs.mkdtempSync(path.join(os.tmpdir(), 'codegraph-1276b-'));
  2695. try {
  2696. fs.writeFileSync(path.join(tmpDir, 'go.mod'), 'module example.com/b\n\ngo 1.22\n');
  2697. fs.writeFileSync(
  2698. path.join(tmpDir, 'm.go'),
  2699. `package m
  2700. import "net/http"
  2701. type node struct{}
  2702. func (n *node) InsertRoute(path string) {}
  2703. // A local type sharing the stdlib interface's name — the decoy the
  2704. // package-qualifier gate exists for.
  2705. type Handler func()
  2706. func (h Handler) ServeHTTP() {}
  2707. type Mux struct {
  2708. // the tree router lives below this comment (the comment must not
  2709. // donate a field type)
  2710. handler http.Handler
  2711. tree *node
  2712. }
  2713. func (mx *Mux) handle(path string) {
  2714. mx.tree.InsertRoute(path)
  2715. }
  2716. func (mx *Mux) dispatch() {
  2717. mx.handler.ServeHTTP(nil, nil)
  2718. }
  2719. `
  2720. );
  2721. const cg = CodeGraph.initSync(tmpDir);
  2722. await cg.indexAll();
  2723. // Unexported in-package field type: chain resolves (chi's mx.tree shape),
  2724. // and the doc comment above the field donates nothing.
  2725. const insert = (await cg.searchNodes('InsertRoute', { limit: 5 })).find(
  2726. (r) => r.node.kind === 'method'
  2727. );
  2728. expect(insert).toBeDefined();
  2729. const insertCallers = await cg.getCallers(insert!.node.id);
  2730. expect(insertCallers.map((c) => c.node.name)).toContain('handle');
  2731. // `handler http.Handler` is stdlib — the call must NOT bind to the
  2732. // local decoy `Handler.ServeHTTP`.
  2733. const serve = (await cg.searchNodes('ServeHTTP', { limit: 5 })).find(
  2734. (r) => r.node.kind === 'method'
  2735. );
  2736. if (serve) {
  2737. const serveCallers = await cg.getCallers(serve.node.id);
  2738. expect(serveCallers.map((c) => c.node.name)).not.toContain('dispatch');
  2739. }
  2740. cg.close();
  2741. } finally {
  2742. fs.rmSync(tmpDir, { recursive: true, force: true });
  2743. }
  2744. }, 30000);
  2745. });
  2746. describe('Imported singleton instance-method calls (#1292)', () => {
  2747. // `reproStore.notifyJoinGuildStatus()` after `import { reproStore }` used
  2748. // to emit its calls edge to the CONSTANT (resolvedBy:'import'), while the
  2749. // identical call in the defining file resolved to the method — so callers
  2750. // of the method missed every cross-file use. The import path now infers
  2751. // the value's type from its own declaration and resolves the member on it.
  2752. it('cross-file call through an imported singleton resolves to the class method', async () => {
  2753. const tmpDir = fs.mkdtempSync(path.join(os.tmpdir(), 'codegraph-1292-'));
  2754. try {
  2755. fs.mkdirSync(path.join(tmpDir, 'src'));
  2756. fs.writeFileSync(
  2757. path.join(tmpDir, 'src', 'store.ts'),
  2758. `export class ReproStore {
  2759. notifyJoinGuildStatus(): void {
  2760. console.log('notified');
  2761. }
  2762. }
  2763. export const reproStore = new ReproStore();
  2764. export function callInDefinitionFile(): void {
  2765. reproStore.notifyJoinGuildStatus();
  2766. }
  2767. `
  2768. );
  2769. fs.writeFileSync(
  2770. path.join(tmpDir, 'src', 'caller.ts'),
  2771. `import { reproStore } from './store';
  2772. export function callFromImportedFile(): void {
  2773. reproStore.notifyJoinGuildStatus();
  2774. }
  2775. `
  2776. );
  2777. const cg = CodeGraph.initSync(tmpDir);
  2778. await cg.indexAll();
  2779. const method = (await cg.searchNodes('notifyJoinGuildStatus', { limit: 5 })).find(
  2780. (r) => r.node.kind === 'method'
  2781. );
  2782. expect(method).toBeDefined();
  2783. // BOTH functions call the method — the cross-file one included.
  2784. const callers = await cg.getCallers(method!.node.id);
  2785. const callerNames = callers.map((c) => c.node.name).sort();
  2786. expect(callerNames).toContain('callInDefinitionFile');
  2787. expect(callerNames).toContain('callFromImportedFile');
  2788. cg.close();
  2789. } finally {
  2790. fs.rmSync(tmpDir, { recursive: true, force: true });
  2791. }
  2792. }, 30000);
  2793. });
  2794. describe('Object-literal namespace members (#1573)', () => {
  2795. // `export const api = { call() {…}, get: () => {…} }` used as the module's
  2796. // API surface: the members are plain functions with bare names inside the
  2797. // constant's extent, so `api.call()` resolved to nothing in the defining
  2798. // file and to the CONSTANT through an import — zero callers everywhere.
  2799. const setup = (files: Record<string, string>) => {
  2800. const tmpDir = fs.mkdtempSync(path.join(os.tmpdir(), 'codegraph-1573-'));
  2801. for (const [name, content] of Object.entries(files)) {
  2802. fs.mkdirSync(path.dirname(path.join(tmpDir, name)), { recursive: true });
  2803. fs.writeFileSync(path.join(tmpDir, name), content);
  2804. }
  2805. return tmpDir;
  2806. };
  2807. const callersOf = async (cg: CodeGraph, name: string, kind: string, filePath?: string) => {
  2808. const target = (await cg.searchNodes(name, { limit: 20 })).find(
  2809. (r) => r.node.kind === kind && r.node.name === name && (!filePath || r.node.filePath === filePath)
  2810. );
  2811. expect(target).toBeDefined();
  2812. return (await cg.getCallers(target!.node.id)).map((c) => c.node.name).sort();
  2813. };
  2814. it('resolves same-file and imported calls to the literal member, never to the constant (#1573)', async () => {
  2815. const tmpDir = setup({
  2816. 'a.ts': `export const obj = { m() { return 1; } };
  2817. export class C { static s() { return 2; } }
  2818. export function sameFileCallers() { return obj.m() + C.s(); }
  2819. `,
  2820. 'b.ts': `import { obj, C } from "./a";
  2821. export function crossFileCaller() { return obj.m() + C.s(); }
  2822. `,
  2823. // A same-named top-level function elsewhere must never be chosen.
  2824. 'decoy.ts': `export function m() { return 'decoy'; }
  2825. `,
  2826. });
  2827. try {
  2828. const cg = CodeGraph.initSync(tmpDir);
  2829. await cg.indexAll();
  2830. expect(await callersOf(cg, 'm', 'function', 'a.ts')).toEqual(['crossFileCaller', 'sameFileCallers']);
  2831. expect(await callersOf(cg, 'm', 'function', 'decoy.ts')).toEqual([]);
  2832. // The class static next to it resolves exactly as before (#825).
  2833. expect(await callersOf(cg, 's', 'method')).toEqual(['crossFileCaller', 'sameFileCallers']);
  2834. // The import edge no longer lands on the constant itself.
  2835. const obj = (await cg.searchNodes('obj', { limit: 5 })).find((r) => r.node.kind === 'constant');
  2836. expect(obj).toBeDefined();
  2837. const caller = (await cg.searchNodes('crossFileCaller', { limit: 5 })).find((r) => r.node.kind === 'function');
  2838. const toConstant = cg
  2839. .getOutgoingEdges(caller!.node.id)
  2840. .filter((e) => e.kind === 'calls' && e.target === obj!.node.id);
  2841. expect(toConstant).toHaveLength(0);
  2842. cg.close();
  2843. } finally {
  2844. fs.rmSync(tmpDir, { recursive: true, force: true });
  2845. }
  2846. }, 30000);
  2847. it('covers method and arrow-property members, and skips a declaration nested in a member body', async () => {
  2848. const tmpDir = setup({
  2849. 'src/api.ts': `export const api = {
  2850. call: () => { return 1; },
  2851. get() {
  2852. function call() { return 'nested in get, not a member'; }
  2853. return call();
  2854. },
  2855. };
  2856. `,
  2857. 'src/use.ts': `import { api } from './api';
  2858. export function useCall() { return api.call(); }
  2859. export function useGet() { return api.get(); }
  2860. `,
  2861. });
  2862. try {
  2863. const cg = CodeGraph.initSync(tmpDir);
  2864. await cg.indexAll();
  2865. const calls = (await cg.searchNodes('call', { limit: 20 }))
  2866. .map((r) => r.node)
  2867. .filter((n) => n.name === 'call' && n.filePath === 'src/api.ts' && (n.kind === 'function' || n.kind === 'method'));
  2868. // The member is the arrow on line 2; the nested declaration sits
  2869. // inside `get`'s body on line 4 and must never be taken for it.
  2870. const member = calls.find((n) => n.startLine === 2);
  2871. const nested = calls.find((n) => n.startLine === 4);
  2872. expect(member).toBeDefined();
  2873. expect(nested).toBeDefined();
  2874. expect((await cg.getCallers(member!.id)).map((c) => c.node.name)).toContain('useCall');
  2875. expect((await cg.getCallers(nested!.id)).map((c) => c.node.name)).not.toContain('useCall');
  2876. expect(await callersOf(cg, 'get', 'function')).toEqual(['useGet']);
  2877. cg.close();
  2878. } finally {
  2879. fs.rmSync(tmpDir, { recursive: true, force: true });
  2880. }
  2881. }, 30000);
  2882. it('leaves a non-literal value receiver on its existing path', async () => {
  2883. const tmpDir = setup({
  2884. 'src/mk.ts': `export function m() { return 'top-level, unrelated to obj'; }
  2885. export const obj = makeObj();
  2886. export function makeObj(): { m(): number } { return { m: () => 1 } as { m(): number }; }
  2887. export function localUse() { return obj.m(); }
  2888. `,
  2889. 'src/use.ts': `import { obj } from './mk';
  2890. export function remoteUse() { return obj.m(); }
  2891. `,
  2892. });
  2893. try {
  2894. const cg = CodeGraph.initSync(tmpDir);
  2895. await cg.indexAll();
  2896. // `obj` holds a call result, not a literal: the same-named top-level
  2897. // `m` lies outside its declaration, so containment finds nothing and
  2898. // both calls keep today's behavior (unresolved in the defining file;
  2899. // the constant edge through the import) rather than guessing.
  2900. expect(await callersOf(cg, 'm', 'function')).toEqual([]);
  2901. const obj = (await cg.searchNodes('obj', { limit: 5 })).find((r) => r.node.kind === 'constant');
  2902. const remote = (await cg.searchNodes('remoteUse', { limit: 5 })).find((r) => r.node.kind === 'function');
  2903. expect(
  2904. cg.getOutgoingEdges(remote!.node.id).some((e) => e.kind === 'calls' && e.target === obj!.node.id)
  2905. ).toBe(true);
  2906. cg.close();
  2907. } finally {
  2908. fs.rmSync(tmpDir, { recursive: true, force: true });
  2909. }
  2910. }, 30000);
  2911. });
  2912. describe('C++ namespace-qualified static method calls to out-of-line definitions (#1291)', () => {
  2913. // The issue's exact shape: nested types + out-of-line static method
  2914. // definition inside `namespace simulator { }` in the .cpp, called via the
  2915. // fully-qualified path from a different file. The definition's
  2916. // qualifiedName previously dropped the namespace (`ManifestStartup::Apply`
  2917. // vs the class's `simulator::ManifestStartup`), so `callers` came up empty.
  2918. it('resolves simulator::ManifestStartup::Apply(...) from another file', async () => {
  2919. const tmpDir = fs.mkdtempSync(path.join(os.tmpdir(), 'codegraph-1291-'));
  2920. try {
  2921. fs.writeFileSync(
  2922. path.join(tmpDir, 'manifest_startup.h'),
  2923. `#pragma once
  2924. namespace simulator {
  2925. class ManifestStartup {
  2926. public:
  2927. struct Input { int a; };
  2928. struct Output { int b; };
  2929. static Output Apply(const Input& input);
  2930. };
  2931. }
  2932. `
  2933. );
  2934. fs.writeFileSync(
  2935. path.join(tmpDir, 'manifest_startup.cpp'),
  2936. `#include "manifest_startup.h"
  2937. namespace simulator {
  2938. ManifestStartup::Output ManifestStartup::Apply(const Input& input) {
  2939. return Output{input.a};
  2940. }
  2941. }
  2942. `
  2943. );
  2944. fs.writeFileSync(
  2945. path.join(tmpDir, 'main.cpp'),
  2946. `#include "manifest_startup.h"
  2947. int run() {
  2948. const auto manifest_result = simulator::ManifestStartup::Apply({1});
  2949. return manifest_result.b;
  2950. }
  2951. `
  2952. );
  2953. const cg = CodeGraph.initSync(tmpDir);
  2954. await cg.indexAll();
  2955. const applyDefs = (await cg.searchNodes('Apply', { limit: 20 })).filter(
  2956. (r) => r.node.name === 'Apply' && r.node.kind === 'method'
  2957. );
  2958. expect(applyDefs.length).toBeGreaterThan(0);
  2959. const def = applyDefs.find((r) => r.node.filePath.endsWith('manifest_startup.cpp'));
  2960. expect(def).toBeDefined();
  2961. expect(def!.node.qualifiedName).toBe('simulator::ManifestStartup::Apply');
  2962. // The qualified cross-file call resolves: run() is a caller of Apply.
  2963. const callers = await cg.getCallers(def!.node.id);
  2964. expect(callers.map((c) => c.node.name)).toContain('run');
  2965. cg.close();
  2966. } finally {
  2967. fs.rmSync(tmpDir, { recursive: true, force: true });
  2968. }
  2969. }, 30000);
  2970. });
  2971. describe('C/C++ Import Resolution', () => {
  2972. afterEach(() => {
  2973. clearCppIncludeDirCache();
  2974. });
  2975. it('should resolve C include to header in same directory', () => {
  2976. const context: ResolutionContext = {
  2977. getNodesInFile: () => [],
  2978. getNodesByName: () => [],
  2979. getNodesByQualifiedName: () => [],
  2980. getNodesByKind: () => [],
  2981. fileExists: (p) => p === 'utils.h',
  2982. readFile: () => null,
  2983. getProjectRoot: () => '',
  2984. getAllFiles: () => ['utils.h', 'main.c'],
  2985. };
  2986. const result = resolveImportPath(
  2987. 'utils.h',
  2988. 'main.c',
  2989. 'c',
  2990. context
  2991. );
  2992. expect(result).toBe('utils.h');
  2993. });
  2994. it('should resolve C++ include with .hpp extension', () => {
  2995. const context: ResolutionContext = {
  2996. getNodesInFile: () => [],
  2997. getNodesByName: () => [],
  2998. getNodesByQualifiedName: () => [],
  2999. getNodesByKind: () => [],
  3000. fileExists: (p) => p === 'include/myclass.hpp',
  3001. readFile: () => null,
  3002. getProjectRoot: () => '',
  3003. getAllFiles: () => ['include/myclass.hpp', 'src/main.cpp'],
  3004. getCppIncludeDirs: () => ['include'],
  3005. };
  3006. const result = resolveImportPath(
  3007. 'myclass.hpp',
  3008. 'src/main.cpp',
  3009. 'cpp',
  3010. context
  3011. );
  3012. expect(result).toBe('include/myclass.hpp');
  3013. });
  3014. it('should resolve include with subdirectory path', () => {
  3015. const context: ResolutionContext = {
  3016. getNodesInFile: () => [],
  3017. getNodesByName: () => [],
  3018. getNodesByQualifiedName: () => [],
  3019. getNodesByKind: () => [],
  3020. fileExists: (p) => p === 'utils/helpers.h',
  3021. readFile: () => null,
  3022. getProjectRoot: () => '',
  3023. getAllFiles: () => ['utils/helpers.h', 'main.c'],
  3024. };
  3025. const result = resolveImportPath(
  3026. 'utils/helpers.h',
  3027. 'main.c',
  3028. 'c',
  3029. context
  3030. );
  3031. expect(result).toBe('utils/helpers.h');
  3032. });
  3033. it('should resolve include via include directories', () => {
  3034. const context: ResolutionContext = {
  3035. getNodesInFile: () => [],
  3036. getNodesByName: () => [],
  3037. getNodesByQualifiedName: () => [],
  3038. getNodesByKind: () => [],
  3039. fileExists: (p) => p === 'include/myheader.h',
  3040. readFile: () => null,
  3041. getProjectRoot: () => '',
  3042. getAllFiles: () => ['include/myheader.h', 'src/main.cpp'],
  3043. getCppIncludeDirs: () => ['include'],
  3044. };
  3045. const result = resolveImportPath(
  3046. 'myheader.h',
  3047. 'src/main.cpp',
  3048. 'cpp',
  3049. context
  3050. );
  3051. expect(result).toBe('include/myheader.h');
  3052. });
  3053. it('should resolve include trying multiple extensions', () => {
  3054. const context: ResolutionContext = {
  3055. getNodesInFile: () => [],
  3056. getNodesByName: () => [],
  3057. getNodesByQualifiedName: () => [],
  3058. getNodesByKind: () => [],
  3059. // myclass.h does not exist, but myclass.hpp does
  3060. fileExists: (p) => p === 'include/myclass.hpp',
  3061. readFile: () => null,
  3062. getProjectRoot: () => '',
  3063. getAllFiles: () => ['include/myclass.hpp', 'src/main.cpp'],
  3064. getCppIncludeDirs: () => ['include'],
  3065. };
  3066. const result = resolveImportPath(
  3067. 'myclass',
  3068. 'src/main.cpp',
  3069. 'cpp',
  3070. context
  3071. );
  3072. expect(result).toBe('include/myclass.hpp');
  3073. });
  3074. it('should return null for system headers', () => {
  3075. const context: ResolutionContext = {
  3076. getNodesInFile: () => [],
  3077. getNodesByName: () => [],
  3078. getNodesByQualifiedName: () => [],
  3079. getNodesByKind: () => [],
  3080. fileExists: () => true,
  3081. readFile: () => null,
  3082. getProjectRoot: () => '',
  3083. getAllFiles: () => [],
  3084. };
  3085. // C standard library header
  3086. expect(resolveImportPath('stdio.h', 'main.c', 'c', context)).toBeNull();
  3087. // C++ standard library header
  3088. expect(resolveImportPath('vector', 'main.cpp', 'cpp', context)).toBeNull();
  3089. // C++ C-wrapper header
  3090. expect(resolveImportPath('cstdio', 'main.cpp', 'cpp', context)).toBeNull();
  3091. });
  3092. it('should return null for single-component third-party paths that cannot be resolved', () => {
  3093. const context: ResolutionContext = {
  3094. getNodesInFile: () => [],
  3095. getNodesByName: () => [],
  3096. getNodesByQualifiedName: () => [],
  3097. getNodesByKind: () => [],
  3098. fileExists: () => false,
  3099. readFile: () => null,
  3100. getProjectRoot: () => '',
  3101. getAllFiles: () => [],
  3102. getCppIncludeDirs: () => [],
  3103. };
  3104. // Third-party bare header without path — not resolvable, returns null
  3105. const result = resolveImportPath(
  3106. 'openssl/ssl.h',
  3107. 'main.cpp',
  3108. 'cpp',
  3109. context
  3110. );
  3111. expect(result).toBeNull();
  3112. });
  3113. it('should not filter project headers with path separators', () => {
  3114. const context: ResolutionContext = {
  3115. getNodesInFile: () => [],
  3116. getNodesByName: () => [],
  3117. getNodesByQualifiedName: () => [],
  3118. getNodesByKind: () => [],
  3119. fileExists: (p) => p === 'mylib/utils.h',
  3120. readFile: () => null,
  3121. getProjectRoot: () => '',
  3122. getAllFiles: () => ['mylib/utils.h'],
  3123. };
  3124. // Path with separator should NOT be filtered as external
  3125. const result = resolveImportPath(
  3126. 'mylib/utils.h',
  3127. 'main.c',
  3128. 'c',
  3129. context
  3130. );
  3131. expect(result).toBe('mylib/utils.h');
  3132. });
  3133. it('should extract C/C++ import mappings from #include directives', () => {
  3134. const code = `#include <iostream>
  3135. #include "myheader.h"
  3136. #include "utils/helpers.hpp"`;
  3137. const mappings = extractImportMappings('main.cpp', code, 'cpp');
  3138. expect(mappings.length).toBe(3);
  3139. expect(mappings[0]).toEqual({
  3140. localName: 'iostream',
  3141. exportedName: '*',
  3142. source: 'iostream',
  3143. isDefault: false,
  3144. isNamespace: true,
  3145. });
  3146. expect(mappings[1]).toEqual({
  3147. localName: 'myheader',
  3148. exportedName: '*',
  3149. source: 'myheader.h',
  3150. isDefault: false,
  3151. isNamespace: true,
  3152. });
  3153. expect(mappings[2]).toEqual({
  3154. localName: 'helpers',
  3155. exportedName: '*',
  3156. source: 'utils/helpers.hpp',
  3157. isDefault: false,
  3158. isNamespace: true,
  3159. });
  3160. });
  3161. it('should discover include directories from compile_commands.json', () => {
  3162. // Create a temp project with compile_commands.json
  3163. const tempProject = fs.mkdtempSync(path.join(os.tmpdir(), 'codegraph-cpp-test-'));
  3164. try {
  3165. const compileDb = [
  3166. {
  3167. directory: tempProject,
  3168. command: 'g++ -Iinclude -Isrc/lib -isystem /usr/include -c src/main.cpp',
  3169. file: 'src/main.cpp',
  3170. },
  3171. ];
  3172. fs.writeFileSync(
  3173. path.join(tempProject, 'compile_commands.json'),
  3174. JSON.stringify(compileDb)
  3175. );
  3176. // Create the include dirs so they exist
  3177. fs.mkdirSync(path.join(tempProject, 'include'), { recursive: true });
  3178. fs.mkdirSync(path.join(tempProject, 'src', 'lib'), { recursive: true });
  3179. clearCppIncludeDirCache();
  3180. const dirs = loadCppIncludeDirs(tempProject);
  3181. // Should find include and src/lib (relative to project root)
  3182. // /usr/include is absolute and outside project, should be excluded
  3183. expect(dirs).toContain('include');
  3184. expect(dirs).toContain('src/lib');
  3185. expect(dirs.some(d => d.includes('usr'))).toBe(false);
  3186. } finally {
  3187. fs.rmSync(tempProject, { recursive: true });
  3188. }
  3189. });
  3190. it('should fall back to heuristic include dirs when no compile_commands.json', () => {
  3191. const tempProject = fs.mkdtempSync(path.join(os.tmpdir(), 'codegraph-cpp-test-'));
  3192. try {
  3193. // Create include/ and src/ directories with headers
  3194. fs.mkdirSync(path.join(tempProject, 'include'), { recursive: true });
  3195. fs.writeFileSync(path.join(tempProject, 'include', 'types.h'), '');
  3196. fs.mkdirSync(path.join(tempProject, 'src'), { recursive: true });
  3197. fs.writeFileSync(path.join(tempProject, 'src', 'main.cpp'), '');
  3198. // Create a directory without headers — should not be included
  3199. fs.mkdirSync(path.join(tempProject, 'docs'), { recursive: true });
  3200. clearCppIncludeDirCache();
  3201. const dirs = loadCppIncludeDirs(tempProject);
  3202. expect(dirs).toContain('include');
  3203. expect(dirs).toContain('src');
  3204. expect(dirs).not.toContain('docs');
  3205. } finally {
  3206. fs.rmSync(tempProject, { recursive: true });
  3207. }
  3208. });
  3209. // Documents the cross-language `.h` behavior. Objective-C and C++ share
  3210. // the `.h` extension, so in a mixed iOS-style project an Obj-C header
  3211. // dir gets claimed as a C/C++ include dir too. That's intentional — a
  3212. // C++ file legitimately can `#include "Foo.h"` against an Obj-C header
  3213. // (Obj-C++ / .mm callers), and false-positive inclusion is far cheaper
  3214. // than missing real resolutions. The test pins this so a later
  3215. // "exclude objc dirs" refactor breaks loudly and reviewers see the
  3216. // trade-off explicitly.
  3217. it('heuristic claims any top-level dir containing .h files, including Obj-C', () => {
  3218. const tempProject = fs.mkdtempSync(path.join(os.tmpdir(), 'codegraph-cpp-test-'));
  3219. try {
  3220. // C++ side: an `cppmod` dir with a .hpp (C++-only extension)
  3221. fs.mkdirSync(path.join(tempProject, 'cppmod'), { recursive: true });
  3222. fs.writeFileSync(path.join(tempProject, 'cppmod', 'shared.hpp'), '');
  3223. // Obj-C side: an `iosmod` dir with .h + .m (no .cpp/.hpp).
  3224. fs.mkdirSync(path.join(tempProject, 'iosmod'), { recursive: true });
  3225. fs.writeFileSync(path.join(tempProject, 'iosmod', 'View.h'), '');
  3226. fs.writeFileSync(path.join(tempProject, 'iosmod', 'View.m'), '');
  3227. clearCppIncludeDirCache();
  3228. const dirs = loadCppIncludeDirs(tempProject);
  3229. // Both included — Obj-C dirs are intentionally allowed.
  3230. expect(dirs).toContain('cppmod');
  3231. expect(dirs).toContain('iosmod');
  3232. } finally {
  3233. fs.rmSync(tempProject, { recursive: true });
  3234. }
  3235. });
  3236. // End-to-end: ensure `#include "X.h"` produces a file→file `imports` edge
  3237. // in the actual indexing pipeline (not just a phantom file→import-node
  3238. // edge). This pins the include-dir resolution path so the headline PR
  3239. // feature can't silently regress to a no-op in the indexing flow.
  3240. it('connects #include to the real header file via include-dir scan (end-to-end)', async () => {
  3241. const tempProject = fs.mkdtempSync(path.join(os.tmpdir(), 'codegraph-cpp-e2e-'));
  3242. try {
  3243. fs.mkdirSync(path.join(tempProject, 'include'), { recursive: true });
  3244. fs.mkdirSync(path.join(tempProject, 'src'), { recursive: true });
  3245. fs.writeFileSync(
  3246. path.join(tempProject, 'include', 'utils.h'),
  3247. `#ifndef UTILS_H\n#define UTILS_H\nint add(int, int);\n#endif\n`
  3248. );
  3249. fs.writeFileSync(
  3250. path.join(tempProject, 'src', 'main.cpp'),
  3251. `#include "utils.h"\n#include <vector>\nint main(){ return add(1,2); }\n`
  3252. );
  3253. clearCppIncludeDirCache();
  3254. cg = await CodeGraph.init(tempProject, { index: true });
  3255. // Sanity: file nodes exist for the header and the cpp.
  3256. const allFiles = cg.getStats();
  3257. expect(allFiles.fileCount).toBe(2);
  3258. // The `#include "utils.h"` edge should target the real
  3259. // `include/utils.h` file node — not a floating `import` node
  3260. // living inside main.cpp.
  3261. const db = DatabaseConnection.open(path.join(tempProject, '.codegraph', 'codegraph.db'));
  3262. const rows = db.getDb().prepare(`
  3263. select dst.kind as dstKind, dst.file_path as dstPath
  3264. from edges e
  3265. join nodes src on e.source = src.id
  3266. join nodes dst on e.target = dst.id
  3267. where e.kind = 'imports'
  3268. and src.kind = 'file'
  3269. and src.file_path = 'src/main.cpp'
  3270. `).all() as Array<{ dstKind: string; dstPath: string }>;
  3271. const resolvedToHeader = rows.find(
  3272. (r) => r.dstKind === 'file' && r.dstPath === 'include/utils.h'
  3273. );
  3274. expect(resolvedToHeader, 'main.cpp → include/utils.h imports edge missing').toBeDefined();
  3275. // `<vector>` should NOT produce a file edge — it's a stdlib header.
  3276. const stdlibFile = rows.find(
  3277. (r) => r.dstKind === 'file' && r.dstPath && r.dstPath.endsWith('vector')
  3278. );
  3279. expect(stdlibFile).toBeUndefined();
  3280. } finally {
  3281. fs.rmSync(tempProject, { recursive: true, force: true });
  3282. }
  3283. });
  3284. });
  3285. describe('C++ templated base-class inheritance (#1043)', () => {
  3286. // A class deriving from a TEMPLATE — `class D : public Base<int>` (or a CRTP
  3287. // `class W : public CRTPBase<W>`, or a qualified `class Q : public ns::Tpl<int>`)
  3288. // recorded its base as the full instantiation text (`Base<int>`), which never
  3289. // name-matched the template, indexed as the bare node `Base`. The `<…>` args
  3290. // are now stripped so the `extends` edge resolves end-to-end.
  3291. it('resolves an extends edge to a templated base (plain, CRTP, struct, multi-base)', async () => {
  3292. fs.writeFileSync(
  3293. path.join(tempDir, 'lib.hpp'),
  3294. `#pragma once
  3295. template<typename T> class Base { public: void foo(); };
  3296. template<typename Derived> class CRTPBase {};
  3297. class Plain {};
  3298. class Widget : public Base<int> {}; // plain template base
  3299. class App : public CRTPBase<App> {}; // CRTP (curiously-recurring)
  3300. struct Node : public Base<double> {}; // struct inheriting a template
  3301. class Both : public Base<char>, public Plain {}; // templated + plain in one clause
  3302. `
  3303. );
  3304. cg = await CodeGraph.init(tempDir, { index: true });
  3305. const db = DatabaseConnection.open(path.join(tempDir, '.codegraph', 'codegraph.db'));
  3306. const edges = db
  3307. .getDb()
  3308. .prepare(
  3309. `select src.name as fromName, dst.name as toName
  3310. from edges e
  3311. join nodes src on e.source = src.id
  3312. join nodes dst on e.target = dst.id
  3313. where e.kind = 'extends'`
  3314. )
  3315. .all() as Array<{ fromName: string; toName: string }>;
  3316. const has = (from: string, to: string) =>
  3317. edges.some((r) => r.fromName === from && r.toName === to);
  3318. // Every templated base now resolves to the bare template node.
  3319. expect(has('Widget', 'Base'), 'Widget : Base<int>').toBe(true);
  3320. expect(has('App', 'CRTPBase'), 'App : CRTPBase<App> (CRTP)').toBe(true);
  3321. expect(has('Node', 'Base'), 'struct Node : Base<double>').toBe(true);
  3322. // A mixed clause resolves BOTH the templated and the plain base.
  3323. expect(has('Both', 'Base'), 'Both : Base<char>').toBe(true);
  3324. expect(has('Both', 'Plain'), 'Both : Plain (non-templated, regression guard)').toBe(true);
  3325. });
  3326. });
  3327. describe('PHP Include Resolution', () => {
  3328. it('isPhpIncludePathRef distinguishes include paths from namespace use (#660)', () => {
  3329. const mk = (name: string, over: Partial<UnresolvedRef> = {}): UnresolvedRef => ({
  3330. fromNodeId: 'f', referenceName: name, referenceKind: 'imports',
  3331. line: 1, column: 0, filePath: 'x.php', language: 'php', ...over,
  3332. });
  3333. // include paths: contain a slash or a file extension
  3334. expect(isPhpIncludePathRef(mk('lib.php'))).toBe(true);
  3335. expect(isPhpIncludePathRef(mk('inc/db.php'))).toBe(true);
  3336. expect(isPhpIncludePathRef(mk('../config.php'))).toBe(true);
  3337. // namespace use symbols: a bare class (Closure) or FQN — never a path,
  3338. // so they must NOT be treated as includes (would mis-connect to a
  3339. // same-named Closure.php / Bar.php file).
  3340. expect(isPhpIncludePathRef(mk('Closure'))).toBe(false);
  3341. expect(isPhpIncludePathRef(mk('PDO'))).toBe(false);
  3342. expect(isPhpIncludePathRef(mk('App\\Foo\\Bar'))).toBe(false);
  3343. // scoped to PHP imports only
  3344. expect(isPhpIncludePathRef(mk('lib.php', { language: 'c' }))).toBe(false);
  3345. expect(isPhpIncludePathRef(mk('lib.php', { referenceKind: 'calls' }))).toBe(false);
  3346. });
  3347. it('resolves require_once to a file→file imports edge (#660)', async () => {
  3348. const tempProject = fs.mkdtempSync(path.join(os.tmpdir(), 'codegraph-php-e2e-'));
  3349. try {
  3350. fs.mkdirSync(path.join(tempProject, 'src'), { recursive: true });
  3351. fs.writeFileSync(
  3352. path.join(tempProject, 'src', 'lib.php'),
  3353. `<?php\nfunction greet() { return "hi"; }\n`
  3354. );
  3355. fs.writeFileSync(
  3356. path.join(tempProject, 'src', 'page.php'),
  3357. `<?php\nrequire_once("lib.php");\necho greet();\n`
  3358. );
  3359. cg = await CodeGraph.init(tempProject, { index: true });
  3360. // reporter's repro: page.php's `require_once("lib.php")` must resolve
  3361. // to the real src/lib.php file node — a file→file `imports` edge, so
  3362. // callers(lib.php) now includes page.php.
  3363. const db = DatabaseConnection.open(path.join(tempProject, '.codegraph', 'codegraph.db'));
  3364. const rows = db.getDb().prepare(`
  3365. select dst.kind as dstKind, dst.file_path as dstPath
  3366. from edges e
  3367. join nodes src on e.source = src.id
  3368. join nodes dst on e.target = dst.id
  3369. where e.kind = 'imports'
  3370. and src.kind = 'file'
  3371. and src.file_path = 'src/page.php'
  3372. `).all() as Array<{ dstKind: string; dstPath: string }>;
  3373. const resolved = rows.find(
  3374. (r) => r.dstKind === 'file' && r.dstPath === 'src/lib.php'
  3375. );
  3376. expect(resolved, 'page.php → src/lib.php imports edge missing').toBeDefined();
  3377. } finally {
  3378. fs.rmSync(tempProject, { recursive: true, force: true });
  3379. }
  3380. });
  3381. it('resolves a subdirectory include path to the correct file (#660)', async () => {
  3382. const tempProject = fs.mkdtempSync(path.join(os.tmpdir(), 'codegraph-php-subdir-'));
  3383. try {
  3384. fs.mkdirSync(path.join(tempProject, 'inc'), { recursive: true });
  3385. fs.writeFileSync(
  3386. path.join(tempProject, 'inc', 'db.php'),
  3387. `<?php\nfunction query() { return 1; }\n`
  3388. );
  3389. fs.writeFileSync(
  3390. path.join(tempProject, 'index.php'),
  3391. `<?php\nrequire "inc/db.php";\nquery();\n`
  3392. );
  3393. cg = await CodeGraph.init(tempProject, { index: true });
  3394. const db = DatabaseConnection.open(path.join(tempProject, '.codegraph', 'codegraph.db'));
  3395. const rows = db.getDb().prepare(`
  3396. select dst.kind as dstKind, dst.file_path as dstPath
  3397. from edges e
  3398. join nodes src on e.source = src.id
  3399. join nodes dst on e.target = dst.id
  3400. where e.kind = 'imports'
  3401. and src.kind = 'file'
  3402. and src.file_path = 'index.php'
  3403. `).all() as Array<{ dstKind: string; dstPath: string }>;
  3404. expect(
  3405. rows.find((r) => r.dstKind === 'file' && r.dstPath === 'inc/db.php'),
  3406. 'index.php → inc/db.php imports edge missing'
  3407. ).toBeDefined();
  3408. } finally {
  3409. fs.rmSync(tempProject, { recursive: true, force: true });
  3410. }
  3411. });
  3412. it('does not mis-connect an unresolvable include to a same-named file elsewhere (#660)', async () => {
  3413. const tempProject = fs.mkdtempSync(path.join(os.tmpdir(), 'codegraph-php-misresolve-'));
  3414. try {
  3415. // app/page.php's `require "inc/db.php"` resolves relative to app/, where
  3416. // inc/db.php does NOT exist. A same-named lib/inc/db.php exists elsewhere
  3417. // but is unrelated — no edge should be created (a wrong edge is worse
  3418. // than a missing one).
  3419. fs.mkdirSync(path.join(tempProject, 'app'), { recursive: true });
  3420. fs.mkdirSync(path.join(tempProject, 'lib', 'inc'), { recursive: true });
  3421. fs.writeFileSync(
  3422. path.join(tempProject, 'lib', 'inc', 'db.php'),
  3423. `<?php\nfunction unrelated() {}\n`
  3424. );
  3425. fs.writeFileSync(
  3426. path.join(tempProject, 'app', 'page.php'),
  3427. `<?php\nrequire "inc/db.php";\n`
  3428. );
  3429. cg = await CodeGraph.init(tempProject, { index: true });
  3430. const db = DatabaseConnection.open(path.join(tempProject, '.codegraph', 'codegraph.db'));
  3431. const rows = db.getDb().prepare(`
  3432. select dst.kind as dstKind, dst.file_path as dstPath
  3433. from edges e
  3434. join nodes src on e.source = src.id
  3435. join nodes dst on e.target = dst.id
  3436. where e.kind = 'imports'
  3437. and src.kind = 'file'
  3438. and src.file_path = 'app/page.php'
  3439. `).all() as Array<{ dstKind: string; dstPath: string }>;
  3440. expect(
  3441. rows.find((r) => r.dstKind === 'file' && r.dstPath === 'lib/inc/db.php'),
  3442. 'app/page.php must NOT mis-connect to unrelated lib/inc/db.php'
  3443. ).toBeUndefined();
  3444. } finally {
  3445. fs.rmSync(tempProject, { recursive: true, force: true });
  3446. }
  3447. });
  3448. });
  3449. describe('C++ chained-call receiver resolution (#645)', () => {
  3450. async function indexCpp(files: Record<string, string>): Promise<void> {
  3451. for (const [name, content] of Object.entries(files)) {
  3452. fs.writeFileSync(path.join(tempDir, name), content);
  3453. }
  3454. cg = await CodeGraph.init(tempDir, { index: true });
  3455. }
  3456. function callerNamesOf(qualifiedName: string): string[] {
  3457. const target = cg.getNodesByKind('method').find((n) => n.qualifiedName === qualifiedName);
  3458. if (!target) return [];
  3459. const names = cg
  3460. .getIncomingEdges(target.id)
  3461. .filter((e) => e.kind === 'calls')
  3462. .map((e) => cg.getNode(e.source)?.name)
  3463. .filter((n): n is string => !!n);
  3464. return [...new Set(names)].sort();
  3465. }
  3466. it('resolves singleton chains and auto locals to the right class, never the first-sorted one', async () => {
  3467. // Two classes share writeLog; Logger sorts first so it wins any name-only
  3468. // tie. All three call forms target Metrics.
  3469. await indexCpp({
  3470. 'logger.hpp': `#pragma once
  3471. #include <string>
  3472. class Logger { public: static Logger& instance(); void writeLog(const std::string&); };
  3473. class Metrics { public: static Metrics& instance(); void writeLog(const std::string&); };
  3474. `,
  3475. 'impl.cpp': `#include "logger.hpp"
  3476. Logger& Logger::instance() { static Logger l; return l; }
  3477. Metrics& Metrics::instance() { static Metrics m; return m; }
  3478. void Logger::writeLog(const std::string&) {}
  3479. void Metrics::writeLog(const std::string&) {}
  3480. `,
  3481. 'app.cpp': `#include "logger.hpp"
  3482. void a() { Metrics::instance().writeLog("x"); } // chained singleton
  3483. void b() { auto& m = Metrics::instance(); m.writeLog("x"); } // stored in auto
  3484. void c() { Metrics& m = Metrics::instance(); m.writeLog("x"); } // explicit type
  3485. `,
  3486. });
  3487. expect(callerNamesOf('Metrics::writeLog')).toEqual(['a', 'b', 'c']);
  3488. expect(callerNamesOf('Logger::writeLog')).toEqual([]);
  3489. });
  3490. it('resolves factories, free-function factories, and member chains via the inner call return type', async () => {
  3491. await indexCpp({
  3492. 'types.hpp': `#pragma once
  3493. #include <memory>
  3494. struct Widget { void draw(); };
  3495. struct Session { void run(); };
  3496. struct View { void render(); };
  3497. class WidgetFactory { public: static Widget create(); };
  3498. class Manager { public: View view(); };
  3499. Session* openSession();
  3500. // Decoy that sorts first and has all three methods — must never win.
  3501. struct Aaa { void draw(); void run(); void render(); };
  3502. `,
  3503. 'impl.cpp': `#include "types.hpp"
  3504. void Widget::draw() {}
  3505. void Session::run() {}
  3506. void View::render() {}
  3507. void Aaa::draw() {}
  3508. void Aaa::run() {}
  3509. void Aaa::render() {}
  3510. Widget WidgetFactory::create() { return Widget(); }
  3511. View Manager::view() { return View(); }
  3512. Session* openSession() { return nullptr; }
  3513. `,
  3514. 'app.cpp': `#include "types.hpp"
  3515. void factory() { WidgetFactory::create().draw(); } // -> Widget::draw
  3516. void freefunc() { openSession()->run(); } // -> Session::run
  3517. void member() { Manager mgr; mgr.view().render(); } // -> View::render
  3518. void makeUnique() { auto w = std::make_unique<Widget>(); w->draw(); } // -> Widget::draw
  3519. `,
  3520. });
  3521. expect(callerNamesOf('Widget::draw')).toEqual(['factory', 'makeUnique']);
  3522. expect(callerNamesOf('Session::run')).toEqual(['freefunc']);
  3523. expect(callerNamesOf('View::render')).toEqual(['member']);
  3524. // The first-sorted decoy never captures any of them.
  3525. expect(callerNamesOf('Aaa::draw')).toEqual([]);
  3526. expect(callerNamesOf('Aaa::run')).toEqual([]);
  3527. expect(callerNamesOf('Aaa::render')).toEqual([]);
  3528. });
  3529. it('creates NO edge when the inferred type lacks the method (silent miss, not a wrong edge)', async () => {
  3530. await indexCpp({
  3531. 'types.hpp': `#pragma once
  3532. struct Widget { void draw(); };
  3533. struct Other { void onlyOther(); };
  3534. class WidgetFactory { public: static Widget create(); };
  3535. `,
  3536. 'impl.cpp': `#include "types.hpp"
  3537. void Widget::draw() {}
  3538. void Other::onlyOther() {}
  3539. Widget WidgetFactory::create() { return Widget(); }
  3540. `,
  3541. 'app.cpp': `#include "types.hpp"
  3542. // Widget has no onlyOther() — must produce NO edge, never a wrong one to Other.
  3543. void wrong() { WidgetFactory::create().onlyOther(); }
  3544. `,
  3545. });
  3546. expect(callerNamesOf('Other::onlyOther')).toEqual([]);
  3547. });
  3548. });
  3549. describe('C++ explicit operator-call resolution (#1247)', () => {
  3550. // `a.operator+(b)` produced no calls edge: the operator_name lands in an
  3551. // ERROR node (never a field_expression callee), so the extractor emitted a
  3552. // ref named just `a`. With the ERROR-node recovery it emits `a.operator+`,
  3553. // and matchMethodCall (dot pattern extended to admit operator method parts)
  3554. // resolves it through receiver-type inference. Infix `a + b` / `a[i]` need
  3555. // real type inference and are out of scope here (#1258).
  3556. async function indexCpp(files: Record<string, string>): Promise<void> {
  3557. for (const [name, content] of Object.entries(files)) {
  3558. fs.writeFileSync(path.join(tempDir, name), content);
  3559. }
  3560. cg = await CodeGraph.init(tempDir, { index: true });
  3561. }
  3562. function callerNamesOf(qualifiedName: string): string[] {
  3563. const target = cg.getNodesByKind('method').find((n) => n.qualifiedName === qualifiedName);
  3564. if (!target) return [];
  3565. const names = cg
  3566. .getIncomingEdges(target.id)
  3567. .filter((e) => e.kind === 'calls')
  3568. .map((e) => cg.getNode(e.source)?.name)
  3569. .filter((n): n is string => !!n);
  3570. return [...new Set(names)].sort();
  3571. }
  3572. it('resolves explicit operator calls to the receiver type, never a same-named decoy', async () => {
  3573. // Aaa sorts first and declares the same operators — only receiver-type
  3574. // inference (const V& a → V) can pick V, so a name-only tie can't win.
  3575. await indexCpp({
  3576. 'optest.cpp': `struct Aaa {
  3577. Aaa operator+(const Aaa& o) const { return o; }
  3578. Aaa operator[](int i) const { return *this; }
  3579. };
  3580. struct V {
  3581. int x;
  3582. V operator+(const V& o) const { return V{x + o.x}; }
  3583. V operator[](int i) const { return V{x + i}; }
  3584. int get() const { return x; }
  3585. };
  3586. int plainCaller(const V& a) { return a.get(); }
  3587. V explicitCaller(const V& a, const V& b) { return a.operator+(b); }
  3588. V subscriptCaller(const V& a) { return a.operator[](3); }
  3589. V pointerCaller(const V* p, const V& b) { return p->operator+(b); }
  3590. `,
  3591. });
  3592. expect(callerNamesOf('V::operator+')).toEqual(['explicitCaller', 'pointerCaller']);
  3593. expect(callerNamesOf('V::operator[]')).toEqual(['subscriptCaller']);
  3594. expect(callerNamesOf('V::get')).toEqual(['plainCaller']); // control: plain calls unaffected
  3595. expect(callerNamesOf('Aaa::operator+')).toEqual([]);
  3596. expect(callerNamesOf('Aaa::operator[]')).toEqual([]);
  3597. });
  3598. it('resolves an out-of-line operator definition (declaration in header)', async () => {
  3599. await indexCpp({
  3600. 'v.hpp': `#pragma once
  3601. struct V { int x; V operator+(const V& o) const; };
  3602. `,
  3603. 'v.cpp': `#include "v.hpp"
  3604. V V::operator+(const V& o) const { return V{x + o.x}; }
  3605. `,
  3606. 'app.cpp': `#include "v.hpp"
  3607. V add(const V& a, const V& b) { return a.operator+(b); }
  3608. `,
  3609. });
  3610. expect(callerNamesOf('V::operator+')).toEqual(['add']);
  3611. });
  3612. });
  3613. describe('PHP chained static-factory call resolution (#608)', () => {
  3614. function callerNamesOf(qualifiedName: string): string[] {
  3615. const target = cg.getNodesByKind('method').find((n) => n.qualifiedName === qualifiedName);
  3616. if (!target) return [];
  3617. const names = cg
  3618. .getIncomingEdges(target.id)
  3619. .filter((e) => e.kind === 'calls')
  3620. .map((e) => cg.getNode(e.source)?.name)
  3621. .filter((n): n is string => !!n);
  3622. return [...new Set(names)].sort();
  3623. }
  3624. it('resolves Cls::for($x)->method() via the factory\'s `: self` return (#608)', async () => {
  3625. fs.writeFileSync(
  3626. path.join(tempDir, 'ApiClient.php'),
  3627. `<?php\nclass ApiClient {\n public static function for(string $c): self { return new self; }\n public function createOrder(array $p): array { return []; }\n}\n`
  3628. );
  3629. fs.writeFileSync(
  3630. path.join(tempDir, 'DispatchOrder.php'),
  3631. `<?php\nclass DispatchOrder {\n public function handle(): void {\n ApiClient::for('cred')->createOrder([]);\n }\n}\n`
  3632. );
  3633. cg = await CodeGraph.init(tempDir, { index: true });
  3634. // The chained call's edge attaches to the factory result's method.
  3635. expect(callerNamesOf('ApiClient::createOrder')).toContain('handle');
  3636. });
  3637. it('creates NO edge when the factory result lacks the method (#608)', async () => {
  3638. fs.writeFileSync(
  3639. path.join(tempDir, 'lib.php'),
  3640. `<?php\nclass ApiClient { public static function for(string $c): self { return new self; } }\nclass Other { public function onlyOther(): void {} }\nclass Caller { public function go(): void { ApiClient::for('x')->onlyOther(); } }\n`
  3641. );
  3642. cg = await CodeGraph.init(tempDir, { index: true });
  3643. // ApiClient has no onlyOther — must not mis-attach to the same-named Other::onlyOther.
  3644. expect(callerNamesOf('Other::onlyOther')).toEqual([]);
  3645. });
  3646. });
  3647. describe('Java chained static-factory call resolution (#645/#608 mechanism)', () => {
  3648. function callerNamesOf(qualifiedName: string): string[] {
  3649. const target = cg.getNodesByKind('method').find((n) => n.qualifiedName === qualifiedName);
  3650. if (!target) return [];
  3651. const names = cg
  3652. .getIncomingEdges(target.id)
  3653. .filter((e) => e.kind === 'calls')
  3654. .map((e) => cg.getNode(e.source)?.name)
  3655. .filter((n): n is string => !!n);
  3656. return [...new Set(names)].sort();
  3657. }
  3658. it('resolves Foo.getInstance().bar() via the factory return type, never a same-named decoy', async () => {
  3659. // Aaa sorts first and has a same-named bar() — it must never win the chain.
  3660. fs.writeFileSync(
  3661. path.join(tempDir, 'Main.java'),
  3662. `class Aaa { void bar() {} }
  3663. class Foo {
  3664. static Foo getInstance() { return new Foo(); }
  3665. void bar() {}
  3666. }
  3667. class Caller {
  3668. void run() { Foo.getInstance().bar(); }
  3669. }
  3670. `
  3671. );
  3672. cg = await CodeGraph.init(tempDir, { index: true });
  3673. expect(callerNamesOf('Foo::bar')).toEqual(['run']);
  3674. expect(callerNamesOf('Aaa::bar')).toEqual([]);
  3675. });
  3676. it('resolves a factory chain that passes arguments — Foo.create(cfg).build()', async () => {
  3677. // The factory call carries an argument; the extractor must normalize the
  3678. // receiver to empty parens (`Foo.create().build`) so the chain still splits.
  3679. fs.writeFileSync(
  3680. path.join(tempDir, 'Main.java'),
  3681. `class Config {}
  3682. class Foo {
  3683. static Foo create(Config c) { return new Foo(); }
  3684. void build() {}
  3685. }
  3686. class Caller {
  3687. void run() { Foo.create(new Config()).build(); }
  3688. }
  3689. `
  3690. );
  3691. cg = await CodeGraph.init(tempDir, { index: true });
  3692. expect(callerNamesOf('Foo::build')).toEqual(['run']);
  3693. });
  3694. it('creates NO edge when the factory return type lacks the method (silent miss, not a wrong edge)', async () => {
  3695. fs.writeFileSync(
  3696. path.join(tempDir, 'Main.java'),
  3697. `class Foo {
  3698. static Foo getInstance() { return new Foo(); }
  3699. }
  3700. class Other { void onlyOther() {} }
  3701. class Caller {
  3702. void run() { Foo.getInstance().onlyOther(); }
  3703. }
  3704. `
  3705. );
  3706. cg = await CodeGraph.init(tempDir, { index: true });
  3707. // Foo has no onlyOther() — must not mis-attach to the same-named Other::onlyOther.
  3708. expect(callerNamesOf('Other::onlyOther')).toEqual([]);
  3709. });
  3710. });
  3711. describe('Kotlin chained companion-factory call resolution (#645/#608 mechanism)', () => {
  3712. function callerNamesOf(qualifiedName: string): string[] {
  3713. const target = cg.getNodesByKind('method').find((n) => n.qualifiedName === qualifiedName);
  3714. if (!target) return [];
  3715. const names = cg
  3716. .getIncomingEdges(target.id)
  3717. .filter((e) => e.kind === 'calls')
  3718. .map((e) => cg.getNode(e.source)?.name)
  3719. .filter((n): n is string => !!n);
  3720. return [...new Set(names)].sort();
  3721. }
  3722. it('resolves Foo.getInstance().bar() via the companion return type, never a same-named decoy', async () => {
  3723. // Aaa sorts first and has a same-named bar() — without the chain fix Kotlin
  3724. // dropped the receiver to a bare `bar` and attached to Aaa (a wrong edge).
  3725. fs.writeFileSync(
  3726. path.join(tempDir, 'Main.kt'),
  3727. `class Aaa { fun bar() {} }
  3728. class Foo {
  3729. companion object {
  3730. fun getInstance(): Foo = Foo()
  3731. }
  3732. fun bar() {}
  3733. }
  3734. class Caller {
  3735. fun run() { Foo.getInstance().bar() }
  3736. }
  3737. `
  3738. );
  3739. cg = await CodeGraph.init(tempDir, { index: true });
  3740. expect(callerNamesOf('Foo::bar')).toEqual(['run']);
  3741. expect(callerNamesOf('Aaa::bar')).toEqual([]);
  3742. });
  3743. it('resolves a companion factory chain that passes arguments — Foo.create(cfg).build()', async () => {
  3744. fs.writeFileSync(
  3745. path.join(tempDir, 'Main.kt'),
  3746. `class Config
  3747. class Foo {
  3748. companion object {
  3749. fun create(c: Config): Foo = Foo()
  3750. }
  3751. fun build() {}
  3752. }
  3753. class Caller {
  3754. fun run() { Foo.create(Config()).build() }
  3755. }
  3756. `
  3757. );
  3758. cg = await CodeGraph.init(tempDir, { index: true });
  3759. expect(callerNamesOf('Foo::build')).toEqual(['run']);
  3760. });
  3761. it('creates NO edge when the companion return type lacks the method (silent miss, not a wrong edge)', async () => {
  3762. fs.writeFileSync(
  3763. path.join(tempDir, 'Main.kt'),
  3764. `class Foo {
  3765. companion object {
  3766. fun getInstance(): Foo = Foo()
  3767. }
  3768. }
  3769. class Other { fun onlyOther() {} }
  3770. class Caller {
  3771. fun run() { Foo.getInstance().onlyOther() }
  3772. }
  3773. `
  3774. );
  3775. cg = await CodeGraph.init(tempDir, { index: true });
  3776. // Foo has no onlyOther() — must not mis-attach to the same-named Other::onlyOther.
  3777. expect(callerNamesOf('Other::onlyOther')).toEqual([]);
  3778. });
  3779. });
  3780. describe('C# chained static-factory call resolution (#645/#608 mechanism)', () => {
  3781. function callerNamesOf(qualifiedName: string): string[] {
  3782. const target = cg.getNodesByKind('method').find((n) => n.qualifiedName === qualifiedName);
  3783. if (!target) return [];
  3784. const names = cg
  3785. .getIncomingEdges(target.id)
  3786. .filter((e) => e.kind === 'calls')
  3787. .map((e) => cg.getNode(e.source)?.name)
  3788. .filter((n): n is string => !!n);
  3789. return [...new Set(names)].sort();
  3790. }
  3791. it('resolves Foo.Create().Bar() via the factory return type, never a same-named decoy', async () => {
  3792. // Aaa sorts first and has a same-named Bar() — it must never win the chain.
  3793. fs.writeFileSync(
  3794. path.join(tempDir, 'Main.cs'),
  3795. `class Aaa { void Bar() {} }
  3796. class Foo {
  3797. static Foo Create() { return new Foo(); }
  3798. void Bar() {}
  3799. }
  3800. class Caller {
  3801. void Run() { Foo.Create().Bar(); }
  3802. }
  3803. `
  3804. );
  3805. cg = await CodeGraph.init(tempDir, { index: true });
  3806. expect(callerNamesOf('Foo::Bar')).toEqual(['Run']);
  3807. expect(callerNamesOf('Aaa::Bar')).toEqual([]);
  3808. });
  3809. it('resolves a factory chain that passes arguments — Foo.Make(cfg).Build()', async () => {
  3810. fs.writeFileSync(
  3811. path.join(tempDir, 'Main.cs'),
  3812. `class Config {}
  3813. class Foo {
  3814. static Foo Make(Config c) { return new Foo(); }
  3815. void Build() {}
  3816. }
  3817. class Caller {
  3818. void Run() { Foo.Make(new Config()).Build(); }
  3819. }
  3820. `
  3821. );
  3822. cg = await CodeGraph.init(tempDir, { index: true });
  3823. expect(callerNamesOf('Foo::Build')).toEqual(['Run']);
  3824. });
  3825. it('creates NO edge when the factory return type lacks the method (silent miss, not a wrong edge)', async () => {
  3826. fs.writeFileSync(
  3827. path.join(tempDir, 'Main.cs'),
  3828. `class Foo {
  3829. static Foo Create() { return new Foo(); }
  3830. }
  3831. class Other { void OnlyOther() {} }
  3832. class Caller {
  3833. void Run() { Foo.Create().OnlyOther(); }
  3834. }
  3835. `
  3836. );
  3837. cg = await CodeGraph.init(tempDir, { index: true });
  3838. // Foo has no OnlyOther() — must not mis-attach to the same-named Other::OnlyOther.
  3839. expect(callerNamesOf('Other::OnlyOther')).toEqual([]);
  3840. });
  3841. });
  3842. describe('Swift chained static-factory call resolution (#645/#608 mechanism)', () => {
  3843. function callerNamesOf(qualifiedName: string): string[] {
  3844. const target = cg.getNodesByKind('method').find((n) => n.qualifiedName === qualifiedName);
  3845. if (!target) return [];
  3846. const names = cg
  3847. .getIncomingEdges(target.id)
  3848. .filter((e) => e.kind === 'calls')
  3849. .map((e) => cg.getNode(e.source)?.name)
  3850. .filter((n): n is string => !!n);
  3851. return [...new Set(names)].sort();
  3852. }
  3853. it('resolves Foo.make().draw() via the factory return type, never a same-named decoy', async () => {
  3854. // Aaa sorts first and has a same-named draw() — without the fix Swift dropped
  3855. // the receiver to a bare `draw` and attached to Aaa (a wrong edge).
  3856. fs.writeFileSync(
  3857. path.join(tempDir, 'Main.swift'),
  3858. `class Aaa { func draw() {} }
  3859. class Foo {
  3860. static func make() -> Foo { return Foo() }
  3861. func draw() {}
  3862. }
  3863. func runCaller() { Foo.make().draw() }
  3864. `
  3865. );
  3866. cg = await CodeGraph.init(tempDir, { index: true });
  3867. expect(callerNamesOf('Foo::draw')).toEqual(['runCaller']);
  3868. expect(callerNamesOf('Aaa::draw')).toEqual([]);
  3869. });
  3870. it('resolves a constructor chain Foo().draw() and an args factory chain Foo.build(c).render()', async () => {
  3871. fs.writeFileSync(
  3872. path.join(tempDir, 'Main.swift'),
  3873. `class Config {}
  3874. class Foo {
  3875. static func build(_ c: Config) -> Foo { return Foo() }
  3876. func draw() {}
  3877. func render() {}
  3878. }
  3879. func runCaller() {
  3880. Foo().draw()
  3881. Foo.build(Config()).render()
  3882. }
  3883. `
  3884. );
  3885. cg = await CodeGraph.init(tempDir, { index: true });
  3886. expect(callerNamesOf('Foo::draw')).toEqual(['runCaller']);
  3887. expect(callerNamesOf('Foo::render')).toEqual(['runCaller']);
  3888. });
  3889. it('creates NO edge when the factory return type lacks the method (silent miss, not a wrong edge)', async () => {
  3890. fs.writeFileSync(
  3891. path.join(tempDir, 'Main.swift'),
  3892. `class Foo {
  3893. static func make() -> Foo { return Foo() }
  3894. }
  3895. class Other { func onlyOther() {} }
  3896. func runCaller() { Foo.make().onlyOther() }
  3897. `
  3898. );
  3899. cg = await CodeGraph.init(tempDir, { index: true });
  3900. // Foo has no onlyOther() — must not mis-attach to the same-named Other::onlyOther.
  3901. expect(callerNamesOf('Other::onlyOther')).toEqual([]);
  3902. });
  3903. });
  3904. describe('Chained call resolves a method on a supertype (conformance, #750)', () => {
  3905. function callerNamesOf(qualifiedName: string): string[] {
  3906. const target = cg.getNodesByKind('method').find((n) => n.qualifiedName === qualifiedName);
  3907. if (!target) return [];
  3908. const names = cg
  3909. .getIncomingEdges(target.id)
  3910. .filter((e) => e.kind === 'calls')
  3911. .map((e) => cg.getNode(e.source)?.name)
  3912. .filter((n): n is string => !!n);
  3913. return [...new Set(names)].sort();
  3914. }
  3915. it('resolves a chained method defined only on a SUPERCLASS the return type extends', async () => {
  3916. // draw() lives on Base; Widget (the factory's return type) has no draw() of
  3917. // its own. Decoy.draw must never win. Needs the conformance second pass.
  3918. fs.writeFileSync(
  3919. path.join(tempDir, 'Main.java'),
  3920. `class Base { void draw() {} }
  3921. class Widget extends Base {}
  3922. class Decoy { void draw() {} }
  3923. class Factory { static Widget create() { return new Widget(); } }
  3924. class Caller {
  3925. void run() { Factory.create().draw(); }
  3926. }
  3927. `
  3928. );
  3929. cg = await CodeGraph.init(tempDir, { index: true });
  3930. expect(callerNamesOf('Base::draw')).toEqual(['run']);
  3931. expect(callerNamesOf('Decoy::draw')).toEqual([]);
  3932. });
  3933. it('resolves a chained method defined on an INTERFACE the return type implements (default method)', async () => {
  3934. fs.writeFileSync(
  3935. path.join(tempDir, 'Main.java'),
  3936. `interface Drawable { default void draw() {} }
  3937. class Widget implements Drawable {}
  3938. class Decoy { void draw() {} }
  3939. class Factory { static Widget create() { return new Widget(); } }
  3940. class Caller {
  3941. void run() { Factory.create().draw(); }
  3942. }
  3943. `
  3944. );
  3945. cg = await CodeGraph.init(tempDir, { index: true });
  3946. expect(callerNamesOf('Drawable::draw')).toEqual(['run']);
  3947. expect(callerNamesOf('Decoy::draw')).toEqual([]);
  3948. });
  3949. it('still creates NO edge when no supertype has the method (safety preserved)', async () => {
  3950. fs.writeFileSync(
  3951. path.join(tempDir, 'Main.java'),
  3952. `class Base {}
  3953. class Widget extends Base {}
  3954. class Other { void onlyOther() {} }
  3955. class Factory { static Widget create() { return new Widget(); } }
  3956. class Caller {
  3957. void run() { Factory.create().onlyOther(); }
  3958. }
  3959. `
  3960. );
  3961. cg = await CodeGraph.init(tempDir, { index: true });
  3962. // Neither Widget nor Base has onlyOther() — must not attach to Other::onlyOther.
  3963. expect(callerNamesOf('Other::onlyOther')).toEqual([]);
  3964. });
  3965. });
  3966. describe('Rust chained associated-function call resolution (#645/#608 mechanism)', () => {
  3967. function callerNamesOf(qualifiedName: string): string[] {
  3968. const target = cg.getNodesByKind('method').find((n) => n.qualifiedName === qualifiedName);
  3969. if (!target) return [];
  3970. const names = cg
  3971. .getIncomingEdges(target.id)
  3972. .filter((e) => e.kind === 'calls')
  3973. .map((e) => cg.getNode(e.source)?.name)
  3974. .filter((n): n is string => !!n);
  3975. return [...new Set(names)].sort();
  3976. }
  3977. it('resolves Foo::new().bar() (and a Self return) via the associated fn, never a same-named decoy', async () => {
  3978. fs.writeFileSync(
  3979. path.join(tempDir, 'main.rs'),
  3980. `struct Aaa { _x: i32 }
  3981. impl Aaa { fn bar(&self) {} }
  3982. struct Foo { _x: i32 }
  3983. impl Foo {
  3984. fn new() -> Foo { Foo { _x: 0 } }
  3985. fn make() -> Self { Foo { _x: 0 } }
  3986. fn bar(&self) {}
  3987. }
  3988. fn caller() {
  3989. Foo::new().bar();
  3990. Foo::make().bar();
  3991. }
  3992. `
  3993. );
  3994. cg = await CodeGraph.init(tempDir, { index: true });
  3995. expect(callerNamesOf('Foo::bar')).toEqual(['caller']);
  3996. expect(callerNamesOf('Aaa::bar')).toEqual([]);
  3997. });
  3998. it('resolves a chain that passes arguments — Foo::with(c).build()', async () => {
  3999. fs.writeFileSync(
  4000. path.join(tempDir, 'main.rs'),
  4001. `struct Config;
  4002. struct Foo { _x: i32 }
  4003. impl Foo {
  4004. fn with(c: Config) -> Foo { Foo { _x: 0 } }
  4005. fn build(&self) {}
  4006. }
  4007. fn caller() { Foo::with(Config).build(); }
  4008. `
  4009. );
  4010. cg = await CodeGraph.init(tempDir, { index: true });
  4011. expect(callerNamesOf('Foo::build')).toEqual(['caller']);
  4012. });
  4013. it('resolves a chained method from a trait the type implements (default method, via conformance)', async () => {
  4014. fs.writeFileSync(
  4015. path.join(tempDir, 'main.rs'),
  4016. `struct Foo { _x: i32 }
  4017. impl Foo { fn new() -> Foo { Foo { _x: 0 } } }
  4018. struct Decoy { _x: i32 }
  4019. impl Decoy { fn draw(&self) {} }
  4020. trait Drawable { fn draw(&self) {} }
  4021. impl Drawable for Foo {}
  4022. fn caller() { Foo::new().draw(); }
  4023. `
  4024. );
  4025. cg = await CodeGraph.init(tempDir, { index: true });
  4026. expect(callerNamesOf('Drawable::draw')).toEqual(['caller']);
  4027. expect(callerNamesOf('Decoy::draw')).toEqual([]);
  4028. });
  4029. it('creates NO edge when neither the type nor a supertype has the method (silent miss)', async () => {
  4030. fs.writeFileSync(
  4031. path.join(tempDir, 'main.rs'),
  4032. `struct Foo { _x: i32 }
  4033. impl Foo { fn new() -> Foo { Foo { _x: 0 } } }
  4034. struct Other { _x: i32 }
  4035. impl Other { fn only_other(&self) {} }
  4036. fn caller() { Foo::new().only_other(); }
  4037. `
  4038. );
  4039. cg = await CodeGraph.init(tempDir, { index: true });
  4040. // Foo has no only_other() — must not mis-attach to the same-named Other::only_other.
  4041. expect(callerNamesOf('Other::only_other')).toEqual([]);
  4042. });
  4043. });
  4044. describe('Go chained factory-function call resolution (#645/#608 mechanism)', () => {
  4045. function callerNamesOf(qualifiedName: string): string[] {
  4046. const target = cg.getNodesByKind('method').find((n) => n.qualifiedName === qualifiedName);
  4047. if (!target) return [];
  4048. const names = cg
  4049. .getIncomingEdges(target.id)
  4050. .filter((e) => e.kind === 'calls')
  4051. .map((e) => cg.getNode(e.source)?.name)
  4052. .filter((n): n is string => !!n);
  4053. return [...new Set(names)].sort();
  4054. }
  4055. it('resolves New().Bar() via the factory return type (pointer), never a same-named decoy', async () => {
  4056. fs.writeFileSync(
  4057. path.join(tempDir, 'main.go'),
  4058. `package main
  4059. type Aaa struct{}
  4060. func (a *Aaa) Bar() {}
  4061. type Foo struct{}
  4062. func New() *Foo { return &Foo{} }
  4063. func (f *Foo) Bar() {}
  4064. func caller() { New().Bar() }
  4065. `
  4066. );
  4067. cg = await CodeGraph.init(tempDir, { index: true });
  4068. expect(callerNamesOf('Foo::Bar')).toEqual(['caller']);
  4069. expect(callerNamesOf('Aaa::Bar')).toEqual([]);
  4070. });
  4071. it('resolves an args chain and a multi-return factory — With(c).Build(), (*Foo, error)', async () => {
  4072. fs.writeFileSync(
  4073. path.join(tempDir, 'main.go'),
  4074. `package main
  4075. type Config struct{}
  4076. type Foo struct{}
  4077. func With(c Config) (*Foo, error) { return &Foo{}, nil }
  4078. func (f *Foo) Build() {}
  4079. func caller() { With(Config{}).Build() }
  4080. `
  4081. );
  4082. cg = await CodeGraph.init(tempDir, { index: true });
  4083. expect(callerNamesOf('Foo::Build')).toEqual(['caller']);
  4084. });
  4085. it('resolves a method provided by an embedded struct (via conformance)', async () => {
  4086. fs.writeFileSync(
  4087. path.join(tempDir, 'main.go'),
  4088. `package main
  4089. type Base struct{}
  4090. func (b *Base) Embedded() {}
  4091. type Decoy struct{}
  4092. func (d *Decoy) Embedded() {}
  4093. type Widget struct{ Base }
  4094. func NewWidget() *Widget { return &Widget{} }
  4095. func caller() { NewWidget().Embedded() }
  4096. `
  4097. );
  4098. cg = await CodeGraph.init(tempDir, { index: true });
  4099. expect(callerNamesOf('Base::Embedded')).toEqual(['caller']);
  4100. expect(callerNamesOf('Decoy::Embedded')).toEqual([]);
  4101. });
  4102. it('creates NO edge when neither the type nor an embedded type has the method (silent miss)', async () => {
  4103. fs.writeFileSync(
  4104. path.join(tempDir, 'main.go'),
  4105. `package main
  4106. type Foo struct{}
  4107. func New() *Foo { return &Foo{} }
  4108. type Other struct{}
  4109. func (o *Other) OnlyOther() {}
  4110. func caller() { New().OnlyOther() }
  4111. `
  4112. );
  4113. cg = await CodeGraph.init(tempDir, { index: true });
  4114. // Foo has no OnlyOther() — must not mis-attach to the same-named Other::OnlyOther.
  4115. expect(callerNamesOf('Other::OnlyOther')).toEqual([]);
  4116. });
  4117. it('falls back to bare-name resolution for a VARIABLE-inner chain without exploding the graph', async () => {
  4118. // `engine` is a package-level VARIABLE holding a func value, not a factory
  4119. // FUNCTION — so its return type can't be recovered and the chain falls back
  4120. // to bare-name resolution of the method (restoring the pre-re-encoding edge).
  4121. // Regression for the runaway this fallback originally caused: it resolved
  4122. // with a mutated `original.referenceName` (the bare `ServeHTTP`, not the
  4123. // stored `engine().ServeHTTP`), so the batched resolver's keyed delete
  4124. // no-oped, the offset-0 batch never drained, and edges inserted forever
  4125. // (5M edges / 1.4 GB on a 99-file repo). The fallback now ties the match to
  4126. // the original ref, and a non-progress guard backstops the loop.
  4127. fs.writeFileSync(
  4128. path.join(tempDir, 'main.go'),
  4129. `package main
  4130. type Server struct{}
  4131. func (s *Server) ServeHTTP() {}
  4132. var engine = func() *Server { return &Server{} }
  4133. func caller() { engine().ServeHTTP() }
  4134. `
  4135. );
  4136. cg = await CodeGraph.init(tempDir, { index: true });
  4137. // Recall: the variable-inner chain still finds the method by bare name.
  4138. expect(callerNamesOf('Server::ServeHTTP')).toEqual(['caller']);
  4139. // No runaway: a single call site yields a single edge, not millions.
  4140. const target = cg
  4141. .getNodesByKind('method')
  4142. .find((n) => n.qualifiedName === 'Server::ServeHTTP')!;
  4143. const rawCalls = cg
  4144. .getIncomingEdges(target.id)
  4145. .filter((e) => e.kind === 'calls');
  4146. expect(rawCalls.length).toBeLessThan(5);
  4147. });
  4148. });
  4149. describe('Scala chained static-factory call resolution (#645/#608 mechanism)', () => {
  4150. function callerNamesOf(qualifiedName: string): string[] {
  4151. const target = cg.getNodesByKind('method').find((n) => n.qualifiedName === qualifiedName);
  4152. if (!target) return [];
  4153. const names = cg
  4154. .getIncomingEdges(target.id)
  4155. .filter((e) => e.kind === 'calls')
  4156. .map((e) => cg.getNode(e.source)?.name)
  4157. .filter((n): n is string => !!n);
  4158. return [...new Set(names)].sort();
  4159. }
  4160. it('resolves a companion-factory chain Foo.create().doIt() to the return type, never a same-named decoy', async () => {
  4161. fs.writeFileSync(
  4162. path.join(tempDir, 'Main.scala'),
  4163. `object Foo {
  4164. def create(): Bar = new Bar()
  4165. }
  4166. class Bar {
  4167. def doIt(): Unit = {}
  4168. }
  4169. class Decoy {
  4170. def doIt(): Unit = {}
  4171. }
  4172. object Main {
  4173. def run(): Unit = { Foo.create().doIt() }
  4174. }
  4175. `
  4176. );
  4177. cg = await CodeGraph.init(tempDir, { index: true });
  4178. expect(callerNamesOf('Bar::doIt')).toEqual(['run']);
  4179. expect(callerNamesOf('Decoy::doIt')).toEqual([]);
  4180. });
  4181. it('resolves a case-class apply construction Point(x).dist() on the constructed class', async () => {
  4182. fs.writeFileSync(
  4183. path.join(tempDir, 'Main.scala'),
  4184. `class Point(x: Int) {
  4185. def dist(): Int = x
  4186. }
  4187. class Other {
  4188. def dist(): Int = 0
  4189. }
  4190. object Main {
  4191. def run(): Unit = { Point(3).dist() }
  4192. }
  4193. `
  4194. );
  4195. cg = await CodeGraph.init(tempDir, { index: true });
  4196. expect(callerNamesOf('Point::dist')).toEqual(['run']);
  4197. expect(callerNamesOf('Other::dist')).toEqual([]);
  4198. });
  4199. it('resolves a chained method provided by a trait the return type extends (via conformance)', async () => {
  4200. fs.writeFileSync(
  4201. path.join(tempDir, 'Main.scala'),
  4202. `trait Base {
  4203. def shared(): Unit = {}
  4204. }
  4205. class Widget extends Base
  4206. class Decoy {
  4207. def shared(): Unit = {}
  4208. }
  4209. object Factory {
  4210. def make(): Widget = new Widget()
  4211. }
  4212. object Main {
  4213. def run(): Unit = { Factory.make().shared() }
  4214. }
  4215. `
  4216. );
  4217. cg = await CodeGraph.init(tempDir, { index: true });
  4218. expect(callerNamesOf('Base::shared')).toEqual(['run']);
  4219. expect(callerNamesOf('Decoy::shared')).toEqual([]);
  4220. });
  4221. it('creates NO edge when neither the factory return type nor a supertype has the method (silent miss)', async () => {
  4222. fs.writeFileSync(
  4223. path.join(tempDir, 'Main.scala'),
  4224. `object Foo {
  4225. def create(): Bar = new Bar()
  4226. }
  4227. class Bar {
  4228. }
  4229. class Other {
  4230. def onlyOther(): Unit = {}
  4231. }
  4232. object Main {
  4233. def run(): Unit = { Foo.create().onlyOther() }
  4234. }
  4235. `
  4236. );
  4237. cg = await CodeGraph.init(tempDir, { index: true });
  4238. // Bar has no onlyOther() — must not mis-attach to the same-named Other::onlyOther.
  4239. expect(callerNamesOf('Other::onlyOther')).toEqual([]);
  4240. });
  4241. });
  4242. describe('Dart chained static-factory / factory-constructor call resolution (#645/#608 mechanism)', () => {
  4243. function callerNamesOf(qualifiedName: string): string[] {
  4244. const target = cg.getNodesByKind('method').find((n) => n.qualifiedName === qualifiedName);
  4245. if (!target) return [];
  4246. const names = cg
  4247. .getIncomingEdges(target.id)
  4248. .filter((e) => e.kind === 'calls')
  4249. .map((e) => cg.getNode(e.source)?.name)
  4250. .filter((n): n is string => !!n);
  4251. return [...new Set(names)].sort();
  4252. }
  4253. it('resolves a static-factory chain Foo.makeBar().doIt() to the return type, never a same-named decoy', async () => {
  4254. fs.writeFileSync(
  4255. path.join(tempDir, 'main.dart'),
  4256. `class Foo {
  4257. static Bar makeBar() => Bar();
  4258. }
  4259. class Bar {
  4260. void doIt() {}
  4261. }
  4262. class Decoy {
  4263. void doIt() {}
  4264. }
  4265. void run() {
  4266. Foo.makeBar().doIt();
  4267. }
  4268. `
  4269. );
  4270. cg = await CodeGraph.init(tempDir, { index: true });
  4271. expect(callerNamesOf('Bar::doIt')).toEqual(['run']);
  4272. expect(callerNamesOf('Decoy::doIt')).toEqual([]);
  4273. });
  4274. it('resolves a named factory-constructor chain Foo.create().ship() on the constructed class', async () => {
  4275. fs.writeFileSync(
  4276. path.join(tempDir, 'main.dart'),
  4277. `class Foo {
  4278. Foo._();
  4279. factory Foo.create() => Foo._();
  4280. void ship() {}
  4281. }
  4282. class Decoy {
  4283. void ship() {}
  4284. }
  4285. void run() {
  4286. Foo.create().ship();
  4287. }
  4288. `
  4289. );
  4290. cg = await CodeGraph.init(tempDir, { index: true });
  4291. // The factory constructor `Foo.create` is now a node whose return type is Foo,
  4292. // so `ship` resolves on Foo, not the same-named Decoy.
  4293. expect(callerNamesOf('Foo::ship')).toEqual(['run']);
  4294. expect(callerNamesOf('Decoy::ship')).toEqual([]);
  4295. });
  4296. it('resolves a constructor-receiver chain Bar().doIt() on the constructed class', async () => {
  4297. fs.writeFileSync(
  4298. path.join(tempDir, 'main.dart'),
  4299. `class Bar {
  4300. void doIt() {}
  4301. }
  4302. class Decoy {
  4303. void doIt() {}
  4304. }
  4305. void run() {
  4306. Bar().doIt();
  4307. }
  4308. `
  4309. );
  4310. cg = await CodeGraph.init(tempDir, { index: true });
  4311. expect(callerNamesOf('Bar::doIt')).toEqual(['run']);
  4312. expect(callerNamesOf('Decoy::doIt')).toEqual([]);
  4313. });
  4314. it('resolves a chained method inherited from a superclass the return type extends (via conformance)', async () => {
  4315. fs.writeFileSync(
  4316. path.join(tempDir, 'main.dart'),
  4317. `class Base {
  4318. void render() {}
  4319. }
  4320. class Widget extends Base {
  4321. static Widget make() => Widget();
  4322. }
  4323. class Decoy {
  4324. void render() {}
  4325. }
  4326. void run() {
  4327. Widget.make().render();
  4328. }
  4329. `
  4330. );
  4331. cg = await CodeGraph.init(tempDir, { index: true });
  4332. expect(callerNamesOf('Base::render')).toEqual(['run']);
  4333. expect(callerNamesOf('Decoy::render')).toEqual([]);
  4334. });
  4335. it('creates NO edge when neither the factory return type nor a supertype has the method (silent miss)', async () => {
  4336. fs.writeFileSync(
  4337. path.join(tempDir, 'main.dart'),
  4338. `class Foo {
  4339. static Bar makeBar() => Bar();
  4340. }
  4341. class Bar {
  4342. }
  4343. class Other {
  4344. void onlyOther() {}
  4345. }
  4346. void run() {
  4347. Foo.makeBar().onlyOther();
  4348. }
  4349. `
  4350. );
  4351. cg = await CodeGraph.init(tempDir, { index: true });
  4352. // Bar has no onlyOther() — must not mis-attach to the same-named Other::onlyOther.
  4353. expect(callerNamesOf('Other::onlyOther')).toEqual([]);
  4354. });
  4355. it('still extracts a method tree-sitter misparses as a constructor (@override + record return)', async () => {
  4356. // tree-sitter-dart misparses `@override (A, B) reduce()` — the annotation
  4357. // swallows the record return type, so `reduce()` looks like a single-
  4358. // identifier constructor_signature. It must NOT be skipped as an unnamed
  4359. // ctor (its name doesn't match the class); its body call must attribute to
  4360. // `reduce`, not the class.
  4361. fs.writeFileSync(
  4362. path.join(tempDir, 'main.dart'),
  4363. `class Base {}
  4364. class Action extends Base {
  4365. Action({required int x});
  4366. @override
  4367. (int, String) reduce() {
  4368. return (compute(), "y");
  4369. }
  4370. int compute() => 1;
  4371. }
  4372. `
  4373. );
  4374. cg = await CodeGraph.init(tempDir, { index: true });
  4375. // reduce must be a node and its body call must resolve to Action::compute.
  4376. expect(callerNamesOf('Action::compute')).toEqual(['reduce']);
  4377. });
  4378. it('keeps plain construction Foo() as instantiation, not a Foo::Foo method call', async () => {
  4379. // The unnamed constructor is intentionally NOT extracted as a `Foo::Foo`
  4380. // method, so `Foo(...)` resolves to the class (an `instantiates` edge),
  4381. // never hijacked into a call to a phantom constructor method.
  4382. fs.writeFileSync(
  4383. path.join(tempDir, 'main.dart'),
  4384. `class Widget {
  4385. final int x;
  4386. Widget(this.x);
  4387. }
  4388. void run() {
  4389. Widget(3);
  4390. }
  4391. `
  4392. );
  4393. cg = await CodeGraph.init(tempDir, { index: true });
  4394. // No Foo::Foo phantom method node.
  4395. expect(cg.getNodesByKind('method').some((n) => n.qualifiedName === 'Widget::Widget')).toBe(false);
  4396. // The construction resolves to the class as an `instantiates` edge.
  4397. const widget = cg.getNodesByKind('class').find((n) => n.name === 'Widget')!;
  4398. const incoming = cg.getIncomingEdges(widget.id);
  4399. expect(incoming.some((e) => e.kind === 'instantiates')).toBe(true);
  4400. });
  4401. });
  4402. describe('Objective-C chained message-send call resolution (#645/#608 mechanism)', () => {
  4403. function callerNamesOf(qualifiedName: string): string[] {
  4404. const target = cg.getNodesByKind('method').find((n) => n.qualifiedName === qualifiedName);
  4405. if (!target) return [];
  4406. const names = cg
  4407. .getIncomingEdges(target.id)
  4408. .filter((e) => e.kind === 'calls')
  4409. .map((e) => cg.getNode(e.source)?.name)
  4410. .filter((n): n is string => !!n);
  4411. return [...new Set(names)].sort();
  4412. }
  4413. it('resolves a chained message send [[Foo create] doIt] via the return type, never a same-named decoy', async () => {
  4414. fs.writeFileSync(
  4415. path.join(tempDir, 'main.m'),
  4416. `@interface Bar : NSObject
  4417. - (void)doIt;
  4418. @end
  4419. @implementation Bar
  4420. - (void)doIt {}
  4421. @end
  4422. @interface Decoy : NSObject
  4423. - (void)doIt;
  4424. @end
  4425. @implementation Decoy
  4426. - (void)doIt {}
  4427. @end
  4428. @interface Foo : NSObject
  4429. + (Bar *)create;
  4430. @end
  4431. @implementation Foo
  4432. + (Bar *)create { return nil; }
  4433. - (void)run { [[Foo create] doIt]; }
  4434. @end
  4435. `
  4436. );
  4437. cg = await CodeGraph.init(tempDir, { index: true });
  4438. expect(callerNamesOf('Bar::doIt')).toEqual(['run']);
  4439. expect(callerNamesOf('Decoy::doIt')).toEqual([]);
  4440. });
  4441. it('resolves a chained message whose method is inherited from a superclass (via conformance)', async () => {
  4442. fs.writeFileSync(
  4443. path.join(tempDir, 'main.m'),
  4444. `@interface Base : NSObject
  4445. - (void)render;
  4446. @end
  4447. @implementation Base
  4448. - (void)render {}
  4449. @end
  4450. @interface Widget : Base
  4451. @end
  4452. @implementation Widget
  4453. @end
  4454. @interface Decoy : NSObject
  4455. - (void)render;
  4456. @end
  4457. @implementation Decoy
  4458. - (void)render {}
  4459. @end
  4460. @interface Factory : NSObject
  4461. + (Widget *)make;
  4462. @end
  4463. @implementation Factory
  4464. + (Widget *)make { return nil; }
  4465. - (void)run { [[Factory make] render]; }
  4466. @end
  4467. `
  4468. );
  4469. cg = await CodeGraph.init(tempDir, { index: true });
  4470. expect(callerNamesOf('Base::render')).toEqual(['run']);
  4471. expect(callerNamesOf('Decoy::render')).toEqual([]);
  4472. });
  4473. it('creates NO edge when the factory return type lacks the method (silent miss)', async () => {
  4474. fs.writeFileSync(
  4475. path.join(tempDir, 'main.m'),
  4476. `@interface Bar : NSObject
  4477. @end
  4478. @implementation Bar
  4479. @end
  4480. @interface Other : NSObject
  4481. - (void)onlyOther;
  4482. @end
  4483. @implementation Other
  4484. - (void)onlyOther {}
  4485. @end
  4486. @interface Foo : NSObject
  4487. + (Bar *)create;
  4488. @end
  4489. @implementation Foo
  4490. + (Bar *)create { return nil; }
  4491. - (void)run { [[Foo create] onlyOther]; }
  4492. @end
  4493. `
  4494. );
  4495. cg = await CodeGraph.init(tempDir, { index: true });
  4496. // Bar has no onlyOther — must not mis-attach to the same-named Other::onlyOther.
  4497. expect(callerNamesOf('Other::onlyOther')).toEqual([]);
  4498. });
  4499. it('resolves a singleton chain [[Cache shared] clearAll] whose factory returns nonnull instancetype', async () => {
  4500. // The factory returns `nonnull instancetype` — the nullability qualifier must
  4501. // be skipped (not captured AS the type), and an instancetype class-message
  4502. // factory returns the receiver class, so clearAll resolves on Cache, never a
  4503. // same-named decoy. (Regression for both: the captured-`nonnull` bug and the
  4504. // ubiquitous `[[X alloc] init]` / singleton pattern.)
  4505. fs.writeFileSync(
  4506. path.join(tempDir, 'main.m'),
  4507. `@interface Cache : NSObject
  4508. + (nonnull instancetype)shared;
  4509. - (void)clearAll;
  4510. @end
  4511. @implementation Cache
  4512. + (nonnull instancetype)shared { return nil; }
  4513. - (void)clearAll {}
  4514. @end
  4515. @interface Decoy : NSObject
  4516. - (void)clearAll;
  4517. @end
  4518. @implementation Decoy
  4519. - (void)clearAll {}
  4520. @end
  4521. @interface Caller : NSObject
  4522. - (void)run;
  4523. @end
  4524. @implementation Caller
  4525. - (void)run { [[Cache shared] clearAll]; }
  4526. @end
  4527. `
  4528. );
  4529. cg = await CodeGraph.init(tempDir, { index: true });
  4530. expect(callerNamesOf('Cache::clearAll')).toEqual(['run']);
  4531. expect(callerNamesOf('Decoy::clearAll')).toEqual([]);
  4532. });
  4533. });
  4534. describe('Pascal/Delphi chained static-factory call resolution (#645/#608 mechanism)', () => {
  4535. function callerNamesOf(qualifiedName: string): string[] {
  4536. const target = cg.getNodesByKind('method').find((n) => n.qualifiedName === qualifiedName);
  4537. if (!target) return [];
  4538. const names = cg
  4539. .getIncomingEdges(target.id)
  4540. .filter((e) => e.kind === 'calls')
  4541. .map((e) => cg.getNode(e.source)?.name)
  4542. .filter((n): n is string => !!n);
  4543. return [...new Set(names)].sort();
  4544. }
  4545. function isCalled(qn: string): boolean {
  4546. const t = cg.getNodesByKind('method').find((n) => n.qualifiedName === qn);
  4547. return !!t && cg.getIncomingEdges(t.id).some((e) => e.kind === 'calls');
  4548. }
  4549. it('resolves a chained factory call TFoo.GetInstance().DoIt() via the return type, never a same-named decoy', async () => {
  4550. fs.writeFileSync(
  4551. path.join(tempDir, 'main.pas'),
  4552. `unit Main;
  4553. interface
  4554. type
  4555. TBar = class
  4556. procedure DoIt;
  4557. end;
  4558. TDecoy = class
  4559. procedure DoIt;
  4560. end;
  4561. TFoo = class
  4562. class function GetInstance: TBar;
  4563. end;
  4564. implementation
  4565. procedure TBar.DoIt; begin end;
  4566. procedure TDecoy.DoIt; begin end;
  4567. class function TFoo.GetInstance: TBar; begin Result := nil; end;
  4568. procedure Run;
  4569. begin
  4570. TFoo.GetInstance().DoIt();
  4571. end;
  4572. end.
  4573. `
  4574. );
  4575. cg = await CodeGraph.init(tempDir, { index: true });
  4576. expect(isCalled('TBar::DoIt')).toBe(true);
  4577. expect(isCalled('TDecoy::DoIt')).toBe(false);
  4578. });
  4579. it('resolves a constructor chain TFoo.Create().Configure() on the constructed class', async () => {
  4580. fs.writeFileSync(
  4581. path.join(tempDir, 'main.pas'),
  4582. `unit Main;
  4583. interface
  4584. type
  4585. TFoo = class
  4586. constructor Create;
  4587. procedure Configure;
  4588. end;
  4589. TDecoy = class
  4590. procedure Configure;
  4591. end;
  4592. implementation
  4593. constructor TFoo.Create; begin end;
  4594. procedure TFoo.Configure; begin end;
  4595. procedure TDecoy.Configure; begin end;
  4596. procedure Run;
  4597. begin
  4598. TFoo.Create().Configure();
  4599. end;
  4600. end.
  4601. `
  4602. );
  4603. cg = await CodeGraph.init(tempDir, { index: true });
  4604. // A constructor returns its own class (no `: TBar` annotation), so Configure
  4605. // resolves on TFoo, not the same-named decoy.
  4606. expect(isCalled('TFoo::Configure')).toBe(true);
  4607. expect(isCalled('TDecoy::Configure')).toBe(false);
  4608. });
  4609. it('resolves a typecast chain TFoo(x).DoIt() on the cast type', async () => {
  4610. fs.writeFileSync(
  4611. path.join(tempDir, 'main.pas'),
  4612. `unit Main;
  4613. interface
  4614. type
  4615. TFoo = class
  4616. procedure DoIt;
  4617. end;
  4618. TDecoy = class
  4619. procedure DoIt;
  4620. end;
  4621. implementation
  4622. procedure TFoo.DoIt; begin end;
  4623. procedure TDecoy.DoIt; begin end;
  4624. procedure Run(obj: TObject);
  4625. begin
  4626. TFoo(obj).DoIt();
  4627. end;
  4628. end.
  4629. `
  4630. );
  4631. cg = await CodeGraph.init(tempDir, { index: true });
  4632. expect(isCalled('TFoo::DoIt')).toBe(true);
  4633. expect(isCalled('TDecoy::DoIt')).toBe(false);
  4634. });
  4635. it('creates NO edge when the factory return type lacks the method (silent miss)', async () => {
  4636. fs.writeFileSync(
  4637. path.join(tempDir, 'main.pas'),
  4638. `unit Main;
  4639. interface
  4640. type
  4641. TBar = class
  4642. end;
  4643. TOther = class
  4644. procedure OnlyOther;
  4645. end;
  4646. TFoo = class
  4647. class function GetInstance: TBar;
  4648. end;
  4649. implementation
  4650. procedure TOther.OnlyOther; begin end;
  4651. class function TFoo.GetInstance: TBar; begin Result := nil; end;
  4652. procedure Run;
  4653. begin
  4654. TFoo.GetInstance().OnlyOther();
  4655. end;
  4656. end.
  4657. `
  4658. );
  4659. cg = await CodeGraph.init(tempDir, { index: true });
  4660. // TBar has no OnlyOther — must not mis-attach to the same-named TOther::OnlyOther.
  4661. expect(isCalled('TOther::OnlyOther')).toBe(false);
  4662. });
  4663. it('extracts paren-less method calls (Pascal lets a no-arg method drop its parens)', async () => {
  4664. fs.writeFileSync(
  4665. path.join(tempDir, 'main.pas'),
  4666. `unit Main;
  4667. interface
  4668. type
  4669. TFoo = class
  4670. procedure DoThing;
  4671. procedure Reset;
  4672. end;
  4673. implementation
  4674. procedure TFoo.DoThing; begin end;
  4675. procedure TFoo.Reset; begin end;
  4676. procedure Run(f: TFoo);
  4677. begin
  4678. f.DoThing;
  4679. f.Reset;
  4680. end;
  4681. end.
  4682. `
  4683. );
  4684. cg = await CodeGraph.init(tempDir, { index: true });
  4685. expect(isCalled('TFoo::DoThing')).toBe(true);
  4686. expect(isCalled('TFoo::Reset')).toBe(true);
  4687. });
  4688. it('resolves a PAREN-LESS chained factory call TFoo.GetInstance.DoIt via the return type', async () => {
  4689. fs.writeFileSync(
  4690. path.join(tempDir, 'main.pas'),
  4691. `unit Main;
  4692. interface
  4693. type
  4694. TBar = class
  4695. procedure DoIt;
  4696. end;
  4697. TDecoy = class
  4698. procedure DoIt;
  4699. end;
  4700. TFoo = class
  4701. class function GetInstance: TBar;
  4702. end;
  4703. implementation
  4704. procedure TBar.DoIt; begin end;
  4705. procedure TDecoy.DoIt; begin end;
  4706. class function TFoo.GetInstance: TBar; begin Result := nil; end;
  4707. procedure Run;
  4708. begin
  4709. TFoo.GetInstance.DoIt;
  4710. end;
  4711. end.
  4712. `
  4713. );
  4714. cg = await CodeGraph.init(tempDir, { index: true });
  4715. expect(isCalled('TBar::DoIt')).toBe(true);
  4716. expect(isCalled('TDecoy::DoIt')).toBe(false);
  4717. });
  4718. it('does NOT turn a property write/read into a call edge (only statement-level dots are calls)', async () => {
  4719. fs.writeFileSync(
  4720. path.join(tempDir, 'main.pas'),
  4721. `unit Main;
  4722. interface
  4723. type
  4724. TFoo = class
  4725. function GetValue: Integer;
  4726. procedure SetValue(v: Integer);
  4727. property Value: Integer read GetValue write SetValue;
  4728. end;
  4729. implementation
  4730. function TFoo.GetValue: Integer; begin Result := 0; end;
  4731. procedure TFoo.SetValue(v: Integer); begin end;
  4732. procedure Run(f: TFoo);
  4733. var x: Integer;
  4734. begin
  4735. f.Value := 5;
  4736. x := f.Value;
  4737. end;
  4738. end.
  4739. `
  4740. );
  4741. cg = await CodeGraph.init(tempDir, { index: true });
  4742. // A property read/write is a bare dot in assignment position, not a statement,
  4743. // so it must not be mis-extracted as a call to the property's getter/setter.
  4744. expect(isCalled('TFoo::GetValue')).toBe(false);
  4745. expect(isCalled('TFoo::SetValue')).toBe(false);
  4746. });
  4747. it('attributes an implementation-only free procedure\'s calls to the procedure, not the file', async () => {
  4748. fs.writeFileSync(
  4749. path.join(tempDir, 'main.pas'),
  4750. `unit Main;
  4751. interface
  4752. type
  4753. TTgt = class
  4754. procedure Hit;
  4755. end;
  4756. TFoo = class
  4757. procedure DoStuff;
  4758. end;
  4759. implementation
  4760. procedure TTgt.Hit; begin end;
  4761. procedure TFoo.DoStuff; var t: TTgt; begin t.Hit; end;
  4762. procedure Helper; var t: TTgt; begin t.Hit; end;
  4763. `
  4764. );
  4765. cg = await CodeGraph.init(tempDir, { index: true });
  4766. // `Helper` is implementation-only (no interface decl, not a method), but its
  4767. // body's call must attribute to `Helper`, not the file/module — alongside the
  4768. // method `DoStuff`.
  4769. expect(callerNamesOf('TTgt::Hit')).toEqual(['DoStuff', 'Helper']);
  4770. });
  4771. });
  4772. describe('Nix path import resolution', () => {
  4773. function fileNode(filePath: string) {
  4774. return cg.getNodesByKind('file').find((n) => n.filePath === filePath);
  4775. }
  4776. function importedFilePaths(fromFile: string): string[] {
  4777. const source = fileNode(fromFile);
  4778. expect(source, `${fromFile} file node`).toBeDefined();
  4779. return cg
  4780. .getOutgoingEdges(source!.id)
  4781. .filter((edge) => edge.kind === 'imports')
  4782. .map((edge) => cg.getNodesByKind('file').find((n) => n.id === edge.target)?.filePath)
  4783. .filter((filePath): filePath is string => Boolean(filePath))
  4784. .sort();
  4785. }
  4786. it('resolves relative Nix imports to indexed file nodes', async () => {
  4787. fs.mkdirSync(path.join(tempDir, 'core'), { recursive: true });
  4788. fs.mkdirSync(path.join(tempDir, 'data'), { recursive: true });
  4789. fs.writeFileSync(path.join(tempDir, 'core', 'ports.nix'), '{ http = 80; https = 443; }');
  4790. fs.writeFileSync(
  4791. path.join(tempDir, 'data', 'postgresql.nix'),
  4792. `let
  4793. ports = import ../core/ports.nix;
  4794. in
  4795. {
  4796. port = ports.https;
  4797. }
  4798. `
  4799. );
  4800. cg = await CodeGraph.init(tempDir, { index: true });
  4801. cg.resolveReferences();
  4802. expect(importedFilePaths('data/postgresql.nix')).toEqual(['core/ports.nix']);
  4803. });
  4804. it('resolves Nix directory imports through default.nix and deduplicates called imports', async () => {
  4805. fs.mkdirSync(path.join(tempDir, 'dir'), { recursive: true });
  4806. fs.writeFileSync(path.join(tempDir, 'dir', 'default.nix'), '{ value = 1; }');
  4807. fs.writeFileSync(path.join(tempDir, 'x.nix'), '{ value = 2; }');
  4808. fs.writeFileSync(
  4809. path.join(tempDir, 'main.nix'),
  4810. `let
  4811. dir = import ./dir;
  4812. x = import ./x.nix {};
  4813. in
  4814. {
  4815. inherit dir x;
  4816. }
  4817. `
  4818. );
  4819. cg = await CodeGraph.init(tempDir, { index: true });
  4820. cg.resolveReferences();
  4821. expect(importedFilePaths('main.nix')).toEqual(['dir/default.nix', 'x.nix']);
  4822. });
  4823. it('resolves NixOS module imports lists and callPackage paths to file nodes', async () => {
  4824. fs.mkdirSync(path.join(tempDir, 'modules'), { recursive: true });
  4825. fs.mkdirSync(path.join(tempDir, 'common'), { recursive: true });
  4826. fs.mkdirSync(path.join(tempDir, 'pkgs', 'hello'), { recursive: true });
  4827. fs.writeFileSync(path.join(tempDir, 'modules', 'users.nix'), '{ users.users.demo.isNormalUser = true; }');
  4828. fs.writeFileSync(path.join(tempDir, 'common', 'default.nix'), '{ time.timeZone = "UTC"; }');
  4829. fs.writeFileSync(
  4830. path.join(tempDir, 'pkgs', 'hello', 'default.nix'),
  4831. '{ stdenv }: stdenv.mkDerivation { pname = "hello"; }'
  4832. );
  4833. fs.writeFileSync(
  4834. path.join(tempDir, 'configuration.nix'),
  4835. `{ config, pkgs, ... }:
  4836. {
  4837. imports = [ ./modules/users.nix ./common ];
  4838. environment.systemPackages = [ (pkgs.callPackage ./pkgs/hello { }) ];
  4839. }
  4840. `
  4841. );
  4842. cg = await CodeGraph.init(tempDir, { index: true });
  4843. cg.resolveReferences();
  4844. expect(importedFilePaths('configuration.nix')).toEqual([
  4845. 'common/default.nix',
  4846. 'modules/users.nix',
  4847. 'pkgs/hello/default.nix',
  4848. ]);
  4849. });
  4850. it('never resolves another language\'s calls into nix bindings', async () => {
  4851. // Nix bindings are not linkable symbols from any other language —
  4852. // interop is eval/CLI. Without the target-side gate, a Python script's
  4853. // bare `resolve(...)` exact-matches a module's `resolve = ...` binding.
  4854. fs.writeFileSync(
  4855. path.join(tempDir, 'helpers.nix'),
  4856. `let
  4857. resolve = x: x;
  4858. in
  4859. {
  4860. inherit resolve;
  4861. }
  4862. `
  4863. );
  4864. fs.writeFileSync(path.join(tempDir, 'tool.py'), 'def main():\n return resolve("target")\n');
  4865. cg = await CodeGraph.init(tempDir, { index: true });
  4866. cg.resolveReferences();
  4867. const nixNodeIds = new Set(
  4868. cg.getNodesByKind('variable').filter((n) => n.language === 'nix').map((n) => n.id)
  4869. );
  4870. const pyFns = cg.getNodesByKind('function').filter((n) => n.language === 'python');
  4871. expect(pyFns.length).toBeGreaterThan(0);
  4872. const crossEdges = pyFns.flatMap((f) => cg.getOutgoingEdges(f.id)).filter((e) => nixNodeIds.has(e.target));
  4873. expect(crossEdges).toEqual([]);
  4874. });
  4875. it('never cross-links Nix calls by bare name across files (lexical scope only)', async () => {
  4876. // Both modules `inherit (lib) mkOption` — the nixpkgs idiom. A call to
  4877. // mkOption in one file must NOT resolve to the other file's inherit
  4878. // binding: Nix has no ambient cross-file namespace, so any such edge is
  4879. // wrong by construction. Same-file bindings still resolve.
  4880. fs.writeFileSync(
  4881. path.join(tempDir, 'alpha.nix'),
  4882. `{ lib, ... }:
  4883. let
  4884. inherit (lib) mkOption;
  4885. mkPort = default: mkOption { inherit default; };
  4886. in
  4887. {
  4888. options.alpha.port = mkPort 8080;
  4889. }
  4890. `
  4891. );
  4892. fs.writeFileSync(
  4893. path.join(tempDir, 'beta.nix'),
  4894. `{ lib, ... }:
  4895. let
  4896. inherit (lib) mkOption;
  4897. in
  4898. {
  4899. options.beta.enable = mkOption { default = false; };
  4900. }
  4901. `
  4902. );
  4903. cg = await CodeGraph.init(tempDir, { index: true });
  4904. cg.resolveReferences();
  4905. const crossFileCalls = cg
  4906. .getNodesByKind('file')
  4907. .flatMap((f) => cg.getOutgoingEdges(f.id))
  4908. .concat(
  4909. cg.getNodesByKind('function').flatMap((f) => cg.getOutgoingEdges(f.id)),
  4910. cg.getNodesByKind('variable').flatMap((v) => cg.getOutgoingEdges(v.id))
  4911. )
  4912. .filter((e) => e.kind === 'calls')
  4913. .map((e) => {
  4914. const src = cg.getNode(e.source);
  4915. const tgt = cg.getNode(e.target);
  4916. return { from: src?.filePath, to: tgt?.filePath, name: tgt?.name };
  4917. });
  4918. // No calls edge may cross files by bare-name matching.
  4919. expect(crossFileCalls.filter((e) => e.from !== e.to)).toEqual([]);
  4920. // The same-file chain still resolves: mkPort's mkOption call hits
  4921. // alpha.nix's own inherit binding.
  4922. const sameFile = crossFileCalls.filter((e) => e.from === e.to && e.name === 'mkOption');
  4923. expect(sameFile.length).toBeGreaterThan(0);
  4924. expect(sameFile.every((e) => e.from === 'alpha.nix' || e.from === 'beta.nix')).toBe(true);
  4925. });
  4926. it('does not resolve Nix angle-bracket, attribute, or variable imports as project file edges', async () => {
  4927. fs.writeFileSync(path.join(tempDir, 'nixpkgs.nix'), '{ bogus = true; }');
  4928. fs.writeFileSync(path.join(tempDir, 'selectedPath.nix'), '{ bogus = true; }');
  4929. fs.writeFileSync(
  4930. path.join(tempDir, 'main.nix'),
  4931. `let
  4932. pkgs = import <nixpkgs> {};
  4933. fromSources = import sources.nixpkgs {};
  4934. dynamic = import selectedPath;
  4935. in
  4936. {
  4937. inherit pkgs fromSources dynamic;
  4938. }
  4939. `
  4940. );
  4941. cg = await CodeGraph.init(tempDir, { index: true });
  4942. cg.resolveReferences();
  4943. expect(importedFilePaths('main.nix')).toEqual([]);
  4944. });
  4945. });
  4946. describe('Bindings in a module that exports nothing (#1719)', () => {
  4947. it('does not treat documentation headings as package imports', () => {
  4948. // Inject the planned Markdown node shape without depending on its extractor.
  4949. const heading: Node = {
  4950. id: 'heading:vite', name: 'vite', qualifiedName: 'guide.md#vite',
  4951. kind: 'module', language: 'markdown' as Node['language'], filePath: 'guide.md',
  4952. startLine: 1, endLine: 1, startColumn: 0, endColumn: 0, updatedAt: 0,
  4953. };
  4954. const context = {
  4955. getNodesByName: () => [heading], getNodesInFile: () => [],
  4956. getNodesByQualifiedName: () => [], getNodesByKind: () => [],
  4957. fileExists: () => false, readFile: () => null,
  4958. getProjectRoot: () => tempDir, getAllFiles: () => [],
  4959. } as ResolutionContext;
  4960. const ref: UnresolvedRef = {
  4961. fromNodeId: 'file:consumer.ts', referenceName: 'vite', referenceKind: 'imports',
  4962. filePath: 'consumer.ts', language: 'typescript', line: 1, column: 0,
  4963. };
  4964. expect(matchByExactName(ref, context)).toBeNull();
  4965. expect(matchByExactName({ ...ref, language: 'markdown' as Node['language'] }, context)?.targetNodeId).toBe(heading.id);
  4966. context.getNodesByName = () => [{ ...heading, id: 'fn:vite', kind: 'function', language: 'typescript', filePath: 'vite.ts' }];
  4967. expect(matchByExactName(ref, context)?.targetNodeId).toBe('fn:vite');
  4968. });
  4969. it('ignores export examples in strings and comments when checking module visibility', async () => {
  4970. fs.mkdirSync(path.join(tempDir, 'src'));
  4971. fs.writeFileSync(path.join(tempDir, 'src/private.js'), [
  4972. "import fs from 'node:fs'",
  4973. 'const example = `',
  4974. 'export const example = 1',
  4975. '`',
  4976. '/*',
  4977. 'export { hidden }',
  4978. '*/',
  4979. 'function hidden() { return fs }',
  4980. 'hidden()',
  4981. ].join('\n'));
  4982. fs.writeFileSync(path.join(tempDir, 'src/consumer.js'), 'hidden()');
  4983. fs.mkdirSync(path.join(tempDir, 'legacy'));
  4984. fs.writeFileSync(path.join(tempDir, 'legacy/global.js'), 'function hidden() { return 1 }');
  4985. cg = await CodeGraph.init(tempDir, { index: true });
  4986. cg.resolveReferences();
  4987. const hidden = cg.getNodesByKind('function').find((n) => n.name === 'hidden' && n.filePath === 'src/private.js');
  4988. expect(hidden).toBeDefined();
  4989. const callers = cg.getIncomingEdges(hidden!.id).filter((e) => e.kind === 'calls');
  4990. expect(callers.some((e) => cg.getNode(e.source)?.filePath === 'src/consumer.js')).toBe(false);
  4991. expect(callers.some((e) => cg.getNode(e.source)?.filePath === 'src/private.js')).toBe(true);
  4992. const consumer = cg.getNodesByKind('file').find((n) => n.filePath === 'src/consumer.js');
  4993. expect(cg.getOutgoingEdges(consumer!.id).filter((e) => e.kind === 'calls')).toEqual([]);
  4994. });
  4995. it('does not name-match a method call to another file\'s JSON value', async () => {
  4996. fs.writeFileSync(path.join(tempDir, 'data.json'), '{"content": "hello"}');
  4997. fs.writeFileSync(path.join(tempDir, 'data.js'), "const content = require('./data.json')\nmodule.exports = { content }\n");
  4998. fs.writeFileSync(path.join(tempDir, 'consumer.js'), 'export async function read(page) { return page.frame("main").content() }');
  4999. fs.writeFileSync(path.join(tempDir, 'use-data.js'), "import { content } from './data'\nconsole.log(content)\n");
  5000. fs.writeFileSync(path.join(tempDir, 'callback.js'), "const callback = require('./handler.js')\nmodule.exports = { callback }\n");
  5001. fs.writeFileSync(path.join(tempDir, 'call.js'), 'callback()');
  5002. cg = await CodeGraph.init(tempDir, { index: true });
  5003. cg.resolveReferences();
  5004. const content = cg.getNodesByKind('constant').find((n) => n.name === 'content');
  5005. expect(content).toBeDefined();
  5006. expect(cg.getIncomingEdges(content!.id).filter((e) => e.kind === 'calls')).toEqual([]);
  5007. expect(cg.getIncomingEdges(content!.id).some((e) => e.kind === 'imports')).toBe(true);
  5008. const callback = cg.getNodesByKind('constant').find((n) => n.name === 'callback');
  5009. expect(callback).toBeDefined();
  5010. expect(cg.getIncomingEdges(callback!.id).some((e) => e.kind === 'calls')).toBe(true);
  5011. });
  5012. it('keeps a local file dependency import when a closer private name collides', async () => {
  5013. fs.writeFileSync(path.join(tempDir, 'package.json'), JSON.stringify({ dependencies: { 'local-dep': 'file:./dep' } }));
  5014. fs.mkdirSync(path.join(tempDir, 'dep'));
  5015. fs.mkdirSync(path.join(tempDir, 'src'));
  5016. fs.writeFileSync(path.join(tempDir, 'dep/package.json'), JSON.stringify({ name: 'local-dep', main: 'index.js' }));
  5017. fs.writeFileSync(path.join(tempDir, 'dep/index.js'), "export const msg = 'local'\n");
  5018. fs.writeFileSync(path.join(tempDir, 'src/private.js'), "import fs from 'node:fs'\nconst msg = 'private'\n");
  5019. fs.writeFileSync(path.join(tempDir, 'src/consumer.js'), "import { msg } from 'local-dep'\nconsole.log(msg)\n");
  5020. cg = await CodeGraph.init(tempDir, { index: true });
  5021. cg.resolveReferences();
  5022. const msg = cg.getNodesByKind('constant').find((n) => n.name === 'msg' && n.filePath === 'dep/index.js');
  5023. expect(msg).toBeDefined();
  5024. expect(cg.getIncomingEdges(msg!.id).some((e) => e.kind === 'imports')).toBe(true);
  5025. });
  5026. it('preserves executable CommonJS exports inside nested template interpolations', async () => {
  5027. fs.writeFileSync(path.join(tempDir, 'cjs.js'), [
  5028. "import fs from 'node:fs'",
  5029. 'function helper() { return fs }',
  5030. 'const text = `outer ${`inner ${module.exports = { helper }}`}`',
  5031. ].join('\n'));
  5032. fs.writeFileSync(path.join(tempDir, 'consumer.js'), 'helper()');
  5033. cg = await CodeGraph.init(tempDir, { index: true });
  5034. cg.resolveReferences();
  5035. const helper = cg.getNodesByKind('function').find((n) => n.name === 'helper');
  5036. expect(helper).toBeDefined();
  5037. expect(cg.getIncomingEdges(helper!.id).some((e) =>
  5038. e.kind === 'calls' && cg.getNode(e.source)?.filePath === 'consumer.js')).toBe(true);
  5039. });
  5040. it.each(['export function visible() { return fs }', 'function visible() { return fs }\nexport { visible }'])('preserves real exports after a regex containing a backtick: %s', async (declaration) => {
  5041. fs.writeFileSync(path.join(tempDir, 'exported.js'), "import fs from 'node:fs'\nconst re = /`/\nif (fs) /`/.test('text')\nelse /`/.test('other')\nconst make = () => /`/\n" + declaration + '\n');
  5042. fs.writeFileSync(path.join(tempDir, 'consumer.js'), 'visible()');
  5043. cg = await CodeGraph.init(tempDir, { index: true });
  5044. cg.resolveReferences();
  5045. const visible = cg.getNodesByKind('function').find((n) => n.name === 'visible');
  5046. expect(visible).toBeDefined();
  5047. expect(cg.getIncomingEdges(visible!.id).some((e) => e.kind === 'calls')).toBe(true);
  5048. });
  5049. // On vitejs/vite, every `import { defineConfig } from 'vite'` across the
  5050. // playground resolved onto `playground/ssr-html/test-stacktrace.js::vite`
  5051. // — `const vite = await createServer(…)` at module scope in a file with
  5052. // zero exports — because exact-match commits whenever one candidate
  5053. // survives, and nothing asked whether an import could reach it. Only
  5054. // `sealed.js` may be filtered; every other file here is a class that must
  5055. // NOT be — a classic script (a top-level binding really is a reachable
  5056. // global), a CommonJS module, one exporting through `exports["x"]`, an ESM
  5057. // file whose export is a later `export { … }` statement (which leaves
  5058. // `isExported` false on the declaration's node), and one contributing a
  5059. // name through `declare global` while exporting nothing of its own.
  5060. let tmpDir: string;
  5061. let cg: CodeGraph;
  5062. afterEach(() => {
  5063. cg?.close();
  5064. if (tmpDir) fs.rmSync(tmpDir, { recursive: true, force: true });
  5065. });
  5066. it('drops them as cross-file candidates, and keeps scripts, CJS and later exports', async () => {
  5067. tmpDir = fs.mkdtempSync(path.join(os.tmpdir(), 'codegraph-1719-'));
  5068. fs.writeFileSync(
  5069. path.join(tmpDir, 'sealed.js'),
  5070. `import fsp from 'node:fs/promises'
  5071. function widget() {
  5072. return fsp
  5073. }
  5074. widget()
  5075. `
  5076. );
  5077. fs.writeFileSync(
  5078. path.join(tmpDir, 'script.js'),
  5079. `function gadget() {
  5080. return 1
  5081. }
  5082. `
  5083. );
  5084. fs.writeFileSync(
  5085. path.join(tmpDir, 'cjs.js'),
  5086. `import osp from 'node:os'
  5087. function helper() {
  5088. return osp
  5089. }
  5090. module.exports = { helper }
  5091. `
  5092. );
  5093. fs.writeFileSync(
  5094. path.join(tmpDir, 'later.js'),
  5095. `import pathp from 'node:path'
  5096. function parser() {
  5097. return pathp
  5098. }
  5099. export { parser }
  5100. `
  5101. );
  5102. // `exports["x"]` is a CommonJS export too, and a file declaring globals
  5103. // offers them to every other file whether or not it exports anything of
  5104. // its own. Both would read as sealed on a test that looked only for
  5105. // `export …`, `module.exports` and `exports.x`.
  5106. fs.writeFileSync(
  5107. path.join(tmpDir, 'bracket.js'),
  5108. `import urlp from 'node:url'
  5109. function bracketed() {
  5110. return urlp
  5111. }
  5112. exports["bracketed"] = bracketed
  5113. `
  5114. );
  5115. // A module with imports and no export of its own still contributes every
  5116. // name in `declare global` to every other file. `plain.ts` is the control
  5117. // that makes the assertion mean something: it is the same "import, no
  5118. // export" shape holding the same kind of declaration, so the pair differs
  5119. // only by the `declare global`, and an assertion on StrayFace alone would
  5120. // pass whatever the guard did.
  5121. fs.writeFileSync(
  5122. path.join(tmpDir, 'ambient.ts'),
  5123. `import './later'
  5124. declare global {
  5125. interface StrayFace {
  5126. a: number
  5127. }
  5128. }
  5129. `
  5130. );
  5131. fs.writeFileSync(
  5132. path.join(tmpDir, 'plain.ts'),
  5133. `import './later'
  5134. interface HiddenFace {
  5135. a: number
  5136. }
  5137. const unused: HiddenFace = { a: 1 }
  5138. `
  5139. );
  5140. // A type annotation is the reference here, so this consumer must be .ts.
  5141. fs.writeFileSync(
  5142. path.join(tmpDir, 'consumer.ts'),
  5143. `const face: StrayFace = { a: 1 }
  5144. const hidden: HiddenFace = { a: 2 }
  5145. export function use(): number {
  5146. return face.a + hidden.a
  5147. }
  5148. `
  5149. );
  5150. // Nothing here is bound by an import, so every name is a free reference
  5151. // that falls through to exact name matching — the path this rule sits on.
  5152. // A bare import would reach that path too, but a bare specifier names a
  5153. // package outside the graph, so no project node is the right target for
  5154. // it and such a fixture would assert a resolution nothing should make.
  5155. fs.writeFileSync(
  5156. path.join(tmpDir, 'consumer.js'),
  5157. `widget()
  5158. gadget()
  5159. helper()
  5160. parser()
  5161. bracketed()
  5162. `
  5163. );
  5164. cg = await CodeGraph.init(tmpDir, { index: true });
  5165. cg.resolveReferences();
  5166. // Incoming edges rather than callers, so the interfaces are asked the
  5167. // same question as the functions: a type annotation is a reference, not
  5168. // a call.
  5169. const reachedFrom = (consumer: string, name: string): boolean => {
  5170. const target = cg
  5171. .searchNodes(name, { limit: 10 })
  5172. .find((r) => r.node.name === name && r.node.filePath !== consumer);
  5173. expect(target, `no node named ${name}`).toBeDefined();
  5174. return cg
  5175. .getIncomingEdges(target!.node.id)
  5176. .some((e) => cg.getNode(e.source)?.filePath === consumer);
  5177. };
  5178. expect(reachedFrom('consumer.js', 'widget')).toBe(false);
  5179. expect(reachedFrom('consumer.js', 'gadget')).toBe(true);
  5180. expect(reachedFrom('consumer.js', 'helper')).toBe(true);
  5181. expect(reachedFrom('consumer.js', 'parser')).toBe(true);
  5182. expect(reachedFrom('consumer.js', 'bracketed')).toBe(true);
  5183. expect(reachedFrom('consumer.ts', 'StrayFace')).toBe(true);
  5184. expect(reachedFrom('consumer.ts', 'HiddenFace')).toBe(false);
  5185. }, 30000);
  5186. });
  5187. });