resolution.test.ts 232 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670671672673674675676677678679680681682683684685686687688689690691692693694695696697698699700701702703704705706707708709710711712713714715716717718719720721722723724725726727728729730731732733734735736737738739740741742743744745746747748749750751752753754755756757758759760761762763764765766767768769770771772773774775776777778779780781782783784785786787788789790791792793794795796797798799800801802803804805806807808809810811812813814815816817818819820821822823824825826827828829830831832833834835836837838839840841842843844845846847848849850851852853854855856857858859860861862863864865866867868869870871872873874875876877878879880881882883884885886887888889890891892893894895896897898899900901902903904905906907908909910911912913914915916917918919920921922923924925926927928929930931932933934935936937938939940941942943944945946947948949950951952953954955956957958959960961962963964965966967968969970971972973974975976977978979980981982983984985986987988989990991992993994995996997998999100010011002100310041005100610071008100910101011101210131014101510161017101810191020102110221023102410251026102710281029103010311032103310341035103610371038103910401041104210431044104510461047104810491050105110521053105410551056105710581059106010611062106310641065106610671068106910701071107210731074107510761077107810791080108110821083108410851086108710881089109010911092109310941095109610971098109911001101110211031104110511061107110811091110111111121113111411151116111711181119112011211122112311241125112611271128112911301131113211331134113511361137113811391140114111421143114411451146114711481149115011511152115311541155115611571158115911601161116211631164116511661167116811691170117111721173117411751176117711781179118011811182118311841185118611871188118911901191119211931194119511961197119811991200120112021203120412051206120712081209121012111212121312141215121612171218121912201221122212231224122512261227122812291230123112321233123412351236123712381239124012411242124312441245124612471248124912501251125212531254125512561257125812591260126112621263126412651266126712681269127012711272127312741275127612771278127912801281128212831284128512861287128812891290129112921293129412951296129712981299130013011302130313041305130613071308130913101311131213131314131513161317131813191320132113221323132413251326132713281329133013311332133313341335133613371338133913401341134213431344134513461347134813491350135113521353135413551356135713581359136013611362136313641365136613671368136913701371137213731374137513761377137813791380138113821383138413851386138713881389139013911392139313941395139613971398139914001401140214031404140514061407140814091410141114121413141414151416141714181419142014211422142314241425142614271428142914301431143214331434143514361437143814391440144114421443144414451446144714481449145014511452145314541455145614571458145914601461146214631464146514661467146814691470147114721473147414751476147714781479148014811482148314841485148614871488148914901491149214931494149514961497149814991500150115021503150415051506150715081509151015111512151315141515151615171518151915201521152215231524152515261527152815291530153115321533153415351536153715381539154015411542154315441545154615471548154915501551155215531554155515561557155815591560156115621563156415651566156715681569157015711572157315741575157615771578157915801581158215831584158515861587158815891590159115921593159415951596159715981599160016011602160316041605160616071608160916101611161216131614161516161617161816191620162116221623162416251626162716281629163016311632163316341635163616371638163916401641164216431644164516461647164816491650165116521653165416551656165716581659166016611662166316641665166616671668166916701671167216731674167516761677167816791680168116821683168416851686168716881689169016911692169316941695169616971698169917001701170217031704170517061707170817091710171117121713171417151716171717181719172017211722172317241725172617271728172917301731173217331734173517361737173817391740174117421743174417451746174717481749175017511752175317541755175617571758175917601761176217631764176517661767176817691770177117721773177417751776177717781779178017811782178317841785178617871788178917901791179217931794179517961797179817991800180118021803180418051806180718081809181018111812181318141815181618171818181918201821182218231824182518261827182818291830183118321833183418351836183718381839184018411842184318441845184618471848184918501851185218531854185518561857185818591860186118621863186418651866186718681869187018711872187318741875187618771878187918801881188218831884188518861887188818891890189118921893189418951896189718981899190019011902190319041905190619071908190919101911191219131914191519161917191819191920192119221923192419251926192719281929193019311932193319341935193619371938193919401941194219431944194519461947194819491950195119521953195419551956195719581959196019611962196319641965196619671968196919701971197219731974197519761977197819791980198119821983198419851986198719881989199019911992199319941995199619971998199920002001200220032004200520062007200820092010201120122013201420152016201720182019202020212022202320242025202620272028202920302031203220332034203520362037203820392040204120422043204420452046204720482049205020512052205320542055205620572058205920602061206220632064206520662067206820692070207120722073207420752076207720782079208020812082208320842085208620872088208920902091209220932094209520962097209820992100210121022103210421052106210721082109211021112112211321142115211621172118211921202121212221232124212521262127212821292130213121322133213421352136213721382139214021412142214321442145214621472148214921502151215221532154215521562157215821592160216121622163216421652166216721682169217021712172217321742175217621772178217921802181218221832184218521862187218821892190219121922193219421952196219721982199220022012202220322042205220622072208220922102211221222132214221522162217221822192220222122222223222422252226222722282229223022312232223322342235223622372238223922402241224222432244224522462247224822492250225122522253225422552256225722582259226022612262226322642265226622672268226922702271227222732274227522762277227822792280228122822283228422852286228722882289229022912292229322942295229622972298229923002301230223032304230523062307230823092310231123122313231423152316231723182319232023212322232323242325232623272328232923302331233223332334233523362337233823392340234123422343234423452346234723482349235023512352235323542355235623572358235923602361236223632364236523662367236823692370237123722373237423752376237723782379238023812382238323842385238623872388238923902391239223932394239523962397239823992400240124022403240424052406240724082409241024112412241324142415241624172418241924202421242224232424242524262427242824292430243124322433243424352436243724382439244024412442244324442445244624472448244924502451245224532454245524562457245824592460246124622463246424652466246724682469247024712472247324742475247624772478247924802481248224832484248524862487248824892490249124922493249424952496249724982499250025012502250325042505250625072508250925102511251225132514251525162517251825192520252125222523252425252526252725282529253025312532253325342535253625372538253925402541254225432544254525462547254825492550255125522553255425552556255725582559256025612562256325642565256625672568256925702571257225732574257525762577257825792580258125822583258425852586258725882589259025912592259325942595259625972598259926002601260226032604260526062607260826092610261126122613261426152616261726182619262026212622262326242625262626272628262926302631263226332634263526362637263826392640264126422643264426452646264726482649265026512652265326542655265626572658265926602661266226632664266526662667266826692670267126722673267426752676267726782679268026812682268326842685268626872688268926902691269226932694269526962697269826992700270127022703270427052706270727082709271027112712271327142715271627172718271927202721272227232724272527262727272827292730273127322733273427352736273727382739274027412742274327442745274627472748274927502751275227532754275527562757275827592760276127622763276427652766276727682769277027712772277327742775277627772778277927802781278227832784278527862787278827892790279127922793279427952796279727982799280028012802280328042805280628072808280928102811281228132814281528162817281828192820282128222823282428252826282728282829283028312832283328342835283628372838283928402841284228432844284528462847284828492850285128522853285428552856285728582859286028612862286328642865286628672868286928702871287228732874287528762877287828792880288128822883288428852886288728882889289028912892289328942895289628972898289929002901290229032904290529062907290829092910291129122913291429152916291729182919292029212922292329242925292629272928292929302931293229332934293529362937293829392940294129422943294429452946294729482949295029512952295329542955295629572958295929602961296229632964296529662967296829692970297129722973297429752976297729782979298029812982298329842985298629872988298929902991299229932994299529962997299829993000300130023003300430053006300730083009301030113012301330143015301630173018301930203021302230233024302530263027302830293030303130323033303430353036303730383039304030413042304330443045304630473048304930503051305230533054305530563057305830593060306130623063306430653066306730683069307030713072307330743075307630773078307930803081308230833084308530863087308830893090309130923093309430953096309730983099310031013102310331043105310631073108310931103111311231133114311531163117311831193120312131223123312431253126312731283129313031313132313331343135313631373138313931403141314231433144314531463147314831493150315131523153315431553156315731583159316031613162316331643165316631673168316931703171317231733174317531763177317831793180318131823183318431853186318731883189319031913192319331943195319631973198319932003201320232033204320532063207320832093210321132123213321432153216321732183219322032213222322332243225322632273228322932303231323232333234323532363237323832393240324132423243324432453246324732483249325032513252325332543255325632573258325932603261326232633264326532663267326832693270327132723273327432753276327732783279328032813282328332843285328632873288328932903291329232933294329532963297329832993300330133023303330433053306330733083309331033113312331333143315331633173318331933203321332233233324332533263327332833293330333133323333333433353336333733383339334033413342334333443345334633473348334933503351335233533354335533563357335833593360336133623363336433653366336733683369337033713372337333743375337633773378337933803381338233833384338533863387338833893390339133923393339433953396339733983399340034013402340334043405340634073408340934103411341234133414341534163417341834193420342134223423342434253426342734283429343034313432343334343435343634373438343934403441344234433444344534463447344834493450345134523453345434553456345734583459346034613462346334643465346634673468346934703471347234733474347534763477347834793480348134823483348434853486348734883489349034913492349334943495349634973498349935003501350235033504350535063507350835093510351135123513351435153516351735183519352035213522352335243525352635273528352935303531353235333534353535363537353835393540354135423543354435453546354735483549355035513552355335543555355635573558355935603561356235633564356535663567356835693570357135723573357435753576357735783579358035813582358335843585358635873588358935903591359235933594359535963597359835993600360136023603360436053606360736083609361036113612361336143615361636173618361936203621362236233624362536263627362836293630363136323633363436353636363736383639364036413642364336443645364636473648364936503651365236533654365536563657365836593660366136623663366436653666366736683669367036713672367336743675367636773678367936803681368236833684368536863687368836893690369136923693369436953696369736983699370037013702370337043705370637073708370937103711371237133714371537163717371837193720372137223723372437253726372737283729373037313732373337343735373637373738373937403741374237433744374537463747374837493750375137523753375437553756375737583759376037613762376337643765376637673768376937703771377237733774377537763777377837793780378137823783378437853786378737883789379037913792379337943795379637973798379938003801380238033804380538063807380838093810381138123813381438153816381738183819382038213822382338243825382638273828382938303831383238333834383538363837383838393840384138423843384438453846384738483849385038513852385338543855385638573858385938603861386238633864386538663867386838693870387138723873387438753876387738783879388038813882388338843885388638873888388938903891389238933894389538963897389838993900390139023903390439053906390739083909391039113912391339143915391639173918391939203921392239233924392539263927392839293930393139323933393439353936393739383939394039413942394339443945394639473948394939503951395239533954395539563957395839593960396139623963396439653966396739683969397039713972397339743975397639773978397939803981398239833984398539863987398839893990399139923993399439953996399739983999400040014002400340044005400640074008400940104011401240134014401540164017401840194020402140224023402440254026402740284029403040314032403340344035403640374038403940404041404240434044404540464047404840494050405140524053405440554056405740584059406040614062406340644065406640674068406940704071407240734074407540764077407840794080408140824083408440854086408740884089409040914092409340944095409640974098409941004101410241034104410541064107410841094110411141124113411441154116411741184119412041214122412341244125412641274128412941304131413241334134413541364137413841394140414141424143414441454146414741484149415041514152415341544155415641574158415941604161416241634164416541664167416841694170417141724173417441754176417741784179418041814182418341844185418641874188418941904191419241934194419541964197419841994200420142024203420442054206420742084209421042114212421342144215421642174218421942204221422242234224422542264227422842294230423142324233423442354236423742384239424042414242424342444245424642474248424942504251425242534254425542564257425842594260426142624263426442654266426742684269427042714272427342744275427642774278427942804281428242834284428542864287428842894290429142924293429442954296429742984299430043014302430343044305430643074308430943104311431243134314431543164317431843194320432143224323432443254326432743284329433043314332433343344335433643374338433943404341434243434344434543464347434843494350435143524353435443554356435743584359436043614362436343644365436643674368436943704371437243734374437543764377437843794380438143824383438443854386438743884389439043914392439343944395439643974398439944004401440244034404440544064407440844094410441144124413441444154416441744184419442044214422442344244425442644274428442944304431443244334434443544364437443844394440444144424443444444454446444744484449445044514452445344544455445644574458445944604461446244634464446544664467446844694470447144724473447444754476447744784479448044814482448344844485448644874488448944904491449244934494449544964497449844994500450145024503450445054506450745084509451045114512451345144515451645174518451945204521452245234524452545264527452845294530453145324533453445354536453745384539454045414542454345444545454645474548454945504551455245534554455545564557455845594560456145624563456445654566456745684569457045714572457345744575457645774578457945804581458245834584458545864587458845894590459145924593459445954596459745984599460046014602460346044605460646074608460946104611461246134614461546164617461846194620462146224623462446254626462746284629463046314632463346344635463646374638463946404641464246434644464546464647464846494650465146524653465446554656465746584659466046614662466346644665466646674668466946704671467246734674467546764677467846794680468146824683468446854686468746884689469046914692469346944695469646974698469947004701470247034704470547064707470847094710471147124713471447154716471747184719472047214722472347244725472647274728472947304731473247334734473547364737473847394740474147424743474447454746474747484749475047514752475347544755475647574758475947604761476247634764476547664767476847694770477147724773477447754776477747784779478047814782478347844785478647874788478947904791479247934794479547964797479847994800480148024803480448054806480748084809481048114812481348144815481648174818481948204821482248234824482548264827482848294830483148324833483448354836483748384839484048414842484348444845484648474848484948504851485248534854485548564857485848594860486148624863486448654866486748684869487048714872487348744875487648774878487948804881488248834884488548864887488848894890489148924893489448954896489748984899490049014902490349044905490649074908490949104911491249134914491549164917491849194920492149224923492449254926492749284929493049314932493349344935493649374938493949404941494249434944494549464947494849494950495149524953495449554956495749584959496049614962496349644965496649674968496949704971497249734974497549764977497849794980498149824983498449854986498749884989499049914992499349944995499649974998499950005001500250035004500550065007500850095010501150125013501450155016501750185019502050215022502350245025502650275028502950305031503250335034503550365037503850395040504150425043504450455046504750485049505050515052505350545055505650575058505950605061506250635064506550665067506850695070507150725073507450755076507750785079508050815082508350845085508650875088508950905091509250935094509550965097509850995100510151025103510451055106510751085109511051115112511351145115511651175118511951205121512251235124512551265127512851295130513151325133513451355136513751385139514051415142514351445145514651475148514951505151515251535154515551565157515851595160516151625163516451655166516751685169517051715172517351745175517651775178517951805181518251835184518551865187518851895190519151925193519451955196519751985199520052015202520352045205520652075208520952105211521252135214521552165217521852195220522152225223522452255226522752285229523052315232523352345235523652375238523952405241524252435244524552465247524852495250525152525253525452555256525752585259526052615262526352645265526652675268526952705271527252735274527552765277527852795280528152825283528452855286528752885289529052915292529352945295529652975298529953005301530253035304530553065307530853095310531153125313531453155316531753185319532053215322532353245325532653275328532953305331533253335334533553365337533853395340534153425343534453455346534753485349535053515352535353545355535653575358535953605361536253635364536553665367536853695370537153725373537453755376537753785379538053815382538353845385538653875388538953905391539253935394539553965397539853995400540154025403540454055406540754085409541054115412541354145415541654175418541954205421542254235424542554265427542854295430543154325433543454355436543754385439544054415442544354445445544654475448544954505451545254535454545554565457545854595460546154625463546454655466546754685469547054715472547354745475547654775478547954805481548254835484548554865487548854895490549154925493549454955496549754985499550055015502550355045505550655075508550955105511551255135514551555165517551855195520552155225523552455255526552755285529553055315532553355345535553655375538553955405541554255435544554555465547554855495550555155525553555455555556555755585559556055615562556355645565556655675568556955705571557255735574557555765577557855795580558155825583558455855586558755885589559055915592559355945595559655975598559956005601560256035604560556065607560856095610561156125613561456155616561756185619562056215622562356245625562656275628562956305631563256335634563556365637563856395640564156425643564456455646564756485649565056515652565356545655565656575658565956605661566256635664566556665667566856695670567156725673567456755676567756785679568056815682568356845685568656875688568956905691569256935694569556965697569856995700570157025703570457055706570757085709571057115712571357145715571657175718571957205721572257235724572557265727572857295730573157325733573457355736573757385739574057415742574357445745574657475748574957505751575257535754575557565757575857595760576157625763576457655766576757685769577057715772577357745775577657775778577957805781578257835784578557865787578857895790579157925793579457955796579757985799580058015802580358045805580658075808580958105811581258135814581558165817581858195820582158225823582458255826582758285829583058315832583358345835583658375838583958405841584258435844584558465847584858495850585158525853585458555856585758585859586058615862586358645865586658675868586958705871587258735874
  1. /**
  2. * Resolution Module Tests
  3. *
  4. * Tests for Phase 3: Reference Resolution
  5. */
  6. import { describe, it, expect, beforeEach, afterEach } from 'vitest';
  7. import * as fs from 'fs';
  8. import * as path from 'path';
  9. import * as os from 'os';
  10. import { CodeGraph } from '../src';
  11. import { Node, UnresolvedReference } from '../src/types';
  12. import { ReferenceResolver, createResolver, ResolutionContext } from '../src/resolution';
  13. import { matchReference, resolveMethodOnType, matchByQualifiedName, matchByExactName, preferCallSiteFile, matchMethodCall } from '../src/resolution/name-matcher';
  14. import { resolveImportPath, extractImportMappings, resolveJvmImport, loadCppIncludeDirs, clearCppIncludeDirCache, isPhpIncludePathRef } from '../src/resolution/import-resolver';
  15. import type { UnresolvedRef } from '../src/resolution/types';
  16. import { detectFrameworks, getAllFrameworkResolvers } from '../src/resolution/frameworks';
  17. import { QueryBuilder } from '../src/db/queries';
  18. import { DatabaseConnection } from '../src/db';
  19. describe('Resolution Module', () => {
  20. let tempDir: string;
  21. let cg: CodeGraph;
  22. beforeEach(() => {
  23. // Create temp directory
  24. tempDir = fs.mkdtempSync(path.join(os.tmpdir(), 'codegraph-resolution-test-'));
  25. });
  26. afterEach(() => {
  27. // Clean up
  28. if (cg) {
  29. cg.destroy();
  30. } else if (fs.existsSync(tempDir)) {
  31. fs.rmSync(tempDir, { recursive: true });
  32. }
  33. });
  34. describe('Name Matcher', () => {
  35. it('should match exact name references', () => {
  36. // Create a mock context
  37. const mockNodes: Node[] = [
  38. {
  39. id: 'func:test.ts:myFunction:10',
  40. kind: 'function',
  41. name: 'myFunction',
  42. qualifiedName: 'test.ts::myFunction',
  43. filePath: 'test.ts',
  44. language: 'typescript',
  45. startLine: 10,
  46. endLine: 20,
  47. startColumn: 0,
  48. endColumn: 0,
  49. updatedAt: Date.now(),
  50. },
  51. ];
  52. const context: ResolutionContext = {
  53. getNodesInFile: () => mockNodes,
  54. getNodesByName: (name) => mockNodes.filter((n) => n.name === name),
  55. getNodesByQualifiedName: () => [],
  56. getNodesByKind: () => [],
  57. fileExists: () => true,
  58. readFile: () => null,
  59. getProjectRoot: () => '/test',
  60. getAllFiles: () => ['test.ts'],
  61. };
  62. const ref = {
  63. fromNodeId: 'caller:main.ts:caller:5',
  64. referenceName: 'myFunction',
  65. referenceKind: 'calls' as const,
  66. line: 5,
  67. column: 10,
  68. filePath: 'main.ts',
  69. language: 'typescript' as const,
  70. };
  71. const result = matchReference(ref, context);
  72. expect(result).not.toBeNull();
  73. expect(result?.targetNodeId).toBe('func:test.ts:myFunction:10');
  74. expect(result?.resolvedBy).toBe('exact-match');
  75. });
  76. it('should resolve Erlang -behaviour refs only to module namespaces', () => {
  77. // On emqx, `-behaviour(supervisor)` (OTP behaviour, not in the repo)
  78. // fell through to bare-name matching and resolved to a
  79. // `-define(supervisor, ...)` macro constant in an unrelated app.
  80. const macroConstant: Node = {
  81. id: 'constant:apps/bridge/src/impl.erl:supervisor:61',
  82. kind: 'constant',
  83. name: 'supervisor',
  84. qualifiedName: 'impl::supervisor',
  85. filePath: 'apps/bridge/src/impl.erl',
  86. language: 'erlang',
  87. startLine: 61,
  88. endLine: 61,
  89. startColumn: 0,
  90. endColumn: 0,
  91. updatedAt: Date.now(),
  92. };
  93. const behaviourModule: Node = {
  94. id: 'namespace:src/my_behaviour.erl:my_behaviour:1',
  95. kind: 'namespace',
  96. name: 'my_behaviour',
  97. qualifiedName: 'my_behaviour',
  98. filePath: 'src/my_behaviour.erl',
  99. language: 'erlang',
  100. startLine: 1,
  101. endLine: 1,
  102. startColumn: 0,
  103. endColumn: 0,
  104. updatedAt: Date.now(),
  105. };
  106. const nodes = [macroConstant, behaviourModule];
  107. const context: ResolutionContext = {
  108. getNodesInFile: () => [],
  109. getNodesByName: (name) => nodes.filter((n) => n.name === name),
  110. getNodesByQualifiedName: () => [],
  111. getNodesByKind: () => [],
  112. fileExists: () => false,
  113. readFile: () => null,
  114. getProjectRoot: () => '/test',
  115. getAllFiles: () => [],
  116. getNodesByLowerName: () => [],
  117. getImportMappings: () => [],
  118. };
  119. const mkRef = (name: string) => ({
  120. fromNodeId: 'namespace:src/worker.erl:worker:1',
  121. referenceName: name,
  122. referenceKind: 'implements' as const,
  123. line: 2,
  124. column: 0,
  125. filePath: 'src/worker.erl',
  126. language: 'erlang' as const,
  127. });
  128. // Out-of-repo behaviour whose name collides with a macro constant:
  129. // stays unresolved instead of linking the constant.
  130. expect(matchReference(mkRef('supervisor'), context)).toBeNull();
  131. // In-repo behaviour module resolves to its namespace.
  132. const resolved = matchReference(mkRef('my_behaviour'), context);
  133. expect(resolved?.targetNodeId).toBe(behaviourModule.id);
  134. // The same module-only rule covers refs emitted by .app/.app.src
  135. // resource files: on emqx, the `ssl` OTP app dependency resolved to a
  136. // test helper FUNCTION named ssl. A colliding non-module name stays
  137. // unresolved; a real umbrella-sibling module resolves.
  138. nodes.push({
  139. id: 'function:test/ldap_SUITE.erl:ssl:12',
  140. kind: 'function',
  141. name: 'ssl',
  142. qualifiedName: 'ldap_SUITE::ssl',
  143. filePath: 'test/ldap_SUITE.erl',
  144. language: 'erlang',
  145. startLine: 12,
  146. endLine: 14,
  147. startColumn: 0,
  148. endColumn: 0,
  149. updatedAt: Date.now(),
  150. });
  151. const appRef = (name: string) => ({
  152. fromNodeId: 'file:src/myapp.app.src',
  153. referenceName: name,
  154. referenceKind: 'imports' as const,
  155. line: 6,
  156. column: 0,
  157. filePath: 'src/myapp.app.src',
  158. language: 'erlang' as const,
  159. });
  160. expect(matchReference(appRef('ssl'), context)).toBeNull();
  161. expect(matchReference(appRef('my_behaviour'), context)?.targetNodeId).toBe(behaviourModule.id);
  162. });
  163. it('should prefer same-module candidates over cross-module matches', () => {
  164. // Simulates a Python monorepo where multiple apps define navigate()
  165. const candidateA: Node = {
  166. id: 'func:apps/app_a/src/server.py:navigate:10',
  167. kind: 'function',
  168. name: 'navigate',
  169. qualifiedName: 'apps/app_a/src/server.py::navigate',
  170. filePath: 'apps/app_a/src/server.py',
  171. language: 'python',
  172. startLine: 10,
  173. endLine: 20,
  174. startColumn: 0,
  175. endColumn: 0,
  176. updatedAt: Date.now(),
  177. };
  178. const candidateB: Node = {
  179. id: 'func:apps/app_b/src/server.py:navigate:15',
  180. kind: 'function',
  181. name: 'navigate',
  182. qualifiedName: 'apps/app_b/src/server.py::navigate',
  183. filePath: 'apps/app_b/src/server.py',
  184. language: 'python',
  185. startLine: 15,
  186. endLine: 25,
  187. startColumn: 0,
  188. endColumn: 0,
  189. updatedAt: Date.now(),
  190. };
  191. const context: ResolutionContext = {
  192. getNodesInFile: () => [],
  193. getNodesByName: (name) => name === 'navigate' ? [candidateA, candidateB] : [],
  194. getNodesByQualifiedName: () => [],
  195. getNodesByKind: () => [],
  196. fileExists: () => true,
  197. readFile: () => null,
  198. getProjectRoot: () => '/test',
  199. getAllFiles: () => [],
  200. getNodesByLowerName: () => [],
  201. getImportMappings: () => [],
  202. };
  203. // Reference from app_a should resolve to app_a's navigate, not app_b's
  204. const ref = {
  205. fromNodeId: 'func:apps/app_a/src/handler.py:handler:5',
  206. referenceName: 'navigate',
  207. referenceKind: 'calls' as const,
  208. line: 5,
  209. column: 10,
  210. filePath: 'apps/app_a/src/handler.py',
  211. language: 'python' as const,
  212. };
  213. const result = matchReference(ref, context);
  214. expect(result).not.toBeNull();
  215. expect(result?.targetNodeId).toBe('func:apps/app_a/src/server.py:navigate:10');
  216. expect(result?.resolvedBy).toBe('exact-match');
  217. });
  218. it('should lower confidence for cross-module exact matches', () => {
  219. // Only one candidate but in a completely different module
  220. const candidates: Node[] = [
  221. {
  222. id: 'func:apps/app_b/src/server.py:navigate:10',
  223. kind: 'function',
  224. name: 'navigate',
  225. qualifiedName: 'apps/app_b/src/server.py::navigate',
  226. filePath: 'apps/app_b/src/server.py',
  227. language: 'python',
  228. startLine: 10,
  229. endLine: 20,
  230. startColumn: 0,
  231. endColumn: 0,
  232. updatedAt: Date.now(),
  233. },
  234. {
  235. id: 'func:apps/app_c/src/server.py:navigate:10',
  236. kind: 'function',
  237. name: 'navigate',
  238. qualifiedName: 'apps/app_c/src/server.py::navigate',
  239. filePath: 'apps/app_c/src/server.py',
  240. language: 'python',
  241. startLine: 10,
  242. endLine: 20,
  243. startColumn: 0,
  244. endColumn: 0,
  245. updatedAt: Date.now(),
  246. },
  247. ];
  248. const context: ResolutionContext = {
  249. getNodesInFile: () => [],
  250. getNodesByName: (name) => name === 'navigate' ? candidates : [],
  251. getNodesByQualifiedName: () => [],
  252. getNodesByKind: () => [],
  253. fileExists: () => true,
  254. readFile: () => null,
  255. getProjectRoot: () => '/test',
  256. getAllFiles: () => [],
  257. getNodesByLowerName: () => [],
  258. getImportMappings: () => [],
  259. };
  260. // Reference from app_a — neither candidate is in the same module
  261. const ref = {
  262. fromNodeId: 'func:apps/app_a/src/handler.py:handler:5',
  263. referenceName: 'navigate',
  264. referenceKind: 'calls' as const,
  265. line: 5,
  266. column: 10,
  267. filePath: 'apps/app_a/src/handler.py',
  268. language: 'python' as const,
  269. };
  270. const result = matchReference(ref, context);
  271. // Should still resolve but with low confidence
  272. expect(result).not.toBeNull();
  273. expect(result?.confidence).toBeLessThanOrEqual(0.4);
  274. });
  275. it('should match qualified name references', () => {
  276. const mockClassNode: Node = {
  277. id: 'class:user.ts:User:5',
  278. kind: 'class',
  279. name: 'User',
  280. qualifiedName: 'user.ts::User',
  281. filePath: 'user.ts',
  282. language: 'typescript',
  283. startLine: 5,
  284. endLine: 30,
  285. startColumn: 0,
  286. endColumn: 0,
  287. updatedAt: Date.now(),
  288. };
  289. const mockMethodNode: Node = {
  290. id: 'method:user.ts:User.save:15',
  291. kind: 'method',
  292. name: 'save',
  293. qualifiedName: 'user.ts::User::save',
  294. filePath: 'user.ts',
  295. language: 'typescript',
  296. startLine: 15,
  297. endLine: 25,
  298. startColumn: 0,
  299. endColumn: 0,
  300. updatedAt: Date.now(),
  301. };
  302. const context: ResolutionContext = {
  303. getNodesInFile: (fp) => fp === 'user.ts' ? [mockClassNode, mockMethodNode] : [],
  304. getNodesByName: (name) => {
  305. if (name === 'User') return [mockClassNode];
  306. if (name === 'save') return [mockMethodNode];
  307. return [];
  308. },
  309. getNodesByQualifiedName: (qn) => {
  310. if (qn === 'user.ts::User::save') return [mockMethodNode];
  311. return [];
  312. },
  313. getNodesByKind: () => [],
  314. fileExists: () => true,
  315. readFile: () => null,
  316. getProjectRoot: () => '/test',
  317. getAllFiles: () => ['user.ts'],
  318. };
  319. const ref = {
  320. fromNodeId: 'caller:main.ts:main:5',
  321. referenceName: 'User.save',
  322. referenceKind: 'calls' as const,
  323. line: 5,
  324. column: 10,
  325. filePath: 'main.ts',
  326. language: 'typescript' as const,
  327. };
  328. const result = matchReference(ref, context);
  329. expect(result).not.toBeNull();
  330. expect(result?.targetNodeId).toBe('method:user.ts:User.save:15');
  331. });
  332. });
  333. describe('Ubiquitous-name ceiling (#999)', () => {
  334. // A vendored theme/SDK re-declares the same method name across thousands of
  335. // files (Metronic's `init`/`update`/… on every widget). The fuzzy strategies
  336. // used to score every same-named candidate per ref — O(K) per ref, O(K²)
  337. // total — which pinned a core for 15-28 min at "Resolving refs … 94%". Above
  338. // the ceiling they must DECLINE instead, since no proximity/word-overlap
  339. // score can pick the one true target among thousands anyway.
  340. const CEILING = 500;
  341. // A spy context: counts how many nodes the strategy actually inspects, so we
  342. // can assert the cap short-circuits BEFORE the O(K) scoring (not just that it
  343. // returns null).
  344. const makeManyMethods = (n: number, name: string): Node[] =>
  345. Array.from({ length: n }, (_, i) => ({
  346. id: `method:widget${i}.js:Widget${i}.${name}:1`,
  347. kind: 'method' as const,
  348. name,
  349. qualifiedName: `widget${i}.js::Widget${i}::${name}`,
  350. filePath: `static/theme/widget${i}.js`,
  351. language: 'javascript' as const,
  352. startLine: 1,
  353. endLine: 5,
  354. startColumn: 0,
  355. endColumn: 0,
  356. updatedAt: Date.now(),
  357. }));
  358. const spyContext = (nodes: Node[]): { ctx: ResolutionContext; lookups: () => number } => {
  359. let scanned = 0;
  360. const ctx: ResolutionContext = {
  361. getNodesInFile: () => [],
  362. getNodesByName: (name) => {
  363. const hit = nodes.filter((n) => n.name === name);
  364. scanned += hit.length;
  365. return hit;
  366. },
  367. getNodesByQualifiedName: () => [],
  368. getNodesByKind: () => [],
  369. fileExists: () => true,
  370. readFile: () => null,
  371. getProjectRoot: () => '/test',
  372. getAllFiles: () => [],
  373. getNodesByLowerName: () => [],
  374. getImportMappings: () => [],
  375. };
  376. return { ctx, lookups: () => scanned };
  377. };
  378. it('declines a method call (`obj.init`) above the ceiling instead of scoring K candidates', () => {
  379. const { ctx } = spyContext(makeManyMethods(CEILING + 1, 'init'));
  380. const ref = {
  381. fromNodeId: 'method:caller.js:caller:1',
  382. referenceName: 'widget.init',
  383. referenceKind: 'calls' as const,
  384. line: 2,
  385. column: 4,
  386. filePath: 'static/theme/caller.js',
  387. language: 'javascript' as const,
  388. };
  389. expect(matchReference(ref, ctx)).toBeNull();
  390. });
  391. it('declines a bare exact-name ref above the ceiling', () => {
  392. const { ctx } = spyContext(makeManyMethods(CEILING + 1, 'render'));
  393. const ref = {
  394. fromNodeId: 'method:caller.js:caller:1',
  395. referenceName: 'render',
  396. referenceKind: 'calls' as const,
  397. line: 2,
  398. column: 4,
  399. filePath: 'static/theme/caller.js',
  400. language: 'javascript' as const,
  401. };
  402. expect(matchReference(ref, ctx)).toBeNull();
  403. });
  404. it('still resolves a SAME-FILE definition when one exists (precise path unaffected)', () => {
  405. // Strategy 1 (class-name) and same-file matching are precise — a ubiquitous
  406. // name with an unambiguous local target still resolves.
  407. const nodes = makeManyMethods(CEILING + 1, 'init');
  408. const local: Node = {
  409. id: 'class:static/theme/caller.js:Widgetly:1',
  410. kind: 'class',
  411. name: 'Widgetly',
  412. qualifiedName: 'static/theme/caller.js::Widgetly',
  413. filePath: 'static/theme/caller.js',
  414. language: 'javascript',
  415. startLine: 1, endLine: 9, startColumn: 0, endColumn: 0, updatedAt: Date.now(),
  416. };
  417. const localMethod: Node = {
  418. id: 'method:static/theme/caller.js:Widgetly.init:2',
  419. kind: 'method',
  420. name: 'init',
  421. qualifiedName: 'static/theme/caller.js::Widgetly::init',
  422. filePath: 'static/theme/caller.js',
  423. language: 'javascript',
  424. startLine: 2, endLine: 4, startColumn: 0, endColumn: 0, updatedAt: Date.now(),
  425. };
  426. const all = [...nodes, local, localMethod];
  427. const ctx: ResolutionContext = {
  428. getNodesInFile: (fp) => all.filter((n) => n.filePath === fp),
  429. getNodesByName: (name) => all.filter((n) => n.name === name),
  430. getNodesByQualifiedName: () => [],
  431. getNodesByKind: () => [],
  432. fileExists: () => true,
  433. readFile: () => null,
  434. getProjectRoot: () => '/test',
  435. getAllFiles: () => [],
  436. getNodesByLowerName: () => [],
  437. getImportMappings: () => [],
  438. };
  439. // `Widgetly.init` names the class explicitly → Strategy 1 resolves it.
  440. const ref = {
  441. fromNodeId: 'method:static/theme/caller.js:caller:6',
  442. referenceName: 'Widgetly.init',
  443. referenceKind: 'calls' as const,
  444. line: 6,
  445. column: 4,
  446. filePath: 'static/theme/caller.js',
  447. language: 'javascript' as const,
  448. };
  449. const result = matchReference(ref, ctx);
  450. expect(result?.targetNodeId).toBe('method:static/theme/caller.js:Widgetly.init:2');
  451. });
  452. it('still scores normally JUST below the ceiling (no behavior change for normal repos)', () => {
  453. // Real repos top out near ~40 same-named methods; this proves a sub-ceiling
  454. // collision still resolves via proximity, so the cap is invisible to them.
  455. const nodes = makeManyMethods(CEILING - 1, 'update');
  456. // Make ONE candidate share the caller's directory so proximity picks it.
  457. nodes[0] = {
  458. ...nodes[0]!,
  459. id: 'method:static/theme/app/Widget0.update:1',
  460. qualifiedName: 'static/theme/app/widget.js::Widget0::update',
  461. filePath: 'static/theme/app/widget.js',
  462. };
  463. const ctx: ResolutionContext = {
  464. getNodesInFile: () => [],
  465. getNodesByName: (name) => nodes.filter((n) => n.name === name),
  466. getNodesByQualifiedName: () => [],
  467. getNodesByKind: () => [],
  468. fileExists: () => true,
  469. readFile: () => null,
  470. getProjectRoot: () => '/test',
  471. getAllFiles: () => [],
  472. getNodesByLowerName: () => [],
  473. getImportMappings: () => [],
  474. };
  475. const ref = {
  476. fromNodeId: 'method:static/theme/app/caller.js:caller:1',
  477. referenceName: 'update',
  478. referenceKind: 'calls' as const,
  479. line: 2,
  480. column: 4,
  481. filePath: 'static/theme/app/caller.js',
  482. language: 'javascript' as const,
  483. };
  484. // Below the ceiling the fuzzy path runs and resolves SOMETHING (not capped).
  485. expect(matchReference(ref, ctx)).not.toBeNull();
  486. });
  487. });
  488. describe('Import Resolver', () => {
  489. it('should resolve relative import paths', () => {
  490. const context: ResolutionContext = {
  491. getNodesInFile: () => [],
  492. getNodesByName: () => [],
  493. getNodesByQualifiedName: () => [],
  494. getNodesByKind: () => [],
  495. fileExists: (p) => p === 'src/components/utils.ts' || p === 'src/components/utils/index.ts',
  496. readFile: () => null,
  497. getProjectRoot: () => '',
  498. getAllFiles: () => ['src/components/utils.ts', 'src/components/utils/index.ts'],
  499. };
  500. const result = resolveImportPath(
  501. './utils',
  502. 'src/components/Button.ts',
  503. 'typescript',
  504. context
  505. );
  506. expect(result).toBe('src/components/utils.ts');
  507. });
  508. it('should resolve parent directory imports', () => {
  509. const context: ResolutionContext = {
  510. getNodesInFile: () => [],
  511. getNodesByName: () => [],
  512. getNodesByQualifiedName: () => [],
  513. getNodesByKind: () => [],
  514. fileExists: (p) => p === 'src/helpers.ts' || p === 'src/helpers/index.ts',
  515. readFile: () => null,
  516. getProjectRoot: () => '',
  517. getAllFiles: () => ['src/helpers.ts', 'src/helpers/index.ts'],
  518. };
  519. const result = resolveImportPath(
  520. '../helpers',
  521. 'src/components/Button.ts',
  522. 'typescript',
  523. context
  524. );
  525. expect(result).toBe('src/helpers.ts');
  526. });
  527. it('should extract JS/TS import mappings', () => {
  528. const content = `
  529. import { foo } from './foo';
  530. import bar from '../bar';
  531. import * as utils from './utils';
  532. import { baz, qux } from './baz';
  533. `;
  534. const mappings = extractImportMappings(
  535. 'src/index.ts',
  536. content,
  537. 'typescript'
  538. );
  539. expect(mappings.length).toBeGreaterThan(0);
  540. expect(mappings.some((m) => m.localName === 'foo')).toBe(true);
  541. expect(mappings.some((m) => m.localName === 'bar')).toBe(true);
  542. });
  543. it('should extract Python import mappings', () => {
  544. const content = `
  545. from utils import helper
  546. from .models import User
  547. import os
  548. from ..services import auth_service
  549. `;
  550. const mappings = extractImportMappings(
  551. 'src/main.py',
  552. content,
  553. 'python'
  554. );
  555. expect(mappings.length).toBeGreaterThan(0);
  556. expect(mappings.some((m) => m.localName === 'helper')).toBe(true);
  557. expect(mappings.some((m) => m.localName === 'User')).toBe(true);
  558. });
  559. });
  560. describe('JVM FQN Import Resolution', () => {
  561. // Build a ResolutionContext stub whose getNodesByQualifiedName answers
  562. // from a fixed table — the only context method resolveJvmImport touches.
  563. const makeContext = (byQName: Record<string, Node[]>): ResolutionContext => ({
  564. getNodesInFile: () => [],
  565. getNodesByName: () => [],
  566. getNodesByQualifiedName: (q) => byQName[q] ?? [],
  567. getNodesByKind: () => [],
  568. fileExists: () => false,
  569. readFile: () => null,
  570. getProjectRoot: () => '',
  571. getAllFiles: () => [],
  572. });
  573. const node = (id: string, name: string, qualifiedName: string, kind: Node['kind'] = 'class', language: Node['language'] = 'kotlin'): Node => ({
  574. id, kind, name, qualifiedName,
  575. filePath: 'Models.kt', language,
  576. startLine: 1, endLine: 1, startColumn: 0, endColumn: 0,
  577. updatedAt: 0,
  578. });
  579. const importRef = (referenceName: string, language: Node['language'] = 'kotlin'): UnresolvedRef => ({
  580. fromNodeId: 'caller',
  581. referenceName,
  582. referenceKind: 'imports',
  583. line: 1, column: 0,
  584. filePath: 'Caller.kt',
  585. language,
  586. });
  587. it('resolves a Kotlin class import by FQN regardless of filename', () => {
  588. const target = node('n1', 'Bar', 'com.example.foo::Bar');
  589. const ctx = makeContext({ 'com.example.foo::Bar': [target] });
  590. const result = resolveJvmImport(importRef('com.example.foo.Bar'), ctx);
  591. expect(result?.targetNodeId).toBe('n1');
  592. expect(result?.resolvedBy).toBe('import');
  593. });
  594. it('resolves a Kotlin top-level function import by FQN', () => {
  595. const util = node('n2', 'util', 'com.example.foo::util', 'function');
  596. const ctx = makeContext({ 'com.example.foo::util': [util] });
  597. const result = resolveJvmImport(importRef('com.example.foo.util'), ctx);
  598. expect(result?.targetNodeId).toBe('n2');
  599. });
  600. it('resolves a Java import by FQN', () => {
  601. const target = node('n3', 'Bar', 'com.example.foo::Bar', 'class', 'java');
  602. const ctx = makeContext({ 'com.example.foo::Bar': [target] });
  603. const result = resolveJvmImport(importRef('com.example.foo.Bar', 'java'), ctx);
  604. expect(result?.targetNodeId).toBe('n3');
  605. });
  606. it('resolves cross-language: Kotlin importing a Java class', () => {
  607. // The Kotlin file declares `import com.example.JavaBar` — the target is
  608. // a Java class node. JVM interop means the resolver doesn't care about
  609. // the source language of the target, only that the FQN matches.
  610. const target = node('n4', 'JavaBar', 'com.example::JavaBar', 'class', 'java');
  611. const ctx = makeContext({ 'com.example::JavaBar': [target] });
  612. const result = resolveJvmImport(importRef('com.example.JavaBar'), ctx);
  613. expect(result?.targetNodeId).toBe('n4');
  614. });
  615. it('disambiguates a name collision across packages', () => {
  616. // Two classes named `Bar` in different packages. Each import resolves
  617. // to the one whose FQN matches — not to "whichever was found first".
  618. const barA = node('n5a', 'Bar', 'com.example.alpha::Bar');
  619. const barB = node('n5b', 'Bar', 'com.example.beta::Bar');
  620. const ctx = makeContext({
  621. 'com.example.alpha::Bar': [barA],
  622. 'com.example.beta::Bar': [barB],
  623. });
  624. expect(resolveJvmImport(importRef('com.example.alpha.Bar'), ctx)?.targetNodeId).toBe('n5a');
  625. expect(resolveJvmImport(importRef('com.example.beta.Bar'), ctx)?.targetNodeId).toBe('n5b');
  626. });
  627. it('returns null for wildcard imports', () => {
  628. const ctx = makeContext({});
  629. expect(resolveJvmImport(importRef('com.example.foo.*'), ctx)).toBeNull();
  630. });
  631. it('returns null for unqualified names', () => {
  632. // A single-segment name has no package; nothing to look up by FQN.
  633. const ctx = makeContext({ 'Bar': [node('n6', 'Bar', 'Bar')] });
  634. expect(resolveJvmImport(importRef('Bar'), ctx)).toBeNull();
  635. });
  636. it('returns null for non-JVM languages', () => {
  637. const target = node('n7', 'Bar', 'com.example::Bar');
  638. const ctx = makeContext({ 'com.example::Bar': [target] });
  639. expect(resolveJvmImport(importRef('com.example.Bar', 'typescript'), ctx)).toBeNull();
  640. });
  641. it('returns null for non-imports reference kinds', () => {
  642. // The resolver intentionally only acts on `imports` refs; ordinary
  643. // `calls`/`extends` refs fall through to the framework + name-matcher
  644. // strategies.
  645. const target = node('n8', 'Bar', 'com.example::Bar');
  646. const ctx = makeContext({ 'com.example::Bar': [target] });
  647. const ref: UnresolvedRef = {
  648. fromNodeId: 'caller', referenceName: 'com.example.Bar',
  649. referenceKind: 'calls', line: 1, column: 0,
  650. filePath: 'Caller.kt', language: 'kotlin',
  651. };
  652. expect(resolveJvmImport(ref, ctx)).toBeNull();
  653. });
  654. it('returns null when the FQN is not in the index', () => {
  655. const ctx = makeContext({});
  656. expect(resolveJvmImport(importRef('com.example.Unknown'), ctx)).toBeNull();
  657. });
  658. });
  659. describe('Framework Detection', () => {
  660. it('should detect React framework', () => {
  661. const context: ResolutionContext = {
  662. getNodesInFile: () => [],
  663. getNodesByName: () => [],
  664. getNodesByQualifiedName: () => [],
  665. getNodesByKind: () => [],
  666. fileExists: () => false,
  667. readFile: (p) => {
  668. if (p === 'package.json') {
  669. return JSON.stringify({
  670. dependencies: { react: '^18.0.0' },
  671. });
  672. }
  673. return null;
  674. },
  675. getProjectRoot: () => '/test',
  676. getAllFiles: () => ['package.json', 'src/App.tsx'],
  677. };
  678. const frameworks = detectFrameworks(context);
  679. expect(frameworks.some((f) => f.name === 'react')).toBe(true);
  680. });
  681. it('should detect Express framework', () => {
  682. const context: ResolutionContext = {
  683. getNodesInFile: () => [],
  684. getNodesByName: () => [],
  685. getNodesByQualifiedName: () => [],
  686. getNodesByKind: () => [],
  687. fileExists: () => false,
  688. readFile: (p) => {
  689. if (p === 'package.json') {
  690. return JSON.stringify({
  691. dependencies: { express: '^4.18.0' },
  692. });
  693. }
  694. return null;
  695. },
  696. getProjectRoot: () => '/test',
  697. getAllFiles: () => ['package.json', 'src/app.js'],
  698. };
  699. const frameworks = detectFrameworks(context);
  700. expect(frameworks.some((f) => f.name === 'express')).toBe(true);
  701. });
  702. it('should detect Laravel framework', () => {
  703. const context: ResolutionContext = {
  704. getNodesInFile: () => [],
  705. getNodesByName: () => [],
  706. getNodesByQualifiedName: () => [],
  707. getNodesByKind: () => [],
  708. fileExists: (p) => p === 'artisan',
  709. readFile: () => null,
  710. getProjectRoot: () => '/test',
  711. getAllFiles: () => ['artisan', 'app/Http/Kernel.php'],
  712. };
  713. const frameworks = detectFrameworks(context);
  714. expect(frameworks.some((f) => f.name === 'laravel')).toBe(true);
  715. });
  716. it('should return all framework resolvers', () => {
  717. const resolvers = getAllFrameworkResolvers();
  718. expect(resolvers.length).toBeGreaterThan(0);
  719. expect(resolvers.some((r) => r.name === 'react')).toBe(true);
  720. expect(resolvers.some((r) => r.name === 'express')).toBe(true);
  721. expect(resolvers.some((r) => r.name === 'laravel')).toBe(true);
  722. });
  723. });
  724. describe('React Framework Resolver', () => {
  725. it('should resolve React component references', () => {
  726. const mockNodes: Node[] = [
  727. {
  728. id: 'component:src/Button.tsx:Button:5',
  729. kind: 'component',
  730. name: 'Button',
  731. qualifiedName: 'src/Button.tsx::Button',
  732. filePath: 'src/Button.tsx',
  733. language: 'tsx',
  734. startLine: 5,
  735. endLine: 20,
  736. startColumn: 0,
  737. endColumn: 0,
  738. updatedAt: Date.now(),
  739. },
  740. ];
  741. const context: ResolutionContext = {
  742. getNodesInFile: (fp) => (fp === 'src/Button.tsx' ? mockNodes : []),
  743. getNodesByName: () => mockNodes,
  744. getNodesByQualifiedName: () => [],
  745. getNodesByKind: () => [],
  746. fileExists: () => false,
  747. readFile: (p) => {
  748. if (p === 'package.json') {
  749. return JSON.stringify({ dependencies: { react: '^18.0.0' } });
  750. }
  751. return null;
  752. },
  753. getProjectRoot: () => '/test',
  754. getAllFiles: () => ['package.json', 'src/Button.tsx', 'src/App.tsx'],
  755. };
  756. const frameworks = detectFrameworks(context);
  757. const reactResolver = frameworks.find((f) => f.name === 'react');
  758. expect(reactResolver).toBeDefined();
  759. const ref = {
  760. fromNodeId: 'component:src/App.tsx:App:1',
  761. referenceName: 'Button',
  762. referenceKind: 'renders' as const,
  763. line: 10,
  764. column: 5,
  765. filePath: 'src/App.tsx',
  766. // Refs extracted from .tsx files carry language 'tsx' — component
  767. // resolution is gated to JSX-capable refs (#764: PascalCase TYPE refs
  768. // from plain .ts files were resolving to arbitrary same-named classes).
  769. language: 'tsx' as const,
  770. };
  771. const result = reactResolver!.resolve(ref, context);
  772. expect(result).not.toBeNull();
  773. expect(result?.targetNodeId).toBe('component:src/Button.tsx:Button:5');
  774. // The same PascalCase name referenced from a plain .ts file is a TYPE
  775. // reference, not a component usage — component resolution must decline
  776. // and leave it to proximity-aware name matching (#764: a .ts GraphQL
  777. // types file's own `Account` alias was losing to an arbitrary same-named
  778. // class in another monorepo package).
  779. const tsRef = { ...ref, filePath: 'src/models.ts', language: 'typescript' as const };
  780. expect(reactResolver!.resolve(tsRef, context)).toBeNull();
  781. });
  782. it('should resolve custom hook references', () => {
  783. const mockNodes: Node[] = [
  784. {
  785. id: 'hook:src/hooks/useAuth.ts:useAuth:1',
  786. kind: 'function',
  787. name: 'useAuth',
  788. qualifiedName: 'src/hooks/useAuth.ts::useAuth',
  789. filePath: 'src/hooks/useAuth.ts',
  790. language: 'typescript',
  791. startLine: 1,
  792. endLine: 20,
  793. startColumn: 0,
  794. endColumn: 0,
  795. updatedAt: Date.now(),
  796. },
  797. ];
  798. const context: ResolutionContext = {
  799. getNodesInFile: (fp) => (fp.includes('useAuth') ? mockNodes : []),
  800. getNodesByName: () => mockNodes,
  801. getNodesByQualifiedName: () => [],
  802. getNodesByKind: () => [],
  803. fileExists: () => false,
  804. readFile: (p) => {
  805. if (p === 'package.json') {
  806. return JSON.stringify({ dependencies: { react: '^18.0.0' } });
  807. }
  808. return null;
  809. },
  810. getProjectRoot: () => '/test',
  811. getAllFiles: () => ['package.json', 'src/hooks/useAuth.ts'],
  812. };
  813. const frameworks = detectFrameworks(context);
  814. const reactResolver = frameworks.find((f) => f.name === 'react');
  815. const ref = {
  816. fromNodeId: 'component:src/App.tsx:App:1',
  817. referenceName: 'useAuth',
  818. referenceKind: 'calls' as const,
  819. line: 5,
  820. column: 10,
  821. filePath: 'src/App.tsx',
  822. language: 'typescript' as const,
  823. };
  824. const result = reactResolver!.resolve(ref, context);
  825. expect(result).not.toBeNull();
  826. expect(result?.targetNodeId).toBe('hook:src/hooks/useAuth.ts:useAuth:1');
  827. });
  828. });
  829. describe('Integration Tests', () => {
  830. it('should create resolver from CodeGraph instance', async () => {
  831. // Create a simple TypeScript project
  832. fs.writeFileSync(
  833. path.join(tempDir, 'package.json'),
  834. JSON.stringify({ name: 'test', dependencies: { react: '^18.0.0' } })
  835. );
  836. const srcDir = path.join(tempDir, 'src');
  837. fs.mkdirSync(srcDir);
  838. // Create utility file
  839. fs.writeFileSync(
  840. path.join(srcDir, 'utils.ts'),
  841. `export function formatDate(date: Date): string {
  842. return date.toISOString();
  843. }
  844. export function parseDate(str: string): Date {
  845. return new Date(str);
  846. }`
  847. );
  848. // Create main file that uses utils
  849. fs.writeFileSync(
  850. path.join(srcDir, 'main.ts'),
  851. `import { formatDate, parseDate } from './utils';
  852. function processDate(input: string): string {
  853. const date = parseDate(input);
  854. return formatDate(date);
  855. }`
  856. );
  857. // Initialize and index
  858. cg = await CodeGraph.init(tempDir, { index: true });
  859. // Check that resolver detected React framework
  860. const frameworks = cg.getDetectedFrameworks();
  861. expect(frameworks).toContain('react');
  862. // Get stats to verify indexing worked
  863. const stats = cg.getStats();
  864. expect(stats.fileCount).toBe(2);
  865. expect(stats.nodeCount).toBeGreaterThan(0);
  866. });
  867. it('should resolve references after indexing', async () => {
  868. // Create a project with references
  869. const srcDir = path.join(tempDir, 'src');
  870. fs.mkdirSync(srcDir, { recursive: true });
  871. fs.writeFileSync(
  872. path.join(srcDir, 'helper.ts'),
  873. `export function helperFunction(): void {
  874. console.log('helper');
  875. }`
  876. );
  877. fs.writeFileSync(
  878. path.join(srcDir, 'main.ts'),
  879. `import { helperFunction } from './helper';
  880. function main(): void {
  881. helperFunction();
  882. }`
  883. );
  884. cg = await CodeGraph.init(tempDir, { index: true });
  885. // Run reference resolution
  886. const result = cg.resolveReferences();
  887. // Should have attempted resolution
  888. expect(result.stats.total).toBeGreaterThanOrEqual(0);
  889. });
  890. it('promotes calls→instantiates when target resolves to a class (Python)', async () => {
  891. // Python has no `new` keyword — `Foo()` is the standard
  892. // instantiation syntax. Extraction can't tell that apart from
  893. // a function call without symbol info, so it emits a `calls`
  894. // ref. Resolution promotes it to `instantiates` once the
  895. // target is known to be a class.
  896. const srcDir = path.join(tempDir, 'src');
  897. fs.mkdirSync(srcDir, { recursive: true });
  898. fs.writeFileSync(
  899. path.join(srcDir, 'app.py'),
  900. `class UserService:
  901. def __init__(self):
  902. self.db = None
  903. def bootstrap():
  904. return UserService()
  905. `
  906. );
  907. cg = await CodeGraph.init(tempDir, { index: true });
  908. cg.resolveReferences();
  909. const bootstrap = cg
  910. .getNodesByKind('function')
  911. .find((n) => n.name === 'bootstrap');
  912. expect(bootstrap).toBeDefined();
  913. const outgoing = cg.getOutgoingEdges(bootstrap!.id);
  914. const instantiates = outgoing.find((e) => e.kind === 'instantiates');
  915. expect(instantiates).toBeDefined();
  916. // Same edge must NOT also appear as a `calls` edge — promotion
  917. // replaces the kind, doesn't duplicate.
  918. const callsToUserService = outgoing.filter(
  919. (e) => e.kind === 'calls' && e.target === instantiates!.target
  920. );
  921. expect(callsToUserService).toHaveLength(0);
  922. });
  923. it('promotes calls→instantiates when target resolves to a C++ union', async () => {
  924. // `Packet()` value-initializes the union. The extractor emits a calls
  925. // reference for that expression, so resolution must preserve the
  926. // class-like promotion that unions received when they were structs.
  927. fs.writeFileSync(
  928. path.join(tempDir, 'packet.cpp'),
  929. `union Packet { unsigned int raw; };
  930. void initialize() { Packet(); }
  931. `
  932. );
  933. cg = await CodeGraph.init(tempDir, { index: true });
  934. cg.resolveReferences();
  935. const packet = cg.getNodesByKind('union').find((n) => n.name === 'Packet');
  936. const initialize = cg.getNodesByKind('function').find((n) => n.name === 'initialize');
  937. expect(packet).toBeDefined();
  938. expect(initialize).toBeDefined();
  939. const outgoing = cg.getOutgoingEdges(initialize!.id);
  940. expect(outgoing.some((e) => e.kind === 'instantiates' && e.target === packet!.id)).toBe(true);
  941. expect(outgoing.some((e) => e.kind === 'calls' && e.target === packet!.id)).toBe(false);
  942. });
  943. it('resolves a static call through an imported C++ union to its member', async () => {
  944. fs.writeFileSync(
  945. path.join(tempDir, 'ops.hpp'),
  946. `union Ops {
  947. static int run() { return 1; }
  948. };
  949. `
  950. );
  951. fs.writeFileSync(
  952. path.join(tempDir, 'main.cpp'),
  953. `#include "ops.hpp"
  954. int invoke() { return Ops::run(); }
  955. `
  956. );
  957. cg = await CodeGraph.init(tempDir, { index: true });
  958. cg.resolveReferences();
  959. const invoke = cg.getNodesByKind('function').find((n) => n.name === 'invoke');
  960. const run = cg.getNodesByKind('method').find((n) => n.name === 'run');
  961. expect(invoke).toBeDefined();
  962. expect(run).toBeDefined();
  963. const outgoing = cg.getOutgoingEdges(invoke!.id);
  964. expect(outgoing.some((e) => e.kind === 'calls' && e.target === run!.id)).toBe(true);
  965. });
  966. it('bridges a Rust trait method to a union implementor (interface-impl)', async () => {
  967. // A Rust union can `impl Trait` exactly as a struct can. Trait-dispatch
  968. // synthesis enumerates concrete kinds explicitly, so a union implementor
  969. // only becomes a candidate if `union` is in that list. Making unions
  970. // first-class nodes is not enough on its own: without this, `Reg` has an
  971. // `implements` edge and is still silently dropped from the fan-out, so
  972. // "who implements this trait" answers wrongly rather than incompletely
  973. // — the struct beside it resolves and the union does not (#1515).
  974. fs.writeFileSync(
  975. path.join(tempDir, 'lib.rs'),
  976. `pub union Reg { pub raw: u32 }
  977. pub struct Ctl { pub n: u32 }
  978. pub trait Describe { fn describe(&self) -> String; }
  979. impl Describe for Reg { fn describe(&self) -> String { "reg".into() } }
  980. impl Describe for Ctl { fn describe(&self) -> String { "ctl".into() } }
  981. `
  982. );
  983. cg = await CodeGraph.init(tempDir, { index: true });
  984. const methods = cg.getNodesByKind('method');
  985. const traitMethod = methods.find((n) => n.qualifiedName === 'Describe::describe');
  986. const unionImpl = methods.find((n) => n.qualifiedName === 'Reg::describe');
  987. const structImpl = methods.find((n) => n.qualifiedName === 'Ctl::describe');
  988. expect(traitMethod, 'trait method should be in the graph').toBeDefined();
  989. expect(unionImpl, 'union impl method should be in the graph').toBeDefined();
  990. expect(structImpl, 'struct impl method should be in the graph').toBeDefined();
  991. const synth = cg
  992. .getOutgoingEdges(traitMethod!.id)
  993. .filter((e) => e.kind === 'calls' && e.provenance === 'heuristic');
  994. const targets = new Set(synth.map((e) => e.target));
  995. // The struct implementor bridged before unions were nodes at all; it is
  996. // the control that proves the synthesizer ran for this trait.
  997. expect(targets.has(structImpl!.id), 'struct implementor should bridge').toBe(true);
  998. expect(targets.has(unionImpl!.id), 'union implementor should bridge').toBe(true);
  999. const unionEdge = synth.find((e) => e.target === unionImpl!.id);
  1000. expect(
  1001. (unionEdge!.metadata as { synthesizedBy?: string } | undefined)?.synthesizedBy
  1002. ).toBe('interface-impl');
  1003. });
  1004. it('qualifies a generic impl by its type, so trait dispatch reaches it and no edge is invented from its body (#1588)', async () => {
  1005. // `impl<T> Source for BufSource<T>`: the implementing type parses as a
  1006. // generic_type, so the old positional receiver scan picked the TRAIT.
  1007. // The impl's `read` was recorded as `Source::read` — unaddressable as
  1008. // `BufSource::read` — and, carrying the trait's name, the interface-impl
  1009. // synthesizer treated its body (`{ 0 }`, no call at all) as a second
  1010. // declaration and gave it a dispatch edge to FileSource's implementation.
  1011. fs.writeFileSync(
  1012. path.join(tempDir, 'lib.rs'),
  1013. `pub trait Source {
  1014. fn read(&mut self) -> usize;
  1015. }
  1016. pub struct FileSource { pub n: usize }
  1017. impl Source for FileSource {
  1018. fn read(&mut self) -> usize { self.n }
  1019. }
  1020. pub struct BufSource<T> { pub inner: T }
  1021. impl<T> Source for BufSource<T> {
  1022. fn read(&mut self) -> usize { 0 }
  1023. }
  1024. `
  1025. );
  1026. cg = await CodeGraph.init(tempDir, { index: true });
  1027. const methods = cg.getNodesByKind('method');
  1028. const traitDecls = methods.filter((n) => n.qualifiedName === 'Source::read');
  1029. expect(traitDecls, 'only the declaration carries the trait-qualified name').toHaveLength(1);
  1030. const traitMethod = traitDecls[0]!;
  1031. expect(traitMethod.startLine).toBe(2);
  1032. const fileImpl = methods.find((n) => n.qualifiedName === 'FileSource::read');
  1033. const bufImpl = methods.find((n) => n.qualifiedName === 'BufSource::read');
  1034. expect(fileImpl).toBeDefined();
  1035. expect(bufImpl, 'the generic impl is addressable by its type').toBeDefined();
  1036. const synth = (id: string) =>
  1037. cg.getOutgoingEdges(id).filter((e) => e.kind === 'calls' && e.provenance === 'heuristic');
  1038. // Dispatch fans out from the declaration to BOTH implementations…
  1039. const fromTrait = synth(traitMethod.id);
  1040. expect(new Set(fromTrait.map((e) => e.target))).toEqual(new Set([fileImpl!.id, bufImpl!.id]));
  1041. for (const e of fromTrait) {
  1042. expect(
  1043. (e.metadata as { synthesizedBy?: string } | undefined)?.synthesizedBy
  1044. ).toBe('interface-impl');
  1045. expect(e.line, 'registered at the declaration, never at an impl body').toBe(2);
  1046. }
  1047. // …and neither implementation body sprouts a synthesized call of its own.
  1048. expect(synth(fileImpl!.id)).toHaveLength(0);
  1049. expect(synth(bufImpl!.id)).toHaveLength(0);
  1050. });
  1051. // ── Rust `self.<field>.<method>()` receivers (#1585) ───────────────────
  1052. // A Cargo layout (Cargo.toml + src/) so `use crate::…` paths resolve.
  1053. function writeRustCrate(root: string, files: Record<string, string>): void {
  1054. fs.writeFileSync(
  1055. path.join(root, 'Cargo.toml'),
  1056. '[package]\nname = "repro"\nversion = "0.1.0"\nedition = "2021"\n'
  1057. );
  1058. fs.mkdirSync(path.join(root, 'src'), { recursive: true });
  1059. for (const [rel, content] of Object.entries(files)) {
  1060. fs.writeFileSync(path.join(root, 'src', rel), content);
  1061. }
  1062. }
  1063. const callsFrom = (qualifiedName: string) => {
  1064. const from = cg.getNodesByKind('method').find((n) => n.qualifiedName === qualifiedName);
  1065. expect(from, qualifiedName).toBeDefined();
  1066. return cg
  1067. .getOutgoingEdges(from!.id)
  1068. .filter((e) => e.kind === 'calls')
  1069. .map((e) => ({
  1070. target: cg.getNode(e.target)?.qualifiedName,
  1071. resolvedBy: (e.metadata as { resolvedBy?: string } | undefined)?.resolvedBy,
  1072. provenance: e.provenance ?? undefined, // a resolved (non-synthesized) edge stores NULL
  1073. }));
  1074. };
  1075. it("resolves `self.field.method()` to the method on the field's declared type, never to the caller itself (#1585)", async () => {
  1076. // The issue's repro: `Outer::run` forwards to `Inner::run` through the
  1077. // typed field `inner`. The call used to collapse to the bare name `run`
  1078. // and exact-match the nearest same-named method — the calling method —
  1079. // recording recursion the source does not contain.
  1080. writeRustCrate(tempDir, {
  1081. 'lib.rs': 'pub mod inner;\npub mod outer;\n',
  1082. 'inner.rs': 'pub struct Inner {\n pub n: usize,\n}\n\nimpl Inner {\n pub fn run(&mut self) {\n self.n += 1;\n }\n}\n',
  1083. 'outer.rs': 'use crate::inner::Inner;\n\npub struct Outer {\n pub inner: Inner,\n}\n\nimpl Outer {\n pub fn run(&mut self) {\n self.inner.run();\n }\n}\n',
  1084. });
  1085. cg = await CodeGraph.init(tempDir, { index: true });
  1086. expect(callsFrom('Outer::run')).toEqual([
  1087. { target: 'Inner::run', resolvedBy: 'instance-method', provenance: undefined },
  1088. ]);
  1089. });
  1090. it('leaves a `self.field.method()` call unresolved when the field type is external, instead of guessing a same-named local method', async () => {
  1091. // `its` is a std type with no project node. Before, `self.its.next()`
  1092. // became the bare `next`, which exact-matched a local `next` — the
  1093. // calling method (self-edge) or the unrelated `Other::next` decoy.
  1094. writeRustCrate(tempDir, {
  1095. 'lib.rs':
  1096. 'pub struct Scanner {\n its: std::vec::IntoIter<u8>,\n}\n\nimpl Scanner {\n pub fn next(&mut self) -> Option<u8> {\n self.its.next()\n }\n}\n\n' +
  1097. 'pub struct Other { pub n: u8 }\nimpl Other {\n pub fn next(&mut self) -> Option<u8> {\n None\n }\n}\n',
  1098. });
  1099. cg = await CodeGraph.init(tempDir, { index: true });
  1100. expect(callsFrom('Scanner::next')).toEqual([]);
  1101. });
  1102. it('looks through references and owning smart pointers, but not through containers (#1585)', async () => {
  1103. // Method-call auto-deref reaches the pointee of `Box`/`&mut`, so those
  1104. // fields resolve to `Inner::run`. `Option<Inner>` does not auto-deref —
  1105. // `self.inner.take()` is Option's method, so it must NOT become
  1106. // `Inner::take` even though Inner declares a `take` too.
  1107. writeRustCrate(tempDir, {
  1108. 'lib.rs':
  1109. 'pub struct Inner { pub n: usize }\nimpl Inner {\n pub fn run(&mut self) { self.n += 1; }\n pub fn take(&mut self) {}\n}\n\n' +
  1110. 'pub struct Boxed { inner: Box<Inner> }\nimpl Boxed {\n pub fn go(&mut self) { self.inner.run(); }\n}\n\n' +
  1111. "pub struct Borrowed<'a> { inner: &'a mut Inner }\nimpl<'a> Borrowed<'a> {\n pub fn go(&mut self) { self.inner.run(); }\n}\n\n" +
  1112. 'pub struct Optional { inner: Option<Inner> }\nimpl Optional {\n pub fn go(&mut self) { self.inner.take(); }\n}\n',
  1113. });
  1114. cg = await CodeGraph.init(tempDir, { index: true });
  1115. expect(callsFrom('Boxed::go').map((c) => c.target)).toEqual(['Inner::run']);
  1116. expect(callsFrom('Borrowed::go').map((c) => c.target)).toEqual(['Inner::run']);
  1117. expect(callsFrom('Optional::go')).toEqual([]);
  1118. });
  1119. it('leaves a call through a generic-typed field unresolved, and keeps genuine `self.method()` recursion (#1585)', async () => {
  1120. writeRustCrate(tempDir, {
  1121. 'lib.rs':
  1122. 'pub struct Inner { pub n: usize }\nimpl Inner {\n pub fn run(&mut self) {}\n}\n\n' +
  1123. 'pub struct Holder<T> { item: T }\nimpl<T> Holder<T> {\n pub fn go(&mut self) { self.item.run(); }\n}\n\n' +
  1124. 'pub struct Countdown { pub n: usize }\nimpl Countdown {\n pub fn run(&mut self) {\n if self.n > 0 {\n self.n -= 1;\n self.run();\n }\n }\n}\n',
  1125. });
  1126. cg = await CodeGraph.init(tempDir, { index: true });
  1127. // `T` names no project type: no edge, and in particular not `Inner::run`.
  1128. expect(callsFrom('Holder::go')).toEqual([]);
  1129. // A bare `self` receiver is untouched — real recursion stays a self-edge.
  1130. expect(callsFrom('Countdown::run').map((c) => c.target)).toEqual(['Countdown::run']);
  1131. });
  1132. it('resolves a trait-object field to the trait method and typed fields to the right implementation (#1585, #1588)', async () => {
  1133. // The #1588 repro's second half: `UsesFile::go` / `UsesBuf::go` each
  1134. // forward through a typed field, and a `Box<dyn Source>` field lands on
  1135. // the trait's declaration — from which the interface-impl synthesizer
  1136. // fans out to every implementation.
  1137. writeRustCrate(tempDir, {
  1138. 'lib.rs':
  1139. 'pub trait Source {\n fn read(&mut self) -> usize;\n}\n\n' +
  1140. 'pub struct FileSource { pub n: usize }\nimpl Source for FileSource {\n fn read(&mut self) -> usize { self.n }\n}\n\n' +
  1141. 'pub struct BufSource<T> { pub inner: T }\nimpl<T> Source for BufSource<T> {\n fn read(&mut self) -> usize { 0 }\n}\n\n' +
  1142. 'pub struct UsesFile { pub src: FileSource }\nimpl UsesFile {\n pub fn go(&mut self) -> usize { self.src.read() }\n}\n\n' +
  1143. 'pub struct UsesBuf { pub src: BufSource<u8> }\nimpl UsesBuf {\n pub fn go(&mut self) -> usize { self.src.read() }\n}\n\n' +
  1144. 'pub struct UsesDyn { pub src: Box<dyn Source> }\nimpl UsesDyn {\n pub fn go(&mut self) -> usize { self.src.read() }\n}\n',
  1145. });
  1146. cg = await CodeGraph.init(tempDir, { index: true });
  1147. expect(callsFrom('UsesFile::go').map((c) => c.target)).toEqual(['FileSource::read']);
  1148. expect(callsFrom('UsesBuf::go').map((c) => c.target)).toEqual(['BufSource::read']);
  1149. expect(callsFrom('UsesDyn::go').map((c) => c.target)).toEqual(['Source::read']);
  1150. // …and dispatch continues from the trait declaration to both impls.
  1151. const fanOut = callsFrom('Source::read').filter((c) => c.provenance === 'heuristic').map((c) => c.target).sort();
  1152. expect(fanOut).toEqual(['BufSource::read', 'FileSource::read']);
  1153. });
  1154. it('records instantiates for C++ stack/brace construction, targeting the class (#1035)', async () => {
  1155. // `Calculator calc(0)` (direct-init) and `Widget w{1, 2}` (brace-init)
  1156. // carry the constructor args directly on the declarator — there's no
  1157. // call/new node — so they recorded no `instantiates` edge, while heap
  1158. // `new Calculator(0)` did. Both stack forms now do.
  1159. fs.writeFileSync(
  1160. path.join(tempDir, 'm.cpp'),
  1161. `class Calculator { public: Calculator(int seed) {} int add(int a, int b){ return a+b; } };
  1162. class Widget { public: Widget(int a, int b) {} };
  1163. int runStack(int a, int b) { Calculator calc(0); return calc.add(a, b); }
  1164. int runBrace() { Widget w{1, 2}; return 0; }
  1165. int runHeap(int a, int b) { Calculator* c = new Calculator(0); return c->add(a, b); }
  1166. void noise() { int x(5); int y{6}; Calculator deferred; }
  1167. `
  1168. );
  1169. cg = await CodeGraph.init(tempDir, { index: true });
  1170. const fn = (name: string) => cg.getNodesByKind('function').find((n) => n.name === name)!;
  1171. const instTargets = (name: string) =>
  1172. cg
  1173. .getOutgoingEdges(fn(name).id)
  1174. .filter((e) => e.kind === 'instantiates')
  1175. .map((e) => cg.getNode(e.target)!);
  1176. // Direct-init (the issue) and brace-init both instantiate, targeting the
  1177. // CLASS node — not the same-named constructor method.
  1178. const stack = instTargets('runStack');
  1179. expect(stack.map((n) => `${n.kind}:${n.name}`)).toContain('class:Calculator');
  1180. expect(instTargets('runBrace').map((n) => `${n.kind}:${n.name}`)).toContain('class:Widget');
  1181. // Heap still works (regression guard).
  1182. expect(instTargets('runHeap').map((n) => `${n.kind}:${n.name}`)).toContain('class:Calculator');
  1183. // Primitives (`int x(0)`/`int y{6}`) and bare default construction
  1184. // (`Calculator deferred;`) must NOT mint an instantiates edge.
  1185. expect(instTargets('noise')).toHaveLength(0);
  1186. });
  1187. it('resolves a cross-file static method call to the method, not the class (#825)', async () => {
  1188. // `Foo.bar()` where `Foo` is an imported class must link to the static
  1189. // method `Foo::bar`, NOT to the class `Foo`. Previously the import
  1190. // resolver dropped the `.bar` member and resolved to `Foo`, which the
  1191. // calls→instantiates promotion then turned into `run instantiates Foo`,
  1192. // leaving the static method with zero callers and a hollow impact radius.
  1193. fs.writeFileSync(
  1194. path.join(tempDir, 'helpers.ts'),
  1195. `export class Foo {\n static bar(x: number) { return x + 1; }\n}\n`
  1196. );
  1197. fs.writeFileSync(
  1198. path.join(tempDir, 'caller.ts'),
  1199. `import { Foo } from './helpers';\nexport function run() { return Foo.bar(41); }\n`
  1200. );
  1201. cg = await CodeGraph.init(tempDir, { index: true });
  1202. cg.resolveReferences();
  1203. const bar = cg.getNodesByKind('method').find((n) => n.name === 'bar');
  1204. const foo = cg.getNodesByKind('class').find((n) => n.name === 'Foo');
  1205. const run = cg.getNodesByKind('function').find((n) => n.name === 'run');
  1206. expect(bar).toBeDefined();
  1207. expect(foo).toBeDefined();
  1208. expect(run).toBeDefined();
  1209. // `run` is reported as a caller of the static method `Foo.bar`.
  1210. const barCallers = cg.getCallers(bar!.id).map((c) => c.node.name);
  1211. expect(barCallers).toContain('run');
  1212. // And the call is NOT mis-promoted to `run instantiates Foo`.
  1213. const outgoing = cg.getOutgoingEdges(run!.id);
  1214. expect(
  1215. outgoing.filter((e) => e.kind === 'instantiates' && e.target === foo!.id)
  1216. ).toHaveLength(0);
  1217. // The real edge is a `calls` edge to the method.
  1218. expect(
  1219. outgoing.some((e) => e.kind === 'calls' && e.target === bar!.id)
  1220. ).toBe(true);
  1221. });
  1222. it('resolves Go cross-package qualified calls via go.mod module path (#388)', async () => {
  1223. // Pre-#388, every `pkga.FuncX(...)` call in a Go monorepo was flagged
  1224. // external (isExternalImport returned true for any non-`/internal/`
  1225. // import without `.`-prefix) and resolution fell through to name-match
  1226. // with path proximity — recall on cross-package callers was ~<1%.
  1227. fs.writeFileSync(
  1228. path.join(tempDir, 'go.mod'),
  1229. 'module github.com/example/myproject\n\ngo 1.21\n'
  1230. );
  1231. const pkgaDir = path.join(tempDir, 'pkga');
  1232. const pkgbDir = path.join(tempDir, 'pkgb');
  1233. const pkgcDir = path.join(tempDir, 'pkgc');
  1234. fs.mkdirSync(pkgaDir);
  1235. fs.mkdirSync(pkgbDir);
  1236. fs.mkdirSync(pkgcDir);
  1237. // Same-name exported function in two packages — only the imported one
  1238. // should resolve. Exercises disambiguation, not just connectivity.
  1239. fs.writeFileSync(
  1240. path.join(pkgaDir, 'conv.go'),
  1241. 'package pkga\nfunc Convert(x int) int { return x * 2 }\n'
  1242. );
  1243. fs.writeFileSync(
  1244. path.join(pkgbDir, 'conv.go'),
  1245. 'package pkgb\nfunc Convert(x int) int { return x + 1 }\n'
  1246. );
  1247. fs.writeFileSync(
  1248. path.join(pkgcDir, 'use.go'),
  1249. `package pkgc
  1250. import "github.com/example/myproject/pkga"
  1251. func UsePkga() {
  1252. pkga.Convert(5)
  1253. }
  1254. `
  1255. );
  1256. cg = await CodeGraph.init(tempDir, { index: true });
  1257. const usePkga = cg.getNodesByKind('function').filter((n) => n.name ==='UsePkga')[0];
  1258. expect(usePkga).toBeDefined();
  1259. const outgoing = cg.getOutgoingEdges(usePkga!.id);
  1260. const callEdges = outgoing.filter((e) => e.kind === 'calls');
  1261. expect(callEdges).toHaveLength(1);
  1262. const target = cg.getNode(callEdges[0]!.target);
  1263. expect(target?.name).toBe('Convert');
  1264. // Critical: the resolver must pick the imported pkga's Convert,
  1265. // not pkgb's. With the broken (pre-fix) resolver this lands on
  1266. // whichever Convert happens to be cheaper under path proximity.
  1267. expect(target?.filePath.replace(/\\/g, '/')).toBe('pkga/conv.go');
  1268. });
  1269. it('resolves Go aliased imports across packages (#388)', async () => {
  1270. fs.writeFileSync(
  1271. path.join(tempDir, 'go.mod'),
  1272. 'module github.com/example/myproject\n\ngo 1.21\n'
  1273. );
  1274. fs.mkdirSync(path.join(tempDir, 'pkgb'));
  1275. fs.mkdirSync(path.join(tempDir, 'pkgd'));
  1276. fs.writeFileSync(
  1277. path.join(tempDir, 'pkgb', 'lib.go'),
  1278. 'package pkgb\nfunc Compute(x int) int { return x }\n'
  1279. );
  1280. fs.writeFileSync(
  1281. path.join(tempDir, 'pkgd', 'use.go'),
  1282. `package pkgd
  1283. import (
  1284. "fmt"
  1285. alias "github.com/example/myproject/pkgb"
  1286. )
  1287. func UseAliased() {
  1288. fmt.Println("hi")
  1289. alias.Compute(3)
  1290. }
  1291. `
  1292. );
  1293. cg = await CodeGraph.init(tempDir, { index: true });
  1294. const useAliased = cg.getNodesByKind('function').filter((n) => n.name ==='UseAliased')[0];
  1295. expect(useAliased).toBeDefined();
  1296. const calls = cg.getOutgoingEdges(useAliased!.id).filter((e) => e.kind === 'calls');
  1297. // fmt.Println is stdlib — must stay external. alias.Compute must resolve.
  1298. expect(calls).toHaveLength(1);
  1299. const target = cg.getNode(calls[0]!.target);
  1300. expect(target?.name).toBe('Compute');
  1301. expect(target?.filePath.replace(/\\/g, '/')).toBe('pkgb/lib.go');
  1302. });
  1303. it('resolves Python module-attribute calls after `from pkg import module` (#578)', async () => {
  1304. // Pre-#578, a `module.func()` call where `module` was bound via
  1305. // `from pkg import module` dropped its `calls` edge. The file→file import
  1306. // edge resolved (resolveModuleImportToFile falls back to a dotted-module
  1307. // file lookup for absolute package paths), but resolvePythonModuleMember
  1308. // had no such fallback — resolveImportPath returns null for an absolute
  1309. // package path like `pkg.module`, so the member never resolved and
  1310. // callers/callees/impact on the target came back empty. Same root-cause
  1311. // class as the Go cross-package qualified call (#388).
  1312. fs.mkdirSync(path.join(tempDir, 'pkg'));
  1313. fs.writeFileSync(path.join(tempDir, 'pkg', '__init__.py'), '');
  1314. fs.writeFileSync(
  1315. path.join(tempDir, 'pkg', 'module.py'),
  1316. 'def func():\n return 1\n'
  1317. );
  1318. fs.writeFileSync(
  1319. path.join(tempDir, 'main.py'),
  1320. `from pkg import module
  1321. import os
  1322. def caller():
  1323. return module.func()
  1324. def external_caller():
  1325. return os.getcwd()
  1326. `
  1327. );
  1328. cg = await CodeGraph.init(tempDir, { index: true });
  1329. const caller = cg.getNodesByKind('function').filter((n) => n.name === 'caller')[0];
  1330. expect(caller).toBeDefined();
  1331. const calls = cg.getOutgoingEdges(caller!.id).filter((e) => e.kind === 'calls');
  1332. // module.func() must resolve to the real function in the submodule file.
  1333. expect(calls).toHaveLength(1);
  1334. const target = cg.getNode(calls[0]!.target);
  1335. expect(target?.name).toBe('func');
  1336. expect(target?.filePath.replace(/\\/g, '/')).toBe('pkg/module.py');
  1337. // The flip side of the fix: an attribute call through a *stdlib* module
  1338. // (`os.getcwd()`) must still create no edge — the fallback only matches
  1339. // real in-repo module files.
  1340. const externalCaller = cg.getNodesByKind('function').filter((n) => n.name === 'external_caller')[0];
  1341. expect(externalCaller).toBeDefined();
  1342. const externalCalls = cg.getOutgoingEdges(externalCaller!.id).filter((e) => e.kind === 'calls');
  1343. expect(externalCalls).toHaveLength(0);
  1344. });
  1345. it('resolves a module-qualified call to a function whose name collides with a builtin collection method, and does not fabricate one from an unrelated chained receiver (#1681)', async () => {
  1346. // `ledger.append(row)` (module imported, method name `append`) previously
  1347. // never reached resolution: isBuiltInOrExternal's Python built-in-method
  1348. // filter treated ANY `x.append(...)` as `list.append` unless `X` matched a
  1349. // known CLASS, so a real MODULE export named `append` was dropped before
  1350. // resolveViaImport ever ran. Separately, `d.setdefault(k, []).append(x)` —
  1351. // a non-identifier (call-chain) receiver — used to degrade at extraction
  1352. // to a BARE `append` ref and exact-match ledger.append (#1683/#1748 fixed
  1353. // that half; assert both directions here).
  1354. fs.writeFileSync(
  1355. path.join(tempDir, 'ledger.py'),
  1356. 'def append(row):\n return True\n\n\ndef path():\n return "ledger.jsonl"\n'
  1357. );
  1358. fs.writeFileSync(
  1359. path.join(tempDir, 'record.py'),
  1360. `from . import ledger
  1361. def add_outcome(row):
  1362. if not ledger.append(row):
  1363. return None
  1364. return ledger.path()
  1365. `
  1366. );
  1367. fs.writeFileSync(
  1368. path.join(tempDir, 'unrelated.py'),
  1369. `def build_map():
  1370. rows_by_file = {}
  1371. rows_by_file.setdefault("f", []).append({"x": 1})
  1372. return rows_by_file
  1373. `
  1374. );
  1375. cg = await CodeGraph.init(tempDir, { index: true });
  1376. const ledgerAppend = cg
  1377. .getNodesByKind('function')
  1378. .find((n) => n.name === 'append' && n.filePath.replace(/\\/g, '/') === 'ledger.py');
  1379. expect(ledgerAppend).toBeDefined();
  1380. // The real, import-qualified call must resolve.
  1381. const addOutcome = cg.getNodesByKind('function').find((n) => n.name === 'add_outcome');
  1382. expect(addOutcome).toBeDefined();
  1383. const addOutcomeCalls = cg.getOutgoingEdges(addOutcome!.id).filter((e) => e.kind === 'calls');
  1384. expect(addOutcomeCalls.map((e) => e.target)).toContain(ledgerAppend!.id);
  1385. // The unrelated dict/list `.append()` on a chained receiver must NOT
  1386. // fabricate an edge to ledger.py's append.
  1387. const buildMap = cg.getNodesByKind('function').find((n) => n.name === 'build_map');
  1388. expect(buildMap).toBeDefined();
  1389. const buildMapCalls = cg.getOutgoingEdges(buildMap!.id).filter((e) => e.kind === 'calls');
  1390. expect(buildMapCalls.map((e) => e.target)).not.toContain(ledgerAppend!.id);
  1391. });
  1392. it('resolves Python module-attribute calls and file imports through an alias (#1626)', async () => {
  1393. // #715 taught resolvePythonModuleMember to fall back to a dotted-module
  1394. // file lookup, which fixed `from pkg import module` (#578). The aliased
  1395. // form still missed: the module path was rebuilt from the LOCAL name, so
  1396. // `from pkg import module as alias` looked for `pkg.alias` — a file that
  1397. // does not exist — and the call landed in unresolved_refs. The plain
  1398. // `import top as alias` form is a namespace import and binds at `source`,
  1399. // so it was already correct; it is pinned here so the fix can't regress it.
  1400. fs.mkdirSync(path.join(tempDir, 'pkg'));
  1401. fs.writeFileSync(path.join(tempDir, 'pkg', '__init__.py'), '');
  1402. fs.writeFileSync(
  1403. path.join(tempDir, 'pkg', 'module.py'),
  1404. 'def func():\n return 1\n'
  1405. );
  1406. fs.writeFileSync(
  1407. path.join(tempDir, 'top_level.py'),
  1408. 'def top_func():\n return 2\n'
  1409. );
  1410. fs.writeFileSync(
  1411. path.join(tempDir, 'main.py'),
  1412. `from pkg import module as mod_alias
  1413. import top_level as tl
  1414. def from_import_caller():
  1415. return mod_alias.func()
  1416. def plain_import_caller():
  1417. return tl.top_func()
  1418. `
  1419. );
  1420. cg = await CodeGraph.init(tempDir, { index: true });
  1421. const fromImportCaller = cg.getNodesByKind('function').filter((n) => n.name === 'from_import_caller')[0];
  1422. expect(fromImportCaller).toBeDefined();
  1423. const aliasCalls = cg.getOutgoingEdges(fromImportCaller!.id).filter((e) => e.kind === 'calls');
  1424. expect(aliasCalls).toHaveLength(1);
  1425. const aliasTarget = cg.getNode(aliasCalls[0]!.target);
  1426. expect(aliasTarget?.name).toBe('func');
  1427. expect(aliasTarget?.filePath.replace(/\\/g, '/')).toBe('pkg/module.py');
  1428. const plainCaller = cg.getNodesByKind('function').filter((n) => n.name === 'plain_import_caller')[0];
  1429. expect(plainCaller).toBeDefined();
  1430. const plainCalls = cg.getOutgoingEdges(plainCaller!.id).filter((e) => e.kind === 'calls');
  1431. expect(plainCalls).toHaveLength(1);
  1432. expect(cg.getNode(plainCalls[0]!.target)?.name).toBe('top_func');
  1433. // The file dependency must resolve too: fixing only the member lookup
  1434. // restores calls but leaves the aliased module's imports edge missing.
  1435. const mainFile = cg.getNodesByKind('file').find((n) => n.filePath === 'main.py');
  1436. const moduleFile = cg.getNodesByKind('file').find((n) => n.filePath.replace(/\\/g, '/') === 'pkg/module.py');
  1437. expect(mainFile).toBeDefined();
  1438. expect(moduleFile).toBeDefined();
  1439. const fileImports = cg.getOutgoingEdges(mainFile!.id).filter((e) => e.kind === 'imports');
  1440. expect(fileImports.map((e) => e.target)).toContain(moduleFile!.id);
  1441. });
  1442. it('attaches Go methods to their receiver type across files (#583, cross-file half)', async () => {
  1443. // In Go a type's methods are commonly declared in a different file from the
  1444. // `type` declaration (`type Box` in box.go, `func (b *Box) Get()` in
  1445. // box_methods.go). Extraction only attaches the struct→method `contains`
  1446. // edge when the type is in the SAME file (the owner lookup is file-scoped),
  1447. // so a cross-file method was orphaned from its struct — breaking member
  1448. // outlines and any callers/callees/impact traversal through `contains`. A
  1449. // resolution-phase pass now links them within the package (= directory).
  1450. fs.writeFileSync(
  1451. path.join(tempDir, 'box.go'),
  1452. 'package main\n\ntype Box struct{ v int }\n'
  1453. );
  1454. fs.writeFileSync(
  1455. path.join(tempDir, 'box_methods.go'),
  1456. 'package main\n\nfunc (b *Box) Get() int { return b.v }\nfunc (b *Box) Set(x int) { b.v = x }\n'
  1457. );
  1458. // Generic receiver declared cross-file too — exercises #583 half A
  1459. // (generic `*Stack[T]` receiver parsing) and half B (cross-file) together.
  1460. fs.writeFileSync(
  1461. path.join(tempDir, 'stack.go'),
  1462. 'package main\n\ntype Stack[T any] struct {\n\titems []T\n}\n'
  1463. );
  1464. fs.writeFileSync(
  1465. path.join(tempDir, 'stack_push.go'),
  1466. 'package main\n\nfunc (s *Stack[T]) Push(v T) { s.items = append(s.items, v) }\n'
  1467. );
  1468. // A same-named type in another package must NOT capture this package's
  1469. // methods — the link is scoped to the receiver type's own directory.
  1470. fs.mkdirSync(path.join(tempDir, 'other'));
  1471. fs.writeFileSync(
  1472. path.join(tempDir, 'other', 'box.go'),
  1473. 'package other\n\ntype Box struct{ w int }\n'
  1474. );
  1475. cg = await CodeGraph.init(tempDir, { index: true });
  1476. const methodsOf = (typeName: string, file: string): string[] => {
  1477. const node = cg
  1478. .getNodesByKind('struct')
  1479. .find((n) => n.name === typeName && n.filePath.replace(/\\/g, '/') === file);
  1480. expect(node, `${typeName} @ ${file}`).toBeDefined();
  1481. return cg
  1482. .getOutgoingEdges(node!.id)
  1483. .filter((e) => e.kind === 'contains')
  1484. .map((e) => cg.getNode(e.target))
  1485. .filter((n) => !!n && n.kind === 'method')
  1486. .map((n) => n!.name)
  1487. .sort();
  1488. };
  1489. // Cross-file (non-generic) methods now attach to their struct.
  1490. expect(methodsOf('Box', 'box.go')).toEqual(['Get', 'Set']);
  1491. // Generic + cross-file.
  1492. expect(methodsOf('Stack', 'stack.go')).toEqual(['Push']);
  1493. // Cross-package isolation: other/Box defines no methods of its own.
  1494. expect(methodsOf('Box', 'other/box.go')).toEqual([]);
  1495. });
  1496. it('TS type_alias object-shape members resolve method calls (#359)', async () => {
  1497. // Pre-#359, `recorder.stop()` (recorder: RecorderHandle) attached
  1498. // to `StdioMcpClient.stop` in a sibling directory via path-proximity
  1499. // because the type_alias had no `stop` node — only the unrelated
  1500. // class did. Now type_alias produces member nodes (property/method),
  1501. // so the camelCase receiver↔type word overlap pulls the call to
  1502. // `RecorderHandle::stop` instead of the look-alike class.
  1503. fs.mkdirSync(path.join(tempDir, 'voice'));
  1504. fs.mkdirSync(path.join(tempDir, 'codegraph'));
  1505. fs.writeFileSync(
  1506. path.join(tempDir, 'voice', 'recorder.ts'),
  1507. `export type RecorderHandle = {
  1508. wavPath: string;
  1509. stop: () => Promise<{ ok: true }>;
  1510. };
  1511. `
  1512. );
  1513. fs.writeFileSync(
  1514. path.join(tempDir, 'voice', 'controller.ts'),
  1515. `import type { RecorderHandle } from "./recorder";
  1516. export async function finaliseRecording(recorder: RecorderHandle) {
  1517. return await recorder.stop();
  1518. }
  1519. `
  1520. );
  1521. fs.writeFileSync(
  1522. path.join(tempDir, 'codegraph', 'stdio-client.ts'),
  1523. `export class StdioMcpClient {
  1524. private stopped = false;
  1525. async stop(): Promise<void> { this.stopped = true; }
  1526. }
  1527. `
  1528. );
  1529. cg = await CodeGraph.init(tempDir, { index: true });
  1530. const handleStop = cg
  1531. .getNodesByKind('method')
  1532. .find((n) => n.qualifiedName === 'RecorderHandle::stop');
  1533. expect(handleStop).toBeDefined();
  1534. const clientStop = cg
  1535. .getNodesByKind('method')
  1536. .find((n) => n.qualifiedName === 'StdioMcpClient::stop');
  1537. expect(clientStop).toBeDefined();
  1538. const handleCallers = cg.getIncomingEdges(handleStop!.id).filter((e) => e.kind === 'calls');
  1539. const clientCallers = cg.getIncomingEdges(clientStop!.id).filter((e) => e.kind === 'calls');
  1540. expect(handleCallers.length).toBeGreaterThanOrEqual(1);
  1541. // The class method must have NO callers — voice/'s call must NOT
  1542. // mis-attribute. A non-empty list would mean the false-positive
  1543. // path is still firing.
  1544. expect(clientCallers).toHaveLength(0);
  1545. // Function-typed property surfaces as a `method` node, not `property`,
  1546. // because `stop()` semantics at the call site are method semantics.
  1547. expect(handleStop!.kind).toBe('method');
  1548. });
  1549. it('Java import disambiguates same-name classes across modules (#314)', async () => {
  1550. // Pre-#314 the import resolver had no Java branch at all, so a
  1551. // multi-module Maven repo where `dao/converter/FooConverter` and
  1552. // `service/converter/FooConverter` both export a `convert` method
  1553. // resolved by file-path proximity — picking whichever class was
  1554. // closer to the caller, which is wrong any time the caller lives
  1555. // in an equidistant cross-cutting module.
  1556. const daoDir = path.join(tempDir, 'dao/src/main/java/com/example/dao/converter');
  1557. const serviceDir = path.join(tempDir, 'service/src/main/java/com/example/service/converter');
  1558. const webDir = path.join(tempDir, 'web/src/main/java/com/example/web');
  1559. fs.mkdirSync(daoDir, { recursive: true });
  1560. fs.mkdirSync(serviceDir, { recursive: true });
  1561. fs.mkdirSync(webDir, { recursive: true });
  1562. fs.writeFileSync(
  1563. path.join(daoDir, 'FooConverter.java'),
  1564. `package com.example.dao.converter;
  1565. public class FooConverter { public String convert(String x) { return "dao:" + x; } }
  1566. `
  1567. );
  1568. fs.writeFileSync(
  1569. path.join(serviceDir, 'FooConverter.java'),
  1570. `package com.example.service.converter;
  1571. public class FooConverter { public String convert(String x) { return "svc:" + x; } }
  1572. `
  1573. );
  1574. // The caller imports the SERVICE version — even though dao is
  1575. // alphabetically/lexically first in the candidate list, the
  1576. // import must trump that order.
  1577. fs.writeFileSync(
  1578. path.join(webDir, 'Handler.java'),
  1579. `package com.example.web;
  1580. import com.example.service.converter.FooConverter;
  1581. public class Handler {
  1582. private FooConverter fooConverter;
  1583. public String use() { return fooConverter.convert("input"); }
  1584. }
  1585. `
  1586. );
  1587. cg = await CodeGraph.init(tempDir, { index: true });
  1588. const use = cg
  1589. .getNodesByKind('method')
  1590. .find((n) => n.qualifiedName === 'com.example.web::Handler::use');
  1591. expect(use).toBeDefined();
  1592. const calls = cg.getOutgoingEdges(use!.id).filter((e) => e.kind === 'calls');
  1593. expect(calls.length).toBeGreaterThanOrEqual(1);
  1594. const target = cg.getNode(calls[0]!.target);
  1595. expect(target?.name).toBe('convert');
  1596. expect(target?.filePath.replace(/\\/g, '/')).toBe(
  1597. 'service/src/main/java/com/example/service/converter/FooConverter.java'
  1598. );
  1599. });
  1600. it('C# extracts references from method/property/field types (#381)', async () => {
  1601. // Pre-#381, every C# project produced ZERO `references` edges:
  1602. // csharp.ts was missing returnField, and the type-leaf walker
  1603. // only recognized TS/Java's `type_identifier` nodes — C# uses
  1604. // `identifier`/`predefined_type`/`qualified_name`/`generic_name`.
  1605. const srcDir = path.join(tempDir, 'src');
  1606. fs.mkdirSync(srcDir, { recursive: true });
  1607. fs.writeFileSync(
  1608. path.join(srcDir, 'Dtos.cs'),
  1609. `namespace MyApp;
  1610. public class SessionInfoDto { public string Id { get; set; } = ""; }
  1611. public class UserDto { public string Name { get; set; } = ""; }
  1612. `
  1613. );
  1614. fs.writeFileSync(
  1615. path.join(srcDir, 'Service.cs'),
  1616. `using System.Threading.Tasks;
  1617. namespace MyApp;
  1618. public class DataExporter
  1619. {
  1620. public SessionInfoDto Build(UserDto user, SessionInfoDto session) { return session; }
  1621. public Task<SessionInfoDto> BuildAsync(UserDto user) { return Task.FromResult(new SessionInfoDto()); }
  1622. public SessionInfoDto Latest { get; set; } = new();
  1623. private UserDto _cached;
  1624. }
  1625. `
  1626. );
  1627. cg = await CodeGraph.init(tempDir, { index: true });
  1628. const sessionDto = cg
  1629. .getNodesByKind('class')
  1630. .find((n) => n.name === 'SessionInfoDto');
  1631. const userDto = cg
  1632. .getNodesByKind('class')
  1633. .find((n) => n.name === 'UserDto');
  1634. expect(sessionDto).toBeDefined();
  1635. expect(userDto).toBeDefined();
  1636. const sessionIncoming = cg
  1637. .getIncomingEdges(sessionDto!.id)
  1638. .filter((e) => e.kind === 'references');
  1639. const userIncoming = cg
  1640. .getIncomingEdges(userDto!.id)
  1641. .filter((e) => e.kind === 'references');
  1642. // SessionInfoDto: Build return, Build param, BuildAsync return (inside Task<>), Latest property.
  1643. // UserDto: Build param, BuildAsync param, _cached field.
  1644. expect(sessionIncoming.length).toBeGreaterThanOrEqual(4);
  1645. expect(userIncoming.length).toBeGreaterThanOrEqual(3);
  1646. });
  1647. it('C# primary-constructor parameters record their type dependencies (#237)', async () => {
  1648. // C# 12 primary constructors declare a type's injected dependencies inline
  1649. // (`class Svc(IRepo repo, [FromKeyedServices("k")] ICache cache)`). Each
  1650. // ctor parameter's type is recorded as a `references` edge from the class,
  1651. // so a DI-registered contract reached only through a primary ctor is no
  1652. // longer reported as having no dependents.
  1653. fs.mkdirSync(path.join(tempDir, 'src'), { recursive: true });
  1654. fs.writeFileSync(
  1655. path.join(tempDir, 'src', 'Contracts.cs'),
  1656. `namespace App;
  1657. public interface IRepo { }
  1658. public class ICache { }
  1659. `
  1660. );
  1661. fs.writeFileSync(
  1662. path.join(tempDir, 'src', 'OrderService.cs'),
  1663. `namespace App;
  1664. public sealed class OrderService(IRepo repo, [FromKeyedServices("primary")] ICache cache)
  1665. {
  1666. public void Run() { }
  1667. }
  1668. `
  1669. );
  1670. cg = await CodeGraph.init(tempDir, { index: true });
  1671. const svc = cg.getNodesByKind('class').find((n) => n.name === 'OrderService');
  1672. expect(svc).toBeDefined();
  1673. // The class itself must index (it used to vanish under the old grammar).
  1674. const out = cg.getOutgoingEdges(svc!.id).filter((e) => e.kind === 'references');
  1675. const depNames = out.map((e) => cg.getNode(e.target)?.name);
  1676. expect(depNames).toContain('IRepo');
  1677. expect(depNames).toContain('ICache'); // the keyed-DI ([FromKeyedServices]) dependency
  1678. });
  1679. it('Go: leaves stdlib calls (fmt.Println, etc.) external', async () => {
  1680. fs.writeFileSync(
  1681. path.join(tempDir, 'go.mod'),
  1682. 'module github.com/example/myproject\n\ngo 1.21\n'
  1683. );
  1684. fs.writeFileSync(
  1685. path.join(tempDir, 'main.go'),
  1686. `package main
  1687. import "fmt"
  1688. func main() {
  1689. fmt.Println("hi")
  1690. }
  1691. `
  1692. );
  1693. cg = await CodeGraph.init(tempDir, { index: true });
  1694. const mainFn = cg.getNodesByKind('function').filter((n) => n.name ==='main')[0];
  1695. const calls = cg.getOutgoingEdges(mainFn!.id).filter((e) => e.kind === 'calls');
  1696. // No spurious in-project edge — fmt.* must stay unresolved/external.
  1697. expect(calls).toHaveLength(0);
  1698. });
  1699. });
  1700. describe('Same-name method disambiguation (#1079)', () => {
  1701. // resolveMethodOnType picks among several methods that share a
  1702. // `Type::method` qualifiedName. The precedence is:
  1703. // 1. preferredFqn (Java/Kotlin import — target is intentionally in
  1704. // ANOTHER file, #314),
  1705. // 2. the call site's OWN file (language-agnostic, #1079),
  1706. // 3. matches[0] (first-indexed) as a last resort.
  1707. const methodNode = (
  1708. id: string,
  1709. filePath: string,
  1710. language: Node['language'] = 'cpp',
  1711. qualifiedName = 'Logger::log',
  1712. name = 'log',
  1713. ): Node => ({
  1714. id, kind: 'method', name, qualifiedName, filePath, language,
  1715. startLine: 1, endLine: 1, startColumn: 0, endColumn: 0, updatedAt: 0,
  1716. });
  1717. const callRef = (filePath: string, language: Node['language'] = 'cpp'): UnresolvedRef => ({
  1718. fromNodeId: 'caller', referenceName: 'lg.log', referenceKind: 'calls',
  1719. line: 2, column: 0, filePath, language,
  1720. });
  1721. const ctxFor = (candidates: Node[]): ResolutionContext => ({
  1722. getNodesInFile: () => [],
  1723. getNodesByName: (name) => candidates.filter((c) => c.name === name),
  1724. getNodesByQualifiedName: () => [],
  1725. getNodesByKind: () => [],
  1726. fileExists: () => false,
  1727. readFile: () => null,
  1728. getProjectRoot: () => '',
  1729. getAllFiles: () => [],
  1730. });
  1731. it('prefers the definition in the call site\'s own file (#1079)', () => {
  1732. // matches[0] is the a/ definition; the call comes from b/, so it must
  1733. // resolve to b/ — not collapse onto the first-indexed match.
  1734. const logA = methodNode('m:a', 'a/svc.cpp');
  1735. const logB = methodNode('m:b', 'b/svc.cpp');
  1736. const result = resolveMethodOnType(
  1737. 'Logger', 'log', callRef('b/svc.cpp'), ctxFor([logA, logB]), 0.9, 'instance-method',
  1738. );
  1739. expect(result?.targetNodeId).toBe('m:b');
  1740. });
  1741. it('lets an import FQN pin a cross-file target over the same-file preference (#314)', () => {
  1742. // Java: two `Bar::doIt` in different packages. The import FQN pins the
  1743. // alpha package; even though the call site lives in beta's file, the FQN
  1744. // must win — the same-file preference runs only AFTER preferredFqn.
  1745. const alpha = methodNode('m:alpha', 'com/example/alpha/Bar.java', 'java', 'Bar::doIt', 'doIt');
  1746. const beta = methodNode('m:beta', 'com/example/beta/Bar.java', 'java', 'Bar::doIt', 'doIt');
  1747. const result = resolveMethodOnType(
  1748. 'Bar', 'doIt', callRef('com/example/beta/Bar.java', 'java'),
  1749. ctxFor([alpha, beta]), 0.9, 'instance-method', 'com.example.alpha.Bar',
  1750. );
  1751. expect(result?.targetNodeId).toBe('m:alpha');
  1752. });
  1753. it('falls back to the first match when nothing disambiguates', () => {
  1754. // Call site is a third file: no FQN, no same-file candidate → matches[0].
  1755. const logA = methodNode('m:a', 'a/svc.cpp');
  1756. const logB = methodNode('m:b', 'b/svc.cpp');
  1757. const result = resolveMethodOnType(
  1758. 'Logger', 'log', callRef('c/other.cpp'), ctxFor([logA, logB]), 0.9, 'instance-method',
  1759. );
  1760. expect(result?.targetNodeId).toBe('m:a');
  1761. });
  1762. it('resolves C++ calls end-to-end to same-named classes in different files (#1079)', async () => {
  1763. // The exact repro from the issue: two files, each with its own
  1764. // `Logger::log`. Before the fix both callers pointed at the first def.
  1765. fs.mkdirSync(path.join(tempDir, 'a'), { recursive: true });
  1766. fs.mkdirSync(path.join(tempDir, 'b'), { recursive: true });
  1767. fs.writeFileSync(
  1768. path.join(tempDir, 'a', 'svc.cpp'),
  1769. `class Logger { public: void log() { int a = 1; } };\nvoid useA() { Logger lg; lg.log(); }\n`,
  1770. );
  1771. fs.writeFileSync(
  1772. path.join(tempDir, 'b', 'svc.cpp'),
  1773. `class Logger { public: void log() { int b = 2; } };\nvoid useB() { Logger lg; lg.log(); }\n`,
  1774. );
  1775. cg = await CodeGraph.init(tempDir, { index: true });
  1776. cg.resolveReferences();
  1777. const logInDir = (dir: string) =>
  1778. cg.getNodesByKind('method').find(
  1779. (n) => n.name === 'log' && n.filePath.replace(/\\/g, '/').endsWith(`${dir}/svc.cpp`),
  1780. )!;
  1781. const callTargets = (fnName: string) =>
  1782. cg
  1783. .getOutgoingEdges(cg.getNodesByKind('function').find((n) => n.name === fnName)!.id)
  1784. .filter((e) => e.kind === 'calls')
  1785. .map((e) => e.target);
  1786. const logA = logInDir('a');
  1787. const logB = logInDir('b');
  1788. expect(logA).toBeDefined();
  1789. expect(logB).toBeDefined();
  1790. expect(logA.id).not.toBe(logB.id);
  1791. // Each caller resolves to the Logger::log in its OWN file.
  1792. expect(callTargets('useA')).toContain(logA.id);
  1793. expect(callTargets('useB')).toContain(logB.id);
  1794. });
  1795. it('preferCallSiteFile puts same-file candidates first and is otherwise a no-op', () => {
  1796. const a = methodNode('m:a', 'a/svc.cpp');
  1797. const b = methodNode('m:b', 'b/svc.cpp');
  1798. // Same-file first; the rest keep their original order (stable).
  1799. expect(preferCallSiteFile([a, b], 'b/svc.cpp').map((n) => n.id)).toEqual(['m:b', 'm:a']);
  1800. expect(preferCallSiteFile([a, b], 'a/svc.cpp').map((n) => n.id)).toEqual(['m:a', 'm:b']);
  1801. // No same-file match → unchanged; <2 candidates → returned as-is.
  1802. expect(preferCallSiteFile([a, b], 'c/other.cpp').map((n) => n.id)).toEqual(['m:a', 'm:b']);
  1803. expect(preferCallSiteFile([a], 'z/none.cpp')).toHaveLength(1);
  1804. });
  1805. it('matchByQualifiedName prefers the same-file target when a qualified name is ambiguous (#1079)', () => {
  1806. // Two `Logger::log` definitions; an explicit `Logger::log()` call from b/
  1807. // must resolve to b/'s definition, not the first-indexed one.
  1808. const a = methodNode('m:a', 'a/svc.cpp');
  1809. const b = methodNode('m:b', 'b/svc.cpp');
  1810. const ctx: ResolutionContext = {
  1811. getNodesInFile: () => [],
  1812. getNodesByName: (name) => [a, b].filter((n) => n.name === name),
  1813. getNodesByQualifiedName: (q) => (q === 'Logger::log' ? [a, b] : []),
  1814. getNodesByKind: () => [],
  1815. fileExists: () => false,
  1816. readFile: () => null,
  1817. getProjectRoot: () => '',
  1818. getAllFiles: () => [],
  1819. };
  1820. const ref: UnresolvedRef = {
  1821. fromNodeId: 'caller', referenceName: 'Logger::log', referenceKind: 'calls',
  1822. line: 2, column: 0, filePath: 'b/svc.cpp', language: 'cpp',
  1823. };
  1824. expect(matchByQualifiedName(ref, ctx)?.targetNodeId).toBe('m:b');
  1825. });
  1826. it('resolves a static/class-receiver call to the class in the caller\'s file (#1079)', async () => {
  1827. // `Logger.log()` — the receiver is the class NAME, so this routes through
  1828. // the class-name-receiver strategy (not the C++ instance path). It was
  1829. // file-blind across languages; verified here on TypeScript.
  1830. fs.mkdirSync(path.join(tempDir, 'a'), { recursive: true });
  1831. fs.mkdirSync(path.join(tempDir, 'b'), { recursive: true });
  1832. fs.writeFileSync(
  1833. path.join(tempDir, 'a', 'svc.ts'),
  1834. `class Logger { static log() { return 1; } }\nexport function useA() { return Logger.log(); }\n`,
  1835. );
  1836. fs.writeFileSync(
  1837. path.join(tempDir, 'b', 'svc.ts'),
  1838. `class Logger { static log() { return 2; } }\nexport function useB() { return Logger.log(); }\n`,
  1839. );
  1840. cg = await CodeGraph.init(tempDir, { index: true });
  1841. cg.resolveReferences();
  1842. const logInDir = (dir: string) =>
  1843. cg.getNodesByKind('method').find(
  1844. (n) => n.name === 'log' && n.filePath.replace(/\\/g, '/').endsWith(`${dir}/svc.ts`),
  1845. )!;
  1846. const callTargets = (fnName: string) =>
  1847. cg
  1848. .getOutgoingEdges(cg.getNodesByKind('function').find((n) => n.name === fnName)!.id)
  1849. .filter((e) => e.kind === 'calls')
  1850. .map((e) => e.target);
  1851. const logA = logInDir('a');
  1852. const logB = logInDir('b');
  1853. expect(logA?.id).not.toBe(logB?.id);
  1854. expect(callTargets('useA')).toContain(logA.id);
  1855. expect(callTargets('useB')).toContain(logB.id);
  1856. });
  1857. it('resolves an explicitly-qualified call to the definition in the caller\'s file (#1079)', async () => {
  1858. // `Logger::log()` with two `Logger::log` definitions routes through the
  1859. // qualified-name strategy, whose partial match previously picked the first.
  1860. fs.mkdirSync(path.join(tempDir, 'a'), { recursive: true });
  1861. fs.mkdirSync(path.join(tempDir, 'b'), { recursive: true });
  1862. fs.writeFileSync(
  1863. path.join(tempDir, 'a', 'svc.cpp'),
  1864. `class Logger { public: static void log() { int a = 1; } };\nvoid useA() { Logger::log(); }\n`,
  1865. );
  1866. fs.writeFileSync(
  1867. path.join(tempDir, 'b', 'svc.cpp'),
  1868. `class Logger { public: static void log() { int b = 2; } };\nvoid useB() { Logger::log(); }\n`,
  1869. );
  1870. cg = await CodeGraph.init(tempDir, { index: true });
  1871. cg.resolveReferences();
  1872. const logInDir = (dir: string) =>
  1873. cg.getNodesByKind('method').find(
  1874. (n) => n.name === 'log' && n.filePath.replace(/\\/g, '/').endsWith(`${dir}/svc.cpp`),
  1875. )!;
  1876. const callTargets = (fnName: string) =>
  1877. cg
  1878. .getOutgoingEdges(cg.getNodesByKind('function').find((n) => n.name === fnName)!.id)
  1879. .filter((e) => e.kind === 'calls')
  1880. .map((e) => e.target);
  1881. const logA = logInDir('a');
  1882. const logB = logInDir('b');
  1883. expect(logA?.id).not.toBe(logB?.id);
  1884. expect(callTargets('useA')).toContain(logA.id);
  1885. expect(callTargets('useB')).toContain(logB.id);
  1886. });
  1887. });
  1888. describe('Lua function-expression resolution (#1616)', () => {
  1889. it('attributes helper calls to each assigned callable instead of the file node', async () => {
  1890. fs.writeFileSync(
  1891. path.join(tempDir, 'util.lua'),
  1892. `util = {}\nfunction util.helper() return 1 end\nreturn util\n`
  1893. );
  1894. fs.writeFileSync(
  1895. path.join(tempDir, 'handlers.lua'),
  1896. `local M = {}\nfunction M.namedFn() return util.helper() end\nM.assignedFn = function() return util.helper() end\nM.callbacks = { onStart = function() return util.helper() end }\nreturn M\n`
  1897. );
  1898. cg = await CodeGraph.init(tempDir, { index: true });
  1899. cg.resolveReferences();
  1900. const helper = cg
  1901. .getNodesByKind('method')
  1902. .find((n) => n.qualifiedName === 'util::helper');
  1903. expect(helper).toBeDefined();
  1904. const callers = cg.getCallers(helper!.id).map((c) => c.node);
  1905. expect(callers.some((n) => n.qualifiedName === 'M::namedFn')).toBe(true);
  1906. expect(callers.some((n) => n.qualifiedName === 'M::assignedFn')).toBe(true);
  1907. expect(callers.some((n) => n.qualifiedName === 'M.callbacks::onStart')).toBe(true);
  1908. expect(callers.some((n) => n.kind === 'file' && n.filePath === 'handlers.lua')).toBe(false);
  1909. });
  1910. });
  1911. describe('Watchdog-safe resolution on collision-heavy repos (#1122)', () => {
  1912. // On a large Java-style repo, per-ref resolution cost is unbounded in the
  1913. // worst case (a colliding method name whose candidate set misses the LRU
  1914. // re-fetches tens of thousands of rows, and receiver inference re-splits
  1915. // the whole source file). v1.2.0 yielded only every 500 refs, so a dense
  1916. // pocket multiplied that cost past the #850 watchdog window and a VALID
  1917. // `init` was SIGKILLed at "Resolving refs". These pin the three guards:
  1918. // per-ref yield checkpoints, the (type, method) match memo, and the
  1919. // per-file lines cache with its generated/minified-line skip.
  1920. const methodNode = (
  1921. id: string,
  1922. filePath: string,
  1923. qualifiedName: string,
  1924. name: string,
  1925. language: Node['language'] = 'typescript',
  1926. kind: Node['kind'] = 'method',
  1927. ): Node => ({
  1928. id, kind, name, qualifiedName, filePath, language,
  1929. startLine: 1, endLine: 1, startColumn: 0, endColumn: 0, updatedAt: 0,
  1930. });
  1931. it('resolveMethodOnType consults the method-match memo and still disambiguates per call site', () => {
  1932. const logA = methodNode('m:a', 'a/svc.ts', 'Logger::log', 'log');
  1933. const logB = methodNode('m:b', 'b/svc.ts', 'Logger::log', 'log');
  1934. const shared = [logA, logB]; // one cached array served to every caller
  1935. let memoCalls = 0;
  1936. let rawNameLookups = 0;
  1937. const ctx: ResolutionContext = {
  1938. getNodesInFile: () => [],
  1939. getNodesByName: () => { rawNameLookups++; return shared; },
  1940. getMethodMatches: () => { memoCalls++; return shared; },
  1941. getNodesByQualifiedName: () => [],
  1942. getNodesByKind: () => [],
  1943. fileExists: () => false,
  1944. readFile: () => null,
  1945. getProjectRoot: () => '',
  1946. getAllFiles: () => [],
  1947. };
  1948. const refFrom = (filePath: string): UnresolvedRef => ({
  1949. fromNodeId: 'caller', referenceName: 'lg.log', referenceKind: 'calls',
  1950. line: 2, column: 0, filePath, language: 'typescript',
  1951. });
  1952. // Both call sites read the SAME memoized array, yet each still resolves
  1953. // to its own file — per-ref disambiguation runs after the memo (#1079).
  1954. const fromA = resolveMethodOnType('Logger', 'log', refFrom('a/svc.ts'), ctx, 0.9, 'instance-method');
  1955. const fromB = resolveMethodOnType('Logger', 'log', refFrom('b/svc.ts'), ctx, 0.9, 'instance-method');
  1956. expect(fromA?.targetNodeId).toBe('m:a');
  1957. expect(fromB?.targetNodeId).toBe('m:b');
  1958. expect(memoCalls).toBe(2);
  1959. expect(rawNameLookups).toBe(0); // memo bypasses the unbounded name fetch
  1960. });
  1961. it('the production resolver context memoizes method matches per (language, type, method)', async () => {
  1962. fs.writeFileSync(
  1963. path.join(tempDir, 'svc.ts'),
  1964. `class Logger { log() { return 1; } }\nexport function use() { const lg = new Logger(); return lg.log(); }\n`,
  1965. );
  1966. cg = await CodeGraph.init(tempDir, { index: true });
  1967. const resolver = (cg as unknown as { resolver: ReferenceResolver }).resolver;
  1968. const ctx = (resolver as unknown as { context: ResolutionContext }).context;
  1969. const first = ctx.getMethodMatches!('Logger', 'log', 'typescript');
  1970. const second = ctx.getMethodMatches!('Logger', 'log', 'typescript');
  1971. expect(first.map((n) => n.qualifiedName)).toEqual(['Logger::log']);
  1972. // Same array instance = served from the memo, not recomputed.
  1973. expect(second).toBe(first);
  1974. resolver.clearCaches();
  1975. const afterClear = ctx.getMethodMatches!('Logger', 'log', 'typescript');
  1976. expect(afterClear).not.toBe(first);
  1977. expect(afterClear.map((n) => n.qualifiedName)).toEqual(['Logger::log']);
  1978. });
  1979. it('resolveBatchYielding offers a yield checkpoint for every ref', async () => {
  1980. fs.writeFileSync(
  1981. path.join(tempDir, 'a.ts'),
  1982. `export function fnA() { return 1; }\nexport function fnB() { return fnA(); }\nexport function fnC() { return fnB(); }\n`,
  1983. );
  1984. fs.writeFileSync(
  1985. path.join(tempDir, 'b.ts'),
  1986. `import { fnA } from './a';\nexport function fnD() { return fnA(); }\n`,
  1987. );
  1988. cg = await CodeGraph.init(tempDir, { index: true });
  1989. const resolver = (cg as unknown as { resolver: ReferenceResolver }).resolver;
  1990. // `init({ index: true })` already ran resolution, so feed the batch
  1991. // directly — resolveBatchYielding takes it as an argument; whether each
  1992. // ref resolves is irrelevant to the checkpoint contract.
  1993. const refs: UnresolvedReference[] = ['fnA', 'fnB', 'nosuchFn', 'fnA', 'alsoMissing'].map((name, i) => ({
  1994. fromNodeId: `caller-${i}`,
  1995. referenceName: name,
  1996. referenceKind: 'calls',
  1997. line: i + 1,
  1998. column: 0,
  1999. filePath: 'a.ts',
  2000. language: 'typescript',
  2001. }));
  2002. let checkpoints = 0;
  2003. const countingYield = async () => { checkpoints++; };
  2004. const result = await (resolver as unknown as {
  2005. resolveBatchYielding(batch: UnresolvedReference[], maybeYield: () => Promise<void>): Promise<{ stats: { total: number } }>;
  2006. }).resolveBatchYielding(refs, countingYield);
  2007. // One checkpoint per ref: a pocket of pathologically slow refs can never
  2008. // run more than ONE ref past the yield budget before the heartbeat gets
  2009. // a window — the #1122 kill required 500.
  2010. expect(checkpoints).toBe(refs.length);
  2011. expect(result.stats.total).toBe(refs.length);
  2012. });
  2013. it('receiver inference reads lines through getFileLines when the context provides it', () => {
  2014. const loggerClass = methodNode('c:logger', 'svc.ts', 'Logger', 'Logger', 'typescript', 'class');
  2015. const logMethod = methodNode('m:log', 'svc.ts', 'Logger::log', 'log');
  2016. const otherLog = methodNode('m:other', 'other.ts', 'Other::log', 'log');
  2017. const byName: Record<string, Node[]> = {
  2018. Logger: [loggerClass],
  2019. log: [logMethod, otherLog], // ambiguous bare name → only inference can resolve
  2020. };
  2021. const lines = ['const lg = new Logger();', 'lg.log();'];
  2022. const ctx: ResolutionContext = {
  2023. getNodesInFile: () => [],
  2024. getNodesByName: (name) => byName[name] ?? [],
  2025. getNodesByQualifiedName: () => [],
  2026. getNodesByKind: () => [],
  2027. fileExists: () => false,
  2028. // Reading the raw source must not be needed when lines are provided.
  2029. readFile: () => { throw new Error('readFile must not be called when getFileLines exists'); },
  2030. getFileLines: () => lines,
  2031. getProjectRoot: () => '',
  2032. getAllFiles: () => [],
  2033. };
  2034. const ref: UnresolvedRef = {
  2035. fromNodeId: 'caller', referenceName: 'lg.log', referenceKind: 'calls',
  2036. line: 2, column: 0, filePath: 'svc.ts', language: 'typescript',
  2037. };
  2038. expect(matchMethodCall(ref, ctx)?.targetNodeId).toBe('m:log');
  2039. });
  2040. it('receiver inference skips generated/minified lines instead of regex-scanning them', () => {
  2041. const loggerClass = methodNode('c:logger', 'svc.ts', 'Logger', 'Logger', 'typescript', 'class');
  2042. const logMethod = methodNode('m:log', 'svc.ts', 'Logger::log', 'log');
  2043. const otherLog = methodNode('m:other', 'other.ts', 'Other::log', 'log');
  2044. const byName: Record<string, Node[]> = {
  2045. Logger: [loggerClass],
  2046. log: [logMethod, otherLog],
  2047. };
  2048. const ctxWithLines = (lines: string[]): ResolutionContext => ({
  2049. getNodesInFile: () => [],
  2050. getNodesByName: (name) => byName[name] ?? [],
  2051. getNodesByQualifiedName: () => [],
  2052. getNodesByKind: () => [],
  2053. fileExists: () => false,
  2054. readFile: () => null,
  2055. getFileLines: () => lines,
  2056. getProjectRoot: () => '',
  2057. getAllFiles: () => [],
  2058. });
  2059. const ref: UnresolvedRef = {
  2060. fromNodeId: 'caller', referenceName: 'lg.log', referenceKind: 'calls',
  2061. line: 1, column: 0, filePath: 'svc.ts', language: 'typescript',
  2062. };
  2063. // Control: the declaration on a normal-length line resolves.
  2064. const normal = matchMethodCall(ref, ctxWithLines(['const lg = new Logger(); lg.log();']));
  2065. expect(normal?.targetNodeId).toBe('m:log');
  2066. // The same declaration buried in a >10K-char generated/minified line is
  2067. // skipped — no resolution, and no per-ref regex pass over the huge line.
  2068. const minified = 'var pad="' + 'x'.repeat(10_000) + '";const lg = new Logger(); lg.log();';
  2069. expect(matchMethodCall(ref, ctxWithLines([minified]))).toBeNull();
  2070. });
  2071. });
  2072. describe('Local-variable receiver-type inference (#1108)', () => {
  2073. it.each(['ts', 'tsx', 'js', 'jsx'])('keeps built-in Map calls off project methods — %s (#1566)', async (ext) => {
  2074. const typed = ext === 'ts' || ext === 'tsx';
  2075. fs.writeFileSync(path.join(tempDir, `cache.${ext}`), `
  2076. export class LRUCache {
  2077. get(key) { return key; }
  2078. set(key, value) { return value; }
  2079. has(key) { return true; }
  2080. }
  2081. export function useLocalMap() {
  2082. const values = new Map${typed ? '<string, string>' : ''}();
  2083. values.set('answer', '42');
  2084. values.get('answer');
  2085. return values.has('answer');
  2086. }
  2087. export function useNestedMap(holder${typed ? ': { values: Map<string, string> }' : ''}) {
  2088. return holder.values.get('answer');
  2089. }
  2090. export function useProjectCache() {
  2091. const cache = new LRUCache();
  2092. cache.set('answer', '42');
  2093. cache.get('answer');
  2094. return cache.has('answer');
  2095. }
  2096. `);
  2097. cg = await CodeGraph.init(tempDir, { index: true });
  2098. cg.resolveReferences();
  2099. for (const name of ['useLocalMap', 'useNestedMap', 'useProjectCache']) {
  2100. const caller = cg.getNodesByName(name).find((n) => n.kind === 'function');
  2101. expect(caller, name).toBeDefined();
  2102. const calls = cg.getOutgoingEdges(caller!.id).filter((e) => e.kind === 'calls');
  2103. if (name === 'useProjectCache') {
  2104. const methods = cg.getNodesByKind('method').filter((n) => n.qualifiedName.startsWith('LRUCache::'));
  2105. expect(methods).toHaveLength(3);
  2106. expect(calls.map((e) => e.target).sort()).toEqual(methods.map((n) => n.id).sort());
  2107. expect(calls.every((e) => e.metadata?.confidence === 0.9)).toBe(true);
  2108. } else {
  2109. expect.soft(calls, `${ext}: ${name} must not call a project method`).toEqual([]);
  2110. }
  2111. }
  2112. });
  2113. it('keeps a validated project class that shadows Map (#1566)', async () => {
  2114. fs.writeFileSync(path.join(tempDir, 'shadow.ts'), `
  2115. export class Map { get() { return 1; } }
  2116. export class Other { get() { return 2; } }
  2117. export function useShadow() {
  2118. const values = new Map();
  2119. return values.get();
  2120. }
  2121. `);
  2122. cg = await CodeGraph.init(tempDir, { index: true });
  2123. const caller = cg.getNodesByName('useShadow').find((n) => n.kind === 'function');
  2124. expect(caller).toBeDefined();
  2125. expect(cg.getCallees(caller!.id).filter(({ edge }) => edge.kind === 'calls').map(({ node }) => node.qualifiedName))
  2126. .toEqual(['Map::get']);
  2127. });
  2128. it.each([
  2129. ['Set', 'has'], ['WeakMap', 'get'], ['WeakSet', 'has'], ['Array', 'map'], ['Promise', 'then'],
  2130. ])('declines same-name guesses for an inferred %s receiver (#1566)', async (type, method) => {
  2131. fs.writeFileSync(path.join(tempDir, 'builtin.ts'), `
  2132. export class Collision { ${method}() { return 1; } }
  2133. export function constructed() {
  2134. const values = new ${type}();
  2135. return values.${method}();
  2136. }
  2137. export function annotated(values: ${type}<string>) {
  2138. return values.${method}();
  2139. }
  2140. `);
  2141. cg = await CodeGraph.init(tempDir, { index: true });
  2142. cg.resolveReferences();
  2143. expect(cg.getNodesByKind('method').some((n) => n.name === method)).toBe(true);
  2144. for (const name of ['constructed', 'annotated']) {
  2145. const caller = cg.getNodesByName(name).find((n) => n.kind === 'function');
  2146. expect(caller, name).toBeDefined();
  2147. expect.soft(cg.getOutgoingEdges(caller!.id).filter((e) => e.kind === 'calls'), name).toEqual([]);
  2148. }
  2149. });
  2150. // `lg.log()` where `lg` is a local whose type is inferred from its
  2151. // declaration/initializer. Before this, only C++ resolved these; every
  2152. // other language produced no method edge. Each case is one file with a
  2153. // single Logger + a caller using a local-variable receiver — a correct
  2154. // resolution makes the caller a caller of `log`.
  2155. const cases: Array<{ lang: string; file: string; src: string }> = [
  2156. { lang: 'TypeScript (= new T)', file: 'svc.ts',
  2157. src: `class Logger { log() { return 1; } }\nexport function use() { const lg = new Logger(); return lg.log(); }\n` },
  2158. { lang: 'JavaScript (= new T)', file: 'svc.js',
  2159. src: `class Logger { log() { return 1; } }\nexport function use() { const lg = new Logger(); return lg.log(); }\n` },
  2160. { lang: 'Python (= T())', file: 'svc.py',
  2161. src: `class Logger:\n def log(self):\n return 1\ndef use():\n lg = Logger()\n return lg.log()\n` },
  2162. { lang: 'Java (T x = new T)', file: 'Svc.java',
  2163. src: `class Logger { void log() { int a = 1; } }\nclass Use { void run() { Logger lg = new Logger(); lg.log(); } }\n` },
  2164. { lang: 'C# (var x = new T)', file: 'Svc.cs',
  2165. src: `class Logger { void Log() { int a = 1; } }\nclass Use { void Run() { var lg = new Logger(); lg.Log(); } }\n` },
  2166. { lang: 'Kotlin (val x = T())', file: 'Svc.kt',
  2167. src: `class Logger { fun log(): Int { return 1 } }\nfun use(): Int { val lg = Logger(); return lg.log() }\n` },
  2168. { lang: 'Swift (let x = T())', file: 'svc.swift',
  2169. src: `class Logger { func log() -> Int { return 1 } }\nfunc use() -> Int { let lg = Logger(); return lg.log() }\n` },
  2170. { lang: 'Go (x := T{})', file: 'svc.go',
  2171. src: `package a\ntype Logger struct{}\nfunc (l Logger) Log() int { return 1 }\nfunc Use() int { lg := Logger{}; return lg.Log() }\n` },
  2172. { lang: 'Rust (let x = T{})', file: 'svc.rs',
  2173. src: `pub struct Logger { n: i32 }\nimpl Logger { pub fn log(&self) -> i32 { self.n } }\npub fn use_it() -> i32 { let lg = Logger { n: 1 }; lg.log() }\n` },
  2174. { lang: 'Dart (var x = T())', file: 'svc.dart',
  2175. src: `class Logger { int log() { return 1; } }\nint use() { var lg = Logger(); return lg.log(); }\n` },
  2176. { lang: 'PHP ($x = new T)', file: 'svc.php',
  2177. src: `<?php\nclass Logger { function log() { return 1; } }\nfunction useIt() { $lg = new Logger(); return $lg->log(); }\n` },
  2178. { lang: 'Scala (val x = new T)', file: 'Svc.scala',
  2179. src: `class Logger { def log(): Int = 1 }\nobject A { def use(): Int = { val lg = new Logger(); lg.log() } }\n` },
  2180. { lang: 'Ruby (x = T.new)', file: 'svc.rb',
  2181. src: `class Logger\n def log\n 1\n end\nend\ndef use\n lg = Logger.new\n lg.log\nend\n` },
  2182. { lang: 'Lua (x = T.new(); x:log())', file: 'svc.lua',
  2183. src: `local Logger = {}\nLogger.__index = Logger\nfunction Logger.new() return setmetatable({}, Logger) end\nfunction Logger:log() return 1 end\nlocal function use() local lg = Logger.new(); return lg:log() end\nreturn use\n` },
  2184. { lang: 'Luau (x = T.new(); x:log())', file: 'svc.luau',
  2185. src: `local Logger = {}\nLogger.__index = Logger\nfunction Logger.new() return setmetatable({}, Logger) end\nfunction Logger:log(): number return 1 end\nlocal function use(): number local lg = Logger.new(); return lg:log() end\nreturn use\n` },
  2186. { lang: 'R (x <- T$new(); x$log())', file: 'svc.R',
  2187. src: `Logger <- R6::R6Class("Logger", public = list(log = function() 1))\nuse <- function() { lg <- Logger$new(); lg$log() }\n` },
  2188. { lang: 'Pascal (var x: T; x.Method)', file: 'svc.pas',
  2189. src: `unit A;\ninterface\ntype TLogger = class function Log: Integer; end;\nimplementation\nfunction TLogger.Log: Integer; begin Result := 1; end;\nprocedure Use;\nvar lg: TLogger;\nbegin\n lg := TLogger.Create;\n lg.Log;\nend;\nend.\n` },
  2190. ];
  2191. for (const c of cases) {
  2192. it(`resolves a local-variable method call — ${c.lang}`, async () => {
  2193. fs.writeFileSync(path.join(tempDir, c.file), c.src);
  2194. cg = await CodeGraph.init(tempDir, { index: true });
  2195. cg.resolveReferences();
  2196. const logMethod = cg
  2197. .getNodesByKind('method')
  2198. .find((n) => n.name.toLowerCase() === 'log');
  2199. expect(logMethod, `${c.lang}: log method should be indexed`).toBeDefined();
  2200. // The enclosing caller resolves through the local variable to `log`.
  2201. const callers = cg.getCallers(logMethod!.id).map((x) => x.node.name);
  2202. expect(
  2203. callers.length,
  2204. `${c.lang}: log should have a caller (got [${callers.join(', ')}])`,
  2205. ).toBeGreaterThan(0);
  2206. });
  2207. }
  2208. it('Ruby: builds receiver.method and keeps Foo.new as an instantiation', async () => {
  2209. // The Ruby extractor previously took the receiver as the callee and
  2210. // dropped the method name (`lg.log()` -> a call to `lg`). Now it builds
  2211. // `lg.log`, while `Logger.new` must still record an instantiation.
  2212. fs.writeFileSync(
  2213. path.join(tempDir, 'svc.rb'),
  2214. `class Logger\n def log\n 1\n end\nend\ndef run\n lg = Logger.new\n lg.log\nend\n`,
  2215. );
  2216. cg = await CodeGraph.init(tempDir, { index: true });
  2217. cg.resolveReferences();
  2218. const run = cg.getNodesByKind('function').find((n) => n.name === 'run')!;
  2219. const logMethod = cg.getNodesByKind('method').find((n) => n.name === 'log')!;
  2220. const logger = cg.getNodesByKind('class').find((n) => n.name === 'Logger')!;
  2221. const out = cg.getOutgoingEdges(run.id);
  2222. // lg.log resolved to the method (the receiver-type inference kicked in).
  2223. expect(out.some((e) => e.kind === 'calls' && e.target === logMethod.id)).toBe(true);
  2224. // Logger.new is still an instantiation of the class.
  2225. expect(out.some((e) => e.kind === 'instantiates' && e.target === logger.id)).toBe(true);
  2226. });
  2227. it('TypeScript: infers a typed-parameter receiver, disambiguating same-named methods (#1125)', async () => {
  2228. // A typed function parameter used as a receiver — `function use(lg: Logger)`
  2229. // — never matched the old TS/JS pattern (it required a const|let|var
  2230. // prefix), so `lg.log()` fell through to no edge once a second class shared
  2231. // the method name. Two ambiguous classes are load-bearing here: a
  2232. // single-class version resolves via a same-name fallback even without
  2233. // inference, so only the collision proves type inference actually fired.
  2234. fs.writeFileSync(
  2235. path.join(tempDir, 'svc.ts'),
  2236. `class Logger { log() { return 1; } }\n` +
  2237. `class Other { log() { return 2; } }\n` +
  2238. `export function use(lg: Logger) { return lg.log(); }\n` +
  2239. `export function useOther(o: Other) { return o.log(); }\n`,
  2240. );
  2241. cg = await CodeGraph.init(tempDir, { index: true });
  2242. cg.resolveReferences();
  2243. const classes = cg.getNodesByKind('class');
  2244. const logger = classes.find((n) => n.name === 'Logger')!;
  2245. const other = classes.find((n) => n.name === 'Other')!;
  2246. const logs = cg.getNodesByKind('method').filter((n) => n.name === 'log');
  2247. expect(logs.length, 'both log methods should be indexed').toBe(2);
  2248. // Associate each same-named `log` with its class by line containment.
  2249. const inClass = (m: (typeof logs)[number], c: typeof logger) =>
  2250. m.startLine >= c.startLine && m.startLine <= (c.endLine ?? c.startLine);
  2251. const loggerLog = logs.find((m) => inClass(m, logger))!;
  2252. const otherLog = logs.find((m) => inClass(m, other))!;
  2253. expect(loggerLog, "Logger's log").toBeDefined();
  2254. expect(otherLog, "Other's log").toBeDefined();
  2255. const loggerCallers = cg.getCallers(loggerLog.id).map((x) => x.node.name);
  2256. const otherCallers = cg.getCallers(otherLog.id).map((x) => x.node.name);
  2257. // Each typed-param call routes to its OWN class's method, not the other's.
  2258. expect(loggerCallers).toContain('use');
  2259. expect(loggerCallers).not.toContain('useOther');
  2260. expect(otherCallers).toContain('useOther');
  2261. expect(otherCallers).not.toContain('use');
  2262. });
  2263. // The same typed-parameter gap existed in every language whose pattern set
  2264. // only matched keyword-anchored locals (let/var/:=/= new), not the bare
  2265. // parameter form — Rust, Go, Dart, PHP (#1125). Each case: two classes
  2266. // sharing a method name + two functions taking one as a typed param; a
  2267. // correct fix routes each call to its OWN type's method (the collision is
  2268. // load-bearing — a single class resolves via the same-name fallback either
  2269. // way). Method↔type association is by qualifiedName, robust where the method
  2270. // lives outside the type's line range (Rust `impl`, Go method decl).
  2271. const typedParamCases: Array<{
  2272. lang: string; file: string; method: string; callerA: string; callerB: string; src: string;
  2273. }> = [
  2274. { lang: 'Rust (fn f(x: &T))', file: 'svc.rs', method: 'log', callerA: 'use_it', callerB: 'use_other',
  2275. src: `pub struct Logger { n: i32 }\nimpl Logger { pub fn log(&self) -> i32 { self.n } }\npub struct Other { n: i32 }\nimpl Other { pub fn log(&self) -> i32 { self.n } }\npub fn use_it(lg: &Logger) -> i32 { lg.log() }\npub fn use_other(o: &Other) -> i32 { o.log() }\n` },
  2276. { lang: 'Go (func f(x T))', file: 'svc.go', method: 'Log', callerA: 'UseIt', callerB: 'UseOther',
  2277. src: `package a\ntype Logger struct{}\nfunc (l Logger) Log() int { return 1 }\ntype Other struct{}\nfunc (o Other) Log() int { return 2 }\nfunc UseIt(lg Logger) int { return lg.Log() }\nfunc UseOther(o Other) int { return o.Log() }\n` },
  2278. { lang: 'Dart (T f(U x))', file: 'svc.dart', method: 'log', callerA: 'useIt', callerB: 'useOther',
  2279. src: `class Logger { int log() { return 1; } }\nclass Other { int log() { return 2; } }\nint useIt(Logger lg) { return lg.log(); }\nint useOther(Other o) { return o.log(); }\n` },
  2280. { lang: 'PHP (f(T $x))', file: 'svc.php', method: 'log', callerA: 'useIt', callerB: 'useOther',
  2281. src: `<?php\nclass Logger { function log() { return 1; } }\nclass Other { function log() { return 2; } }\nfunction useIt(Logger $lg) { return $lg->log(); }\nfunction useOther(Other $o) { return $o->log(); }\n` },
  2282. ];
  2283. for (const c of typedParamCases) {
  2284. it(`infers a typed-parameter receiver, disambiguating same-named methods — ${c.lang} (#1125)`, async () => {
  2285. fs.writeFileSync(path.join(tempDir, c.file), c.src);
  2286. cg = await CodeGraph.init(tempDir, { index: true });
  2287. cg.resolveReferences();
  2288. const methods = cg.getNodesByKind('method').filter((n) => n.name === c.method);
  2289. expect(methods.length, `${c.lang}: both ${c.method} methods indexed`).toBe(2);
  2290. const loggerLog = methods.find((m) => /Logger/.test(m.qualifiedName ?? ''));
  2291. const otherLog = methods.find((m) => /Other/.test(m.qualifiedName ?? ''));
  2292. expect(loggerLog, `${c.lang}: Logger's ${c.method}`).toBeDefined();
  2293. expect(otherLog, `${c.lang}: Other's ${c.method}`).toBeDefined();
  2294. const loggerCallers = cg.getCallers(loggerLog!.id).map((x) => x.node.name);
  2295. const otherCallers = cg.getCallers(otherLog!.id).map((x) => x.node.name);
  2296. expect(loggerCallers, `${c.lang}: Logger callers`).toContain(c.callerA);
  2297. expect(loggerCallers, `${c.lang}: Logger callers`).not.toContain(c.callerB);
  2298. expect(otherCallers, `${c.lang}: Other callers`).toContain(c.callerB);
  2299. expect(otherCallers, `${c.lang}: Other callers`).not.toContain(c.callerA);
  2300. });
  2301. }
  2302. // Lua/Luau: a PascalCase method call (`lg:Log()`, the Roblox convention)
  2303. // is the identical `receiver:Name` shape as a Luau type annotation, so it
  2304. // self-matched the annotation pattern on the call's own line and inferred
  2305. // "type = Log" (#1124). Two things are load-bearing in these fixtures:
  2306. // the declaration sits on an EARLIER line than the call (on one line,
  2307. // pattern order resolves it — the `.new` pattern wins first), and TWO
  2308. // classes share the method name (a single class resolves via the
  2309. // same-name fallback even when inference misfires). Luau's `useLogger`
  2310. // takes a typed param instead of calling `.new()`, pinning that the
  2311. // gated pattern still matches a genuine annotation.
  2312. const pascalMethodCases: Array<{ lang: string; file: string; src: string }> = [
  2313. { lang: 'Lua', file: 'svc.lua',
  2314. src: `local Logger = {}\nLogger.__index = Logger\nfunction Logger.new() return setmetatable({}, Logger) end\nfunction Logger:Log() return 1 end\n\nlocal Other = {}\nOther.__index = Other\nfunction Other.new() return setmetatable({}, Other) end\nfunction Other:Log() return 2 end\n\nlocal function useLogger()\n\tlocal lg = Logger.new()\n\treturn lg:Log()\nend\n\nlocal function useOther()\n\tlocal o = Other.new()\n\treturn o:Log()\nend\n\nreturn useLogger, useOther\n` },
  2315. { lang: 'Luau', file: 'svc.luau',
  2316. src: `local Logger = {}\nLogger.__index = Logger\nfunction Logger.new() return setmetatable({}, Logger) end\nfunction Logger:Log(): number return 1 end\n\nlocal Other = {}\nOther.__index = Other\nfunction Other.new() return setmetatable({}, Other) end\nfunction Other:Log(): number return 2 end\n\nlocal function useLogger(lg: Logger): number\n\treturn lg:Log()\nend\n\nlocal function useOther(): number\n\tlocal o = Other.new()\n\treturn o:Log()\nend\n\nreturn useLogger, useOther\n` },
  2317. ];
  2318. for (const c of pascalMethodCases) {
  2319. it(`resolves a PascalCase method call without self-matching the annotation pattern — ${c.lang} (#1124)`, async () => {
  2320. fs.writeFileSync(path.join(tempDir, c.file), c.src);
  2321. cg = await CodeGraph.init(tempDir, { index: true });
  2322. cg.resolveReferences();
  2323. const methods = cg.getNodesByKind('method').filter((n) => n.name === 'Log');
  2324. expect(methods.length, `${c.lang}: both Log methods indexed`).toBe(2);
  2325. const loggerLog = methods.find((m) => /Logger/.test(m.qualifiedName ?? ''));
  2326. const otherLog = methods.find((m) => /Other/.test(m.qualifiedName ?? ''));
  2327. expect(loggerLog, `${c.lang}: Logger's Log`).toBeDefined();
  2328. expect(otherLog, `${c.lang}: Other's Log`).toBeDefined();
  2329. const loggerCallers = cg.getCallers(loggerLog!.id).map((x) => x.node.name);
  2330. const otherCallers = cg.getCallers(otherLog!.id).map((x) => x.node.name);
  2331. expect(loggerCallers, `${c.lang}: Logger callers`).toContain('useLogger');
  2332. expect(loggerCallers, `${c.lang}: Logger callers`).not.toContain('useOther');
  2333. expect(otherCallers, `${c.lang}: Other callers`).toContain('useOther');
  2334. expect(otherCallers, `${c.lang}: Other callers`).not.toContain('useLogger');
  2335. });
  2336. }
  2337. });
  2338. describe('Name Matcher: kind bias for new ref kinds', () => {
  2339. const baseContext = (candidates: Node[]): ResolutionContext => ({
  2340. getNodesInFile: () => [],
  2341. getNodesByName: (name) => candidates.filter((c) => c.name === name),
  2342. getNodesByQualifiedName: () => [],
  2343. getNodesByKind: () => [],
  2344. fileExists: () => true,
  2345. readFile: () => null,
  2346. getProjectRoot: () => '/test',
  2347. getAllFiles: () => [],
  2348. getNodesByLowerName: () => [],
  2349. getImportMappings: () => [],
  2350. });
  2351. it('prefers a class candidate over a function for `instantiates` refs', () => {
  2352. // A class and a function share a name across the codebase.
  2353. // Without the kind bias, the function (which gets the +25 `calls`
  2354. // bonus historically applied to all candidates of that kind) would
  2355. // win. Now the instantiates branch reverses it.
  2356. const fn: Node = {
  2357. id: 'func:utils.ts:Logger:5', kind: 'function', name: 'Logger',
  2358. qualifiedName: 'utils.ts::Logger', filePath: 'utils.ts', language: 'typescript',
  2359. startLine: 5, endLine: 7, startColumn: 0, endColumn: 0, updatedAt: Date.now(),
  2360. };
  2361. const cls: Node = {
  2362. id: 'class:logger.ts:Logger:10', kind: 'class', name: 'Logger',
  2363. qualifiedName: 'logger.ts::Logger', filePath: 'logger.ts', language: 'typescript',
  2364. startLine: 10, endLine: 30, startColumn: 0, endColumn: 0, updatedAt: Date.now(),
  2365. };
  2366. const ref = {
  2367. fromNodeId: 'func:main.ts:bootstrap:1',
  2368. referenceName: 'Logger',
  2369. referenceKind: 'instantiates' as const,
  2370. line: 5, column: 0, filePath: 'main.ts', language: 'typescript' as const,
  2371. };
  2372. const result = matchReference(ref, baseContext([fn, cls]));
  2373. expect(result?.targetNodeId).toBe('class:logger.ts:Logger:10');
  2374. });
  2375. it('prefers a union candidate over a function for `instantiates` refs', () => {
  2376. const fn: Node = {
  2377. id: 'func:packet.cpp:Packet:5', kind: 'function', name: 'Packet',
  2378. qualifiedName: 'packet.cpp::Packet', filePath: 'packet.cpp', language: 'cpp',
  2379. startLine: 5, endLine: 7, startColumn: 0, endColumn: 0, updatedAt: Date.now(),
  2380. };
  2381. const union: Node = {
  2382. id: 'union:packet.hpp:Packet:10', kind: 'union', name: 'Packet',
  2383. qualifiedName: 'packet.hpp::Packet', filePath: 'packet.hpp', language: 'cpp',
  2384. startLine: 10, endLine: 14, startColumn: 0, endColumn: 0, updatedAt: Date.now(),
  2385. };
  2386. const ref = {
  2387. fromNodeId: 'func:main.cpp:initialize:1',
  2388. referenceName: 'Packet',
  2389. referenceKind: 'instantiates' as const,
  2390. line: 5, column: 0, filePath: 'main.cpp', language: 'cpp' as const,
  2391. };
  2392. const result = matchReference(ref, baseContext([fn, union]));
  2393. expect(result?.targetNodeId).toBe('union:packet.hpp:Packet:10');
  2394. });
  2395. it('prefers a function candidate over a non-function for `decorates` refs', () => {
  2396. const variable: Node = {
  2397. id: 'var:config.ts:Inject:5', kind: 'variable', name: 'Inject',
  2398. qualifiedName: 'config.ts::Inject', filePath: 'config.ts', language: 'typescript',
  2399. startLine: 5, endLine: 5, startColumn: 0, endColumn: 0, updatedAt: Date.now(),
  2400. };
  2401. const decorator: Node = {
  2402. id: 'func:di.ts:Inject:10', kind: 'function', name: 'Inject',
  2403. qualifiedName: 'di.ts::Inject', filePath: 'di.ts', language: 'typescript',
  2404. startLine: 10, endLine: 20, startColumn: 0, endColumn: 0, updatedAt: Date.now(),
  2405. };
  2406. const ref = {
  2407. fromNodeId: 'class:svc.ts:UserService:1',
  2408. referenceName: 'Inject',
  2409. referenceKind: 'decorates' as const,
  2410. line: 5, column: 0, filePath: 'svc.ts', language: 'typescript' as const,
  2411. };
  2412. const result = matchReference(ref, baseContext([variable, decorator]));
  2413. expect(result?.targetNodeId).toBe('func:di.ts:Inject:10');
  2414. });
  2415. });
  2416. describe('tsconfig path aliases', () => {
  2417. it('resolves an aliased import to the alias-mapped file (not a same-named file elsewhere)', async () => {
  2418. // Two same-named exports in different directories. Without alias
  2419. // resolution, name-matcher would pick whichever it finds first;
  2420. // with alias resolution, the import path uniquely picks one.
  2421. fs.mkdirSync(path.join(tempDir, 'src/utils'), { recursive: true });
  2422. fs.mkdirSync(path.join(tempDir, 'src/legacy'), { recursive: true });
  2423. fs.writeFileSync(
  2424. path.join(tempDir, 'src/utils/format.ts'),
  2425. `export function pickMe(): number { return 1; }\n`
  2426. );
  2427. fs.writeFileSync(
  2428. path.join(tempDir, 'src/legacy/format.ts'),
  2429. `export function pickMe(): number { return 99; }\n`
  2430. );
  2431. fs.writeFileSync(
  2432. path.join(tempDir, 'src/main.ts'),
  2433. `import { pickMe } from '@utils/format';\nexport function go(): number { return pickMe(); }\n`
  2434. );
  2435. fs.writeFileSync(
  2436. path.join(tempDir, 'tsconfig.json'),
  2437. JSON.stringify({
  2438. compilerOptions: {
  2439. baseUrl: './src',
  2440. paths: { '@utils/*': ['utils/*'] },
  2441. },
  2442. })
  2443. );
  2444. cg = await CodeGraph.init(tempDir, { index: true });
  2445. cg.resolveReferences();
  2446. // The two pickMe nodes live in different files. The aliased
  2447. // import should attach the call edge to the @utils-mapped one,
  2448. // not the legacy duplicate.
  2449. const all = cg.getNodesByKind('function').filter((n) => n.name === 'pickMe');
  2450. const utilsNode = all.find((n) => n.filePath === 'src/utils/format.ts');
  2451. const legacyNode = all.find((n) => n.filePath === 'src/legacy/format.ts');
  2452. expect(utilsNode).toBeDefined();
  2453. expect(legacyNode).toBeDefined();
  2454. const utilsCallers = cg.getCallers(utilsNode!.id);
  2455. const legacyCallers = cg.getCallers(legacyNode!.id);
  2456. expect(utilsCallers.length).toBeGreaterThan(0);
  2457. expect(utilsCallers.some((c) => c.node.filePath === 'src/main.ts')).toBe(true);
  2458. // The legacy node should NOT have a caller from src/main.ts —
  2459. // the alias correctly picked the utils version.
  2460. expect(legacyCallers.some((c) => c.node.filePath === 'src/main.ts')).toBe(false);
  2461. });
  2462. it('falls back gracefully when tsconfig is absent', async () => {
  2463. fs.mkdirSync(path.join(tempDir, 'src'), { recursive: true });
  2464. fs.writeFileSync(
  2465. path.join(tempDir, 'src/a.ts'),
  2466. `export function aFn(): void {}\n`
  2467. );
  2468. fs.writeFileSync(
  2469. path.join(tempDir, 'src/b.ts'),
  2470. `import { aFn } from './a';\nexport function bFn(): void { aFn(); }\n`
  2471. );
  2472. cg = await CodeGraph.init(tempDir, { index: true });
  2473. // No tsconfig present — index should still complete and the
  2474. // relative-import-based call edge should be created.
  2475. const aFn = cg.getNodesByKind('function').find((n) => n.name === 'aFn');
  2476. expect(aFn).toBeDefined();
  2477. const callers = cg.getCallers(aFn!.id);
  2478. expect(callers.some((c) => c.node.filePath === 'src/b.ts')).toBe(true);
  2479. });
  2480. });
  2481. describe('re-export chain following', () => {
  2482. it('chases a 3-hop barrel chain (wildcard → named → declaration)', async () => {
  2483. // main.ts → all.ts (wildcard) → index.ts (named) → auth.ts (declaration).
  2484. // Without chain following, `signIn` resolves to nothing because
  2485. // none of the barrel files declare it directly.
  2486. fs.mkdirSync(path.join(tempDir, 'src/services'), { recursive: true });
  2487. fs.writeFileSync(
  2488. path.join(tempDir, 'src/services/auth.ts'),
  2489. `export function signIn(): void {}\n`
  2490. );
  2491. fs.writeFileSync(
  2492. path.join(tempDir, 'src/services/index.ts'),
  2493. `export { signIn } from './auth';\n`
  2494. );
  2495. fs.writeFileSync(
  2496. path.join(tempDir, 'src/all.ts'),
  2497. `export * from './services/index';\n`
  2498. );
  2499. fs.writeFileSync(
  2500. path.join(tempDir, 'src/main.ts'),
  2501. `import { signIn } from './all';\nexport function go(): void { signIn(); }\n`
  2502. );
  2503. cg = await CodeGraph.init(tempDir, { index: true });
  2504. cg.resolveReferences();
  2505. const signInNode = cg
  2506. .getNodesByKind('function')
  2507. .find((n) => n.name === 'signIn' && n.filePath === 'src/services/auth.ts');
  2508. expect(signInNode).toBeDefined();
  2509. const callers = cg.getCallers(signInNode!.id);
  2510. expect(callers.some((c) => c.node.filePath === 'src/main.ts')).toBe(true);
  2511. });
  2512. it('follows a renamed named re-export (export { foo as bar } from ...)', async () => {
  2513. // The chase has to look up `foo` in the upstream module even
  2514. // though the importer asked for `bar` — exercises the rename
  2515. // branch of findExportedSymbol.
  2516. fs.mkdirSync(path.join(tempDir, 'src'), { recursive: true });
  2517. fs.writeFileSync(
  2518. path.join(tempDir, 'src/auth.ts'),
  2519. `export function signIn(): void {}\n`
  2520. );
  2521. fs.writeFileSync(
  2522. path.join(tempDir, 'src/index.ts'),
  2523. `export { signIn as login } from './auth';\n`
  2524. );
  2525. fs.writeFileSync(
  2526. path.join(tempDir, 'src/main.ts'),
  2527. `import { login } from './index';\nexport function go(): void { login(); }\n`
  2528. );
  2529. cg = await CodeGraph.init(tempDir, { index: true });
  2530. cg.resolveReferences();
  2531. const signInNode = cg
  2532. .getNodesByKind('function')
  2533. .find((n) => n.name === 'signIn' && n.filePath === 'src/auth.ts');
  2534. expect(signInNode).toBeDefined();
  2535. const callers = cg.getCallers(signInNode!.id);
  2536. expect(callers.some((c) => c.node.filePath === 'src/main.ts')).toBe(true);
  2537. });
  2538. it('follows a default re-export of a .svelte component (export { default as Foo } from ./RealButton.svelte) (#629)', async () => {
  2539. // The ubiquitous Svelte/React component-barrel form. The leaf is a
  2540. // .svelte component (extracted as kind 'component', the default
  2541. // export). The re-export ALIAS (`Foo`) deliberately differs from the
  2542. // component's real name (`RealButton`) so the name-matcher fallback
  2543. // can't coincidentally connect them — the only path to the edge is
  2544. // the import-chase, which must match a `component` (not just
  2545. // function/class) for the default export. Otherwise the
  2546. // consumer↔component edge is never created and `callers` returns a
  2547. // false 0.
  2548. fs.mkdirSync(path.join(tempDir, 'src/lib'), { recursive: true });
  2549. fs.writeFileSync(
  2550. path.join(tempDir, 'src/lib/RealButton.svelte'),
  2551. `<script lang="ts">\n export let label: string = '';\n</script>\n\n<button>{label}</button>\n`
  2552. );
  2553. fs.writeFileSync(
  2554. path.join(tempDir, 'src/lib/index.ts'),
  2555. `export { default as Foo } from './RealButton.svelte';\n`
  2556. );
  2557. fs.writeFileSync(
  2558. path.join(tempDir, 'src/Bar.svelte'),
  2559. `<script lang="ts">\n import { Foo } from './lib';\n</script>\n\n<Foo />\n`
  2560. );
  2561. cg = await CodeGraph.init(tempDir, { index: true });
  2562. cg.resolveReferences();
  2563. const fooNode = cg
  2564. .getNodesByKind('component')
  2565. .find((n) => n.name === 'RealButton' && n.filePath === 'src/lib/RealButton.svelte');
  2566. expect(fooNode).toBeDefined();
  2567. const callers = cg.getCallers(fooNode!.id);
  2568. expect(callers.some((c) => c.node.filePath === 'src/Bar.svelte')).toBe(true);
  2569. });
  2570. it('links an .astro page to the component and TS util it uses (#768)', async () => {
  2571. // The canonical Astro shape: a page imports a layout/component in
  2572. // frontmatter and uses it as a template tag; the component's template
  2573. // calls an imported .ts util. Both hops must produce graph edges or
  2574. // an Astro project is invisible to callers/impact.
  2575. fs.mkdirSync(path.join(tempDir, 'src/components'), { recursive: true });
  2576. fs.mkdirSync(path.join(tempDir, 'src/utils'), { recursive: true });
  2577. fs.mkdirSync(path.join(tempDir, 'src/pages'), { recursive: true });
  2578. fs.writeFileSync(
  2579. path.join(tempDir, 'src/utils/format.ts'),
  2580. `export function formatDate(d: Date): string { return d.toISOString(); }\n`
  2581. );
  2582. fs.writeFileSync(
  2583. path.join(tempDir, 'src/components/PostCard.astro'),
  2584. `---\nimport { formatDate } from '../utils/format';\nconst { date } = Astro.props;\n---\n<time>{formatDate(date)}</time>\n`
  2585. );
  2586. fs.writeFileSync(
  2587. path.join(tempDir, 'src/pages/index.astro'),
  2588. `---\nimport PostCard from '../components/PostCard.astro';\n---\n<PostCard date={new Date()} />\n`
  2589. );
  2590. cg = await CodeGraph.init(tempDir, { index: true });
  2591. cg.resolveReferences();
  2592. // Hop 1: page → component (template tag through the frontmatter import)
  2593. const cardNode = cg
  2594. .getNodesByKind('component')
  2595. .find((n) => n.name === 'PostCard' && n.filePath === 'src/components/PostCard.astro');
  2596. expect(cardNode).toBeDefined();
  2597. const cardCallers = cg.getCallers(cardNode!.id);
  2598. expect(cardCallers.some((c) => c.node.filePath === 'src/pages/index.astro')).toBe(true);
  2599. // Hop 2: component template call → .ts util
  2600. const fmtNode = cg
  2601. .getNodesByKind('function')
  2602. .find((n) => n.name === 'formatDate' && n.filePath === 'src/utils/format.ts');
  2603. expect(fmtNode).toBeDefined();
  2604. const fmtCallers = cg.getCallers(fmtNode!.id);
  2605. expect(fmtCallers.some((c) => c.node.filePath === 'src/components/PostCard.astro')).toBe(true);
  2606. });
  2607. it('resolves a bare directory import (import { x } from "." / "./") to index.ts (#629)', async () => {
  2608. // `import { helper } from '.'` (or './') must map to the
  2609. // directory's index.ts before the re-export chase can run. The
  2610. // barrel renames `realHelper` → `helper` so the name-matcher can't
  2611. // mask a path-resolution failure: only the bare-dir resolution +
  2612. // rename chase can connect the edge.
  2613. fs.mkdirSync(path.join(tempDir, 'src'), { recursive: true });
  2614. fs.writeFileSync(
  2615. path.join(tempDir, 'src/util.ts'),
  2616. `export function realHelper(): void {}\n`
  2617. );
  2618. fs.writeFileSync(
  2619. path.join(tempDir, 'src/index.ts'),
  2620. `export { realHelper as helper } from './util';\n`
  2621. );
  2622. fs.writeFileSync(
  2623. path.join(tempDir, 'src/main.ts'),
  2624. `import { helper } from '.';\nexport function go(): void { helper(); }\n`
  2625. );
  2626. fs.writeFileSync(
  2627. path.join(tempDir, 'src/main2.ts'),
  2628. `import { helper } from './';\nexport function go2(): void { helper(); }\n`
  2629. );
  2630. cg = await CodeGraph.init(tempDir, { index: true });
  2631. cg.resolveReferences();
  2632. const helperNode = cg
  2633. .getNodesByKind('function')
  2634. .find((n) => n.name === 'realHelper' && n.filePath === 'src/util.ts');
  2635. expect(helperNode).toBeDefined();
  2636. const callers = cg.getCallers(helperNode!.id);
  2637. expect(callers.some((c) => c.node.filePath === 'src/main.ts')).toBe(true);
  2638. expect(callers.some((c) => c.node.filePath === 'src/main2.ts')).toBe(true);
  2639. });
  2640. it('resolves a workspace package-subpath barrel (@scope/pkg/sub) to its index (#629)', async () => {
  2641. // bun/npm/pnpm workspace: `@scope/ui/widgets` → the `ui` package's
  2642. // `widgets/` subdir index, which re-exports a .svelte component.
  2643. // Alias `Thing` ≠ component `Widget` defeats the name-matcher, so
  2644. // only workspace-package resolution can connect the edge.
  2645. fs.mkdirSync(path.join(tempDir, 'packages/ui/widgets'), { recursive: true });
  2646. fs.writeFileSync(
  2647. path.join(tempDir, 'package.json'),
  2648. JSON.stringify({ name: 'root', private: true, workspaces: ['packages/*'] }, null, 2)
  2649. );
  2650. fs.writeFileSync(
  2651. path.join(tempDir, 'packages/ui/package.json'),
  2652. JSON.stringify({ name: '@scope/ui', version: '1.0.0' }, null, 2)
  2653. );
  2654. fs.writeFileSync(
  2655. path.join(tempDir, 'packages/ui/widgets/Widget.svelte'),
  2656. `<script lang="ts">\n export let label: string = '';\n</script>\n\n<button>{label}</button>\n`
  2657. );
  2658. fs.writeFileSync(
  2659. path.join(tempDir, 'packages/ui/widgets/index.ts'),
  2660. `export { default as Thing } from './Widget.svelte';\n`
  2661. );
  2662. fs.mkdirSync(path.join(tempDir, 'app'), { recursive: true });
  2663. fs.writeFileSync(
  2664. path.join(tempDir, 'app/App.svelte'),
  2665. `<script lang="ts">\n import { Thing } from '@scope/ui/widgets';\n</script>\n\n<Thing />\n`
  2666. );
  2667. cg = await CodeGraph.init(tempDir, { index: true });
  2668. cg.resolveReferences();
  2669. const buttonNode = cg
  2670. .getNodesByKind('component')
  2671. .find((n) => n.name === 'Widget' && n.filePath === 'packages/ui/widgets/Widget.svelte');
  2672. expect(buttonNode).toBeDefined();
  2673. const callers = cg.getCallers(buttonNode!.id);
  2674. expect(callers.some((c) => c.node.filePath === 'app/App.svelte')).toBe(true);
  2675. });
  2676. it('resolves a barrel import from a Vue SFC <script> block (#629)', async () => {
  2677. // The same import-resolution gaps (no SFC import mappings, no SFC
  2678. // extension list, barrel parsed in the consumer's language) broke
  2679. // Vue SFCs too. Guards the resolver-side generalization to `.vue`.
  2680. // The barrel renames `realRun` → `run` so only the import-chase (not
  2681. // the name-matcher) can connect the call.
  2682. fs.mkdirSync(path.join(tempDir, 'src'), { recursive: true });
  2683. fs.writeFileSync(
  2684. path.join(tempDir, 'src/util.ts'),
  2685. `export function realRun(): void {}\n`
  2686. );
  2687. fs.writeFileSync(
  2688. path.join(tempDir, 'src/index.ts'),
  2689. `export { realRun as run } from './util';\n`
  2690. );
  2691. fs.writeFileSync(
  2692. path.join(tempDir, 'src/App.vue'),
  2693. `<script lang="ts">\nimport { run } from './';\nexport default { mounted() { run(); } };\n</script>\n<template><div/></template>\n`
  2694. );
  2695. cg = await CodeGraph.init(tempDir, { index: true });
  2696. cg.resolveReferences();
  2697. const runNode = cg
  2698. .getNodesByKind('function')
  2699. .find((n) => n.name === 'realRun' && n.filePath === 'src/util.ts');
  2700. expect(runNode).toBeDefined();
  2701. const callers = cg.getCallers(runNode!.id);
  2702. expect(callers.some((c) => c.node.filePath === 'src/App.vue')).toBe(true);
  2703. });
  2704. it('follows a Vue component used in a <template> through a default re-export barrel (#629)', async () => {
  2705. // End-to-end Vue analogue of the Svelte case: the leaf is a `.vue`
  2706. // component re-exported under an alias (`Thing`) that differs from its
  2707. // real name (`Widget`), and the consumer uses it ONLY in markup
  2708. // (`<Thing />`). Requires both the new template-tag extraction AND the
  2709. // barrel default-export chase to connect the edge.
  2710. fs.mkdirSync(path.join(tempDir, 'src/lib'), { recursive: true });
  2711. fs.writeFileSync(
  2712. path.join(tempDir, 'src/lib/Widget.vue'),
  2713. `<script setup lang="ts">\ndefineProps<{ label?: string }>();\n</script>\n<template><button>x</button></template>\n`
  2714. );
  2715. fs.writeFileSync(
  2716. path.join(tempDir, 'src/lib/index.ts'),
  2717. `export { default as Thing } from './Widget.vue';\n`
  2718. );
  2719. fs.writeFileSync(
  2720. path.join(tempDir, 'src/App.vue'),
  2721. `<script setup lang="ts">\nimport { Thing } from './lib';\n</script>\n<template>\n <Thing />\n</template>\n`
  2722. );
  2723. cg = await CodeGraph.init(tempDir, { index: true });
  2724. cg.resolveReferences();
  2725. const widgetNode = cg
  2726. .getNodesByKind('component')
  2727. .find((n) => n.name === 'Widget' && n.filePath === 'src/lib/Widget.vue');
  2728. expect(widgetNode).toBeDefined();
  2729. const callers = cg.getCallers(widgetNode!.id);
  2730. expect(callers.some((c) => c.node.filePath === 'src/App.vue')).toBe(true);
  2731. });
  2732. });
  2733. describe('Literal receivers and nested-local scope (#1230)', () => {
  2734. // Two stacked fabrications: `", ".join(...)` (a builtin on a string
  2735. // literal) exact-matched a project function named `join` — one that was
  2736. // moreover nested inside a DIFFERENT function and thus lexically
  2737. // unreachable. Literal receivers now emit no call ref at all, and
  2738. // exact-match refuses candidates nested in a function the ref isn't in.
  2739. it("str-literal builtin calls don't bind to project symbols; nested locals only resolve from inside their container", async () => {
  2740. const tmpDir = fs.mkdtempSync(path.join(os.tmpdir(), 'codegraph-1230-'));
  2741. try {
  2742. fs.writeFileSync(
  2743. path.join(tmpDir, 'repro.py'),
  2744. `def format_fields(values):
  2745. def join(vals):
  2746. return "-".join(sorted(vals))
  2747. return join(values)
  2748. def report_missing(unresolved):
  2749. missing_list = ", ".join(sorted(unresolved))
  2750. return f"Could not resolve: {missing_list}"
  2751. `
  2752. );
  2753. const cg = CodeGraph.initSync(tmpDir);
  2754. await cg.indexAll();
  2755. const join = (await cg.searchNodes('join', { limit: 5 })).find(
  2756. (r) => r.node.kind === 'function' && r.node.name === 'join'
  2757. );
  2758. expect(join).toBeDefined();
  2759. // Exactly one caller: the enclosing format_fields. Neither
  2760. // report_missing (literal receiver) nor join itself (its own literal
  2761. // "-".join) may appear.
  2762. const callers = await cg.getCallers(join!.node.id);
  2763. expect(callers.map((c) => c.node.name)).toEqual(['format_fields']);
  2764. // report_missing has zero project callees.
  2765. const reportMissing = (await cg.searchNodes('report_missing', { limit: 5 })).find(
  2766. (r) => r.node.kind === 'function'
  2767. );
  2768. const callees = await cg.getCallees(reportMissing!.node.id);
  2769. expect(callees.filter((c) => c.node.name === 'join')).toHaveLength(0);
  2770. cg.close();
  2771. } finally {
  2772. fs.rmSync(tmpDir, { recursive: true, force: true });
  2773. }
  2774. }, 30000);
  2775. });
  2776. describe('Go field-chain receiver calls (#1276)', () => {
  2777. // `target.conn.Exec(...)` where `conn *sql.DB` used to emit a BARE `Exec`
  2778. // ref, which exact-matched the only local `Exec` — an unrelated
  2779. // interface's method — fabricating an internal dependency. Chained Go
  2780. // receivers now resolve exclusively via validated field-hop inference:
  2781. // external field types produce NO edge; in-project ones produce the
  2782. // correct edge (new recall).
  2783. it('external receiver types produce no edge; in-project field chains resolve correctly', async () => {
  2784. const tmpDir = fs.mkdtempSync(path.join(os.tmpdir(), 'codegraph-1276-'));
  2785. try {
  2786. fs.writeFileSync(path.join(tmpDir, 'go.mod'), 'module example.com/app\n\ngo 1.22\n');
  2787. fs.mkdirSync(path.join(tmpDir, 'flow'));
  2788. fs.writeFileSync(
  2789. path.join(tmpDir, 'flow', 'flow.go'),
  2790. `package flow
  2791. import "database/sql"
  2792. type InternalStore interface {
  2793. Exec(string, ...any) (sql.Result, error)
  2794. QueryRow(string, ...any) *sql.Row
  2795. }
  2796. type Target struct{ conn *sql.DB }
  2797. func (target *Target) Write() error {
  2798. _, err := target.conn.Exec("insert")
  2799. return err
  2800. }
  2801. func (target *Target) Read() *sql.Row {
  2802. return target.conn.QueryRow("select")
  2803. }
  2804. type Store struct{}
  2805. func (s *Store) Put(key string) {}
  2806. type Repo struct{ db *Store }
  2807. func (r *Repo) Save() {
  2808. r.db.Put("k")
  2809. }
  2810. `
  2811. );
  2812. const cg = CodeGraph.initSync(tmpDir);
  2813. await cg.indexAll();
  2814. // The unrelated local interface's methods have NO callers — the
  2815. // external sql.DB calls must not bind to them.
  2816. const execDecl = (await cg.searchNodes('Exec', { limit: 10 })).find(
  2817. (r) => r.node.kind === 'method'
  2818. );
  2819. if (execDecl) {
  2820. const execCallers = await cg.getCallers(execDecl.node.id);
  2821. expect(execCallers.map((c) => c.node.name)).not.toContain('Write');
  2822. }
  2823. const qrDecl = (await cg.searchNodes('QueryRow', { limit: 10 })).find(
  2824. (r) => r.node.kind === 'method'
  2825. );
  2826. if (qrDecl) {
  2827. const qrCallers = await cg.getCallers(qrDecl.node.id);
  2828. expect(qrCallers.map((c) => c.node.name)).not.toContain('Read');
  2829. }
  2830. // The in-project field chain resolves (validated), gaining an edge the
  2831. // bare-name era never produced.
  2832. const put = (await cg.searchNodes('Put', { limit: 10 })).find(
  2833. (r) => r.node.kind === 'method' && r.node.qualifiedName?.includes('Store')
  2834. );
  2835. expect(put).toBeDefined();
  2836. const putCallers = await cg.getCallers(put!.node.id);
  2837. expect(putCallers.map((c) => c.node.name)).toContain('Save');
  2838. cg.close();
  2839. } finally {
  2840. fs.rmSync(tmpDir, { recursive: true, force: true });
  2841. }
  2842. }, 30000);
  2843. it('unexported field types resolve; stdlib-qualified types never bind a same-named local decoy', async () => {
  2844. const tmpDir = fs.mkdtempSync(path.join(os.tmpdir(), 'codegraph-1276b-'));
  2845. try {
  2846. fs.writeFileSync(path.join(tmpDir, 'go.mod'), 'module example.com/b\n\ngo 1.22\n');
  2847. fs.writeFileSync(
  2848. path.join(tmpDir, 'm.go'),
  2849. `package m
  2850. import "net/http"
  2851. type node struct{}
  2852. func (n *node) InsertRoute(path string) {}
  2853. // A local type sharing the stdlib interface's name — the decoy the
  2854. // package-qualifier gate exists for.
  2855. type Handler func()
  2856. func (h Handler) ServeHTTP() {}
  2857. type Mux struct {
  2858. // the tree router lives below this comment (the comment must not
  2859. // donate a field type)
  2860. handler http.Handler
  2861. tree *node
  2862. }
  2863. func (mx *Mux) handle(path string) {
  2864. mx.tree.InsertRoute(path)
  2865. }
  2866. func (mx *Mux) dispatch() {
  2867. mx.handler.ServeHTTP(nil, nil)
  2868. }
  2869. `
  2870. );
  2871. const cg = CodeGraph.initSync(tmpDir);
  2872. await cg.indexAll();
  2873. // Unexported in-package field type: chain resolves (chi's mx.tree shape),
  2874. // and the doc comment above the field donates nothing.
  2875. const insert = (await cg.searchNodes('InsertRoute', { limit: 5 })).find(
  2876. (r) => r.node.kind === 'method'
  2877. );
  2878. expect(insert).toBeDefined();
  2879. const insertCallers = await cg.getCallers(insert!.node.id);
  2880. expect(insertCallers.map((c) => c.node.name)).toContain('handle');
  2881. // `handler http.Handler` is stdlib — the call must NOT bind to the
  2882. // local decoy `Handler.ServeHTTP`.
  2883. const serve = (await cg.searchNodes('ServeHTTP', { limit: 5 })).find(
  2884. (r) => r.node.kind === 'method'
  2885. );
  2886. if (serve) {
  2887. const serveCallers = await cg.getCallers(serve.node.id);
  2888. expect(serveCallers.map((c) => c.node.name)).not.toContain('dispatch');
  2889. }
  2890. cg.close();
  2891. } finally {
  2892. fs.rmSync(tmpDir, { recursive: true, force: true });
  2893. }
  2894. }, 30000);
  2895. });
  2896. describe('Imported singleton instance-method calls (#1292)', () => {
  2897. // `reproStore.notifyJoinGuildStatus()` after `import { reproStore }` used
  2898. // to emit its calls edge to the CONSTANT (resolvedBy:'import'), while the
  2899. // identical call in the defining file resolved to the method — so callers
  2900. // of the method missed every cross-file use. The import path now infers
  2901. // the value's type from its own declaration and resolves the member on it.
  2902. it('cross-file call through an imported singleton resolves to the class method', async () => {
  2903. const tmpDir = fs.mkdtempSync(path.join(os.tmpdir(), 'codegraph-1292-'));
  2904. try {
  2905. fs.mkdirSync(path.join(tmpDir, 'src'));
  2906. fs.writeFileSync(
  2907. path.join(tmpDir, 'src', 'store.ts'),
  2908. `export class ReproStore {
  2909. notifyJoinGuildStatus(): void {
  2910. console.log('notified');
  2911. }
  2912. }
  2913. export const reproStore = new ReproStore();
  2914. export function callInDefinitionFile(): void {
  2915. reproStore.notifyJoinGuildStatus();
  2916. }
  2917. `
  2918. );
  2919. fs.writeFileSync(
  2920. path.join(tmpDir, 'src', 'caller.ts'),
  2921. `import { reproStore } from './store';
  2922. export function callFromImportedFile(): void {
  2923. reproStore.notifyJoinGuildStatus();
  2924. }
  2925. `
  2926. );
  2927. const cg = CodeGraph.initSync(tmpDir);
  2928. await cg.indexAll();
  2929. const method = (await cg.searchNodes('notifyJoinGuildStatus', { limit: 5 })).find(
  2930. (r) => r.node.kind === 'method'
  2931. );
  2932. expect(method).toBeDefined();
  2933. // BOTH functions call the method — the cross-file one included.
  2934. const callers = await cg.getCallers(method!.node.id);
  2935. const callerNames = callers.map((c) => c.node.name).sort();
  2936. expect(callerNames).toContain('callInDefinitionFile');
  2937. expect(callerNames).toContain('callFromImportedFile');
  2938. cg.close();
  2939. } finally {
  2940. fs.rmSync(tmpDir, { recursive: true, force: true });
  2941. }
  2942. }, 30000);
  2943. });
  2944. describe('Object-literal namespace members (#1573)', () => {
  2945. // `export const api = { call() {…}, get: () => {…} }` used as the module's
  2946. // API surface: the members are plain functions with bare names inside the
  2947. // constant's extent, so `api.call()` resolved to nothing in the defining
  2948. // file and to the CONSTANT through an import — zero callers everywhere.
  2949. const setup = (files: Record<string, string>) => {
  2950. const tmpDir = fs.mkdtempSync(path.join(os.tmpdir(), 'codegraph-1573-'));
  2951. for (const [name, content] of Object.entries(files)) {
  2952. fs.mkdirSync(path.dirname(path.join(tmpDir, name)), { recursive: true });
  2953. fs.writeFileSync(path.join(tmpDir, name), content);
  2954. }
  2955. return tmpDir;
  2956. };
  2957. const callersOf = async (cg: CodeGraph, name: string, kind: string, filePath?: string) => {
  2958. const target = (await cg.searchNodes(name, { limit: 20 })).find(
  2959. (r) => r.node.kind === kind && r.node.name === name && (!filePath || r.node.filePath === filePath)
  2960. );
  2961. expect(target).toBeDefined();
  2962. return (await cg.getCallers(target!.node.id)).map((c) => c.node.name).sort();
  2963. };
  2964. it('resolves same-file and imported calls to the literal member, never to the constant (#1573)', async () => {
  2965. const tmpDir = setup({
  2966. 'a.ts': `export const obj = { m() { return 1; } };
  2967. export class C { static s() { return 2; } }
  2968. export function sameFileCallers() { return obj.m() + C.s(); }
  2969. `,
  2970. 'b.ts': `import { obj, C } from "./a";
  2971. export function crossFileCaller() { return obj.m() + C.s(); }
  2972. `,
  2973. // A same-named top-level function elsewhere must never be chosen.
  2974. 'decoy.ts': `export function m() { return 'decoy'; }
  2975. `,
  2976. });
  2977. try {
  2978. const cg = CodeGraph.initSync(tmpDir);
  2979. await cg.indexAll();
  2980. expect(await callersOf(cg, 'm', 'function', 'a.ts')).toEqual(['crossFileCaller', 'sameFileCallers']);
  2981. expect(await callersOf(cg, 'm', 'function', 'decoy.ts')).toEqual([]);
  2982. // The class static next to it resolves exactly as before (#825).
  2983. expect(await callersOf(cg, 's', 'method')).toEqual(['crossFileCaller', 'sameFileCallers']);
  2984. // The import edge no longer lands on the constant itself.
  2985. const obj = (await cg.searchNodes('obj', { limit: 5 })).find((r) => r.node.kind === 'constant');
  2986. expect(obj).toBeDefined();
  2987. const caller = (await cg.searchNodes('crossFileCaller', { limit: 5 })).find((r) => r.node.kind === 'function');
  2988. const toConstant = cg
  2989. .getOutgoingEdges(caller!.node.id)
  2990. .filter((e) => e.kind === 'calls' && e.target === obj!.node.id);
  2991. expect(toConstant).toHaveLength(0);
  2992. cg.close();
  2993. } finally {
  2994. fs.rmSync(tmpDir, { recursive: true, force: true });
  2995. }
  2996. }, 30000);
  2997. it('covers method and arrow-property members, and skips a declaration nested in a member body', async () => {
  2998. const tmpDir = setup({
  2999. 'src/api.ts': `export const api = {
  3000. call: () => { return 1; },
  3001. get() {
  3002. function call() { return 'nested in get, not a member'; }
  3003. return call();
  3004. },
  3005. };
  3006. `,
  3007. 'src/use.ts': `import { api } from './api';
  3008. export function useCall() { return api.call(); }
  3009. export function useGet() { return api.get(); }
  3010. `,
  3011. });
  3012. try {
  3013. const cg = CodeGraph.initSync(tmpDir);
  3014. await cg.indexAll();
  3015. const calls = (await cg.searchNodes('call', { limit: 20 }))
  3016. .map((r) => r.node)
  3017. .filter((n) => n.name === 'call' && n.filePath === 'src/api.ts' && (n.kind === 'function' || n.kind === 'method'));
  3018. // The member is the arrow on line 2; the nested declaration sits
  3019. // inside `get`'s body on line 4 and must never be taken for it.
  3020. const member = calls.find((n) => n.startLine === 2);
  3021. const nested = calls.find((n) => n.startLine === 4);
  3022. expect(member).toBeDefined();
  3023. expect(nested).toBeDefined();
  3024. expect((await cg.getCallers(member!.id)).map((c) => c.node.name)).toContain('useCall');
  3025. expect((await cg.getCallers(nested!.id)).map((c) => c.node.name)).not.toContain('useCall');
  3026. expect(await callersOf(cg, 'get', 'function')).toEqual(['useGet']);
  3027. cg.close();
  3028. } finally {
  3029. fs.rmSync(tmpDir, { recursive: true, force: true });
  3030. }
  3031. }, 30000);
  3032. it('leaves a non-literal value receiver on its existing path', async () => {
  3033. const tmpDir = setup({
  3034. 'src/mk.ts': `export function m() { return 'top-level, unrelated to obj'; }
  3035. export const obj = makeObj();
  3036. export function makeObj(): { m(): number } { return { m: () => 1 } as { m(): number }; }
  3037. export function localUse() { return obj.m(); }
  3038. `,
  3039. 'src/use.ts': `import { obj } from './mk';
  3040. export function remoteUse() { return obj.m(); }
  3041. `,
  3042. });
  3043. try {
  3044. const cg = CodeGraph.initSync(tmpDir);
  3045. await cg.indexAll();
  3046. // `obj` holds a call result, not a literal: the same-named top-level
  3047. // `m` lies outside its declaration, so containment finds nothing and
  3048. // both calls keep today's behavior (unresolved in the defining file;
  3049. // the constant edge through the import) rather than guessing.
  3050. expect(await callersOf(cg, 'm', 'function')).toEqual([]);
  3051. const obj = (await cg.searchNodes('obj', { limit: 5 })).find((r) => r.node.kind === 'constant');
  3052. const remote = (await cg.searchNodes('remoteUse', { limit: 5 })).find((r) => r.node.kind === 'function');
  3053. expect(
  3054. cg.getOutgoingEdges(remote!.node.id).some((e) => e.kind === 'calls' && e.target === obj!.node.id)
  3055. ).toBe(true);
  3056. cg.close();
  3057. } finally {
  3058. fs.rmSync(tmpDir, { recursive: true, force: true });
  3059. }
  3060. }, 30000);
  3061. });
  3062. describe('C++ namespace-qualified static method calls to out-of-line definitions (#1291)', () => {
  3063. // The issue's exact shape: nested types + out-of-line static method
  3064. // definition inside `namespace simulator { }` in the .cpp, called via the
  3065. // fully-qualified path from a different file. The definition's
  3066. // qualifiedName previously dropped the namespace (`ManifestStartup::Apply`
  3067. // vs the class's `simulator::ManifestStartup`), so `callers` came up empty.
  3068. it('resolves simulator::ManifestStartup::Apply(...) from another file', async () => {
  3069. const tmpDir = fs.mkdtempSync(path.join(os.tmpdir(), 'codegraph-1291-'));
  3070. try {
  3071. fs.writeFileSync(
  3072. path.join(tmpDir, 'manifest_startup.h'),
  3073. `#pragma once
  3074. namespace simulator {
  3075. class ManifestStartup {
  3076. public:
  3077. struct Input { int a; };
  3078. struct Output { int b; };
  3079. static Output Apply(const Input& input);
  3080. };
  3081. }
  3082. `
  3083. );
  3084. fs.writeFileSync(
  3085. path.join(tmpDir, 'manifest_startup.cpp'),
  3086. `#include "manifest_startup.h"
  3087. namespace simulator {
  3088. ManifestStartup::Output ManifestStartup::Apply(const Input& input) {
  3089. return Output{input.a};
  3090. }
  3091. }
  3092. `
  3093. );
  3094. fs.writeFileSync(
  3095. path.join(tmpDir, 'main.cpp'),
  3096. `#include "manifest_startup.h"
  3097. int run() {
  3098. const auto manifest_result = simulator::ManifestStartup::Apply({1});
  3099. return manifest_result.b;
  3100. }
  3101. `
  3102. );
  3103. const cg = CodeGraph.initSync(tmpDir);
  3104. await cg.indexAll();
  3105. const applyDefs = (await cg.searchNodes('Apply', { limit: 20 })).filter(
  3106. (r) => r.node.name === 'Apply' && r.node.kind === 'method'
  3107. );
  3108. expect(applyDefs.length).toBeGreaterThan(0);
  3109. const def = applyDefs.find((r) => r.node.filePath.endsWith('manifest_startup.cpp'));
  3110. expect(def).toBeDefined();
  3111. expect(def!.node.qualifiedName).toBe('simulator::ManifestStartup::Apply');
  3112. // The qualified cross-file call resolves: run() is a caller of Apply.
  3113. const callers = await cg.getCallers(def!.node.id);
  3114. expect(callers.map((c) => c.node.name)).toContain('run');
  3115. cg.close();
  3116. } finally {
  3117. fs.rmSync(tmpDir, { recursive: true, force: true });
  3118. }
  3119. }, 30000);
  3120. });
  3121. describe('C/C++ Import Resolution', () => {
  3122. afterEach(() => {
  3123. clearCppIncludeDirCache();
  3124. });
  3125. it('should resolve C include to header in same directory', () => {
  3126. const context: ResolutionContext = {
  3127. getNodesInFile: () => [],
  3128. getNodesByName: () => [],
  3129. getNodesByQualifiedName: () => [],
  3130. getNodesByKind: () => [],
  3131. fileExists: (p) => p === 'utils.h',
  3132. readFile: () => null,
  3133. getProjectRoot: () => '',
  3134. getAllFiles: () => ['utils.h', 'main.c'],
  3135. };
  3136. const result = resolveImportPath(
  3137. 'utils.h',
  3138. 'main.c',
  3139. 'c',
  3140. context
  3141. );
  3142. expect(result).toBe('utils.h');
  3143. });
  3144. it('should resolve C++ include with .hpp extension', () => {
  3145. const context: ResolutionContext = {
  3146. getNodesInFile: () => [],
  3147. getNodesByName: () => [],
  3148. getNodesByQualifiedName: () => [],
  3149. getNodesByKind: () => [],
  3150. fileExists: (p) => p === 'include/myclass.hpp',
  3151. readFile: () => null,
  3152. getProjectRoot: () => '',
  3153. getAllFiles: () => ['include/myclass.hpp', 'src/main.cpp'],
  3154. getCppIncludeDirs: () => ['include'],
  3155. };
  3156. const result = resolveImportPath(
  3157. 'myclass.hpp',
  3158. 'src/main.cpp',
  3159. 'cpp',
  3160. context
  3161. );
  3162. expect(result).toBe('include/myclass.hpp');
  3163. });
  3164. it('should resolve include with subdirectory path', () => {
  3165. const context: ResolutionContext = {
  3166. getNodesInFile: () => [],
  3167. getNodesByName: () => [],
  3168. getNodesByQualifiedName: () => [],
  3169. getNodesByKind: () => [],
  3170. fileExists: (p) => p === 'utils/helpers.h',
  3171. readFile: () => null,
  3172. getProjectRoot: () => '',
  3173. getAllFiles: () => ['utils/helpers.h', 'main.c'],
  3174. };
  3175. const result = resolveImportPath(
  3176. 'utils/helpers.h',
  3177. 'main.c',
  3178. 'c',
  3179. context
  3180. );
  3181. expect(result).toBe('utils/helpers.h');
  3182. });
  3183. it('should resolve include via include directories', () => {
  3184. const context: ResolutionContext = {
  3185. getNodesInFile: () => [],
  3186. getNodesByName: () => [],
  3187. getNodesByQualifiedName: () => [],
  3188. getNodesByKind: () => [],
  3189. fileExists: (p) => p === 'include/myheader.h',
  3190. readFile: () => null,
  3191. getProjectRoot: () => '',
  3192. getAllFiles: () => ['include/myheader.h', 'src/main.cpp'],
  3193. getCppIncludeDirs: () => ['include'],
  3194. };
  3195. const result = resolveImportPath(
  3196. 'myheader.h',
  3197. 'src/main.cpp',
  3198. 'cpp',
  3199. context
  3200. );
  3201. expect(result).toBe('include/myheader.h');
  3202. });
  3203. it('should resolve include trying multiple extensions', () => {
  3204. const context: ResolutionContext = {
  3205. getNodesInFile: () => [],
  3206. getNodesByName: () => [],
  3207. getNodesByQualifiedName: () => [],
  3208. getNodesByKind: () => [],
  3209. // myclass.h does not exist, but myclass.hpp does
  3210. fileExists: (p) => p === 'include/myclass.hpp',
  3211. readFile: () => null,
  3212. getProjectRoot: () => '',
  3213. getAllFiles: () => ['include/myclass.hpp', 'src/main.cpp'],
  3214. getCppIncludeDirs: () => ['include'],
  3215. };
  3216. const result = resolveImportPath(
  3217. 'myclass',
  3218. 'src/main.cpp',
  3219. 'cpp',
  3220. context
  3221. );
  3222. expect(result).toBe('include/myclass.hpp');
  3223. });
  3224. it('should return null for system headers', () => {
  3225. const context: ResolutionContext = {
  3226. getNodesInFile: () => [],
  3227. getNodesByName: () => [],
  3228. getNodesByQualifiedName: () => [],
  3229. getNodesByKind: () => [],
  3230. fileExists: () => true,
  3231. readFile: () => null,
  3232. getProjectRoot: () => '',
  3233. getAllFiles: () => [],
  3234. };
  3235. // C standard library header
  3236. expect(resolveImportPath('stdio.h', 'main.c', 'c', context)).toBeNull();
  3237. // C++ standard library header
  3238. expect(resolveImportPath('vector', 'main.cpp', 'cpp', context)).toBeNull();
  3239. // C++ C-wrapper header
  3240. expect(resolveImportPath('cstdio', 'main.cpp', 'cpp', context)).toBeNull();
  3241. });
  3242. it('should return null for single-component third-party paths that cannot be resolved', () => {
  3243. const context: ResolutionContext = {
  3244. getNodesInFile: () => [],
  3245. getNodesByName: () => [],
  3246. getNodesByQualifiedName: () => [],
  3247. getNodesByKind: () => [],
  3248. fileExists: () => false,
  3249. readFile: () => null,
  3250. getProjectRoot: () => '',
  3251. getAllFiles: () => [],
  3252. getCppIncludeDirs: () => [],
  3253. };
  3254. // Third-party bare header without path — not resolvable, returns null
  3255. const result = resolveImportPath(
  3256. 'openssl/ssl.h',
  3257. 'main.cpp',
  3258. 'cpp',
  3259. context
  3260. );
  3261. expect(result).toBeNull();
  3262. });
  3263. it('should not filter project headers with path separators', () => {
  3264. const context: ResolutionContext = {
  3265. getNodesInFile: () => [],
  3266. getNodesByName: () => [],
  3267. getNodesByQualifiedName: () => [],
  3268. getNodesByKind: () => [],
  3269. fileExists: (p) => p === 'mylib/utils.h',
  3270. readFile: () => null,
  3271. getProjectRoot: () => '',
  3272. getAllFiles: () => ['mylib/utils.h'],
  3273. };
  3274. // Path with separator should NOT be filtered as external
  3275. const result = resolveImportPath(
  3276. 'mylib/utils.h',
  3277. 'main.c',
  3278. 'c',
  3279. context
  3280. );
  3281. expect(result).toBe('mylib/utils.h');
  3282. });
  3283. it('should extract C/C++ import mappings from #include directives', () => {
  3284. const code = `#include <iostream>
  3285. #include "myheader.h"
  3286. #include "utils/helpers.hpp"`;
  3287. const mappings = extractImportMappings('main.cpp', code, 'cpp');
  3288. expect(mappings.length).toBe(3);
  3289. expect(mappings[0]).toEqual({
  3290. localName: 'iostream',
  3291. exportedName: '*',
  3292. source: 'iostream',
  3293. isDefault: false,
  3294. isNamespace: true,
  3295. });
  3296. expect(mappings[1]).toEqual({
  3297. localName: 'myheader',
  3298. exportedName: '*',
  3299. source: 'myheader.h',
  3300. isDefault: false,
  3301. isNamespace: true,
  3302. });
  3303. expect(mappings[2]).toEqual({
  3304. localName: 'helpers',
  3305. exportedName: '*',
  3306. source: 'utils/helpers.hpp',
  3307. isDefault: false,
  3308. isNamespace: true,
  3309. });
  3310. });
  3311. it('should discover include directories from compile_commands.json', () => {
  3312. // Create a temp project with compile_commands.json
  3313. const tempProject = fs.mkdtempSync(path.join(os.tmpdir(), 'codegraph-cpp-test-'));
  3314. try {
  3315. const compileDb = [
  3316. {
  3317. directory: tempProject,
  3318. command: 'g++ -Iinclude -Isrc/lib -isystem /usr/include -c src/main.cpp',
  3319. file: 'src/main.cpp',
  3320. },
  3321. ];
  3322. fs.writeFileSync(
  3323. path.join(tempProject, 'compile_commands.json'),
  3324. JSON.stringify(compileDb)
  3325. );
  3326. // Create the include dirs so they exist
  3327. fs.mkdirSync(path.join(tempProject, 'include'), { recursive: true });
  3328. fs.mkdirSync(path.join(tempProject, 'src', 'lib'), { recursive: true });
  3329. clearCppIncludeDirCache();
  3330. const dirs = loadCppIncludeDirs(tempProject);
  3331. // Should find include and src/lib (relative to project root)
  3332. // /usr/include is absolute and outside project, should be excluded
  3333. expect(dirs).toContain('include');
  3334. expect(dirs).toContain('src/lib');
  3335. expect(dirs.some(d => d.includes('usr'))).toBe(false);
  3336. } finally {
  3337. fs.rmSync(tempProject, { recursive: true });
  3338. }
  3339. });
  3340. it('should fall back to heuristic include dirs when no compile_commands.json', () => {
  3341. const tempProject = fs.mkdtempSync(path.join(os.tmpdir(), 'codegraph-cpp-test-'));
  3342. try {
  3343. // Create include/ and src/ directories with headers
  3344. fs.mkdirSync(path.join(tempProject, 'include'), { recursive: true });
  3345. fs.writeFileSync(path.join(tempProject, 'include', 'types.h'), '');
  3346. fs.mkdirSync(path.join(tempProject, 'src'), { recursive: true });
  3347. fs.writeFileSync(path.join(tempProject, 'src', 'main.cpp'), '');
  3348. // Create a directory without headers — should not be included
  3349. fs.mkdirSync(path.join(tempProject, 'docs'), { recursive: true });
  3350. clearCppIncludeDirCache();
  3351. const dirs = loadCppIncludeDirs(tempProject);
  3352. expect(dirs).toContain('include');
  3353. expect(dirs).toContain('src');
  3354. expect(dirs).not.toContain('docs');
  3355. } finally {
  3356. fs.rmSync(tempProject, { recursive: true });
  3357. }
  3358. });
  3359. // Documents the cross-language `.h` behavior. Objective-C and C++ share
  3360. // the `.h` extension, so in a mixed iOS-style project an Obj-C header
  3361. // dir gets claimed as a C/C++ include dir too. That's intentional — a
  3362. // C++ file legitimately can `#include "Foo.h"` against an Obj-C header
  3363. // (Obj-C++ / .mm callers), and false-positive inclusion is far cheaper
  3364. // than missing real resolutions. The test pins this so a later
  3365. // "exclude objc dirs" refactor breaks loudly and reviewers see the
  3366. // trade-off explicitly.
  3367. it('heuristic claims any top-level dir containing .h files, including Obj-C', () => {
  3368. const tempProject = fs.mkdtempSync(path.join(os.tmpdir(), 'codegraph-cpp-test-'));
  3369. try {
  3370. // C++ side: an `cppmod` dir with a .hpp (C++-only extension)
  3371. fs.mkdirSync(path.join(tempProject, 'cppmod'), { recursive: true });
  3372. fs.writeFileSync(path.join(tempProject, 'cppmod', 'shared.hpp'), '');
  3373. // Obj-C side: an `iosmod` dir with .h + .m (no .cpp/.hpp).
  3374. fs.mkdirSync(path.join(tempProject, 'iosmod'), { recursive: true });
  3375. fs.writeFileSync(path.join(tempProject, 'iosmod', 'View.h'), '');
  3376. fs.writeFileSync(path.join(tempProject, 'iosmod', 'View.m'), '');
  3377. clearCppIncludeDirCache();
  3378. const dirs = loadCppIncludeDirs(tempProject);
  3379. // Both included — Obj-C dirs are intentionally allowed.
  3380. expect(dirs).toContain('cppmod');
  3381. expect(dirs).toContain('iosmod');
  3382. } finally {
  3383. fs.rmSync(tempProject, { recursive: true });
  3384. }
  3385. });
  3386. // End-to-end: ensure `#include "X.h"` produces a file→file `imports` edge
  3387. // in the actual indexing pipeline (not just a phantom file→import-node
  3388. // edge). This pins the include-dir resolution path so the headline PR
  3389. // feature can't silently regress to a no-op in the indexing flow.
  3390. it('connects #include to the real header file via include-dir scan (end-to-end)', async () => {
  3391. const tempProject = fs.mkdtempSync(path.join(os.tmpdir(), 'codegraph-cpp-e2e-'));
  3392. try {
  3393. fs.mkdirSync(path.join(tempProject, 'include'), { recursive: true });
  3394. fs.mkdirSync(path.join(tempProject, 'src'), { recursive: true });
  3395. fs.writeFileSync(
  3396. path.join(tempProject, 'include', 'utils.h'),
  3397. `#ifndef UTILS_H\n#define UTILS_H\nint add(int, int);\n#endif\n`
  3398. );
  3399. fs.writeFileSync(
  3400. path.join(tempProject, 'src', 'main.cpp'),
  3401. `#include "utils.h"\n#include <vector>\nint main(){ return add(1,2); }\n`
  3402. );
  3403. clearCppIncludeDirCache();
  3404. cg = await CodeGraph.init(tempProject, { index: true });
  3405. // Sanity: file nodes exist for the header and the cpp.
  3406. const allFiles = cg.getStats();
  3407. expect(allFiles.fileCount).toBe(2);
  3408. // The `#include "utils.h"` edge should target the real
  3409. // `include/utils.h` file node — not a floating `import` node
  3410. // living inside main.cpp.
  3411. const db = DatabaseConnection.open(path.join(tempProject, '.codegraph', 'codegraph.db'));
  3412. const rows = db.getDb().prepare(`
  3413. select dst.kind as dstKind, dst.file_path as dstPath
  3414. from edges e
  3415. join nodes src on e.source = src.id
  3416. join nodes dst on e.target = dst.id
  3417. where e.kind = 'imports'
  3418. and src.kind = 'file'
  3419. and src.file_path = 'src/main.cpp'
  3420. `).all() as Array<{ dstKind: string; dstPath: string }>;
  3421. const resolvedToHeader = rows.find(
  3422. (r) => r.dstKind === 'file' && r.dstPath === 'include/utils.h'
  3423. );
  3424. expect(resolvedToHeader, 'main.cpp → include/utils.h imports edge missing').toBeDefined();
  3425. // `<vector>` should NOT produce a file edge — it's a stdlib header.
  3426. const stdlibFile = rows.find(
  3427. (r) => r.dstKind === 'file' && r.dstPath && r.dstPath.endsWith('vector')
  3428. );
  3429. expect(stdlibFile).toBeUndefined();
  3430. } finally {
  3431. fs.rmSync(tempProject, { recursive: true, force: true });
  3432. }
  3433. });
  3434. });
  3435. describe('C++ templated base-class inheritance (#1043)', () => {
  3436. // A class deriving from a TEMPLATE — `class D : public Base<int>` (or a CRTP
  3437. // `class W : public CRTPBase<W>`, or a qualified `class Q : public ns::Tpl<int>`)
  3438. // recorded its base as the full instantiation text (`Base<int>`), which never
  3439. // name-matched the template, indexed as the bare node `Base`. The `<…>` args
  3440. // are now stripped so the `extends` edge resolves end-to-end.
  3441. it('resolves an extends edge to a templated base (plain, CRTP, struct, multi-base)', async () => {
  3442. fs.writeFileSync(
  3443. path.join(tempDir, 'lib.hpp'),
  3444. `#pragma once
  3445. template<typename T> class Base { public: void foo(); };
  3446. template<typename Derived> class CRTPBase {};
  3447. class Plain {};
  3448. class Widget : public Base<int> {}; // plain template base
  3449. class App : public CRTPBase<App> {}; // CRTP (curiously-recurring)
  3450. struct Node : public Base<double> {}; // struct inheriting a template
  3451. class Both : public Base<char>, public Plain {}; // templated + plain in one clause
  3452. `
  3453. );
  3454. cg = await CodeGraph.init(tempDir, { index: true });
  3455. const db = DatabaseConnection.open(path.join(tempDir, '.codegraph', 'codegraph.db'));
  3456. const edges = db
  3457. .getDb()
  3458. .prepare(
  3459. `select src.name as fromName, dst.name as toName
  3460. from edges e
  3461. join nodes src on e.source = src.id
  3462. join nodes dst on e.target = dst.id
  3463. where e.kind = 'extends'`
  3464. )
  3465. .all() as Array<{ fromName: string; toName: string }>;
  3466. const has = (from: string, to: string) =>
  3467. edges.some((r) => r.fromName === from && r.toName === to);
  3468. // Every templated base now resolves to the bare template node.
  3469. expect(has('Widget', 'Base'), 'Widget : Base<int>').toBe(true);
  3470. expect(has('App', 'CRTPBase'), 'App : CRTPBase<App> (CRTP)').toBe(true);
  3471. expect(has('Node', 'Base'), 'struct Node : Base<double>').toBe(true);
  3472. // A mixed clause resolves BOTH the templated and the plain base.
  3473. expect(has('Both', 'Base'), 'Both : Base<char>').toBe(true);
  3474. expect(has('Both', 'Plain'), 'Both : Plain (non-templated, regression guard)').toBe(true);
  3475. });
  3476. });
  3477. describe('PHP Include Resolution', () => {
  3478. it('isPhpIncludePathRef distinguishes include paths from namespace use (#660)', () => {
  3479. const mk = (name: string, over: Partial<UnresolvedRef> = {}): UnresolvedRef => ({
  3480. fromNodeId: 'f', referenceName: name, referenceKind: 'imports',
  3481. line: 1, column: 0, filePath: 'x.php', language: 'php', ...over,
  3482. });
  3483. // include paths: contain a slash or a file extension
  3484. expect(isPhpIncludePathRef(mk('lib.php'))).toBe(true);
  3485. expect(isPhpIncludePathRef(mk('inc/db.php'))).toBe(true);
  3486. expect(isPhpIncludePathRef(mk('../config.php'))).toBe(true);
  3487. // namespace use symbols: a bare class (Closure) or FQN — never a path,
  3488. // so they must NOT be treated as includes (would mis-connect to a
  3489. // same-named Closure.php / Bar.php file).
  3490. expect(isPhpIncludePathRef(mk('Closure'))).toBe(false);
  3491. expect(isPhpIncludePathRef(mk('PDO'))).toBe(false);
  3492. expect(isPhpIncludePathRef(mk('App\\Foo\\Bar'))).toBe(false);
  3493. // scoped to PHP imports only
  3494. expect(isPhpIncludePathRef(mk('lib.php', { language: 'c' }))).toBe(false);
  3495. expect(isPhpIncludePathRef(mk('lib.php', { referenceKind: 'calls' }))).toBe(false);
  3496. });
  3497. it('resolves require_once to a file→file imports edge (#660)', async () => {
  3498. const tempProject = fs.mkdtempSync(path.join(os.tmpdir(), 'codegraph-php-e2e-'));
  3499. try {
  3500. fs.mkdirSync(path.join(tempProject, 'src'), { recursive: true });
  3501. fs.writeFileSync(
  3502. path.join(tempProject, 'src', 'lib.php'),
  3503. `<?php\nfunction greet() { return "hi"; }\n`
  3504. );
  3505. fs.writeFileSync(
  3506. path.join(tempProject, 'src', 'page.php'),
  3507. `<?php\nrequire_once("lib.php");\necho greet();\n`
  3508. );
  3509. cg = await CodeGraph.init(tempProject, { index: true });
  3510. // reporter's repro: page.php's `require_once("lib.php")` must resolve
  3511. // to the real src/lib.php file node — a file→file `imports` edge, so
  3512. // callers(lib.php) now includes page.php.
  3513. const db = DatabaseConnection.open(path.join(tempProject, '.codegraph', 'codegraph.db'));
  3514. const rows = db.getDb().prepare(`
  3515. select dst.kind as dstKind, dst.file_path as dstPath
  3516. from edges e
  3517. join nodes src on e.source = src.id
  3518. join nodes dst on e.target = dst.id
  3519. where e.kind = 'imports'
  3520. and src.kind = 'file'
  3521. and src.file_path = 'src/page.php'
  3522. `).all() as Array<{ dstKind: string; dstPath: string }>;
  3523. const resolved = rows.find(
  3524. (r) => r.dstKind === 'file' && r.dstPath === 'src/lib.php'
  3525. );
  3526. expect(resolved, 'page.php → src/lib.php imports edge missing').toBeDefined();
  3527. } finally {
  3528. fs.rmSync(tempProject, { recursive: true, force: true });
  3529. }
  3530. });
  3531. it('resolves a subdirectory include path to the correct file (#660)', async () => {
  3532. const tempProject = fs.mkdtempSync(path.join(os.tmpdir(), 'codegraph-php-subdir-'));
  3533. try {
  3534. fs.mkdirSync(path.join(tempProject, 'inc'), { recursive: true });
  3535. fs.writeFileSync(
  3536. path.join(tempProject, 'inc', 'db.php'),
  3537. `<?php\nfunction query() { return 1; }\n`
  3538. );
  3539. fs.writeFileSync(
  3540. path.join(tempProject, 'index.php'),
  3541. `<?php\nrequire "inc/db.php";\nquery();\n`
  3542. );
  3543. cg = await CodeGraph.init(tempProject, { index: true });
  3544. const db = DatabaseConnection.open(path.join(tempProject, '.codegraph', 'codegraph.db'));
  3545. const rows = db.getDb().prepare(`
  3546. select dst.kind as dstKind, dst.file_path as dstPath
  3547. from edges e
  3548. join nodes src on e.source = src.id
  3549. join nodes dst on e.target = dst.id
  3550. where e.kind = 'imports'
  3551. and src.kind = 'file'
  3552. and src.file_path = 'index.php'
  3553. `).all() as Array<{ dstKind: string; dstPath: string }>;
  3554. expect(
  3555. rows.find((r) => r.dstKind === 'file' && r.dstPath === 'inc/db.php'),
  3556. 'index.php → inc/db.php imports edge missing'
  3557. ).toBeDefined();
  3558. } finally {
  3559. fs.rmSync(tempProject, { recursive: true, force: true });
  3560. }
  3561. });
  3562. it('does not mis-connect an unresolvable include to a same-named file elsewhere (#660)', async () => {
  3563. const tempProject = fs.mkdtempSync(path.join(os.tmpdir(), 'codegraph-php-misresolve-'));
  3564. try {
  3565. // app/page.php's `require "inc/db.php"` resolves relative to app/, where
  3566. // inc/db.php does NOT exist. A same-named lib/inc/db.php exists elsewhere
  3567. // but is unrelated — no edge should be created (a wrong edge is worse
  3568. // than a missing one).
  3569. fs.mkdirSync(path.join(tempProject, 'app'), { recursive: true });
  3570. fs.mkdirSync(path.join(tempProject, 'lib', 'inc'), { recursive: true });
  3571. fs.writeFileSync(
  3572. path.join(tempProject, 'lib', 'inc', 'db.php'),
  3573. `<?php\nfunction unrelated() {}\n`
  3574. );
  3575. fs.writeFileSync(
  3576. path.join(tempProject, 'app', 'page.php'),
  3577. `<?php\nrequire "inc/db.php";\n`
  3578. );
  3579. cg = await CodeGraph.init(tempProject, { index: true });
  3580. const db = DatabaseConnection.open(path.join(tempProject, '.codegraph', 'codegraph.db'));
  3581. const rows = db.getDb().prepare(`
  3582. select dst.kind as dstKind, dst.file_path as dstPath
  3583. from edges e
  3584. join nodes src on e.source = src.id
  3585. join nodes dst on e.target = dst.id
  3586. where e.kind = 'imports'
  3587. and src.kind = 'file'
  3588. and src.file_path = 'app/page.php'
  3589. `).all() as Array<{ dstKind: string; dstPath: string }>;
  3590. expect(
  3591. rows.find((r) => r.dstKind === 'file' && r.dstPath === 'lib/inc/db.php'),
  3592. 'app/page.php must NOT mis-connect to unrelated lib/inc/db.php'
  3593. ).toBeUndefined();
  3594. } finally {
  3595. fs.rmSync(tempProject, { recursive: true, force: true });
  3596. }
  3597. });
  3598. });
  3599. describe('C++ chained-call receiver resolution (#645)', () => {
  3600. async function indexCpp(files: Record<string, string>): Promise<void> {
  3601. for (const [name, content] of Object.entries(files)) {
  3602. fs.writeFileSync(path.join(tempDir, name), content);
  3603. }
  3604. cg = await CodeGraph.init(tempDir, { index: true });
  3605. }
  3606. function callerNamesOf(qualifiedName: string): string[] {
  3607. const target = cg.getNodesByKind('method').find((n) => n.qualifiedName === qualifiedName);
  3608. if (!target) return [];
  3609. const names = cg
  3610. .getIncomingEdges(target.id)
  3611. .filter((e) => e.kind === 'calls')
  3612. .map((e) => cg.getNode(e.source)?.name)
  3613. .filter((n): n is string => !!n);
  3614. return [...new Set(names)].sort();
  3615. }
  3616. it('resolves singleton chains and auto locals to the right class, never the first-sorted one', async () => {
  3617. // Two classes share writeLog; Logger sorts first so it wins any name-only
  3618. // tie. All three call forms target Metrics.
  3619. await indexCpp({
  3620. 'logger.hpp': `#pragma once
  3621. #include <string>
  3622. class Logger { public: static Logger& instance(); void writeLog(const std::string&); };
  3623. class Metrics { public: static Metrics& instance(); void writeLog(const std::string&); };
  3624. `,
  3625. 'impl.cpp': `#include "logger.hpp"
  3626. Logger& Logger::instance() { static Logger l; return l; }
  3627. Metrics& Metrics::instance() { static Metrics m; return m; }
  3628. void Logger::writeLog(const std::string&) {}
  3629. void Metrics::writeLog(const std::string&) {}
  3630. `,
  3631. 'app.cpp': `#include "logger.hpp"
  3632. void a() { Metrics::instance().writeLog("x"); } // chained singleton
  3633. void b() { auto& m = Metrics::instance(); m.writeLog("x"); } // stored in auto
  3634. void c() { Metrics& m = Metrics::instance(); m.writeLog("x"); } // explicit type
  3635. `,
  3636. });
  3637. expect(callerNamesOf('Metrics::writeLog')).toEqual(['a', 'b', 'c']);
  3638. expect(callerNamesOf('Logger::writeLog')).toEqual([]);
  3639. });
  3640. it('resolves factories, free-function factories, and member chains via the inner call return type', async () => {
  3641. await indexCpp({
  3642. 'types.hpp': `#pragma once
  3643. #include <memory>
  3644. struct Widget { void draw(); };
  3645. struct Session { void run(); };
  3646. struct View { void render(); };
  3647. class WidgetFactory { public: static Widget create(); };
  3648. class Manager { public: View view(); };
  3649. Session* openSession();
  3650. // Decoy that sorts first and has all three methods — must never win.
  3651. struct Aaa { void draw(); void run(); void render(); };
  3652. `,
  3653. 'impl.cpp': `#include "types.hpp"
  3654. void Widget::draw() {}
  3655. void Session::run() {}
  3656. void View::render() {}
  3657. void Aaa::draw() {}
  3658. void Aaa::run() {}
  3659. void Aaa::render() {}
  3660. Widget WidgetFactory::create() { return Widget(); }
  3661. View Manager::view() { return View(); }
  3662. Session* openSession() { return nullptr; }
  3663. `,
  3664. 'app.cpp': `#include "types.hpp"
  3665. void factory() { WidgetFactory::create().draw(); } // -> Widget::draw
  3666. void freefunc() { openSession()->run(); } // -> Session::run
  3667. void member() { Manager mgr; mgr.view().render(); } // -> View::render
  3668. void makeUnique() { auto w = std::make_unique<Widget>(); w->draw(); } // -> Widget::draw
  3669. `,
  3670. });
  3671. expect(callerNamesOf('Widget::draw')).toEqual(['factory', 'makeUnique']);
  3672. expect(callerNamesOf('Session::run')).toEqual(['freefunc']);
  3673. expect(callerNamesOf('View::render')).toEqual(['member']);
  3674. // The first-sorted decoy never captures any of them.
  3675. expect(callerNamesOf('Aaa::draw')).toEqual([]);
  3676. expect(callerNamesOf('Aaa::run')).toEqual([]);
  3677. expect(callerNamesOf('Aaa::render')).toEqual([]);
  3678. });
  3679. it('creates NO edge when the inferred type lacks the method (silent miss, not a wrong edge)', async () => {
  3680. await indexCpp({
  3681. 'types.hpp': `#pragma once
  3682. struct Widget { void draw(); };
  3683. struct Other { void onlyOther(); };
  3684. class WidgetFactory { public: static Widget create(); };
  3685. `,
  3686. 'impl.cpp': `#include "types.hpp"
  3687. void Widget::draw() {}
  3688. void Other::onlyOther() {}
  3689. Widget WidgetFactory::create() { return Widget(); }
  3690. `,
  3691. 'app.cpp': `#include "types.hpp"
  3692. // Widget has no onlyOther() — must produce NO edge, never a wrong one to Other.
  3693. void wrong() { WidgetFactory::create().onlyOther(); }
  3694. `,
  3695. });
  3696. expect(callerNamesOf('Other::onlyOther')).toEqual([]);
  3697. });
  3698. });
  3699. describe('C++ explicit operator-call resolution (#1247)', () => {
  3700. // `a.operator+(b)` produced no calls edge: the operator_name lands in an
  3701. // ERROR node (never a field_expression callee), so the extractor emitted a
  3702. // ref named just `a`. With the ERROR-node recovery it emits `a.operator+`,
  3703. // and matchMethodCall (dot pattern extended to admit operator method parts)
  3704. // resolves it through receiver-type inference. Infix `a + b` / `a[i]` need
  3705. // real type inference and are out of scope here (#1258).
  3706. async function indexCpp(files: Record<string, string>): Promise<void> {
  3707. for (const [name, content] of Object.entries(files)) {
  3708. fs.writeFileSync(path.join(tempDir, name), content);
  3709. }
  3710. cg = await CodeGraph.init(tempDir, { index: true });
  3711. }
  3712. function callerNamesOf(qualifiedName: string): string[] {
  3713. const target = cg.getNodesByKind('method').find((n) => n.qualifiedName === qualifiedName);
  3714. if (!target) return [];
  3715. const names = cg
  3716. .getIncomingEdges(target.id)
  3717. .filter((e) => e.kind === 'calls')
  3718. .map((e) => cg.getNode(e.source)?.name)
  3719. .filter((n): n is string => !!n);
  3720. return [...new Set(names)].sort();
  3721. }
  3722. it('resolves explicit operator calls to the receiver type, never a same-named decoy', async () => {
  3723. // Aaa sorts first and declares the same operators — only receiver-type
  3724. // inference (const V& a → V) can pick V, so a name-only tie can't win.
  3725. await indexCpp({
  3726. 'optest.cpp': `struct Aaa {
  3727. Aaa operator+(const Aaa& o) const { return o; }
  3728. Aaa operator[](int i) const { return *this; }
  3729. };
  3730. struct V {
  3731. int x;
  3732. V operator+(const V& o) const { return V{x + o.x}; }
  3733. V operator[](int i) const { return V{x + i}; }
  3734. int get() const { return x; }
  3735. };
  3736. int plainCaller(const V& a) { return a.get(); }
  3737. V explicitCaller(const V& a, const V& b) { return a.operator+(b); }
  3738. V subscriptCaller(const V& a) { return a.operator[](3); }
  3739. V pointerCaller(const V* p, const V& b) { return p->operator+(b); }
  3740. `,
  3741. });
  3742. expect(callerNamesOf('V::operator+')).toEqual(['explicitCaller', 'pointerCaller']);
  3743. expect(callerNamesOf('V::operator[]')).toEqual(['subscriptCaller']);
  3744. expect(callerNamesOf('V::get')).toEqual(['plainCaller']); // control: plain calls unaffected
  3745. expect(callerNamesOf('Aaa::operator+')).toEqual([]);
  3746. expect(callerNamesOf('Aaa::operator[]')).toEqual([]);
  3747. });
  3748. it('resolves an out-of-line operator definition (declaration in header)', async () => {
  3749. await indexCpp({
  3750. 'v.hpp': `#pragma once
  3751. struct V { int x; V operator+(const V& o) const; };
  3752. `,
  3753. 'v.cpp': `#include "v.hpp"
  3754. V V::operator+(const V& o) const { return V{x + o.x}; }
  3755. `,
  3756. 'app.cpp': `#include "v.hpp"
  3757. V add(const V& a, const V& b) { return a.operator+(b); }
  3758. `,
  3759. });
  3760. expect(callerNamesOf('V::operator+')).toEqual(['add']);
  3761. });
  3762. });
  3763. describe('PHP chained static-factory call resolution (#608)', () => {
  3764. function callerNamesOf(qualifiedName: string): string[] {
  3765. const target = cg.getNodesByKind('method').find((n) => n.qualifiedName === qualifiedName);
  3766. if (!target) return [];
  3767. const names = cg
  3768. .getIncomingEdges(target.id)
  3769. .filter((e) => e.kind === 'calls')
  3770. .map((e) => cg.getNode(e.source)?.name)
  3771. .filter((n): n is string => !!n);
  3772. return [...new Set(names)].sort();
  3773. }
  3774. it('resolves Cls::for($x)->method() via the factory\'s `: self` return (#608)', async () => {
  3775. fs.writeFileSync(
  3776. path.join(tempDir, 'ApiClient.php'),
  3777. `<?php\nclass ApiClient {\n public static function for(string $c): self { return new self; }\n public function createOrder(array $p): array { return []; }\n}\n`
  3778. );
  3779. fs.writeFileSync(
  3780. path.join(tempDir, 'DispatchOrder.php'),
  3781. `<?php\nclass DispatchOrder {\n public function handle(): void {\n ApiClient::for('cred')->createOrder([]);\n }\n}\n`
  3782. );
  3783. cg = await CodeGraph.init(tempDir, { index: true });
  3784. // The chained call's edge attaches to the factory result's method.
  3785. expect(callerNamesOf('ApiClient::createOrder')).toContain('handle');
  3786. });
  3787. it('creates NO edge when the factory result lacks the method (#608)', async () => {
  3788. fs.writeFileSync(
  3789. path.join(tempDir, 'lib.php'),
  3790. `<?php\nclass ApiClient { public static function for(string $c): self { return new self; } }\nclass Other { public function onlyOther(): void {} }\nclass Caller { public function go(): void { ApiClient::for('x')->onlyOther(); } }\n`
  3791. );
  3792. cg = await CodeGraph.init(tempDir, { index: true });
  3793. // ApiClient has no onlyOther — must not mis-attach to the same-named Other::onlyOther.
  3794. expect(callerNamesOf('Other::onlyOther')).toEqual([]);
  3795. });
  3796. });
  3797. describe('Java chained static-factory call resolution (#645/#608 mechanism)', () => {
  3798. function callerNamesOf(qualifiedName: string): string[] {
  3799. const target = cg.getNodesByKind('method').find((n) => n.qualifiedName === qualifiedName);
  3800. if (!target) return [];
  3801. const names = cg
  3802. .getIncomingEdges(target.id)
  3803. .filter((e) => e.kind === 'calls')
  3804. .map((e) => cg.getNode(e.source)?.name)
  3805. .filter((n): n is string => !!n);
  3806. return [...new Set(names)].sort();
  3807. }
  3808. it('resolves Foo.getInstance().bar() via the factory return type, never a same-named decoy', async () => {
  3809. // Aaa sorts first and has a same-named bar() — it must never win the chain.
  3810. fs.writeFileSync(
  3811. path.join(tempDir, 'Main.java'),
  3812. `class Aaa { void bar() {} }
  3813. class Foo {
  3814. static Foo getInstance() { return new Foo(); }
  3815. void bar() {}
  3816. }
  3817. class Caller {
  3818. void run() { Foo.getInstance().bar(); }
  3819. }
  3820. `
  3821. );
  3822. cg = await CodeGraph.init(tempDir, { index: true });
  3823. expect(callerNamesOf('Foo::bar')).toEqual(['run']);
  3824. expect(callerNamesOf('Aaa::bar')).toEqual([]);
  3825. });
  3826. it('resolves a factory chain that passes arguments — Foo.create(cfg).build()', async () => {
  3827. // The factory call carries an argument; the extractor must normalize the
  3828. // receiver to empty parens (`Foo.create().build`) so the chain still splits.
  3829. fs.writeFileSync(
  3830. path.join(tempDir, 'Main.java'),
  3831. `class Config {}
  3832. class Foo {
  3833. static Foo create(Config c) { return new Foo(); }
  3834. void build() {}
  3835. }
  3836. class Caller {
  3837. void run() { Foo.create(new Config()).build(); }
  3838. }
  3839. `
  3840. );
  3841. cg = await CodeGraph.init(tempDir, { index: true });
  3842. expect(callerNamesOf('Foo::build')).toEqual(['run']);
  3843. });
  3844. it('creates NO edge when the factory return type lacks the method (silent miss, not a wrong edge)', async () => {
  3845. fs.writeFileSync(
  3846. path.join(tempDir, 'Main.java'),
  3847. `class Foo {
  3848. static Foo getInstance() { return new Foo(); }
  3849. }
  3850. class Other { void onlyOther() {} }
  3851. class Caller {
  3852. void run() { Foo.getInstance().onlyOther(); }
  3853. }
  3854. `
  3855. );
  3856. cg = await CodeGraph.init(tempDir, { index: true });
  3857. // Foo has no onlyOther() — must not mis-attach to the same-named Other::onlyOther.
  3858. expect(callerNamesOf('Other::onlyOther')).toEqual([]);
  3859. });
  3860. });
  3861. describe('Kotlin chained companion-factory call resolution (#645/#608 mechanism)', () => {
  3862. function callerNamesOf(qualifiedName: string): string[] {
  3863. const target = cg.getNodesByKind('method').find((n) => n.qualifiedName === qualifiedName);
  3864. if (!target) return [];
  3865. const names = cg
  3866. .getIncomingEdges(target.id)
  3867. .filter((e) => e.kind === 'calls')
  3868. .map((e) => cg.getNode(e.source)?.name)
  3869. .filter((n): n is string => !!n);
  3870. return [...new Set(names)].sort();
  3871. }
  3872. it('resolves Foo.getInstance().bar() via the companion return type, never a same-named decoy', async () => {
  3873. // Aaa sorts first and has a same-named bar() — without the chain fix Kotlin
  3874. // dropped the receiver to a bare `bar` and attached to Aaa (a wrong edge).
  3875. fs.writeFileSync(
  3876. path.join(tempDir, 'Main.kt'),
  3877. `class Aaa { fun bar() {} }
  3878. class Foo {
  3879. companion object {
  3880. fun getInstance(): Foo = Foo()
  3881. }
  3882. fun bar() {}
  3883. }
  3884. class Caller {
  3885. fun run() { Foo.getInstance().bar() }
  3886. }
  3887. `
  3888. );
  3889. cg = await CodeGraph.init(tempDir, { index: true });
  3890. expect(callerNamesOf('Foo::bar')).toEqual(['run']);
  3891. expect(callerNamesOf('Aaa::bar')).toEqual([]);
  3892. });
  3893. it('resolves a companion factory chain that passes arguments — Foo.create(cfg).build()', async () => {
  3894. fs.writeFileSync(
  3895. path.join(tempDir, 'Main.kt'),
  3896. `class Config
  3897. class Foo {
  3898. companion object {
  3899. fun create(c: Config): Foo = Foo()
  3900. }
  3901. fun build() {}
  3902. }
  3903. class Caller {
  3904. fun run() { Foo.create(Config()).build() }
  3905. }
  3906. `
  3907. );
  3908. cg = await CodeGraph.init(tempDir, { index: true });
  3909. expect(callerNamesOf('Foo::build')).toEqual(['run']);
  3910. });
  3911. it('creates NO edge when the companion return type lacks the method (silent miss, not a wrong edge)', async () => {
  3912. fs.writeFileSync(
  3913. path.join(tempDir, 'Main.kt'),
  3914. `class Foo {
  3915. companion object {
  3916. fun getInstance(): Foo = Foo()
  3917. }
  3918. }
  3919. class Other { fun onlyOther() {} }
  3920. class Caller {
  3921. fun run() { Foo.getInstance().onlyOther() }
  3922. }
  3923. `
  3924. );
  3925. cg = await CodeGraph.init(tempDir, { index: true });
  3926. // Foo has no onlyOther() — must not mis-attach to the same-named Other::onlyOther.
  3927. expect(callerNamesOf('Other::onlyOther')).toEqual([]);
  3928. });
  3929. });
  3930. describe('C# chained static-factory call resolution (#645/#608 mechanism)', () => {
  3931. function callerNamesOf(qualifiedName: string): string[] {
  3932. const target = cg.getNodesByKind('method').find((n) => n.qualifiedName === qualifiedName);
  3933. if (!target) return [];
  3934. const names = cg
  3935. .getIncomingEdges(target.id)
  3936. .filter((e) => e.kind === 'calls')
  3937. .map((e) => cg.getNode(e.source)?.name)
  3938. .filter((n): n is string => !!n);
  3939. return [...new Set(names)].sort();
  3940. }
  3941. it('resolves Foo.Create().Bar() via the factory return type, never a same-named decoy', async () => {
  3942. // Aaa sorts first and has a same-named Bar() — it must never win the chain.
  3943. fs.writeFileSync(
  3944. path.join(tempDir, 'Main.cs'),
  3945. `class Aaa { void Bar() {} }
  3946. class Foo {
  3947. static Foo Create() { return new Foo(); }
  3948. void Bar() {}
  3949. }
  3950. class Caller {
  3951. void Run() { Foo.Create().Bar(); }
  3952. }
  3953. `
  3954. );
  3955. cg = await CodeGraph.init(tempDir, { index: true });
  3956. expect(callerNamesOf('Foo::Bar')).toEqual(['Run']);
  3957. expect(callerNamesOf('Aaa::Bar')).toEqual([]);
  3958. });
  3959. it('resolves a factory chain that passes arguments — Foo.Make(cfg).Build()', async () => {
  3960. fs.writeFileSync(
  3961. path.join(tempDir, 'Main.cs'),
  3962. `class Config {}
  3963. class Foo {
  3964. static Foo Make(Config c) { return new Foo(); }
  3965. void Build() {}
  3966. }
  3967. class Caller {
  3968. void Run() { Foo.Make(new Config()).Build(); }
  3969. }
  3970. `
  3971. );
  3972. cg = await CodeGraph.init(tempDir, { index: true });
  3973. expect(callerNamesOf('Foo::Build')).toEqual(['Run']);
  3974. });
  3975. it('creates NO edge when the factory return type lacks the method (silent miss, not a wrong edge)', async () => {
  3976. fs.writeFileSync(
  3977. path.join(tempDir, 'Main.cs'),
  3978. `class Foo {
  3979. static Foo Create() { return new Foo(); }
  3980. }
  3981. class Other { void OnlyOther() {} }
  3982. class Caller {
  3983. void Run() { Foo.Create().OnlyOther(); }
  3984. }
  3985. `
  3986. );
  3987. cg = await CodeGraph.init(tempDir, { index: true });
  3988. // Foo has no OnlyOther() — must not mis-attach to the same-named Other::OnlyOther.
  3989. expect(callerNamesOf('Other::OnlyOther')).toEqual([]);
  3990. });
  3991. });
  3992. describe('Swift chained static-factory call resolution (#645/#608 mechanism)', () => {
  3993. function callerNamesOf(qualifiedName: string): string[] {
  3994. const target = cg.getNodesByKind('method').find((n) => n.qualifiedName === qualifiedName);
  3995. if (!target) return [];
  3996. const names = cg
  3997. .getIncomingEdges(target.id)
  3998. .filter((e) => e.kind === 'calls')
  3999. .map((e) => cg.getNode(e.source)?.name)
  4000. .filter((n): n is string => !!n);
  4001. return [...new Set(names)].sort();
  4002. }
  4003. it('resolves Foo.make().draw() via the factory return type, never a same-named decoy', async () => {
  4004. // Aaa sorts first and has a same-named draw() — without the fix Swift dropped
  4005. // the receiver to a bare `draw` and attached to Aaa (a wrong edge).
  4006. fs.writeFileSync(
  4007. path.join(tempDir, 'Main.swift'),
  4008. `class Aaa { func draw() {} }
  4009. class Foo {
  4010. static func make() -> Foo { return Foo() }
  4011. func draw() {}
  4012. }
  4013. func runCaller() { Foo.make().draw() }
  4014. `
  4015. );
  4016. cg = await CodeGraph.init(tempDir, { index: true });
  4017. expect(callerNamesOf('Foo::draw')).toEqual(['runCaller']);
  4018. expect(callerNamesOf('Aaa::draw')).toEqual([]);
  4019. });
  4020. it('resolves a constructor chain Foo().draw() and an args factory chain Foo.build(c).render()', async () => {
  4021. fs.writeFileSync(
  4022. path.join(tempDir, 'Main.swift'),
  4023. `class Config {}
  4024. class Foo {
  4025. static func build(_ c: Config) -> Foo { return Foo() }
  4026. func draw() {}
  4027. func render() {}
  4028. }
  4029. func runCaller() {
  4030. Foo().draw()
  4031. Foo.build(Config()).render()
  4032. }
  4033. `
  4034. );
  4035. cg = await CodeGraph.init(tempDir, { index: true });
  4036. expect(callerNamesOf('Foo::draw')).toEqual(['runCaller']);
  4037. expect(callerNamesOf('Foo::render')).toEqual(['runCaller']);
  4038. });
  4039. it('creates NO edge when the factory return type lacks the method (silent miss, not a wrong edge)', async () => {
  4040. fs.writeFileSync(
  4041. path.join(tempDir, 'Main.swift'),
  4042. `class Foo {
  4043. static func make() -> Foo { return Foo() }
  4044. }
  4045. class Other { func onlyOther() {} }
  4046. func runCaller() { Foo.make().onlyOther() }
  4047. `
  4048. );
  4049. cg = await CodeGraph.init(tempDir, { index: true });
  4050. // Foo has no onlyOther() — must not mis-attach to the same-named Other::onlyOther.
  4051. expect(callerNamesOf('Other::onlyOther')).toEqual([]);
  4052. });
  4053. });
  4054. describe('Chained call resolves a method on a supertype (conformance, #750)', () => {
  4055. function callerNamesOf(qualifiedName: string): string[] {
  4056. const target = cg.getNodesByKind('method').find((n) => n.qualifiedName === qualifiedName);
  4057. if (!target) return [];
  4058. const names = cg
  4059. .getIncomingEdges(target.id)
  4060. .filter((e) => e.kind === 'calls')
  4061. .map((e) => cg.getNode(e.source)?.name)
  4062. .filter((n): n is string => !!n);
  4063. return [...new Set(names)].sort();
  4064. }
  4065. it('resolves a chained method defined only on a SUPERCLASS the return type extends', async () => {
  4066. // draw() lives on Base; Widget (the factory's return type) has no draw() of
  4067. // its own. Decoy.draw must never win. Needs the conformance second pass.
  4068. fs.writeFileSync(
  4069. path.join(tempDir, 'Main.java'),
  4070. `class Base { void draw() {} }
  4071. class Widget extends Base {}
  4072. class Decoy { void draw() {} }
  4073. class Factory { static Widget create() { return new Widget(); } }
  4074. class Caller {
  4075. void run() { Factory.create().draw(); }
  4076. }
  4077. `
  4078. );
  4079. cg = await CodeGraph.init(tempDir, { index: true });
  4080. expect(callerNamesOf('Base::draw')).toEqual(['run']);
  4081. expect(callerNamesOf('Decoy::draw')).toEqual([]);
  4082. });
  4083. it('resolves a chained method defined on an INTERFACE the return type implements (default method)', async () => {
  4084. fs.writeFileSync(
  4085. path.join(tempDir, 'Main.java'),
  4086. `interface Drawable { default void draw() {} }
  4087. class Widget implements Drawable {}
  4088. class Decoy { void draw() {} }
  4089. class Factory { static Widget create() { return new Widget(); } }
  4090. class Caller {
  4091. void run() { Factory.create().draw(); }
  4092. }
  4093. `
  4094. );
  4095. cg = await CodeGraph.init(tempDir, { index: true });
  4096. expect(callerNamesOf('Drawable::draw')).toEqual(['run']);
  4097. expect(callerNamesOf('Decoy::draw')).toEqual([]);
  4098. });
  4099. it('still creates NO edge when no supertype has the method (safety preserved)', async () => {
  4100. fs.writeFileSync(
  4101. path.join(tempDir, 'Main.java'),
  4102. `class Base {}
  4103. class Widget extends Base {}
  4104. class Other { void onlyOther() {} }
  4105. class Factory { static Widget create() { return new Widget(); } }
  4106. class Caller {
  4107. void run() { Factory.create().onlyOther(); }
  4108. }
  4109. `
  4110. );
  4111. cg = await CodeGraph.init(tempDir, { index: true });
  4112. // Neither Widget nor Base has onlyOther() — must not attach to Other::onlyOther.
  4113. expect(callerNamesOf('Other::onlyOther')).toEqual([]);
  4114. });
  4115. });
  4116. describe('Rust chained associated-function call resolution (#645/#608 mechanism)', () => {
  4117. function callerNamesOf(qualifiedName: string): string[] {
  4118. const target = cg.getNodesByKind('method').find((n) => n.qualifiedName === qualifiedName);
  4119. if (!target) return [];
  4120. const names = cg
  4121. .getIncomingEdges(target.id)
  4122. .filter((e) => e.kind === 'calls')
  4123. .map((e) => cg.getNode(e.source)?.name)
  4124. .filter((n): n is string => !!n);
  4125. return [...new Set(names)].sort();
  4126. }
  4127. it('resolves Foo::new().bar() (and a Self return) via the associated fn, never a same-named decoy', async () => {
  4128. fs.writeFileSync(
  4129. path.join(tempDir, 'main.rs'),
  4130. `struct Aaa { _x: i32 }
  4131. impl Aaa { fn bar(&self) {} }
  4132. struct Foo { _x: i32 }
  4133. impl Foo {
  4134. fn new() -> Foo { Foo { _x: 0 } }
  4135. fn make() -> Self { Foo { _x: 0 } }
  4136. fn bar(&self) {}
  4137. }
  4138. fn caller() {
  4139. Foo::new().bar();
  4140. Foo::make().bar();
  4141. }
  4142. `
  4143. );
  4144. cg = await CodeGraph.init(tempDir, { index: true });
  4145. expect(callerNamesOf('Foo::bar')).toEqual(['caller']);
  4146. expect(callerNamesOf('Aaa::bar')).toEqual([]);
  4147. });
  4148. it('resolves a chain that passes arguments — Foo::with(c).build()', async () => {
  4149. fs.writeFileSync(
  4150. path.join(tempDir, 'main.rs'),
  4151. `struct Config;
  4152. struct Foo { _x: i32 }
  4153. impl Foo {
  4154. fn with(c: Config) -> Foo { Foo { _x: 0 } }
  4155. fn build(&self) {}
  4156. }
  4157. fn caller() { Foo::with(Config).build(); }
  4158. `
  4159. );
  4160. cg = await CodeGraph.init(tempDir, { index: true });
  4161. expect(callerNamesOf('Foo::build')).toEqual(['caller']);
  4162. });
  4163. it('resolves a chained method from a trait the type implements (default method, via conformance)', async () => {
  4164. fs.writeFileSync(
  4165. path.join(tempDir, 'main.rs'),
  4166. `struct Foo { _x: i32 }
  4167. impl Foo { fn new() -> Foo { Foo { _x: 0 } } }
  4168. struct Decoy { _x: i32 }
  4169. impl Decoy { fn draw(&self) {} }
  4170. trait Drawable { fn draw(&self) {} }
  4171. impl Drawable for Foo {}
  4172. fn caller() { Foo::new().draw(); }
  4173. `
  4174. );
  4175. cg = await CodeGraph.init(tempDir, { index: true });
  4176. expect(callerNamesOf('Drawable::draw')).toEqual(['caller']);
  4177. expect(callerNamesOf('Decoy::draw')).toEqual([]);
  4178. });
  4179. it('creates NO edge when neither the type nor a supertype has the method (silent miss)', async () => {
  4180. fs.writeFileSync(
  4181. path.join(tempDir, 'main.rs'),
  4182. `struct Foo { _x: i32 }
  4183. impl Foo { fn new() -> Foo { Foo { _x: 0 } } }
  4184. struct Other { _x: i32 }
  4185. impl Other { fn only_other(&self) {} }
  4186. fn caller() { Foo::new().only_other(); }
  4187. `
  4188. );
  4189. cg = await CodeGraph.init(tempDir, { index: true });
  4190. // Foo has no only_other() — must not mis-attach to the same-named Other::only_other.
  4191. expect(callerNamesOf('Other::only_other')).toEqual([]);
  4192. });
  4193. });
  4194. describe('Go chained factory-function call resolution (#645/#608 mechanism)', () => {
  4195. function callerNamesOf(qualifiedName: string): string[] {
  4196. const target = cg.getNodesByKind('method').find((n) => n.qualifiedName === qualifiedName);
  4197. if (!target) return [];
  4198. const names = cg
  4199. .getIncomingEdges(target.id)
  4200. .filter((e) => e.kind === 'calls')
  4201. .map((e) => cg.getNode(e.source)?.name)
  4202. .filter((n): n is string => !!n);
  4203. return [...new Set(names)].sort();
  4204. }
  4205. it('resolves New().Bar() via the factory return type (pointer), never a same-named decoy', async () => {
  4206. fs.writeFileSync(
  4207. path.join(tempDir, 'main.go'),
  4208. `package main
  4209. type Aaa struct{}
  4210. func (a *Aaa) Bar() {}
  4211. type Foo struct{}
  4212. func New() *Foo { return &Foo{} }
  4213. func (f *Foo) Bar() {}
  4214. func caller() { New().Bar() }
  4215. `
  4216. );
  4217. cg = await CodeGraph.init(tempDir, { index: true });
  4218. expect(callerNamesOf('Foo::Bar')).toEqual(['caller']);
  4219. expect(callerNamesOf('Aaa::Bar')).toEqual([]);
  4220. });
  4221. it('resolves an args chain and a multi-return factory — With(c).Build(), (*Foo, error)', async () => {
  4222. fs.writeFileSync(
  4223. path.join(tempDir, 'main.go'),
  4224. `package main
  4225. type Config struct{}
  4226. type Foo struct{}
  4227. func With(c Config) (*Foo, error) { return &Foo{}, nil }
  4228. func (f *Foo) Build() {}
  4229. func caller() { With(Config{}).Build() }
  4230. `
  4231. );
  4232. cg = await CodeGraph.init(tempDir, { index: true });
  4233. expect(callerNamesOf('Foo::Build')).toEqual(['caller']);
  4234. });
  4235. it('resolves a method provided by an embedded struct (via conformance)', async () => {
  4236. fs.writeFileSync(
  4237. path.join(tempDir, 'main.go'),
  4238. `package main
  4239. type Base struct{}
  4240. func (b *Base) Embedded() {}
  4241. type Decoy struct{}
  4242. func (d *Decoy) Embedded() {}
  4243. type Widget struct{ Base }
  4244. func NewWidget() *Widget { return &Widget{} }
  4245. func caller() { NewWidget().Embedded() }
  4246. `
  4247. );
  4248. cg = await CodeGraph.init(tempDir, { index: true });
  4249. expect(callerNamesOf('Base::Embedded')).toEqual(['caller']);
  4250. expect(callerNamesOf('Decoy::Embedded')).toEqual([]);
  4251. });
  4252. it('creates NO edge when neither the type nor an embedded type has the method (silent miss)', async () => {
  4253. fs.writeFileSync(
  4254. path.join(tempDir, 'main.go'),
  4255. `package main
  4256. type Foo struct{}
  4257. func New() *Foo { return &Foo{} }
  4258. type Other struct{}
  4259. func (o *Other) OnlyOther() {}
  4260. func caller() { New().OnlyOther() }
  4261. `
  4262. );
  4263. cg = await CodeGraph.init(tempDir, { index: true });
  4264. // Foo has no OnlyOther() — must not mis-attach to the same-named Other::OnlyOther.
  4265. expect(callerNamesOf('Other::OnlyOther')).toEqual([]);
  4266. });
  4267. it('falls back to bare-name resolution for a VARIABLE-inner chain without exploding the graph', async () => {
  4268. // `engine` is a package-level VARIABLE holding a func value, not a factory
  4269. // FUNCTION — so its return type can't be recovered and the chain falls back
  4270. // to bare-name resolution of the method (restoring the pre-re-encoding edge).
  4271. // Regression for the runaway this fallback originally caused: it resolved
  4272. // with a mutated `original.referenceName` (the bare `ServeHTTP`, not the
  4273. // stored `engine().ServeHTTP`), so the batched resolver's keyed delete
  4274. // no-oped, the offset-0 batch never drained, and edges inserted forever
  4275. // (5M edges / 1.4 GB on a 99-file repo). The fallback now ties the match to
  4276. // the original ref, and a non-progress guard backstops the loop.
  4277. fs.writeFileSync(
  4278. path.join(tempDir, 'main.go'),
  4279. `package main
  4280. type Server struct{}
  4281. func (s *Server) ServeHTTP() {}
  4282. var engine = func() *Server { return &Server{} }
  4283. func caller() { engine().ServeHTTP() }
  4284. `
  4285. );
  4286. cg = await CodeGraph.init(tempDir, { index: true });
  4287. // Recall: the variable-inner chain still finds the method by bare name.
  4288. expect(callerNamesOf('Server::ServeHTTP')).toEqual(['caller']);
  4289. // No runaway: a single call site yields a single edge, not millions.
  4290. const target = cg
  4291. .getNodesByKind('method')
  4292. .find((n) => n.qualifiedName === 'Server::ServeHTTP')!;
  4293. const rawCalls = cg
  4294. .getIncomingEdges(target.id)
  4295. .filter((e) => e.kind === 'calls');
  4296. expect(rawCalls.length).toBeLessThan(5);
  4297. });
  4298. });
  4299. describe('Scala chained static-factory call resolution (#645/#608 mechanism)', () => {
  4300. function callerNamesOf(qualifiedName: string): string[] {
  4301. const target = cg.getNodesByKind('method').find((n) => n.qualifiedName === qualifiedName);
  4302. if (!target) return [];
  4303. const names = cg
  4304. .getIncomingEdges(target.id)
  4305. .filter((e) => e.kind === 'calls')
  4306. .map((e) => cg.getNode(e.source)?.name)
  4307. .filter((n): n is string => !!n);
  4308. return [...new Set(names)].sort();
  4309. }
  4310. it('resolves a companion-factory chain Foo.create().doIt() to the return type, never a same-named decoy', async () => {
  4311. fs.writeFileSync(
  4312. path.join(tempDir, 'Main.scala'),
  4313. `object Foo {
  4314. def create(): Bar = new Bar()
  4315. }
  4316. class Bar {
  4317. def doIt(): Unit = {}
  4318. }
  4319. class Decoy {
  4320. def doIt(): Unit = {}
  4321. }
  4322. object Main {
  4323. def run(): Unit = { Foo.create().doIt() }
  4324. }
  4325. `
  4326. );
  4327. cg = await CodeGraph.init(tempDir, { index: true });
  4328. expect(callerNamesOf('Bar::doIt')).toEqual(['run']);
  4329. expect(callerNamesOf('Decoy::doIt')).toEqual([]);
  4330. });
  4331. it('resolves a case-class apply construction Point(x).dist() on the constructed class', async () => {
  4332. fs.writeFileSync(
  4333. path.join(tempDir, 'Main.scala'),
  4334. `class Point(x: Int) {
  4335. def dist(): Int = x
  4336. }
  4337. class Other {
  4338. def dist(): Int = 0
  4339. }
  4340. object Main {
  4341. def run(): Unit = { Point(3).dist() }
  4342. }
  4343. `
  4344. );
  4345. cg = await CodeGraph.init(tempDir, { index: true });
  4346. expect(callerNamesOf('Point::dist')).toEqual(['run']);
  4347. expect(callerNamesOf('Other::dist')).toEqual([]);
  4348. });
  4349. it('resolves a chained method provided by a trait the return type extends (via conformance)', async () => {
  4350. fs.writeFileSync(
  4351. path.join(tempDir, 'Main.scala'),
  4352. `trait Base {
  4353. def shared(): Unit = {}
  4354. }
  4355. class Widget extends Base
  4356. class Decoy {
  4357. def shared(): Unit = {}
  4358. }
  4359. object Factory {
  4360. def make(): Widget = new Widget()
  4361. }
  4362. object Main {
  4363. def run(): Unit = { Factory.make().shared() }
  4364. }
  4365. `
  4366. );
  4367. cg = await CodeGraph.init(tempDir, { index: true });
  4368. expect(callerNamesOf('Base::shared')).toEqual(['run']);
  4369. expect(callerNamesOf('Decoy::shared')).toEqual([]);
  4370. });
  4371. it('creates NO edge when neither the factory return type nor a supertype has the method (silent miss)', async () => {
  4372. fs.writeFileSync(
  4373. path.join(tempDir, 'Main.scala'),
  4374. `object Foo {
  4375. def create(): Bar = new Bar()
  4376. }
  4377. class Bar {
  4378. }
  4379. class Other {
  4380. def onlyOther(): Unit = {}
  4381. }
  4382. object Main {
  4383. def run(): Unit = { Foo.create().onlyOther() }
  4384. }
  4385. `
  4386. );
  4387. cg = await CodeGraph.init(tempDir, { index: true });
  4388. // Bar has no onlyOther() — must not mis-attach to the same-named Other::onlyOther.
  4389. expect(callerNamesOf('Other::onlyOther')).toEqual([]);
  4390. });
  4391. });
  4392. describe('Dart chained static-factory / factory-constructor call resolution (#645/#608 mechanism)', () => {
  4393. function callerNamesOf(qualifiedName: string): string[] {
  4394. const target = cg.getNodesByKind('method').find((n) => n.qualifiedName === qualifiedName);
  4395. if (!target) return [];
  4396. const names = cg
  4397. .getIncomingEdges(target.id)
  4398. .filter((e) => e.kind === 'calls')
  4399. .map((e) => cg.getNode(e.source)?.name)
  4400. .filter((n): n is string => !!n);
  4401. return [...new Set(names)].sort();
  4402. }
  4403. it('resolves a static-factory chain Foo.makeBar().doIt() to the return type, never a same-named decoy', async () => {
  4404. fs.writeFileSync(
  4405. path.join(tempDir, 'main.dart'),
  4406. `class Foo {
  4407. static Bar makeBar() => Bar();
  4408. }
  4409. class Bar {
  4410. void doIt() {}
  4411. }
  4412. class Decoy {
  4413. void doIt() {}
  4414. }
  4415. void run() {
  4416. Foo.makeBar().doIt();
  4417. }
  4418. `
  4419. );
  4420. cg = await CodeGraph.init(tempDir, { index: true });
  4421. expect(callerNamesOf('Bar::doIt')).toEqual(['run']);
  4422. expect(callerNamesOf('Decoy::doIt')).toEqual([]);
  4423. });
  4424. it('resolves a named factory-constructor chain Foo.create().ship() on the constructed class', async () => {
  4425. fs.writeFileSync(
  4426. path.join(tempDir, 'main.dart'),
  4427. `class Foo {
  4428. Foo._();
  4429. factory Foo.create() => Foo._();
  4430. void ship() {}
  4431. }
  4432. class Decoy {
  4433. void ship() {}
  4434. }
  4435. void run() {
  4436. Foo.create().ship();
  4437. }
  4438. `
  4439. );
  4440. cg = await CodeGraph.init(tempDir, { index: true });
  4441. // The factory constructor `Foo.create` is now a node whose return type is Foo,
  4442. // so `ship` resolves on Foo, not the same-named Decoy.
  4443. expect(callerNamesOf('Foo::ship')).toEqual(['run']);
  4444. expect(callerNamesOf('Decoy::ship')).toEqual([]);
  4445. });
  4446. it('resolves a constructor-receiver chain Bar().doIt() on the constructed class', async () => {
  4447. fs.writeFileSync(
  4448. path.join(tempDir, 'main.dart'),
  4449. `class Bar {
  4450. void doIt() {}
  4451. }
  4452. class Decoy {
  4453. void doIt() {}
  4454. }
  4455. void run() {
  4456. Bar().doIt();
  4457. }
  4458. `
  4459. );
  4460. cg = await CodeGraph.init(tempDir, { index: true });
  4461. expect(callerNamesOf('Bar::doIt')).toEqual(['run']);
  4462. expect(callerNamesOf('Decoy::doIt')).toEqual([]);
  4463. });
  4464. it('resolves a chained method inherited from a superclass the return type extends (via conformance)', async () => {
  4465. fs.writeFileSync(
  4466. path.join(tempDir, 'main.dart'),
  4467. `class Base {
  4468. void render() {}
  4469. }
  4470. class Widget extends Base {
  4471. static Widget make() => Widget();
  4472. }
  4473. class Decoy {
  4474. void render() {}
  4475. }
  4476. void run() {
  4477. Widget.make().render();
  4478. }
  4479. `
  4480. );
  4481. cg = await CodeGraph.init(tempDir, { index: true });
  4482. expect(callerNamesOf('Base::render')).toEqual(['run']);
  4483. expect(callerNamesOf('Decoy::render')).toEqual([]);
  4484. });
  4485. it('creates NO edge when neither the factory return type nor a supertype has the method (silent miss)', async () => {
  4486. fs.writeFileSync(
  4487. path.join(tempDir, 'main.dart'),
  4488. `class Foo {
  4489. static Bar makeBar() => Bar();
  4490. }
  4491. class Bar {
  4492. }
  4493. class Other {
  4494. void onlyOther() {}
  4495. }
  4496. void run() {
  4497. Foo.makeBar().onlyOther();
  4498. }
  4499. `
  4500. );
  4501. cg = await CodeGraph.init(tempDir, { index: true });
  4502. // Bar has no onlyOther() — must not mis-attach to the same-named Other::onlyOther.
  4503. expect(callerNamesOf('Other::onlyOther')).toEqual([]);
  4504. });
  4505. it('still extracts a method tree-sitter misparses as a constructor (@override + record return)', async () => {
  4506. // tree-sitter-dart misparses `@override (A, B) reduce()` — the annotation
  4507. // swallows the record return type, so `reduce()` looks like a single-
  4508. // identifier constructor_signature. It must NOT be skipped as an unnamed
  4509. // ctor (its name doesn't match the class); its body call must attribute to
  4510. // `reduce`, not the class.
  4511. fs.writeFileSync(
  4512. path.join(tempDir, 'main.dart'),
  4513. `class Base {}
  4514. class Action extends Base {
  4515. Action({required int x});
  4516. @override
  4517. (int, String) reduce() {
  4518. return (compute(), "y");
  4519. }
  4520. int compute() => 1;
  4521. }
  4522. `
  4523. );
  4524. cg = await CodeGraph.init(tempDir, { index: true });
  4525. // reduce must be a node and its body call must resolve to Action::compute.
  4526. expect(callerNamesOf('Action::compute')).toEqual(['reduce']);
  4527. });
  4528. it('keeps plain construction Foo() as instantiation, not a Foo::Foo method call', async () => {
  4529. // The unnamed constructor is intentionally NOT extracted as a `Foo::Foo`
  4530. // method, so `Foo(...)` resolves to the class (an `instantiates` edge),
  4531. // never hijacked into a call to a phantom constructor method.
  4532. fs.writeFileSync(
  4533. path.join(tempDir, 'main.dart'),
  4534. `class Widget {
  4535. final int x;
  4536. Widget(this.x);
  4537. }
  4538. void run() {
  4539. Widget(3);
  4540. }
  4541. `
  4542. );
  4543. cg = await CodeGraph.init(tempDir, { index: true });
  4544. // No Foo::Foo phantom method node.
  4545. expect(cg.getNodesByKind('method').some((n) => n.qualifiedName === 'Widget::Widget')).toBe(false);
  4546. // The construction resolves to the class as an `instantiates` edge.
  4547. const widget = cg.getNodesByKind('class').find((n) => n.name === 'Widget')!;
  4548. const incoming = cg.getIncomingEdges(widget.id);
  4549. expect(incoming.some((e) => e.kind === 'instantiates')).toBe(true);
  4550. });
  4551. });
  4552. describe('Objective-C chained message-send call resolution (#645/#608 mechanism)', () => {
  4553. function callerNamesOf(qualifiedName: string): string[] {
  4554. const target = cg.getNodesByKind('method').find((n) => n.qualifiedName === qualifiedName);
  4555. if (!target) return [];
  4556. const names = cg
  4557. .getIncomingEdges(target.id)
  4558. .filter((e) => e.kind === 'calls')
  4559. .map((e) => cg.getNode(e.source)?.name)
  4560. .filter((n): n is string => !!n);
  4561. return [...new Set(names)].sort();
  4562. }
  4563. it('resolves a chained message send [[Foo create] doIt] via the return type, never a same-named decoy', async () => {
  4564. fs.writeFileSync(
  4565. path.join(tempDir, 'main.m'),
  4566. `@interface Bar : NSObject
  4567. - (void)doIt;
  4568. @end
  4569. @implementation Bar
  4570. - (void)doIt {}
  4571. @end
  4572. @interface Decoy : NSObject
  4573. - (void)doIt;
  4574. @end
  4575. @implementation Decoy
  4576. - (void)doIt {}
  4577. @end
  4578. @interface Foo : NSObject
  4579. + (Bar *)create;
  4580. @end
  4581. @implementation Foo
  4582. + (Bar *)create { return nil; }
  4583. - (void)run { [[Foo create] doIt]; }
  4584. @end
  4585. `
  4586. );
  4587. cg = await CodeGraph.init(tempDir, { index: true });
  4588. expect(callerNamesOf('Bar::doIt')).toEqual(['run']);
  4589. expect(callerNamesOf('Decoy::doIt')).toEqual([]);
  4590. });
  4591. it('resolves a chained message whose method is inherited from a superclass (via conformance)', async () => {
  4592. fs.writeFileSync(
  4593. path.join(tempDir, 'main.m'),
  4594. `@interface Base : NSObject
  4595. - (void)render;
  4596. @end
  4597. @implementation Base
  4598. - (void)render {}
  4599. @end
  4600. @interface Widget : Base
  4601. @end
  4602. @implementation Widget
  4603. @end
  4604. @interface Decoy : NSObject
  4605. - (void)render;
  4606. @end
  4607. @implementation Decoy
  4608. - (void)render {}
  4609. @end
  4610. @interface Factory : NSObject
  4611. + (Widget *)make;
  4612. @end
  4613. @implementation Factory
  4614. + (Widget *)make { return nil; }
  4615. - (void)run { [[Factory make] render]; }
  4616. @end
  4617. `
  4618. );
  4619. cg = await CodeGraph.init(tempDir, { index: true });
  4620. expect(callerNamesOf('Base::render')).toEqual(['run']);
  4621. expect(callerNamesOf('Decoy::render')).toEqual([]);
  4622. });
  4623. it('creates NO edge when the factory return type lacks the method (silent miss)', async () => {
  4624. fs.writeFileSync(
  4625. path.join(tempDir, 'main.m'),
  4626. `@interface Bar : NSObject
  4627. @end
  4628. @implementation Bar
  4629. @end
  4630. @interface Other : NSObject
  4631. - (void)onlyOther;
  4632. @end
  4633. @implementation Other
  4634. - (void)onlyOther {}
  4635. @end
  4636. @interface Foo : NSObject
  4637. + (Bar *)create;
  4638. @end
  4639. @implementation Foo
  4640. + (Bar *)create { return nil; }
  4641. - (void)run { [[Foo create] onlyOther]; }
  4642. @end
  4643. `
  4644. );
  4645. cg = await CodeGraph.init(tempDir, { index: true });
  4646. // Bar has no onlyOther — must not mis-attach to the same-named Other::onlyOther.
  4647. expect(callerNamesOf('Other::onlyOther')).toEqual([]);
  4648. });
  4649. it('resolves a singleton chain [[Cache shared] clearAll] whose factory returns nonnull instancetype', async () => {
  4650. // The factory returns `nonnull instancetype` — the nullability qualifier must
  4651. // be skipped (not captured AS the type), and an instancetype class-message
  4652. // factory returns the receiver class, so clearAll resolves on Cache, never a
  4653. // same-named decoy. (Regression for both: the captured-`nonnull` bug and the
  4654. // ubiquitous `[[X alloc] init]` / singleton pattern.)
  4655. fs.writeFileSync(
  4656. path.join(tempDir, 'main.m'),
  4657. `@interface Cache : NSObject
  4658. + (nonnull instancetype)shared;
  4659. - (void)clearAll;
  4660. @end
  4661. @implementation Cache
  4662. + (nonnull instancetype)shared { return nil; }
  4663. - (void)clearAll {}
  4664. @end
  4665. @interface Decoy : NSObject
  4666. - (void)clearAll;
  4667. @end
  4668. @implementation Decoy
  4669. - (void)clearAll {}
  4670. @end
  4671. @interface Caller : NSObject
  4672. - (void)run;
  4673. @end
  4674. @implementation Caller
  4675. - (void)run { [[Cache shared] clearAll]; }
  4676. @end
  4677. `
  4678. );
  4679. cg = await CodeGraph.init(tempDir, { index: true });
  4680. expect(callerNamesOf('Cache::clearAll')).toEqual(['run']);
  4681. expect(callerNamesOf('Decoy::clearAll')).toEqual([]);
  4682. });
  4683. });
  4684. describe('Pascal/Delphi chained static-factory call resolution (#645/#608 mechanism)', () => {
  4685. function callerNamesOf(qualifiedName: string): string[] {
  4686. const target = cg.getNodesByKind('method').find((n) => n.qualifiedName === qualifiedName);
  4687. if (!target) return [];
  4688. const names = cg
  4689. .getIncomingEdges(target.id)
  4690. .filter((e) => e.kind === 'calls')
  4691. .map((e) => cg.getNode(e.source)?.name)
  4692. .filter((n): n is string => !!n);
  4693. return [...new Set(names)].sort();
  4694. }
  4695. function isCalled(qn: string): boolean {
  4696. const t = cg.getNodesByKind('method').find((n) => n.qualifiedName === qn);
  4697. return !!t && cg.getIncomingEdges(t.id).some((e) => e.kind === 'calls');
  4698. }
  4699. it('resolves a chained factory call TFoo.GetInstance().DoIt() via the return type, never a same-named decoy', async () => {
  4700. fs.writeFileSync(
  4701. path.join(tempDir, 'main.pas'),
  4702. `unit Main;
  4703. interface
  4704. type
  4705. TBar = class
  4706. procedure DoIt;
  4707. end;
  4708. TDecoy = class
  4709. procedure DoIt;
  4710. end;
  4711. TFoo = class
  4712. class function GetInstance: TBar;
  4713. end;
  4714. implementation
  4715. procedure TBar.DoIt; begin end;
  4716. procedure TDecoy.DoIt; begin end;
  4717. class function TFoo.GetInstance: TBar; begin Result := nil; end;
  4718. procedure Run;
  4719. begin
  4720. TFoo.GetInstance().DoIt();
  4721. end;
  4722. end.
  4723. `
  4724. );
  4725. cg = await CodeGraph.init(tempDir, { index: true });
  4726. expect(isCalled('TBar::DoIt')).toBe(true);
  4727. expect(isCalled('TDecoy::DoIt')).toBe(false);
  4728. });
  4729. it('resolves a constructor chain TFoo.Create().Configure() on the constructed class', async () => {
  4730. fs.writeFileSync(
  4731. path.join(tempDir, 'main.pas'),
  4732. `unit Main;
  4733. interface
  4734. type
  4735. TFoo = class
  4736. constructor Create;
  4737. procedure Configure;
  4738. end;
  4739. TDecoy = class
  4740. procedure Configure;
  4741. end;
  4742. implementation
  4743. constructor TFoo.Create; begin end;
  4744. procedure TFoo.Configure; begin end;
  4745. procedure TDecoy.Configure; begin end;
  4746. procedure Run;
  4747. begin
  4748. TFoo.Create().Configure();
  4749. end;
  4750. end.
  4751. `
  4752. );
  4753. cg = await CodeGraph.init(tempDir, { index: true });
  4754. // A constructor returns its own class (no `: TBar` annotation), so Configure
  4755. // resolves on TFoo, not the same-named decoy.
  4756. expect(isCalled('TFoo::Configure')).toBe(true);
  4757. expect(isCalled('TDecoy::Configure')).toBe(false);
  4758. });
  4759. it('resolves a typecast chain TFoo(x).DoIt() on the cast type', async () => {
  4760. fs.writeFileSync(
  4761. path.join(tempDir, 'main.pas'),
  4762. `unit Main;
  4763. interface
  4764. type
  4765. TFoo = class
  4766. procedure DoIt;
  4767. end;
  4768. TDecoy = class
  4769. procedure DoIt;
  4770. end;
  4771. implementation
  4772. procedure TFoo.DoIt; begin end;
  4773. procedure TDecoy.DoIt; begin end;
  4774. procedure Run(obj: TObject);
  4775. begin
  4776. TFoo(obj).DoIt();
  4777. end;
  4778. end.
  4779. `
  4780. );
  4781. cg = await CodeGraph.init(tempDir, { index: true });
  4782. expect(isCalled('TFoo::DoIt')).toBe(true);
  4783. expect(isCalled('TDecoy::DoIt')).toBe(false);
  4784. });
  4785. it('creates NO edge when the factory return type lacks the method (silent miss)', async () => {
  4786. fs.writeFileSync(
  4787. path.join(tempDir, 'main.pas'),
  4788. `unit Main;
  4789. interface
  4790. type
  4791. TBar = class
  4792. end;
  4793. TOther = class
  4794. procedure OnlyOther;
  4795. end;
  4796. TFoo = class
  4797. class function GetInstance: TBar;
  4798. end;
  4799. implementation
  4800. procedure TOther.OnlyOther; begin end;
  4801. class function TFoo.GetInstance: TBar; begin Result := nil; end;
  4802. procedure Run;
  4803. begin
  4804. TFoo.GetInstance().OnlyOther();
  4805. end;
  4806. end.
  4807. `
  4808. );
  4809. cg = await CodeGraph.init(tempDir, { index: true });
  4810. // TBar has no OnlyOther — must not mis-attach to the same-named TOther::OnlyOther.
  4811. expect(isCalled('TOther::OnlyOther')).toBe(false);
  4812. });
  4813. it('extracts paren-less method calls (Pascal lets a no-arg method drop its parens)', async () => {
  4814. fs.writeFileSync(
  4815. path.join(tempDir, 'main.pas'),
  4816. `unit Main;
  4817. interface
  4818. type
  4819. TFoo = class
  4820. procedure DoThing;
  4821. procedure Reset;
  4822. end;
  4823. implementation
  4824. procedure TFoo.DoThing; begin end;
  4825. procedure TFoo.Reset; begin end;
  4826. procedure Run(f: TFoo);
  4827. begin
  4828. f.DoThing;
  4829. f.Reset;
  4830. end;
  4831. end.
  4832. `
  4833. );
  4834. cg = await CodeGraph.init(tempDir, { index: true });
  4835. expect(isCalled('TFoo::DoThing')).toBe(true);
  4836. expect(isCalled('TFoo::Reset')).toBe(true);
  4837. });
  4838. it('resolves a PAREN-LESS chained factory call TFoo.GetInstance.DoIt via the return type', async () => {
  4839. fs.writeFileSync(
  4840. path.join(tempDir, 'main.pas'),
  4841. `unit Main;
  4842. interface
  4843. type
  4844. TBar = class
  4845. procedure DoIt;
  4846. end;
  4847. TDecoy = class
  4848. procedure DoIt;
  4849. end;
  4850. TFoo = class
  4851. class function GetInstance: TBar;
  4852. end;
  4853. implementation
  4854. procedure TBar.DoIt; begin end;
  4855. procedure TDecoy.DoIt; begin end;
  4856. class function TFoo.GetInstance: TBar; begin Result := nil; end;
  4857. procedure Run;
  4858. begin
  4859. TFoo.GetInstance.DoIt;
  4860. end;
  4861. end.
  4862. `
  4863. );
  4864. cg = await CodeGraph.init(tempDir, { index: true });
  4865. expect(isCalled('TBar::DoIt')).toBe(true);
  4866. expect(isCalled('TDecoy::DoIt')).toBe(false);
  4867. });
  4868. it('does NOT turn a property write/read into a call edge (only statement-level dots are calls)', async () => {
  4869. fs.writeFileSync(
  4870. path.join(tempDir, 'main.pas'),
  4871. `unit Main;
  4872. interface
  4873. type
  4874. TFoo = class
  4875. function GetValue: Integer;
  4876. procedure SetValue(v: Integer);
  4877. property Value: Integer read GetValue write SetValue;
  4878. end;
  4879. implementation
  4880. function TFoo.GetValue: Integer; begin Result := 0; end;
  4881. procedure TFoo.SetValue(v: Integer); begin end;
  4882. procedure Run(f: TFoo);
  4883. var x: Integer;
  4884. begin
  4885. f.Value := 5;
  4886. x := f.Value;
  4887. end;
  4888. end.
  4889. `
  4890. );
  4891. cg = await CodeGraph.init(tempDir, { index: true });
  4892. // A property read/write is a bare dot in assignment position, not a statement,
  4893. // so it must not be mis-extracted as a call to the property's getter/setter.
  4894. expect(isCalled('TFoo::GetValue')).toBe(false);
  4895. expect(isCalled('TFoo::SetValue')).toBe(false);
  4896. });
  4897. it('attributes an implementation-only free procedure\'s calls to the procedure, not the file', async () => {
  4898. fs.writeFileSync(
  4899. path.join(tempDir, 'main.pas'),
  4900. `unit Main;
  4901. interface
  4902. type
  4903. TTgt = class
  4904. procedure Hit;
  4905. end;
  4906. TFoo = class
  4907. procedure DoStuff;
  4908. end;
  4909. implementation
  4910. procedure TTgt.Hit; begin end;
  4911. procedure TFoo.DoStuff; var t: TTgt; begin t.Hit; end;
  4912. procedure Helper; var t: TTgt; begin t.Hit; end;
  4913. `
  4914. );
  4915. cg = await CodeGraph.init(tempDir, { index: true });
  4916. // `Helper` is implementation-only (no interface decl, not a method), but its
  4917. // body's call must attribute to `Helper`, not the file/module — alongside the
  4918. // method `DoStuff`.
  4919. expect(callerNamesOf('TTgt::Hit')).toEqual(['DoStuff', 'Helper']);
  4920. });
  4921. });
  4922. describe('Nix path import resolution', () => {
  4923. function fileNode(filePath: string) {
  4924. return cg.getNodesByKind('file').find((n) => n.filePath === filePath);
  4925. }
  4926. function importedFilePaths(fromFile: string): string[] {
  4927. const source = fileNode(fromFile);
  4928. expect(source, `${fromFile} file node`).toBeDefined();
  4929. return cg
  4930. .getOutgoingEdges(source!.id)
  4931. .filter((edge) => edge.kind === 'imports')
  4932. .map((edge) => cg.getNodesByKind('file').find((n) => n.id === edge.target)?.filePath)
  4933. .filter((filePath): filePath is string => Boolean(filePath))
  4934. .sort();
  4935. }
  4936. it('resolves relative Nix imports to indexed file nodes', async () => {
  4937. fs.mkdirSync(path.join(tempDir, 'core'), { recursive: true });
  4938. fs.mkdirSync(path.join(tempDir, 'data'), { recursive: true });
  4939. fs.writeFileSync(path.join(tempDir, 'core', 'ports.nix'), '{ http = 80; https = 443; }');
  4940. fs.writeFileSync(
  4941. path.join(tempDir, 'data', 'postgresql.nix'),
  4942. `let
  4943. ports = import ../core/ports.nix;
  4944. in
  4945. {
  4946. port = ports.https;
  4947. }
  4948. `
  4949. );
  4950. cg = await CodeGraph.init(tempDir, { index: true });
  4951. cg.resolveReferences();
  4952. expect(importedFilePaths('data/postgresql.nix')).toEqual(['core/ports.nix']);
  4953. });
  4954. it('resolves Nix directory imports through default.nix and deduplicates called imports', async () => {
  4955. fs.mkdirSync(path.join(tempDir, 'dir'), { recursive: true });
  4956. fs.writeFileSync(path.join(tempDir, 'dir', 'default.nix'), '{ value = 1; }');
  4957. fs.writeFileSync(path.join(tempDir, 'x.nix'), '{ value = 2; }');
  4958. fs.writeFileSync(
  4959. path.join(tempDir, 'main.nix'),
  4960. `let
  4961. dir = import ./dir;
  4962. x = import ./x.nix {};
  4963. in
  4964. {
  4965. inherit dir x;
  4966. }
  4967. `
  4968. );
  4969. cg = await CodeGraph.init(tempDir, { index: true });
  4970. cg.resolveReferences();
  4971. expect(importedFilePaths('main.nix')).toEqual(['dir/default.nix', 'x.nix']);
  4972. });
  4973. it('resolves NixOS module imports lists and callPackage paths to file nodes', async () => {
  4974. fs.mkdirSync(path.join(tempDir, 'modules'), { recursive: true });
  4975. fs.mkdirSync(path.join(tempDir, 'common'), { recursive: true });
  4976. fs.mkdirSync(path.join(tempDir, 'pkgs', 'hello'), { recursive: true });
  4977. fs.writeFileSync(path.join(tempDir, 'modules', 'users.nix'), '{ users.users.demo.isNormalUser = true; }');
  4978. fs.writeFileSync(path.join(tempDir, 'common', 'default.nix'), '{ time.timeZone = "UTC"; }');
  4979. fs.writeFileSync(
  4980. path.join(tempDir, 'pkgs', 'hello', 'default.nix'),
  4981. '{ stdenv }: stdenv.mkDerivation { pname = "hello"; }'
  4982. );
  4983. fs.writeFileSync(
  4984. path.join(tempDir, 'configuration.nix'),
  4985. `{ config, pkgs, ... }:
  4986. {
  4987. imports = [ ./modules/users.nix ./common ];
  4988. environment.systemPackages = [ (pkgs.callPackage ./pkgs/hello { }) ];
  4989. }
  4990. `
  4991. );
  4992. cg = await CodeGraph.init(tempDir, { index: true });
  4993. cg.resolveReferences();
  4994. expect(importedFilePaths('configuration.nix')).toEqual([
  4995. 'common/default.nix',
  4996. 'modules/users.nix',
  4997. 'pkgs/hello/default.nix',
  4998. ]);
  4999. });
  5000. it('never resolves another language\'s calls into nix bindings', async () => {
  5001. // Nix bindings are not linkable symbols from any other language —
  5002. // interop is eval/CLI. Without the target-side gate, a Python script's
  5003. // bare `resolve(...)` exact-matches a module's `resolve = ...` binding.
  5004. fs.writeFileSync(
  5005. path.join(tempDir, 'helpers.nix'),
  5006. `let
  5007. resolve = x: x;
  5008. in
  5009. {
  5010. inherit resolve;
  5011. }
  5012. `
  5013. );
  5014. fs.writeFileSync(path.join(tempDir, 'tool.py'), 'def main():\n return resolve("target")\n');
  5015. cg = await CodeGraph.init(tempDir, { index: true });
  5016. cg.resolveReferences();
  5017. const nixNodeIds = new Set(
  5018. cg.getNodesByKind('variable').filter((n) => n.language === 'nix').map((n) => n.id)
  5019. );
  5020. const pyFns = cg.getNodesByKind('function').filter((n) => n.language === 'python');
  5021. expect(pyFns.length).toBeGreaterThan(0);
  5022. const crossEdges = pyFns.flatMap((f) => cg.getOutgoingEdges(f.id)).filter((e) => nixNodeIds.has(e.target));
  5023. expect(crossEdges).toEqual([]);
  5024. });
  5025. it('never cross-links Nix calls by bare name across files (lexical scope only)', async () => {
  5026. // Both modules `inherit (lib) mkOption` — the nixpkgs idiom. A call to
  5027. // mkOption in one file must NOT resolve to the other file's inherit
  5028. // binding: Nix has no ambient cross-file namespace, so any such edge is
  5029. // wrong by construction. Same-file bindings still resolve.
  5030. fs.writeFileSync(
  5031. path.join(tempDir, 'alpha.nix'),
  5032. `{ lib, ... }:
  5033. let
  5034. inherit (lib) mkOption;
  5035. mkPort = default: mkOption { inherit default; };
  5036. in
  5037. {
  5038. options.alpha.port = mkPort 8080;
  5039. }
  5040. `
  5041. );
  5042. fs.writeFileSync(
  5043. path.join(tempDir, 'beta.nix'),
  5044. `{ lib, ... }:
  5045. let
  5046. inherit (lib) mkOption;
  5047. in
  5048. {
  5049. options.beta.enable = mkOption { default = false; };
  5050. }
  5051. `
  5052. );
  5053. cg = await CodeGraph.init(tempDir, { index: true });
  5054. cg.resolveReferences();
  5055. const crossFileCalls = cg
  5056. .getNodesByKind('file')
  5057. .flatMap((f) => cg.getOutgoingEdges(f.id))
  5058. .concat(
  5059. cg.getNodesByKind('function').flatMap((f) => cg.getOutgoingEdges(f.id)),
  5060. cg.getNodesByKind('variable').flatMap((v) => cg.getOutgoingEdges(v.id))
  5061. )
  5062. .filter((e) => e.kind === 'calls')
  5063. .map((e) => {
  5064. const src = cg.getNode(e.source);
  5065. const tgt = cg.getNode(e.target);
  5066. return { from: src?.filePath, to: tgt?.filePath, name: tgt?.name };
  5067. });
  5068. // No calls edge may cross files by bare-name matching.
  5069. expect(crossFileCalls.filter((e) => e.from !== e.to)).toEqual([]);
  5070. // The same-file chain still resolves: mkPort's mkOption call hits
  5071. // alpha.nix's own inherit binding.
  5072. const sameFile = crossFileCalls.filter((e) => e.from === e.to && e.name === 'mkOption');
  5073. expect(sameFile.length).toBeGreaterThan(0);
  5074. expect(sameFile.every((e) => e.from === 'alpha.nix' || e.from === 'beta.nix')).toBe(true);
  5075. });
  5076. it('does not resolve Nix angle-bracket, attribute, or variable imports as project file edges', async () => {
  5077. fs.writeFileSync(path.join(tempDir, 'nixpkgs.nix'), '{ bogus = true; }');
  5078. fs.writeFileSync(path.join(tempDir, 'selectedPath.nix'), '{ bogus = true; }');
  5079. fs.writeFileSync(
  5080. path.join(tempDir, 'main.nix'),
  5081. `let
  5082. pkgs = import <nixpkgs> {};
  5083. fromSources = import sources.nixpkgs {};
  5084. dynamic = import selectedPath;
  5085. in
  5086. {
  5087. inherit pkgs fromSources dynamic;
  5088. }
  5089. `
  5090. );
  5091. cg = await CodeGraph.init(tempDir, { index: true });
  5092. cg.resolveReferences();
  5093. expect(importedFilePaths('main.nix')).toEqual([]);
  5094. });
  5095. });
  5096. describe('Bindings in a module that exports nothing (#1719)', () => {
  5097. it('does not treat documentation headings as package imports', () => {
  5098. // Inject the planned Markdown node shape without depending on its extractor.
  5099. const heading: Node = {
  5100. id: 'heading:vite', name: 'vite', qualifiedName: 'guide.md#vite',
  5101. kind: 'module', language: 'markdown' as Node['language'], filePath: 'guide.md',
  5102. startLine: 1, endLine: 1, startColumn: 0, endColumn: 0, updatedAt: 0,
  5103. };
  5104. const context = {
  5105. getNodesByName: () => [heading], getNodesInFile: () => [],
  5106. getNodesByQualifiedName: () => [], getNodesByKind: () => [],
  5107. fileExists: () => false, readFile: () => null,
  5108. getProjectRoot: () => tempDir, getAllFiles: () => [],
  5109. } as ResolutionContext;
  5110. const ref: UnresolvedRef = {
  5111. fromNodeId: 'file:consumer.ts', referenceName: 'vite', referenceKind: 'imports',
  5112. filePath: 'consumer.ts', language: 'typescript', line: 1, column: 0,
  5113. };
  5114. expect(matchByExactName(ref, context)).toBeNull();
  5115. expect(matchByExactName({ ...ref, language: 'markdown' as Node['language'] }, context)?.targetNodeId).toBe(heading.id);
  5116. context.getNodesByName = () => [{ ...heading, id: 'fn:vite', kind: 'function', language: 'typescript', filePath: 'vite.ts' }];
  5117. expect(matchByExactName(ref, context)?.targetNodeId).toBe('fn:vite');
  5118. });
  5119. it('ignores export examples in strings and comments when checking module visibility', async () => {
  5120. fs.mkdirSync(path.join(tempDir, 'src'));
  5121. fs.writeFileSync(path.join(tempDir, 'src/private.js'), [
  5122. "import fs from 'node:fs'",
  5123. 'const example = `',
  5124. 'export const example = 1',
  5125. '`',
  5126. '/*',
  5127. 'export { hidden }',
  5128. '*/',
  5129. 'function hidden() { return fs }',
  5130. 'hidden()',
  5131. ].join('\n'));
  5132. fs.writeFileSync(path.join(tempDir, 'src/consumer.js'), 'hidden()');
  5133. fs.mkdirSync(path.join(tempDir, 'legacy'));
  5134. fs.writeFileSync(path.join(tempDir, 'legacy/global.js'), 'function hidden() { return 1 }');
  5135. cg = await CodeGraph.init(tempDir, { index: true });
  5136. cg.resolveReferences();
  5137. const hidden = cg.getNodesByKind('function').find((n) => n.name === 'hidden' && n.filePath === 'src/private.js');
  5138. expect(hidden).toBeDefined();
  5139. const callers = cg.getIncomingEdges(hidden!.id).filter((e) => e.kind === 'calls');
  5140. expect(callers.some((e) => cg.getNode(e.source)?.filePath === 'src/consumer.js')).toBe(false);
  5141. expect(callers.some((e) => cg.getNode(e.source)?.filePath === 'src/private.js')).toBe(true);
  5142. const consumer = cg.getNodesByKind('file').find((n) => n.filePath === 'src/consumer.js');
  5143. expect(cg.getOutgoingEdges(consumer!.id).filter((e) => e.kind === 'calls')).toEqual([]);
  5144. });
  5145. it('does not name-match a method call to another file\'s JSON value', async () => {
  5146. fs.writeFileSync(path.join(tempDir, 'data.json'), '{"content": "hello"}');
  5147. fs.writeFileSync(path.join(tempDir, 'data.js'), "const content = require('./data.json')\nmodule.exports = { content }\n");
  5148. fs.writeFileSync(path.join(tempDir, 'consumer.js'), 'export async function read(page) { return page.frame("main").content() }');
  5149. fs.writeFileSync(path.join(tempDir, 'use-data.js'), "import { content } from './data'\nconsole.log(content)\n");
  5150. fs.writeFileSync(path.join(tempDir, 'callback.js'), "const callback = require('./handler.js')\nmodule.exports = { callback }\n");
  5151. fs.writeFileSync(path.join(tempDir, 'call.js'), 'callback()');
  5152. cg = await CodeGraph.init(tempDir, { index: true });
  5153. cg.resolveReferences();
  5154. const content = cg.getNodesByKind('constant').find((n) => n.name === 'content');
  5155. expect(content).toBeDefined();
  5156. expect(cg.getIncomingEdges(content!.id).filter((e) => e.kind === 'calls')).toEqual([]);
  5157. expect(cg.getIncomingEdges(content!.id).some((e) => e.kind === 'imports')).toBe(true);
  5158. const callback = cg.getNodesByKind('constant').find((n) => n.name === 'callback');
  5159. expect(callback).toBeDefined();
  5160. expect(cg.getIncomingEdges(callback!.id).some((e) => e.kind === 'calls')).toBe(true);
  5161. });
  5162. it('keeps a local file dependency import when a closer private name collides', async () => {
  5163. fs.writeFileSync(path.join(tempDir, 'package.json'), JSON.stringify({ dependencies: { 'local-dep': 'file:./dep' } }));
  5164. fs.mkdirSync(path.join(tempDir, 'dep'));
  5165. fs.mkdirSync(path.join(tempDir, 'src'));
  5166. fs.writeFileSync(path.join(tempDir, 'dep/package.json'), JSON.stringify({ name: 'local-dep', main: 'index.js' }));
  5167. fs.writeFileSync(path.join(tempDir, 'dep/index.js'), "export const msg = 'local'\n");
  5168. fs.writeFileSync(path.join(tempDir, 'src/private.js'), "import fs from 'node:fs'\nconst msg = 'private'\n");
  5169. fs.writeFileSync(path.join(tempDir, 'src/consumer.js'), "import { msg } from 'local-dep'\nconsole.log(msg)\n");
  5170. cg = await CodeGraph.init(tempDir, { index: true });
  5171. cg.resolveReferences();
  5172. const msg = cg.getNodesByKind('constant').find((n) => n.name === 'msg' && n.filePath === 'dep/index.js');
  5173. expect(msg).toBeDefined();
  5174. expect(cg.getIncomingEdges(msg!.id).some((e) => e.kind === 'imports')).toBe(true);
  5175. });
  5176. it('preserves executable CommonJS exports inside nested template interpolations', async () => {
  5177. fs.writeFileSync(path.join(tempDir, 'cjs.js'), [
  5178. "import fs from 'node:fs'",
  5179. 'function helper() { return fs }',
  5180. 'const text = `outer ${`inner ${module.exports = { helper }}`}`',
  5181. ].join('\n'));
  5182. fs.writeFileSync(path.join(tempDir, 'consumer.js'), 'helper()');
  5183. cg = await CodeGraph.init(tempDir, { index: true });
  5184. cg.resolveReferences();
  5185. const helper = cg.getNodesByKind('function').find((n) => n.name === 'helper');
  5186. expect(helper).toBeDefined();
  5187. expect(cg.getIncomingEdges(helper!.id).some((e) =>
  5188. e.kind === 'calls' && cg.getNode(e.source)?.filePath === 'consumer.js')).toBe(true);
  5189. });
  5190. it.each(['export function visible() { return fs }', 'function visible() { return fs }\nexport { visible }'])('preserves real exports after a regex containing a backtick: %s', async (declaration) => {
  5191. fs.writeFileSync(path.join(tempDir, 'exported.js'), "import fs from 'node:fs'\nconst re = /`/\nif (fs) /`/.test('text')\nelse /`/.test('other')\nconst make = () => /`/\n" + declaration + '\n');
  5192. fs.writeFileSync(path.join(tempDir, 'consumer.js'), 'visible()');
  5193. cg = await CodeGraph.init(tempDir, { index: true });
  5194. cg.resolveReferences();
  5195. const visible = cg.getNodesByKind('function').find((n) => n.name === 'visible');
  5196. expect(visible).toBeDefined();
  5197. expect(cg.getIncomingEdges(visible!.id).some((e) => e.kind === 'calls')).toBe(true);
  5198. });
  5199. // On vitejs/vite, every `import { defineConfig } from 'vite'` across the
  5200. // playground resolved onto `playground/ssr-html/test-stacktrace.js::vite`
  5201. // — `const vite = await createServer(…)` at module scope in a file with
  5202. // zero exports — because exact-match commits whenever one candidate
  5203. // survives, and nothing asked whether an import could reach it. Only
  5204. // `sealed.js` may be filtered; every other file here is a class that must
  5205. // NOT be — a classic script (a top-level binding really is a reachable
  5206. // global), a CommonJS module, one exporting through `exports["x"]`, an ESM
  5207. // file whose export is a later `export { … }` statement (which leaves
  5208. // `isExported` false on the declaration's node), and one contributing a
  5209. // name through `declare global` while exporting nothing of its own.
  5210. let tmpDir: string;
  5211. let cg: CodeGraph;
  5212. afterEach(() => {
  5213. cg?.close();
  5214. if (tmpDir) fs.rmSync(tmpDir, { recursive: true, force: true });
  5215. });
  5216. it('drops them as cross-file candidates, and keeps scripts, CJS and later exports', async () => {
  5217. tmpDir = fs.mkdtempSync(path.join(os.tmpdir(), 'codegraph-1719-'));
  5218. fs.writeFileSync(
  5219. path.join(tmpDir, 'sealed.js'),
  5220. `import fsp from 'node:fs/promises'
  5221. function widget() {
  5222. return fsp
  5223. }
  5224. widget()
  5225. `
  5226. );
  5227. fs.writeFileSync(
  5228. path.join(tmpDir, 'script.js'),
  5229. `function gadget() {
  5230. return 1
  5231. }
  5232. `
  5233. );
  5234. fs.writeFileSync(
  5235. path.join(tmpDir, 'cjs.js'),
  5236. `import osp from 'node:os'
  5237. function helper() {
  5238. return osp
  5239. }
  5240. module.exports = { helper }
  5241. `
  5242. );
  5243. fs.writeFileSync(
  5244. path.join(tmpDir, 'later.js'),
  5245. `import pathp from 'node:path'
  5246. function parser() {
  5247. return pathp
  5248. }
  5249. export { parser }
  5250. `
  5251. );
  5252. // `exports["x"]` is a CommonJS export too, and a file declaring globals
  5253. // offers them to every other file whether or not it exports anything of
  5254. // its own. Both would read as sealed on a test that looked only for
  5255. // `export …`, `module.exports` and `exports.x`.
  5256. fs.writeFileSync(
  5257. path.join(tmpDir, 'bracket.js'),
  5258. `import urlp from 'node:url'
  5259. function bracketed() {
  5260. return urlp
  5261. }
  5262. exports["bracketed"] = bracketed
  5263. `
  5264. );
  5265. // A module with imports and no export of its own still contributes every
  5266. // name in `declare global` to every other file. `plain.ts` is the control
  5267. // that makes the assertion mean something: it is the same "import, no
  5268. // export" shape holding the same kind of declaration, so the pair differs
  5269. // only by the `declare global`, and an assertion on StrayFace alone would
  5270. // pass whatever the guard did.
  5271. fs.writeFileSync(
  5272. path.join(tmpDir, 'ambient.ts'),
  5273. `import './later'
  5274. declare global {
  5275. interface StrayFace {
  5276. a: number
  5277. }
  5278. }
  5279. `
  5280. );
  5281. fs.writeFileSync(
  5282. path.join(tmpDir, 'plain.ts'),
  5283. `import './later'
  5284. interface HiddenFace {
  5285. a: number
  5286. }
  5287. const unused: HiddenFace = { a: 1 }
  5288. `
  5289. );
  5290. // A type annotation is the reference here, so this consumer must be .ts.
  5291. fs.writeFileSync(
  5292. path.join(tmpDir, 'consumer.ts'),
  5293. `const face: StrayFace = { a: 1 }
  5294. const hidden: HiddenFace = { a: 2 }
  5295. export function use(): number {
  5296. return face.a + hidden.a
  5297. }
  5298. `
  5299. );
  5300. // Nothing here is bound by an import, so every name is a free reference
  5301. // that falls through to exact name matching — the path this rule sits on.
  5302. // A bare import would reach that path too, but a bare specifier names a
  5303. // package outside the graph, so no project node is the right target for
  5304. // it and such a fixture would assert a resolution nothing should make.
  5305. fs.writeFileSync(
  5306. path.join(tmpDir, 'consumer.js'),
  5307. `widget()
  5308. gadget()
  5309. helper()
  5310. parser()
  5311. bracketed()
  5312. `
  5313. );
  5314. cg = await CodeGraph.init(tmpDir, { index: true });
  5315. cg.resolveReferences();
  5316. // Incoming edges rather than callers, so the interfaces are asked the
  5317. // same question as the functions: a type annotation is a reference, not
  5318. // a call.
  5319. const reachedFrom = (consumer: string, name: string): boolean => {
  5320. const target = cg
  5321. .searchNodes(name, { limit: 10 })
  5322. .find((r) => r.node.name === name && r.node.filePath !== consumer);
  5323. expect(target, `no node named ${name}`).toBeDefined();
  5324. return cg
  5325. .getIncomingEdges(target!.node.id)
  5326. .some((e) => cg.getNode(e.source)?.filePath === consumer);
  5327. };
  5328. expect(reachedFrom('consumer.js', 'widget')).toBe(false);
  5329. expect(reachedFrom('consumer.js', 'gadget')).toBe(true);
  5330. expect(reachedFrom('consumer.js', 'helper')).toBe(true);
  5331. expect(reachedFrom('consumer.js', 'parser')).toBe(true);
  5332. expect(reachedFrom('consumer.js', 'bracketed')).toBe(true);
  5333. expect(reachedFrom('consumer.ts', 'StrayFace')).toBe(true);
  5334. expect(reachedFrom('consumer.ts', 'HiddenFace')).toBe(false);
  5335. }, 30000);
  5336. });
  5337. });