resolution.test.ts 180 KB

12345678910111213141516171819202122232425262728293031323334353637383940414243444546474849505152535455565758596061626364656667686970717273747576777879808182838485868788899091929394959697989910010110210310410510610710810911011111211311411511611711811912012112212312412512612712812913013113213313413513613713813914014114214314414514614714814915015115215315415515615715815916016116216316416516616716816917017117217317417517617717817918018118218318418518618718818919019119219319419519619719819920020120220320420520620720820921021121221321421521621721821922022122222322422522622722822923023123223323423523623723823924024124224324424524624724824925025125225325425525625725825926026126226326426526626726826927027127227327427527627727827928028128228328428528628728828929029129229329429529629729829930030130230330430530630730830931031131231331431531631731831932032132232332432532632732832933033133233333433533633733833934034134234334434534634734834935035135235335435535635735835936036136236336436536636736836937037137237337437537637737837938038138238338438538638738838939039139239339439539639739839940040140240340440540640740840941041141241341441541641741841942042142242342442542642742842943043143243343443543643743843944044144244344444544644744844945045145245345445545645745845946046146246346446546646746846947047147247347447547647747847948048148248348448548648748848949049149249349449549649749849950050150250350450550650750850951051151251351451551651751851952052152252352452552652752852953053153253353453553653753853954054154254354454554654754854955055155255355455555655755855956056156256356456556656756856957057157257357457557657757857958058158258358458558658758858959059159259359459559659759859960060160260360460560660760860961061161261361461561661761861962062162262362462562662762862963063163263363463563663763863964064164264364464564664764864965065165265365465565665765865966066166266366466566666766866967067167267367467567667767867968068168268368468568668768868969069169269369469569669769869970070170270370470570670770870971071171271371471571671771871972072172272372472572672772872973073173273373473573673773873974074174274374474574674774874975075175275375475575675775875976076176276376476576676776876977077177277377477577677777877978078178278378478578678778878979079179279379479579679779879980080180280380480580680780880981081181281381481581681781881982082182282382482582682782882983083183283383483583683783883984084184284384484584684784884985085185285385485585685785885986086186286386486586686786886987087187287387487587687787887988088188288388488588688788888989089189289389489589689789889990090190290390490590690790890991091191291391491591691791891992092192292392492592692792892993093193293393493593693793893994094194294394494594694794894995095195295395495595695795895996096196296396496596696796896997097197297397497597697797897998098198298398498598698798898999099199299399499599699799899910001001100210031004100510061007100810091010101110121013101410151016101710181019102010211022102310241025102610271028102910301031103210331034103510361037103810391040104110421043104410451046104710481049105010511052105310541055105610571058105910601061106210631064106510661067106810691070107110721073107410751076107710781079108010811082108310841085108610871088108910901091109210931094109510961097109810991100110111021103110411051106110711081109111011111112111311141115111611171118111911201121112211231124112511261127112811291130113111321133113411351136113711381139114011411142114311441145114611471148114911501151115211531154115511561157115811591160116111621163116411651166116711681169117011711172117311741175117611771178117911801181118211831184118511861187118811891190119111921193119411951196119711981199120012011202120312041205120612071208120912101211121212131214121512161217121812191220122112221223122412251226122712281229123012311232123312341235123612371238123912401241124212431244124512461247124812491250125112521253125412551256125712581259126012611262126312641265126612671268126912701271127212731274127512761277127812791280128112821283128412851286128712881289129012911292129312941295129612971298129913001301130213031304130513061307130813091310131113121313131413151316131713181319132013211322132313241325132613271328132913301331133213331334133513361337133813391340134113421343134413451346134713481349135013511352135313541355135613571358135913601361136213631364136513661367136813691370137113721373137413751376137713781379138013811382138313841385138613871388138913901391139213931394139513961397139813991400140114021403140414051406140714081409141014111412141314141415141614171418141914201421142214231424142514261427142814291430143114321433143414351436143714381439144014411442144314441445144614471448144914501451145214531454145514561457145814591460146114621463146414651466146714681469147014711472147314741475147614771478147914801481148214831484148514861487148814891490149114921493149414951496149714981499150015011502150315041505150615071508150915101511151215131514151515161517151815191520152115221523152415251526152715281529153015311532153315341535153615371538153915401541154215431544154515461547154815491550155115521553155415551556155715581559156015611562156315641565156615671568156915701571157215731574157515761577157815791580158115821583158415851586158715881589159015911592159315941595159615971598159916001601160216031604160516061607160816091610161116121613161416151616161716181619162016211622162316241625162616271628162916301631163216331634163516361637163816391640164116421643164416451646164716481649165016511652165316541655165616571658165916601661166216631664166516661667166816691670167116721673167416751676167716781679168016811682168316841685168616871688168916901691169216931694169516961697169816991700170117021703170417051706170717081709171017111712171317141715171617171718171917201721172217231724172517261727172817291730173117321733173417351736173717381739174017411742174317441745174617471748174917501751175217531754175517561757175817591760176117621763176417651766176717681769177017711772177317741775177617771778177917801781178217831784178517861787178817891790179117921793179417951796179717981799180018011802180318041805180618071808180918101811181218131814181518161817181818191820182118221823182418251826182718281829183018311832183318341835183618371838183918401841184218431844184518461847184818491850185118521853185418551856185718581859186018611862186318641865186618671868186918701871187218731874187518761877187818791880188118821883188418851886188718881889189018911892189318941895189618971898189919001901190219031904190519061907190819091910191119121913191419151916191719181919192019211922192319241925192619271928192919301931193219331934193519361937193819391940194119421943194419451946194719481949195019511952195319541955195619571958195919601961196219631964196519661967196819691970197119721973197419751976197719781979198019811982198319841985198619871988198919901991199219931994199519961997199819992000200120022003200420052006200720082009201020112012201320142015201620172018201920202021202220232024202520262027202820292030203120322033203420352036203720382039204020412042204320442045204620472048204920502051205220532054205520562057205820592060206120622063206420652066206720682069207020712072207320742075207620772078207920802081208220832084208520862087208820892090209120922093209420952096209720982099210021012102210321042105210621072108210921102111211221132114211521162117211821192120212121222123212421252126212721282129213021312132213321342135213621372138213921402141214221432144214521462147214821492150215121522153215421552156215721582159216021612162216321642165216621672168216921702171217221732174217521762177217821792180218121822183218421852186218721882189219021912192219321942195219621972198219922002201220222032204220522062207220822092210221122122213221422152216221722182219222022212222222322242225222622272228222922302231223222332234223522362237223822392240224122422243224422452246224722482249225022512252225322542255225622572258225922602261226222632264226522662267226822692270227122722273227422752276227722782279228022812282228322842285228622872288228922902291229222932294229522962297229822992300230123022303230423052306230723082309231023112312231323142315231623172318231923202321232223232324232523262327232823292330233123322333233423352336233723382339234023412342234323442345234623472348234923502351235223532354235523562357235823592360236123622363236423652366236723682369237023712372237323742375237623772378237923802381238223832384238523862387238823892390239123922393239423952396239723982399240024012402240324042405240624072408240924102411241224132414241524162417241824192420242124222423242424252426242724282429243024312432243324342435243624372438243924402441244224432444244524462447244824492450245124522453245424552456245724582459246024612462246324642465246624672468246924702471247224732474247524762477247824792480248124822483248424852486248724882489249024912492249324942495249624972498249925002501250225032504250525062507250825092510251125122513251425152516251725182519252025212522252325242525252625272528252925302531253225332534253525362537253825392540254125422543254425452546254725482549255025512552255325542555255625572558255925602561256225632564256525662567256825692570257125722573257425752576257725782579258025812582258325842585258625872588258925902591259225932594259525962597259825992600260126022603260426052606260726082609261026112612261326142615261626172618261926202621262226232624262526262627262826292630263126322633263426352636263726382639264026412642264326442645264626472648264926502651265226532654265526562657265826592660266126622663266426652666266726682669267026712672267326742675267626772678267926802681268226832684268526862687268826892690269126922693269426952696269726982699270027012702270327042705270627072708270927102711271227132714271527162717271827192720272127222723272427252726272727282729273027312732273327342735273627372738273927402741274227432744274527462747274827492750275127522753275427552756275727582759276027612762276327642765276627672768276927702771277227732774277527762777277827792780278127822783278427852786278727882789279027912792279327942795279627972798279928002801280228032804280528062807280828092810281128122813281428152816281728182819282028212822282328242825282628272828282928302831283228332834283528362837283828392840284128422843284428452846284728482849285028512852285328542855285628572858285928602861286228632864286528662867286828692870287128722873287428752876287728782879288028812882288328842885288628872888288928902891289228932894289528962897289828992900290129022903290429052906290729082909291029112912291329142915291629172918291929202921292229232924292529262927292829292930293129322933293429352936293729382939294029412942294329442945294629472948294929502951295229532954295529562957295829592960296129622963296429652966296729682969297029712972297329742975297629772978297929802981298229832984298529862987298829892990299129922993299429952996299729982999300030013002300330043005300630073008300930103011301230133014301530163017301830193020302130223023302430253026302730283029303030313032303330343035303630373038303930403041304230433044304530463047304830493050305130523053305430553056305730583059306030613062306330643065306630673068306930703071307230733074307530763077307830793080308130823083308430853086308730883089309030913092309330943095309630973098309931003101310231033104310531063107310831093110311131123113311431153116311731183119312031213122312331243125312631273128312931303131313231333134313531363137313831393140314131423143314431453146314731483149315031513152315331543155315631573158315931603161316231633164316531663167316831693170317131723173317431753176317731783179318031813182318331843185318631873188318931903191319231933194319531963197319831993200320132023203320432053206320732083209321032113212321332143215321632173218321932203221322232233224322532263227322832293230323132323233323432353236323732383239324032413242324332443245324632473248324932503251325232533254325532563257325832593260326132623263326432653266326732683269327032713272327332743275327632773278327932803281328232833284328532863287328832893290329132923293329432953296329732983299330033013302330333043305330633073308330933103311331233133314331533163317331833193320332133223323332433253326332733283329333033313332333333343335333633373338333933403341334233433344334533463347334833493350335133523353335433553356335733583359336033613362336333643365336633673368336933703371337233733374337533763377337833793380338133823383338433853386338733883389339033913392339333943395339633973398339934003401340234033404340534063407340834093410341134123413341434153416341734183419342034213422342334243425342634273428342934303431343234333434343534363437343834393440344134423443344434453446344734483449345034513452345334543455345634573458345934603461346234633464346534663467346834693470347134723473347434753476347734783479348034813482348334843485348634873488348934903491349234933494349534963497349834993500350135023503350435053506350735083509351035113512351335143515351635173518351935203521352235233524352535263527352835293530353135323533353435353536353735383539354035413542354335443545354635473548354935503551355235533554355535563557355835593560356135623563356435653566356735683569357035713572357335743575357635773578357935803581358235833584358535863587358835893590359135923593359435953596359735983599360036013602360336043605360636073608360936103611361236133614361536163617361836193620362136223623362436253626362736283629363036313632363336343635363636373638363936403641364236433644364536463647364836493650365136523653365436553656365736583659366036613662366336643665366636673668366936703671367236733674367536763677367836793680368136823683368436853686368736883689369036913692369336943695369636973698369937003701370237033704370537063707370837093710371137123713371437153716371737183719372037213722372337243725372637273728372937303731373237333734373537363737373837393740374137423743374437453746374737483749375037513752375337543755375637573758375937603761376237633764376537663767376837693770377137723773377437753776377737783779378037813782378337843785378637873788378937903791379237933794379537963797379837993800380138023803380438053806380738083809381038113812381338143815381638173818381938203821382238233824382538263827382838293830383138323833383438353836383738383839384038413842384338443845384638473848384938503851385238533854385538563857385838593860386138623863386438653866386738683869387038713872387338743875387638773878387938803881388238833884388538863887388838893890389138923893389438953896389738983899390039013902390339043905390639073908390939103911391239133914391539163917391839193920392139223923392439253926392739283929393039313932393339343935393639373938393939403941394239433944394539463947394839493950395139523953395439553956395739583959396039613962396339643965396639673968396939703971397239733974397539763977397839793980398139823983398439853986398739883989399039913992399339943995399639973998399940004001400240034004400540064007400840094010401140124013401440154016401740184019402040214022402340244025402640274028402940304031403240334034403540364037403840394040404140424043404440454046404740484049405040514052405340544055405640574058405940604061406240634064406540664067406840694070407140724073407440754076407740784079408040814082408340844085408640874088408940904091409240934094409540964097409840994100410141024103410441054106410741084109411041114112411341144115411641174118411941204121412241234124412541264127412841294130413141324133413441354136413741384139414041414142414341444145414641474148414941504151415241534154415541564157415841594160416141624163416441654166416741684169417041714172417341744175417641774178417941804181418241834184418541864187418841894190419141924193419441954196419741984199420042014202420342044205420642074208420942104211421242134214421542164217421842194220422142224223422442254226422742284229423042314232423342344235423642374238423942404241424242434244424542464247424842494250425142524253425442554256425742584259426042614262426342644265426642674268426942704271427242734274427542764277427842794280428142824283428442854286428742884289429042914292429342944295429642974298429943004301430243034304430543064307430843094310431143124313431443154316431743184319432043214322432343244325432643274328432943304331433243334334433543364337433843394340434143424343434443454346434743484349435043514352435343544355435643574358435943604361436243634364436543664367436843694370437143724373437443754376437743784379438043814382438343844385438643874388438943904391439243934394439543964397439843994400440144024403440444054406440744084409441044114412441344144415441644174418441944204421442244234424442544264427442844294430443144324433443444354436443744384439444044414442444344444445444644474448444944504451445244534454445544564457445844594460446144624463446444654466446744684469447044714472447344744475447644774478447944804481448244834484448544864487448844894490449144924493449444954496449744984499450045014502450345044505450645074508450945104511451245134514451545164517451845194520452145224523452445254526452745284529453045314532453345344535453645374538453945404541454245434544454545464547454845494550455145524553455445554556455745584559456045614562456345644565456645674568456945704571457245734574457545764577457845794580458145824583458445854586458745884589459045914592459345944595459645974598459946004601460246034604460546064607460846094610461146124613461446154616461746184619462046214622462346244625462646274628462946304631463246334634463546364637463846394640464146424643464446454646464746484649465046514652465346544655465646574658465946604661466246634664466546664667
  1. /**
  2. * Resolution Module Tests
  3. *
  4. * Tests for Phase 3: Reference Resolution
  5. */
  6. import { describe, it, expect, beforeEach, afterEach } from 'vitest';
  7. import * as fs from 'fs';
  8. import * as path from 'path';
  9. import * as os from 'os';
  10. import { CodeGraph } from '../src';
  11. import { Node, UnresolvedReference } from '../src/types';
  12. import { ReferenceResolver, createResolver, ResolutionContext } from '../src/resolution';
  13. import { matchReference, resolveMethodOnType, matchByQualifiedName, preferCallSiteFile, matchMethodCall } from '../src/resolution/name-matcher';
  14. import { resolveImportPath, extractImportMappings, resolveJvmImport, loadCppIncludeDirs, clearCppIncludeDirCache, isPhpIncludePathRef } from '../src/resolution/import-resolver';
  15. import type { UnresolvedRef } from '../src/resolution/types';
  16. import { detectFrameworks, getAllFrameworkResolvers } from '../src/resolution/frameworks';
  17. import { QueryBuilder } from '../src/db/queries';
  18. import { DatabaseConnection } from '../src/db';
  19. describe('Resolution Module', () => {
  20. let tempDir: string;
  21. let cg: CodeGraph;
  22. beforeEach(() => {
  23. // Create temp directory
  24. tempDir = fs.mkdtempSync(path.join(os.tmpdir(), 'codegraph-resolution-test-'));
  25. });
  26. afterEach(() => {
  27. // Clean up
  28. if (cg) {
  29. cg.destroy();
  30. } else if (fs.existsSync(tempDir)) {
  31. fs.rmSync(tempDir, { recursive: true });
  32. }
  33. });
  34. describe('Name Matcher', () => {
  35. it('should match exact name references', () => {
  36. // Create a mock context
  37. const mockNodes: Node[] = [
  38. {
  39. id: 'func:test.ts:myFunction:10',
  40. kind: 'function',
  41. name: 'myFunction',
  42. qualifiedName: 'test.ts::myFunction',
  43. filePath: 'test.ts',
  44. language: 'typescript',
  45. startLine: 10,
  46. endLine: 20,
  47. startColumn: 0,
  48. endColumn: 0,
  49. updatedAt: Date.now(),
  50. },
  51. ];
  52. const context: ResolutionContext = {
  53. getNodesInFile: () => mockNodes,
  54. getNodesByName: (name) => mockNodes.filter((n) => n.name === name),
  55. getNodesByQualifiedName: () => [],
  56. getNodesByKind: () => [],
  57. fileExists: () => true,
  58. readFile: () => null,
  59. getProjectRoot: () => '/test',
  60. getAllFiles: () => ['test.ts'],
  61. };
  62. const ref = {
  63. fromNodeId: 'caller:main.ts:caller:5',
  64. referenceName: 'myFunction',
  65. referenceKind: 'calls' as const,
  66. line: 5,
  67. column: 10,
  68. filePath: 'main.ts',
  69. language: 'typescript' as const,
  70. };
  71. const result = matchReference(ref, context);
  72. expect(result).not.toBeNull();
  73. expect(result?.targetNodeId).toBe('func:test.ts:myFunction:10');
  74. expect(result?.resolvedBy).toBe('exact-match');
  75. });
  76. it('should resolve Erlang -behaviour refs only to module namespaces', () => {
  77. // On emqx, `-behaviour(supervisor)` (OTP behaviour, not in the repo)
  78. // fell through to bare-name matching and resolved to a
  79. // `-define(supervisor, ...)` macro constant in an unrelated app.
  80. const macroConstant: Node = {
  81. id: 'constant:apps/bridge/src/impl.erl:supervisor:61',
  82. kind: 'constant',
  83. name: 'supervisor',
  84. qualifiedName: 'impl::supervisor',
  85. filePath: 'apps/bridge/src/impl.erl',
  86. language: 'erlang',
  87. startLine: 61,
  88. endLine: 61,
  89. startColumn: 0,
  90. endColumn: 0,
  91. updatedAt: Date.now(),
  92. };
  93. const behaviourModule: Node = {
  94. id: 'namespace:src/my_behaviour.erl:my_behaviour:1',
  95. kind: 'namespace',
  96. name: 'my_behaviour',
  97. qualifiedName: 'my_behaviour',
  98. filePath: 'src/my_behaviour.erl',
  99. language: 'erlang',
  100. startLine: 1,
  101. endLine: 1,
  102. startColumn: 0,
  103. endColumn: 0,
  104. updatedAt: Date.now(),
  105. };
  106. const nodes = [macroConstant, behaviourModule];
  107. const context: ResolutionContext = {
  108. getNodesInFile: () => [],
  109. getNodesByName: (name) => nodes.filter((n) => n.name === name),
  110. getNodesByQualifiedName: () => [],
  111. getNodesByKind: () => [],
  112. fileExists: () => false,
  113. readFile: () => null,
  114. getProjectRoot: () => '/test',
  115. getAllFiles: () => [],
  116. getNodesByLowerName: () => [],
  117. getImportMappings: () => [],
  118. };
  119. const mkRef = (name: string) => ({
  120. fromNodeId: 'namespace:src/worker.erl:worker:1',
  121. referenceName: name,
  122. referenceKind: 'implements' as const,
  123. line: 2,
  124. column: 0,
  125. filePath: 'src/worker.erl',
  126. language: 'erlang' as const,
  127. });
  128. // Out-of-repo behaviour whose name collides with a macro constant:
  129. // stays unresolved instead of linking the constant.
  130. expect(matchReference(mkRef('supervisor'), context)).toBeNull();
  131. // In-repo behaviour module resolves to its namespace.
  132. const resolved = matchReference(mkRef('my_behaviour'), context);
  133. expect(resolved?.targetNodeId).toBe(behaviourModule.id);
  134. // The same module-only rule covers refs emitted by .app/.app.src
  135. // resource files: on emqx, the `ssl` OTP app dependency resolved to a
  136. // test helper FUNCTION named ssl. A colliding non-module name stays
  137. // unresolved; a real umbrella-sibling module resolves.
  138. nodes.push({
  139. id: 'function:test/ldap_SUITE.erl:ssl:12',
  140. kind: 'function',
  141. name: 'ssl',
  142. qualifiedName: 'ldap_SUITE::ssl',
  143. filePath: 'test/ldap_SUITE.erl',
  144. language: 'erlang',
  145. startLine: 12,
  146. endLine: 14,
  147. startColumn: 0,
  148. endColumn: 0,
  149. updatedAt: Date.now(),
  150. });
  151. const appRef = (name: string) => ({
  152. fromNodeId: 'file:src/myapp.app.src',
  153. referenceName: name,
  154. referenceKind: 'imports' as const,
  155. line: 6,
  156. column: 0,
  157. filePath: 'src/myapp.app.src',
  158. language: 'erlang' as const,
  159. });
  160. expect(matchReference(appRef('ssl'), context)).toBeNull();
  161. expect(matchReference(appRef('my_behaviour'), context)?.targetNodeId).toBe(behaviourModule.id);
  162. });
  163. it('should prefer same-module candidates over cross-module matches', () => {
  164. // Simulates a Python monorepo where multiple apps define navigate()
  165. const candidateA: Node = {
  166. id: 'func:apps/app_a/src/server.py:navigate:10',
  167. kind: 'function',
  168. name: 'navigate',
  169. qualifiedName: 'apps/app_a/src/server.py::navigate',
  170. filePath: 'apps/app_a/src/server.py',
  171. language: 'python',
  172. startLine: 10,
  173. endLine: 20,
  174. startColumn: 0,
  175. endColumn: 0,
  176. updatedAt: Date.now(),
  177. };
  178. const candidateB: Node = {
  179. id: 'func:apps/app_b/src/server.py:navigate:15',
  180. kind: 'function',
  181. name: 'navigate',
  182. qualifiedName: 'apps/app_b/src/server.py::navigate',
  183. filePath: 'apps/app_b/src/server.py',
  184. language: 'python',
  185. startLine: 15,
  186. endLine: 25,
  187. startColumn: 0,
  188. endColumn: 0,
  189. updatedAt: Date.now(),
  190. };
  191. const context: ResolutionContext = {
  192. getNodesInFile: () => [],
  193. getNodesByName: (name) => name === 'navigate' ? [candidateA, candidateB] : [],
  194. getNodesByQualifiedName: () => [],
  195. getNodesByKind: () => [],
  196. fileExists: () => true,
  197. readFile: () => null,
  198. getProjectRoot: () => '/test',
  199. getAllFiles: () => [],
  200. getNodesByLowerName: () => [],
  201. getImportMappings: () => [],
  202. };
  203. // Reference from app_a should resolve to app_a's navigate, not app_b's
  204. const ref = {
  205. fromNodeId: 'func:apps/app_a/src/handler.py:handler:5',
  206. referenceName: 'navigate',
  207. referenceKind: 'calls' as const,
  208. line: 5,
  209. column: 10,
  210. filePath: 'apps/app_a/src/handler.py',
  211. language: 'python' as const,
  212. };
  213. const result = matchReference(ref, context);
  214. expect(result).not.toBeNull();
  215. expect(result?.targetNodeId).toBe('func:apps/app_a/src/server.py:navigate:10');
  216. expect(result?.resolvedBy).toBe('exact-match');
  217. });
  218. it('should lower confidence for cross-module exact matches', () => {
  219. // Only one candidate but in a completely different module
  220. const candidates: Node[] = [
  221. {
  222. id: 'func:apps/app_b/src/server.py:navigate:10',
  223. kind: 'function',
  224. name: 'navigate',
  225. qualifiedName: 'apps/app_b/src/server.py::navigate',
  226. filePath: 'apps/app_b/src/server.py',
  227. language: 'python',
  228. startLine: 10,
  229. endLine: 20,
  230. startColumn: 0,
  231. endColumn: 0,
  232. updatedAt: Date.now(),
  233. },
  234. {
  235. id: 'func:apps/app_c/src/server.py:navigate:10',
  236. kind: 'function',
  237. name: 'navigate',
  238. qualifiedName: 'apps/app_c/src/server.py::navigate',
  239. filePath: 'apps/app_c/src/server.py',
  240. language: 'python',
  241. startLine: 10,
  242. endLine: 20,
  243. startColumn: 0,
  244. endColumn: 0,
  245. updatedAt: Date.now(),
  246. },
  247. ];
  248. const context: ResolutionContext = {
  249. getNodesInFile: () => [],
  250. getNodesByName: (name) => name === 'navigate' ? candidates : [],
  251. getNodesByQualifiedName: () => [],
  252. getNodesByKind: () => [],
  253. fileExists: () => true,
  254. readFile: () => null,
  255. getProjectRoot: () => '/test',
  256. getAllFiles: () => [],
  257. getNodesByLowerName: () => [],
  258. getImportMappings: () => [],
  259. };
  260. // Reference from app_a — neither candidate is in the same module
  261. const ref = {
  262. fromNodeId: 'func:apps/app_a/src/handler.py:handler:5',
  263. referenceName: 'navigate',
  264. referenceKind: 'calls' as const,
  265. line: 5,
  266. column: 10,
  267. filePath: 'apps/app_a/src/handler.py',
  268. language: 'python' as const,
  269. };
  270. const result = matchReference(ref, context);
  271. // Should still resolve but with low confidence
  272. expect(result).not.toBeNull();
  273. expect(result?.confidence).toBeLessThanOrEqual(0.4);
  274. });
  275. it('should match qualified name references', () => {
  276. const mockClassNode: Node = {
  277. id: 'class:user.ts:User:5',
  278. kind: 'class',
  279. name: 'User',
  280. qualifiedName: 'user.ts::User',
  281. filePath: 'user.ts',
  282. language: 'typescript',
  283. startLine: 5,
  284. endLine: 30,
  285. startColumn: 0,
  286. endColumn: 0,
  287. updatedAt: Date.now(),
  288. };
  289. const mockMethodNode: Node = {
  290. id: 'method:user.ts:User.save:15',
  291. kind: 'method',
  292. name: 'save',
  293. qualifiedName: 'user.ts::User::save',
  294. filePath: 'user.ts',
  295. language: 'typescript',
  296. startLine: 15,
  297. endLine: 25,
  298. startColumn: 0,
  299. endColumn: 0,
  300. updatedAt: Date.now(),
  301. };
  302. const context: ResolutionContext = {
  303. getNodesInFile: (fp) => fp === 'user.ts' ? [mockClassNode, mockMethodNode] : [],
  304. getNodesByName: (name) => {
  305. if (name === 'User') return [mockClassNode];
  306. if (name === 'save') return [mockMethodNode];
  307. return [];
  308. },
  309. getNodesByQualifiedName: (qn) => {
  310. if (qn === 'user.ts::User::save') return [mockMethodNode];
  311. return [];
  312. },
  313. getNodesByKind: () => [],
  314. fileExists: () => true,
  315. readFile: () => null,
  316. getProjectRoot: () => '/test',
  317. getAllFiles: () => ['user.ts'],
  318. };
  319. const ref = {
  320. fromNodeId: 'caller:main.ts:main:5',
  321. referenceName: 'User.save',
  322. referenceKind: 'calls' as const,
  323. line: 5,
  324. column: 10,
  325. filePath: 'main.ts',
  326. language: 'typescript' as const,
  327. };
  328. const result = matchReference(ref, context);
  329. expect(result).not.toBeNull();
  330. expect(result?.targetNodeId).toBe('method:user.ts:User.save:15');
  331. });
  332. });
  333. describe('Ubiquitous-name ceiling (#999)', () => {
  334. // A vendored theme/SDK re-declares the same method name across thousands of
  335. // files (Metronic's `init`/`update`/… on every widget). The fuzzy strategies
  336. // used to score every same-named candidate per ref — O(K) per ref, O(K²)
  337. // total — which pinned a core for 15-28 min at "Resolving refs … 94%". Above
  338. // the ceiling they must DECLINE instead, since no proximity/word-overlap
  339. // score can pick the one true target among thousands anyway.
  340. const CEILING = 500;
  341. // A spy context: counts how many nodes the strategy actually inspects, so we
  342. // can assert the cap short-circuits BEFORE the O(K) scoring (not just that it
  343. // returns null).
  344. const makeManyMethods = (n: number, name: string): Node[] =>
  345. Array.from({ length: n }, (_, i) => ({
  346. id: `method:widget${i}.js:Widget${i}.${name}:1`,
  347. kind: 'method' as const,
  348. name,
  349. qualifiedName: `widget${i}.js::Widget${i}::${name}`,
  350. filePath: `static/theme/widget${i}.js`,
  351. language: 'javascript' as const,
  352. startLine: 1,
  353. endLine: 5,
  354. startColumn: 0,
  355. endColumn: 0,
  356. updatedAt: Date.now(),
  357. }));
  358. const spyContext = (nodes: Node[]): { ctx: ResolutionContext; lookups: () => number } => {
  359. let scanned = 0;
  360. const ctx: ResolutionContext = {
  361. getNodesInFile: () => [],
  362. getNodesByName: (name) => {
  363. const hit = nodes.filter((n) => n.name === name);
  364. scanned += hit.length;
  365. return hit;
  366. },
  367. getNodesByQualifiedName: () => [],
  368. getNodesByKind: () => [],
  369. fileExists: () => true,
  370. readFile: () => null,
  371. getProjectRoot: () => '/test',
  372. getAllFiles: () => [],
  373. getNodesByLowerName: () => [],
  374. getImportMappings: () => [],
  375. };
  376. return { ctx, lookups: () => scanned };
  377. };
  378. it('declines a method call (`obj.init`) above the ceiling instead of scoring K candidates', () => {
  379. const { ctx } = spyContext(makeManyMethods(CEILING + 1, 'init'));
  380. const ref = {
  381. fromNodeId: 'method:caller.js:caller:1',
  382. referenceName: 'widget.init',
  383. referenceKind: 'calls' as const,
  384. line: 2,
  385. column: 4,
  386. filePath: 'static/theme/caller.js',
  387. language: 'javascript' as const,
  388. };
  389. expect(matchReference(ref, ctx)).toBeNull();
  390. });
  391. it('declines a bare exact-name ref above the ceiling', () => {
  392. const { ctx } = spyContext(makeManyMethods(CEILING + 1, 'render'));
  393. const ref = {
  394. fromNodeId: 'method:caller.js:caller:1',
  395. referenceName: 'render',
  396. referenceKind: 'calls' as const,
  397. line: 2,
  398. column: 4,
  399. filePath: 'static/theme/caller.js',
  400. language: 'javascript' as const,
  401. };
  402. expect(matchReference(ref, ctx)).toBeNull();
  403. });
  404. it('still resolves a SAME-FILE definition when one exists (precise path unaffected)', () => {
  405. // Strategy 1 (class-name) and same-file matching are precise — a ubiquitous
  406. // name with an unambiguous local target still resolves.
  407. const nodes = makeManyMethods(CEILING + 1, 'init');
  408. const local: Node = {
  409. id: 'class:static/theme/caller.js:Widgetly:1',
  410. kind: 'class',
  411. name: 'Widgetly',
  412. qualifiedName: 'static/theme/caller.js::Widgetly',
  413. filePath: 'static/theme/caller.js',
  414. language: 'javascript',
  415. startLine: 1, endLine: 9, startColumn: 0, endColumn: 0, updatedAt: Date.now(),
  416. };
  417. const localMethod: Node = {
  418. id: 'method:static/theme/caller.js:Widgetly.init:2',
  419. kind: 'method',
  420. name: 'init',
  421. qualifiedName: 'static/theme/caller.js::Widgetly::init',
  422. filePath: 'static/theme/caller.js',
  423. language: 'javascript',
  424. startLine: 2, endLine: 4, startColumn: 0, endColumn: 0, updatedAt: Date.now(),
  425. };
  426. const all = [...nodes, local, localMethod];
  427. const ctx: ResolutionContext = {
  428. getNodesInFile: (fp) => all.filter((n) => n.filePath === fp),
  429. getNodesByName: (name) => all.filter((n) => n.name === name),
  430. getNodesByQualifiedName: () => [],
  431. getNodesByKind: () => [],
  432. fileExists: () => true,
  433. readFile: () => null,
  434. getProjectRoot: () => '/test',
  435. getAllFiles: () => [],
  436. getNodesByLowerName: () => [],
  437. getImportMappings: () => [],
  438. };
  439. // `Widgetly.init` names the class explicitly → Strategy 1 resolves it.
  440. const ref = {
  441. fromNodeId: 'method:static/theme/caller.js:caller:6',
  442. referenceName: 'Widgetly.init',
  443. referenceKind: 'calls' as const,
  444. line: 6,
  445. column: 4,
  446. filePath: 'static/theme/caller.js',
  447. language: 'javascript' as const,
  448. };
  449. const result = matchReference(ref, ctx);
  450. expect(result?.targetNodeId).toBe('method:static/theme/caller.js:Widgetly.init:2');
  451. });
  452. it('still scores normally JUST below the ceiling (no behavior change for normal repos)', () => {
  453. // Real repos top out near ~40 same-named methods; this proves a sub-ceiling
  454. // collision still resolves via proximity, so the cap is invisible to them.
  455. const nodes = makeManyMethods(CEILING - 1, 'update');
  456. // Make ONE candidate share the caller's directory so proximity picks it.
  457. nodes[0] = {
  458. ...nodes[0]!,
  459. id: 'method:static/theme/app/Widget0.update:1',
  460. qualifiedName: 'static/theme/app/widget.js::Widget0::update',
  461. filePath: 'static/theme/app/widget.js',
  462. };
  463. const ctx: ResolutionContext = {
  464. getNodesInFile: () => [],
  465. getNodesByName: (name) => nodes.filter((n) => n.name === name),
  466. getNodesByQualifiedName: () => [],
  467. getNodesByKind: () => [],
  468. fileExists: () => true,
  469. readFile: () => null,
  470. getProjectRoot: () => '/test',
  471. getAllFiles: () => [],
  472. getNodesByLowerName: () => [],
  473. getImportMappings: () => [],
  474. };
  475. const ref = {
  476. fromNodeId: 'method:static/theme/app/caller.js:caller:1',
  477. referenceName: 'update',
  478. referenceKind: 'calls' as const,
  479. line: 2,
  480. column: 4,
  481. filePath: 'static/theme/app/caller.js',
  482. language: 'javascript' as const,
  483. };
  484. // Below the ceiling the fuzzy path runs and resolves SOMETHING (not capped).
  485. expect(matchReference(ref, ctx)).not.toBeNull();
  486. });
  487. });
  488. describe('Import Resolver', () => {
  489. it('should resolve relative import paths', () => {
  490. const context: ResolutionContext = {
  491. getNodesInFile: () => [],
  492. getNodesByName: () => [],
  493. getNodesByQualifiedName: () => [],
  494. getNodesByKind: () => [],
  495. fileExists: (p) => p === 'src/components/utils.ts' || p === 'src/components/utils/index.ts',
  496. readFile: () => null,
  497. getProjectRoot: () => '',
  498. getAllFiles: () => ['src/components/utils.ts', 'src/components/utils/index.ts'],
  499. };
  500. const result = resolveImportPath(
  501. './utils',
  502. 'src/components/Button.ts',
  503. 'typescript',
  504. context
  505. );
  506. expect(result).toBe('src/components/utils.ts');
  507. });
  508. it('should resolve parent directory imports', () => {
  509. const context: ResolutionContext = {
  510. getNodesInFile: () => [],
  511. getNodesByName: () => [],
  512. getNodesByQualifiedName: () => [],
  513. getNodesByKind: () => [],
  514. fileExists: (p) => p === 'src/helpers.ts' || p === 'src/helpers/index.ts',
  515. readFile: () => null,
  516. getProjectRoot: () => '',
  517. getAllFiles: () => ['src/helpers.ts', 'src/helpers/index.ts'],
  518. };
  519. const result = resolveImportPath(
  520. '../helpers',
  521. 'src/components/Button.ts',
  522. 'typescript',
  523. context
  524. );
  525. expect(result).toBe('src/helpers.ts');
  526. });
  527. it('should extract JS/TS import mappings', () => {
  528. const content = `
  529. import { foo } from './foo';
  530. import bar from '../bar';
  531. import * as utils from './utils';
  532. import { baz, qux } from './baz';
  533. `;
  534. const mappings = extractImportMappings(
  535. 'src/index.ts',
  536. content,
  537. 'typescript'
  538. );
  539. expect(mappings.length).toBeGreaterThan(0);
  540. expect(mappings.some((m) => m.localName === 'foo')).toBe(true);
  541. expect(mappings.some((m) => m.localName === 'bar')).toBe(true);
  542. });
  543. it('should extract Python import mappings', () => {
  544. const content = `
  545. from utils import helper
  546. from .models import User
  547. import os
  548. from ..services import auth_service
  549. `;
  550. const mappings = extractImportMappings(
  551. 'src/main.py',
  552. content,
  553. 'python'
  554. );
  555. expect(mappings.length).toBeGreaterThan(0);
  556. expect(mappings.some((m) => m.localName === 'helper')).toBe(true);
  557. expect(mappings.some((m) => m.localName === 'User')).toBe(true);
  558. });
  559. });
  560. describe('JVM FQN Import Resolution', () => {
  561. // Build a ResolutionContext stub whose getNodesByQualifiedName answers
  562. // from a fixed table — the only context method resolveJvmImport touches.
  563. const makeContext = (byQName: Record<string, Node[]>): ResolutionContext => ({
  564. getNodesInFile: () => [],
  565. getNodesByName: () => [],
  566. getNodesByQualifiedName: (q) => byQName[q] ?? [],
  567. getNodesByKind: () => [],
  568. fileExists: () => false,
  569. readFile: () => null,
  570. getProjectRoot: () => '',
  571. getAllFiles: () => [],
  572. });
  573. const node = (id: string, name: string, qualifiedName: string, kind: Node['kind'] = 'class', language: Node['language'] = 'kotlin'): Node => ({
  574. id, kind, name, qualifiedName,
  575. filePath: 'Models.kt', language,
  576. startLine: 1, endLine: 1, startColumn: 0, endColumn: 0,
  577. updatedAt: 0,
  578. });
  579. const importRef = (referenceName: string, language: Node['language'] = 'kotlin'): UnresolvedRef => ({
  580. fromNodeId: 'caller',
  581. referenceName,
  582. referenceKind: 'imports',
  583. line: 1, column: 0,
  584. filePath: 'Caller.kt',
  585. language,
  586. });
  587. it('resolves a Kotlin class import by FQN regardless of filename', () => {
  588. const target = node('n1', 'Bar', 'com.example.foo::Bar');
  589. const ctx = makeContext({ 'com.example.foo::Bar': [target] });
  590. const result = resolveJvmImport(importRef('com.example.foo.Bar'), ctx);
  591. expect(result?.targetNodeId).toBe('n1');
  592. expect(result?.resolvedBy).toBe('import');
  593. });
  594. it('resolves a Kotlin top-level function import by FQN', () => {
  595. const util = node('n2', 'util', 'com.example.foo::util', 'function');
  596. const ctx = makeContext({ 'com.example.foo::util': [util] });
  597. const result = resolveJvmImport(importRef('com.example.foo.util'), ctx);
  598. expect(result?.targetNodeId).toBe('n2');
  599. });
  600. it('resolves a Java import by FQN', () => {
  601. const target = node('n3', 'Bar', 'com.example.foo::Bar', 'class', 'java');
  602. const ctx = makeContext({ 'com.example.foo::Bar': [target] });
  603. const result = resolveJvmImport(importRef('com.example.foo.Bar', 'java'), ctx);
  604. expect(result?.targetNodeId).toBe('n3');
  605. });
  606. it('resolves cross-language: Kotlin importing a Java class', () => {
  607. // The Kotlin file declares `import com.example.JavaBar` — the target is
  608. // a Java class node. JVM interop means the resolver doesn't care about
  609. // the source language of the target, only that the FQN matches.
  610. const target = node('n4', 'JavaBar', 'com.example::JavaBar', 'class', 'java');
  611. const ctx = makeContext({ 'com.example::JavaBar': [target] });
  612. const result = resolveJvmImport(importRef('com.example.JavaBar'), ctx);
  613. expect(result?.targetNodeId).toBe('n4');
  614. });
  615. it('disambiguates a name collision across packages', () => {
  616. // Two classes named `Bar` in different packages. Each import resolves
  617. // to the one whose FQN matches — not to "whichever was found first".
  618. const barA = node('n5a', 'Bar', 'com.example.alpha::Bar');
  619. const barB = node('n5b', 'Bar', 'com.example.beta::Bar');
  620. const ctx = makeContext({
  621. 'com.example.alpha::Bar': [barA],
  622. 'com.example.beta::Bar': [barB],
  623. });
  624. expect(resolveJvmImport(importRef('com.example.alpha.Bar'), ctx)?.targetNodeId).toBe('n5a');
  625. expect(resolveJvmImport(importRef('com.example.beta.Bar'), ctx)?.targetNodeId).toBe('n5b');
  626. });
  627. it('returns null for wildcard imports', () => {
  628. const ctx = makeContext({});
  629. expect(resolveJvmImport(importRef('com.example.foo.*'), ctx)).toBeNull();
  630. });
  631. it('returns null for unqualified names', () => {
  632. // A single-segment name has no package; nothing to look up by FQN.
  633. const ctx = makeContext({ 'Bar': [node('n6', 'Bar', 'Bar')] });
  634. expect(resolveJvmImport(importRef('Bar'), ctx)).toBeNull();
  635. });
  636. it('returns null for non-JVM languages', () => {
  637. const target = node('n7', 'Bar', 'com.example::Bar');
  638. const ctx = makeContext({ 'com.example::Bar': [target] });
  639. expect(resolveJvmImport(importRef('com.example.Bar', 'typescript'), ctx)).toBeNull();
  640. });
  641. it('returns null for non-imports reference kinds', () => {
  642. // The resolver intentionally only acts on `imports` refs; ordinary
  643. // `calls`/`extends` refs fall through to the framework + name-matcher
  644. // strategies.
  645. const target = node('n8', 'Bar', 'com.example::Bar');
  646. const ctx = makeContext({ 'com.example::Bar': [target] });
  647. const ref: UnresolvedRef = {
  648. fromNodeId: 'caller', referenceName: 'com.example.Bar',
  649. referenceKind: 'calls', line: 1, column: 0,
  650. filePath: 'Caller.kt', language: 'kotlin',
  651. };
  652. expect(resolveJvmImport(ref, ctx)).toBeNull();
  653. });
  654. it('returns null when the FQN is not in the index', () => {
  655. const ctx = makeContext({});
  656. expect(resolveJvmImport(importRef('com.example.Unknown'), ctx)).toBeNull();
  657. });
  658. });
  659. describe('Framework Detection', () => {
  660. it('should detect React framework', () => {
  661. const context: ResolutionContext = {
  662. getNodesInFile: () => [],
  663. getNodesByName: () => [],
  664. getNodesByQualifiedName: () => [],
  665. getNodesByKind: () => [],
  666. fileExists: () => false,
  667. readFile: (p) => {
  668. if (p === 'package.json') {
  669. return JSON.stringify({
  670. dependencies: { react: '^18.0.0' },
  671. });
  672. }
  673. return null;
  674. },
  675. getProjectRoot: () => '/test',
  676. getAllFiles: () => ['package.json', 'src/App.tsx'],
  677. };
  678. const frameworks = detectFrameworks(context);
  679. expect(frameworks.some((f) => f.name === 'react')).toBe(true);
  680. });
  681. it('should detect Express framework', () => {
  682. const context: ResolutionContext = {
  683. getNodesInFile: () => [],
  684. getNodesByName: () => [],
  685. getNodesByQualifiedName: () => [],
  686. getNodesByKind: () => [],
  687. fileExists: () => false,
  688. readFile: (p) => {
  689. if (p === 'package.json') {
  690. return JSON.stringify({
  691. dependencies: { express: '^4.18.0' },
  692. });
  693. }
  694. return null;
  695. },
  696. getProjectRoot: () => '/test',
  697. getAllFiles: () => ['package.json', 'src/app.js'],
  698. };
  699. const frameworks = detectFrameworks(context);
  700. expect(frameworks.some((f) => f.name === 'express')).toBe(true);
  701. });
  702. it('should detect Laravel framework', () => {
  703. const context: ResolutionContext = {
  704. getNodesInFile: () => [],
  705. getNodesByName: () => [],
  706. getNodesByQualifiedName: () => [],
  707. getNodesByKind: () => [],
  708. fileExists: (p) => p === 'artisan',
  709. readFile: () => null,
  710. getProjectRoot: () => '/test',
  711. getAllFiles: () => ['artisan', 'app/Http/Kernel.php'],
  712. };
  713. const frameworks = detectFrameworks(context);
  714. expect(frameworks.some((f) => f.name === 'laravel')).toBe(true);
  715. });
  716. it('should return all framework resolvers', () => {
  717. const resolvers = getAllFrameworkResolvers();
  718. expect(resolvers.length).toBeGreaterThan(0);
  719. expect(resolvers.some((r) => r.name === 'react')).toBe(true);
  720. expect(resolvers.some((r) => r.name === 'express')).toBe(true);
  721. expect(resolvers.some((r) => r.name === 'laravel')).toBe(true);
  722. });
  723. });
  724. describe('React Framework Resolver', () => {
  725. it('should resolve React component references', () => {
  726. const mockNodes: Node[] = [
  727. {
  728. id: 'component:src/Button.tsx:Button:5',
  729. kind: 'component',
  730. name: 'Button',
  731. qualifiedName: 'src/Button.tsx::Button',
  732. filePath: 'src/Button.tsx',
  733. language: 'tsx',
  734. startLine: 5,
  735. endLine: 20,
  736. startColumn: 0,
  737. endColumn: 0,
  738. updatedAt: Date.now(),
  739. },
  740. ];
  741. const context: ResolutionContext = {
  742. getNodesInFile: (fp) => (fp === 'src/Button.tsx' ? mockNodes : []),
  743. getNodesByName: () => mockNodes,
  744. getNodesByQualifiedName: () => [],
  745. getNodesByKind: () => [],
  746. fileExists: () => false,
  747. readFile: (p) => {
  748. if (p === 'package.json') {
  749. return JSON.stringify({ dependencies: { react: '^18.0.0' } });
  750. }
  751. return null;
  752. },
  753. getProjectRoot: () => '/test',
  754. getAllFiles: () => ['package.json', 'src/Button.tsx', 'src/App.tsx'],
  755. };
  756. const frameworks = detectFrameworks(context);
  757. const reactResolver = frameworks.find((f) => f.name === 'react');
  758. expect(reactResolver).toBeDefined();
  759. const ref = {
  760. fromNodeId: 'component:src/App.tsx:App:1',
  761. referenceName: 'Button',
  762. referenceKind: 'renders' as const,
  763. line: 10,
  764. column: 5,
  765. filePath: 'src/App.tsx',
  766. // Refs extracted from .tsx files carry language 'tsx' — component
  767. // resolution is gated to JSX-capable refs (#764: PascalCase TYPE refs
  768. // from plain .ts files were resolving to arbitrary same-named classes).
  769. language: 'tsx' as const,
  770. };
  771. const result = reactResolver!.resolve(ref, context);
  772. expect(result).not.toBeNull();
  773. expect(result?.targetNodeId).toBe('component:src/Button.tsx:Button:5');
  774. // The same PascalCase name referenced from a plain .ts file is a TYPE
  775. // reference, not a component usage — component resolution must decline
  776. // and leave it to proximity-aware name matching (#764: a .ts GraphQL
  777. // types file's own `Account` alias was losing to an arbitrary same-named
  778. // class in another monorepo package).
  779. const tsRef = { ...ref, filePath: 'src/models.ts', language: 'typescript' as const };
  780. expect(reactResolver!.resolve(tsRef, context)).toBeNull();
  781. });
  782. it('should resolve custom hook references', () => {
  783. const mockNodes: Node[] = [
  784. {
  785. id: 'hook:src/hooks/useAuth.ts:useAuth:1',
  786. kind: 'function',
  787. name: 'useAuth',
  788. qualifiedName: 'src/hooks/useAuth.ts::useAuth',
  789. filePath: 'src/hooks/useAuth.ts',
  790. language: 'typescript',
  791. startLine: 1,
  792. endLine: 20,
  793. startColumn: 0,
  794. endColumn: 0,
  795. updatedAt: Date.now(),
  796. },
  797. ];
  798. const context: ResolutionContext = {
  799. getNodesInFile: (fp) => (fp.includes('useAuth') ? mockNodes : []),
  800. getNodesByName: () => mockNodes,
  801. getNodesByQualifiedName: () => [],
  802. getNodesByKind: () => [],
  803. fileExists: () => false,
  804. readFile: (p) => {
  805. if (p === 'package.json') {
  806. return JSON.stringify({ dependencies: { react: '^18.0.0' } });
  807. }
  808. return null;
  809. },
  810. getProjectRoot: () => '/test',
  811. getAllFiles: () => ['package.json', 'src/hooks/useAuth.ts'],
  812. };
  813. const frameworks = detectFrameworks(context);
  814. const reactResolver = frameworks.find((f) => f.name === 'react');
  815. const ref = {
  816. fromNodeId: 'component:src/App.tsx:App:1',
  817. referenceName: 'useAuth',
  818. referenceKind: 'calls' as const,
  819. line: 5,
  820. column: 10,
  821. filePath: 'src/App.tsx',
  822. language: 'typescript' as const,
  823. };
  824. const result = reactResolver!.resolve(ref, context);
  825. expect(result).not.toBeNull();
  826. expect(result?.targetNodeId).toBe('hook:src/hooks/useAuth.ts:useAuth:1');
  827. });
  828. });
  829. describe('Integration Tests', () => {
  830. it('should create resolver from CodeGraph instance', async () => {
  831. // Create a simple TypeScript project
  832. fs.writeFileSync(
  833. path.join(tempDir, 'package.json'),
  834. JSON.stringify({ name: 'test', dependencies: { react: '^18.0.0' } })
  835. );
  836. const srcDir = path.join(tempDir, 'src');
  837. fs.mkdirSync(srcDir);
  838. // Create utility file
  839. fs.writeFileSync(
  840. path.join(srcDir, 'utils.ts'),
  841. `export function formatDate(date: Date): string {
  842. return date.toISOString();
  843. }
  844. export function parseDate(str: string): Date {
  845. return new Date(str);
  846. }`
  847. );
  848. // Create main file that uses utils
  849. fs.writeFileSync(
  850. path.join(srcDir, 'main.ts'),
  851. `import { formatDate, parseDate } from './utils';
  852. function processDate(input: string): string {
  853. const date = parseDate(input);
  854. return formatDate(date);
  855. }`
  856. );
  857. // Initialize and index
  858. cg = await CodeGraph.init(tempDir, { index: true });
  859. // Check that resolver detected React framework
  860. const frameworks = cg.getDetectedFrameworks();
  861. expect(frameworks).toContain('react');
  862. // Get stats to verify indexing worked
  863. const stats = cg.getStats();
  864. expect(stats.fileCount).toBe(2);
  865. expect(stats.nodeCount).toBeGreaterThan(0);
  866. });
  867. it('should resolve references after indexing', async () => {
  868. // Create a project with references
  869. const srcDir = path.join(tempDir, 'src');
  870. fs.mkdirSync(srcDir, { recursive: true });
  871. fs.writeFileSync(
  872. path.join(srcDir, 'helper.ts'),
  873. `export function helperFunction(): void {
  874. console.log('helper');
  875. }`
  876. );
  877. fs.writeFileSync(
  878. path.join(srcDir, 'main.ts'),
  879. `import { helperFunction } from './helper';
  880. function main(): void {
  881. helperFunction();
  882. }`
  883. );
  884. cg = await CodeGraph.init(tempDir, { index: true });
  885. // Run reference resolution
  886. const result = cg.resolveReferences();
  887. // Should have attempted resolution
  888. expect(result.stats.total).toBeGreaterThanOrEqual(0);
  889. });
  890. it('promotes calls→instantiates when target resolves to a class (Python)', async () => {
  891. // Python has no `new` keyword — `Foo()` is the standard
  892. // instantiation syntax. Extraction can't tell that apart from
  893. // a function call without symbol info, so it emits a `calls`
  894. // ref. Resolution promotes it to `instantiates` once the
  895. // target is known to be a class.
  896. const srcDir = path.join(tempDir, 'src');
  897. fs.mkdirSync(srcDir, { recursive: true });
  898. fs.writeFileSync(
  899. path.join(srcDir, 'app.py'),
  900. `class UserService:
  901. def __init__(self):
  902. self.db = None
  903. def bootstrap():
  904. return UserService()
  905. `
  906. );
  907. cg = await CodeGraph.init(tempDir, { index: true });
  908. cg.resolveReferences();
  909. const bootstrap = cg
  910. .getNodesByKind('function')
  911. .find((n) => n.name === 'bootstrap');
  912. expect(bootstrap).toBeDefined();
  913. const outgoing = cg.getOutgoingEdges(bootstrap!.id);
  914. const instantiates = outgoing.find((e) => e.kind === 'instantiates');
  915. expect(instantiates).toBeDefined();
  916. // Same edge must NOT also appear as a `calls` edge — promotion
  917. // replaces the kind, doesn't duplicate.
  918. const callsToUserService = outgoing.filter(
  919. (e) => e.kind === 'calls' && e.target === instantiates!.target
  920. );
  921. expect(callsToUserService).toHaveLength(0);
  922. });
  923. it('records instantiates for C++ stack/brace construction, targeting the class (#1035)', async () => {
  924. // `Calculator calc(0)` (direct-init) and `Widget w{1, 2}` (brace-init)
  925. // carry the constructor args directly on the declarator — there's no
  926. // call/new node — so they recorded no `instantiates` edge, while heap
  927. // `new Calculator(0)` did. Both stack forms now do.
  928. fs.writeFileSync(
  929. path.join(tempDir, 'm.cpp'),
  930. `class Calculator { public: Calculator(int seed) {} int add(int a, int b){ return a+b; } };
  931. class Widget { public: Widget(int a, int b) {} };
  932. int runStack(int a, int b) { Calculator calc(0); return calc.add(a, b); }
  933. int runBrace() { Widget w{1, 2}; return 0; }
  934. int runHeap(int a, int b) { Calculator* c = new Calculator(0); return c->add(a, b); }
  935. void noise() { int x(5); int y{6}; Calculator deferred; }
  936. `
  937. );
  938. cg = await CodeGraph.init(tempDir, { index: true });
  939. const fn = (name: string) => cg.getNodesByKind('function').find((n) => n.name === name)!;
  940. const instTargets = (name: string) =>
  941. cg
  942. .getOutgoingEdges(fn(name).id)
  943. .filter((e) => e.kind === 'instantiates')
  944. .map((e) => cg.getNode(e.target)!);
  945. // Direct-init (the issue) and brace-init both instantiate, targeting the
  946. // CLASS node — not the same-named constructor method.
  947. const stack = instTargets('runStack');
  948. expect(stack.map((n) => `${n.kind}:${n.name}`)).toContain('class:Calculator');
  949. expect(instTargets('runBrace').map((n) => `${n.kind}:${n.name}`)).toContain('class:Widget');
  950. // Heap still works (regression guard).
  951. expect(instTargets('runHeap').map((n) => `${n.kind}:${n.name}`)).toContain('class:Calculator');
  952. // Primitives (`int x(0)`/`int y{6}`) and bare default construction
  953. // (`Calculator deferred;`) must NOT mint an instantiates edge.
  954. expect(instTargets('noise')).toHaveLength(0);
  955. });
  956. it('resolves a cross-file static method call to the method, not the class (#825)', async () => {
  957. // `Foo.bar()` where `Foo` is an imported class must link to the static
  958. // method `Foo::bar`, NOT to the class `Foo`. Previously the import
  959. // resolver dropped the `.bar` member and resolved to `Foo`, which the
  960. // calls→instantiates promotion then turned into `run instantiates Foo`,
  961. // leaving the static method with zero callers and a hollow impact radius.
  962. fs.writeFileSync(
  963. path.join(tempDir, 'helpers.ts'),
  964. `export class Foo {\n static bar(x: number) { return x + 1; }\n}\n`
  965. );
  966. fs.writeFileSync(
  967. path.join(tempDir, 'caller.ts'),
  968. `import { Foo } from './helpers';\nexport function run() { return Foo.bar(41); }\n`
  969. );
  970. cg = await CodeGraph.init(tempDir, { index: true });
  971. cg.resolveReferences();
  972. const bar = cg.getNodesByKind('method').find((n) => n.name === 'bar');
  973. const foo = cg.getNodesByKind('class').find((n) => n.name === 'Foo');
  974. const run = cg.getNodesByKind('function').find((n) => n.name === 'run');
  975. expect(bar).toBeDefined();
  976. expect(foo).toBeDefined();
  977. expect(run).toBeDefined();
  978. // `run` is reported as a caller of the static method `Foo.bar`.
  979. const barCallers = cg.getCallers(bar!.id).map((c) => c.node.name);
  980. expect(barCallers).toContain('run');
  981. // And the call is NOT mis-promoted to `run instantiates Foo`.
  982. const outgoing = cg.getOutgoingEdges(run!.id);
  983. expect(
  984. outgoing.filter((e) => e.kind === 'instantiates' && e.target === foo!.id)
  985. ).toHaveLength(0);
  986. // The real edge is a `calls` edge to the method.
  987. expect(
  988. outgoing.some((e) => e.kind === 'calls' && e.target === bar!.id)
  989. ).toBe(true);
  990. });
  991. it('resolves Go cross-package qualified calls via go.mod module path (#388)', async () => {
  992. // Pre-#388, every `pkga.FuncX(...)` call in a Go monorepo was flagged
  993. // external (isExternalImport returned true for any non-`/internal/`
  994. // import without `.`-prefix) and resolution fell through to name-match
  995. // with path proximity — recall on cross-package callers was ~<1%.
  996. fs.writeFileSync(
  997. path.join(tempDir, 'go.mod'),
  998. 'module github.com/example/myproject\n\ngo 1.21\n'
  999. );
  1000. const pkgaDir = path.join(tempDir, 'pkga');
  1001. const pkgbDir = path.join(tempDir, 'pkgb');
  1002. const pkgcDir = path.join(tempDir, 'pkgc');
  1003. fs.mkdirSync(pkgaDir);
  1004. fs.mkdirSync(pkgbDir);
  1005. fs.mkdirSync(pkgcDir);
  1006. // Same-name exported function in two packages — only the imported one
  1007. // should resolve. Exercises disambiguation, not just connectivity.
  1008. fs.writeFileSync(
  1009. path.join(pkgaDir, 'conv.go'),
  1010. 'package pkga\nfunc Convert(x int) int { return x * 2 }\n'
  1011. );
  1012. fs.writeFileSync(
  1013. path.join(pkgbDir, 'conv.go'),
  1014. 'package pkgb\nfunc Convert(x int) int { return x + 1 }\n'
  1015. );
  1016. fs.writeFileSync(
  1017. path.join(pkgcDir, 'use.go'),
  1018. `package pkgc
  1019. import "github.com/example/myproject/pkga"
  1020. func UsePkga() {
  1021. pkga.Convert(5)
  1022. }
  1023. `
  1024. );
  1025. cg = await CodeGraph.init(tempDir, { index: true });
  1026. const usePkga = cg.getNodesByKind('function').filter((n) => n.name ==='UsePkga')[0];
  1027. expect(usePkga).toBeDefined();
  1028. const outgoing = cg.getOutgoingEdges(usePkga!.id);
  1029. const callEdges = outgoing.filter((e) => e.kind === 'calls');
  1030. expect(callEdges).toHaveLength(1);
  1031. const target = cg.getNode(callEdges[0]!.target);
  1032. expect(target?.name).toBe('Convert');
  1033. // Critical: the resolver must pick the imported pkga's Convert,
  1034. // not pkgb's. With the broken (pre-fix) resolver this lands on
  1035. // whichever Convert happens to be cheaper under path proximity.
  1036. expect(target?.filePath.replace(/\\/g, '/')).toBe('pkga/conv.go');
  1037. });
  1038. it('resolves Go aliased imports across packages (#388)', async () => {
  1039. fs.writeFileSync(
  1040. path.join(tempDir, 'go.mod'),
  1041. 'module github.com/example/myproject\n\ngo 1.21\n'
  1042. );
  1043. fs.mkdirSync(path.join(tempDir, 'pkgb'));
  1044. fs.mkdirSync(path.join(tempDir, 'pkgd'));
  1045. fs.writeFileSync(
  1046. path.join(tempDir, 'pkgb', 'lib.go'),
  1047. 'package pkgb\nfunc Compute(x int) int { return x }\n'
  1048. );
  1049. fs.writeFileSync(
  1050. path.join(tempDir, 'pkgd', 'use.go'),
  1051. `package pkgd
  1052. import (
  1053. "fmt"
  1054. alias "github.com/example/myproject/pkgb"
  1055. )
  1056. func UseAliased() {
  1057. fmt.Println("hi")
  1058. alias.Compute(3)
  1059. }
  1060. `
  1061. );
  1062. cg = await CodeGraph.init(tempDir, { index: true });
  1063. const useAliased = cg.getNodesByKind('function').filter((n) => n.name ==='UseAliased')[0];
  1064. expect(useAliased).toBeDefined();
  1065. const calls = cg.getOutgoingEdges(useAliased!.id).filter((e) => e.kind === 'calls');
  1066. // fmt.Println is stdlib — must stay external. alias.Compute must resolve.
  1067. expect(calls).toHaveLength(1);
  1068. const target = cg.getNode(calls[0]!.target);
  1069. expect(target?.name).toBe('Compute');
  1070. expect(target?.filePath.replace(/\\/g, '/')).toBe('pkgb/lib.go');
  1071. });
  1072. it('resolves Python module-attribute calls after `from pkg import module` (#578)', async () => {
  1073. // Pre-#578, a `module.func()` call where `module` was bound via
  1074. // `from pkg import module` dropped its `calls` edge. The file→file import
  1075. // edge resolved (resolveModuleImportToFile falls back to a dotted-module
  1076. // file lookup for absolute package paths), but resolvePythonModuleMember
  1077. // had no such fallback — resolveImportPath returns null for an absolute
  1078. // package path like `pkg.module`, so the member never resolved and
  1079. // callers/callees/impact on the target came back empty. Same root-cause
  1080. // class as the Go cross-package qualified call (#388).
  1081. fs.mkdirSync(path.join(tempDir, 'pkg'));
  1082. fs.writeFileSync(path.join(tempDir, 'pkg', '__init__.py'), '');
  1083. fs.writeFileSync(
  1084. path.join(tempDir, 'pkg', 'module.py'),
  1085. 'def func():\n return 1\n'
  1086. );
  1087. fs.writeFileSync(
  1088. path.join(tempDir, 'main.py'),
  1089. `from pkg import module
  1090. import os
  1091. def caller():
  1092. return module.func()
  1093. def external_caller():
  1094. return os.getcwd()
  1095. `
  1096. );
  1097. cg = await CodeGraph.init(tempDir, { index: true });
  1098. const caller = cg.getNodesByKind('function').filter((n) => n.name === 'caller')[0];
  1099. expect(caller).toBeDefined();
  1100. const calls = cg.getOutgoingEdges(caller!.id).filter((e) => e.kind === 'calls');
  1101. // module.func() must resolve to the real function in the submodule file.
  1102. expect(calls).toHaveLength(1);
  1103. const target = cg.getNode(calls[0]!.target);
  1104. expect(target?.name).toBe('func');
  1105. expect(target?.filePath.replace(/\\/g, '/')).toBe('pkg/module.py');
  1106. // The flip side of the fix: an attribute call through a *stdlib* module
  1107. // (`os.getcwd()`) must still create no edge — the fallback only matches
  1108. // real in-repo module files.
  1109. const externalCaller = cg.getNodesByKind('function').filter((n) => n.name === 'external_caller')[0];
  1110. expect(externalCaller).toBeDefined();
  1111. const externalCalls = cg.getOutgoingEdges(externalCaller!.id).filter((e) => e.kind === 'calls');
  1112. expect(externalCalls).toHaveLength(0);
  1113. });
  1114. it('attaches Go methods to their receiver type across files (#583, cross-file half)', async () => {
  1115. // In Go a type's methods are commonly declared in a different file from the
  1116. // `type` declaration (`type Box` in box.go, `func (b *Box) Get()` in
  1117. // box_methods.go). Extraction only attaches the struct→method `contains`
  1118. // edge when the type is in the SAME file (the owner lookup is file-scoped),
  1119. // so a cross-file method was orphaned from its struct — breaking member
  1120. // outlines and any callers/callees/impact traversal through `contains`. A
  1121. // resolution-phase pass now links them within the package (= directory).
  1122. fs.writeFileSync(
  1123. path.join(tempDir, 'box.go'),
  1124. 'package main\n\ntype Box struct{ v int }\n'
  1125. );
  1126. fs.writeFileSync(
  1127. path.join(tempDir, 'box_methods.go'),
  1128. 'package main\n\nfunc (b *Box) Get() int { return b.v }\nfunc (b *Box) Set(x int) { b.v = x }\n'
  1129. );
  1130. // Generic receiver declared cross-file too — exercises #583 half A
  1131. // (generic `*Stack[T]` receiver parsing) and half B (cross-file) together.
  1132. fs.writeFileSync(
  1133. path.join(tempDir, 'stack.go'),
  1134. 'package main\n\ntype Stack[T any] struct {\n\titems []T\n}\n'
  1135. );
  1136. fs.writeFileSync(
  1137. path.join(tempDir, 'stack_push.go'),
  1138. 'package main\n\nfunc (s *Stack[T]) Push(v T) { s.items = append(s.items, v) }\n'
  1139. );
  1140. // A same-named type in another package must NOT capture this package's
  1141. // methods — the link is scoped to the receiver type's own directory.
  1142. fs.mkdirSync(path.join(tempDir, 'other'));
  1143. fs.writeFileSync(
  1144. path.join(tempDir, 'other', 'box.go'),
  1145. 'package other\n\ntype Box struct{ w int }\n'
  1146. );
  1147. cg = await CodeGraph.init(tempDir, { index: true });
  1148. const methodsOf = (typeName: string, file: string): string[] => {
  1149. const node = cg
  1150. .getNodesByKind('struct')
  1151. .find((n) => n.name === typeName && n.filePath.replace(/\\/g, '/') === file);
  1152. expect(node, `${typeName} @ ${file}`).toBeDefined();
  1153. return cg
  1154. .getOutgoingEdges(node!.id)
  1155. .filter((e) => e.kind === 'contains')
  1156. .map((e) => cg.getNode(e.target))
  1157. .filter((n) => !!n && n.kind === 'method')
  1158. .map((n) => n!.name)
  1159. .sort();
  1160. };
  1161. // Cross-file (non-generic) methods now attach to their struct.
  1162. expect(methodsOf('Box', 'box.go')).toEqual(['Get', 'Set']);
  1163. // Generic + cross-file.
  1164. expect(methodsOf('Stack', 'stack.go')).toEqual(['Push']);
  1165. // Cross-package isolation: other/Box defines no methods of its own.
  1166. expect(methodsOf('Box', 'other/box.go')).toEqual([]);
  1167. });
  1168. it('TS type_alias object-shape members resolve method calls (#359)', async () => {
  1169. // Pre-#359, `recorder.stop()` (recorder: RecorderHandle) attached
  1170. // to `StdioMcpClient.stop` in a sibling directory via path-proximity
  1171. // because the type_alias had no `stop` node — only the unrelated
  1172. // class did. Now type_alias produces member nodes (property/method),
  1173. // so the camelCase receiver↔type word overlap pulls the call to
  1174. // `RecorderHandle::stop` instead of the look-alike class.
  1175. fs.mkdirSync(path.join(tempDir, 'voice'));
  1176. fs.mkdirSync(path.join(tempDir, 'codegraph'));
  1177. fs.writeFileSync(
  1178. path.join(tempDir, 'voice', 'recorder.ts'),
  1179. `export type RecorderHandle = {
  1180. wavPath: string;
  1181. stop: () => Promise<{ ok: true }>;
  1182. };
  1183. `
  1184. );
  1185. fs.writeFileSync(
  1186. path.join(tempDir, 'voice', 'controller.ts'),
  1187. `import type { RecorderHandle } from "./recorder";
  1188. export async function finaliseRecording(recorder: RecorderHandle) {
  1189. return await recorder.stop();
  1190. }
  1191. `
  1192. );
  1193. fs.writeFileSync(
  1194. path.join(tempDir, 'codegraph', 'stdio-client.ts'),
  1195. `export class StdioMcpClient {
  1196. private stopped = false;
  1197. async stop(): Promise<void> { this.stopped = true; }
  1198. }
  1199. `
  1200. );
  1201. cg = await CodeGraph.init(tempDir, { index: true });
  1202. const handleStop = cg
  1203. .getNodesByKind('method')
  1204. .find((n) => n.qualifiedName === 'RecorderHandle::stop');
  1205. expect(handleStop).toBeDefined();
  1206. const clientStop = cg
  1207. .getNodesByKind('method')
  1208. .find((n) => n.qualifiedName === 'StdioMcpClient::stop');
  1209. expect(clientStop).toBeDefined();
  1210. const handleCallers = cg.getIncomingEdges(handleStop!.id).filter((e) => e.kind === 'calls');
  1211. const clientCallers = cg.getIncomingEdges(clientStop!.id).filter((e) => e.kind === 'calls');
  1212. expect(handleCallers.length).toBeGreaterThanOrEqual(1);
  1213. // The class method must have NO callers — voice/'s call must NOT
  1214. // mis-attribute. A non-empty list would mean the false-positive
  1215. // path is still firing.
  1216. expect(clientCallers).toHaveLength(0);
  1217. // Function-typed property surfaces as a `method` node, not `property`,
  1218. // because `stop()` semantics at the call site are method semantics.
  1219. expect(handleStop!.kind).toBe('method');
  1220. });
  1221. it('Java import disambiguates same-name classes across modules (#314)', async () => {
  1222. // Pre-#314 the import resolver had no Java branch at all, so a
  1223. // multi-module Maven repo where `dao/converter/FooConverter` and
  1224. // `service/converter/FooConverter` both export a `convert` method
  1225. // resolved by file-path proximity — picking whichever class was
  1226. // closer to the caller, which is wrong any time the caller lives
  1227. // in an equidistant cross-cutting module.
  1228. const daoDir = path.join(tempDir, 'dao/src/main/java/com/example/dao/converter');
  1229. const serviceDir = path.join(tempDir, 'service/src/main/java/com/example/service/converter');
  1230. const webDir = path.join(tempDir, 'web/src/main/java/com/example/web');
  1231. fs.mkdirSync(daoDir, { recursive: true });
  1232. fs.mkdirSync(serviceDir, { recursive: true });
  1233. fs.mkdirSync(webDir, { recursive: true });
  1234. fs.writeFileSync(
  1235. path.join(daoDir, 'FooConverter.java'),
  1236. `package com.example.dao.converter;
  1237. public class FooConverter { public String convert(String x) { return "dao:" + x; } }
  1238. `
  1239. );
  1240. fs.writeFileSync(
  1241. path.join(serviceDir, 'FooConverter.java'),
  1242. `package com.example.service.converter;
  1243. public class FooConverter { public String convert(String x) { return "svc:" + x; } }
  1244. `
  1245. );
  1246. // The caller imports the SERVICE version — even though dao is
  1247. // alphabetically/lexically first in the candidate list, the
  1248. // import must trump that order.
  1249. fs.writeFileSync(
  1250. path.join(webDir, 'Handler.java'),
  1251. `package com.example.web;
  1252. import com.example.service.converter.FooConverter;
  1253. public class Handler {
  1254. private FooConverter fooConverter;
  1255. public String use() { return fooConverter.convert("input"); }
  1256. }
  1257. `
  1258. );
  1259. cg = await CodeGraph.init(tempDir, { index: true });
  1260. const use = cg
  1261. .getNodesByKind('method')
  1262. .find((n) => n.qualifiedName === 'com.example.web::Handler::use');
  1263. expect(use).toBeDefined();
  1264. const calls = cg.getOutgoingEdges(use!.id).filter((e) => e.kind === 'calls');
  1265. expect(calls.length).toBeGreaterThanOrEqual(1);
  1266. const target = cg.getNode(calls[0]!.target);
  1267. expect(target?.name).toBe('convert');
  1268. expect(target?.filePath.replace(/\\/g, '/')).toBe(
  1269. 'service/src/main/java/com/example/service/converter/FooConverter.java'
  1270. );
  1271. });
  1272. it('C# extracts references from method/property/field types (#381)', async () => {
  1273. // Pre-#381, every C# project produced ZERO `references` edges:
  1274. // csharp.ts was missing returnField, and the type-leaf walker
  1275. // only recognized TS/Java's `type_identifier` nodes — C# uses
  1276. // `identifier`/`predefined_type`/`qualified_name`/`generic_name`.
  1277. const srcDir = path.join(tempDir, 'src');
  1278. fs.mkdirSync(srcDir, { recursive: true });
  1279. fs.writeFileSync(
  1280. path.join(srcDir, 'Dtos.cs'),
  1281. `namespace MyApp;
  1282. public class SessionInfoDto { public string Id { get; set; } = ""; }
  1283. public class UserDto { public string Name { get; set; } = ""; }
  1284. `
  1285. );
  1286. fs.writeFileSync(
  1287. path.join(srcDir, 'Service.cs'),
  1288. `using System.Threading.Tasks;
  1289. namespace MyApp;
  1290. public class DataExporter
  1291. {
  1292. public SessionInfoDto Build(UserDto user, SessionInfoDto session) { return session; }
  1293. public Task<SessionInfoDto> BuildAsync(UserDto user) { return Task.FromResult(new SessionInfoDto()); }
  1294. public SessionInfoDto Latest { get; set; } = new();
  1295. private UserDto _cached;
  1296. }
  1297. `
  1298. );
  1299. cg = await CodeGraph.init(tempDir, { index: true });
  1300. const sessionDto = cg
  1301. .getNodesByKind('class')
  1302. .find((n) => n.name === 'SessionInfoDto');
  1303. const userDto = cg
  1304. .getNodesByKind('class')
  1305. .find((n) => n.name === 'UserDto');
  1306. expect(sessionDto).toBeDefined();
  1307. expect(userDto).toBeDefined();
  1308. const sessionIncoming = cg
  1309. .getIncomingEdges(sessionDto!.id)
  1310. .filter((e) => e.kind === 'references');
  1311. const userIncoming = cg
  1312. .getIncomingEdges(userDto!.id)
  1313. .filter((e) => e.kind === 'references');
  1314. // SessionInfoDto: Build return, Build param, BuildAsync return (inside Task<>), Latest property.
  1315. // UserDto: Build param, BuildAsync param, _cached field.
  1316. expect(sessionIncoming.length).toBeGreaterThanOrEqual(4);
  1317. expect(userIncoming.length).toBeGreaterThanOrEqual(3);
  1318. });
  1319. it('C# primary-constructor parameters record their type dependencies (#237)', async () => {
  1320. // C# 12 primary constructors declare a type's injected dependencies inline
  1321. // (`class Svc(IRepo repo, [FromKeyedServices("k")] ICache cache)`). Each
  1322. // ctor parameter's type is recorded as a `references` edge from the class,
  1323. // so a DI-registered contract reached only through a primary ctor is no
  1324. // longer reported as having no dependents.
  1325. fs.mkdirSync(path.join(tempDir, 'src'), { recursive: true });
  1326. fs.writeFileSync(
  1327. path.join(tempDir, 'src', 'Contracts.cs'),
  1328. `namespace App;
  1329. public interface IRepo { }
  1330. public class ICache { }
  1331. `
  1332. );
  1333. fs.writeFileSync(
  1334. path.join(tempDir, 'src', 'OrderService.cs'),
  1335. `namespace App;
  1336. public sealed class OrderService(IRepo repo, [FromKeyedServices("primary")] ICache cache)
  1337. {
  1338. public void Run() { }
  1339. }
  1340. `
  1341. );
  1342. cg = await CodeGraph.init(tempDir, { index: true });
  1343. const svc = cg.getNodesByKind('class').find((n) => n.name === 'OrderService');
  1344. expect(svc).toBeDefined();
  1345. // The class itself must index (it used to vanish under the old grammar).
  1346. const out = cg.getOutgoingEdges(svc!.id).filter((e) => e.kind === 'references');
  1347. const depNames = out.map((e) => cg.getNode(e.target)?.name);
  1348. expect(depNames).toContain('IRepo');
  1349. expect(depNames).toContain('ICache'); // the keyed-DI ([FromKeyedServices]) dependency
  1350. });
  1351. it('Go: leaves stdlib calls (fmt.Println, etc.) external', async () => {
  1352. fs.writeFileSync(
  1353. path.join(tempDir, 'go.mod'),
  1354. 'module github.com/example/myproject\n\ngo 1.21\n'
  1355. );
  1356. fs.writeFileSync(
  1357. path.join(tempDir, 'main.go'),
  1358. `package main
  1359. import "fmt"
  1360. func main() {
  1361. fmt.Println("hi")
  1362. }
  1363. `
  1364. );
  1365. cg = await CodeGraph.init(tempDir, { index: true });
  1366. const mainFn = cg.getNodesByKind('function').filter((n) => n.name ==='main')[0];
  1367. const calls = cg.getOutgoingEdges(mainFn!.id).filter((e) => e.kind === 'calls');
  1368. // No spurious in-project edge — fmt.* must stay unresolved/external.
  1369. expect(calls).toHaveLength(0);
  1370. });
  1371. });
  1372. describe('Same-name method disambiguation (#1079)', () => {
  1373. // resolveMethodOnType picks among several methods that share a
  1374. // `Type::method` qualifiedName. The precedence is:
  1375. // 1. preferredFqn (Java/Kotlin import — target is intentionally in
  1376. // ANOTHER file, #314),
  1377. // 2. the call site's OWN file (language-agnostic, #1079),
  1378. // 3. matches[0] (first-indexed) as a last resort.
  1379. const methodNode = (
  1380. id: string,
  1381. filePath: string,
  1382. language: Node['language'] = 'cpp',
  1383. qualifiedName = 'Logger::log',
  1384. name = 'log',
  1385. ): Node => ({
  1386. id, kind: 'method', name, qualifiedName, filePath, language,
  1387. startLine: 1, endLine: 1, startColumn: 0, endColumn: 0, updatedAt: 0,
  1388. });
  1389. const callRef = (filePath: string, language: Node['language'] = 'cpp'): UnresolvedRef => ({
  1390. fromNodeId: 'caller', referenceName: 'lg.log', referenceKind: 'calls',
  1391. line: 2, column: 0, filePath, language,
  1392. });
  1393. const ctxFor = (candidates: Node[]): ResolutionContext => ({
  1394. getNodesInFile: () => [],
  1395. getNodesByName: (name) => candidates.filter((c) => c.name === name),
  1396. getNodesByQualifiedName: () => [],
  1397. getNodesByKind: () => [],
  1398. fileExists: () => false,
  1399. readFile: () => null,
  1400. getProjectRoot: () => '',
  1401. getAllFiles: () => [],
  1402. });
  1403. it('prefers the definition in the call site\'s own file (#1079)', () => {
  1404. // matches[0] is the a/ definition; the call comes from b/, so it must
  1405. // resolve to b/ — not collapse onto the first-indexed match.
  1406. const logA = methodNode('m:a', 'a/svc.cpp');
  1407. const logB = methodNode('m:b', 'b/svc.cpp');
  1408. const result = resolveMethodOnType(
  1409. 'Logger', 'log', callRef('b/svc.cpp'), ctxFor([logA, logB]), 0.9, 'instance-method',
  1410. );
  1411. expect(result?.targetNodeId).toBe('m:b');
  1412. });
  1413. it('lets an import FQN pin a cross-file target over the same-file preference (#314)', () => {
  1414. // Java: two `Bar::doIt` in different packages. The import FQN pins the
  1415. // alpha package; even though the call site lives in beta's file, the FQN
  1416. // must win — the same-file preference runs only AFTER preferredFqn.
  1417. const alpha = methodNode('m:alpha', 'com/example/alpha/Bar.java', 'java', 'Bar::doIt', 'doIt');
  1418. const beta = methodNode('m:beta', 'com/example/beta/Bar.java', 'java', 'Bar::doIt', 'doIt');
  1419. const result = resolveMethodOnType(
  1420. 'Bar', 'doIt', callRef('com/example/beta/Bar.java', 'java'),
  1421. ctxFor([alpha, beta]), 0.9, 'instance-method', 'com.example.alpha.Bar',
  1422. );
  1423. expect(result?.targetNodeId).toBe('m:alpha');
  1424. });
  1425. it('falls back to the first match when nothing disambiguates', () => {
  1426. // Call site is a third file: no FQN, no same-file candidate → matches[0].
  1427. const logA = methodNode('m:a', 'a/svc.cpp');
  1428. const logB = methodNode('m:b', 'b/svc.cpp');
  1429. const result = resolveMethodOnType(
  1430. 'Logger', 'log', callRef('c/other.cpp'), ctxFor([logA, logB]), 0.9, 'instance-method',
  1431. );
  1432. expect(result?.targetNodeId).toBe('m:a');
  1433. });
  1434. it('resolves C++ calls end-to-end to same-named classes in different files (#1079)', async () => {
  1435. // The exact repro from the issue: two files, each with its own
  1436. // `Logger::log`. Before the fix both callers pointed at the first def.
  1437. fs.mkdirSync(path.join(tempDir, 'a'), { recursive: true });
  1438. fs.mkdirSync(path.join(tempDir, 'b'), { recursive: true });
  1439. fs.writeFileSync(
  1440. path.join(tempDir, 'a', 'svc.cpp'),
  1441. `class Logger { public: void log() { int a = 1; } };\nvoid useA() { Logger lg; lg.log(); }\n`,
  1442. );
  1443. fs.writeFileSync(
  1444. path.join(tempDir, 'b', 'svc.cpp'),
  1445. `class Logger { public: void log() { int b = 2; } };\nvoid useB() { Logger lg; lg.log(); }\n`,
  1446. );
  1447. cg = await CodeGraph.init(tempDir, { index: true });
  1448. cg.resolveReferences();
  1449. const logInDir = (dir: string) =>
  1450. cg.getNodesByKind('method').find(
  1451. (n) => n.name === 'log' && n.filePath.replace(/\\/g, '/').endsWith(`${dir}/svc.cpp`),
  1452. )!;
  1453. const callTargets = (fnName: string) =>
  1454. cg
  1455. .getOutgoingEdges(cg.getNodesByKind('function').find((n) => n.name === fnName)!.id)
  1456. .filter((e) => e.kind === 'calls')
  1457. .map((e) => e.target);
  1458. const logA = logInDir('a');
  1459. const logB = logInDir('b');
  1460. expect(logA).toBeDefined();
  1461. expect(logB).toBeDefined();
  1462. expect(logA.id).not.toBe(logB.id);
  1463. // Each caller resolves to the Logger::log in its OWN file.
  1464. expect(callTargets('useA')).toContain(logA.id);
  1465. expect(callTargets('useB')).toContain(logB.id);
  1466. });
  1467. it('preferCallSiteFile puts same-file candidates first and is otherwise a no-op', () => {
  1468. const a = methodNode('m:a', 'a/svc.cpp');
  1469. const b = methodNode('m:b', 'b/svc.cpp');
  1470. // Same-file first; the rest keep their original order (stable).
  1471. expect(preferCallSiteFile([a, b], 'b/svc.cpp').map((n) => n.id)).toEqual(['m:b', 'm:a']);
  1472. expect(preferCallSiteFile([a, b], 'a/svc.cpp').map((n) => n.id)).toEqual(['m:a', 'm:b']);
  1473. // No same-file match → unchanged; <2 candidates → returned as-is.
  1474. expect(preferCallSiteFile([a, b], 'c/other.cpp').map((n) => n.id)).toEqual(['m:a', 'm:b']);
  1475. expect(preferCallSiteFile([a], 'z/none.cpp')).toHaveLength(1);
  1476. });
  1477. it('matchByQualifiedName prefers the same-file target when a qualified name is ambiguous (#1079)', () => {
  1478. // Two `Logger::log` definitions; an explicit `Logger::log()` call from b/
  1479. // must resolve to b/'s definition, not the first-indexed one.
  1480. const a = methodNode('m:a', 'a/svc.cpp');
  1481. const b = methodNode('m:b', 'b/svc.cpp');
  1482. const ctx: ResolutionContext = {
  1483. getNodesInFile: () => [],
  1484. getNodesByName: (name) => [a, b].filter((n) => n.name === name),
  1485. getNodesByQualifiedName: (q) => (q === 'Logger::log' ? [a, b] : []),
  1486. getNodesByKind: () => [],
  1487. fileExists: () => false,
  1488. readFile: () => null,
  1489. getProjectRoot: () => '',
  1490. getAllFiles: () => [],
  1491. };
  1492. const ref: UnresolvedRef = {
  1493. fromNodeId: 'caller', referenceName: 'Logger::log', referenceKind: 'calls',
  1494. line: 2, column: 0, filePath: 'b/svc.cpp', language: 'cpp',
  1495. };
  1496. expect(matchByQualifiedName(ref, ctx)?.targetNodeId).toBe('m:b');
  1497. });
  1498. it('resolves a static/class-receiver call to the class in the caller\'s file (#1079)', async () => {
  1499. // `Logger.log()` — the receiver is the class NAME, so this routes through
  1500. // the class-name-receiver strategy (not the C++ instance path). It was
  1501. // file-blind across languages; verified here on TypeScript.
  1502. fs.mkdirSync(path.join(tempDir, 'a'), { recursive: true });
  1503. fs.mkdirSync(path.join(tempDir, 'b'), { recursive: true });
  1504. fs.writeFileSync(
  1505. path.join(tempDir, 'a', 'svc.ts'),
  1506. `class Logger { static log() { return 1; } }\nexport function useA() { return Logger.log(); }\n`,
  1507. );
  1508. fs.writeFileSync(
  1509. path.join(tempDir, 'b', 'svc.ts'),
  1510. `class Logger { static log() { return 2; } }\nexport function useB() { return Logger.log(); }\n`,
  1511. );
  1512. cg = await CodeGraph.init(tempDir, { index: true });
  1513. cg.resolveReferences();
  1514. const logInDir = (dir: string) =>
  1515. cg.getNodesByKind('method').find(
  1516. (n) => n.name === 'log' && n.filePath.replace(/\\/g, '/').endsWith(`${dir}/svc.ts`),
  1517. )!;
  1518. const callTargets = (fnName: string) =>
  1519. cg
  1520. .getOutgoingEdges(cg.getNodesByKind('function').find((n) => n.name === fnName)!.id)
  1521. .filter((e) => e.kind === 'calls')
  1522. .map((e) => e.target);
  1523. const logA = logInDir('a');
  1524. const logB = logInDir('b');
  1525. expect(logA?.id).not.toBe(logB?.id);
  1526. expect(callTargets('useA')).toContain(logA.id);
  1527. expect(callTargets('useB')).toContain(logB.id);
  1528. });
  1529. it('resolves an explicitly-qualified call to the definition in the caller\'s file (#1079)', async () => {
  1530. // `Logger::log()` with two `Logger::log` definitions routes through the
  1531. // qualified-name strategy, whose partial match previously picked the first.
  1532. fs.mkdirSync(path.join(tempDir, 'a'), { recursive: true });
  1533. fs.mkdirSync(path.join(tempDir, 'b'), { recursive: true });
  1534. fs.writeFileSync(
  1535. path.join(tempDir, 'a', 'svc.cpp'),
  1536. `class Logger { public: static void log() { int a = 1; } };\nvoid useA() { Logger::log(); }\n`,
  1537. );
  1538. fs.writeFileSync(
  1539. path.join(tempDir, 'b', 'svc.cpp'),
  1540. `class Logger { public: static void log() { int b = 2; } };\nvoid useB() { Logger::log(); }\n`,
  1541. );
  1542. cg = await CodeGraph.init(tempDir, { index: true });
  1543. cg.resolveReferences();
  1544. const logInDir = (dir: string) =>
  1545. cg.getNodesByKind('method').find(
  1546. (n) => n.name === 'log' && n.filePath.replace(/\\/g, '/').endsWith(`${dir}/svc.cpp`),
  1547. )!;
  1548. const callTargets = (fnName: string) =>
  1549. cg
  1550. .getOutgoingEdges(cg.getNodesByKind('function').find((n) => n.name === fnName)!.id)
  1551. .filter((e) => e.kind === 'calls')
  1552. .map((e) => e.target);
  1553. const logA = logInDir('a');
  1554. const logB = logInDir('b');
  1555. expect(logA?.id).not.toBe(logB?.id);
  1556. expect(callTargets('useA')).toContain(logA.id);
  1557. expect(callTargets('useB')).toContain(logB.id);
  1558. });
  1559. });
  1560. describe('Watchdog-safe resolution on collision-heavy repos (#1122)', () => {
  1561. // On a large Java-style repo, per-ref resolution cost is unbounded in the
  1562. // worst case (a colliding method name whose candidate set misses the LRU
  1563. // re-fetches tens of thousands of rows, and receiver inference re-splits
  1564. // the whole source file). v1.2.0 yielded only every 500 refs, so a dense
  1565. // pocket multiplied that cost past the #850 watchdog window and a VALID
  1566. // `init` was SIGKILLed at "Resolving refs". These pin the three guards:
  1567. // per-ref yield checkpoints, the (type, method) match memo, and the
  1568. // per-file lines cache with its generated/minified-line skip.
  1569. const methodNode = (
  1570. id: string,
  1571. filePath: string,
  1572. qualifiedName: string,
  1573. name: string,
  1574. language: Node['language'] = 'typescript',
  1575. kind: Node['kind'] = 'method',
  1576. ): Node => ({
  1577. id, kind, name, qualifiedName, filePath, language,
  1578. startLine: 1, endLine: 1, startColumn: 0, endColumn: 0, updatedAt: 0,
  1579. });
  1580. it('resolveMethodOnType consults the method-match memo and still disambiguates per call site', () => {
  1581. const logA = methodNode('m:a', 'a/svc.ts', 'Logger::log', 'log');
  1582. const logB = methodNode('m:b', 'b/svc.ts', 'Logger::log', 'log');
  1583. const shared = [logA, logB]; // one cached array served to every caller
  1584. let memoCalls = 0;
  1585. let rawNameLookups = 0;
  1586. const ctx: ResolutionContext = {
  1587. getNodesInFile: () => [],
  1588. getNodesByName: () => { rawNameLookups++; return shared; },
  1589. getMethodMatches: () => { memoCalls++; return shared; },
  1590. getNodesByQualifiedName: () => [],
  1591. getNodesByKind: () => [],
  1592. fileExists: () => false,
  1593. readFile: () => null,
  1594. getProjectRoot: () => '',
  1595. getAllFiles: () => [],
  1596. };
  1597. const refFrom = (filePath: string): UnresolvedRef => ({
  1598. fromNodeId: 'caller', referenceName: 'lg.log', referenceKind: 'calls',
  1599. line: 2, column: 0, filePath, language: 'typescript',
  1600. });
  1601. // Both call sites read the SAME memoized array, yet each still resolves
  1602. // to its own file — per-ref disambiguation runs after the memo (#1079).
  1603. const fromA = resolveMethodOnType('Logger', 'log', refFrom('a/svc.ts'), ctx, 0.9, 'instance-method');
  1604. const fromB = resolveMethodOnType('Logger', 'log', refFrom('b/svc.ts'), ctx, 0.9, 'instance-method');
  1605. expect(fromA?.targetNodeId).toBe('m:a');
  1606. expect(fromB?.targetNodeId).toBe('m:b');
  1607. expect(memoCalls).toBe(2);
  1608. expect(rawNameLookups).toBe(0); // memo bypasses the unbounded name fetch
  1609. });
  1610. it('the production resolver context memoizes method matches per (language, type, method)', async () => {
  1611. fs.writeFileSync(
  1612. path.join(tempDir, 'svc.ts'),
  1613. `class Logger { log() { return 1; } }\nexport function use() { const lg = new Logger(); return lg.log(); }\n`,
  1614. );
  1615. cg = await CodeGraph.init(tempDir, { index: true });
  1616. const resolver = (cg as unknown as { resolver: ReferenceResolver }).resolver;
  1617. const ctx = (resolver as unknown as { context: ResolutionContext }).context;
  1618. const first = ctx.getMethodMatches!('Logger', 'log', 'typescript');
  1619. const second = ctx.getMethodMatches!('Logger', 'log', 'typescript');
  1620. expect(first.map((n) => n.qualifiedName)).toEqual(['Logger::log']);
  1621. // Same array instance = served from the memo, not recomputed.
  1622. expect(second).toBe(first);
  1623. resolver.clearCaches();
  1624. const afterClear = ctx.getMethodMatches!('Logger', 'log', 'typescript');
  1625. expect(afterClear).not.toBe(first);
  1626. expect(afterClear.map((n) => n.qualifiedName)).toEqual(['Logger::log']);
  1627. });
  1628. it('resolveBatchYielding offers a yield checkpoint for every ref', async () => {
  1629. fs.writeFileSync(
  1630. path.join(tempDir, 'a.ts'),
  1631. `export function fnA() { return 1; }\nexport function fnB() { return fnA(); }\nexport function fnC() { return fnB(); }\n`,
  1632. );
  1633. fs.writeFileSync(
  1634. path.join(tempDir, 'b.ts'),
  1635. `import { fnA } from './a';\nexport function fnD() { return fnA(); }\n`,
  1636. );
  1637. cg = await CodeGraph.init(tempDir, { index: true });
  1638. const resolver = (cg as unknown as { resolver: ReferenceResolver }).resolver;
  1639. // `init({ index: true })` already ran resolution, so feed the batch
  1640. // directly — resolveBatchYielding takes it as an argument; whether each
  1641. // ref resolves is irrelevant to the checkpoint contract.
  1642. const refs: UnresolvedReference[] = ['fnA', 'fnB', 'nosuchFn', 'fnA', 'alsoMissing'].map((name, i) => ({
  1643. fromNodeId: `caller-${i}`,
  1644. referenceName: name,
  1645. referenceKind: 'calls',
  1646. line: i + 1,
  1647. column: 0,
  1648. filePath: 'a.ts',
  1649. language: 'typescript',
  1650. }));
  1651. let checkpoints = 0;
  1652. const countingYield = async () => { checkpoints++; };
  1653. const result = await (resolver as unknown as {
  1654. resolveBatchYielding(batch: UnresolvedReference[], maybeYield: () => Promise<void>): Promise<{ stats: { total: number } }>;
  1655. }).resolveBatchYielding(refs, countingYield);
  1656. // One checkpoint per ref: a pocket of pathologically slow refs can never
  1657. // run more than ONE ref past the yield budget before the heartbeat gets
  1658. // a window — the #1122 kill required 500.
  1659. expect(checkpoints).toBe(refs.length);
  1660. expect(result.stats.total).toBe(refs.length);
  1661. });
  1662. it('receiver inference reads lines through getFileLines when the context provides it', () => {
  1663. const loggerClass = methodNode('c:logger', 'svc.ts', 'Logger', 'Logger', 'typescript', 'class');
  1664. const logMethod = methodNode('m:log', 'svc.ts', 'Logger::log', 'log');
  1665. const otherLog = methodNode('m:other', 'other.ts', 'Other::log', 'log');
  1666. const byName: Record<string, Node[]> = {
  1667. Logger: [loggerClass],
  1668. log: [logMethod, otherLog], // ambiguous bare name → only inference can resolve
  1669. };
  1670. const lines = ['const lg = new Logger();', 'lg.log();'];
  1671. const ctx: ResolutionContext = {
  1672. getNodesInFile: () => [],
  1673. getNodesByName: (name) => byName[name] ?? [],
  1674. getNodesByQualifiedName: () => [],
  1675. getNodesByKind: () => [],
  1676. fileExists: () => false,
  1677. // Reading the raw source must not be needed when lines are provided.
  1678. readFile: () => { throw new Error('readFile must not be called when getFileLines exists'); },
  1679. getFileLines: () => lines,
  1680. getProjectRoot: () => '',
  1681. getAllFiles: () => [],
  1682. };
  1683. const ref: UnresolvedRef = {
  1684. fromNodeId: 'caller', referenceName: 'lg.log', referenceKind: 'calls',
  1685. line: 2, column: 0, filePath: 'svc.ts', language: 'typescript',
  1686. };
  1687. expect(matchMethodCall(ref, ctx)?.targetNodeId).toBe('m:log');
  1688. });
  1689. it('receiver inference skips generated/minified lines instead of regex-scanning them', () => {
  1690. const loggerClass = methodNode('c:logger', 'svc.ts', 'Logger', 'Logger', 'typescript', 'class');
  1691. const logMethod = methodNode('m:log', 'svc.ts', 'Logger::log', 'log');
  1692. const otherLog = methodNode('m:other', 'other.ts', 'Other::log', 'log');
  1693. const byName: Record<string, Node[]> = {
  1694. Logger: [loggerClass],
  1695. log: [logMethod, otherLog],
  1696. };
  1697. const ctxWithLines = (lines: string[]): ResolutionContext => ({
  1698. getNodesInFile: () => [],
  1699. getNodesByName: (name) => byName[name] ?? [],
  1700. getNodesByQualifiedName: () => [],
  1701. getNodesByKind: () => [],
  1702. fileExists: () => false,
  1703. readFile: () => null,
  1704. getFileLines: () => lines,
  1705. getProjectRoot: () => '',
  1706. getAllFiles: () => [],
  1707. });
  1708. const ref: UnresolvedRef = {
  1709. fromNodeId: 'caller', referenceName: 'lg.log', referenceKind: 'calls',
  1710. line: 1, column: 0, filePath: 'svc.ts', language: 'typescript',
  1711. };
  1712. // Control: the declaration on a normal-length line resolves.
  1713. const normal = matchMethodCall(ref, ctxWithLines(['const lg = new Logger(); lg.log();']));
  1714. expect(normal?.targetNodeId).toBe('m:log');
  1715. // The same declaration buried in a >10K-char generated/minified line is
  1716. // skipped — no resolution, and no per-ref regex pass over the huge line.
  1717. const minified = 'var pad="' + 'x'.repeat(10_000) + '";const lg = new Logger(); lg.log();';
  1718. expect(matchMethodCall(ref, ctxWithLines([minified]))).toBeNull();
  1719. });
  1720. });
  1721. describe('Local-variable receiver-type inference (#1108)', () => {
  1722. // `lg.log()` where `lg` is a local whose type is inferred from its
  1723. // declaration/initializer. Before this, only C++ resolved these; every
  1724. // other language produced no method edge. Each case is one file with a
  1725. // single Logger + a caller using a local-variable receiver — a correct
  1726. // resolution makes the caller a caller of `log`.
  1727. const cases: Array<{ lang: string; file: string; src: string }> = [
  1728. { lang: 'TypeScript (= new T)', file: 'svc.ts',
  1729. src: `class Logger { log() { return 1; } }\nexport function use() { const lg = new Logger(); return lg.log(); }\n` },
  1730. { lang: 'JavaScript (= new T)', file: 'svc.js',
  1731. src: `class Logger { log() { return 1; } }\nexport function use() { const lg = new Logger(); return lg.log(); }\n` },
  1732. { lang: 'Python (= T())', file: 'svc.py',
  1733. src: `class Logger:\n def log(self):\n return 1\ndef use():\n lg = Logger()\n return lg.log()\n` },
  1734. { lang: 'Java (T x = new T)', file: 'Svc.java',
  1735. src: `class Logger { void log() { int a = 1; } }\nclass Use { void run() { Logger lg = new Logger(); lg.log(); } }\n` },
  1736. { lang: 'C# (var x = new T)', file: 'Svc.cs',
  1737. src: `class Logger { void Log() { int a = 1; } }\nclass Use { void Run() { var lg = new Logger(); lg.Log(); } }\n` },
  1738. { lang: 'Kotlin (val x = T())', file: 'Svc.kt',
  1739. src: `class Logger { fun log(): Int { return 1 } }\nfun use(): Int { val lg = Logger(); return lg.log() }\n` },
  1740. { lang: 'Swift (let x = T())', file: 'svc.swift',
  1741. src: `class Logger { func log() -> Int { return 1 } }\nfunc use() -> Int { let lg = Logger(); return lg.log() }\n` },
  1742. { lang: 'Go (x := T{})', file: 'svc.go',
  1743. src: `package a\ntype Logger struct{}\nfunc (l Logger) Log() int { return 1 }\nfunc Use() int { lg := Logger{}; return lg.Log() }\n` },
  1744. { lang: 'Rust (let x = T{})', file: 'svc.rs',
  1745. src: `pub struct Logger { n: i32 }\nimpl Logger { pub fn log(&self) -> i32 { self.n } }\npub fn use_it() -> i32 { let lg = Logger { n: 1 }; lg.log() }\n` },
  1746. { lang: 'Dart (var x = T())', file: 'svc.dart',
  1747. src: `class Logger { int log() { return 1; } }\nint use() { var lg = Logger(); return lg.log(); }\n` },
  1748. { lang: 'PHP ($x = new T)', file: 'svc.php',
  1749. src: `<?php\nclass Logger { function log() { return 1; } }\nfunction useIt() { $lg = new Logger(); return $lg->log(); }\n` },
  1750. { lang: 'Scala (val x = new T)', file: 'Svc.scala',
  1751. src: `class Logger { def log(): Int = 1 }\nobject A { def use(): Int = { val lg = new Logger(); lg.log() } }\n` },
  1752. { lang: 'Ruby (x = T.new)', file: 'svc.rb',
  1753. src: `class Logger\n def log\n 1\n end\nend\ndef use\n lg = Logger.new\n lg.log\nend\n` },
  1754. { lang: 'Lua (x = T.new(); x:log())', file: 'svc.lua',
  1755. src: `local Logger = {}\nLogger.__index = Logger\nfunction Logger.new() return setmetatable({}, Logger) end\nfunction Logger:log() return 1 end\nlocal function use() local lg = Logger.new(); return lg:log() end\nreturn use\n` },
  1756. { lang: 'Luau (x = T.new(); x:log())', file: 'svc.luau',
  1757. src: `local Logger = {}\nLogger.__index = Logger\nfunction Logger.new() return setmetatable({}, Logger) end\nfunction Logger:log(): number return 1 end\nlocal function use(): number local lg = Logger.new(); return lg:log() end\nreturn use\n` },
  1758. { lang: 'R (x <- T$new(); x$log())', file: 'svc.R',
  1759. src: `Logger <- R6::R6Class("Logger", public = list(log = function() 1))\nuse <- function() { lg <- Logger$new(); lg$log() }\n` },
  1760. { lang: 'Pascal (var x: T; x.Method)', file: 'svc.pas',
  1761. src: `unit A;\ninterface\ntype TLogger = class function Log: Integer; end;\nimplementation\nfunction TLogger.Log: Integer; begin Result := 1; end;\nprocedure Use;\nvar lg: TLogger;\nbegin\n lg := TLogger.Create;\n lg.Log;\nend;\nend.\n` },
  1762. ];
  1763. for (const c of cases) {
  1764. it(`resolves a local-variable method call — ${c.lang}`, async () => {
  1765. fs.writeFileSync(path.join(tempDir, c.file), c.src);
  1766. cg = await CodeGraph.init(tempDir, { index: true });
  1767. cg.resolveReferences();
  1768. const logMethod = cg
  1769. .getNodesByKind('method')
  1770. .find((n) => n.name.toLowerCase() === 'log');
  1771. expect(logMethod, `${c.lang}: log method should be indexed`).toBeDefined();
  1772. // The enclosing caller resolves through the local variable to `log`.
  1773. const callers = cg.getCallers(logMethod!.id).map((x) => x.node.name);
  1774. expect(
  1775. callers.length,
  1776. `${c.lang}: log should have a caller (got [${callers.join(', ')}])`,
  1777. ).toBeGreaterThan(0);
  1778. });
  1779. }
  1780. it('Ruby: builds receiver.method and keeps Foo.new as an instantiation', async () => {
  1781. // The Ruby extractor previously took the receiver as the callee and
  1782. // dropped the method name (`lg.log()` -> a call to `lg`). Now it builds
  1783. // `lg.log`, while `Logger.new` must still record an instantiation.
  1784. fs.writeFileSync(
  1785. path.join(tempDir, 'svc.rb'),
  1786. `class Logger\n def log\n 1\n end\nend\ndef run\n lg = Logger.new\n lg.log\nend\n`,
  1787. );
  1788. cg = await CodeGraph.init(tempDir, { index: true });
  1789. cg.resolveReferences();
  1790. const run = cg.getNodesByKind('function').find((n) => n.name === 'run')!;
  1791. const logMethod = cg.getNodesByKind('method').find((n) => n.name === 'log')!;
  1792. const logger = cg.getNodesByKind('class').find((n) => n.name === 'Logger')!;
  1793. const out = cg.getOutgoingEdges(run.id);
  1794. // lg.log resolved to the method (the receiver-type inference kicked in).
  1795. expect(out.some((e) => e.kind === 'calls' && e.target === logMethod.id)).toBe(true);
  1796. // Logger.new is still an instantiation of the class.
  1797. expect(out.some((e) => e.kind === 'instantiates' && e.target === logger.id)).toBe(true);
  1798. });
  1799. it('TypeScript: infers a typed-parameter receiver, disambiguating same-named methods (#1125)', async () => {
  1800. // A typed function parameter used as a receiver — `function use(lg: Logger)`
  1801. // — never matched the old TS/JS pattern (it required a const|let|var
  1802. // prefix), so `lg.log()` fell through to no edge once a second class shared
  1803. // the method name. Two ambiguous classes are load-bearing here: a
  1804. // single-class version resolves via a same-name fallback even without
  1805. // inference, so only the collision proves type inference actually fired.
  1806. fs.writeFileSync(
  1807. path.join(tempDir, 'svc.ts'),
  1808. `class Logger { log() { return 1; } }\n` +
  1809. `class Other { log() { return 2; } }\n` +
  1810. `export function use(lg: Logger) { return lg.log(); }\n` +
  1811. `export function useOther(o: Other) { return o.log(); }\n`,
  1812. );
  1813. cg = await CodeGraph.init(tempDir, { index: true });
  1814. cg.resolveReferences();
  1815. const classes = cg.getNodesByKind('class');
  1816. const logger = classes.find((n) => n.name === 'Logger')!;
  1817. const other = classes.find((n) => n.name === 'Other')!;
  1818. const logs = cg.getNodesByKind('method').filter((n) => n.name === 'log');
  1819. expect(logs.length, 'both log methods should be indexed').toBe(2);
  1820. // Associate each same-named `log` with its class by line containment.
  1821. const inClass = (m: (typeof logs)[number], c: typeof logger) =>
  1822. m.startLine >= c.startLine && m.startLine <= (c.endLine ?? c.startLine);
  1823. const loggerLog = logs.find((m) => inClass(m, logger))!;
  1824. const otherLog = logs.find((m) => inClass(m, other))!;
  1825. expect(loggerLog, "Logger's log").toBeDefined();
  1826. expect(otherLog, "Other's log").toBeDefined();
  1827. const loggerCallers = cg.getCallers(loggerLog.id).map((x) => x.node.name);
  1828. const otherCallers = cg.getCallers(otherLog.id).map((x) => x.node.name);
  1829. // Each typed-param call routes to its OWN class's method, not the other's.
  1830. expect(loggerCallers).toContain('use');
  1831. expect(loggerCallers).not.toContain('useOther');
  1832. expect(otherCallers).toContain('useOther');
  1833. expect(otherCallers).not.toContain('use');
  1834. });
  1835. // The same typed-parameter gap existed in every language whose pattern set
  1836. // only matched keyword-anchored locals (let/var/:=/= new), not the bare
  1837. // parameter form — Rust, Go, Dart, PHP (#1125). Each case: two classes
  1838. // sharing a method name + two functions taking one as a typed param; a
  1839. // correct fix routes each call to its OWN type's method (the collision is
  1840. // load-bearing — a single class resolves via the same-name fallback either
  1841. // way). Method↔type association is by qualifiedName, robust where the method
  1842. // lives outside the type's line range (Rust `impl`, Go method decl).
  1843. const typedParamCases: Array<{
  1844. lang: string; file: string; method: string; callerA: string; callerB: string; src: string;
  1845. }> = [
  1846. { lang: 'Rust (fn f(x: &T))', file: 'svc.rs', method: 'log', callerA: 'use_it', callerB: 'use_other',
  1847. src: `pub struct Logger { n: i32 }\nimpl Logger { pub fn log(&self) -> i32 { self.n } }\npub struct Other { n: i32 }\nimpl Other { pub fn log(&self) -> i32 { self.n } }\npub fn use_it(lg: &Logger) -> i32 { lg.log() }\npub fn use_other(o: &Other) -> i32 { o.log() }\n` },
  1848. { lang: 'Go (func f(x T))', file: 'svc.go', method: 'Log', callerA: 'UseIt', callerB: 'UseOther',
  1849. src: `package a\ntype Logger struct{}\nfunc (l Logger) Log() int { return 1 }\ntype Other struct{}\nfunc (o Other) Log() int { return 2 }\nfunc UseIt(lg Logger) int { return lg.Log() }\nfunc UseOther(o Other) int { return o.Log() }\n` },
  1850. { lang: 'Dart (T f(U x))', file: 'svc.dart', method: 'log', callerA: 'useIt', callerB: 'useOther',
  1851. src: `class Logger { int log() { return 1; } }\nclass Other { int log() { return 2; } }\nint useIt(Logger lg) { return lg.log(); }\nint useOther(Other o) { return o.log(); }\n` },
  1852. { lang: 'PHP (f(T $x))', file: 'svc.php', method: 'log', callerA: 'useIt', callerB: 'useOther',
  1853. src: `<?php\nclass Logger { function log() { return 1; } }\nclass Other { function log() { return 2; } }\nfunction useIt(Logger $lg) { return $lg->log(); }\nfunction useOther(Other $o) { return $o->log(); }\n` },
  1854. ];
  1855. for (const c of typedParamCases) {
  1856. it(`infers a typed-parameter receiver, disambiguating same-named methods — ${c.lang} (#1125)`, async () => {
  1857. fs.writeFileSync(path.join(tempDir, c.file), c.src);
  1858. cg = await CodeGraph.init(tempDir, { index: true });
  1859. cg.resolveReferences();
  1860. const methods = cg.getNodesByKind('method').filter((n) => n.name === c.method);
  1861. expect(methods.length, `${c.lang}: both ${c.method} methods indexed`).toBe(2);
  1862. const loggerLog = methods.find((m) => /Logger/.test(m.qualifiedName ?? ''));
  1863. const otherLog = methods.find((m) => /Other/.test(m.qualifiedName ?? ''));
  1864. expect(loggerLog, `${c.lang}: Logger's ${c.method}`).toBeDefined();
  1865. expect(otherLog, `${c.lang}: Other's ${c.method}`).toBeDefined();
  1866. const loggerCallers = cg.getCallers(loggerLog!.id).map((x) => x.node.name);
  1867. const otherCallers = cg.getCallers(otherLog!.id).map((x) => x.node.name);
  1868. expect(loggerCallers, `${c.lang}: Logger callers`).toContain(c.callerA);
  1869. expect(loggerCallers, `${c.lang}: Logger callers`).not.toContain(c.callerB);
  1870. expect(otherCallers, `${c.lang}: Other callers`).toContain(c.callerB);
  1871. expect(otherCallers, `${c.lang}: Other callers`).not.toContain(c.callerA);
  1872. });
  1873. }
  1874. // Lua/Luau: a PascalCase method call (`lg:Log()`, the Roblox convention)
  1875. // is the identical `receiver:Name` shape as a Luau type annotation, so it
  1876. // self-matched the annotation pattern on the call's own line and inferred
  1877. // "type = Log" (#1124). Two things are load-bearing in these fixtures:
  1878. // the declaration sits on an EARLIER line than the call (on one line,
  1879. // pattern order resolves it — the `.new` pattern wins first), and TWO
  1880. // classes share the method name (a single class resolves via the
  1881. // same-name fallback even when inference misfires). Luau's `useLogger`
  1882. // takes a typed param instead of calling `.new()`, pinning that the
  1883. // gated pattern still matches a genuine annotation.
  1884. const pascalMethodCases: Array<{ lang: string; file: string; src: string }> = [
  1885. { lang: 'Lua', file: 'svc.lua',
  1886. src: `local Logger = {}\nLogger.__index = Logger\nfunction Logger.new() return setmetatable({}, Logger) end\nfunction Logger:Log() return 1 end\n\nlocal Other = {}\nOther.__index = Other\nfunction Other.new() return setmetatable({}, Other) end\nfunction Other:Log() return 2 end\n\nlocal function useLogger()\n\tlocal lg = Logger.new()\n\treturn lg:Log()\nend\n\nlocal function useOther()\n\tlocal o = Other.new()\n\treturn o:Log()\nend\n\nreturn useLogger, useOther\n` },
  1887. { lang: 'Luau', file: 'svc.luau',
  1888. src: `local Logger = {}\nLogger.__index = Logger\nfunction Logger.new() return setmetatable({}, Logger) end\nfunction Logger:Log(): number return 1 end\n\nlocal Other = {}\nOther.__index = Other\nfunction Other.new() return setmetatable({}, Other) end\nfunction Other:Log(): number return 2 end\n\nlocal function useLogger(lg: Logger): number\n\treturn lg:Log()\nend\n\nlocal function useOther(): number\n\tlocal o = Other.new()\n\treturn o:Log()\nend\n\nreturn useLogger, useOther\n` },
  1889. ];
  1890. for (const c of pascalMethodCases) {
  1891. it(`resolves a PascalCase method call without self-matching the annotation pattern — ${c.lang} (#1124)`, async () => {
  1892. fs.writeFileSync(path.join(tempDir, c.file), c.src);
  1893. cg = await CodeGraph.init(tempDir, { index: true });
  1894. cg.resolveReferences();
  1895. const methods = cg.getNodesByKind('method').filter((n) => n.name === 'Log');
  1896. expect(methods.length, `${c.lang}: both Log methods indexed`).toBe(2);
  1897. const loggerLog = methods.find((m) => /Logger/.test(m.qualifiedName ?? ''));
  1898. const otherLog = methods.find((m) => /Other/.test(m.qualifiedName ?? ''));
  1899. expect(loggerLog, `${c.lang}: Logger's Log`).toBeDefined();
  1900. expect(otherLog, `${c.lang}: Other's Log`).toBeDefined();
  1901. const loggerCallers = cg.getCallers(loggerLog!.id).map((x) => x.node.name);
  1902. const otherCallers = cg.getCallers(otherLog!.id).map((x) => x.node.name);
  1903. expect(loggerCallers, `${c.lang}: Logger callers`).toContain('useLogger');
  1904. expect(loggerCallers, `${c.lang}: Logger callers`).not.toContain('useOther');
  1905. expect(otherCallers, `${c.lang}: Other callers`).toContain('useOther');
  1906. expect(otherCallers, `${c.lang}: Other callers`).not.toContain('useLogger');
  1907. });
  1908. }
  1909. });
  1910. describe('Name Matcher: kind bias for new ref kinds', () => {
  1911. const baseContext = (candidates: Node[]): ResolutionContext => ({
  1912. getNodesInFile: () => [],
  1913. getNodesByName: (name) => candidates.filter((c) => c.name === name),
  1914. getNodesByQualifiedName: () => [],
  1915. getNodesByKind: () => [],
  1916. fileExists: () => true,
  1917. readFile: () => null,
  1918. getProjectRoot: () => '/test',
  1919. getAllFiles: () => [],
  1920. getNodesByLowerName: () => [],
  1921. getImportMappings: () => [],
  1922. });
  1923. it('prefers a class candidate over a function for `instantiates` refs', () => {
  1924. // A class and a function share a name across the codebase.
  1925. // Without the kind bias, the function (which gets the +25 `calls`
  1926. // bonus historically applied to all candidates of that kind) would
  1927. // win. Now the instantiates branch reverses it.
  1928. const fn: Node = {
  1929. id: 'func:utils.ts:Logger:5', kind: 'function', name: 'Logger',
  1930. qualifiedName: 'utils.ts::Logger', filePath: 'utils.ts', language: 'typescript',
  1931. startLine: 5, endLine: 7, startColumn: 0, endColumn: 0, updatedAt: Date.now(),
  1932. };
  1933. const cls: Node = {
  1934. id: 'class:logger.ts:Logger:10', kind: 'class', name: 'Logger',
  1935. qualifiedName: 'logger.ts::Logger', filePath: 'logger.ts', language: 'typescript',
  1936. startLine: 10, endLine: 30, startColumn: 0, endColumn: 0, updatedAt: Date.now(),
  1937. };
  1938. const ref = {
  1939. fromNodeId: 'func:main.ts:bootstrap:1',
  1940. referenceName: 'Logger',
  1941. referenceKind: 'instantiates' as const,
  1942. line: 5, column: 0, filePath: 'main.ts', language: 'typescript' as const,
  1943. };
  1944. const result = matchReference(ref, baseContext([fn, cls]));
  1945. expect(result?.targetNodeId).toBe('class:logger.ts:Logger:10');
  1946. });
  1947. it('prefers a function candidate over a non-function for `decorates` refs', () => {
  1948. const variable: Node = {
  1949. id: 'var:config.ts:Inject:5', kind: 'variable', name: 'Inject',
  1950. qualifiedName: 'config.ts::Inject', filePath: 'config.ts', language: 'typescript',
  1951. startLine: 5, endLine: 5, startColumn: 0, endColumn: 0, updatedAt: Date.now(),
  1952. };
  1953. const decorator: Node = {
  1954. id: 'func:di.ts:Inject:10', kind: 'function', name: 'Inject',
  1955. qualifiedName: 'di.ts::Inject', filePath: 'di.ts', language: 'typescript',
  1956. startLine: 10, endLine: 20, startColumn: 0, endColumn: 0, updatedAt: Date.now(),
  1957. };
  1958. const ref = {
  1959. fromNodeId: 'class:svc.ts:UserService:1',
  1960. referenceName: 'Inject',
  1961. referenceKind: 'decorates' as const,
  1962. line: 5, column: 0, filePath: 'svc.ts', language: 'typescript' as const,
  1963. };
  1964. const result = matchReference(ref, baseContext([variable, decorator]));
  1965. expect(result?.targetNodeId).toBe('func:di.ts:Inject:10');
  1966. });
  1967. });
  1968. describe('tsconfig path aliases', () => {
  1969. it('resolves an aliased import to the alias-mapped file (not a same-named file elsewhere)', async () => {
  1970. // Two same-named exports in different directories. Without alias
  1971. // resolution, name-matcher would pick whichever it finds first;
  1972. // with alias resolution, the import path uniquely picks one.
  1973. fs.mkdirSync(path.join(tempDir, 'src/utils'), { recursive: true });
  1974. fs.mkdirSync(path.join(tempDir, 'src/legacy'), { recursive: true });
  1975. fs.writeFileSync(
  1976. path.join(tempDir, 'src/utils/format.ts'),
  1977. `export function pickMe(): number { return 1; }\n`
  1978. );
  1979. fs.writeFileSync(
  1980. path.join(tempDir, 'src/legacy/format.ts'),
  1981. `export function pickMe(): number { return 99; }\n`
  1982. );
  1983. fs.writeFileSync(
  1984. path.join(tempDir, 'src/main.ts'),
  1985. `import { pickMe } from '@utils/format';\nexport function go(): number { return pickMe(); }\n`
  1986. );
  1987. fs.writeFileSync(
  1988. path.join(tempDir, 'tsconfig.json'),
  1989. JSON.stringify({
  1990. compilerOptions: {
  1991. baseUrl: './src',
  1992. paths: { '@utils/*': ['utils/*'] },
  1993. },
  1994. })
  1995. );
  1996. cg = await CodeGraph.init(tempDir, { index: true });
  1997. cg.resolveReferences();
  1998. // The two pickMe nodes live in different files. The aliased
  1999. // import should attach the call edge to the @utils-mapped one,
  2000. // not the legacy duplicate.
  2001. const all = cg.getNodesByKind('function').filter((n) => n.name === 'pickMe');
  2002. const utilsNode = all.find((n) => n.filePath === 'src/utils/format.ts');
  2003. const legacyNode = all.find((n) => n.filePath === 'src/legacy/format.ts');
  2004. expect(utilsNode).toBeDefined();
  2005. expect(legacyNode).toBeDefined();
  2006. const utilsCallers = cg.getCallers(utilsNode!.id);
  2007. const legacyCallers = cg.getCallers(legacyNode!.id);
  2008. expect(utilsCallers.length).toBeGreaterThan(0);
  2009. expect(utilsCallers.some((c) => c.node.filePath === 'src/main.ts')).toBe(true);
  2010. // The legacy node should NOT have a caller from src/main.ts —
  2011. // the alias correctly picked the utils version.
  2012. expect(legacyCallers.some((c) => c.node.filePath === 'src/main.ts')).toBe(false);
  2013. });
  2014. it('falls back gracefully when tsconfig is absent', async () => {
  2015. fs.mkdirSync(path.join(tempDir, 'src'), { recursive: true });
  2016. fs.writeFileSync(
  2017. path.join(tempDir, 'src/a.ts'),
  2018. `export function aFn(): void {}\n`
  2019. );
  2020. fs.writeFileSync(
  2021. path.join(tempDir, 'src/b.ts'),
  2022. `import { aFn } from './a';\nexport function bFn(): void { aFn(); }\n`
  2023. );
  2024. cg = await CodeGraph.init(tempDir, { index: true });
  2025. // No tsconfig present — index should still complete and the
  2026. // relative-import-based call edge should be created.
  2027. const aFn = cg.getNodesByKind('function').find((n) => n.name === 'aFn');
  2028. expect(aFn).toBeDefined();
  2029. const callers = cg.getCallers(aFn!.id);
  2030. expect(callers.some((c) => c.node.filePath === 'src/b.ts')).toBe(true);
  2031. });
  2032. });
  2033. describe('re-export chain following', () => {
  2034. it('chases a 3-hop barrel chain (wildcard → named → declaration)', async () => {
  2035. // main.ts → all.ts (wildcard) → index.ts (named) → auth.ts (declaration).
  2036. // Without chain following, `signIn` resolves to nothing because
  2037. // none of the barrel files declare it directly.
  2038. fs.mkdirSync(path.join(tempDir, 'src/services'), { recursive: true });
  2039. fs.writeFileSync(
  2040. path.join(tempDir, 'src/services/auth.ts'),
  2041. `export function signIn(): void {}\n`
  2042. );
  2043. fs.writeFileSync(
  2044. path.join(tempDir, 'src/services/index.ts'),
  2045. `export { signIn } from './auth';\n`
  2046. );
  2047. fs.writeFileSync(
  2048. path.join(tempDir, 'src/all.ts'),
  2049. `export * from './services/index';\n`
  2050. );
  2051. fs.writeFileSync(
  2052. path.join(tempDir, 'src/main.ts'),
  2053. `import { signIn } from './all';\nexport function go(): void { signIn(); }\n`
  2054. );
  2055. cg = await CodeGraph.init(tempDir, { index: true });
  2056. cg.resolveReferences();
  2057. const signInNode = cg
  2058. .getNodesByKind('function')
  2059. .find((n) => n.name === 'signIn' && n.filePath === 'src/services/auth.ts');
  2060. expect(signInNode).toBeDefined();
  2061. const callers = cg.getCallers(signInNode!.id);
  2062. expect(callers.some((c) => c.node.filePath === 'src/main.ts')).toBe(true);
  2063. });
  2064. it('follows a renamed named re-export (export { foo as bar } from ...)', async () => {
  2065. // The chase has to look up `foo` in the upstream module even
  2066. // though the importer asked for `bar` — exercises the rename
  2067. // branch of findExportedSymbol.
  2068. fs.mkdirSync(path.join(tempDir, 'src'), { recursive: true });
  2069. fs.writeFileSync(
  2070. path.join(tempDir, 'src/auth.ts'),
  2071. `export function signIn(): void {}\n`
  2072. );
  2073. fs.writeFileSync(
  2074. path.join(tempDir, 'src/index.ts'),
  2075. `export { signIn as login } from './auth';\n`
  2076. );
  2077. fs.writeFileSync(
  2078. path.join(tempDir, 'src/main.ts'),
  2079. `import { login } from './index';\nexport function go(): void { login(); }\n`
  2080. );
  2081. cg = await CodeGraph.init(tempDir, { index: true });
  2082. cg.resolveReferences();
  2083. const signInNode = cg
  2084. .getNodesByKind('function')
  2085. .find((n) => n.name === 'signIn' && n.filePath === 'src/auth.ts');
  2086. expect(signInNode).toBeDefined();
  2087. const callers = cg.getCallers(signInNode!.id);
  2088. expect(callers.some((c) => c.node.filePath === 'src/main.ts')).toBe(true);
  2089. });
  2090. it('follows a default re-export of a .svelte component (export { default as Foo } from ./RealButton.svelte) (#629)', async () => {
  2091. // The ubiquitous Svelte/React component-barrel form. The leaf is a
  2092. // .svelte component (extracted as kind 'component', the default
  2093. // export). The re-export ALIAS (`Foo`) deliberately differs from the
  2094. // component's real name (`RealButton`) so the name-matcher fallback
  2095. // can't coincidentally connect them — the only path to the edge is
  2096. // the import-chase, which must match a `component` (not just
  2097. // function/class) for the default export. Otherwise the
  2098. // consumer↔component edge is never created and `callers` returns a
  2099. // false 0.
  2100. fs.mkdirSync(path.join(tempDir, 'src/lib'), { recursive: true });
  2101. fs.writeFileSync(
  2102. path.join(tempDir, 'src/lib/RealButton.svelte'),
  2103. `<script lang="ts">\n export let label: string = '';\n</script>\n\n<button>{label}</button>\n`
  2104. );
  2105. fs.writeFileSync(
  2106. path.join(tempDir, 'src/lib/index.ts'),
  2107. `export { default as Foo } from './RealButton.svelte';\n`
  2108. );
  2109. fs.writeFileSync(
  2110. path.join(tempDir, 'src/Bar.svelte'),
  2111. `<script lang="ts">\n import { Foo } from './lib';\n</script>\n\n<Foo />\n`
  2112. );
  2113. cg = await CodeGraph.init(tempDir, { index: true });
  2114. cg.resolveReferences();
  2115. const fooNode = cg
  2116. .getNodesByKind('component')
  2117. .find((n) => n.name === 'RealButton' && n.filePath === 'src/lib/RealButton.svelte');
  2118. expect(fooNode).toBeDefined();
  2119. const callers = cg.getCallers(fooNode!.id);
  2120. expect(callers.some((c) => c.node.filePath === 'src/Bar.svelte')).toBe(true);
  2121. });
  2122. it('links an .astro page to the component and TS util it uses (#768)', async () => {
  2123. // The canonical Astro shape: a page imports a layout/component in
  2124. // frontmatter and uses it as a template tag; the component's template
  2125. // calls an imported .ts util. Both hops must produce graph edges or
  2126. // an Astro project is invisible to callers/impact.
  2127. fs.mkdirSync(path.join(tempDir, 'src/components'), { recursive: true });
  2128. fs.mkdirSync(path.join(tempDir, 'src/utils'), { recursive: true });
  2129. fs.mkdirSync(path.join(tempDir, 'src/pages'), { recursive: true });
  2130. fs.writeFileSync(
  2131. path.join(tempDir, 'src/utils/format.ts'),
  2132. `export function formatDate(d: Date): string { return d.toISOString(); }\n`
  2133. );
  2134. fs.writeFileSync(
  2135. path.join(tempDir, 'src/components/PostCard.astro'),
  2136. `---\nimport { formatDate } from '../utils/format';\nconst { date } = Astro.props;\n---\n<time>{formatDate(date)}</time>\n`
  2137. );
  2138. fs.writeFileSync(
  2139. path.join(tempDir, 'src/pages/index.astro'),
  2140. `---\nimport PostCard from '../components/PostCard.astro';\n---\n<PostCard date={new Date()} />\n`
  2141. );
  2142. cg = await CodeGraph.init(tempDir, { index: true });
  2143. cg.resolveReferences();
  2144. // Hop 1: page → component (template tag through the frontmatter import)
  2145. const cardNode = cg
  2146. .getNodesByKind('component')
  2147. .find((n) => n.name === 'PostCard' && n.filePath === 'src/components/PostCard.astro');
  2148. expect(cardNode).toBeDefined();
  2149. const cardCallers = cg.getCallers(cardNode!.id);
  2150. expect(cardCallers.some((c) => c.node.filePath === 'src/pages/index.astro')).toBe(true);
  2151. // Hop 2: component template call → .ts util
  2152. const fmtNode = cg
  2153. .getNodesByKind('function')
  2154. .find((n) => n.name === 'formatDate' && n.filePath === 'src/utils/format.ts');
  2155. expect(fmtNode).toBeDefined();
  2156. const fmtCallers = cg.getCallers(fmtNode!.id);
  2157. expect(fmtCallers.some((c) => c.node.filePath === 'src/components/PostCard.astro')).toBe(true);
  2158. });
  2159. it('resolves a bare directory import (import { x } from "." / "./") to index.ts (#629)', async () => {
  2160. // `import { helper } from '.'` (or './') must map to the
  2161. // directory's index.ts before the re-export chase can run. The
  2162. // barrel renames `realHelper` → `helper` so the name-matcher can't
  2163. // mask a path-resolution failure: only the bare-dir resolution +
  2164. // rename chase can connect the edge.
  2165. fs.mkdirSync(path.join(tempDir, 'src'), { recursive: true });
  2166. fs.writeFileSync(
  2167. path.join(tempDir, 'src/util.ts'),
  2168. `export function realHelper(): void {}\n`
  2169. );
  2170. fs.writeFileSync(
  2171. path.join(tempDir, 'src/index.ts'),
  2172. `export { realHelper as helper } from './util';\n`
  2173. );
  2174. fs.writeFileSync(
  2175. path.join(tempDir, 'src/main.ts'),
  2176. `import { helper } from '.';\nexport function go(): void { helper(); }\n`
  2177. );
  2178. fs.writeFileSync(
  2179. path.join(tempDir, 'src/main2.ts'),
  2180. `import { helper } from './';\nexport function go2(): void { helper(); }\n`
  2181. );
  2182. cg = await CodeGraph.init(tempDir, { index: true });
  2183. cg.resolveReferences();
  2184. const helperNode = cg
  2185. .getNodesByKind('function')
  2186. .find((n) => n.name === 'realHelper' && n.filePath === 'src/util.ts');
  2187. expect(helperNode).toBeDefined();
  2188. const callers = cg.getCallers(helperNode!.id);
  2189. expect(callers.some((c) => c.node.filePath === 'src/main.ts')).toBe(true);
  2190. expect(callers.some((c) => c.node.filePath === 'src/main2.ts')).toBe(true);
  2191. });
  2192. it('resolves a workspace package-subpath barrel (@scope/pkg/sub) to its index (#629)', async () => {
  2193. // bun/npm/pnpm workspace: `@scope/ui/widgets` → the `ui` package's
  2194. // `widgets/` subdir index, which re-exports a .svelte component.
  2195. // Alias `Thing` ≠ component `Widget` defeats the name-matcher, so
  2196. // only workspace-package resolution can connect the edge.
  2197. fs.mkdirSync(path.join(tempDir, 'packages/ui/widgets'), { recursive: true });
  2198. fs.writeFileSync(
  2199. path.join(tempDir, 'package.json'),
  2200. JSON.stringify({ name: 'root', private: true, workspaces: ['packages/*'] }, null, 2)
  2201. );
  2202. fs.writeFileSync(
  2203. path.join(tempDir, 'packages/ui/package.json'),
  2204. JSON.stringify({ name: '@scope/ui', version: '1.0.0' }, null, 2)
  2205. );
  2206. fs.writeFileSync(
  2207. path.join(tempDir, 'packages/ui/widgets/Widget.svelte'),
  2208. `<script lang="ts">\n export let label: string = '';\n</script>\n\n<button>{label}</button>\n`
  2209. );
  2210. fs.writeFileSync(
  2211. path.join(tempDir, 'packages/ui/widgets/index.ts'),
  2212. `export { default as Thing } from './Widget.svelte';\n`
  2213. );
  2214. fs.mkdirSync(path.join(tempDir, 'app'), { recursive: true });
  2215. fs.writeFileSync(
  2216. path.join(tempDir, 'app/App.svelte'),
  2217. `<script lang="ts">\n import { Thing } from '@scope/ui/widgets';\n</script>\n\n<Thing />\n`
  2218. );
  2219. cg = await CodeGraph.init(tempDir, { index: true });
  2220. cg.resolveReferences();
  2221. const buttonNode = cg
  2222. .getNodesByKind('component')
  2223. .find((n) => n.name === 'Widget' && n.filePath === 'packages/ui/widgets/Widget.svelte');
  2224. expect(buttonNode).toBeDefined();
  2225. const callers = cg.getCallers(buttonNode!.id);
  2226. expect(callers.some((c) => c.node.filePath === 'app/App.svelte')).toBe(true);
  2227. });
  2228. it('resolves a barrel import from a Vue SFC <script> block (#629)', async () => {
  2229. // The same import-resolution gaps (no SFC import mappings, no SFC
  2230. // extension list, barrel parsed in the consumer's language) broke
  2231. // Vue SFCs too. Guards the resolver-side generalization to `.vue`.
  2232. // The barrel renames `realRun` → `run` so only the import-chase (not
  2233. // the name-matcher) can connect the call.
  2234. fs.mkdirSync(path.join(tempDir, 'src'), { recursive: true });
  2235. fs.writeFileSync(
  2236. path.join(tempDir, 'src/util.ts'),
  2237. `export function realRun(): void {}\n`
  2238. );
  2239. fs.writeFileSync(
  2240. path.join(tempDir, 'src/index.ts'),
  2241. `export { realRun as run } from './util';\n`
  2242. );
  2243. fs.writeFileSync(
  2244. path.join(tempDir, 'src/App.vue'),
  2245. `<script lang="ts">\nimport { run } from './';\nexport default { mounted() { run(); } };\n</script>\n<template><div/></template>\n`
  2246. );
  2247. cg = await CodeGraph.init(tempDir, { index: true });
  2248. cg.resolveReferences();
  2249. const runNode = cg
  2250. .getNodesByKind('function')
  2251. .find((n) => n.name === 'realRun' && n.filePath === 'src/util.ts');
  2252. expect(runNode).toBeDefined();
  2253. const callers = cg.getCallers(runNode!.id);
  2254. expect(callers.some((c) => c.node.filePath === 'src/App.vue')).toBe(true);
  2255. });
  2256. it('follows a Vue component used in a <template> through a default re-export barrel (#629)', async () => {
  2257. // End-to-end Vue analogue of the Svelte case: the leaf is a `.vue`
  2258. // component re-exported under an alias (`Thing`) that differs from its
  2259. // real name (`Widget`), and the consumer uses it ONLY in markup
  2260. // (`<Thing />`). Requires both the new template-tag extraction AND the
  2261. // barrel default-export chase to connect the edge.
  2262. fs.mkdirSync(path.join(tempDir, 'src/lib'), { recursive: true });
  2263. fs.writeFileSync(
  2264. path.join(tempDir, 'src/lib/Widget.vue'),
  2265. `<script setup lang="ts">\ndefineProps<{ label?: string }>();\n</script>\n<template><button>x</button></template>\n`
  2266. );
  2267. fs.writeFileSync(
  2268. path.join(tempDir, 'src/lib/index.ts'),
  2269. `export { default as Thing } from './Widget.vue';\n`
  2270. );
  2271. fs.writeFileSync(
  2272. path.join(tempDir, 'src/App.vue'),
  2273. `<script setup lang="ts">\nimport { Thing } from './lib';\n</script>\n<template>\n <Thing />\n</template>\n`
  2274. );
  2275. cg = await CodeGraph.init(tempDir, { index: true });
  2276. cg.resolveReferences();
  2277. const widgetNode = cg
  2278. .getNodesByKind('component')
  2279. .find((n) => n.name === 'Widget' && n.filePath === 'src/lib/Widget.vue');
  2280. expect(widgetNode).toBeDefined();
  2281. const callers = cg.getCallers(widgetNode!.id);
  2282. expect(callers.some((c) => c.node.filePath === 'src/App.vue')).toBe(true);
  2283. });
  2284. });
  2285. describe('C/C++ Import Resolution', () => {
  2286. afterEach(() => {
  2287. clearCppIncludeDirCache();
  2288. });
  2289. it('should resolve C include to header in same directory', () => {
  2290. const context: ResolutionContext = {
  2291. getNodesInFile: () => [],
  2292. getNodesByName: () => [],
  2293. getNodesByQualifiedName: () => [],
  2294. getNodesByKind: () => [],
  2295. fileExists: (p) => p === 'utils.h',
  2296. readFile: () => null,
  2297. getProjectRoot: () => '',
  2298. getAllFiles: () => ['utils.h', 'main.c'],
  2299. };
  2300. const result = resolveImportPath(
  2301. 'utils.h',
  2302. 'main.c',
  2303. 'c',
  2304. context
  2305. );
  2306. expect(result).toBe('utils.h');
  2307. });
  2308. it('should resolve C++ include with .hpp extension', () => {
  2309. const context: ResolutionContext = {
  2310. getNodesInFile: () => [],
  2311. getNodesByName: () => [],
  2312. getNodesByQualifiedName: () => [],
  2313. getNodesByKind: () => [],
  2314. fileExists: (p) => p === 'include/myclass.hpp',
  2315. readFile: () => null,
  2316. getProjectRoot: () => '',
  2317. getAllFiles: () => ['include/myclass.hpp', 'src/main.cpp'],
  2318. getCppIncludeDirs: () => ['include'],
  2319. };
  2320. const result = resolveImportPath(
  2321. 'myclass.hpp',
  2322. 'src/main.cpp',
  2323. 'cpp',
  2324. context
  2325. );
  2326. expect(result).toBe('include/myclass.hpp');
  2327. });
  2328. it('should resolve include with subdirectory path', () => {
  2329. const context: ResolutionContext = {
  2330. getNodesInFile: () => [],
  2331. getNodesByName: () => [],
  2332. getNodesByQualifiedName: () => [],
  2333. getNodesByKind: () => [],
  2334. fileExists: (p) => p === 'utils/helpers.h',
  2335. readFile: () => null,
  2336. getProjectRoot: () => '',
  2337. getAllFiles: () => ['utils/helpers.h', 'main.c'],
  2338. };
  2339. const result = resolveImportPath(
  2340. 'utils/helpers.h',
  2341. 'main.c',
  2342. 'c',
  2343. context
  2344. );
  2345. expect(result).toBe('utils/helpers.h');
  2346. });
  2347. it('should resolve include via include directories', () => {
  2348. const context: ResolutionContext = {
  2349. getNodesInFile: () => [],
  2350. getNodesByName: () => [],
  2351. getNodesByQualifiedName: () => [],
  2352. getNodesByKind: () => [],
  2353. fileExists: (p) => p === 'include/myheader.h',
  2354. readFile: () => null,
  2355. getProjectRoot: () => '',
  2356. getAllFiles: () => ['include/myheader.h', 'src/main.cpp'],
  2357. getCppIncludeDirs: () => ['include'],
  2358. };
  2359. const result = resolveImportPath(
  2360. 'myheader.h',
  2361. 'src/main.cpp',
  2362. 'cpp',
  2363. context
  2364. );
  2365. expect(result).toBe('include/myheader.h');
  2366. });
  2367. it('should resolve include trying multiple extensions', () => {
  2368. const context: ResolutionContext = {
  2369. getNodesInFile: () => [],
  2370. getNodesByName: () => [],
  2371. getNodesByQualifiedName: () => [],
  2372. getNodesByKind: () => [],
  2373. // myclass.h does not exist, but myclass.hpp does
  2374. fileExists: (p) => p === 'include/myclass.hpp',
  2375. readFile: () => null,
  2376. getProjectRoot: () => '',
  2377. getAllFiles: () => ['include/myclass.hpp', 'src/main.cpp'],
  2378. getCppIncludeDirs: () => ['include'],
  2379. };
  2380. const result = resolveImportPath(
  2381. 'myclass',
  2382. 'src/main.cpp',
  2383. 'cpp',
  2384. context
  2385. );
  2386. expect(result).toBe('include/myclass.hpp');
  2387. });
  2388. it('should return null for system headers', () => {
  2389. const context: ResolutionContext = {
  2390. getNodesInFile: () => [],
  2391. getNodesByName: () => [],
  2392. getNodesByQualifiedName: () => [],
  2393. getNodesByKind: () => [],
  2394. fileExists: () => true,
  2395. readFile: () => null,
  2396. getProjectRoot: () => '',
  2397. getAllFiles: () => [],
  2398. };
  2399. // C standard library header
  2400. expect(resolveImportPath('stdio.h', 'main.c', 'c', context)).toBeNull();
  2401. // C++ standard library header
  2402. expect(resolveImportPath('vector', 'main.cpp', 'cpp', context)).toBeNull();
  2403. // C++ C-wrapper header
  2404. expect(resolveImportPath('cstdio', 'main.cpp', 'cpp', context)).toBeNull();
  2405. });
  2406. it('should return null for single-component third-party paths that cannot be resolved', () => {
  2407. const context: ResolutionContext = {
  2408. getNodesInFile: () => [],
  2409. getNodesByName: () => [],
  2410. getNodesByQualifiedName: () => [],
  2411. getNodesByKind: () => [],
  2412. fileExists: () => false,
  2413. readFile: () => null,
  2414. getProjectRoot: () => '',
  2415. getAllFiles: () => [],
  2416. getCppIncludeDirs: () => [],
  2417. };
  2418. // Third-party bare header without path — not resolvable, returns null
  2419. const result = resolveImportPath(
  2420. 'openssl/ssl.h',
  2421. 'main.cpp',
  2422. 'cpp',
  2423. context
  2424. );
  2425. expect(result).toBeNull();
  2426. });
  2427. it('should not filter project headers with path separators', () => {
  2428. const context: ResolutionContext = {
  2429. getNodesInFile: () => [],
  2430. getNodesByName: () => [],
  2431. getNodesByQualifiedName: () => [],
  2432. getNodesByKind: () => [],
  2433. fileExists: (p) => p === 'mylib/utils.h',
  2434. readFile: () => null,
  2435. getProjectRoot: () => '',
  2436. getAllFiles: () => ['mylib/utils.h'],
  2437. };
  2438. // Path with separator should NOT be filtered as external
  2439. const result = resolveImportPath(
  2440. 'mylib/utils.h',
  2441. 'main.c',
  2442. 'c',
  2443. context
  2444. );
  2445. expect(result).toBe('mylib/utils.h');
  2446. });
  2447. it('should extract C/C++ import mappings from #include directives', () => {
  2448. const code = `#include <iostream>
  2449. #include "myheader.h"
  2450. #include "utils/helpers.hpp"`;
  2451. const mappings = extractImportMappings('main.cpp', code, 'cpp');
  2452. expect(mappings.length).toBe(3);
  2453. expect(mappings[0]).toEqual({
  2454. localName: 'iostream',
  2455. exportedName: '*',
  2456. source: 'iostream',
  2457. isDefault: false,
  2458. isNamespace: true,
  2459. });
  2460. expect(mappings[1]).toEqual({
  2461. localName: 'myheader',
  2462. exportedName: '*',
  2463. source: 'myheader.h',
  2464. isDefault: false,
  2465. isNamespace: true,
  2466. });
  2467. expect(mappings[2]).toEqual({
  2468. localName: 'helpers',
  2469. exportedName: '*',
  2470. source: 'utils/helpers.hpp',
  2471. isDefault: false,
  2472. isNamespace: true,
  2473. });
  2474. });
  2475. it('should discover include directories from compile_commands.json', () => {
  2476. // Create a temp project with compile_commands.json
  2477. const tempProject = fs.mkdtempSync(path.join(os.tmpdir(), 'codegraph-cpp-test-'));
  2478. try {
  2479. const compileDb = [
  2480. {
  2481. directory: tempProject,
  2482. command: 'g++ -Iinclude -Isrc/lib -isystem /usr/include -c src/main.cpp',
  2483. file: 'src/main.cpp',
  2484. },
  2485. ];
  2486. fs.writeFileSync(
  2487. path.join(tempProject, 'compile_commands.json'),
  2488. JSON.stringify(compileDb)
  2489. );
  2490. // Create the include dirs so they exist
  2491. fs.mkdirSync(path.join(tempProject, 'include'), { recursive: true });
  2492. fs.mkdirSync(path.join(tempProject, 'src', 'lib'), { recursive: true });
  2493. clearCppIncludeDirCache();
  2494. const dirs = loadCppIncludeDirs(tempProject);
  2495. // Should find include and src/lib (relative to project root)
  2496. // /usr/include is absolute and outside project, should be excluded
  2497. expect(dirs).toContain('include');
  2498. expect(dirs).toContain('src/lib');
  2499. expect(dirs.some(d => d.includes('usr'))).toBe(false);
  2500. } finally {
  2501. fs.rmSync(tempProject, { recursive: true });
  2502. }
  2503. });
  2504. it('should fall back to heuristic include dirs when no compile_commands.json', () => {
  2505. const tempProject = fs.mkdtempSync(path.join(os.tmpdir(), 'codegraph-cpp-test-'));
  2506. try {
  2507. // Create include/ and src/ directories with headers
  2508. fs.mkdirSync(path.join(tempProject, 'include'), { recursive: true });
  2509. fs.writeFileSync(path.join(tempProject, 'include', 'types.h'), '');
  2510. fs.mkdirSync(path.join(tempProject, 'src'), { recursive: true });
  2511. fs.writeFileSync(path.join(tempProject, 'src', 'main.cpp'), '');
  2512. // Create a directory without headers — should not be included
  2513. fs.mkdirSync(path.join(tempProject, 'docs'), { recursive: true });
  2514. clearCppIncludeDirCache();
  2515. const dirs = loadCppIncludeDirs(tempProject);
  2516. expect(dirs).toContain('include');
  2517. expect(dirs).toContain('src');
  2518. expect(dirs).not.toContain('docs');
  2519. } finally {
  2520. fs.rmSync(tempProject, { recursive: true });
  2521. }
  2522. });
  2523. // Documents the cross-language `.h` behavior. Objective-C and C++ share
  2524. // the `.h` extension, so in a mixed iOS-style project an Obj-C header
  2525. // dir gets claimed as a C/C++ include dir too. That's intentional — a
  2526. // C++ file legitimately can `#include "Foo.h"` against an Obj-C header
  2527. // (Obj-C++ / .mm callers), and false-positive inclusion is far cheaper
  2528. // than missing real resolutions. The test pins this so a later
  2529. // "exclude objc dirs" refactor breaks loudly and reviewers see the
  2530. // trade-off explicitly.
  2531. it('heuristic claims any top-level dir containing .h files, including Obj-C', () => {
  2532. const tempProject = fs.mkdtempSync(path.join(os.tmpdir(), 'codegraph-cpp-test-'));
  2533. try {
  2534. // C++ side: an `cppmod` dir with a .hpp (C++-only extension)
  2535. fs.mkdirSync(path.join(tempProject, 'cppmod'), { recursive: true });
  2536. fs.writeFileSync(path.join(tempProject, 'cppmod', 'shared.hpp'), '');
  2537. // Obj-C side: an `iosmod` dir with .h + .m (no .cpp/.hpp).
  2538. fs.mkdirSync(path.join(tempProject, 'iosmod'), { recursive: true });
  2539. fs.writeFileSync(path.join(tempProject, 'iosmod', 'View.h'), '');
  2540. fs.writeFileSync(path.join(tempProject, 'iosmod', 'View.m'), '');
  2541. clearCppIncludeDirCache();
  2542. const dirs = loadCppIncludeDirs(tempProject);
  2543. // Both included — Obj-C dirs are intentionally allowed.
  2544. expect(dirs).toContain('cppmod');
  2545. expect(dirs).toContain('iosmod');
  2546. } finally {
  2547. fs.rmSync(tempProject, { recursive: true });
  2548. }
  2549. });
  2550. // End-to-end: ensure `#include "X.h"` produces a file→file `imports` edge
  2551. // in the actual indexing pipeline (not just a phantom file→import-node
  2552. // edge). This pins the include-dir resolution path so the headline PR
  2553. // feature can't silently regress to a no-op in the indexing flow.
  2554. it('connects #include to the real header file via include-dir scan (end-to-end)', async () => {
  2555. const tempProject = fs.mkdtempSync(path.join(os.tmpdir(), 'codegraph-cpp-e2e-'));
  2556. try {
  2557. fs.mkdirSync(path.join(tempProject, 'include'), { recursive: true });
  2558. fs.mkdirSync(path.join(tempProject, 'src'), { recursive: true });
  2559. fs.writeFileSync(
  2560. path.join(tempProject, 'include', 'utils.h'),
  2561. `#ifndef UTILS_H\n#define UTILS_H\nint add(int, int);\n#endif\n`
  2562. );
  2563. fs.writeFileSync(
  2564. path.join(tempProject, 'src', 'main.cpp'),
  2565. `#include "utils.h"\n#include <vector>\nint main(){ return add(1,2); }\n`
  2566. );
  2567. clearCppIncludeDirCache();
  2568. cg = await CodeGraph.init(tempProject, { index: true });
  2569. // Sanity: file nodes exist for the header and the cpp.
  2570. const allFiles = cg.getStats();
  2571. expect(allFiles.fileCount).toBe(2);
  2572. // The `#include "utils.h"` edge should target the real
  2573. // `include/utils.h` file node — not a floating `import` node
  2574. // living inside main.cpp.
  2575. const db = DatabaseConnection.open(path.join(tempProject, '.codegraph', 'codegraph.db'));
  2576. const rows = db.getDb().prepare(`
  2577. select dst.kind as dstKind, dst.file_path as dstPath
  2578. from edges e
  2579. join nodes src on e.source = src.id
  2580. join nodes dst on e.target = dst.id
  2581. where e.kind = 'imports'
  2582. and src.kind = 'file'
  2583. and src.file_path = 'src/main.cpp'
  2584. `).all() as Array<{ dstKind: string; dstPath: string }>;
  2585. const resolvedToHeader = rows.find(
  2586. (r) => r.dstKind === 'file' && r.dstPath === 'include/utils.h'
  2587. );
  2588. expect(resolvedToHeader, 'main.cpp → include/utils.h imports edge missing').toBeDefined();
  2589. // `<vector>` should NOT produce a file edge — it's a stdlib header.
  2590. const stdlibFile = rows.find(
  2591. (r) => r.dstKind === 'file' && r.dstPath && r.dstPath.endsWith('vector')
  2592. );
  2593. expect(stdlibFile).toBeUndefined();
  2594. } finally {
  2595. fs.rmSync(tempProject, { recursive: true, force: true });
  2596. }
  2597. });
  2598. });
  2599. describe('C++ templated base-class inheritance (#1043)', () => {
  2600. // A class deriving from a TEMPLATE — `class D : public Base<int>` (or a CRTP
  2601. // `class W : public CRTPBase<W>`, or a qualified `class Q : public ns::Tpl<int>`)
  2602. // recorded its base as the full instantiation text (`Base<int>`), which never
  2603. // name-matched the template, indexed as the bare node `Base`. The `<…>` args
  2604. // are now stripped so the `extends` edge resolves end-to-end.
  2605. it('resolves an extends edge to a templated base (plain, CRTP, struct, multi-base)', async () => {
  2606. fs.writeFileSync(
  2607. path.join(tempDir, 'lib.hpp'),
  2608. `#pragma once
  2609. template<typename T> class Base { public: void foo(); };
  2610. template<typename Derived> class CRTPBase {};
  2611. class Plain {};
  2612. class Widget : public Base<int> {}; // plain template base
  2613. class App : public CRTPBase<App> {}; // CRTP (curiously-recurring)
  2614. struct Node : public Base<double> {}; // struct inheriting a template
  2615. class Both : public Base<char>, public Plain {}; // templated + plain in one clause
  2616. `
  2617. );
  2618. cg = await CodeGraph.init(tempDir, { index: true });
  2619. const db = DatabaseConnection.open(path.join(tempDir, '.codegraph', 'codegraph.db'));
  2620. const edges = db
  2621. .getDb()
  2622. .prepare(
  2623. `select src.name as fromName, dst.name as toName
  2624. from edges e
  2625. join nodes src on e.source = src.id
  2626. join nodes dst on e.target = dst.id
  2627. where e.kind = 'extends'`
  2628. )
  2629. .all() as Array<{ fromName: string; toName: string }>;
  2630. const has = (from: string, to: string) =>
  2631. edges.some((r) => r.fromName === from && r.toName === to);
  2632. // Every templated base now resolves to the bare template node.
  2633. expect(has('Widget', 'Base'), 'Widget : Base<int>').toBe(true);
  2634. expect(has('App', 'CRTPBase'), 'App : CRTPBase<App> (CRTP)').toBe(true);
  2635. expect(has('Node', 'Base'), 'struct Node : Base<double>').toBe(true);
  2636. // A mixed clause resolves BOTH the templated and the plain base.
  2637. expect(has('Both', 'Base'), 'Both : Base<char>').toBe(true);
  2638. expect(has('Both', 'Plain'), 'Both : Plain (non-templated, regression guard)').toBe(true);
  2639. });
  2640. });
  2641. describe('PHP Include Resolution', () => {
  2642. it('isPhpIncludePathRef distinguishes include paths from namespace use (#660)', () => {
  2643. const mk = (name: string, over: Partial<UnresolvedRef> = {}): UnresolvedRef => ({
  2644. fromNodeId: 'f', referenceName: name, referenceKind: 'imports',
  2645. line: 1, column: 0, filePath: 'x.php', language: 'php', ...over,
  2646. });
  2647. // include paths: contain a slash or a file extension
  2648. expect(isPhpIncludePathRef(mk('lib.php'))).toBe(true);
  2649. expect(isPhpIncludePathRef(mk('inc/db.php'))).toBe(true);
  2650. expect(isPhpIncludePathRef(mk('../config.php'))).toBe(true);
  2651. // namespace use symbols: a bare class (Closure) or FQN — never a path,
  2652. // so they must NOT be treated as includes (would mis-connect to a
  2653. // same-named Closure.php / Bar.php file).
  2654. expect(isPhpIncludePathRef(mk('Closure'))).toBe(false);
  2655. expect(isPhpIncludePathRef(mk('PDO'))).toBe(false);
  2656. expect(isPhpIncludePathRef(mk('App\\Foo\\Bar'))).toBe(false);
  2657. // scoped to PHP imports only
  2658. expect(isPhpIncludePathRef(mk('lib.php', { language: 'c' }))).toBe(false);
  2659. expect(isPhpIncludePathRef(mk('lib.php', { referenceKind: 'calls' }))).toBe(false);
  2660. });
  2661. it('resolves require_once to a file→file imports edge (#660)', async () => {
  2662. const tempProject = fs.mkdtempSync(path.join(os.tmpdir(), 'codegraph-php-e2e-'));
  2663. try {
  2664. fs.mkdirSync(path.join(tempProject, 'src'), { recursive: true });
  2665. fs.writeFileSync(
  2666. path.join(tempProject, 'src', 'lib.php'),
  2667. `<?php\nfunction greet() { return "hi"; }\n`
  2668. );
  2669. fs.writeFileSync(
  2670. path.join(tempProject, 'src', 'page.php'),
  2671. `<?php\nrequire_once("lib.php");\necho greet();\n`
  2672. );
  2673. cg = await CodeGraph.init(tempProject, { index: true });
  2674. // reporter's repro: page.php's `require_once("lib.php")` must resolve
  2675. // to the real src/lib.php file node — a file→file `imports` edge, so
  2676. // callers(lib.php) now includes page.php.
  2677. const db = DatabaseConnection.open(path.join(tempProject, '.codegraph', 'codegraph.db'));
  2678. const rows = db.getDb().prepare(`
  2679. select dst.kind as dstKind, dst.file_path as dstPath
  2680. from edges e
  2681. join nodes src on e.source = src.id
  2682. join nodes dst on e.target = dst.id
  2683. where e.kind = 'imports'
  2684. and src.kind = 'file'
  2685. and src.file_path = 'src/page.php'
  2686. `).all() as Array<{ dstKind: string; dstPath: string }>;
  2687. const resolved = rows.find(
  2688. (r) => r.dstKind === 'file' && r.dstPath === 'src/lib.php'
  2689. );
  2690. expect(resolved, 'page.php → src/lib.php imports edge missing').toBeDefined();
  2691. } finally {
  2692. fs.rmSync(tempProject, { recursive: true, force: true });
  2693. }
  2694. });
  2695. it('resolves a subdirectory include path to the correct file (#660)', async () => {
  2696. const tempProject = fs.mkdtempSync(path.join(os.tmpdir(), 'codegraph-php-subdir-'));
  2697. try {
  2698. fs.mkdirSync(path.join(tempProject, 'inc'), { recursive: true });
  2699. fs.writeFileSync(
  2700. path.join(tempProject, 'inc', 'db.php'),
  2701. `<?php\nfunction query() { return 1; }\n`
  2702. );
  2703. fs.writeFileSync(
  2704. path.join(tempProject, 'index.php'),
  2705. `<?php\nrequire "inc/db.php";\nquery();\n`
  2706. );
  2707. cg = await CodeGraph.init(tempProject, { index: true });
  2708. const db = DatabaseConnection.open(path.join(tempProject, '.codegraph', 'codegraph.db'));
  2709. const rows = db.getDb().prepare(`
  2710. select dst.kind as dstKind, dst.file_path as dstPath
  2711. from edges e
  2712. join nodes src on e.source = src.id
  2713. join nodes dst on e.target = dst.id
  2714. where e.kind = 'imports'
  2715. and src.kind = 'file'
  2716. and src.file_path = 'index.php'
  2717. `).all() as Array<{ dstKind: string; dstPath: string }>;
  2718. expect(
  2719. rows.find((r) => r.dstKind === 'file' && r.dstPath === 'inc/db.php'),
  2720. 'index.php → inc/db.php imports edge missing'
  2721. ).toBeDefined();
  2722. } finally {
  2723. fs.rmSync(tempProject, { recursive: true, force: true });
  2724. }
  2725. });
  2726. it('does not mis-connect an unresolvable include to a same-named file elsewhere (#660)', async () => {
  2727. const tempProject = fs.mkdtempSync(path.join(os.tmpdir(), 'codegraph-php-misresolve-'));
  2728. try {
  2729. // app/page.php's `require "inc/db.php"` resolves relative to app/, where
  2730. // inc/db.php does NOT exist. A same-named lib/inc/db.php exists elsewhere
  2731. // but is unrelated — no edge should be created (a wrong edge is worse
  2732. // than a missing one).
  2733. fs.mkdirSync(path.join(tempProject, 'app'), { recursive: true });
  2734. fs.mkdirSync(path.join(tempProject, 'lib', 'inc'), { recursive: true });
  2735. fs.writeFileSync(
  2736. path.join(tempProject, 'lib', 'inc', 'db.php'),
  2737. `<?php\nfunction unrelated() {}\n`
  2738. );
  2739. fs.writeFileSync(
  2740. path.join(tempProject, 'app', 'page.php'),
  2741. `<?php\nrequire "inc/db.php";\n`
  2742. );
  2743. cg = await CodeGraph.init(tempProject, { index: true });
  2744. const db = DatabaseConnection.open(path.join(tempProject, '.codegraph', 'codegraph.db'));
  2745. const rows = db.getDb().prepare(`
  2746. select dst.kind as dstKind, dst.file_path as dstPath
  2747. from edges e
  2748. join nodes src on e.source = src.id
  2749. join nodes dst on e.target = dst.id
  2750. where e.kind = 'imports'
  2751. and src.kind = 'file'
  2752. and src.file_path = 'app/page.php'
  2753. `).all() as Array<{ dstKind: string; dstPath: string }>;
  2754. expect(
  2755. rows.find((r) => r.dstKind === 'file' && r.dstPath === 'lib/inc/db.php'),
  2756. 'app/page.php must NOT mis-connect to unrelated lib/inc/db.php'
  2757. ).toBeUndefined();
  2758. } finally {
  2759. fs.rmSync(tempProject, { recursive: true, force: true });
  2760. }
  2761. });
  2762. });
  2763. describe('C++ chained-call receiver resolution (#645)', () => {
  2764. async function indexCpp(files: Record<string, string>): Promise<void> {
  2765. for (const [name, content] of Object.entries(files)) {
  2766. fs.writeFileSync(path.join(tempDir, name), content);
  2767. }
  2768. cg = await CodeGraph.init(tempDir, { index: true });
  2769. }
  2770. function callerNamesOf(qualifiedName: string): string[] {
  2771. const target = cg.getNodesByKind('method').find((n) => n.qualifiedName === qualifiedName);
  2772. if (!target) return [];
  2773. const names = cg
  2774. .getIncomingEdges(target.id)
  2775. .filter((e) => e.kind === 'calls')
  2776. .map((e) => cg.getNode(e.source)?.name)
  2777. .filter((n): n is string => !!n);
  2778. return [...new Set(names)].sort();
  2779. }
  2780. it('resolves singleton chains and auto locals to the right class, never the first-sorted one', async () => {
  2781. // Two classes share writeLog; Logger sorts first so it wins any name-only
  2782. // tie. All three call forms target Metrics.
  2783. await indexCpp({
  2784. 'logger.hpp': `#pragma once
  2785. #include <string>
  2786. class Logger { public: static Logger& instance(); void writeLog(const std::string&); };
  2787. class Metrics { public: static Metrics& instance(); void writeLog(const std::string&); };
  2788. `,
  2789. 'impl.cpp': `#include "logger.hpp"
  2790. Logger& Logger::instance() { static Logger l; return l; }
  2791. Metrics& Metrics::instance() { static Metrics m; return m; }
  2792. void Logger::writeLog(const std::string&) {}
  2793. void Metrics::writeLog(const std::string&) {}
  2794. `,
  2795. 'app.cpp': `#include "logger.hpp"
  2796. void a() { Metrics::instance().writeLog("x"); } // chained singleton
  2797. void b() { auto& m = Metrics::instance(); m.writeLog("x"); } // stored in auto
  2798. void c() { Metrics& m = Metrics::instance(); m.writeLog("x"); } // explicit type
  2799. `,
  2800. });
  2801. expect(callerNamesOf('Metrics::writeLog')).toEqual(['a', 'b', 'c']);
  2802. expect(callerNamesOf('Logger::writeLog')).toEqual([]);
  2803. });
  2804. it('resolves factories, free-function factories, and member chains via the inner call return type', async () => {
  2805. await indexCpp({
  2806. 'types.hpp': `#pragma once
  2807. #include <memory>
  2808. struct Widget { void draw(); };
  2809. struct Session { void run(); };
  2810. struct View { void render(); };
  2811. class WidgetFactory { public: static Widget create(); };
  2812. class Manager { public: View view(); };
  2813. Session* openSession();
  2814. // Decoy that sorts first and has all three methods — must never win.
  2815. struct Aaa { void draw(); void run(); void render(); };
  2816. `,
  2817. 'impl.cpp': `#include "types.hpp"
  2818. void Widget::draw() {}
  2819. void Session::run() {}
  2820. void View::render() {}
  2821. void Aaa::draw() {}
  2822. void Aaa::run() {}
  2823. void Aaa::render() {}
  2824. Widget WidgetFactory::create() { return Widget(); }
  2825. View Manager::view() { return View(); }
  2826. Session* openSession() { return nullptr; }
  2827. `,
  2828. 'app.cpp': `#include "types.hpp"
  2829. void factory() { WidgetFactory::create().draw(); } // -> Widget::draw
  2830. void freefunc() { openSession()->run(); } // -> Session::run
  2831. void member() { Manager mgr; mgr.view().render(); } // -> View::render
  2832. void makeUnique() { auto w = std::make_unique<Widget>(); w->draw(); } // -> Widget::draw
  2833. `,
  2834. });
  2835. expect(callerNamesOf('Widget::draw')).toEqual(['factory', 'makeUnique']);
  2836. expect(callerNamesOf('Session::run')).toEqual(['freefunc']);
  2837. expect(callerNamesOf('View::render')).toEqual(['member']);
  2838. // The first-sorted decoy never captures any of them.
  2839. expect(callerNamesOf('Aaa::draw')).toEqual([]);
  2840. expect(callerNamesOf('Aaa::run')).toEqual([]);
  2841. expect(callerNamesOf('Aaa::render')).toEqual([]);
  2842. });
  2843. it('creates NO edge when the inferred type lacks the method (silent miss, not a wrong edge)', async () => {
  2844. await indexCpp({
  2845. 'types.hpp': `#pragma once
  2846. struct Widget { void draw(); };
  2847. struct Other { void onlyOther(); };
  2848. class WidgetFactory { public: static Widget create(); };
  2849. `,
  2850. 'impl.cpp': `#include "types.hpp"
  2851. void Widget::draw() {}
  2852. void Other::onlyOther() {}
  2853. Widget WidgetFactory::create() { return Widget(); }
  2854. `,
  2855. 'app.cpp': `#include "types.hpp"
  2856. // Widget has no onlyOther() — must produce NO edge, never a wrong one to Other.
  2857. void wrong() { WidgetFactory::create().onlyOther(); }
  2858. `,
  2859. });
  2860. expect(callerNamesOf('Other::onlyOther')).toEqual([]);
  2861. });
  2862. });
  2863. describe('C++ explicit operator-call resolution (#1247)', () => {
  2864. // `a.operator+(b)` produced no calls edge: the operator_name lands in an
  2865. // ERROR node (never a field_expression callee), so the extractor emitted a
  2866. // ref named just `a`. With the ERROR-node recovery it emits `a.operator+`,
  2867. // and matchMethodCall (dot pattern extended to admit operator method parts)
  2868. // resolves it through receiver-type inference. Infix `a + b` / `a[i]` need
  2869. // real type inference and are out of scope here (#1258).
  2870. async function indexCpp(files: Record<string, string>): Promise<void> {
  2871. for (const [name, content] of Object.entries(files)) {
  2872. fs.writeFileSync(path.join(tempDir, name), content);
  2873. }
  2874. cg = await CodeGraph.init(tempDir, { index: true });
  2875. }
  2876. function callerNamesOf(qualifiedName: string): string[] {
  2877. const target = cg.getNodesByKind('method').find((n) => n.qualifiedName === qualifiedName);
  2878. if (!target) return [];
  2879. const names = cg
  2880. .getIncomingEdges(target.id)
  2881. .filter((e) => e.kind === 'calls')
  2882. .map((e) => cg.getNode(e.source)?.name)
  2883. .filter((n): n is string => !!n);
  2884. return [...new Set(names)].sort();
  2885. }
  2886. it('resolves explicit operator calls to the receiver type, never a same-named decoy', async () => {
  2887. // Aaa sorts first and declares the same operators — only receiver-type
  2888. // inference (const V& a → V) can pick V, so a name-only tie can't win.
  2889. await indexCpp({
  2890. 'optest.cpp': `struct Aaa {
  2891. Aaa operator+(const Aaa& o) const { return o; }
  2892. Aaa operator[](int i) const { return *this; }
  2893. };
  2894. struct V {
  2895. int x;
  2896. V operator+(const V& o) const { return V{x + o.x}; }
  2897. V operator[](int i) const { return V{x + i}; }
  2898. int get() const { return x; }
  2899. };
  2900. int plainCaller(const V& a) { return a.get(); }
  2901. V explicitCaller(const V& a, const V& b) { return a.operator+(b); }
  2902. V subscriptCaller(const V& a) { return a.operator[](3); }
  2903. V pointerCaller(const V* p, const V& b) { return p->operator+(b); }
  2904. `,
  2905. });
  2906. expect(callerNamesOf('V::operator+')).toEqual(['explicitCaller', 'pointerCaller']);
  2907. expect(callerNamesOf('V::operator[]')).toEqual(['subscriptCaller']);
  2908. expect(callerNamesOf('V::get')).toEqual(['plainCaller']); // control: plain calls unaffected
  2909. expect(callerNamesOf('Aaa::operator+')).toEqual([]);
  2910. expect(callerNamesOf('Aaa::operator[]')).toEqual([]);
  2911. });
  2912. it('resolves an out-of-line operator definition (declaration in header)', async () => {
  2913. await indexCpp({
  2914. 'v.hpp': `#pragma once
  2915. struct V { int x; V operator+(const V& o) const; };
  2916. `,
  2917. 'v.cpp': `#include "v.hpp"
  2918. V V::operator+(const V& o) const { return V{x + o.x}; }
  2919. `,
  2920. 'app.cpp': `#include "v.hpp"
  2921. V add(const V& a, const V& b) { return a.operator+(b); }
  2922. `,
  2923. });
  2924. expect(callerNamesOf('V::operator+')).toEqual(['add']);
  2925. });
  2926. });
  2927. describe('PHP chained static-factory call resolution (#608)', () => {
  2928. function callerNamesOf(qualifiedName: string): string[] {
  2929. const target = cg.getNodesByKind('method').find((n) => n.qualifiedName === qualifiedName);
  2930. if (!target) return [];
  2931. const names = cg
  2932. .getIncomingEdges(target.id)
  2933. .filter((e) => e.kind === 'calls')
  2934. .map((e) => cg.getNode(e.source)?.name)
  2935. .filter((n): n is string => !!n);
  2936. return [...new Set(names)].sort();
  2937. }
  2938. it('resolves Cls::for($x)->method() via the factory\'s `: self` return (#608)', async () => {
  2939. fs.writeFileSync(
  2940. path.join(tempDir, 'ApiClient.php'),
  2941. `<?php\nclass ApiClient {\n public static function for(string $c): self { return new self; }\n public function createOrder(array $p): array { return []; }\n}\n`
  2942. );
  2943. fs.writeFileSync(
  2944. path.join(tempDir, 'DispatchOrder.php'),
  2945. `<?php\nclass DispatchOrder {\n public function handle(): void {\n ApiClient::for('cred')->createOrder([]);\n }\n}\n`
  2946. );
  2947. cg = await CodeGraph.init(tempDir, { index: true });
  2948. // The chained call's edge attaches to the factory result's method.
  2949. expect(callerNamesOf('ApiClient::createOrder')).toContain('handle');
  2950. });
  2951. it('creates NO edge when the factory result lacks the method (#608)', async () => {
  2952. fs.writeFileSync(
  2953. path.join(tempDir, 'lib.php'),
  2954. `<?php\nclass ApiClient { public static function for(string $c): self { return new self; } }\nclass Other { public function onlyOther(): void {} }\nclass Caller { public function go(): void { ApiClient::for('x')->onlyOther(); } }\n`
  2955. );
  2956. cg = await CodeGraph.init(tempDir, { index: true });
  2957. // ApiClient has no onlyOther — must not mis-attach to the same-named Other::onlyOther.
  2958. expect(callerNamesOf('Other::onlyOther')).toEqual([]);
  2959. });
  2960. });
  2961. describe('Java chained static-factory call resolution (#645/#608 mechanism)', () => {
  2962. function callerNamesOf(qualifiedName: string): string[] {
  2963. const target = cg.getNodesByKind('method').find((n) => n.qualifiedName === qualifiedName);
  2964. if (!target) return [];
  2965. const names = cg
  2966. .getIncomingEdges(target.id)
  2967. .filter((e) => e.kind === 'calls')
  2968. .map((e) => cg.getNode(e.source)?.name)
  2969. .filter((n): n is string => !!n);
  2970. return [...new Set(names)].sort();
  2971. }
  2972. it('resolves Foo.getInstance().bar() via the factory return type, never a same-named decoy', async () => {
  2973. // Aaa sorts first and has a same-named bar() — it must never win the chain.
  2974. fs.writeFileSync(
  2975. path.join(tempDir, 'Main.java'),
  2976. `class Aaa { void bar() {} }
  2977. class Foo {
  2978. static Foo getInstance() { return new Foo(); }
  2979. void bar() {}
  2980. }
  2981. class Caller {
  2982. void run() { Foo.getInstance().bar(); }
  2983. }
  2984. `
  2985. );
  2986. cg = await CodeGraph.init(tempDir, { index: true });
  2987. expect(callerNamesOf('Foo::bar')).toEqual(['run']);
  2988. expect(callerNamesOf('Aaa::bar')).toEqual([]);
  2989. });
  2990. it('resolves a factory chain that passes arguments — Foo.create(cfg).build()', async () => {
  2991. // The factory call carries an argument; the extractor must normalize the
  2992. // receiver to empty parens (`Foo.create().build`) so the chain still splits.
  2993. fs.writeFileSync(
  2994. path.join(tempDir, 'Main.java'),
  2995. `class Config {}
  2996. class Foo {
  2997. static Foo create(Config c) { return new Foo(); }
  2998. void build() {}
  2999. }
  3000. class Caller {
  3001. void run() { Foo.create(new Config()).build(); }
  3002. }
  3003. `
  3004. );
  3005. cg = await CodeGraph.init(tempDir, { index: true });
  3006. expect(callerNamesOf('Foo::build')).toEqual(['run']);
  3007. });
  3008. it('creates NO edge when the factory return type lacks the method (silent miss, not a wrong edge)', async () => {
  3009. fs.writeFileSync(
  3010. path.join(tempDir, 'Main.java'),
  3011. `class Foo {
  3012. static Foo getInstance() { return new Foo(); }
  3013. }
  3014. class Other { void onlyOther() {} }
  3015. class Caller {
  3016. void run() { Foo.getInstance().onlyOther(); }
  3017. }
  3018. `
  3019. );
  3020. cg = await CodeGraph.init(tempDir, { index: true });
  3021. // Foo has no onlyOther() — must not mis-attach to the same-named Other::onlyOther.
  3022. expect(callerNamesOf('Other::onlyOther')).toEqual([]);
  3023. });
  3024. });
  3025. describe('Kotlin chained companion-factory call resolution (#645/#608 mechanism)', () => {
  3026. function callerNamesOf(qualifiedName: string): string[] {
  3027. const target = cg.getNodesByKind('method').find((n) => n.qualifiedName === qualifiedName);
  3028. if (!target) return [];
  3029. const names = cg
  3030. .getIncomingEdges(target.id)
  3031. .filter((e) => e.kind === 'calls')
  3032. .map((e) => cg.getNode(e.source)?.name)
  3033. .filter((n): n is string => !!n);
  3034. return [...new Set(names)].sort();
  3035. }
  3036. it('resolves Foo.getInstance().bar() via the companion return type, never a same-named decoy', async () => {
  3037. // Aaa sorts first and has a same-named bar() — without the chain fix Kotlin
  3038. // dropped the receiver to a bare `bar` and attached to Aaa (a wrong edge).
  3039. fs.writeFileSync(
  3040. path.join(tempDir, 'Main.kt'),
  3041. `class Aaa { fun bar() {} }
  3042. class Foo {
  3043. companion object {
  3044. fun getInstance(): Foo = Foo()
  3045. }
  3046. fun bar() {}
  3047. }
  3048. class Caller {
  3049. fun run() { Foo.getInstance().bar() }
  3050. }
  3051. `
  3052. );
  3053. cg = await CodeGraph.init(tempDir, { index: true });
  3054. expect(callerNamesOf('Foo::bar')).toEqual(['run']);
  3055. expect(callerNamesOf('Aaa::bar')).toEqual([]);
  3056. });
  3057. it('resolves a companion factory chain that passes arguments — Foo.create(cfg).build()', async () => {
  3058. fs.writeFileSync(
  3059. path.join(tempDir, 'Main.kt'),
  3060. `class Config
  3061. class Foo {
  3062. companion object {
  3063. fun create(c: Config): Foo = Foo()
  3064. }
  3065. fun build() {}
  3066. }
  3067. class Caller {
  3068. fun run() { Foo.create(Config()).build() }
  3069. }
  3070. `
  3071. );
  3072. cg = await CodeGraph.init(tempDir, { index: true });
  3073. expect(callerNamesOf('Foo::build')).toEqual(['run']);
  3074. });
  3075. it('creates NO edge when the companion return type lacks the method (silent miss, not a wrong edge)', async () => {
  3076. fs.writeFileSync(
  3077. path.join(tempDir, 'Main.kt'),
  3078. `class Foo {
  3079. companion object {
  3080. fun getInstance(): Foo = Foo()
  3081. }
  3082. }
  3083. class Other { fun onlyOther() {} }
  3084. class Caller {
  3085. fun run() { Foo.getInstance().onlyOther() }
  3086. }
  3087. `
  3088. );
  3089. cg = await CodeGraph.init(tempDir, { index: true });
  3090. // Foo has no onlyOther() — must not mis-attach to the same-named Other::onlyOther.
  3091. expect(callerNamesOf('Other::onlyOther')).toEqual([]);
  3092. });
  3093. });
  3094. describe('C# chained static-factory call resolution (#645/#608 mechanism)', () => {
  3095. function callerNamesOf(qualifiedName: string): string[] {
  3096. const target = cg.getNodesByKind('method').find((n) => n.qualifiedName === qualifiedName);
  3097. if (!target) return [];
  3098. const names = cg
  3099. .getIncomingEdges(target.id)
  3100. .filter((e) => e.kind === 'calls')
  3101. .map((e) => cg.getNode(e.source)?.name)
  3102. .filter((n): n is string => !!n);
  3103. return [...new Set(names)].sort();
  3104. }
  3105. it('resolves Foo.Create().Bar() via the factory return type, never a same-named decoy', async () => {
  3106. // Aaa sorts first and has a same-named Bar() — it must never win the chain.
  3107. fs.writeFileSync(
  3108. path.join(tempDir, 'Main.cs'),
  3109. `class Aaa { void Bar() {} }
  3110. class Foo {
  3111. static Foo Create() { return new Foo(); }
  3112. void Bar() {}
  3113. }
  3114. class Caller {
  3115. void Run() { Foo.Create().Bar(); }
  3116. }
  3117. `
  3118. );
  3119. cg = await CodeGraph.init(tempDir, { index: true });
  3120. expect(callerNamesOf('Foo::Bar')).toEqual(['Run']);
  3121. expect(callerNamesOf('Aaa::Bar')).toEqual([]);
  3122. });
  3123. it('resolves a factory chain that passes arguments — Foo.Make(cfg).Build()', async () => {
  3124. fs.writeFileSync(
  3125. path.join(tempDir, 'Main.cs'),
  3126. `class Config {}
  3127. class Foo {
  3128. static Foo Make(Config c) { return new Foo(); }
  3129. void Build() {}
  3130. }
  3131. class Caller {
  3132. void Run() { Foo.Make(new Config()).Build(); }
  3133. }
  3134. `
  3135. );
  3136. cg = await CodeGraph.init(tempDir, { index: true });
  3137. expect(callerNamesOf('Foo::Build')).toEqual(['Run']);
  3138. });
  3139. it('creates NO edge when the factory return type lacks the method (silent miss, not a wrong edge)', async () => {
  3140. fs.writeFileSync(
  3141. path.join(tempDir, 'Main.cs'),
  3142. `class Foo {
  3143. static Foo Create() { return new Foo(); }
  3144. }
  3145. class Other { void OnlyOther() {} }
  3146. class Caller {
  3147. void Run() { Foo.Create().OnlyOther(); }
  3148. }
  3149. `
  3150. );
  3151. cg = await CodeGraph.init(tempDir, { index: true });
  3152. // Foo has no OnlyOther() — must not mis-attach to the same-named Other::OnlyOther.
  3153. expect(callerNamesOf('Other::OnlyOther')).toEqual([]);
  3154. });
  3155. });
  3156. describe('Swift chained static-factory call resolution (#645/#608 mechanism)', () => {
  3157. function callerNamesOf(qualifiedName: string): string[] {
  3158. const target = cg.getNodesByKind('method').find((n) => n.qualifiedName === qualifiedName);
  3159. if (!target) return [];
  3160. const names = cg
  3161. .getIncomingEdges(target.id)
  3162. .filter((e) => e.kind === 'calls')
  3163. .map((e) => cg.getNode(e.source)?.name)
  3164. .filter((n): n is string => !!n);
  3165. return [...new Set(names)].sort();
  3166. }
  3167. it('resolves Foo.make().draw() via the factory return type, never a same-named decoy', async () => {
  3168. // Aaa sorts first and has a same-named draw() — without the fix Swift dropped
  3169. // the receiver to a bare `draw` and attached to Aaa (a wrong edge).
  3170. fs.writeFileSync(
  3171. path.join(tempDir, 'Main.swift'),
  3172. `class Aaa { func draw() {} }
  3173. class Foo {
  3174. static func make() -> Foo { return Foo() }
  3175. func draw() {}
  3176. }
  3177. func runCaller() { Foo.make().draw() }
  3178. `
  3179. );
  3180. cg = await CodeGraph.init(tempDir, { index: true });
  3181. expect(callerNamesOf('Foo::draw')).toEqual(['runCaller']);
  3182. expect(callerNamesOf('Aaa::draw')).toEqual([]);
  3183. });
  3184. it('resolves a constructor chain Foo().draw() and an args factory chain Foo.build(c).render()', async () => {
  3185. fs.writeFileSync(
  3186. path.join(tempDir, 'Main.swift'),
  3187. `class Config {}
  3188. class Foo {
  3189. static func build(_ c: Config) -> Foo { return Foo() }
  3190. func draw() {}
  3191. func render() {}
  3192. }
  3193. func runCaller() {
  3194. Foo().draw()
  3195. Foo.build(Config()).render()
  3196. }
  3197. `
  3198. );
  3199. cg = await CodeGraph.init(tempDir, { index: true });
  3200. expect(callerNamesOf('Foo::draw')).toEqual(['runCaller']);
  3201. expect(callerNamesOf('Foo::render')).toEqual(['runCaller']);
  3202. });
  3203. it('creates NO edge when the factory return type lacks the method (silent miss, not a wrong edge)', async () => {
  3204. fs.writeFileSync(
  3205. path.join(tempDir, 'Main.swift'),
  3206. `class Foo {
  3207. static func make() -> Foo { return Foo() }
  3208. }
  3209. class Other { func onlyOther() {} }
  3210. func runCaller() { Foo.make().onlyOther() }
  3211. `
  3212. );
  3213. cg = await CodeGraph.init(tempDir, { index: true });
  3214. // Foo has no onlyOther() — must not mis-attach to the same-named Other::onlyOther.
  3215. expect(callerNamesOf('Other::onlyOther')).toEqual([]);
  3216. });
  3217. });
  3218. describe('Chained call resolves a method on a supertype (conformance, #750)', () => {
  3219. function callerNamesOf(qualifiedName: string): string[] {
  3220. const target = cg.getNodesByKind('method').find((n) => n.qualifiedName === qualifiedName);
  3221. if (!target) return [];
  3222. const names = cg
  3223. .getIncomingEdges(target.id)
  3224. .filter((e) => e.kind === 'calls')
  3225. .map((e) => cg.getNode(e.source)?.name)
  3226. .filter((n): n is string => !!n);
  3227. return [...new Set(names)].sort();
  3228. }
  3229. it('resolves a chained method defined only on a SUPERCLASS the return type extends', async () => {
  3230. // draw() lives on Base; Widget (the factory's return type) has no draw() of
  3231. // its own. Decoy.draw must never win. Needs the conformance second pass.
  3232. fs.writeFileSync(
  3233. path.join(tempDir, 'Main.java'),
  3234. `class Base { void draw() {} }
  3235. class Widget extends Base {}
  3236. class Decoy { void draw() {} }
  3237. class Factory { static Widget create() { return new Widget(); } }
  3238. class Caller {
  3239. void run() { Factory.create().draw(); }
  3240. }
  3241. `
  3242. );
  3243. cg = await CodeGraph.init(tempDir, { index: true });
  3244. expect(callerNamesOf('Base::draw')).toEqual(['run']);
  3245. expect(callerNamesOf('Decoy::draw')).toEqual([]);
  3246. });
  3247. it('resolves a chained method defined on an INTERFACE the return type implements (default method)', async () => {
  3248. fs.writeFileSync(
  3249. path.join(tempDir, 'Main.java'),
  3250. `interface Drawable { default void draw() {} }
  3251. class Widget implements Drawable {}
  3252. class Decoy { void draw() {} }
  3253. class Factory { static Widget create() { return new Widget(); } }
  3254. class Caller {
  3255. void run() { Factory.create().draw(); }
  3256. }
  3257. `
  3258. );
  3259. cg = await CodeGraph.init(tempDir, { index: true });
  3260. expect(callerNamesOf('Drawable::draw')).toEqual(['run']);
  3261. expect(callerNamesOf('Decoy::draw')).toEqual([]);
  3262. });
  3263. it('still creates NO edge when no supertype has the method (safety preserved)', async () => {
  3264. fs.writeFileSync(
  3265. path.join(tempDir, 'Main.java'),
  3266. `class Base {}
  3267. class Widget extends Base {}
  3268. class Other { void onlyOther() {} }
  3269. class Factory { static Widget create() { return new Widget(); } }
  3270. class Caller {
  3271. void run() { Factory.create().onlyOther(); }
  3272. }
  3273. `
  3274. );
  3275. cg = await CodeGraph.init(tempDir, { index: true });
  3276. // Neither Widget nor Base has onlyOther() — must not attach to Other::onlyOther.
  3277. expect(callerNamesOf('Other::onlyOther')).toEqual([]);
  3278. });
  3279. });
  3280. describe('Rust chained associated-function call resolution (#645/#608 mechanism)', () => {
  3281. function callerNamesOf(qualifiedName: string): string[] {
  3282. const target = cg.getNodesByKind('method').find((n) => n.qualifiedName === qualifiedName);
  3283. if (!target) return [];
  3284. const names = cg
  3285. .getIncomingEdges(target.id)
  3286. .filter((e) => e.kind === 'calls')
  3287. .map((e) => cg.getNode(e.source)?.name)
  3288. .filter((n): n is string => !!n);
  3289. return [...new Set(names)].sort();
  3290. }
  3291. it('resolves Foo::new().bar() (and a Self return) via the associated fn, never a same-named decoy', async () => {
  3292. fs.writeFileSync(
  3293. path.join(tempDir, 'main.rs'),
  3294. `struct Aaa { _x: i32 }
  3295. impl Aaa { fn bar(&self) {} }
  3296. struct Foo { _x: i32 }
  3297. impl Foo {
  3298. fn new() -> Foo { Foo { _x: 0 } }
  3299. fn make() -> Self { Foo { _x: 0 } }
  3300. fn bar(&self) {}
  3301. }
  3302. fn caller() {
  3303. Foo::new().bar();
  3304. Foo::make().bar();
  3305. }
  3306. `
  3307. );
  3308. cg = await CodeGraph.init(tempDir, { index: true });
  3309. expect(callerNamesOf('Foo::bar')).toEqual(['caller']);
  3310. expect(callerNamesOf('Aaa::bar')).toEqual([]);
  3311. });
  3312. it('resolves a chain that passes arguments — Foo::with(c).build()', async () => {
  3313. fs.writeFileSync(
  3314. path.join(tempDir, 'main.rs'),
  3315. `struct Config;
  3316. struct Foo { _x: i32 }
  3317. impl Foo {
  3318. fn with(c: Config) -> Foo { Foo { _x: 0 } }
  3319. fn build(&self) {}
  3320. }
  3321. fn caller() { Foo::with(Config).build(); }
  3322. `
  3323. );
  3324. cg = await CodeGraph.init(tempDir, { index: true });
  3325. expect(callerNamesOf('Foo::build')).toEqual(['caller']);
  3326. });
  3327. it('resolves a chained method from a trait the type implements (default method, via conformance)', async () => {
  3328. fs.writeFileSync(
  3329. path.join(tempDir, 'main.rs'),
  3330. `struct Foo { _x: i32 }
  3331. impl Foo { fn new() -> Foo { Foo { _x: 0 } } }
  3332. struct Decoy { _x: i32 }
  3333. impl Decoy { fn draw(&self) {} }
  3334. trait Drawable { fn draw(&self) {} }
  3335. impl Drawable for Foo {}
  3336. fn caller() { Foo::new().draw(); }
  3337. `
  3338. );
  3339. cg = await CodeGraph.init(tempDir, { index: true });
  3340. expect(callerNamesOf('Drawable::draw')).toEqual(['caller']);
  3341. expect(callerNamesOf('Decoy::draw')).toEqual([]);
  3342. });
  3343. it('creates NO edge when neither the type nor a supertype has the method (silent miss)', async () => {
  3344. fs.writeFileSync(
  3345. path.join(tempDir, 'main.rs'),
  3346. `struct Foo { _x: i32 }
  3347. impl Foo { fn new() -> Foo { Foo { _x: 0 } } }
  3348. struct Other { _x: i32 }
  3349. impl Other { fn only_other(&self) {} }
  3350. fn caller() { Foo::new().only_other(); }
  3351. `
  3352. );
  3353. cg = await CodeGraph.init(tempDir, { index: true });
  3354. // Foo has no only_other() — must not mis-attach to the same-named Other::only_other.
  3355. expect(callerNamesOf('Other::only_other')).toEqual([]);
  3356. });
  3357. });
  3358. describe('Go chained factory-function call resolution (#645/#608 mechanism)', () => {
  3359. function callerNamesOf(qualifiedName: string): string[] {
  3360. const target = cg.getNodesByKind('method').find((n) => n.qualifiedName === qualifiedName);
  3361. if (!target) return [];
  3362. const names = cg
  3363. .getIncomingEdges(target.id)
  3364. .filter((e) => e.kind === 'calls')
  3365. .map((e) => cg.getNode(e.source)?.name)
  3366. .filter((n): n is string => !!n);
  3367. return [...new Set(names)].sort();
  3368. }
  3369. it('resolves New().Bar() via the factory return type (pointer), never a same-named decoy', async () => {
  3370. fs.writeFileSync(
  3371. path.join(tempDir, 'main.go'),
  3372. `package main
  3373. type Aaa struct{}
  3374. func (a *Aaa) Bar() {}
  3375. type Foo struct{}
  3376. func New() *Foo { return &Foo{} }
  3377. func (f *Foo) Bar() {}
  3378. func caller() { New().Bar() }
  3379. `
  3380. );
  3381. cg = await CodeGraph.init(tempDir, { index: true });
  3382. expect(callerNamesOf('Foo::Bar')).toEqual(['caller']);
  3383. expect(callerNamesOf('Aaa::Bar')).toEqual([]);
  3384. });
  3385. it('resolves an args chain and a multi-return factory — With(c).Build(), (*Foo, error)', async () => {
  3386. fs.writeFileSync(
  3387. path.join(tempDir, 'main.go'),
  3388. `package main
  3389. type Config struct{}
  3390. type Foo struct{}
  3391. func With(c Config) (*Foo, error) { return &Foo{}, nil }
  3392. func (f *Foo) Build() {}
  3393. func caller() { With(Config{}).Build() }
  3394. `
  3395. );
  3396. cg = await CodeGraph.init(tempDir, { index: true });
  3397. expect(callerNamesOf('Foo::Build')).toEqual(['caller']);
  3398. });
  3399. it('resolves a method provided by an embedded struct (via conformance)', async () => {
  3400. fs.writeFileSync(
  3401. path.join(tempDir, 'main.go'),
  3402. `package main
  3403. type Base struct{}
  3404. func (b *Base) Embedded() {}
  3405. type Decoy struct{}
  3406. func (d *Decoy) Embedded() {}
  3407. type Widget struct{ Base }
  3408. func NewWidget() *Widget { return &Widget{} }
  3409. func caller() { NewWidget().Embedded() }
  3410. `
  3411. );
  3412. cg = await CodeGraph.init(tempDir, { index: true });
  3413. expect(callerNamesOf('Base::Embedded')).toEqual(['caller']);
  3414. expect(callerNamesOf('Decoy::Embedded')).toEqual([]);
  3415. });
  3416. it('creates NO edge when neither the type nor an embedded type has the method (silent miss)', async () => {
  3417. fs.writeFileSync(
  3418. path.join(tempDir, 'main.go'),
  3419. `package main
  3420. type Foo struct{}
  3421. func New() *Foo { return &Foo{} }
  3422. type Other struct{}
  3423. func (o *Other) OnlyOther() {}
  3424. func caller() { New().OnlyOther() }
  3425. `
  3426. );
  3427. cg = await CodeGraph.init(tempDir, { index: true });
  3428. // Foo has no OnlyOther() — must not mis-attach to the same-named Other::OnlyOther.
  3429. expect(callerNamesOf('Other::OnlyOther')).toEqual([]);
  3430. });
  3431. it('falls back to bare-name resolution for a VARIABLE-inner chain without exploding the graph', async () => {
  3432. // `engine` is a package-level VARIABLE holding a func value, not a factory
  3433. // FUNCTION — so its return type can't be recovered and the chain falls back
  3434. // to bare-name resolution of the method (restoring the pre-re-encoding edge).
  3435. // Regression for the runaway this fallback originally caused: it resolved
  3436. // with a mutated `original.referenceName` (the bare `ServeHTTP`, not the
  3437. // stored `engine().ServeHTTP`), so the batched resolver's keyed delete
  3438. // no-oped, the offset-0 batch never drained, and edges inserted forever
  3439. // (5M edges / 1.4 GB on a 99-file repo). The fallback now ties the match to
  3440. // the original ref, and a non-progress guard backstops the loop.
  3441. fs.writeFileSync(
  3442. path.join(tempDir, 'main.go'),
  3443. `package main
  3444. type Server struct{}
  3445. func (s *Server) ServeHTTP() {}
  3446. var engine = func() *Server { return &Server{} }
  3447. func caller() { engine().ServeHTTP() }
  3448. `
  3449. );
  3450. cg = await CodeGraph.init(tempDir, { index: true });
  3451. // Recall: the variable-inner chain still finds the method by bare name.
  3452. expect(callerNamesOf('Server::ServeHTTP')).toEqual(['caller']);
  3453. // No runaway: a single call site yields a single edge, not millions.
  3454. const target = cg
  3455. .getNodesByKind('method')
  3456. .find((n) => n.qualifiedName === 'Server::ServeHTTP')!;
  3457. const rawCalls = cg
  3458. .getIncomingEdges(target.id)
  3459. .filter((e) => e.kind === 'calls');
  3460. expect(rawCalls.length).toBeLessThan(5);
  3461. });
  3462. });
  3463. describe('Scala chained static-factory call resolution (#645/#608 mechanism)', () => {
  3464. function callerNamesOf(qualifiedName: string): string[] {
  3465. const target = cg.getNodesByKind('method').find((n) => n.qualifiedName === qualifiedName);
  3466. if (!target) return [];
  3467. const names = cg
  3468. .getIncomingEdges(target.id)
  3469. .filter((e) => e.kind === 'calls')
  3470. .map((e) => cg.getNode(e.source)?.name)
  3471. .filter((n): n is string => !!n);
  3472. return [...new Set(names)].sort();
  3473. }
  3474. it('resolves a companion-factory chain Foo.create().doIt() to the return type, never a same-named decoy', async () => {
  3475. fs.writeFileSync(
  3476. path.join(tempDir, 'Main.scala'),
  3477. `object Foo {
  3478. def create(): Bar = new Bar()
  3479. }
  3480. class Bar {
  3481. def doIt(): Unit = {}
  3482. }
  3483. class Decoy {
  3484. def doIt(): Unit = {}
  3485. }
  3486. object Main {
  3487. def run(): Unit = { Foo.create().doIt() }
  3488. }
  3489. `
  3490. );
  3491. cg = await CodeGraph.init(tempDir, { index: true });
  3492. expect(callerNamesOf('Bar::doIt')).toEqual(['run']);
  3493. expect(callerNamesOf('Decoy::doIt')).toEqual([]);
  3494. });
  3495. it('resolves a case-class apply construction Point(x).dist() on the constructed class', async () => {
  3496. fs.writeFileSync(
  3497. path.join(tempDir, 'Main.scala'),
  3498. `class Point(x: Int) {
  3499. def dist(): Int = x
  3500. }
  3501. class Other {
  3502. def dist(): Int = 0
  3503. }
  3504. object Main {
  3505. def run(): Unit = { Point(3).dist() }
  3506. }
  3507. `
  3508. );
  3509. cg = await CodeGraph.init(tempDir, { index: true });
  3510. expect(callerNamesOf('Point::dist')).toEqual(['run']);
  3511. expect(callerNamesOf('Other::dist')).toEqual([]);
  3512. });
  3513. it('resolves a chained method provided by a trait the return type extends (via conformance)', async () => {
  3514. fs.writeFileSync(
  3515. path.join(tempDir, 'Main.scala'),
  3516. `trait Base {
  3517. def shared(): Unit = {}
  3518. }
  3519. class Widget extends Base
  3520. class Decoy {
  3521. def shared(): Unit = {}
  3522. }
  3523. object Factory {
  3524. def make(): Widget = new Widget()
  3525. }
  3526. object Main {
  3527. def run(): Unit = { Factory.make().shared() }
  3528. }
  3529. `
  3530. );
  3531. cg = await CodeGraph.init(tempDir, { index: true });
  3532. expect(callerNamesOf('Base::shared')).toEqual(['run']);
  3533. expect(callerNamesOf('Decoy::shared')).toEqual([]);
  3534. });
  3535. it('creates NO edge when neither the factory return type nor a supertype has the method (silent miss)', async () => {
  3536. fs.writeFileSync(
  3537. path.join(tempDir, 'Main.scala'),
  3538. `object Foo {
  3539. def create(): Bar = new Bar()
  3540. }
  3541. class Bar {
  3542. }
  3543. class Other {
  3544. def onlyOther(): Unit = {}
  3545. }
  3546. object Main {
  3547. def run(): Unit = { Foo.create().onlyOther() }
  3548. }
  3549. `
  3550. );
  3551. cg = await CodeGraph.init(tempDir, { index: true });
  3552. // Bar has no onlyOther() — must not mis-attach to the same-named Other::onlyOther.
  3553. expect(callerNamesOf('Other::onlyOther')).toEqual([]);
  3554. });
  3555. });
  3556. describe('Dart chained static-factory / factory-constructor call resolution (#645/#608 mechanism)', () => {
  3557. function callerNamesOf(qualifiedName: string): string[] {
  3558. const target = cg.getNodesByKind('method').find((n) => n.qualifiedName === qualifiedName);
  3559. if (!target) return [];
  3560. const names = cg
  3561. .getIncomingEdges(target.id)
  3562. .filter((e) => e.kind === 'calls')
  3563. .map((e) => cg.getNode(e.source)?.name)
  3564. .filter((n): n is string => !!n);
  3565. return [...new Set(names)].sort();
  3566. }
  3567. it('resolves a static-factory chain Foo.makeBar().doIt() to the return type, never a same-named decoy', async () => {
  3568. fs.writeFileSync(
  3569. path.join(tempDir, 'main.dart'),
  3570. `class Foo {
  3571. static Bar makeBar() => Bar();
  3572. }
  3573. class Bar {
  3574. void doIt() {}
  3575. }
  3576. class Decoy {
  3577. void doIt() {}
  3578. }
  3579. void run() {
  3580. Foo.makeBar().doIt();
  3581. }
  3582. `
  3583. );
  3584. cg = await CodeGraph.init(tempDir, { index: true });
  3585. expect(callerNamesOf('Bar::doIt')).toEqual(['run']);
  3586. expect(callerNamesOf('Decoy::doIt')).toEqual([]);
  3587. });
  3588. it('resolves a named factory-constructor chain Foo.create().ship() on the constructed class', async () => {
  3589. fs.writeFileSync(
  3590. path.join(tempDir, 'main.dart'),
  3591. `class Foo {
  3592. Foo._();
  3593. factory Foo.create() => Foo._();
  3594. void ship() {}
  3595. }
  3596. class Decoy {
  3597. void ship() {}
  3598. }
  3599. void run() {
  3600. Foo.create().ship();
  3601. }
  3602. `
  3603. );
  3604. cg = await CodeGraph.init(tempDir, { index: true });
  3605. // The factory constructor `Foo.create` is now a node whose return type is Foo,
  3606. // so `ship` resolves on Foo, not the same-named Decoy.
  3607. expect(callerNamesOf('Foo::ship')).toEqual(['run']);
  3608. expect(callerNamesOf('Decoy::ship')).toEqual([]);
  3609. });
  3610. it('resolves a constructor-receiver chain Bar().doIt() on the constructed class', async () => {
  3611. fs.writeFileSync(
  3612. path.join(tempDir, 'main.dart'),
  3613. `class Bar {
  3614. void doIt() {}
  3615. }
  3616. class Decoy {
  3617. void doIt() {}
  3618. }
  3619. void run() {
  3620. Bar().doIt();
  3621. }
  3622. `
  3623. );
  3624. cg = await CodeGraph.init(tempDir, { index: true });
  3625. expect(callerNamesOf('Bar::doIt')).toEqual(['run']);
  3626. expect(callerNamesOf('Decoy::doIt')).toEqual([]);
  3627. });
  3628. it('resolves a chained method inherited from a superclass the return type extends (via conformance)', async () => {
  3629. fs.writeFileSync(
  3630. path.join(tempDir, 'main.dart'),
  3631. `class Base {
  3632. void render() {}
  3633. }
  3634. class Widget extends Base {
  3635. static Widget make() => Widget();
  3636. }
  3637. class Decoy {
  3638. void render() {}
  3639. }
  3640. void run() {
  3641. Widget.make().render();
  3642. }
  3643. `
  3644. );
  3645. cg = await CodeGraph.init(tempDir, { index: true });
  3646. expect(callerNamesOf('Base::render')).toEqual(['run']);
  3647. expect(callerNamesOf('Decoy::render')).toEqual([]);
  3648. });
  3649. it('creates NO edge when neither the factory return type nor a supertype has the method (silent miss)', async () => {
  3650. fs.writeFileSync(
  3651. path.join(tempDir, 'main.dart'),
  3652. `class Foo {
  3653. static Bar makeBar() => Bar();
  3654. }
  3655. class Bar {
  3656. }
  3657. class Other {
  3658. void onlyOther() {}
  3659. }
  3660. void run() {
  3661. Foo.makeBar().onlyOther();
  3662. }
  3663. `
  3664. );
  3665. cg = await CodeGraph.init(tempDir, { index: true });
  3666. // Bar has no onlyOther() — must not mis-attach to the same-named Other::onlyOther.
  3667. expect(callerNamesOf('Other::onlyOther')).toEqual([]);
  3668. });
  3669. it('still extracts a method tree-sitter misparses as a constructor (@override + record return)', async () => {
  3670. // tree-sitter-dart misparses `@override (A, B) reduce()` — the annotation
  3671. // swallows the record return type, so `reduce()` looks like a single-
  3672. // identifier constructor_signature. It must NOT be skipped as an unnamed
  3673. // ctor (its name doesn't match the class); its body call must attribute to
  3674. // `reduce`, not the class.
  3675. fs.writeFileSync(
  3676. path.join(tempDir, 'main.dart'),
  3677. `class Base {}
  3678. class Action extends Base {
  3679. Action({required int x});
  3680. @override
  3681. (int, String) reduce() {
  3682. return (compute(), "y");
  3683. }
  3684. int compute() => 1;
  3685. }
  3686. `
  3687. );
  3688. cg = await CodeGraph.init(tempDir, { index: true });
  3689. // reduce must be a node and its body call must resolve to Action::compute.
  3690. expect(callerNamesOf('Action::compute')).toEqual(['reduce']);
  3691. });
  3692. it('keeps plain construction Foo() as instantiation, not a Foo::Foo method call', async () => {
  3693. // The unnamed constructor is intentionally NOT extracted as a `Foo::Foo`
  3694. // method, so `Foo(...)` resolves to the class (an `instantiates` edge),
  3695. // never hijacked into a call to a phantom constructor method.
  3696. fs.writeFileSync(
  3697. path.join(tempDir, 'main.dart'),
  3698. `class Widget {
  3699. final int x;
  3700. Widget(this.x);
  3701. }
  3702. void run() {
  3703. Widget(3);
  3704. }
  3705. `
  3706. );
  3707. cg = await CodeGraph.init(tempDir, { index: true });
  3708. // No Foo::Foo phantom method node.
  3709. expect(cg.getNodesByKind('method').some((n) => n.qualifiedName === 'Widget::Widget')).toBe(false);
  3710. // The construction resolves to the class as an `instantiates` edge.
  3711. const widget = cg.getNodesByKind('class').find((n) => n.name === 'Widget')!;
  3712. const incoming = cg.getIncomingEdges(widget.id);
  3713. expect(incoming.some((e) => e.kind === 'instantiates')).toBe(true);
  3714. });
  3715. });
  3716. describe('Objective-C chained message-send call resolution (#645/#608 mechanism)', () => {
  3717. function callerNamesOf(qualifiedName: string): string[] {
  3718. const target = cg.getNodesByKind('method').find((n) => n.qualifiedName === qualifiedName);
  3719. if (!target) return [];
  3720. const names = cg
  3721. .getIncomingEdges(target.id)
  3722. .filter((e) => e.kind === 'calls')
  3723. .map((e) => cg.getNode(e.source)?.name)
  3724. .filter((n): n is string => !!n);
  3725. return [...new Set(names)].sort();
  3726. }
  3727. it('resolves a chained message send [[Foo create] doIt] via the return type, never a same-named decoy', async () => {
  3728. fs.writeFileSync(
  3729. path.join(tempDir, 'main.m'),
  3730. `@interface Bar : NSObject
  3731. - (void)doIt;
  3732. @end
  3733. @implementation Bar
  3734. - (void)doIt {}
  3735. @end
  3736. @interface Decoy : NSObject
  3737. - (void)doIt;
  3738. @end
  3739. @implementation Decoy
  3740. - (void)doIt {}
  3741. @end
  3742. @interface Foo : NSObject
  3743. + (Bar *)create;
  3744. @end
  3745. @implementation Foo
  3746. + (Bar *)create { return nil; }
  3747. - (void)run { [[Foo create] doIt]; }
  3748. @end
  3749. `
  3750. );
  3751. cg = await CodeGraph.init(tempDir, { index: true });
  3752. expect(callerNamesOf('Bar::doIt')).toEqual(['run']);
  3753. expect(callerNamesOf('Decoy::doIt')).toEqual([]);
  3754. });
  3755. it('resolves a chained message whose method is inherited from a superclass (via conformance)', async () => {
  3756. fs.writeFileSync(
  3757. path.join(tempDir, 'main.m'),
  3758. `@interface Base : NSObject
  3759. - (void)render;
  3760. @end
  3761. @implementation Base
  3762. - (void)render {}
  3763. @end
  3764. @interface Widget : Base
  3765. @end
  3766. @implementation Widget
  3767. @end
  3768. @interface Decoy : NSObject
  3769. - (void)render;
  3770. @end
  3771. @implementation Decoy
  3772. - (void)render {}
  3773. @end
  3774. @interface Factory : NSObject
  3775. + (Widget *)make;
  3776. @end
  3777. @implementation Factory
  3778. + (Widget *)make { return nil; }
  3779. - (void)run { [[Factory make] render]; }
  3780. @end
  3781. `
  3782. );
  3783. cg = await CodeGraph.init(tempDir, { index: true });
  3784. expect(callerNamesOf('Base::render')).toEqual(['run']);
  3785. expect(callerNamesOf('Decoy::render')).toEqual([]);
  3786. });
  3787. it('creates NO edge when the factory return type lacks the method (silent miss)', async () => {
  3788. fs.writeFileSync(
  3789. path.join(tempDir, 'main.m'),
  3790. `@interface Bar : NSObject
  3791. @end
  3792. @implementation Bar
  3793. @end
  3794. @interface Other : NSObject
  3795. - (void)onlyOther;
  3796. @end
  3797. @implementation Other
  3798. - (void)onlyOther {}
  3799. @end
  3800. @interface Foo : NSObject
  3801. + (Bar *)create;
  3802. @end
  3803. @implementation Foo
  3804. + (Bar *)create { return nil; }
  3805. - (void)run { [[Foo create] onlyOther]; }
  3806. @end
  3807. `
  3808. );
  3809. cg = await CodeGraph.init(tempDir, { index: true });
  3810. // Bar has no onlyOther — must not mis-attach to the same-named Other::onlyOther.
  3811. expect(callerNamesOf('Other::onlyOther')).toEqual([]);
  3812. });
  3813. it('resolves a singleton chain [[Cache shared] clearAll] whose factory returns nonnull instancetype', async () => {
  3814. // The factory returns `nonnull instancetype` — the nullability qualifier must
  3815. // be skipped (not captured AS the type), and an instancetype class-message
  3816. // factory returns the receiver class, so clearAll resolves on Cache, never a
  3817. // same-named decoy. (Regression for both: the captured-`nonnull` bug and the
  3818. // ubiquitous `[[X alloc] init]` / singleton pattern.)
  3819. fs.writeFileSync(
  3820. path.join(tempDir, 'main.m'),
  3821. `@interface Cache : NSObject
  3822. + (nonnull instancetype)shared;
  3823. - (void)clearAll;
  3824. @end
  3825. @implementation Cache
  3826. + (nonnull instancetype)shared { return nil; }
  3827. - (void)clearAll {}
  3828. @end
  3829. @interface Decoy : NSObject
  3830. - (void)clearAll;
  3831. @end
  3832. @implementation Decoy
  3833. - (void)clearAll {}
  3834. @end
  3835. @interface Caller : NSObject
  3836. - (void)run;
  3837. @end
  3838. @implementation Caller
  3839. - (void)run { [[Cache shared] clearAll]; }
  3840. @end
  3841. `
  3842. );
  3843. cg = await CodeGraph.init(tempDir, { index: true });
  3844. expect(callerNamesOf('Cache::clearAll')).toEqual(['run']);
  3845. expect(callerNamesOf('Decoy::clearAll')).toEqual([]);
  3846. });
  3847. });
  3848. describe('Pascal/Delphi chained static-factory call resolution (#645/#608 mechanism)', () => {
  3849. function callerNamesOf(qualifiedName: string): string[] {
  3850. const target = cg.getNodesByKind('method').find((n) => n.qualifiedName === qualifiedName);
  3851. if (!target) return [];
  3852. const names = cg
  3853. .getIncomingEdges(target.id)
  3854. .filter((e) => e.kind === 'calls')
  3855. .map((e) => cg.getNode(e.source)?.name)
  3856. .filter((n): n is string => !!n);
  3857. return [...new Set(names)].sort();
  3858. }
  3859. function isCalled(qn: string): boolean {
  3860. const t = cg.getNodesByKind('method').find((n) => n.qualifiedName === qn);
  3861. return !!t && cg.getIncomingEdges(t.id).some((e) => e.kind === 'calls');
  3862. }
  3863. it('resolves a chained factory call TFoo.GetInstance().DoIt() via the return type, never a same-named decoy', async () => {
  3864. fs.writeFileSync(
  3865. path.join(tempDir, 'main.pas'),
  3866. `unit Main;
  3867. interface
  3868. type
  3869. TBar = class
  3870. procedure DoIt;
  3871. end;
  3872. TDecoy = class
  3873. procedure DoIt;
  3874. end;
  3875. TFoo = class
  3876. class function GetInstance: TBar;
  3877. end;
  3878. implementation
  3879. procedure TBar.DoIt; begin end;
  3880. procedure TDecoy.DoIt; begin end;
  3881. class function TFoo.GetInstance: TBar; begin Result := nil; end;
  3882. procedure Run;
  3883. begin
  3884. TFoo.GetInstance().DoIt();
  3885. end;
  3886. end.
  3887. `
  3888. );
  3889. cg = await CodeGraph.init(tempDir, { index: true });
  3890. expect(isCalled('TBar::DoIt')).toBe(true);
  3891. expect(isCalled('TDecoy::DoIt')).toBe(false);
  3892. });
  3893. it('resolves a constructor chain TFoo.Create().Configure() on the constructed class', async () => {
  3894. fs.writeFileSync(
  3895. path.join(tempDir, 'main.pas'),
  3896. `unit Main;
  3897. interface
  3898. type
  3899. TFoo = class
  3900. constructor Create;
  3901. procedure Configure;
  3902. end;
  3903. TDecoy = class
  3904. procedure Configure;
  3905. end;
  3906. implementation
  3907. constructor TFoo.Create; begin end;
  3908. procedure TFoo.Configure; begin end;
  3909. procedure TDecoy.Configure; begin end;
  3910. procedure Run;
  3911. begin
  3912. TFoo.Create().Configure();
  3913. end;
  3914. end.
  3915. `
  3916. );
  3917. cg = await CodeGraph.init(tempDir, { index: true });
  3918. // A constructor returns its own class (no `: TBar` annotation), so Configure
  3919. // resolves on TFoo, not the same-named decoy.
  3920. expect(isCalled('TFoo::Configure')).toBe(true);
  3921. expect(isCalled('TDecoy::Configure')).toBe(false);
  3922. });
  3923. it('resolves a typecast chain TFoo(x).DoIt() on the cast type', async () => {
  3924. fs.writeFileSync(
  3925. path.join(tempDir, 'main.pas'),
  3926. `unit Main;
  3927. interface
  3928. type
  3929. TFoo = class
  3930. procedure DoIt;
  3931. end;
  3932. TDecoy = class
  3933. procedure DoIt;
  3934. end;
  3935. implementation
  3936. procedure TFoo.DoIt; begin end;
  3937. procedure TDecoy.DoIt; begin end;
  3938. procedure Run(obj: TObject);
  3939. begin
  3940. TFoo(obj).DoIt();
  3941. end;
  3942. end.
  3943. `
  3944. );
  3945. cg = await CodeGraph.init(tempDir, { index: true });
  3946. expect(isCalled('TFoo::DoIt')).toBe(true);
  3947. expect(isCalled('TDecoy::DoIt')).toBe(false);
  3948. });
  3949. it('creates NO edge when the factory return type lacks the method (silent miss)', async () => {
  3950. fs.writeFileSync(
  3951. path.join(tempDir, 'main.pas'),
  3952. `unit Main;
  3953. interface
  3954. type
  3955. TBar = class
  3956. end;
  3957. TOther = class
  3958. procedure OnlyOther;
  3959. end;
  3960. TFoo = class
  3961. class function GetInstance: TBar;
  3962. end;
  3963. implementation
  3964. procedure TOther.OnlyOther; begin end;
  3965. class function TFoo.GetInstance: TBar; begin Result := nil; end;
  3966. procedure Run;
  3967. begin
  3968. TFoo.GetInstance().OnlyOther();
  3969. end;
  3970. end.
  3971. `
  3972. );
  3973. cg = await CodeGraph.init(tempDir, { index: true });
  3974. // TBar has no OnlyOther — must not mis-attach to the same-named TOther::OnlyOther.
  3975. expect(isCalled('TOther::OnlyOther')).toBe(false);
  3976. });
  3977. it('extracts paren-less method calls (Pascal lets a no-arg method drop its parens)', async () => {
  3978. fs.writeFileSync(
  3979. path.join(tempDir, 'main.pas'),
  3980. `unit Main;
  3981. interface
  3982. type
  3983. TFoo = class
  3984. procedure DoThing;
  3985. procedure Reset;
  3986. end;
  3987. implementation
  3988. procedure TFoo.DoThing; begin end;
  3989. procedure TFoo.Reset; begin end;
  3990. procedure Run(f: TFoo);
  3991. begin
  3992. f.DoThing;
  3993. f.Reset;
  3994. end;
  3995. end.
  3996. `
  3997. );
  3998. cg = await CodeGraph.init(tempDir, { index: true });
  3999. expect(isCalled('TFoo::DoThing')).toBe(true);
  4000. expect(isCalled('TFoo::Reset')).toBe(true);
  4001. });
  4002. it('resolves a PAREN-LESS chained factory call TFoo.GetInstance.DoIt via the return type', async () => {
  4003. fs.writeFileSync(
  4004. path.join(tempDir, 'main.pas'),
  4005. `unit Main;
  4006. interface
  4007. type
  4008. TBar = class
  4009. procedure DoIt;
  4010. end;
  4011. TDecoy = class
  4012. procedure DoIt;
  4013. end;
  4014. TFoo = class
  4015. class function GetInstance: TBar;
  4016. end;
  4017. implementation
  4018. procedure TBar.DoIt; begin end;
  4019. procedure TDecoy.DoIt; begin end;
  4020. class function TFoo.GetInstance: TBar; begin Result := nil; end;
  4021. procedure Run;
  4022. begin
  4023. TFoo.GetInstance.DoIt;
  4024. end;
  4025. end.
  4026. `
  4027. );
  4028. cg = await CodeGraph.init(tempDir, { index: true });
  4029. expect(isCalled('TBar::DoIt')).toBe(true);
  4030. expect(isCalled('TDecoy::DoIt')).toBe(false);
  4031. });
  4032. it('does NOT turn a property write/read into a call edge (only statement-level dots are calls)', async () => {
  4033. fs.writeFileSync(
  4034. path.join(tempDir, 'main.pas'),
  4035. `unit Main;
  4036. interface
  4037. type
  4038. TFoo = class
  4039. function GetValue: Integer;
  4040. procedure SetValue(v: Integer);
  4041. property Value: Integer read GetValue write SetValue;
  4042. end;
  4043. implementation
  4044. function TFoo.GetValue: Integer; begin Result := 0; end;
  4045. procedure TFoo.SetValue(v: Integer); begin end;
  4046. procedure Run(f: TFoo);
  4047. var x: Integer;
  4048. begin
  4049. f.Value := 5;
  4050. x := f.Value;
  4051. end;
  4052. end.
  4053. `
  4054. );
  4055. cg = await CodeGraph.init(tempDir, { index: true });
  4056. // A property read/write is a bare dot in assignment position, not a statement,
  4057. // so it must not be mis-extracted as a call to the property's getter/setter.
  4058. expect(isCalled('TFoo::GetValue')).toBe(false);
  4059. expect(isCalled('TFoo::SetValue')).toBe(false);
  4060. });
  4061. it('attributes an implementation-only free procedure\'s calls to the procedure, not the file', async () => {
  4062. fs.writeFileSync(
  4063. path.join(tempDir, 'main.pas'),
  4064. `unit Main;
  4065. interface
  4066. type
  4067. TTgt = class
  4068. procedure Hit;
  4069. end;
  4070. TFoo = class
  4071. procedure DoStuff;
  4072. end;
  4073. implementation
  4074. procedure TTgt.Hit; begin end;
  4075. procedure TFoo.DoStuff; var t: TTgt; begin t.Hit; end;
  4076. procedure Helper; var t: TTgt; begin t.Hit; end;
  4077. `
  4078. );
  4079. cg = await CodeGraph.init(tempDir, { index: true });
  4080. // `Helper` is implementation-only (no interface decl, not a method), but its
  4081. // body's call must attribute to `Helper`, not the file/module — alongside the
  4082. // method `DoStuff`.
  4083. expect(callerNamesOf('TTgt::Hit')).toEqual(['DoStuff', 'Helper']);
  4084. });
  4085. });
  4086. describe('Nix path import resolution', () => {
  4087. function fileNode(filePath: string) {
  4088. return cg.getNodesByKind('file').find((n) => n.filePath === filePath);
  4089. }
  4090. function importedFilePaths(fromFile: string): string[] {
  4091. const source = fileNode(fromFile);
  4092. expect(source, `${fromFile} file node`).toBeDefined();
  4093. return cg
  4094. .getOutgoingEdges(source!.id)
  4095. .filter((edge) => edge.kind === 'imports')
  4096. .map((edge) => cg.getNodesByKind('file').find((n) => n.id === edge.target)?.filePath)
  4097. .filter((filePath): filePath is string => Boolean(filePath))
  4098. .sort();
  4099. }
  4100. it('resolves relative Nix imports to indexed file nodes', async () => {
  4101. fs.mkdirSync(path.join(tempDir, 'core'), { recursive: true });
  4102. fs.mkdirSync(path.join(tempDir, 'data'), { recursive: true });
  4103. fs.writeFileSync(path.join(tempDir, 'core', 'ports.nix'), '{ http = 80; https = 443; }');
  4104. fs.writeFileSync(
  4105. path.join(tempDir, 'data', 'postgresql.nix'),
  4106. `let
  4107. ports = import ../core/ports.nix;
  4108. in
  4109. {
  4110. port = ports.https;
  4111. }
  4112. `
  4113. );
  4114. cg = await CodeGraph.init(tempDir, { index: true });
  4115. cg.resolveReferences();
  4116. expect(importedFilePaths('data/postgresql.nix')).toEqual(['core/ports.nix']);
  4117. });
  4118. it('resolves Nix directory imports through default.nix and deduplicates called imports', async () => {
  4119. fs.mkdirSync(path.join(tempDir, 'dir'), { recursive: true });
  4120. fs.writeFileSync(path.join(tempDir, 'dir', 'default.nix'), '{ value = 1; }');
  4121. fs.writeFileSync(path.join(tempDir, 'x.nix'), '{ value = 2; }');
  4122. fs.writeFileSync(
  4123. path.join(tempDir, 'main.nix'),
  4124. `let
  4125. dir = import ./dir;
  4126. x = import ./x.nix {};
  4127. in
  4128. {
  4129. inherit dir x;
  4130. }
  4131. `
  4132. );
  4133. cg = await CodeGraph.init(tempDir, { index: true });
  4134. cg.resolveReferences();
  4135. expect(importedFilePaths('main.nix')).toEqual(['dir/default.nix', 'x.nix']);
  4136. });
  4137. it('resolves NixOS module imports lists and callPackage paths to file nodes', async () => {
  4138. fs.mkdirSync(path.join(tempDir, 'modules'), { recursive: true });
  4139. fs.mkdirSync(path.join(tempDir, 'common'), { recursive: true });
  4140. fs.mkdirSync(path.join(tempDir, 'pkgs', 'hello'), { recursive: true });
  4141. fs.writeFileSync(path.join(tempDir, 'modules', 'users.nix'), '{ users.users.demo.isNormalUser = true; }');
  4142. fs.writeFileSync(path.join(tempDir, 'common', 'default.nix'), '{ time.timeZone = "UTC"; }');
  4143. fs.writeFileSync(
  4144. path.join(tempDir, 'pkgs', 'hello', 'default.nix'),
  4145. '{ stdenv }: stdenv.mkDerivation { pname = "hello"; }'
  4146. );
  4147. fs.writeFileSync(
  4148. path.join(tempDir, 'configuration.nix'),
  4149. `{ config, pkgs, ... }:
  4150. {
  4151. imports = [ ./modules/users.nix ./common ];
  4152. environment.systemPackages = [ (pkgs.callPackage ./pkgs/hello { }) ];
  4153. }
  4154. `
  4155. );
  4156. cg = await CodeGraph.init(tempDir, { index: true });
  4157. cg.resolveReferences();
  4158. expect(importedFilePaths('configuration.nix')).toEqual([
  4159. 'common/default.nix',
  4160. 'modules/users.nix',
  4161. 'pkgs/hello/default.nix',
  4162. ]);
  4163. });
  4164. it('never resolves another language\'s calls into nix bindings', async () => {
  4165. // Nix bindings are not linkable symbols from any other language —
  4166. // interop is eval/CLI. Without the target-side gate, a Python script's
  4167. // bare `resolve(...)` exact-matches a module's `resolve = ...` binding.
  4168. fs.writeFileSync(
  4169. path.join(tempDir, 'helpers.nix'),
  4170. `let
  4171. resolve = x: x;
  4172. in
  4173. {
  4174. inherit resolve;
  4175. }
  4176. `
  4177. );
  4178. fs.writeFileSync(path.join(tempDir, 'tool.py'), 'def main():\n return resolve("target")\n');
  4179. cg = await CodeGraph.init(tempDir, { index: true });
  4180. cg.resolveReferences();
  4181. const nixNodeIds = new Set(
  4182. cg.getNodesByKind('variable').filter((n) => n.language === 'nix').map((n) => n.id)
  4183. );
  4184. const pyFns = cg.getNodesByKind('function').filter((n) => n.language === 'python');
  4185. expect(pyFns.length).toBeGreaterThan(0);
  4186. const crossEdges = pyFns.flatMap((f) => cg.getOutgoingEdges(f.id)).filter((e) => nixNodeIds.has(e.target));
  4187. expect(crossEdges).toEqual([]);
  4188. });
  4189. it('never cross-links Nix calls by bare name across files (lexical scope only)', async () => {
  4190. // Both modules `inherit (lib) mkOption` — the nixpkgs idiom. A call to
  4191. // mkOption in one file must NOT resolve to the other file's inherit
  4192. // binding: Nix has no ambient cross-file namespace, so any such edge is
  4193. // wrong by construction. Same-file bindings still resolve.
  4194. fs.writeFileSync(
  4195. path.join(tempDir, 'alpha.nix'),
  4196. `{ lib, ... }:
  4197. let
  4198. inherit (lib) mkOption;
  4199. mkPort = default: mkOption { inherit default; };
  4200. in
  4201. {
  4202. options.alpha.port = mkPort 8080;
  4203. }
  4204. `
  4205. );
  4206. fs.writeFileSync(
  4207. path.join(tempDir, 'beta.nix'),
  4208. `{ lib, ... }:
  4209. let
  4210. inherit (lib) mkOption;
  4211. in
  4212. {
  4213. options.beta.enable = mkOption { default = false; };
  4214. }
  4215. `
  4216. );
  4217. cg = await CodeGraph.init(tempDir, { index: true });
  4218. cg.resolveReferences();
  4219. const crossFileCalls = cg
  4220. .getNodesByKind('file')
  4221. .flatMap((f) => cg.getOutgoingEdges(f.id))
  4222. .concat(
  4223. cg.getNodesByKind('function').flatMap((f) => cg.getOutgoingEdges(f.id)),
  4224. cg.getNodesByKind('variable').flatMap((v) => cg.getOutgoingEdges(v.id))
  4225. )
  4226. .filter((e) => e.kind === 'calls')
  4227. .map((e) => {
  4228. const src = cg.getNode(e.source);
  4229. const tgt = cg.getNode(e.target);
  4230. return { from: src?.filePath, to: tgt?.filePath, name: tgt?.name };
  4231. });
  4232. // No calls edge may cross files by bare-name matching.
  4233. expect(crossFileCalls.filter((e) => e.from !== e.to)).toEqual([]);
  4234. // The same-file chain still resolves: mkPort's mkOption call hits
  4235. // alpha.nix's own inherit binding.
  4236. const sameFile = crossFileCalls.filter((e) => e.from === e.to && e.name === 'mkOption');
  4237. expect(sameFile.length).toBeGreaterThan(0);
  4238. expect(sameFile.every((e) => e.from === 'alpha.nix' || e.from === 'beta.nix')).toBe(true);
  4239. });
  4240. it('does not resolve Nix angle-bracket, attribute, or variable imports as project file edges', async () => {
  4241. fs.writeFileSync(path.join(tempDir, 'nixpkgs.nix'), '{ bogus = true; }');
  4242. fs.writeFileSync(path.join(tempDir, 'selectedPath.nix'), '{ bogus = true; }');
  4243. fs.writeFileSync(
  4244. path.join(tempDir, 'main.nix'),
  4245. `let
  4246. pkgs = import <nixpkgs> {};
  4247. fromSources = import sources.nixpkgs {};
  4248. dynamic = import selectedPath;
  4249. in
  4250. {
  4251. inherit pkgs fromSources dynamic;
  4252. }
  4253. `
  4254. );
  4255. cg = await CodeGraph.init(tempDir, { index: true });
  4256. cg.resolveReferences();
  4257. expect(importedFilePaths('main.nix')).toEqual([]);
  4258. });
  4259. });
  4260. });