فهرست منبع

chore: trim stale comments and duplicate strings

Tianyi Cui 3 ماه پیش
والد
کامیت
0334b4ad2e
4فایلهای تغییر یافته به همراه11 افزوده شده و 7 حذف شده
  1. 0 2
      packages/agent-loop/src/loop.ts
  2. 5 2
      packages/agent/src/index.ts
  3. 3 2
      packages/agent/src/types.ts
  4. 3 1
      packages/session/src/index.ts

+ 0 - 2
packages/agent-loop/src/loop.ts

@@ -560,8 +560,6 @@ async function runStep(
     })
     // signal CAN flip during the await above (abort() inside a tool);
     // the analyzer can't see through the await boundary.
-    // signal can flip during the await above (abort() inside a tool);
-    // the analyzer can't see through the await boundary.
     /* v8 ignore start -- signal.reason default unreachable via agent.abort() */
     // eslint-disable-next-line @typescript-eslint/no-unnecessary-condition
     if (signal.aborted) throw new Error(String(signal.reason ?? 'aborted'))

+ 5 - 2
packages/agent/src/index.ts

@@ -71,6 +71,9 @@ export interface AgentFactory {
   resume(options: ResumeAgentOptions): Promise<Agent>
 }
 
+/** Thrown when create/resume is called before an agent factory is registered. */
+const NO_FACTORY_MESSAGE = 'no agent factory registered (load an agent-loop plugin)'
+
 /**
  * Agent registry (`ctx.agents`): tracks live agents so UI, hook, and
  * orchestrator plugins can find them without depending on the concrete loop
@@ -107,7 +110,7 @@ export class AgentRegistry extends Service {
    * registered.
    */
   create(options: CreateAgentOptions): Agent {
-    if (this.factory === undefined) throw new Error('no agent factory registered (load an agent-loop plugin)')
+    if (this.factory === undefined) throw new Error(NO_FACTORY_MESSAGE)
     return this.factory.createAgent(options)
   }
 
@@ -117,7 +120,7 @@ export class AgentRegistry extends Service {
    * session persistence is not configured.
    */
   async resume(options: ResumeAgentOptions): Promise<Agent> {
-    if (this.factory === undefined) throw new Error('no agent factory registered (load an agent-loop plugin)')
+    if (this.factory === undefined) throw new Error(NO_FACTORY_MESSAGE)
     return this.factory.resume(options)
   }
 

+ 3 - 2
packages/agent/src/types.ts

@@ -72,8 +72,9 @@ export interface Agent {
    * (inject is synchronous): a failing flush is reported via `agent/error`
    * (step `0`) and the logger, never thrown into the caller.
    *
-   * TODO(review): exact envelope/rendering rules live in dsh-session and need
-   * review once a real adapter exists.
+   * TODO(review): verify the tagged-envelope rendering against live model
+   * behavior; the real adapters that were the original precondition now exist
+   * (see the twin-adapter RFC).
    */
   inject(content: ContentBlock[], options?: SendOptions): void
 

+ 3 - 1
packages/session/src/index.ts

@@ -42,7 +42,9 @@ declare module 'cordis' {
  * synthetic user-role message (the system-reminder pattern: zero adapter
  * burden, models distinguish it from real user prompts by the envelope).
  *
- * TODO(review): revisit the envelope once a real adapter exists.
+ * TODO(review): verify the tagged-envelope rendering against live model
+ * behavior; the real adapters that were the original precondition now exist
+ * (see the twin-adapter RFC).
  */
 function renderTagged(tag: string, content: ContentBlock[], source: MessageSource): ContentBlock[] {
   const open = `<${tag} source=${JSON.stringify(source.kind)}>`