Просмотр исходного кода

fix(web): assert both viewport axes and align the note with the committed golden

The in-viewport checks covered only the x axis while the note promised
failure on any out-of-viewport move; both axes are now asserted. The
Agent Note (en + zh) now describes the committed golden (boolean
verdicts only), the host-plane e2e pairing (client exclude + host
include) that gives the file its single TypeScript program, and the
typed exit-path assertion.
Chinesezjc 2 месяцев назад
Родитель
Сommit
1ede702c9d

+ 2 - 2
.agents/notes/implemented/feature/2026-08-06-plan-narrow-viewport-regression.i18n.yaml

@@ -2,5 +2,5 @@
 # side as of the last confirmed-consistent state. Both languages carry equal authority;
 # after editing either side, bring the other along and re-record with:
 #   pnpm run verify-translation-pairing --write .agents/notes/implemented/feature/2026-08-06-plan-narrow-viewport-regression.md
-2026-08-06-plan-narrow-viewport-regression.md: 2a50e420e5d701b5a0dc84ee7389377835cb2f2b
-2026-08-06-plan-narrow-viewport-regression.zh.md: 25c78baf8fc05c98b0a819630a48a6ee33557e4b
+2026-08-06-plan-narrow-viewport-regression.md: a183a17ce90eecbf0d1af524dbbefe8e417dd463
+2026-08-06-plan-narrow-viewport-regression.zh.md: 6c26ee1b5e4b00806e5fe5548ec8740ba8a66de8

+ 3 - 3
.agents/notes/implemented/feature/2026-08-06-plan-narrow-viewport-regression.md

@@ -14,9 +14,9 @@ The browser regression test reproduced the report on current master: at 800×720
 
 The row wraps instead of shrinking its left group into the right group's area: `.row { flex-wrap: wrap }` plus `margin-left: auto` on `.trailing`, which re-anchors the trailing group (model + send) to the right edge of its wrapped line while `space-between` already pins it right on a single line. Wrapping is the acceptance's "wrap, fold, or re-arrange controls when space runs out" option, keeps every control at full width (no label folding that would hide the model name or the Plan wordmark), and holds at every viewport width by construction instead of at a calibrated container-query threshold.
 
-Add `apps/web/tests/plan-control-row.e2e.ts`: enter plan mode once through the real `/plan` command during record (the model replies OK and calls no tool, so the review takeover never replaces the control row), then replay the recorded turn keyless. Plan state folds from the session log (`plan/mode`, last one wins), so the chip renders at replay time without a model call. The file joins the `apps/web/tsconfig.json` exclude list like every web e2e that imports host-plane types, so the client graph never compiles it.
+Add `apps/web/tests/plan-control-row.e2e.ts`: enter plan mode once through the real `/plan` command during record (the model replies OK and calls no tool, so the review takeover never replaces the control row), then replay the recorded turn keyless. Plan state folds from the session log (`plan/mode`, last one wins), so the chip renders at replay time without a model call. The file joins the host-plane e2e pairing like every sibling: excluded from the client graph in `apps/web/tsconfig.json` (it imports host-plane types) AND included in the host aggregate in `tsconfig.host.json`, so exactly one TypeScript program owns it — the pairing that also gives the lint type service its program.
 
-The geometry golden records stable facts — viewport membership, the center hit-test verdict, the gap between the chip's right edge and the trigger's left edge, the overlap area, and the exit result — never absolute coordinates, whose pixel values depend on installed fonts. The behavior assertions implement the acceptance directly: the chip center hit-tests to the chip, the click areas are disjoint, and clicking the chip leaves plan mode through the real command channel (`/plan off` via `commands.execute`).
+The geometry golden records stable facts — viewport membership on both axes and disjoint click areas — never absolute coordinates, whose pixel values depend on installed fonts and differ between macOS and Linux. The behavior assertions implement the acceptance directly: the click areas are disjoint, the click at the chip's center (Playwright's actionability check) leaves plan mode through the real command channel (`/plan off` via `commands.execute`), and the last `plan/mode` event in the session log flips inactive.
 
 ## Alternatives considered
 
@@ -30,4 +30,4 @@ The geometry golden records stable facts — viewport membership, the center hit
 
 ## Consequences
 
-Any future change to the control row layout — fonts, gaps, media or container queries — that re-introduces overlap or moves the chip out of viewport fails this test. Recording needs a real API key locally; CI replays keyless. The fixture's recorded user prompt is the single source tying the drive step to the recorded reality (`fixtureUserPrompts`), so prompt and fixture cannot drift.
+Any future change to the control row layout — fonts, gaps, media or container queries — that re-introduces overlap or moves the chip out of the viewport on either axis fails this test. Recording needs a real API key locally; CI replays keyless. The fixture's recorded user prompt is the single source tying the drive step to the recorded reality (`fixtureUserPrompts`), so prompt and fixture cannot drift.

+ 3 - 3
.agents/notes/implemented/feature/2026-08-06-plan-narrow-viewport-regression.zh.md

@@ -14,9 +14,9 @@
 
 控制行换行而不是把左侧组收缩进右侧组的区域:`.row { flex-wrap: wrap }` 加上 `.trailing` 的 `margin-left: auto`——后者把 trailing 组(模型选择 + 发送)重新锚定到换行后的右缘,单行时 `space-between` 已把它钉在右侧。换行是验收中"空间不足时允许换行、折叠或重新排列控件"的选项,保持每个控件全宽(不做会隐藏模型名或 Plan 字样的 label 折叠),并且按构造在所有视口宽度下成立,而非依赖标定的容器查询阈值。
 
-新增 `apps/web/tests/plan-control-row.e2e.ts`:录制时通过真实 `/plan` 命令进入一次 Plan 模式(模型只回复 OK 且不调用任何工具,因此 review takeover 不会替换控制行),随后 keyless 回放录制的回合。Plan 状态从会话日志折叠(`plan/mode`,最后一条生效),回放时无需模型调用即可渲染 chip。该文件与所有导入 host 平面类型的 web e2e 一样加入 `apps/web/tsconfig.json` 的 exclude 列表,client 图绝不编译它。
+新增 `apps/web/tests/plan-control-row.e2e.ts`:录制时通过真实 `/plan` 命令进入一次 Plan 模式(模型只回复 OK 且不调用任何工具,因此 review takeover 不会替换控制行),随后 keyless 回放录制的回合。Plan 状态从会话日志折叠(`plan/mode`,最后一条生效),回放时无需模型调用即可渲染 chip。该文件与所有同类 host 平面 e2e 一样采用成对登记:在 `apps/web/tsconfig.json` 的 exclude 列表(它导入 host 平面类型,client 图绝不编译它),同时在 `tsconfig.host.json` 的 host 聚合 include 中——恰好一个 TypeScript 程序拥有它,这也是 lint 类型服务获得程序的配对方式。
 
-几何 golden 记录稳定事实——视口内位置、中心命中测试结论、chip 右缘与 trigger 左缘的间隙、重叠面积、退出结果——绝不记录绝对坐标,其像素值依赖安装字体。行为断言直接实现验收:chip 中心命中 chip 自身、点击区域不相交、点击 chip 通过真实命令通道(经 `commands.execute` 执行 `/plan off`)退出 Plan 模式。
+几何 golden 记录稳定事实——两个轴上的视口内位置与点击区域不相交——绝不记录绝对坐标,其像素值依赖安装字体且在 macOS 与 Linux 间不同。行为断言直接实现验收:点击区域不相交、点击 chip 中心(Playwright 的可操作性检查)经真实命令通道(`commands.execute` 执行 `/plan off`)退出 Plan 模式,且会话日志中最后一条 `plan/mode` 事件翻转为 inactive。
 
 ## 备选方案
 
@@ -30,4 +30,4 @@
 
 ## 后果
 
-任何改变控制行布局的后续改动——字体、间距、媒体查询或容器查询——一旦重新引入重叠或把 chip 移出视口,本测试即失败。录制需要本地真实 API key;CI keyless 回放。fixture 中录制的用户 prompt 是驱动步骤与录制事实之间的唯一纽带(`fixtureUserPrompts`),prompt 与 fixture 不会漂移。
+任何改变控制行布局的后续改动——字体、间距、媒体查询或容器查询——一旦重新引入重叠或把 chip 沿任一轴移出视口,本测试即失败。录制需要本地真实 API key;CI keyless 回放。fixture 中录制的用户 prompt 是驱动步骤与录制事实之间的唯一纽带(`fixtureUserPrompts`),prompt 与 fixture 不会漂移。

+ 2 - 0
apps/web/tests/plan-control-row.e2e.ts

@@ -110,7 +110,9 @@ describe('web e2e: plan chip click area at the narrow viewport', () => {
     // disjoint click areas (a non-zero overlap would fail), and — in the
     // click below — the chip center receiving the pointer.
     const chipInViewport = chipBox!.x >= 0 && chipBox!.x + chipBox!.width <= VIEWPORT.width
+      && chipBox!.y >= 0 && chipBox!.y + chipBox!.height <= VIEWPORT.height
     const triggerInViewport = triggerBox!.x >= 0 && triggerBox!.x + triggerBox!.width <= VIEWPORT.width
+      && triggerBox!.y >= 0 && triggerBox!.y + triggerBox!.height <= VIEWPORT.height
     const overlapLeft = Math.max(chipBox!.x, triggerBox!.x)
     const overlapTop = Math.max(chipBox!.y, triggerBox!.y)
     const overlapRight = Math.min(chipBox!.x + chipBox!.width, triggerBox!.x + triggerBox!.width)