Răsfoiți Sursa

fix(cic): narrow workflow.on before Object.keys in event-set assertion

The exact-event-set assertion called Object.keys on a Record<string, unknown>'s
on field without narrowing, failing typecheck (TS2769). Guard with isRecord
before asserting the full event sets.
Chinesezjc 1 lună în urmă
părinte
comite
7ae647d52c
1 a modificat fișierele cu 3 adăugiri și 0 ștergeri
  1. 3 0
      scripts/ci-workflow.spec.ts

+ 3 - 0
scripts/ci-workflow.spec.ts

@@ -143,6 +143,9 @@ describe('CI workflow', () => {
     // panel: ci-master triggers only on push(master) + workflow_dispatch and
     // never on pull_request; ci.yml is exactly pull_request-only. Assert the
     // full sets so losing the wrong event, or gaining an extra one, fails.
+    if (!isRecord(workflow.on) || !isRecord(prWorkflow.on)) {
+      throw new TypeError('both CI workflows must define on')
+    }
     expect(Object.keys(workflow.on).sort()).toEqual(['push', 'workflow_dispatch'])
     expect(Object.keys(prWorkflow.on)).toEqual(['pull_request'])