Explorar o código

refactor(subagent): avoid duplicate process diagnostics

pku-xht hai 1 mes
pai
achega
f0b2d7c762
Modificáronse 1 ficheiros con 6 adicións e 7 borrados
  1. 6 7
      packages/subagent/subagent-codex/src/run.ts

+ 6 - 7
packages/subagent/subagent-codex/src/run.ts

@@ -71,13 +71,12 @@ function failureDiagnostic(facts: CodexFailureFacts): string {
   if (facts.httpStatus !== undefined) {
     fields.push(`HTTP status: ${facts.httpStatus}`)
   }
-  const exitCode = facts.outcome?.exitCode
-  if (exitCode !== null && exitCode !== undefined) {
-    fields.push(`exit code: ${exitCode}`)
-  }
-  const signal = facts.outcome?.signal
-  if (signal !== null && signal !== undefined) {
-    fields.push(`signal: ${signal}`)
+  const processFields = [
+    ['exit code', facts.outcome?.exitCode],
+    ['signal', facts.outcome?.signal],
+  ] as const
+  for (const [label, value] of processFields) {
+    if (value !== null && value !== undefined) fields.push(`${label}: ${value}`)
   }
   return `Product subagent failure (${fields.join('; ')})`
 }