deepseek-harness/packages/hooks/hooks-codex/tests/config.spec.ts

import { describe, expect, it } from 'vitest'
import { parseCodexConfig, CODEX_EVENTS } from '@deepseek-ai/dsh-hooks-codex/src/config.ts'

describe('parseCodexConfig', () => {
  it('honors only the five bridge-supported Codex events, dropping the rest', () => {
    const { config } = parseCodexConfig({
      PreToolUse: [{ hooks: [{ type: 'command', command: 'a.sh' }] }],
      SubagentStop: [{ hooks: [{ type: 'command', command: 'b.sh' }] }], // current Codex event, unsupported by this bridge
      Notification: [{ hooks: [{ type: 'command', command: 'c.sh' }] }], // unknown to current Codex
    })
    expect(Object.keys(config)).toEqual(['PreToolUse'])
    expect(CODEX_EVENTS).toContain('PreToolUse')
    expect(CODEX_EVENTS).not.toContain('SubagentStop' as never)
  })

  it('accepts both timeout and the timeoutSec alias, no substitution', () => {
    const { config } = parseCodexConfig({
      Stop: [{ hooks: [{ type: 'command', command: '${NOT_SUBSTITUTED}/s.sh', timeout: 10 }] }],
      UserPromptSubmit: [{ hooks: [{ type: 'command', command: 'u.sh', timeoutSec: 20 }] }],
    })
    // The parser performs no config-time substitution; shell expansion happens later.
    expect(config.Stop).toEqual([{ hooks: [{ command: '${NOT_SUBSTITUTED}/s.sh', timeoutSec: 10 }] }])
    expect(config.UserPromptSubmit).toEqual([{ hooks: [{ command: 'u.sh', timeoutSec: 20 }] }])
  })

  it('skips non-command and async:true hooks (recorded)', () => {
    const { config, skipped } = parseCodexConfig({
      PreToolUse: [{ hooks: [
        { type: 'prompt' },
        { type: 'command', command: 'sync.sh' },
        { type: 'command', command: 'bg.sh', async: true },
      ] }],
    })
    expect(config.PreToolUse).toEqual([{ hooks: [{ command: 'sync.sh' }] }])
    expect(skipped).toEqual([{ event: 'PreToolUse', reason: 'unsupported "prompt" hook' }, { event: 'PreToolUse', reason: 'async hook' }])
  })

  it('parses the { hooks: … } wrapper and the bare map identically', () => {
    const groups = { Stop: [{ hooks: [{ type: 'command', command: 's.sh' }] }] }
    expect(parseCodexConfig(groups).config).toEqual(parseCodexConfig({ hooks: groups }).config)
  })

  it('drops malformed entries and a non-object top level without throwing', () => {
    expect(parseCodexConfig(null).config).toEqual({})
    expect(parseCodexConfig({ PreToolUse: 'no' }).config).toEqual({})
    expect(parseCodexConfig({ Stop: [7, { hooks: 'x' }, { hooks: [{ type: 'command', command: 9 }] }] }).config).toEqual({})
  })

  it('skips a non-object element inside a hooks array, keeping the valid sibling', () => {
    const { config } = parseCodexConfig({ Stop: [{ hooks: [null, 7, { type: 'command', command: 's.sh' }] }] })
    expect(config.Stop).toEqual([{ hooks: [{ command: 's.sh' }] }])
  })

  it('treats a hook with no `type` field as a command (the default)', () => {
    const { config } = parseCodexConfig({ Stop: [{ hooks: [{ command: 's.sh' }] }] })
    expect(config.Stop).toEqual([{ hooks: [{ command: 's.sh' }] }])
  })

  it('omits the matcher key for a match-all group', () => {
    const { config } = parseCodexConfig({ Stop: [{ hooks: [{ type: 'command', command: 's.sh' }] }] })
    expect('matcher' in config.Stop![0]!).toBe(false)
  })

  it('keeps a matcher when present', () => {
    const { config } = parseCodexConfig({ PreToolUse: [{ matcher: '^Bash$', hooks: [{ type: 'command', command: 'b.sh' }] }] })
    expect(config.PreToolUse![0]!.matcher).toBe('^Bash$')
  })

  it('rejects an invalid regex matcher with its event name', () => {
    expect(() => parseCodexConfig({
      PreToolUse: [{ matcher: '[', hooks: [{ type: 'command', command: 's.sh' }] }],
    })).toThrow('invalid codex regex matcher "[" on event "PreToolUse"')
  })

  it('discards matcher fields on events without matcher subjects before validation', () => {
    const { config } = parseCodexConfig({
      UserPromptSubmit: [{ matcher: '[', hooks: [{ type: 'command', command: 'prompt.sh' }] }],
      Stop: [{ matcher: '(', hooks: [{ type: 'command', command: 'stop.sh' }] }],
    })

    expect(config).toEqual({
      UserPromptSubmit: [{ hooks: [{ command: 'prompt.sh' }] }],
      Stop: [{ hooks: [{ command: 'stop.sh' }] }],
    })
  })
})