web-agent-presets.e2e.ts 34 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670671672673674675676677678679680681682683684685686687688689690691692693694695696697698699700701702703704705706707708709710711712713714715716717718719720721722723724725726727728729730731732733734735736737738739740741742743744745746747748749750751
  1. import { randomUUID } from 'node:crypto'
  2. import { mkdir, mkdtemp, readFile, stat, writeFile } from 'node:fs/promises'
  3. import { tmpdir } from 'node:os'
  4. import { fileURLToPath } from 'node:url'
  5. import { dirname, join } from 'node:path'
  6. import { Context } from '@deepseek-ai/cordis'
  7. import { boot, healProfilesModuleFallback, loadOverlayPatches } from '@deepseek-ai/dsh-app-boot'
  8. import { provideCmdline } from '@deepseek-ai/dsh-cmdline'
  9. import { SessionId } from '@deepseek-ai/dsh-session'
  10. import type { Agent } from '@deepseek-ai/dsh-agent'
  11. import type { PatchOptions } from '@deepseek-ai/cordis-plugin-include'
  12. import { afterAll, beforeAll, describe, expect, it } from 'vitest'
  13. import { settingsNamespace } from '@deepseek-ai/dsh-settings'
  14. import { resolveSessionPreset, SETTINGS_NAMESPACE } from '@deepseek-ai/dsh-agent-presets'
  15. import { applyChildComposition, childSessionMeta } from '@deepseek-ai/dsh-subagent'
  16. import { CallId } from '@deepseek-ai/dsh-llm'
  17. import type { BasicCompactService } from '@deepseek-ai/dsh-compact-basic'
  18. import type {} from '@deepseek-ai/dsh-skill'
  19. import type {} from '@deepseek-ai/dsh-tools'
  20. // Type-only: resolves `ctx.get('sessionProjections')` and `ctx.get('tokenMeter')`.
  21. import type {} from '@deepseek-ai/dsh-session-projection'
  22. import type {} from '@deepseek-ai/dsh-token-meter'
  23. const CONFIG_DIR = fileURLToPath(new URL('../config/', import.meta.url))
  24. const REPO_ROOT = fileURLToPath(new URL('../../..', import.meta.url))
  25. /** The shipped Web surface: the dsh-base and dsh-web-app bundle patches over an empty preset root. */
  26. const BASE_PATCH = join(REPO_ROOT, 'packages/bundle/base/cordis.patch.yml')
  27. const WEB_PATCH = join(REPO_ROOT, 'packages/bundle/web-app/cordis.patch.yml')
  28. /** The installation anchor whose dependency surface the preset module fallback mirrors. */
  29. const INSTALL_ANCHOR = join(REPO_ROOT, 'apps/cli/package.json')
  30. const MINIMAL_PROMPT = 'You are a helpful software engineer assistant.'
  31. const MINIMAL_BASH_DESCRIPTION = `Run commands in a bash shell
  32. * When invoking this tool, the contents of the "command" parameter does NOT need to be XML-escaped.
  33. * You don't have access to the internet via this tool.
  34. * You do have access to a mirror of common linux and python packages via apt and pip.
  35. * State is persistent across command calls and discussions with the user.
  36. * To inspect a particular line range of a file, e.g. lines 10-25, try 'sed -n 10,25p /path/to/the/file'.
  37. * Please avoid commands that may produce a very large amount of output.
  38. * Please run long lived commands in the background, e.g. 'sleep 10 &' or start a server in the background.`
  39. /**
  40. * Boot the shipped Web composition, minus the rows that would bind a port,
  41. * touch the network, or write outside the test. Everything that decides an
  42. * agent's capabilities is the real thing, including both shipped presets.
  43. */
  44. async function bootWeb(settingsFile: string, extra: PatchOptions[] = []): Promise<Context> {
  45. const storageRoot = join(dirname(settingsFile), 'storages')
  46. const patches: PatchOptions[] = [
  47. ...loadOverlayPatches('dsh-test', BASE_PATCH),
  48. ...loadOverlayPatches('dsh-test', WEB_PATCH),
  49. // The settings row defaults to `$DSH_HOME/settings.yaml`. Left alone it
  50. // reads the developer's own document — and since the default preset is a
  51. // setting, a stored `agent-presets.default` would decide this file's
  52. // outcome. Point it at a temp file for the same reason the roster below
  53. // names only the shipped root.
  54. { id: 'settings', config: { path: settingsFile, watch: false } },
  55. // storage-json's root is anchored to the real $DSH_HOME. Unpinned, this
  56. // file writes the developer's own `~/.dsh/storages/` — and then reads it
  57. // back on the next run, so a stored document from any other build decides
  58. // this test's boot. Same reason the settings row above is pinned.
  59. { id: 'storage-json', config: { root: storageRoot } },
  60. // Host rows with side effects outside this process: a bound port, a served
  61. // asset tree, a telemetry exporter. `api-gateway` and `directory-picker`
  62. // stay ENABLED on purpose — the api-proxy is the host row that injects
  63. // `subagents`, `workspace`, and the rest of the agent plane, so disabling
  64. // it would hide exactly the breakage this file exists to catch: a service
  65. // moved into the presets that a host row still waits for. The boot audit
  66. // is that assertion.
  67. { id: 'webserver', disabled: true },
  68. // The web bundle's runtime row injects `httpServer`, so it cannot
  69. // activate without the bound port disabled above. It owns dist serving
  70. // and the URL prompt line — surface glue, not anything that decides an
  71. // agent's capabilities, which is all this file asserts.
  72. { id: 'web-runtime', disabled: true },
  73. { id: 'telemetry-otel', disabled: true },
  74. // A deployment-level skill on the host registry's GLOBAL layer — the same
  75. // registration shape a repository plugin's skill root uses. The layered
  76. // skills test below proves it reaches preset-composed agents.
  77. { id: 'skill-badge', disabled: false },
  78. { id: 'modules', disabled: true },
  79. { id: 'connection', disabled: true },
  80. // The shipped `-auto` chooser resolves its interaction from a running
  81. // host and so waits for the webserver disabled above; the browse variant
  82. // supplies `directoryPicker` without one.
  83. { id: 'directory-picker', disabled: true },
  84. { insert: [{ id: 'directory-picker-browse', name: '@deepseek-ai/dsh-host-directory-picker-browse' }] },
  85. // The roster AppCLIEntry would patch in; only the shipped root, so a
  86. // developer's own `~/.dsh/.preset` cannot change this test's outcome.
  87. // `default` here is the COMPOSITION default — the base layer the settings
  88. // document overrides.
  89. {
  90. id: 'agent-presets',
  91. config: { default: 'standard', roots: [{ path: join(CONFIG_DIR, 'agent-presets'), trust: 'system' }] },
  92. },
  93. ...extra,
  94. ]
  95. // The surface is patch layers over an empty preset root, so the root sits
  96. // outside this workspace and bare plugin names cannot resolve by Node's
  97. // upward walk. The flat fallback the preset boot maintains is what makes
  98. // them resolvable — the same mechanism, not a test-only shim.
  99. const home = dirname(settingsFile)
  100. healProfilesModuleFallback(INSTALL_ANCHOR, home)
  101. const profileDir = join(home, 'profiles', 'spec')
  102. await mkdir(profileDir, { recursive: true })
  103. const rootConfig = join(profileDir, 'cordis.yml')
  104. await writeFile(rootConfig, '[]\n')
  105. return await boot('dsh-test', rootConfig, patches, (bootCtx) => {
  106. provideCmdline(bootCtx, { args: [], exit: () => {} })
  107. })
  108. }
  109. const toolNames = (ctx: Context, agent?: Agent): string[] =>
  110. ctx.tools.schemas(agent).map(schema => schema.name).sort()
  111. function enablePresetTool(composition: string, id: string): string {
  112. const row = ` - id: ${id}\n`
  113. const start = composition.indexOf(row)
  114. if (start < 0) throw new Error(`missing preset row ${id}`)
  115. const end = composition.indexOf('\n - id:', start + row.length)
  116. const disabled = composition.indexOf(' disabled: true\n', start)
  117. if (disabled < 0 || (end >= 0 && disabled > end)) {
  118. throw new Error(`preset row ${id} is not disabled`)
  119. }
  120. return composition.slice(0, disabled) + composition.slice(disabled + ' disabled: true\n'.length)
  121. }
  122. let ctx: Context
  123. beforeAll(async () => {
  124. const settingsFile = join(await mkdtemp(join(tmpdir(), 'dsh-web-presets-')), 'settings.yaml')
  125. await writeFile(settingsFile, '{}\n')
  126. ctx = await bootWeb(settingsFile)
  127. }, 120_000)
  128. describe('the shipped Web composition', () => {
  129. it('leaves the global tool layer empty', () => {
  130. // Every model-facing tool belongs to a preset, `ask_user_question`
  131. // included: a tool in the global layer reaches EVERY agent regardless of
  132. // which preset composed it, so a two-tool benchmark surface would really
  133. // present three. A regression here means an agent-plane row came back to
  134. // the host composition.
  135. expect(toolNames(ctx)).toEqual([])
  136. })
  137. it('keeps the token meter and its context-meter projections on the host plane', async () => {
  138. // Read before any preset in this file mounts, which is what makes this an
  139. // ownership assertion rather than a mount-order coincidence: a preset-side
  140. // meter sits behind an `isolate` realm and is invisible to `ctx.get`.
  141. //
  142. // The projection registry is process-wide rather than scope-layered, so a
  143. // preset-side meter would also make the browser's context meter appear for
  144. // a `minimal` session the moment some OTHER session mounted a preset that
  145. // carries one, and vanish entirely in a process that only ever ran
  146. // `minimal`. Host ownership is what makes the meter a per-session fact.
  147. expect(ctx.get('tokenMeter')).toBeDefined()
  148. const projections = ctx.get('sessionProjections')
  149. if (projections === undefined) throw new Error('the Web composition must compose a projection registry')
  150. const handle = await ctx.agents.create({
  151. sessionId: SessionId('preset-minimal-meter'),
  152. setup: agentCtx => ctx.agentPresets.mount(agentCtx, 'minimal').then(() => undefined),
  153. })
  154. try {
  155. // A subset assertion: `tasks`, `goal`, and the rest register into the
  156. // same process-wide table, and this is about the meter's three units.
  157. expect(Object.keys(projections.snapshot(handle.agent.session).values))
  158. .toEqual(expect.arrayContaining(['contextBreakdown', 'contextPressure', 'tokenUsage']))
  159. } finally {
  160. await handle.dispose()
  161. }
  162. })
  163. it('supplies both shipped presets, and only those, from the system root', async () => {
  164. const listed = await ctx.agentPresets.list()
  165. expect(listed.map(preset => preset.id).sort()).toEqual(['code', 'cordis', 'minimal', 'standard'])
  166. expect(listed.every(preset => preset.trust === 'system')).toBe(true)
  167. expect(ctx.agentPresets.defaultId).toBe('standard')
  168. })
  169. it('composes the full agent from `standard`', async () => {
  170. const handle = await ctx.agents.create({
  171. sessionId: SessionId('preset-standard'),
  172. setup: agentCtx => ctx.agentPresets.mount(agentCtx, 'standard').then(() => undefined),
  173. })
  174. try {
  175. // The EXACT catalog, not a spot-check: an omission is this design's
  176. // quietest failure mode, because a row that registers into the wrong
  177. // layer mounts cleanly and simply contributes nothing. `glob`/`grep` are
  178. // excluded for the reason the TUI composition e2e excludes them — they
  179. // depend on ripgrep being present on the machine.
  180. expect(toolNames(ctx, handle.agent).filter(name => name !== 'glob' && name !== 'grep')).toEqual([
  181. 'ask_user_question', 'bash', 'create_goal', 'edit', 'exit_plan_mode',
  182. 'get_goal', 'interrupt_agent', 'list_agents', 'ralph', 'read', 'read_image', 'send_message', 'skill',
  183. 'subagent', 'subagent_fork', 'task_kill',
  184. 'task_list', 'task_output', 'todo_write', 'update_goal', 'web_search',
  185. 'workflow', 'write',
  186. ])
  187. } finally {
  188. await handle.dispose()
  189. }
  190. })
  191. it('composes the exact RL prompt and two tools from `minimal`', async () => {
  192. const handle = await ctx.agents.create({
  193. sessionId: SessionId('preset-minimal'),
  194. setup: agentCtx => ctx.agentPresets.mount(agentCtx, 'minimal').then(() => undefined),
  195. })
  196. try {
  197. const assembly = await ctx.systemPrompt.assemble({ scope: handle.agent })
  198. expect(assembly.sections).toEqual([
  199. { name: 'deployment:persona', text: MINIMAL_PROMPT },
  200. ])
  201. expect(assembly.tools.map(tool => tool.name)).toEqual(['bash', 'str_replace_editor'])
  202. expect(assembly.tools.find(tool => tool.name === 'bash')?.description).toBe(MINIMAL_BASH_DESCRIPTION)
  203. expect(JSON.stringify(assembly.tools.find(tool => tool.name === 'str_replace_editor')?.parameters))
  204. .toContain('Absolute path')
  205. const compact = ctx.agentPresets.serviceFor(handle.agent, 'compact')
  206. expect(compact).toBeDefined()
  207. expect((compact as BasicCompactService).config).toMatchObject({
  208. thresholdRatio: 0.8,
  209. retainTokens: 20480,
  210. summarizationProvider: '',
  211. summarizationModel: '',
  212. maxTokens: 8192,
  213. compactionRetries: 1,
  214. })
  215. } finally {
  216. await handle.dispose()
  217. }
  218. })
  219. it('keeps two differently composed sessions independent', async () => {
  220. const full = await ctx.agents.create({
  221. sessionId: SessionId('preset-both-full'),
  222. setup: agentCtx => ctx.agentPresets.mount(agentCtx, 'standard').then(() => undefined),
  223. })
  224. const minimal = await ctx.agents.create({
  225. sessionId: SessionId('preset-both-minimal'),
  226. setup: agentCtx => ctx.agentPresets.mount(agentCtx, 'minimal').then(() => undefined),
  227. })
  228. try {
  229. expect(toolNames(ctx, minimal.agent)).toEqual(['bash', 'str_replace_editor'])
  230. expect(toolNames(ctx, full.agent).length).toBeGreaterThan(10)
  231. await minimal.dispose()
  232. // Tearing the minimal session down leaves the full one whole.
  233. expect(toolNames(ctx, full.agent).length).toBeGreaterThan(10)
  234. expect(toolNames(ctx)).toEqual([])
  235. } finally {
  236. await full.dispose()
  237. }
  238. })
  239. it('composes the cordis agent with its own toolset', async () => {
  240. const handle = await ctx.agents.create({
  241. sessionId: SessionId('preset-cordis'),
  242. setup: agentCtx => ctx.agentPresets.mount(agentCtx, 'cordis').then(() => undefined),
  243. })
  244. try {
  245. const tools = toolNames(ctx, handle.agent)
  246. // The self-referential toolset is what distinguishes this preset.
  247. expect(tools).toEqual(expect.arrayContaining(['cordis_inspect', 'cordis_mount', 'cordis_unmount']))
  248. // And it keeps the standard agent's own tools rather than replacing them.
  249. expect(tools).toEqual(expect.arrayContaining(['bash', 'read', 'edit', 'skill']))
  250. expect(tools).not.toContain('str_replace_editor')
  251. // The preset's own authoring skill registers into ITS layer of the host
  252. // registry: the cordis agent's view carries it, the global view does not.
  253. const scoped = (await ctx.skills.list({ scope: handle.agent })).map(skill => skill.name)
  254. expect(scoped).toContain('editing-cordis-compositions')
  255. expect((await ctx.skills.list()).map(skill => skill.name)).not.toContain('editing-cordis-compositions')
  256. } finally {
  257. await handle.dispose()
  258. }
  259. })
  260. it('presents `code` as Code Mode without disturbing a native session beside it', async () => {
  261. const coded = await ctx.agents.create({
  262. sessionId: SessionId('preset-code'),
  263. setup: agentCtx => ctx.agentPresets.mount(agentCtx, 'code').then(() => undefined),
  264. })
  265. const native = await ctx.agents.create({
  266. sessionId: SessionId('preset-code-native'),
  267. setup: agentCtx => ctx.agentPresets.mount(agentCtx, 'standard').then(() => undefined),
  268. })
  269. try {
  270. // One tool reaches the MODEL: the transport. The registry's catalog for
  271. // this agent is unchanged — a code mode collapses the presentation, not
  272. // the capabilities — so the assembly is what carries the claim.
  273. const assembly = await ctx.systemPrompt.assemble({ scope: coded.agent })
  274. expect(assembly.tools.map(tool => tool.name)).toEqual(['run_code'])
  275. expect(toolNames(ctx, coded.agent)).not.toContain('str_replace_editor')
  276. const sdk = assembly.sections.find(section => section.name === 'tools:sdk')?.text ?? ''
  277. expect(sdk).not.toContain('str_replace_editor')
  278. expect(sdk).toContain('web_search')
  279. // The presentation is this agent's alone: the deployment default is
  280. // native, and the session composed from `standard` still sees it.
  281. const nativeAssembly = await ctx.systemPrompt.assemble({ scope: native.agent })
  282. expect(nativeAssembly.tools.map(tool => tool.name)).toContain('bash')
  283. expect(nativeAssembly.tools.map(tool => tool.name)).not.toContain('run_code')
  284. expect(nativeAssembly.sections.some(section => section.name === 'tools:sdk')).toBe(false)
  285. } finally {
  286. await native.dispose()
  287. await coded.dispose()
  288. }
  289. })
  290. it('keeps the self-referential toolset out of every other preset', async () => {
  291. const handle = await ctx.agents.create({
  292. sessionId: SessionId('preset-no-cordis'),
  293. setup: agentCtx => ctx.agentPresets.mount(agentCtx, 'standard').then(() => undefined),
  294. })
  295. try {
  296. // Editing the live runtime is opt-in per session, not ambient.
  297. expect(toolNames(ctx, handle.agent)).not.toContain('cordis_mount')
  298. } finally {
  299. await handle.dispose()
  300. }
  301. })
  302. it('ships the composition-authoring skill inside the preset directory', async () => {
  303. // The preset's skill root is derived from its own `baseUrl`, so the skill
  304. // travels with the directory wherever the preset is installed.
  305. const skill = join(
  306. CONFIG_DIR, 'agent-presets', 'cordis', 'skills', 'editing-cordis-compositions', 'SKILL.md',
  307. )
  308. expect((await readFile(skill, 'utf8')).startsWith('---\nname: editing-cordis-compositions')).toBe(true)
  309. })
  310. it('merges the global skill layer into a preset agent\'s catalog, keeping local discovery preset-side', async () => {
  311. const proj = await mkdtemp(join(tmpdir(), 'dsh-preset-skill-proj-'))
  312. await mkdir(join(proj, '.dsh', 'skills', 'project-proof'), { recursive: true })
  313. await writeFile(join(proj, '.dsh', 'skills', 'project-proof', 'SKILL.md'), [
  314. '---',
  315. 'name: project-proof',
  316. 'description: Proves the preset layer discovers project skills beside global ones.',
  317. '---',
  318. '',
  319. 'Project proof body.',
  320. '',
  321. ].join('\n'))
  322. const handle = await ctx.agents.create({
  323. // Unique per run: the composition persists into the ambient DSH home,
  324. // and a fixed id would collide with a log an earlier run left there.
  325. sessionId: SessionId(`preset-skills-standard-${randomUUID()}`),
  326. setup: agentCtx => ctx.agentPresets.mount(agentCtx, 'standard').then(() => undefined),
  327. })
  328. try {
  329. // The host (global) view carries the deployment-level provider alone:
  330. // local discovery moved behind the presets with `skill-local`.
  331. expect((await ctx.skills.list({ cwd: proj })).map(skill => skill.name)).toEqual(['dsh-badge'])
  332. // The standard agent's view merges the global layer with its preset's
  333. // own local discovery over the session cwd.
  334. const scoped = (await ctx.skills.list({ cwd: proj, scope: handle.agent })).map(skill => skill.name)
  335. expect(scoped).toContain('dsh-badge')
  336. expect(scoped).toContain('project-proof')
  337. // The preset's own loader tool resolves the global-layer skill.
  338. const loaded = await ctx.tools.execute({
  339. callId: CallId('preset-skills-load'),
  340. name: 'skill',
  341. arguments: { name: 'dsh-badge' },
  342. signal: new AbortController().signal,
  343. agent: handle.agent,
  344. })
  345. expect(loaded.isError).toBe(false)
  346. expect(JSON.stringify(loaded.content)).toContain('powered by dsh')
  347. } finally {
  348. await handle.dispose()
  349. }
  350. })
  351. it('shows a minimal agent the global layer but no loader tool', async () => {
  352. const handle = await ctx.agents.create({
  353. sessionId: SessionId(`preset-skills-minimal-${randomUUID()}`),
  354. setup: agentCtx => ctx.agentPresets.mount(agentCtx, 'minimal').then(() => undefined),
  355. })
  356. try {
  357. // Layer visibility is the registry's; whether an agent can USE skills
  358. // stays the preset's choice — minimal mounts no `tool-skill`, so its
  359. // tool table has no loader even though the global layer is readable.
  360. expect((await ctx.skills.list({ scope: handle.agent })).map(skill => skill.name)).toContain('dsh-badge')
  361. expect(toolNames(ctx, handle.agent)).toEqual(['bash', 'str_replace_editor'])
  362. } finally {
  363. await handle.dispose()
  364. }
  365. })
  366. it('never rewrites the preset file it composed from', async () => {
  367. // The Loader persists a tree whose plugin self-disposed, and tearing an
  368. // agent down disposes its whole subtree. Inherited, that rewrote the
  369. // shipped composition — truncating it to `[]` the first time a session
  370. // ended — so `PresetTree` refuses to write at all.
  371. const path = join(CONFIG_DIR, 'agent-presets', 'standard', 'agent.cordis.yml')
  372. const before = await readFile(path, 'utf8')
  373. const handle = await ctx.agents.create({
  374. sessionId: SessionId('preset-readonly'),
  375. setup: agentCtx => ctx.agentPresets.mount(agentCtx, 'standard').then(() => undefined),
  376. })
  377. await handle.dispose()
  378. // Slack, not a race the number has to win. The write is driven by the
  379. // Loader's fiber-unload listener, which fires as the subtree's fibers
  380. // settle rather than when `dispose()` resolves, and the Loader exposes no
  381. // flush to await. A regression writes synchronously inside that listener,
  382. // so any wait past settlement fails; a longer one only slows the test.
  383. await new Promise(resolve => setTimeout(resolve, 50))
  384. expect(await readFile(path, 'utf8')).toBe(before)
  385. })
  386. })
  387. describe('product subagent rows in user presets', () => {
  388. let productCtx: Context
  389. const ids = ['products-none', 'products-codex', 'products-claude', 'products-both'] as const
  390. beforeAll(async () => {
  391. const root = await mkdtemp(join(tmpdir(), 'dsh-product-presets-'))
  392. const userRoot = join(root, 'presets')
  393. const settingsFile = join(root, 'settings.yaml')
  394. const standard = await readFile(join(CONFIG_DIR, 'agent-presets', 'standard', 'agent.cordis.yml'), 'utf8')
  395. await writeFile(settingsFile, '{}\n')
  396. for (const id of ids) {
  397. let composition = standard
  398. if (id === 'products-codex' || id === 'products-both') {
  399. composition = enablePresetTool(composition, 'tool-subagent-codex')
  400. }
  401. if (id === 'products-claude' || id === 'products-both') {
  402. composition = enablePresetTool(composition, 'tool-subagent-claude-code')
  403. }
  404. const directory = join(userRoot, id)
  405. await mkdir(directory, { recursive: true })
  406. await writeFile(join(directory, 'agent.cordis.yml'), composition)
  407. }
  408. productCtx = await bootWeb(settingsFile, [{
  409. id: 'agent-presets',
  410. config: {
  411. default: 'standard',
  412. roots: [
  413. { path: join(CONFIG_DIR, 'agent-presets'), trust: 'system' },
  414. { path: userRoot, trust: 'user' },
  415. ],
  416. },
  417. }])
  418. }, 120_000)
  419. afterAll(async () => {
  420. await productCtx.fiber.dispose()
  421. })
  422. it('composes none, either product, or both without changing the shared host registry', async () => {
  423. const expected = new Map<string, string[]>([
  424. ['products-none', []],
  425. ['products-codex', ['subagent_codex']],
  426. ['products-claude', ['subagent_claude_code']],
  427. ['products-both', ['subagent_claude_code', 'subagent_codex']],
  428. ])
  429. expect(productCtx.subagents.list()).toEqual(expect.arrayContaining([
  430. 'spawn', 'fork', 'codex', 'claude-code',
  431. ]))
  432. for (const [id, productTools] of expected) {
  433. const handle = await productCtx.agents.create({
  434. sessionId: SessionId(`preset-${id}`),
  435. setup: agentCtx => productCtx.agentPresets.mount(agentCtx, id).then(() => undefined),
  436. })
  437. try {
  438. const tools = toolNames(productCtx, handle.agent)
  439. expect(tools.filter(name => name === 'subagent_codex' || name === 'subagent_claude_code'))
  440. .toEqual(productTools)
  441. } finally {
  442. await handle.dispose()
  443. }
  444. }
  445. })
  446. it('applies a product-row edit only to later sessions on the preset', async () => {
  447. const preset = await productCtx.agentPresets.resolve('products-none')
  448. const original = await readFile(preset.path, 'utf8')
  449. const existing = await productCtx.agents.create({
  450. sessionId: SessionId('preset-product-generation-existing'),
  451. setup: agentCtx => productCtx.agentPresets.mount(agentCtx, 'products-none').then(() => undefined),
  452. })
  453. try {
  454. expect(toolNames(productCtx, existing.agent)).not.toContain('subagent_codex')
  455. await writeFile(preset.path, enablePresetTool(original, 'tool-subagent-codex'))
  456. const later = await productCtx.agents.create({
  457. sessionId: SessionId('preset-product-generation-later'),
  458. setup: agentCtx => productCtx.agentPresets.mount(agentCtx, 'products-none').then(() => undefined),
  459. })
  460. try {
  461. expect(toolNames(productCtx, existing.agent)).not.toContain('subagent_codex')
  462. expect(toolNames(productCtx, later.agent)).toContain('subagent_codex')
  463. } finally {
  464. await later.dispose()
  465. }
  466. } finally {
  467. await existing.dispose()
  468. await writeFile(preset.path, original)
  469. }
  470. })
  471. })
  472. describe('a switch survives the session', () => {
  473. it('records the choice so the log states what the agent runs', async () => {
  474. const handle = await ctx.agents.create({
  475. sessionId: SessionId('preset-switch-logged'),
  476. meta: { agentPreset: 'standard' },
  477. setup: agentCtx => ctx.agentPresets.mount(agentCtx, 'standard').then(() => undefined),
  478. })
  479. try {
  480. // The api-proxy's select does exactly this pair while the session is blank.
  481. await ctx.agentPresets.recompose(handle.agent.ctx, 'minimal')
  482. handle.agent.session.append('agent-preset/selected', { agentPreset: 'minimal' })
  483. // The header keeps the creation fact; the log carries what it runs.
  484. expect(handle.agent.session.header.agentPreset).toBe('standard')
  485. expect(resolveSessionPreset(handle.agent.session)).toBe('minimal')
  486. } finally {
  487. await handle.dispose()
  488. }
  489. })
  490. it('rebuilds a switched session from the log, not the creation header', () => {
  491. // The exact shape a resume reads back from disk: the header says standard,
  492. // the log records the switch the user made while the session was blank.
  493. const rebuilt = resolveSessionPreset({
  494. header: { version: 0, id: SessionId('x'), createdAt: 0, agentPreset: 'standard' },
  495. events: [
  496. { type: 'agent-preset/selected', seq: 1, time: 0, data: { agentPreset: 'minimal' } },
  497. { type: 'turn/start', seq: 2, time: 0, data: { turn: 0, trigger: { kind: 'message', source: { kind: 'user' } } } },
  498. ] as never,
  499. })
  500. // Reading the header alone would compose the creation-time preset over a
  501. // history another one produced — the replay the blank-only lock prevents.
  502. expect(rebuilt).toBe('minimal')
  503. })
  504. })
  505. describe('a forked session', () => {
  506. it('inherits the composition its seeded history was produced under', async () => {
  507. const parent = await ctx.agents.create({
  508. sessionId: SessionId('preset-fork-parent'),
  509. meta: { agentPreset: 'minimal' },
  510. setup: agentCtx => ctx.agentPresets.mount(agentCtx, 'minimal').then(() => undefined),
  511. })
  512. const inherited = resolveSessionPreset(parent.agent.session)
  513. const child = await ctx.agents.create({
  514. sessionId: SessionId('preset-fork-child'),
  515. meta: {
  516. parentSession: SessionId('preset-fork-parent'),
  517. seedLength: 0,
  518. ...inherited === undefined ? {} : { agentPreset: inherited },
  519. },
  520. setup: agentCtx => ctx.agentPresets.mount(agentCtx, inherited).then(() => undefined),
  521. })
  522. try {
  523. // Composing nothing would leave the child empty: this layer moved every
  524. // model-facing row out of the host plane, so there is nothing to inherit
  525. // for free any more.
  526. expect(toolNames(ctx, child.agent)).toEqual(toolNames(ctx, parent.agent))
  527. expect(toolNames(ctx, child.agent).length).toBeGreaterThan(0)
  528. } finally {
  529. await child.dispose()
  530. await parent.dispose()
  531. }
  532. })
  533. })
  534. describe('a delegated child', () => {
  535. it('runs on the composition its parent runs on', async () => {
  536. const parent = await ctx.agents.create({
  537. sessionId: SessionId('preset-child-parent'),
  538. meta: { agentPreset: 'standard' },
  539. setup: agentCtx => ctx.agentPresets.mount(agentCtx, 'standard').then(() => undefined),
  540. })
  541. // Exactly what an in-process subagent driver's creation window does.
  542. const child = await parent.agent.ctx.agents.create({
  543. sessionId: SessionId('preset-child'),
  544. meta: childSessionMeta(parent.agent, 1, 0),
  545. setup: (agentCtx) => {
  546. applyChildComposition(agentCtx, parent.agent, {})
  547. },
  548. })
  549. try {
  550. expect(toolNames(ctx, child.agent)).toEqual(toolNames(ctx, parent.agent))
  551. // The shipped `standard` preset is the whole coding agent; an empty
  552. // child here is the defect, and equality alone would not catch it.
  553. expect(toolNames(ctx, child.agent)).toContain('bash')
  554. expect(child.agent.session.header.agentPreset).toBe('standard')
  555. } finally {
  556. await child.dispose()
  557. await parent.dispose()
  558. }
  559. })
  560. it('follows a parent that switched preset while blank', async () => {
  561. const parent = await ctx.agents.create({
  562. sessionId: SessionId('preset-child-switch-parent'),
  563. meta: { agentPreset: 'standard' },
  564. setup: agentCtx => ctx.agentPresets.mount(agentCtx, 'standard').then(() => undefined),
  565. })
  566. await ctx.agentPresets.recompose(parent.agent.ctx, 'minimal')
  567. const child = await parent.agent.ctx.agents.create({
  568. sessionId: SessionId('preset-child-switch'),
  569. meta: childSessionMeta(parent.agent, 1, 0),
  570. setup: (agentCtx) => {
  571. applyChildComposition(agentCtx, parent.agent, {})
  572. },
  573. })
  574. try {
  575. // The live scope chain is the authority, not the parent's creation
  576. // header — which still names `standard`.
  577. expect(toolNames(ctx, child.agent)).toEqual(toolNames(ctx, parent.agent))
  578. expect(child.agent.session.header.agentPreset).toBe('minimal')
  579. } finally {
  580. await child.dispose()
  581. await parent.dispose()
  582. }
  583. })
  584. })
  585. describe('authoring a preset on the shipped composition', () => {
  586. let authorCtx: Context
  587. let userRoot: string
  588. beforeAll(async () => {
  589. userRoot = join(await mkdtemp(join(tmpdir(), 'dsh-preset-authoring-')), 'profiles')
  590. const settingsFile = join(await mkdtemp(join(tmpdir(), 'dsh-preset-authoring-settings-')), 'settings.yaml')
  591. await writeFile(settingsFile, '{}\n')
  592. authorCtx = await bootWeb(settingsFile, [{
  593. id: 'agent-presets',
  594. config: {
  595. default: 'standard',
  596. roots: [
  597. { path: join(CONFIG_DIR, 'agent-presets'), trust: 'system' },
  598. // The root does not exist yet: a deployment whose user has authored
  599. // nothing is the normal first-run state.
  600. { path: userRoot, trust: 'user' },
  601. ],
  602. },
  603. }])
  604. })
  605. it('refuses to copy over or delete a shipped preset', async () => {
  606. await expect(authorCtx.agentPresets.copy('minimal', 'standard')).rejects.toThrow(/already exists/)
  607. await expect(authorCtx.agentPresets.remove('standard')).rejects.toThrow(/ships with the deployment/)
  608. })
  609. it.each(['../escape', 'a/b', '/abs', 'Upper'])('refuses the uncontainable id %j', async (id) => {
  610. // The id becomes a directory name under the user root, so containment is
  611. // checked on the id rather than on the joined path afterwards.
  612. await expect(authorCtx.agentPresets.copy('minimal', id)).rejects.toThrow()
  613. })
  614. it('copies a shipped preset a session then really composes from', async () => {
  615. await authorCtx.agentPresets.copy('minimal', 'my-agent', '我的模式')
  616. // Round-trips through the roster as a `user` row carrying the given name
  617. // and the source's description, over the source's own composition text.
  618. const preset = await authorCtx.agentPresets.resolve('my-agent')
  619. const source = await authorCtx.agentPresets.resolve('minimal')
  620. expect(preset.trust).toBe('user')
  621. expect(preset.name).toBe('我的模式')
  622. expect(preset.description).toBe(source.description)
  623. expect(await authorCtx.agentPresets.read('my-agent')).toBe(await authorCtx.agentPresets.read('minimal'))
  624. // Owner-only, in an owner-only directory: a composition is executable
  625. // configuration on a machine that may have other users.
  626. expect((await stat(preset.path)).mode & 0o777).toBe(0o600)
  627. const handle = await authorCtx.agents.create({
  628. sessionId: SessionId('preset-authored'),
  629. setup: agentCtx => authorCtx.agentPresets.mount(agentCtx, 'my-agent').then(() => undefined),
  630. })
  631. try {
  632. // The same tools the shipped `minimal` composes, from a directory copied
  633. // through the service into a root outside the installed harness.
  634. expect(toolNames(authorCtx, handle.agent)).toEqual(['bash', 'str_replace_editor'])
  635. } finally {
  636. await handle.dispose()
  637. }
  638. })
  639. it('deletes what it copied', async () => {
  640. await authorCtx.agentPresets.copy('minimal', 'doomed')
  641. await authorCtx.agentPresets.remove('doomed')
  642. expect((await authorCtx.agentPresets.list()).map(preset => preset.id)).not.toContain('doomed')
  643. })
  644. })
  645. /**
  646. * Which preset an unnamed session gets is a user setting layered over the
  647. * composition's own default. The package suite proves the layering against a
  648. * hand-built context; this proves it through the shipped `cordis.yml` — that
  649. * the roster and the settings provider are actually wired to each other, and
  650. * that the id the setting names is the one a session composes from.
  651. */
  652. describe('the default preset as a user setting', () => {
  653. it('composes an unnamed session from the stored default, not the composed one', async () => {
  654. expect(ctx.agentPresets.defaultId).toBe('standard')
  655. await ctx.settings.update(settingsNamespace(SETTINGS_NAMESPACE), { default: 'minimal' })
  656. try {
  657. expect(ctx.agentPresets.defaultId).toBe('minimal')
  658. const handle = await ctx.agents.create({
  659. sessionId: SessionId('preset-user-default'),
  660. setup: agentCtx => ctx.agentPresets.mount(agentCtx).then(() => undefined),
  661. })
  662. try {
  663. // `mount()` with no id resolves the effective default. Two tools, not
  664. // `standard`'s catalog: the setting decided the composition.
  665. expect(toolNames(ctx, handle.agent)).toEqual(['bash', 'str_replace_editor'])
  666. } finally {
  667. await handle.dispose()
  668. }
  669. } finally {
  670. // The context is shared with the rest of the file. `replace({})` drops
  671. // the user section wholesale so the field re-inherits the composition
  672. // base; `update` merges, and would leave the override standing.
  673. await ctx.settings.replace(settingsNamespace(SETTINGS_NAMESPACE), {})
  674. }
  675. expect(ctx.agentPresets.defaultId).toBe('standard')
  676. })
  677. })
  678. describe('a session keeps the preset it was created with', () => {
  679. it('refuses to adopt a live session under a different preset', async () => {
  680. const handle = await ctx.agents.create({
  681. sessionId: SessionId('preset-locked'),
  682. meta: { agentPreset: 'minimal' },
  683. setup: agentCtx => ctx.agentPresets.mount(agentCtx, 'minimal').then(() => undefined),
  684. })
  685. try {
  686. // The api-proxy guard reads exactly this: the header records what the
  687. // session runs, so naming anything else is a caller error rather than a
  688. // switch. Its history was produced under `minimal`'s two tools.
  689. expect(handle.agent.session.header.agentPreset).toBe('minimal')
  690. } finally {
  691. await handle.dispose()
  692. }
  693. })
  694. })