deepseek-harness/apps/desktop/tests/package-macos.spec.ts

/** Exercise notarization overlap and artifact isolation without Apple credentials or network. */

import { cp, mkdir, mkdtemp, readFile, readdir, rm, writeFile } from 'node:fs/promises'
import { existsSync } from 'node:fs'
import { tmpdir } from 'node:os'
import { dirname, join } from 'node:path'
import { describe, expect, it, vi } from 'vitest'
import {
  packageMacOSArtifacts,
  type DesktopPrepackagedArtifact,
  type MacOSArtifactOperations,
} from '../scripts/package-macos.ts'
import { desktopElectronBuilderArguments, resolveDesktopPackageTarget } from '../scripts/package-target.ts'

const environment = {
  DSH_DESKTOP_MACOS_SIGNING_IDENTITY: 'Example Company (TEAMID1234)',
  DSH_DESKTOP_MACOS_TEAM_ID: 'TEAMID1234',
  APPLE_KEYCHAIN_PROFILE: 'fixture-profile',
}

function barrier() {
  let release!: () => void
  const promise = new Promise<void>((resolve) => { release = resolve })
  return { promise, release }
}

async function fixture(arch: 'arm64' | 'x64' = 'arm64') {
  const root = await mkdtemp(join(tmpdir(), 'desktop-parallel-notarization-'))
  const artifactsRoot = join(root, 'artifacts')
  const appPath = join(artifactsRoot, arch === 'arm64' ? 'mac-arm64' : 'mac', 'DeepSeek Harness.app')
  await mkdir(appPath, { recursive: true })
  await writeFile(join(appPath, 'payload'), 'signed content')
  const version = '1.2.3-alpha.1'
  const base = `deepseek-harness-${version}-mac-${arch}`
  const request = { arch, artifactsRoot, version, environment }
  const apple: MacOSArtifactOperations = {
    copyApp: async (source, destination) => {
      await cp(source, destination, { recursive: true, verbatimSymlinks: true })
    },
    notarize: async ({ appPath: path }) => { await writeFile(join(path, 'ticket'), 'accepted') },
    verifySignature: vi.fn(),
    verifyNotarization: vi.fn((path: string) => {
      if (!existsSync(join(path, 'ticket'))) throw new Error('missing App ticket')
    }),
  }
  const build = async (artifact: DesktopPrepackagedArtifact) => {
    await mkdir(artifact.output, { recursive: true })
    const contents = JSON.stringify({
      payload: await readFile(join(artifact.appPath, 'payload'), 'utf8'),
      appTicket: existsSync(join(artifact.appPath, 'ticket')),
    })
    await writeFile(join(artifact.output, `${base}.${artifact.format}`), contents)
    if (artifact.format === 'zip') {
      await writeFile(join(artifact.output, `${base}.zip.blockmap`), 'blockmap')
      await writeFile(join(artifact.output, 'alpha-mac.yml'), 'update metadata')
    }
  }
  return { root, appPath, request, apple, build, base }
}

describe('parallel macOS artifacts', () => {
  it.each(['arm64', 'x64'] as const)('overlaps notarization on isolated %s copies and promotes only completed payloads', async (arch) => {
    const f = await fixture(arch)
    const appStarted = barrier()
    const appAccepted = barrier()
    const dmgCompleted = barrier()
    const zipCompleted = barrier()
    const starts: string[] = []
    const copies: string[] = []
    const operation = packageMacOSArtifacts(f.request, async (artifact) => {
      starts.push(artifact.format)
      if (artifact.format === 'dmg') await dmgCompleted.promise
      await f.build(artifact)
      if (artifact.format === 'zip') zipCompleted.release()
    }, {
      ...f.apple,
      copyApp: async (source, destination) => {
        copies.push(destination)
        await f.apple.copyApp(source, destination)
      },
      notarize: async (options) => {
        starts.push('app')
        appStarted.release()
        await appAccepted.promise
        await f.apple.notarize(options)
      },
    })
    try {
      await appStarted.promise
      await vi.waitFor(() => { expect([...starts]).toEqual(expect.arrayContaining(['app', 'dmg'])) })
      expect(new Set(copies).size).toBe(2)
      expect(copies.every(path => path !== f.appPath)).toBe(true)
      appAccepted.release()
      await zipCompleted.promise
      expect(existsSync(join(f.appPath, 'ticket'))).toBe(false)
      expect(existsSync(join(f.request.artifactsRoot, `${f.base}.zip`))).toBe(false)
      dmgCompleted.release()
      await operation
      expect(JSON.parse(await readFile(join(f.request.artifactsRoot, `${f.base}.zip`), 'utf8')))
        .toEqual({ payload: 'signed content', appTicket: true })
      expect(JSON.parse(await readFile(join(f.request.artifactsRoot, `${f.base}.dmg`), 'utf8')))
        .toEqual({ payload: 'signed content', appTicket: false })
      expect(await readFile(join(f.appPath, 'ticket'), 'utf8')).toBe('accepted')
      expect((await readdir(f.root)).sort()).toEqual(['artifacts'])
      expect(f.apple.verifySignature).toHaveBeenCalledTimes(2)
      expect(f.apple.verifyNotarization).toHaveBeenCalledTimes(1)
    } finally {
      appAccepted.release()
      dmgCompleted.release()
      await Promise.allSettled([operation])
      await rm(f.root, { recursive: true, force: true })
    }
  })

  it('collects both failures after both lanes release their copies and publishes neither payload', async () => {
    const f = await fixture()
    const appStarted = barrier()
    const failApp = barrier()
    const failDmg = barrier()
    const appError = new Error('App rejected')
    const dmgError = new Error('DMG rejected')
    const released: string[] = []
    const outcome = packageMacOSArtifacts(f.request, async (artifact) => {
      expect(artifact.format).toBe('dmg')
      await failDmg.promise
      expect(await readFile(join(artifact.appPath, 'payload'), 'utf8')).toBe('signed content')
      released.push('dmg')
      throw dmgError
    }, {
      ...f.apple,
      notarize: async () => {
        appStarted.release()
        await failApp.promise
        released.push('app')
        throw appError
      },
    }).catch((error: unknown) => error)
    try {
      await appStarted.promise
      failApp.release()
      failDmg.release()
      const error = await outcome
      expect(error).toBeInstanceOf(AggregateError)
      expect((error as AggregateError).errors).toEqual([appError, dmgError])
      expect(released.sort()).toEqual(['app', 'dmg'])
      expect(await readdir(f.root)).toEqual(['artifacts'])
      expect(await readdir(f.request.artifactsRoot)).toEqual(['mac-arm64'])
      expect(existsSync(join(f.appPath, 'ticket'))).toBe(false)
    } finally {
      failApp.release()
      failDmg.release()
      await outcome
      await rm(f.root, { recursive: true, force: true })
    }
  })

  it.each(['copy', 'signature', 'ticket', 'metadata'] as const)('rejects incomplete %s qualification without promoting artifacts', async (failure) => {
    const f = await fixture()
    try {
      const apple: MacOSArtifactOperations = {
        ...f.apple,
        ...(failure === 'copy' ? { copyApp: async () => { throw new Error('copy failed') } } : {}),
        ...(failure === 'signature' ? { verifySignature: () => { throw new Error('signature failed') } } : {}),
        ...(failure === 'ticket' ? { verifyNotarization: () => { throw new Error('ticket failed') } } : {}),
      }
      await expect(packageMacOSArtifacts(f.request, async (artifact) => {
        await f.build(artifact)
        if (failure === 'metadata' && artifact.format === 'zip') {
          await writeFile(join(artifact.output, 'alpha-mac.yml'), '')
        }
      }, apple)).rejects.toThrow()
      expect(await readdir(f.root)).toEqual(['artifacts'])
      expect(await readdir(f.request.artifactsRoot)).toEqual(['mac-arm64'])
    } finally { await rm(f.root, { recursive: true, force: true }) }
  })

  it('passes the actual App and isolated output directory to each single-target builder', () => {
    const target = resolveDesktopPackageTarget('mac-arm64', 'darwin', 'arm64')
    for (const format of ['zip', 'dmg'] as const) {
      const appPath = join('private build', format, 'DeepSeek Harness.app')
      const output = join(dirname(appPath), 'artifacts')
      expect(desktopElectronBuilderArguments(target, false, { format, appPath, output })).toEqual([
        'exec', 'electron-builder', '--config', 'electron-builder.config.mjs',
        '--mac', format, '--arm64', '--publish', 'never',
        '--config.mac.notarize=false',
        '--prepackaged', appPath, '--config.directories.output', output,
      ])
    }
  })
})