search.spec.ts 14 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320
  1. import { chmod, mkdir, mkdtemp, rm, symlink, writeFile } from 'node:fs/promises'
  2. import { tmpdir } from 'node:os'
  3. import { join } from 'node:path'
  4. import { afterEach, describe, expect, it, vi } from 'vitest'
  5. import {
  6. activeAtToken,
  7. DEFAULT_FILE_SEARCH_EXCLUDED_DIRECTORIES,
  8. formatFileMention,
  9. WorkspaceFileSearch,
  10. } from '../src/search.ts'
  11. const fsControl = vi.hoisted(() => ({
  12. /** Absolute path whose `readdir` rejects; the injectable stand-in for chmod 0. */
  13. denyReaddir: undefined as string | undefined,
  14. }))
  15. vi.mock('node:fs/promises', async (importOriginal) => {
  16. const actual = await importOriginal<typeof import('node:fs/promises')>()
  17. return {
  18. ...actual,
  19. readdir: (async (path: unknown, ...rest: never[]) => {
  20. if (fsControl.denyReaddir !== undefined && String(path) === fsControl.denyReaddir) {
  21. throw Object.assign(new Error('EACCES: injected unreadable directory'), { code: 'EACCES' })
  22. }
  23. return (actual.readdir as (path: unknown, ...args: never[]) => Promise<unknown>)(path, ...rest)
  24. }) as typeof actual.readdir,
  25. }
  26. })
  27. const searches: WorkspaceFileSearch[] = []
  28. const roots: string[] = []
  29. /** Permission-stripped directories; restored before cleanup can remove them. */
  30. const locks: string[] = []
  31. async function workspace(): Promise<string> {
  32. const root = await mkdtemp(join(tmpdir(), 'dsh-file-autocomplete-'))
  33. roots.push(root)
  34. await mkdir(join(root, 'src'), { recursive: true })
  35. await mkdir(join(root, 'docs'), { recursive: true })
  36. await mkdir(join(root, '.hidden'), { recursive: true })
  37. await mkdir(join(root, 'node_modules', 'ignored-package'), { recursive: true })
  38. await writeFile(join(root, 'README.md'), 'readme')
  39. await writeFile(join(root, 'src', 'tui.spec.ts'), 'test')
  40. await writeFile(join(root, 'src', 'terminal-view.ts'), 'view')
  41. await writeFile(join(root, 'docs', 'design notes.md'), 'design')
  42. await writeFile(join(root, '.hidden', 'secret.txt'), 'hidden')
  43. await writeFile(join(root, 'node_modules', 'ignored-package', 'index.js'), 'ignored')
  44. try {
  45. await symlink(join(root, 'src', 'tui.spec.ts'), join(root, 'linked-test.ts'))
  46. } catch {
  47. // Windows may deny symlink creation without Developer Mode; the product
  48. // still skips every non-file/non-directory Dirent on platforms that expose one.
  49. }
  50. return root
  51. }
  52. function search(root: string, overrides: Partial<ConstructorParameters<typeof WorkspaceFileSearch>[1]> = {}): WorkspaceFileSearch {
  53. const instance = new WorkspaceFileSearch(root, {
  54. maxResults: overrides.maxResults ?? 20,
  55. maxEntries: overrides.maxEntries ?? 10_000,
  56. excludedDirectories: overrides.excludedDirectories ?? ['.git', 'node_modules'],
  57. })
  58. searches.push(instance)
  59. return instance
  60. }
  61. afterEach(async () => {
  62. for (const locked of locks.splice(0)) await chmod(locked, 0o700).catch(() => undefined)
  63. for (const instance of searches.splice(0)) instance.dispose()
  64. await Promise.all(roots.splice(0).map(root => rm(root, { recursive: true, force: true })))
  65. })
  66. describe('file-reference grammar', () => {
  67. it('recognizes boundary and quoted mentions without treating emails as references', () => {
  68. expect(activeAtToken('@src/tu', 7)).toEqual({ prefix: '@src/tu', query: 'src/tu', quoted: false })
  69. expect(activeAtToken('read @"docs/design n', 20)).toEqual({
  70. prefix: '@"docs/design n',
  71. query: 'docs/design n',
  72. quoted: true,
  73. })
  74. expect(activeAtToken('mail a@b.test', 13)).toBeUndefined()
  75. expect(activeAtToken('done @src/x" next', 17)).toBeUndefined()
  76. })
  77. it('formats files, directories, quotes, and rejects unsafe editor values', () => {
  78. expect(formatFileMention({ path: 'src/index.ts', kind: 'file' }, false)).toBe('@src/index.ts')
  79. expect(formatFileMention({ path: 'src', kind: 'directory' }, false)).toBe('@src/')
  80. expect(formatFileMention({ path: 'docs/design notes.md', kind: 'file' }, false))
  81. .toBe('@"docs/design notes.md"')
  82. expect(formatFileMention({ path: 'docs/design notes', kind: 'directory' }, false))
  83. .toBe('@"docs/design notes/')
  84. expect(formatFileMention({ path: 'README.md', kind: 'file' }, true)).toBe('@"README.md"')
  85. expect(formatFileMention({ path: 'bad\nname', kind: 'file' }, false)).toBeUndefined()
  86. expect(formatFileMention({ path: 'bad "name".md', kind: 'file' }, false)).toBeUndefined()
  87. expect(formatFileMention({ path: 'bad"name.md', kind: 'file' }, false)).toBeUndefined()
  88. })
  89. })
  90. describe('WorkspaceFileSearch', () => {
  91. it('lists live directory levels, descends, quotes spaces, and filters hidden/excluded entries', async () => {
  92. const root = await workspace()
  93. const files = search(root)
  94. const signal = new AbortController().signal
  95. expect(await files.list('', signal)).toEqual([
  96. { path: 'docs', kind: 'directory' },
  97. { path: 'src', kind: 'directory' },
  98. { path: 'README.md', kind: 'file' },
  99. ])
  100. expect(await files.list('src/', signal)).toEqual([
  101. { path: 'src/terminal-view.ts', kind: 'file' },
  102. { path: 'src/tui.spec.ts', kind: 'file' },
  103. ])
  104. expect(await files.list('src/ts', signal)).toEqual([
  105. { path: 'src/tui.spec.ts', kind: 'file' },
  106. { path: 'src/terminal-view.ts', kind: 'file' },
  107. ])
  108. expect(await files.list('docs/design n', signal)).toEqual([
  109. { path: 'docs/design notes.md', kind: 'file' },
  110. ])
  111. expect(await files.list('node_modules/', signal)).toEqual([])
  112. expect(await files.list('.hidden/', signal)).toEqual([
  113. { path: '.hidden/secret.txt', kind: 'file' },
  114. ])
  115. const absoluteSrc = `${join(root, 'src').replaceAll('\\', '/')}/`
  116. expect(await files.list(`${absoluteSrc}tui`, signal)).toEqual([
  117. { path: `${absoluteSrc}tui.spec.ts`, kind: 'file' },
  118. { path: `${absoluteSrc}terminal-view.ts`, kind: 'file' },
  119. ])
  120. expect(await files.list('~/.dsh-file-autocomplete-missing/', signal)).toEqual([])
  121. expect(await files.list('../', signal)).toEqual([])
  122. expect(await files.list('README.md/', signal)).toEqual([])
  123. })
  124. it('does not traverse directory symlinks during direct completion', async () => {
  125. const root = await workspace()
  126. const outside = await mkdtemp(join(tmpdir(), 'dsh-file-autocomplete-outside-'))
  127. roots.push(outside)
  128. await writeFile(join(outside, 'outside-secret.txt'), 'secret')
  129. await symlink(
  130. outside,
  131. join(root, 'escape'),
  132. process.platform === 'win32' ? 'junction' : 'dir',
  133. )
  134. const files = search(root)
  135. const signal = new AbortController().signal
  136. expect(await files.list('escape/', signal)).toEqual([])
  137. expect(await files.list('escape/outside', signal)).toEqual([])
  138. })
  139. it('ranks basename and subsequence fuzzy matches across the bounded workspace index', async () => {
  140. const root = await workspace()
  141. await writeFile(join(root, 'src', 'tspc-helper.ts'), 'helper')
  142. const files = search(root, { maxResults: 2 })
  143. const signal = new AbortController().signal
  144. expect(await files.list('tspc', signal)).toEqual([
  145. { path: 'src/tspc-helper.ts', kind: 'file' },
  146. { path: 'src/tui.spec.ts', kind: 'file' },
  147. ])
  148. expect(await files.list('README.md', signal)).toEqual([
  149. { path: 'README.md', kind: 'file' },
  150. ])
  151. expect(await files.list('terminal', signal)).toEqual([
  152. { path: 'src/terminal-view.ts', kind: 'file' },
  153. ])
  154. expect(await files.list('secret', signal)).toEqual([])
  155. expect(await files.list('.hidden', signal)).toEqual([
  156. { path: '.hidden', kind: 'directory' },
  157. { path: '.hidden/secret.txt', kind: 'file' },
  158. ])
  159. })
  160. it('serves an invalidated index while its replacement builds, then swaps it in', async () => {
  161. const root = await workspace()
  162. const files = search(root)
  163. const signal = new AbortController().signal
  164. expect(await files.list('fresh-file', signal)).toEqual([])
  165. await writeFile(join(root, 'fresh-file.ts'), 'fresh')
  166. // No invalidation: the settled traversal is still the answer.
  167. expect(await files.list('fresh-file', signal)).toEqual([])
  168. files.invalidate()
  169. // The stale entries answer this query; the rebuild runs behind the caret.
  170. expect(await files.list('fresh-file', signal)).toEqual([])
  171. await vi.waitFor(async () => {
  172. expect(await files.list('fresh-file', signal)).toEqual([
  173. { path: 'fresh-file.ts', kind: 'file' },
  174. ])
  175. })
  176. files.dispose()
  177. expect(await files.list('fresh-file', signal)).toEqual([])
  178. files.dispose()
  179. })
  180. it('keeps the stale entries when the workspace root is unreadable, and retries once it returns', async () => {
  181. const root = await workspace()
  182. const files = search(root)
  183. const signal = new AbortController().signal
  184. expect(await files.list('README', signal)).toEqual([{ path: 'README.md', kind: 'file' }])
  185. // A root that vanishes under a live index: an unreadable branch costs its
  186. // own candidates, but an unreadable root must not be published as an
  187. // empty workspace over entries that are still good.
  188. await rm(root, { recursive: true, force: true })
  189. files.invalidate()
  190. expect(await files.list('README', signal)).toEqual([{ path: 'README.md', kind: 'file' }])
  191. await new Promise((resolve) => { setTimeout(resolve, 50) })
  192. expect(await files.list('README', signal)).toEqual([{ path: 'README.md', kind: 'file' }])
  193. // The failed attempt left the index stale, so its return is picked up
  194. // without waiting for another invalidation.
  195. await mkdir(root, { recursive: true })
  196. await writeFile(join(root, 'restored.ts'), 'restored')
  197. await vi.waitFor(async () => {
  198. expect(await files.list('restored', signal)).toEqual([{ path: 'restored.ts', kind: 'file' }])
  199. })
  200. })
  201. // chmod 0 can only deny directory reads on POSIX to a non-root owner:
  202. // Windows exposes no directory permission bits for readdir, and root
  203. // bypasses them. Where the fixture stays readable the sealed candidate is
  204. // indexed, so the unreadable-branch behavior is pinned on POSIX non-root.
  205. it.runIf(
  206. process.getuid !== undefined && process.getuid() !== 0,
  207. )('lets an unreadable subtree cost only its own candidates', async () => {
  208. const root = await workspace()
  209. const locked = join(root, 'locked')
  210. await mkdir(locked, { recursive: true })
  211. await writeFile(join(locked, 'sealed.ts'), 'sealed')
  212. await chmod(locked, 0o000)
  213. locks.push(locked)
  214. const files = search(root)
  215. const signal = new AbortController().signal
  216. // The branch itself yields nothing, and the rest of the tree still does.
  217. expect(await files.list('sealed', signal)).toEqual([])
  218. expect(await files.list('README', signal)).toEqual([{ path: 'README.md', kind: 'file' }])
  219. // The directory is still offered: only reading through it fails.
  220. expect(await files.list('locked', signal)).toEqual([{ path: 'locked', kind: 'directory' }])
  221. })
  222. // The chmod-0 fixture above cannot be built on Windows (no directory
  223. // permission bits) or as root (bits are bypassed). An injected readdir
  224. // failure keeps the unreadable-branch behavior covered on every platform.
  225. it('lets an injected readdir failure cost only its own candidates', async () => {
  226. const root = await workspace()
  227. const locked = join(root, 'locked')
  228. await mkdir(locked, { recursive: true })
  229. await writeFile(join(locked, 'sealed.ts'), 'sealed')
  230. fsControl.denyReaddir = locked
  231. try {
  232. const files = search(root)
  233. const signal = new AbortController().signal
  234. // The branch itself yields nothing, and the rest of the tree still does.
  235. expect(await files.list('sealed', signal)).toEqual([])
  236. expect(await files.list('README', signal)).toEqual([{ path: 'README.md', kind: 'file' }])
  237. // The directory is still offered: only reading through it fails.
  238. expect(await files.list('locked', signal)).toEqual([{ path: 'locked', kind: 'directory' }])
  239. } finally {
  240. fsControl.denyReaddir = undefined
  241. }
  242. })
  243. it('enforces the entry cap', async () => {
  244. const root = await workspace()
  245. const capped = search(root, { maxEntries: 2 })
  246. expect(await capped.list('README', new AbortController().signal)).toEqual([
  247. { path: 'README.md', kind: 'file' },
  248. ])
  249. })
  250. it('never traverses an excluded build output, so generated twins cannot outrank sources', async () => {
  251. const root = await workspace()
  252. await mkdir(join(root, 'dist'), { recursive: true })
  253. await writeFile(join(root, 'dist', 'terminal-view.js'), 'built')
  254. const files = search(root, { excludedDirectories: [...DEFAULT_FILE_SEARCH_EXCLUDED_DIRECTORIES] })
  255. expect(await files.list('terminal-view', new AbortController().signal)).toEqual([
  256. { path: 'src/terminal-view.ts', kind: 'file' },
  257. ])
  258. expect(await files.list('dist/', new AbortController().signal)).toEqual([])
  259. })
  260. it('still offers a `lib` tree, where several ecosystems keep their sources', async () => {
  261. const root = await workspace()
  262. await mkdir(join(root, 'lib'), { recursive: true })
  263. await writeFile(join(root, 'lib', 'gem-entry.rb'), 'source')
  264. const files = search(root, { excludedDirectories: [...DEFAULT_FILE_SEARCH_EXCLUDED_DIRECTORIES] })
  265. expect(await files.list('gem-entry', new AbortController().signal)).toEqual([
  266. { path: 'lib/gem-entry.rb', kind: 'file' },
  267. ])
  268. })
  269. it('cancels individual callers, skips missing directories, and validates limits', async () => {
  270. const root = await workspace()
  271. expect(() => search(root, { maxResults: 0 })).toThrow('maxResults')
  272. expect(() => search(root, { maxEntries: 1.5 })).toThrow('maxEntries')
  273. expect(() => search(root, { excludedDirectories: ['nested/name'] })).toThrow('basenames')
  274. const files = search(root)
  275. expect(await files.list('missing/', new AbortController().signal)).toEqual([])
  276. const preAborted = new AbortController()
  277. preAborted.abort(new Error('pre-aborted'))
  278. await expect(files.list('tui', preAborted.signal)).rejects.toThrow('pre-aborted')
  279. files.invalidate()
  280. const running = new AbortController()
  281. const pending = files.list('tui', running.signal)
  282. running.abort(new Error('superseded'))
  283. await expect(pending).rejects.toThrow('superseded')
  284. files.invalidate()
  285. const nonErrorAbort = new AbortController()
  286. const nonErrorPending = files.list('tui', nonErrorAbort.signal)
  287. nonErrorAbort.abort('cancelled')
  288. await expect(nonErrorPending).rejects.toThrow('file search aborted')
  289. })
  290. })