verify-package-readme-model-experience.ts 21 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392
  1. /**
  2. * Doc-sync gate for package README Model Experience sections. It validates
  3. * audited package classifications, context-surface fields, package-owned text
  4. * blocks, generated-catalog links, and final-section order. See the
  5. * [Model Experience RFC](../docs/rfc/implemented/process/2026-07-12-package-model-experience-contract.md).
  6. */
  7. import { existsSync, globSync, readFileSync } from 'node:fs'
  8. import { relative, resolve } from 'node:path'
  9. import { markdownHeadingLines, markdownProseLines, type MarkdownProseLine } from './markdown.ts'
  10. const root = resolve(import.meta.dirname, '..')
  11. const HEADING = '## Model Experience'
  12. const LIMITATIONS_HEADING = '## Known Limitations and Deferred Work'
  13. const MODEL_VIEW_LABEL = '**What the model sees**'
  14. const TOKEN_EFFECT_LABEL = '**Token effect**'
  15. type SentenceKind = 'none' | 'indirect'
  16. interface SentenceContract {
  17. kind: SentenceKind
  18. reason: string
  19. }
  20. /**
  21. * Generic packages whose public contract is model-agnostic. Their READMEs omit
  22. * Model Experience entirely; the reason stays here as reviewable audit evidence
  23. * so an absent section cannot be mistaken for forgotten documentation.
  24. */
  25. const NO_MODEL_EXPERIENCE_SECTION: Readonly<Record<string, string>> = {
  26. 'packages/core/scope': 'The package is a model-agnostic registration and lifecycle primitive; model-facing consumers own any context selection.',
  27. 'packages/util/brand': 'The package is a type-only primitive erased at compile time.',
  28. }
  29. /**
  30. * Packages whose Model Experience is simple enough for one gated sentence.
  31. * Every other package must carry canonical context-surface blocks. A package
  32. * moves on or off this list with the change to its context behavior.
  33. */
  34. const SENTENCE_MODEL_EXPERIENCE: Readonly<Record<string, SentenceContract>> = {
  35. 'packages/bash/bash': { kind: 'indirect', reason: 'The service interface delegates all model rendering to dsh-tool-bash.' },
  36. 'packages/bash/bash-local': { kind: 'indirect', reason: 'The executor backend delegates model rendering to dsh-tool-bash.' },
  37. 'packages/code-runtime/code-runtime': { kind: 'indirect', reason: 'The service interface delegates model rendering to Code Mode in dsh-tools.' },
  38. 'packages/code-runtime/code-runtime-worker': { kind: 'indirect', reason: 'The worker backend delegates model rendering to Code Mode in dsh-tools.' },
  39. 'packages/core/agent-core': { kind: 'indirect', reason: 'The bundle only mounts model-facing child plugins.' },
  40. 'packages/fs/fs': { kind: 'indirect', reason: 'The service interface delegates model rendering to dsh-tool-fs.' },
  41. 'packages/fs/fs-local': { kind: 'indirect', reason: 'The provider backend delegates model rendering to dsh-tool-fs.' },
  42. 'packages/hooks/hook-protocol': { kind: 'indirect', reason: 'Only the hook bridge plugins render decoded hook output to a model.' },
  43. 'packages/llm/llm': { kind: 'none', reason: 'The adapter registry forwards already-assembled requests unchanged.' },
  44. 'packages/lsp/lsp': { kind: 'indirect', reason: 'The provider registry delegates model rendering to dsh-tool-lsp.' },
  45. 'packages/lsp/lsp-local': { kind: 'indirect', reason: 'The provider backend delegates model rendering to dsh-tool-lsp.' },
  46. 'packages/sandbox/sandbox-local': { kind: 'indirect', reason: 'The provider backend delegates model rendering to dsh-bash-sandbox and dsh-tool-bash.' },
  47. 'packages/session-query/session-query': { kind: 'none', reason: 'The trusted query service exposes cloned records only to callers and registers no model surface.' },
  48. 'packages/skill/skill': { kind: 'indirect', reason: 'The provider registry delegates model rendering to dsh-tool-skill.' },
  49. 'packages/skill/skill-local': { kind: 'indirect', reason: 'The provider backend delegates model rendering to dsh-tool-skill.' },
  50. 'packages/subagent/subagent': { kind: 'indirect', reason: 'The provider registry delegates parent-model rendering to dsh-tool-subagent.' },
  51. 'packages/subagent/subagent-subprocess': { kind: 'indirect', reason: 'Only process-based subagent backends compose a child model request.' },
  52. 'packages/support/acp-snapshot': { kind: 'none', reason: 'The test harness observes and normalizes transcripts without changing live requests.' },
  53. 'packages/support/invariants': { kind: 'none', reason: 'The observer validates requests but never rewrites their context.' },
  54. 'packages/support/loader-smoke': { kind: 'none', reason: 'The test harness observes child-process streams without changing live requests.' },
  55. 'packages/support/llm-replay': { kind: 'none', reason: 'The keyless adapter invokes no provider model.' },
  56. 'packages/support/subagent-mock': { kind: 'indirect', reason: 'Only dsh-tool-subagent renders its configured test outcome.' },
  57. 'packages/ui/acp-agent': { kind: 'indirect', reason: 'The app bundle delegates request composition to dsh-agent-core and dsh-acp.' },
  58. 'packages/ui/app-boot': { kind: 'indirect', reason: 'Only the loaded plugin tree contributes model context.' },
  59. 'packages/ui/jsonrpc-agent': { kind: 'indirect', reason: 'Only the externally configured plugin tree contributes model context.' },
  60. 'packages/ui/permission': { kind: 'indirect', reason: 'The service writes mechanism events rendered by dsh-user-approval and dsh-tool-bash.' },
  61. 'packages/ui/user-interaction': { kind: 'indirect', reason: 'Model-facing consumers render provider answers and seam errors.' },
  62. 'packages/util/timeout': { kind: 'indirect', reason: 'Only timeout consumers render timeout outcomes.' },
  63. 'packages/web/web': { kind: 'indirect', reason: 'The provider registry delegates model rendering to dsh-tool-web.' },
  64. 'packages/web/web-fetch-local': { kind: 'indirect', reason: 'The provider backend delegates model rendering to dsh-tool-web.' },
  65. 'packages/web/web-search-exa': { kind: 'indirect', reason: 'The provider backend delegates model rendering to dsh-tool-web.' },
  66. 'packages/workflow/workflow': { kind: 'indirect', reason: 'The service delegates parent and child model rendering to its consumer and engine.' },
  67. }
  68. interface Failure {
  69. path: string
  70. message: string
  71. }
  72. type Line = MarkdownProseLine
  73. interface ContextSurface {
  74. heading: Line
  75. modelView: Line
  76. tokenEffect: Line
  77. title: string
  78. verbatimBlocks: number
  79. }
  80. /** Validate H4-plus-markdown literals nested after one context surface's fields. */
  81. function validateNestedVerbatim(raw: readonly string[]): { blocks: number; error?: string } {
  82. let cursor = 0
  83. while (raw[cursor]?.trim().length === 0) cursor += 1
  84. if (cursor === raw.length) return { blocks: 0 }
  85. let blocks = 0
  86. const fragments = new Set<string>()
  87. while (true) {
  88. while (raw[cursor]?.trim().length === 0) cursor += 1
  89. if (cursor === raw.length) break
  90. if (!/^#### \S/.test(raw[cursor] ?? '')) {
  91. return { blocks, error: 'content after Token effect must be a titled H4 verbatim block' }
  92. }
  93. const title = (raw[cursor] as string).slice('#### '.length)
  94. const fragment = headingFragment(title)
  95. if (fragment.length === 0) return { blocks, error: 'verbatim H4 title must be non-empty' }
  96. if (fragments.has(fragment)) {
  97. return { blocks, error: `verbatim H4 title ${JSON.stringify(title)} is duplicated within its context surface` }
  98. }
  99. fragments.add(fragment)
  100. cursor += 1
  101. while (raw[cursor]?.trim().length === 0) cursor += 1
  102. if (raw[cursor] !== '```markdown') {
  103. return { blocks, error: 'each nested verbatim H4 requires an exact ```markdown fence' }
  104. }
  105. cursor += 1
  106. const contentStart = cursor
  107. while (cursor < raw.length && raw[cursor] !== '```') cursor += 1
  108. if (cursor === raw.length) return { blocks, error: 'unterminated nested ```markdown fence' }
  109. if (cursor === contentStart) return { blocks, error: 'nested ```markdown fence must not be empty' }
  110. cursor += 1
  111. blocks += 1
  112. }
  113. return { blocks }
  114. }
  115. /** GitHub-style fragment for the simple ASCII H4 titles allowed by this contract. */
  116. function headingFragment(title: string): string {
  117. return title.toLowerCase().replaceAll('`', '').replaceAll(/[^a-z0-9 _-]/g, '').trim().replaceAll(/\s+/g, '-')
  118. }
  119. /** A direct stable system-prompt contribution, as named by the README contract. */
  120. function isDirectSystemPromptSurface(title: string): boolean {
  121. return /\bsystem prompt\b/i.test(title)
  122. }
  123. /** Anchored generated-catalog links in one model-view field. */
  124. function toolCatalogLinkFragments(text: string): string[] {
  125. return [...text.matchAll(/\]\(\.\.\/\.\.\/\.\.\/docs\/tool-catalog\.md#([a-z0-9_-]+)\)/g)]
  126. .map(match => match[1] as string)
  127. }
  128. const toolCatalogFragments = new Set<string>()
  129. for (const line of readFileSync(resolve(root, 'docs/tool-catalog.md'), 'utf8').split('\n')) {
  130. const title = /^## (.+)$/.exec(line)?.[1]
  131. if (title !== undefined) toolCatalogFragments.add(headingFragment(title))
  132. }
  133. const failures: Failure[] = []
  134. const packageJsons = globSync('packages/*/*/package.json', { cwd: root }).sort()
  135. const scannedPackages = new Set(packageJsons.map(path => path.slice(0, -'/package.json'.length)))
  136. let structuredCount = 0
  137. let contextSurfaceCount = 0
  138. let omittedSectionCount = 0
  139. let explainedNoneCount = 0
  140. let indirectCount = 0
  141. let verbatimBlockCount = 0
  142. let systemPromptSurfaceCount = 0
  143. let toolSchemaSurfaceCount = 0
  144. for (const [pkg, reason] of Object.entries(NO_MODEL_EXPERIENCE_SECTION)) {
  145. if (!scannedPackages.has(pkg)) {
  146. failures.push({ path: `${pkg}/README.md`, message: 'no-section allowlist entry does not name a scanned package' })
  147. }
  148. if (reason.trim().length === 0) {
  149. failures.push({ path: `${pkg}/README.md`, message: 'no-section allowlist entry must retain its audit justification' })
  150. }
  151. if (SENTENCE_MODEL_EXPERIENCE[pkg] !== undefined) {
  152. failures.push({ path: `${pkg}/README.md`, message: 'package cannot appear in both Model Experience allowlists' })
  153. }
  154. }
  155. for (const [pkg, contract] of Object.entries(SENTENCE_MODEL_EXPERIENCE)) {
  156. if (!scannedPackages.has(pkg)) {
  157. failures.push({ path: `${pkg}/README.md`, message: 'sentence allowlist entry does not name a scanned package' })
  158. }
  159. if (contract.reason.trim().length === 0) {
  160. failures.push({ path: `${pkg}/README.md`, message: 'sentence allowlist entry must justify why structured context surfaces are unnecessary' })
  161. }
  162. }
  163. for (const packageJson of packageJsons) {
  164. const pkg = packageJson.slice(0, -'/package.json'.length)
  165. const readme = packageJson.replace(/package\.json$/, 'README.md')
  166. const abs = resolve(root, readme)
  167. if (!existsSync(abs)) {
  168. failures.push({ path: readme, message: 'missing package README' })
  169. continue
  170. }
  171. const text = readFileSync(abs, 'utf8')
  172. const rawLines = text.split('\n')
  173. const lines = markdownProseLines(text)
  174. const headings = markdownHeadingLines(text)
  175. const h2Headings = headings.filter(heading => heading.depth === 2)
  176. const modelExperienceHeadings = headings.filter(heading => heading.text
  177. .trim().replaceAll(/\s+/g, ' ').toLowerCase() === 'model experience')
  178. const modelHeadings = modelExperienceHeadings.filter(heading => heading.depth === 2 && heading.raw === HEADING)
  179. if (NO_MODEL_EXPERIENCE_SECTION[pkg] !== undefined) {
  180. if (modelExperienceHeadings.length !== 0) {
  181. for (const heading of modelExperienceHeadings) {
  182. failures.push({ path: readme, message: `line ${heading.index}: audited model-agnostic package must omit every Model Experience heading; found ${JSON.stringify(heading.raw)}` })
  183. }
  184. } else {
  185. omittedSectionCount += 1
  186. }
  187. continue
  188. }
  189. const nonCanonicalModelHeading = modelExperienceHeadings.find(heading => heading.depth !== 2 || heading.raw !== HEADING)
  190. if (nonCanonicalModelHeading !== undefined) {
  191. failures.push({ path: readme, message: `line ${nonCanonicalModelHeading.index}: non-canonical Model Experience heading ${JSON.stringify(nonCanonicalModelHeading.raw)}; use exactly ${JSON.stringify(HEADING)}` })
  192. continue
  193. }
  194. const modelHeading = modelHeadings.at(0)
  195. if (modelHeading === undefined) {
  196. failures.push({
  197. path: readme,
  198. message: `missing ${HEADING}`,
  199. })
  200. continue
  201. }
  202. if (modelHeadings.length !== 1) {
  203. failures.push({ path: readme, message: `contains ${modelHeadings.length} copies of ${HEADING}` })
  204. continue
  205. }
  206. const modelH2Index = h2Headings.indexOf(modelHeading)
  207. const limitationsH2Index = h2Headings.findIndex(heading => heading.depth === 2 && heading.raw === LIMITATIONS_HEADING)
  208. if (limitationsH2Index >= 0) {
  209. if (modelH2Index !== h2Headings.length - 2 || limitationsH2Index !== h2Headings.length - 1) {
  210. failures.push({
  211. path: readme,
  212. message: `${HEADING} and ${LIMITATIONS_HEADING} must be the final two H2 sections, in that order`,
  213. })
  214. continue
  215. }
  216. } else if (modelH2Index !== h2Headings.length - 1) {
  217. failures.push({ path: readme, message: `${HEADING} must be the final H2 when ${LIMITATIONS_HEADING} is absent` })
  218. continue
  219. }
  220. const modelHeadingAt = lines.findIndex(line => line.index === modelHeading.index)
  221. const body = lines.slice(modelHeadingAt + 1)
  222. const h2Lines = new Set(h2Headings.map(heading => heading.index))
  223. const nextH2 = body.findIndex(line => h2Lines.has(line.index))
  224. const section = nextH2 < 0 ? body : body.slice(0, nextH2)
  225. const nextH2Line = nextH2 < 0 ? rawLines.length + 1 : (body[nextH2] as Line).index
  226. const rawSection = rawLines.slice(modelHeading.index, nextH2Line - 1)
  227. const content = section.filter(line => line.raw.trim().length > 0)
  228. const sentenceContract = SENTENCE_MODEL_EXPERIENCE[pkg]
  229. if (sentenceContract !== undefined) {
  230. const pattern = sentenceContract.kind === 'none' ? /^None, as .+\.$/ : /^Indirectly, through .+\.$/
  231. const rawContent = rawSection.filter(line => line.trim().length > 0)
  232. if (content.length !== 1 || rawContent.length !== 1 || !pattern.test(content[0]?.raw ?? '')) {
  233. const prefix = sentenceContract.kind === 'none' ? 'None, as ' : 'Indirectly, through '
  234. failures.push({ path: readme, message: `must contain exactly one sentence beginning ${JSON.stringify(prefix)} and ending with a period` })
  235. continue
  236. }
  237. if (sentenceContract.kind === 'none') explainedNoneCount += 1
  238. else indirectCount += 1
  239. continue
  240. }
  241. const shortSentence = content.find(line => line.raw === 'None.' || /^None, as |^Indirectly, through /.test(line.raw))
  242. if (shortSentence !== undefined) {
  243. failures.push({ path: readme, message: `line ${shortSentence.index}: short Model Experience form requires an audited entry in SENTENCE_MODEL_EXPERIENCE` })
  244. continue
  245. }
  246. const surfaceStarts = content
  247. .map((line, index) => ({ line, index }))
  248. .filter(entry => /^### \S/.test(entry.line.raw))
  249. if (surfaceStarts.length === 0 || surfaceStarts[0]?.index !== 0) {
  250. failures.push({ path: readme, message: 'must contain one or more complete context-surface blocks' })
  251. continue
  252. }
  253. const surfaces: ContextSurface[] = []
  254. const surfaceFragments = new Set<string>()
  255. let surfaceError = false
  256. for (let surfaceIndex = 0; surfaceIndex < surfaceStarts.length; surfaceIndex += 1) {
  257. const start = surfaceStarts[surfaceIndex] as { line: Line; index: number }
  258. const end = surfaceStarts[surfaceIndex + 1]?.index ?? content.length
  259. const entries = content.slice(start.index, end)
  260. const heading = entries[0] as Line
  261. const modelView = entries[1]
  262. const tokenEffect = entries[2]
  263. const title = heading.raw.slice('### '.length)
  264. const fragment = headingFragment(title)
  265. if (fragment.length === 0) {
  266. failures.push({ path: readme, message: `line ${heading.index}: each context surface requires a non-empty H3 heading` })
  267. surfaceError = true
  268. break
  269. }
  270. if (surfaceFragments.has(fragment)) {
  271. failures.push({ path: readme, message: `line ${heading.index}: duplicate context-surface link fragment ${JSON.stringify(fragment)}` })
  272. surfaceError = true
  273. break
  274. }
  275. if (modelView === undefined || !modelView.raw.startsWith(`${MODEL_VIEW_LABEL}: `) || modelView.raw.slice(`${MODEL_VIEW_LABEL}: `.length).trim().length === 0) {
  276. failures.push({ path: readme, message: `line ${modelView?.index ?? heading.index}: context surface requires non-empty ${MODEL_VIEW_LABEL}: text` })
  277. surfaceError = true
  278. break
  279. }
  280. if (tokenEffect === undefined || !tokenEffect.raw.startsWith(`${TOKEN_EFFECT_LABEL}: `) || tokenEffect.raw.slice(`${TOKEN_EFFECT_LABEL}: `.length).trim().length === 0) {
  281. failures.push({ path: readme, message: `line ${tokenEffect?.index ?? heading.index}: context surface requires non-empty ${TOKEN_EFFECT_LABEL}: text` })
  282. surfaceError = true
  283. break
  284. }
  285. if ((surfaceIndex === 0 && heading.index !== modelHeading.index + 2)
  286. || rawLines[heading.index - 2]?.trim().length !== 0
  287. || modelView.index !== heading.index + 2
  288. || tokenEffect.index !== modelView.index + 2) {
  289. failures.push({ path: readme, message: `line ${heading.index}: context-surface heading and fields require one blank line between each element` })
  290. surfaceError = true
  291. break
  292. }
  293. const unexpected = entries.slice(3).find(line => !/^#### \S/.test(line.raw))
  294. if (unexpected !== undefined) {
  295. failures.push({ path: readme, message: `line ${unexpected.index}: content after ${TOKEN_EFFECT_LABEL} must be a titled H4 plus \`markdown\` fence inside this context surface` })
  296. surfaceError = true
  297. break
  298. }
  299. const nextHeadingLine = surfaceStarts[surfaceIndex + 1]?.line.index ?? nextH2Line
  300. const verbatim = validateNestedVerbatim(rawLines.slice(tokenEffect.index, nextHeadingLine - 1))
  301. if (verbatim.error !== undefined) {
  302. failures.push({ path: readme, message: `line ${tokenEffect.index}: ${verbatim.error}` })
  303. surfaceError = true
  304. break
  305. }
  306. if (entries.length - 3 !== verbatim.blocks) {
  307. failures.push({ path: readme, message: `line ${tokenEffect.index}: every nested H4 must own exactly one \`markdown\` fence` })
  308. surfaceError = true
  309. break
  310. }
  311. if (/\]\(#[^)]+\)/.test(modelView.raw) || /\]\(#[^)]+\)/.test(tokenEffect.raw)) {
  312. failures.push({ path: readme, message: `line ${heading.index}: Model Experience fields must not link between local subsections; nest the H4 in its owning H3` })
  313. surfaceError = true
  314. break
  315. }
  316. surfaceFragments.add(fragment)
  317. surfaces.push({ heading, modelView, tokenEffect, title, verbatimBlocks: verbatim.blocks })
  318. }
  319. if (surfaceError) continue
  320. const promptWithoutVerbatim = surfaces.find(surface => isDirectSystemPromptSurface(surface.title)
  321. && surface.verbatimBlocks === 0)
  322. if (promptWithoutVerbatim !== undefined) {
  323. failures.push({ path: readme, message: `line ${promptWithoutVerbatim.heading.index}: system-prompt surface must contain a titled H4 plus verbatim \`markdown\` block` })
  324. continue
  325. }
  326. const hasConcreteLiteral = surfaces.some(surface => surface.verbatimBlocks > 0
  327. || surface.modelView.raw.includes('`')
  328. || surface.tokenEffect.raw.includes('`')
  329. || toolCatalogLinkFragments(surface.modelView.raw).length > 0)
  330. if (!hasConcreteLiteral) {
  331. failures.push({ path: readme, message: 'structured Model Experience must ground at least one surface with inline code, a nested `markdown` block, or an anchored tool-catalog link' })
  332. continue
  333. }
  334. let catalogError = false
  335. for (const surface of surfaces) {
  336. if (!/\bschemas?\b/i.test(surface.title)) continue
  337. const fragments = toolCatalogLinkFragments(surface.modelView.raw)
  338. if (fragments.length === 0) {
  339. failures.push({ path: readme, message: `line ${surface.heading.index}: tool-schema surface must link an anchored section of ../../../docs/tool-catalog.md` })
  340. catalogError = true
  341. break
  342. }
  343. const invalid = fragments.find(fragment => !toolCatalogFragments.has(fragment))
  344. if (invalid !== undefined) {
  345. failures.push({ path: readme, message: `line ${surface.modelView.index}: tool-catalog link fragment ${JSON.stringify(invalid)} does not name an H2 section` })
  346. catalogError = true
  347. break
  348. }
  349. }
  350. if (catalogError) continue
  351. verbatimBlockCount += surfaces.reduce((total, surface) => total + surface.verbatimBlocks, 0)
  352. contextSurfaceCount += surfaces.length
  353. systemPromptSurfaceCount += surfaces.filter(surface => isDirectSystemPromptSurface(surface.title)).length
  354. toolSchemaSurfaceCount += surfaces.filter(surface => /\bschemas?\b/i.test(surface.title)).length
  355. structuredCount += 1
  356. }
  357. if (failures.length === 0) {
  358. console.log(`verify-package-readme-model-experience: ${packageJsons.length} README(s) checked (${omittedSectionCount} audited omissions, ${structuredCount} structured, ${contextSurfaceCount} context surfaces, ${systemPromptSurfaceCount} fenced system-prompt surfaces, ${toolSchemaSurfaceCount} catalog-linked tool-schema surfaces, ${explainedNoneCount} explained none, ${indirectCount} indirect, ${verbatimBlockCount} verbatim markdown blocks), all conform.`)
  359. process.exit(0)
  360. }
  361. console.error('verify-package-readme-model-experience failed:')
  362. for (const failure of failures) {
  363. console.error(` ${relative(root, resolve(root, failure.path))}: ${failure.message}`)
  364. }
  365. process.exit(1)