run-gates.spec.ts 19 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507
  1. import { describe, expect, it, vi } from 'vitest'
  2. import {
  3. defaultConcurrency,
  4. formatGateResultReason,
  5. gatesForMode,
  6. runGate,
  7. runGates,
  8. type Gate,
  9. type GateResult,
  10. } from './run-gates.ts'
  11. function gate(id: string, options: Partial<Gate> = {}): Gate {
  12. return {
  13. id,
  14. label: id,
  15. displayCommand: `run ${id}`,
  16. command: process.execPath,
  17. args: ['-e', ''],
  18. ...options,
  19. }
  20. }
  21. function resultFor(subject: Gate, status: GateResult['status'] = 'passed'): GateResult {
  22. return {
  23. gate: subject,
  24. status,
  25. durationMs: 10,
  26. output: [],
  27. exitCode: status === 'passed' ? 0 : 1,
  28. signalCode: null,
  29. }
  30. }
  31. function withPnpmEntrypoint<T>(action: () => T, entrypoint = '/private/pnpm.cjs'): T {
  32. const previous = process.env.npm_execpath
  33. process.env.npm_execpath = entrypoint
  34. try {
  35. return action()
  36. } finally {
  37. if (previous === undefined) Reflect.deleteProperty(process.env, 'npm_execpath')
  38. else process.env.npm_execpath = previous
  39. }
  40. }
  41. function withEnv<T>(name: string, value: string | undefined, action: () => T): T {
  42. const previous = process.env[name]
  43. if (value === undefined) Reflect.deleteProperty(process.env, name)
  44. else process.env[name] = value
  45. try {
  46. return action()
  47. } finally {
  48. if (previous === undefined) Reflect.deleteProperty(process.env, name)
  49. else process.env[name] = previous
  50. }
  51. }
  52. describe('gate graph validation', () => {
  53. it.each([
  54. 'ci-primary',
  55. 'ci-linux-primary',
  56. 'ci-static',
  57. 'ci-lint-contracts-ready',
  58. 'ci-coverage',
  59. 'ci-snapshot',
  60. 'ci-artifacts',
  61. 'ci-consumers',
  62. 'ci-windows-blocking',
  63. 'ci-windows-complete',
  64. 'ci-windows-observational',
  65. 'node-compat',
  66. 'check-all',
  67. 'hygiene',
  68. 'doc-sync',
  69. 'doc-quick',
  70. ] as const)('constructs and executes preflight for a valid non-empty %s graph', async (mode) => {
  71. const subject = withPnpmEntrypoint(() => gatesForMode(mode))
  72. const execute = vi.fn(async (item: Gate) => resultFor(item))
  73. await expect(runGates(subject, subject.length, execute)).resolves.toHaveLength(subject.length)
  74. })
  75. it('keeps the public repository link policy in the documentation gate', () => {
  76. const ids = withPnpmEntrypoint(() => gatesForMode('doc-sync').map(subject => subject.id))
  77. expect(ids).toContain('public-repository-links')
  78. })
  79. it('keeps package-group subsystem ownership in the documentation gate', () => {
  80. const ids = withPnpmEntrypoint(() => gatesForMode('doc-sync').map(subject => subject.id))
  81. expect(ids).toContain('subsystem-pages')
  82. })
  83. it('derives the quick documentation aggregate from marked doc-sync leaves', () => {
  84. const full = withPnpmEntrypoint(() => gatesForMode('doc-sync'))
  85. const quick = withPnpmEntrypoint(() => gatesForMode('doc-quick'))
  86. expect(quick).toEqual(full.filter(gate => gate.quick === true))
  87. })
  88. it('keeps the hygiene aggregate aligned with the package script checks', () => {
  89. const ids = withPnpmEntrypoint(() => gatesForMode('hygiene').map(subject => subject.id))
  90. expect(ids).toEqual([
  91. 'rescope-vendor', 'knip', 'publint', 'constraints', 'application-entrypoints',
  92. 'dsh-package-licenses', 'package-invariants', 'built-package-invariants', 'node-next-types',
  93. 'optional-dependency-imports', 'client-packages', 'client-ui-i18n', 'cordis-config',
  94. 'runtime-closure', 'vendored-links',
  95. ])
  96. expect(defaultConcurrency('hygiene', ids.length, 8)).toEqual({
  97. workers: 4,
  98. source: '8 available CPU(s), hygiene cap 4',
  99. })
  100. })
  101. it('schedules the longest documentation leaves before short checks', () => {
  102. const ids = withPnpmEntrypoint(() => gatesForMode('doc-sync').map(subject => subject.id))
  103. expect(ids.slice(0, 10)).toEqual([
  104. 'doc-typecheck', 'docs-site-build', 'doc-graphs', 'markdown-links', 'type-equivalence',
  105. 'cordis-catalog', 'cordis-inspect-catalog', 'mermaid', 'scoped-events', 'translation-pairing',
  106. ])
  107. })
  108. it('launches a native pnpm entrypoint directly', () => {
  109. const entrypoint = String.raw`C:\Program Files\pnpm\pnpm.exe`
  110. const subject = withPnpmEntrypoint(() => gatesForMode('ci-windows-blocking')[0], entrypoint)
  111. expect(subject).toMatchObject({
  112. command: entrypoint,
  113. args: ['run', 'build'],
  114. })
  115. })
  116. it.each(['ci-primary', 'ci-static', 'check-all'] as const)(
  117. 'keeps the DSH package license policy in %s',
  118. (mode) => {
  119. const ids = withPnpmEntrypoint(() => gatesForMode(mode).map(subject => subject.id))
  120. expect(ids).toContain('dsh-package-licenses')
  121. },
  122. )
  123. it.each(['ci-primary', 'ci-static', 'check-all'] as const)(
  124. 'keeps the client dependency policy in %s',
  125. (mode) => {
  126. const ids = withPnpmEntrypoint(() => gatesForMode(mode).map(subject => subject.id))
  127. expect(ids).toContain('client-packages')
  128. },
  129. )
  130. it.each(['ci-primary', 'ci-static', 'check-all', 'hygiene'] as const)(
  131. 'keeps hard-coded Client UI copy enforcement in %s',
  132. (mode) => {
  133. const ids = withPnpmEntrypoint(() => gatesForMode(mode).map(subject => subject.id))
  134. expect(ids).toContain('client-ui-i18n')
  135. },
  136. )
  137. it.each(['ci-primary', 'ci-static', 'check-all', 'hygiene'] as const)(
  138. 'keeps application entrypoint enforcement in %s',
  139. (mode) => {
  140. const ids = withPnpmEntrypoint(() => gatesForMode(mode).map(subject => subject.id))
  141. expect(ids).toContain('application-entrypoints')
  142. },
  143. )
  144. it('keeps native Windows coverage blocking and behind the complete build', () => {
  145. const complete = withPnpmEntrypoint(() => gatesForMode('ci-windows-complete'))
  146. const observational = withPnpmEntrypoint(() => gatesForMode('ci-windows-observational'))
  147. .filter(gate => gate.id !== 'build' && gate.id !== 'docs-site-build')
  148. const byId = new Map(complete.map(subject => [subject.id, subject]))
  149. expect(byId.get('coverage')?.allowFailure).not.toBe(true)
  150. expect(byId.get('coverage')?.needs).toContain('build')
  151. expect(byId.get('coverage-exempt-heavy')?.allowFailure).not.toBe(true)
  152. expect(byId.get('coverage')?.needs).toContain('build')
  153. expect(byId.get('coverage-exempt-heavy')?.needs).toContain('build')
  154. expect(byId.get('coverage-exempt-heavy')?.args).toContain(
  155. 'packages/experimental/webworker-packer/tests/image-loadable.spec.ts',
  156. )
  157. expect(observational).not.toHaveLength(0)
  158. for (const gate of observational) {
  159. const completeGate = byId.get(gate.id)
  160. expect(completeGate?.allowFailure).toBe(true)
  161. expect(completeGate?.after).toEqual(expect.arrayContaining([
  162. 'coverage',
  163. 'coverage-exempt-heavy',
  164. ]))
  165. expect(completeGate?.needs).toEqual(gate.needs)
  166. }
  167. })
  168. it('applies one configured test and polling timeout to both coverage gates', () => {
  169. const gates = withEnv('DSH_COVERAGE_TEST_TIMEOUT_MS', '15000', () =>
  170. withPnpmEntrypoint(() => gatesForMode('ci-windows-complete')))
  171. for (const id of ['coverage', 'coverage-exempt-heavy']) {
  172. expect(gates.find(subject => subject.id === id)?.args).toEqual(expect.arrayContaining([
  173. '--testTimeout=15000',
  174. '--expect.poll.timeout=15000',
  175. ]))
  176. }
  177. })
  178. it('keeps Vitest timeout defaults when the coverage override is absent', () => {
  179. const gates = withEnv('DSH_COVERAGE_TEST_TIMEOUT_MS', undefined, () =>
  180. withPnpmEntrypoint(() => gatesForMode('ci-windows-complete')))
  181. for (const id of ['coverage', 'coverage-exempt-heavy']) {
  182. expect(gates.find(subject => subject.id === id)?.args).not.toEqual(expect.arrayContaining([
  183. expect.stringMatching(/^--(?:testTimeout|expect\.poll\.timeout)=/),
  184. ]))
  185. }
  186. })
  187. it('rejects an invalid coverage timeout before starting a gate', () => {
  188. expect(() => withEnv('DSH_COVERAGE_TEST_TIMEOUT_MS', '0', () =>
  189. withPnpmEntrypoint(() => gatesForMode('ci-windows-complete'))))
  190. .toThrow('DSH_COVERAGE_TEST_TIMEOUT_MS must be a positive integer')
  191. })
  192. it('selects partitioned coverage only when explicitly configured', () => {
  193. const coverage = withEnv('DSH_COVERAGE_PARTITIONS', '3', () =>
  194. withPnpmEntrypoint(() => gatesForMode('ci-windows-complete').find(subject => subject.id === 'coverage')))
  195. expect(coverage).toMatchObject({
  196. displayCommand: 'DSH_COVERAGE_PARTITIONS=3 pnpm run test:coverage:partitioned',
  197. args: ['/private/pnpm.cjs', 'run', 'test:coverage:partitioned'],
  198. env: { DSH_COVERAGE_EXEMPT_HEAVY: '1' },
  199. streamOutput: true,
  200. })
  201. })
  202. it('rejects an invalid coverage partition count before starting a gate', () => {
  203. expect(() => withEnv('DSH_COVERAGE_PARTITIONS', '1', () =>
  204. withPnpmEntrypoint(() => gatesForMode('ci-windows-complete'))))
  205. .toThrow('DSH_COVERAGE_PARTITIONS must be an integer greater than 1')
  206. })
  207. it.each([
  208. ['empty', [], /gate graph has no gates/],
  209. ['duplicate ids', [gate('same'), gate('same')], /duplicate gate id "same"/],
  210. ['unknown dependencies', [gate('subject', { needs: ['missing'] })], /depends on unknown gate "missing"/],
  211. ['unknown ordering predecessors', [gate('subject', { after: ['missing'] })], /waits for unknown gate "missing"/],
  212. ['cycles', [gate('first', { needs: ['second'] }), gate('second', { needs: ['first'] })], /dependency cycle: first -> second -> first/],
  213. ['mixed cycles', [gate('first', { after: ['second'] }), gate('second', { needs: ['first'] })], /dependency cycle: first -> second -> first/],
  214. ] as const)('rejects %s before starting a child', async (_label, invalid, message) => {
  215. const execute = vi.fn(async (subject: Gate) => resultFor(subject))
  216. await expect(runGates([...invalid], 1, execute)).rejects.toThrow(message)
  217. expect(execute).not.toHaveBeenCalled()
  218. })
  219. it('rejects an invalid worker count before starting a child', async () => {
  220. const execute = vi.fn(async (subject: Gate) => resultFor(subject))
  221. await expect(runGates([gate('subject')], 0, execute)).rejects.toThrow('max concurrency must be a positive integer')
  222. expect(execute).not.toHaveBeenCalled()
  223. })
  224. it('skips dependents after their prerequisite fails', async () => {
  225. const dependent = gate('dependent', { needs: ['root'] })
  226. const root = gate('root')
  227. const execute = vi.fn(async (subject: Gate) => resultFor(subject, 'failed'))
  228. const results = await runGates([dependent, root], 1, execute)
  229. expect(execute).toHaveBeenCalledOnce()
  230. expect(execute).toHaveBeenCalledWith(root)
  231. expect(results[0]).toMatchObject({ gate: dependent, status: 'skipped', error: 'dependency failed or skipped: root' })
  232. })
  233. it('runs an ordered follower after its predecessor fails', async () => {
  234. const follower = gate('follower', { after: ['root'] })
  235. const root = gate('root')
  236. const execute = vi.fn(async (subject: Gate) => resultFor(subject, subject === root ? 'failed' : 'passed'))
  237. const results = await runGates([follower, root], 2, execute)
  238. expect(execute.mock.calls.map(([subject]) => subject.id)).toEqual(['root', 'follower'])
  239. expect(results.map(result => result.status)).toEqual(['passed', 'failed'])
  240. })
  241. it('runs an ordered follower after its predecessor is skipped', async () => {
  242. const follower = gate('follower', { after: ['dependent'] })
  243. const dependent = gate('dependent', { needs: ['root'] })
  244. const root = gate('root')
  245. const execute = vi.fn(async (subject: Gate) => resultFor(subject, subject === root ? 'failed' : 'passed'))
  246. const results = await runGates([follower, dependent, root], 2, execute)
  247. expect(execute.mock.calls.map(([subject]) => subject.id)).toEqual(['root', 'follower'])
  248. expect(results.map(result => result.status)).toEqual(['passed', 'skipped', 'failed'])
  249. })
  250. })
  251. describe('Oxlint gate', () => {
  252. it('uses the package script when no worker bound is configured', () => {
  253. const subject = withEnv('DSH_OXLINT_THREADS', undefined, () =>
  254. withPnpmEntrypoint(() => gatesForMode('ci-lint-contracts-ready')[0]))
  255. expect(subject).toMatchObject({
  256. id: 'lint',
  257. displayCommand: 'pnpm run lint:contracts-ready',
  258. command: process.execPath,
  259. args: ['/private/pnpm.cjs', 'run', 'lint:contracts-ready'],
  260. })
  261. })
  262. it('surfaces the configured worker bound on the shared package script', () => {
  263. const subject = withEnv('DSH_OXLINT_THREADS', '4', () =>
  264. withPnpmEntrypoint(() => gatesForMode('ci-lint-contracts-ready')[0]))
  265. expect(subject).toMatchObject({
  266. id: 'lint',
  267. displayCommand: 'DSH_OXLINT_THREADS=4 pnpm run lint:contracts-ready',
  268. command: process.execPath,
  269. args: ['/private/pnpm.cjs', 'run', 'lint:contracts-ready'],
  270. })
  271. })
  272. })
  273. describe('Typert contract preparation', () => {
  274. it('prepares primary source consumers once before they run', () => {
  275. const subject = withEnv('DSH_OXLINT_THREADS', undefined, () =>
  276. withPnpmEntrypoint(() => gatesForMode('ci-primary')))
  277. expect(subject.find(item => item.id === 'typert-contracts')).toMatchObject({
  278. displayCommand: 'pnpm run build:lib:host',
  279. args: ['/private/pnpm.cjs', 'run', 'build:lib:host'],
  280. })
  281. for (const [id, script] of [
  282. ['typecheck', 'typecheck:contracts-ready'],
  283. ['lint', 'lint:contracts-ready'],
  284. ['doc-typecheck', 'doc-typecheck:contracts-ready'],
  285. ] as const) {
  286. expect(subject.find(item => item.id === id)).toMatchObject({
  287. displayCommand: `pnpm run ${script}`,
  288. args: ['/private/pnpm.cjs', 'run', script],
  289. needs: ['typert-contracts'],
  290. })
  291. }
  292. expect(subject.find(item => item.id === 'build')?.needs).toEqual([
  293. 'typecheck',
  294. 'lint',
  295. 'doc-typecheck',
  296. ])
  297. })
  298. it('reuses contracts from the validated consumer build', () => {
  299. const subject = withPnpmEntrypoint(() => gatesForMode('ci-consumers'))
  300. expect(subject.find(item => item.id === 'lint-and-duplication')).toMatchObject({
  301. displayCommand: 'pnpm run check:ci:lint:contracts-ready',
  302. args: ['/private/pnpm.cjs', 'run', 'check:ci:lint:contracts-ready'],
  303. })
  304. expect(subject.find(item => item.id === 'doc-typecheck')).toMatchObject({
  305. displayCommand: 'pnpm run doc-typecheck:contracts-ready',
  306. args: ['/private/pnpm.cjs', 'run', 'doc-typecheck:contracts-ready'],
  307. })
  308. })
  309. it('keeps standalone doc sync responsible for preparation', () => {
  310. const docTypecheck = withPnpmEntrypoint(() =>
  311. gatesForMode('doc-sync').find(item => item.id === 'doc-typecheck'))
  312. expect(docTypecheck?.displayCommand).toBe('pnpm run doc-typecheck')
  313. })
  314. })
  315. describe('Node compatibility graph', () => {
  316. it('runs the jsdom environment smoke on every advertised Node line', () => {
  317. const subject = withPnpmEntrypoint(() => gatesForMode('node-compat'))
  318. expect(subject.find(item => item.id === 'vitest-jsdom-smoke')).toMatchObject({
  319. label: 'Vitest jsdom smoke',
  320. args: [
  321. '/private/pnpm.cjs',
  322. 'exec',
  323. 'vitest',
  324. 'run',
  325. 'scripts/vitest-environment.compat.spec.ts',
  326. ],
  327. })
  328. })
  329. })
  330. describe('Node 24 lane ownership', () => {
  331. it('keeps the static lane source-only', () => {
  332. const subject = withPnpmEntrypoint(() => gatesForMode('ci-static'))
  333. expect(subject.map(item => item.id)).not.toContain('build')
  334. expect(subject.map(item => item.id)).not.toContain('doc-typecheck')
  335. })
  336. it('owns the build and orders its artifact consumers', () => {
  337. const subject = withPnpmEntrypoint(() => gatesForMode('ci-consumers'))
  338. expect(defaultConcurrency('ci-consumers', subject.length, 4)).toEqual({
  339. workers: 11,
  340. source: 'ci-consumers gate count',
  341. })
  342. expect(subject.map(item => item.id)).toEqual([
  343. 'build',
  344. 'node-compat',
  345. 'publint',
  346. 'built-package-invariants',
  347. 'lint-and-duplication',
  348. 'snapshot',
  349. 'expected-output',
  350. 'web-snapshot',
  351. 'doc-typecheck',
  352. 'node-next-types',
  353. 'built-bin-smoke',
  354. ])
  355. expect(subject.find(item => item.id === 'publint')?.needs).toEqual(['build'])
  356. expect(subject.find(item => item.id === 'build')?.env).toEqual({
  357. DSH_BUILD_CLIENT_PROFILE: 'official',
  358. })
  359. expect(subject.find(item => item.id === 'node-compat')?.env).toEqual({
  360. DSH_BUILD_CLIENT_PROFILE: 'official',
  361. })
  362. expect(subject.find(item => item.id === 'built-package-invariants')?.needs).toEqual(['build'])
  363. expect(subject.find(item => item.id === 'lint-and-duplication')?.needs).toEqual(['built-package-invariants'])
  364. for (const id of [
  365. 'snapshot',
  366. 'expected-output',
  367. 'web-snapshot',
  368. 'doc-typecheck',
  369. 'node-next-types',
  370. 'built-bin-smoke',
  371. ]) {
  372. expect(subject.find(item => item.id === id)?.needs).toEqual(['built-package-invariants'])
  373. }
  374. expect(subject.find(item => item.id === 'snapshot')?.env).toEqual({ DSH_EXAMPLE_MODE: 'lib' })
  375. expect(subject.find(item => item.id === 'expected-output')?.env).toEqual({ DSH_EXAMPLE_MODE: 'lib' })
  376. expect(subject.find(item => item.id === 'doc-typecheck')?.env).toEqual({
  377. DSH_DOC_TYPECHECK_USE_BUILD_OUTPUT: '1',
  378. })
  379. expect(subject.find(item => item.id === 'built-bin-smoke')?.args).toEqual(
  380. expect.arrayContaining([
  381. 'packages/subagent/subagent-codex/tests/loader-composition.e2e.ts',
  382. 'packages/subagent/subagent-claude-code/tests/loader-composition.e2e.ts',
  383. 'packages/experimental/agent-team/tests/built-lib.e2e.ts',
  384. ]),
  385. )
  386. expect(subject.find(item => item.id === 'web-snapshot')).toMatchObject({
  387. displayCommand: 'DSH_SNAPSHOT=replay pnpm run test:web:built',
  388. env: { DSH_SNAPSHOT: 'replay' },
  389. after: [
  390. 'publint',
  391. 'lint-and-duplication',
  392. 'snapshot',
  393. 'expected-output',
  394. 'doc-typecheck',
  395. 'node-next-types',
  396. 'built-bin-smoke',
  397. ],
  398. })
  399. })
  400. })
  401. describe('Linux primary graph', () => {
  402. it('adds the same compare-only web gate after built client artifacts', () => {
  403. const subject = withPnpmEntrypoint(() => gatesForMode('ci-linux-primary'))
  404. const web = subject.find(item => item.id === 'web-snapshot')
  405. expect(web).toMatchObject({
  406. displayCommand: 'DSH_SNAPSHOT=replay pnpm run test:web:built',
  407. env: { DSH_SNAPSHOT: 'replay' },
  408. needs: ['built-package-invariants'],
  409. })
  410. })
  411. })
  412. describe('gate process outcomes', () => {
  413. it('streams selected gate output without retaining it', async () => {
  414. const write = vi.spyOn(process.stdout, 'write').mockReturnValue(true)
  415. try {
  416. const result = await runGate(gate('streamed', {
  417. args: ['-e', "process.stdout.write('live output')"],
  418. streamOutput: true,
  419. }))
  420. expect(result.status).toBe('passed')
  421. expect(result.output).toEqual([])
  422. expect(write).toHaveBeenCalledWith('live output')
  423. } finally {
  424. write.mockRestore()
  425. }
  426. })
  427. it.skipIf(process.platform === 'win32')('reports signal termination independently from exit status', async () => {
  428. const result = await runGate(gate('terminated', {
  429. args: ['-e', "process.kill(process.pid, 'SIGTERM')"],
  430. }))
  431. expect(result.status).toBe('failed')
  432. expect(result.exitCode).toBeNull()
  433. expect(result.signalCode).toBe('SIGTERM')
  434. expect(formatGateResultReason(result)).toBe('signal SIGTERM')
  435. })
  436. })