1
0

run-gates.spec.ts 18 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470
  1. import { describe, expect, it, vi } from 'vitest'
  2. import {
  3. defaultConcurrency,
  4. formatGateResultReason,
  5. gatesForMode,
  6. runGate,
  7. runGates,
  8. type Gate,
  9. type GateResult,
  10. } from './run-gates.ts'
  11. function gate(id: string, options: Partial<Gate> = {}): Gate {
  12. return {
  13. id,
  14. label: id,
  15. displayCommand: `run ${id}`,
  16. command: process.execPath,
  17. args: ['-e', ''],
  18. ...options,
  19. }
  20. }
  21. function resultFor(subject: Gate, status: GateResult['status'] = 'passed'): GateResult {
  22. return {
  23. gate: subject,
  24. status,
  25. durationMs: 10,
  26. output: [],
  27. exitCode: status === 'passed' ? 0 : 1,
  28. signalCode: null,
  29. }
  30. }
  31. function withPnpmEntrypoint<T>(action: () => T, entrypoint = '/private/pnpm.cjs'): T {
  32. const previous = process.env.npm_execpath
  33. process.env.npm_execpath = entrypoint
  34. try {
  35. return action()
  36. } finally {
  37. if (previous === undefined) Reflect.deleteProperty(process.env, 'npm_execpath')
  38. else process.env.npm_execpath = previous
  39. }
  40. }
  41. function withEnv<T>(name: string, value: string | undefined, action: () => T): T {
  42. const previous = process.env[name]
  43. if (value === undefined) Reflect.deleteProperty(process.env, name)
  44. else process.env[name] = value
  45. try {
  46. return action()
  47. } finally {
  48. if (previous === undefined) Reflect.deleteProperty(process.env, name)
  49. else process.env[name] = previous
  50. }
  51. }
  52. describe('gate graph validation', () => {
  53. it.each([
  54. 'ci-primary',
  55. 'ci-linux-primary',
  56. 'ci-static',
  57. 'ci-lint-contracts-ready',
  58. 'ci-coverage',
  59. 'ci-snapshot',
  60. 'ci-artifacts',
  61. 'ci-consumers',
  62. 'ci-windows-blocking',
  63. 'ci-windows-complete',
  64. 'ci-windows-observational',
  65. 'node-compat',
  66. 'check-all',
  67. 'hygiene',
  68. 'doc-sync',
  69. ] as const)('constructs and executes preflight for a valid non-empty %s graph', async (mode) => {
  70. const subject = withPnpmEntrypoint(() => gatesForMode(mode))
  71. const execute = vi.fn(async (item: Gate) => resultFor(item))
  72. await expect(runGates(subject, subject.length, execute)).resolves.toHaveLength(subject.length)
  73. })
  74. it('keeps the public repository link policy in the documentation gate', () => {
  75. const ids = withPnpmEntrypoint(() => gatesForMode('doc-sync').map(subject => subject.id))
  76. expect(ids).toContain('public-repository-links')
  77. })
  78. it('keeps package-group subsystem ownership in the documentation gate', () => {
  79. const ids = withPnpmEntrypoint(() => gatesForMode('doc-sync').map(subject => subject.id))
  80. expect(ids).toContain('subsystem-pages')
  81. })
  82. it('keeps the hygiene aggregate aligned with the package script checks', () => {
  83. const ids = withPnpmEntrypoint(() => gatesForMode('hygiene').map(subject => subject.id))
  84. expect(ids).toEqual([
  85. 'rescope-vendor', 'knip', 'publint', 'constraints', 'application-entrypoints',
  86. 'dsh-package-licenses', 'package-invariants', 'built-package-invariants', 'node-next-types',
  87. 'optional-dependency-imports', 'client-packages', 'cordis-config',
  88. 'runtime-closure', 'vendored-links',
  89. ])
  90. expect(defaultConcurrency('hygiene', ids.length, 8)).toEqual({
  91. workers: 4,
  92. source: '8 available CPU(s), hygiene cap 4',
  93. })
  94. })
  95. it('schedules the longest documentation leaves before short checks', () => {
  96. const ids = withPnpmEntrypoint(() => gatesForMode('doc-sync').map(subject => subject.id))
  97. expect(ids.slice(0, 10)).toEqual([
  98. 'doc-typecheck', 'docs-site-build', 'doc-graphs', 'markdown-links', 'type-equivalence',
  99. 'cordis-catalog', 'mermaid', 'scoped-events', 'translation-pairing', 'markdown-wrap',
  100. ])
  101. })
  102. it('launches a native pnpm entrypoint directly', () => {
  103. const entrypoint = String.raw`C:\Program Files\pnpm\pnpm.exe`
  104. const subject = withPnpmEntrypoint(() => gatesForMode('ci-windows-blocking')[0], entrypoint)
  105. expect(subject).toMatchObject({
  106. command: entrypoint,
  107. args: ['run', 'build'],
  108. })
  109. })
  110. it.each(['ci-primary', 'ci-static', 'check-all'] as const)(
  111. 'keeps the DSH package license policy in %s',
  112. (mode) => {
  113. const ids = withPnpmEntrypoint(() => gatesForMode(mode).map(subject => subject.id))
  114. expect(ids).toContain('dsh-package-licenses')
  115. },
  116. )
  117. it.each(['ci-primary', 'ci-static', 'check-all'] as const)(
  118. 'keeps the client dependency policy in %s',
  119. (mode) => {
  120. const ids = withPnpmEntrypoint(() => gatesForMode(mode).map(subject => subject.id))
  121. expect(ids).toContain('client-packages')
  122. },
  123. )
  124. it.each(['ci-primary', 'ci-static', 'check-all', 'hygiene'] as const)(
  125. 'keeps application entrypoint enforcement in %s',
  126. (mode) => {
  127. const ids = withPnpmEntrypoint(() => gatesForMode(mode).map(subject => subject.id))
  128. expect(ids).toContain('application-entrypoints')
  129. },
  130. )
  131. it('keeps native Windows coverage blocking while retaining the observational inventory', () => {
  132. const complete = withPnpmEntrypoint(() => gatesForMode('ci-windows-complete'))
  133. const observational = withPnpmEntrypoint(() => gatesForMode('ci-windows-observational'))
  134. .filter(gate => gate.id !== 'build' && gate.id !== 'docs-site-build')
  135. const byId = new Map(complete.map(subject => [subject.id, subject]))
  136. expect(byId.get('coverage')?.allowFailure).not.toBe(true)
  137. expect(byId.get('coverage-exempt-heavy')?.allowFailure).not.toBe(true)
  138. expect(byId.get('coverage-exempt-heavy')?.needs).toContain('build')
  139. expect(byId.get('coverage-exempt-heavy')?.after).toContain('coverage')
  140. expect(observational).not.toHaveLength(0)
  141. for (const gate of observational) {
  142. const completeGate = byId.get(gate.id)
  143. expect(completeGate?.allowFailure).toBe(true)
  144. expect(completeGate?.after).toContain('coverage')
  145. expect(completeGate?.after).not.toContain('coverage-exempt-heavy')
  146. expect(completeGate?.needs).toEqual(gate.needs)
  147. }
  148. })
  149. it('applies one configured test and polling timeout to both coverage gates', () => {
  150. const gates = withEnv('DSH_COVERAGE_TEST_TIMEOUT_MS', '15000', () =>
  151. withPnpmEntrypoint(() => gatesForMode('ci-windows-complete')))
  152. for (const id of ['coverage', 'coverage-exempt-heavy']) {
  153. expect(gates.find(subject => subject.id === id)?.args).toEqual(expect.arrayContaining([
  154. '--testTimeout=15000',
  155. '--expect.poll.timeout=15000',
  156. ]))
  157. }
  158. })
  159. it('keeps Vitest timeout defaults when the coverage override is absent', () => {
  160. const gates = withEnv('DSH_COVERAGE_TEST_TIMEOUT_MS', undefined, () =>
  161. withPnpmEntrypoint(() => gatesForMode('ci-windows-complete')))
  162. for (const id of ['coverage', 'coverage-exempt-heavy']) {
  163. expect(gates.find(subject => subject.id === id)?.args).not.toEqual(expect.arrayContaining([
  164. expect.stringMatching(/^--(?:testTimeout|expect\.poll\.timeout)=/),
  165. ]))
  166. }
  167. })
  168. it('rejects an invalid coverage timeout before starting a gate', () => {
  169. expect(() => withEnv('DSH_COVERAGE_TEST_TIMEOUT_MS', '0', () =>
  170. withPnpmEntrypoint(() => gatesForMode('ci-windows-complete'))))
  171. .toThrow('DSH_COVERAGE_TEST_TIMEOUT_MS must be a positive integer')
  172. })
  173. it('selects partitioned coverage only when explicitly configured', () => {
  174. const coverage = withEnv('DSH_COVERAGE_PARTITIONS', '3', () =>
  175. withPnpmEntrypoint(() => gatesForMode('ci-windows-complete').find(subject => subject.id === 'coverage')))
  176. expect(coverage).toMatchObject({
  177. displayCommand: 'DSH_COVERAGE_PARTITIONS=3 pnpm run test:coverage:partitioned',
  178. args: ['/private/pnpm.cjs', 'run', 'test:coverage:partitioned'],
  179. streamOutput: true,
  180. })
  181. })
  182. it('rejects an invalid coverage partition count before starting a gate', () => {
  183. expect(() => withEnv('DSH_COVERAGE_PARTITIONS', '1', () =>
  184. withPnpmEntrypoint(() => gatesForMode('ci-windows-complete'))))
  185. .toThrow('DSH_COVERAGE_PARTITIONS must be an integer greater than 1')
  186. })
  187. it.each([
  188. ['empty', [], /gate graph has no gates/],
  189. ['duplicate ids', [gate('same'), gate('same')], /duplicate gate id "same"/],
  190. ['unknown dependencies', [gate('subject', { needs: ['missing'] })], /depends on unknown gate "missing"/],
  191. ['unknown ordering predecessors', [gate('subject', { after: ['missing'] })], /waits for unknown gate "missing"/],
  192. ['cycles', [gate('first', { needs: ['second'] }), gate('second', { needs: ['first'] })], /dependency cycle: first -> second -> first/],
  193. ['mixed cycles', [gate('first', { after: ['second'] }), gate('second', { needs: ['first'] })], /dependency cycle: first -> second -> first/],
  194. ] as const)('rejects %s before starting a child', async (_label, invalid, message) => {
  195. const execute = vi.fn(async (subject: Gate) => resultFor(subject))
  196. await expect(runGates([...invalid], 1, execute)).rejects.toThrow(message)
  197. expect(execute).not.toHaveBeenCalled()
  198. })
  199. it('rejects an invalid worker count before starting a child', async () => {
  200. const execute = vi.fn(async (subject: Gate) => resultFor(subject))
  201. await expect(runGates([gate('subject')], 0, execute)).rejects.toThrow('max concurrency must be a positive integer')
  202. expect(execute).not.toHaveBeenCalled()
  203. })
  204. it('skips dependents after their prerequisite fails', async () => {
  205. const dependent = gate('dependent', { needs: ['root'] })
  206. const root = gate('root')
  207. const execute = vi.fn(async (subject: Gate) => resultFor(subject, 'failed'))
  208. const results = await runGates([dependent, root], 1, execute)
  209. expect(execute).toHaveBeenCalledOnce()
  210. expect(execute).toHaveBeenCalledWith(root)
  211. expect(results[0]).toMatchObject({ gate: dependent, status: 'skipped', error: 'dependency failed or skipped: root' })
  212. })
  213. it('runs an ordered follower after its predecessor fails', async () => {
  214. const follower = gate('follower', { after: ['root'] })
  215. const root = gate('root')
  216. const execute = vi.fn(async (subject: Gate) => resultFor(subject, subject === root ? 'failed' : 'passed'))
  217. const results = await runGates([follower, root], 2, execute)
  218. expect(execute.mock.calls.map(([subject]) => subject.id)).toEqual(['root', 'follower'])
  219. expect(results.map(result => result.status)).toEqual(['passed', 'failed'])
  220. })
  221. it('runs an ordered follower after its predecessor is skipped', async () => {
  222. const follower = gate('follower', { after: ['dependent'] })
  223. const dependent = gate('dependent', { needs: ['root'] })
  224. const root = gate('root')
  225. const execute = vi.fn(async (subject: Gate) => resultFor(subject, subject === root ? 'failed' : 'passed'))
  226. const results = await runGates([follower, dependent, root], 2, execute)
  227. expect(execute.mock.calls.map(([subject]) => subject.id)).toEqual(['root', 'follower'])
  228. expect(results.map(result => result.status)).toEqual(['passed', 'skipped', 'failed'])
  229. })
  230. })
  231. describe('Oxlint gate', () => {
  232. it('uses the package script when no worker bound is configured', () => {
  233. const subject = withEnv('DSH_OXLINT_THREADS', undefined, () =>
  234. withPnpmEntrypoint(() => gatesForMode('ci-lint-contracts-ready')[0]))
  235. expect(subject).toMatchObject({
  236. id: 'lint',
  237. displayCommand: 'pnpm run lint:contracts-ready',
  238. command: process.execPath,
  239. args: ['/private/pnpm.cjs', 'run', 'lint:contracts-ready'],
  240. })
  241. })
  242. it('surfaces the configured worker bound on the shared package script', () => {
  243. const subject = withEnv('DSH_OXLINT_THREADS', '4', () =>
  244. withPnpmEntrypoint(() => gatesForMode('ci-lint-contracts-ready')[0]))
  245. expect(subject).toMatchObject({
  246. id: 'lint',
  247. displayCommand: 'DSH_OXLINT_THREADS=4 pnpm run lint:contracts-ready',
  248. command: process.execPath,
  249. args: ['/private/pnpm.cjs', 'run', 'lint:contracts-ready'],
  250. })
  251. })
  252. })
  253. describe('Typert contract preparation', () => {
  254. it('prepares primary source consumers once before they run', () => {
  255. const subject = withEnv('DSH_OXLINT_THREADS', undefined, () =>
  256. withPnpmEntrypoint(() => gatesForMode('ci-primary')))
  257. expect(subject.find(item => item.id === 'typert-contracts')).toMatchObject({
  258. displayCommand: 'pnpm run build:lib:host',
  259. args: ['/private/pnpm.cjs', 'run', 'build:lib:host'],
  260. })
  261. for (const [id, script] of [
  262. ['typecheck', 'typecheck:contracts-ready'],
  263. ['lint', 'lint:contracts-ready'],
  264. ['doc-typecheck', 'doc-typecheck:contracts-ready'],
  265. ] as const) {
  266. expect(subject.find(item => item.id === id)).toMatchObject({
  267. displayCommand: `pnpm run ${script}`,
  268. args: ['/private/pnpm.cjs', 'run', script],
  269. needs: ['typert-contracts'],
  270. })
  271. }
  272. expect(subject.find(item => item.id === 'build')?.needs).toEqual([
  273. 'typecheck',
  274. 'lint',
  275. 'doc-typecheck',
  276. ])
  277. })
  278. it('reuses contracts from the validated consumer build', () => {
  279. const subject = withPnpmEntrypoint(() => gatesForMode('ci-consumers'))
  280. expect(subject.find(item => item.id === 'lint-and-duplication')).toMatchObject({
  281. displayCommand: 'pnpm run check:ci:lint:contracts-ready',
  282. args: ['/private/pnpm.cjs', 'run', 'check:ci:lint:contracts-ready'],
  283. })
  284. expect(subject.find(item => item.id === 'doc-typecheck')).toMatchObject({
  285. displayCommand: 'pnpm run doc-typecheck:contracts-ready',
  286. args: ['/private/pnpm.cjs', 'run', 'doc-typecheck:contracts-ready'],
  287. })
  288. })
  289. it('keeps standalone doc sync responsible for preparation', () => {
  290. const docTypecheck = withPnpmEntrypoint(() =>
  291. gatesForMode('doc-sync').find(item => item.id === 'doc-typecheck'))
  292. expect(docTypecheck?.displayCommand).toBe('pnpm run doc-typecheck')
  293. })
  294. })
  295. describe('Node compatibility graph', () => {
  296. it('runs the jsdom environment smoke on every advertised Node line', () => {
  297. const subject = withPnpmEntrypoint(() => gatesForMode('node-compat'))
  298. expect(subject.find(item => item.id === 'vitest-jsdom-smoke')).toMatchObject({
  299. label: 'Vitest jsdom smoke',
  300. args: [
  301. '/private/pnpm.cjs',
  302. 'exec',
  303. 'vitest',
  304. 'run',
  305. 'scripts/vitest-environment.compat.spec.ts',
  306. ],
  307. })
  308. })
  309. })
  310. describe('Node 24 lane ownership', () => {
  311. it('keeps the static lane source-only', () => {
  312. const subject = withPnpmEntrypoint(() => gatesForMode('ci-static'))
  313. expect(subject.map(item => item.id)).not.toContain('build')
  314. expect(subject.map(item => item.id)).not.toContain('doc-typecheck')
  315. })
  316. it('owns the build and orders its artifact consumers', () => {
  317. const subject = withPnpmEntrypoint(() => gatesForMode('ci-consumers'))
  318. expect(defaultConcurrency('ci-consumers', subject.length, 4)).toEqual({
  319. workers: 10,
  320. source: 'ci-consumers gate count',
  321. })
  322. expect(subject.map(item => item.id)).toEqual([
  323. 'build',
  324. 'node-compat',
  325. 'publint',
  326. 'built-package-invariants',
  327. 'lint-and-duplication',
  328. 'snapshot',
  329. 'web-snapshot',
  330. 'doc-typecheck',
  331. 'node-next-types',
  332. 'built-bin-smoke',
  333. ])
  334. expect(subject.find(item => item.id === 'publint')?.needs).toEqual(['build'])
  335. expect(subject.find(item => item.id === 'build')?.env).toEqual({
  336. DSH_BUILD_CLIENT_PROFILE: 'official',
  337. })
  338. expect(subject.find(item => item.id === 'node-compat')?.env).toEqual({
  339. DSH_BUILD_CLIENT_PROFILE: 'official',
  340. })
  341. expect(subject.find(item => item.id === 'built-package-invariants')?.needs).toEqual(['build'])
  342. expect(subject.find(item => item.id === 'lint-and-duplication')?.needs).toEqual(['built-package-invariants'])
  343. for (const id of [
  344. 'snapshot',
  345. 'web-snapshot',
  346. 'doc-typecheck',
  347. 'node-next-types',
  348. 'built-bin-smoke',
  349. ]) {
  350. expect(subject.find(item => item.id === id)?.needs).toEqual(['built-package-invariants'])
  351. }
  352. expect(subject.find(item => item.id === 'snapshot')?.env).toEqual({ DSH_EXAMPLE_MODE: 'lib' })
  353. expect(subject.find(item => item.id === 'doc-typecheck')?.env).toEqual({
  354. DSH_DOC_TYPECHECK_USE_BUILD_OUTPUT: '1',
  355. })
  356. expect(subject.find(item => item.id === 'built-bin-smoke')?.args).toEqual(
  357. expect.arrayContaining([
  358. 'packages/subagent/subagent-codex/tests/loader-composition.e2e.ts',
  359. 'packages/subagent/subagent-claude-code/tests/loader-composition.e2e.ts',
  360. ]),
  361. )
  362. expect(subject.find(item => item.id === 'web-snapshot')).toMatchObject({
  363. displayCommand: 'DSH_SNAPSHOT=replay pnpm run test:web:built',
  364. env: { DSH_SNAPSHOT: 'replay' },
  365. })
  366. })
  367. })
  368. describe('Linux primary graph', () => {
  369. it('adds the same compare-only web gate after built client artifacts', () => {
  370. const subject = withPnpmEntrypoint(() => gatesForMode('ci-linux-primary'))
  371. const web = subject.find(item => item.id === 'web-snapshot')
  372. expect(web).toMatchObject({
  373. displayCommand: 'DSH_SNAPSHOT=replay pnpm run test:web:built',
  374. env: { DSH_SNAPSHOT: 'replay' },
  375. needs: ['built-package-invariants'],
  376. })
  377. })
  378. })
  379. describe('gate process outcomes', () => {
  380. it('streams selected gate output without retaining it', async () => {
  381. const write = vi.spyOn(process.stdout, 'write').mockReturnValue(true)
  382. try {
  383. const result = await runGate(gate('streamed', {
  384. args: ['-e', "process.stdout.write('live output')"],
  385. streamOutput: true,
  386. }))
  387. expect(result.status).toBe('passed')
  388. expect(result.output).toEqual([])
  389. expect(write).toHaveBeenCalledWith('live output')
  390. } finally {
  391. write.mockRestore()
  392. }
  393. })
  394. it.skipIf(process.platform === 'win32')('reports signal termination independently from exit status', async () => {
  395. const result = await runGate(gate('terminated', {
  396. args: ['-e', "process.kill(process.pid, 'SIGTERM')"],
  397. }))
  398. expect(result.status).toBe('failed')
  399. expect(result.exitCode).toBeNull()
  400. expect(result.signalCode).toBe('SIGTERM')
  401. expect(formatGateResultReason(result)).toBe('signal SIGTERM')
  402. })
  403. })