hover-card.spec.tsx 18 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429
  1. // @vitest-environment jsdom
  2. import { act, cleanup, fireEvent, render, screen } from '@testing-library/react'
  3. import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest'
  4. import { HoverCard } from '@deepseek-ai/dsh-client-ui-primitives'
  5. import { POINTER_GRACE_MS } from '../src/pointer-grace.ts'
  6. afterEach(cleanup)
  7. beforeEach(() => { vi.useFakeTimers() })
  8. afterEach(() => { vi.useRealTimers() })
  9. /** Anchor wrapper rect: the card positions from this (jsdom rects are all-zero by default). */
  10. function stubAnchorRect(anchor: HTMLElement, rect: { top: number; right: number }): void {
  11. const wrapper = anchor.parentElement as HTMLElement
  12. wrapper.getBoundingClientRect = () => ({
  13. top: rect.top, right: rect.right, left: rect.right - 100, bottom: rect.top + 34,
  14. width: 100, height: 34, x: rect.right - 100, y: rect.top, toJSON: () => ({}),
  15. })
  16. }
  17. function mount(props: {
  18. openDelayMs?: number
  19. disabled?: boolean
  20. copyText?: string
  21. copyLabel?: string
  22. copiedLabel?: string
  23. } = {}) {
  24. const view = render(
  25. <HoverCard anchor={<span>row</span>} content={<div>card body</div>} {...props} />,
  26. )
  27. const anchor = screen.getByText('row')
  28. stubAnchorRect(anchor, { top: 40, right: 200 })
  29. return { view, anchor, wrapper: anchor.parentElement as HTMLElement }
  30. }
  31. /** Install the async browser clipboard and restore its prior host shape. */
  32. function installClipboard(writeText: (text: string) => Promise<void>): () => void {
  33. const prior = Object.getOwnPropertyDescriptor(navigator, 'clipboard')
  34. Object.defineProperty(navigator, 'clipboard', {
  35. configurable: true,
  36. value: { writeText },
  37. })
  38. return () => {
  39. if (prior === undefined) Reflect.deleteProperty(navigator, 'clipboard')
  40. else Object.defineProperty(navigator, 'clipboard', prior)
  41. }
  42. }
  43. describe('HoverCard', () => {
  44. it('opens after the dwell delay, positioned right of the anchor', () => {
  45. const { wrapper } = mount()
  46. fireEvent.pointerEnter(wrapper)
  47. expect(screen.queryByText('card body')).toBeNull()
  48. act(() => { vi.advanceTimersByTime(499) })
  49. expect(screen.queryByText('card body')).toBeNull()
  50. act(() => { vi.advanceTimersByTime(1) })
  51. const card = screen.getByText('card body').parentElement as HTMLElement
  52. expect(card.parentElement).toBe(document.body)
  53. expect(card.style.left).toBe('208px')
  54. expect(card.style.top).toBe('40px')
  55. })
  56. it('honors a custom openDelayMs', () => {
  57. const { wrapper } = mount({ openDelayMs: 50 })
  58. fireEvent.pointerEnter(wrapper)
  59. act(() => { vi.advanceTimersByTime(50) })
  60. expect(screen.getByText('card body')).toBeTruthy()
  61. })
  62. it('pointerleave before the delay cancels the pending open', () => {
  63. const { wrapper } = mount()
  64. fireEvent.pointerEnter(wrapper)
  65. fireEvent.pointerLeave(wrapper)
  66. act(() => { vi.advanceTimersByTime(1000) })
  67. expect(screen.queryByText('card body')).toBeNull()
  68. })
  69. it('pointerleave closes an open card a grace later; re-enter after that restarts the dwell', () => {
  70. const { wrapper } = mount()
  71. fireEvent.pointerEnter(wrapper)
  72. act(() => { vi.advanceTimersByTime(500) })
  73. expect(screen.getByText('card body')).toBeTruthy()
  74. fireEvent.pointerLeave(wrapper)
  75. act(() => { vi.advanceTimersByTime(POINTER_GRACE_MS - 1) })
  76. expect(screen.getByText('card body')).toBeTruthy()
  77. act(() => { vi.advanceTimersByTime(1) })
  78. expect(screen.queryByText('card body')).toBeNull()
  79. fireEvent.pointerEnter(wrapper)
  80. act(() => { vi.advanceTimersByTime(500) })
  81. expect(screen.getByText('card body')).toBeTruthy()
  82. })
  83. it('reaching the card inside the grace keeps it open without restarting the dwell', () => {
  84. // The portaled card is a React child of the wrapper, so the pointer
  85. // arriving on it re-enters the wrapper — the gesture the 8px anchor gap
  86. // used to make impossible.
  87. const { wrapper } = mount()
  88. fireEvent.pointerEnter(wrapper)
  89. act(() => { vi.advanceTimersByTime(500) })
  90. fireEvent.pointerLeave(wrapper)
  91. act(() => { vi.advanceTimersByTime(POINTER_GRACE_MS - 50) })
  92. fireEvent.pointerEnter(wrapper)
  93. act(() => { vi.advanceTimersByTime(POINTER_GRACE_MS * 10) })
  94. expect(screen.getByText('card body')).toBeTruthy()
  95. })
  96. it('re-entering while open does not queue a second dwell', () => {
  97. const { wrapper } = mount()
  98. fireEvent.pointerEnter(wrapper)
  99. act(() => { vi.advanceTimersByTime(500) })
  100. fireEvent.pointerEnter(wrapper)
  101. fireEvent.pointerLeave(wrapper)
  102. act(() => { vi.advanceTimersByTime(POINTER_GRACE_MS) })
  103. // A dwell restarted by the redundant enter would reopen the card here.
  104. act(() => { vi.advanceTimersByTime(500) })
  105. expect(screen.queryByText('card body')).toBeNull()
  106. })
  107. it('a press inside the anchor dismisses the card without waiting for disabled', () => {
  108. const { wrapper } = mount()
  109. fireEvent.pointerEnter(wrapper)
  110. act(() => { vi.advanceTimersByTime(500) })
  111. expect(screen.getByText('card body')).toBeTruthy()
  112. fireEvent.pointerDown(screen.getByText('row'))
  113. expect(screen.queryByText('card body')).toBeNull()
  114. // The pending timer is also cleared: no reopen after the dwell.
  115. act(() => { vi.advanceTimersByTime(1000) })
  116. expect(screen.queryByText('card body')).toBeNull()
  117. })
  118. it('a press on the card starts a selection instead of dismissing it', () => {
  119. // The card is a React child of the wrapper, so capture-phase presses on
  120. // it reach the wrapper's dismissal handler too; they must not close it,
  121. // or the first pointerdown of a text-selection drag would kill the card.
  122. const { wrapper } = mount()
  123. fireEvent.pointerEnter(wrapper)
  124. act(() => { vi.advanceTimersByTime(500) })
  125. fireEvent.pointerDown(screen.getByText('card body'))
  126. // Still mounted after a grace's worth of time: no close was armed either.
  127. act(() => { vi.advanceTimersByTime(POINTER_GRACE_MS) })
  128. expect(screen.getByText('card body')).toBeTruthy()
  129. })
  130. it('keeps a completed card selection instead of treating its click as copy', async () => {
  131. const writeText = vi.fn(async () => {})
  132. const restoreClipboard = installClipboard(writeText)
  133. const selection = window.getSelection()
  134. if (selection === null) throw new Error('jsdom selection API unavailable')
  135. try {
  136. const { wrapper } = mount({ copyText: 'card body', copyLabel: 'Copy' })
  137. fireEvent.pointerEnter(wrapper)
  138. act(() => { vi.advanceTimersByTime(500) })
  139. const card = screen.getByRole('button', { name: 'Copy: card body' })
  140. const selectedText = screen.getByText('card body')
  141. const cardRange = document.createRange()
  142. cardRange.selectNodeContents(selectedText)
  143. selection.addRange(cardRange)
  144. await act(async () => { fireEvent.click(card) })
  145. expect(writeText).not.toHaveBeenCalled()
  146. expect(selection.toString()).toBe('card body')
  147. expect(screen.getByText('card body')).toBeTruthy()
  148. // Firefox supports multiple selection ranges: any range intersecting
  149. // this card wins, not only the first.
  150. selection.removeAllRanges()
  151. const getSelection = vi.spyOn(window, 'getSelection').mockReturnValue({
  152. isCollapsed: false,
  153. rangeCount: 2,
  154. getRangeAt: vi.fn((index: number) => ({
  155. intersectsNode: () => index === 1,
  156. })),
  157. } as unknown as Selection)
  158. await act(async () => { fireEvent.click(card) })
  159. expect(writeText).not.toHaveBeenCalled()
  160. getSelection.mockRestore()
  161. // A non-collapsed selection elsewhere does not block this card.
  162. const anchorRange = document.createRange()
  163. anchorRange.selectNodeContents(screen.getByText('row'))
  164. selection.addRange(anchorRange)
  165. await act(async () => { fireEvent.click(card) })
  166. expect(writeText).toHaveBeenCalledWith('card body')
  167. } finally {
  168. selection.removeAllRanges()
  169. restoreClipboard()
  170. }
  171. })
  172. it('a press while closed leaves the card closed', () => {
  173. mount()
  174. fireEvent.pointerDown(screen.getByText('row'))
  175. act(() => { vi.advanceTimersByTime(1000) })
  176. expect(screen.queryByText('card body')).toBeNull()
  177. })
  178. it('copies its configured value and shows success only for the feedback window', async () => {
  179. const writeText = vi.fn(async () => {})
  180. const restoreClipboard = installClipboard(writeText)
  181. try {
  182. const { wrapper } = mount({
  183. copyText: '/full/path',
  184. copyLabel: 'Copy path',
  185. copiedLabel: 'Copied',
  186. })
  187. fireEvent.pointerEnter(wrapper)
  188. act(() => { vi.advanceTimersByTime(500) })
  189. const card = screen.getByRole('button', { name: 'Copy path: /full/path' })
  190. const status = screen.getByRole('status')
  191. expect(status.textContent).toBe('')
  192. expect(card.contains(status)).toBe(false)
  193. Object.defineProperty(card, 'offsetHeight', { configurable: true, value: 96 })
  194. await act(async () => { fireEvent.click(card) })
  195. expect(writeText).toHaveBeenCalledWith('/full/path')
  196. expect(status.textContent).toBe('Copied')
  197. expect(screen.getByRole('button', { name: 'Copy path: /full/path' })).toBe(card)
  198. expect(card.style.minHeight).toBe('96px')
  199. // Repeated activation while feedback is visible neither rewrites nor
  200. // extends the one-second success window.
  201. await act(async () => { fireEvent.click(card) })
  202. expect(writeText).toHaveBeenCalledOnce()
  203. act(() => { vi.advanceTimersByTime(999) })
  204. expect(status.textContent).toBe('Copied')
  205. act(() => { vi.advanceTimersByTime(1) })
  206. expect(screen.getByRole('button', { name: 'Copy path: /full/path' })).toBe(card)
  207. expect(card.style.minHeight).toBe('')
  208. expect(status.textContent).toBe('')
  209. expect(screen.getByText('card body')).toBeTruthy()
  210. } finally {
  211. restoreClipboard()
  212. }
  213. })
  214. it('supports button keys and ignores unrelated keys', async () => {
  215. const writeText = vi.fn(async () => {})
  216. const restoreClipboard = installClipboard(writeText)
  217. try {
  218. const { wrapper } = mount({ copyText: 'value', copiedLabel: 'Copied' })
  219. fireEvent.pointerEnter(wrapper)
  220. act(() => { vi.advanceTimersByTime(500) })
  221. const card = screen.getByRole('button')
  222. fireEvent.keyDown(card, { key: 'Escape' })
  223. expect(writeText).not.toHaveBeenCalled()
  224. await act(async () => { fireEvent.keyDown(card, { key: 'Enter' }) })
  225. expect(writeText).toHaveBeenCalledOnce()
  226. act(() => { vi.advanceTimersByTime(1000) })
  227. await act(async () => { fireEvent.keyDown(card, { key: ' ' }) })
  228. expect(writeText).toHaveBeenCalledTimes(2)
  229. } finally {
  230. restoreClipboard()
  231. }
  232. })
  233. it('keeps its content when the clipboard rejects the write', async () => {
  234. const writeText = vi.fn(async () => { throw new Error('denied') })
  235. const restoreClipboard = installClipboard(writeText)
  236. try {
  237. const { wrapper } = mount({ copyText: 'value', copiedLabel: 'Copied' })
  238. fireEvent.pointerEnter(wrapper)
  239. act(() => { vi.advanceTimersByTime(500) })
  240. await act(async () => { fireEvent.click(screen.getByRole('button')) })
  241. expect(screen.queryByText('Copied')).toBeNull()
  242. expect(screen.getByText('card body')).toBeTruthy()
  243. } finally {
  244. restoreClipboard()
  245. }
  246. })
  247. it('unmount clears copied feedback', async () => {
  248. const writeText = vi.fn(async () => {})
  249. const restoreClipboard = installClipboard(writeText)
  250. try {
  251. const { view, wrapper } = mount({ copyText: 'value' })
  252. fireEvent.pointerEnter(wrapper)
  253. act(() => { vi.advanceTimersByTime(500) })
  254. await act(async () => { fireEvent.click(screen.getByRole('button')) })
  255. expect(vi.getTimerCount()).toBe(1)
  256. view.unmount()
  257. expect(vi.getTimerCount()).toBe(0)
  258. } finally {
  259. restoreClipboard()
  260. }
  261. })
  262. it('clears copied feedback when the card closes', async () => {
  263. const writeText = vi.fn(async () => {})
  264. const restoreClipboard = installClipboard(writeText)
  265. try {
  266. const { wrapper } = mount({ copyText: 'value', copiedLabel: 'Copied' })
  267. fireEvent.pointerEnter(wrapper)
  268. act(() => { vi.advanceTimersByTime(500) })
  269. await act(async () => { fireEvent.click(screen.getByRole('button')) })
  270. expect(screen.getByRole('status').textContent).toBe('Copied')
  271. fireEvent.pointerLeave(wrapper)
  272. act(() => { vi.advanceTimersByTime(POINTER_GRACE_MS) })
  273. expect(screen.queryByText('Copied')).toBeNull()
  274. fireEvent.pointerEnter(wrapper)
  275. act(() => { vi.advanceTimersByTime(500) })
  276. expect(screen.getByText('card body')).toBeTruthy()
  277. } finally {
  278. restoreClipboard()
  279. }
  280. })
  281. it('does not create copied feedback after an in-flight write unmounts', async () => {
  282. let acceptWrite: (() => void) | undefined
  283. const writeText = vi.fn(() => new Promise<void>((resolve) => { acceptWrite = resolve }))
  284. const restoreClipboard = installClipboard(writeText)
  285. try {
  286. const { view, wrapper } = mount({ copyText: 'value' })
  287. fireEvent.pointerEnter(wrapper)
  288. act(() => { vi.advanceTimersByTime(500) })
  289. fireEvent.click(screen.getByRole('button'))
  290. expect(writeText).toHaveBeenCalledOnce()
  291. view.unmount()
  292. await act(async () => { acceptWrite?.() })
  293. expect(vi.getTimerCount()).toBe(0)
  294. } finally {
  295. restoreClipboard()
  296. }
  297. })
  298. it('does not restore copied feedback after an in-flight card closes', async () => {
  299. let acceptWrite: (() => void) | undefined
  300. const writeText = vi.fn(() => new Promise<void>((resolve) => { acceptWrite = resolve }))
  301. const restoreClipboard = installClipboard(writeText)
  302. try {
  303. const { wrapper } = mount({ copyText: 'value', copiedLabel: 'Copied' })
  304. fireEvent.pointerEnter(wrapper)
  305. act(() => { vi.advanceTimersByTime(500) })
  306. fireEvent.click(screen.getByRole('button'))
  307. fireEvent.pointerLeave(wrapper)
  308. act(() => { vi.advanceTimersByTime(POINTER_GRACE_MS) })
  309. fireEvent.pointerEnter(wrapper)
  310. act(() => { vi.advanceTimersByTime(500) })
  311. await act(async () => { acceptWrite?.() })
  312. expect(vi.getTimerCount()).toBe(0)
  313. expect(screen.getByText('card body')).toBeTruthy()
  314. } finally {
  315. restoreClipboard()
  316. }
  317. })
  318. it('coalesces activations while the clipboard write is in flight', async () => {
  319. let acceptWrite: (() => void) | undefined
  320. const writeText = vi.fn(() => new Promise<void>((resolve) => { acceptWrite = resolve }))
  321. const restoreClipboard = installClipboard(writeText)
  322. try {
  323. const { wrapper } = mount({ copyText: 'value', copiedLabel: 'Copied' })
  324. fireEvent.pointerEnter(wrapper)
  325. act(() => { vi.advanceTimersByTime(500) })
  326. const card = screen.getByRole('button')
  327. fireEvent.click(card)
  328. fireEvent.click(card)
  329. expect(writeText).toHaveBeenCalledOnce()
  330. await act(async () => { acceptWrite?.() })
  331. expect(screen.getByRole('status').textContent).toBe('Copied')
  332. } finally {
  333. restoreClipboard()
  334. }
  335. })
  336. it('disabled suppresses opening entirely', () => {
  337. const { wrapper } = mount({ disabled: true })
  338. fireEvent.pointerEnter(wrapper)
  339. act(() => { vi.advanceTimersByTime(1000) })
  340. expect(screen.queryByText('card body')).toBeNull()
  341. })
  342. it('flipping disabled true closes an open card', () => {
  343. const { view, wrapper } = mount()
  344. fireEvent.pointerEnter(wrapper)
  345. act(() => { vi.advanceTimersByTime(500) })
  346. expect(screen.getByText('card body')).toBeTruthy()
  347. view.rerender(<HoverCard anchor={<span>row</span>} content={<div>card body</div>} disabled />)
  348. expect(screen.queryByText('card body')).toBeNull()
  349. })
  350. it('corrects the bottom-edge clamp once the mounted card height is measurable', () => {
  351. // First placement reads height 0 (card not yet mounted) and keeps the
  352. // anchor top; the post-mount correction re-clamps with the real height.
  353. window.innerHeight = 300
  354. const offsetHeight = Object.getOwnPropertyDescriptor(HTMLElement.prototype, 'offsetHeight')!
  355. Object.defineProperty(HTMLElement.prototype, 'offsetHeight', { configurable: true, get: () => 120 })
  356. try {
  357. const { wrapper } = mount()
  358. stubAnchorRect(screen.getByText('row'), { top: 280, right: 200 })
  359. fireEvent.pointerEnter(wrapper)
  360. act(() => { vi.advanceTimersByTime(500) })
  361. const card = screen.getByText('card body').parentElement as HTMLElement
  362. // 300 - 120 - 8 = 172, instead of the anchor top 280.
  363. expect(card.style.top).toBe('172px')
  364. } finally {
  365. Object.defineProperty(HTMLElement.prototype, 'offsetHeight', offsetHeight)
  366. }
  367. })
  368. it('clamps inside placement itself when the card is already measured (resize path)', () => {
  369. window.innerHeight = 300
  370. const { wrapper } = mount()
  371. stubAnchorRect(screen.getByText('row'), { top: 280, right: 200 })
  372. fireEvent.pointerEnter(wrapper)
  373. act(() => { vi.advanceTimersByTime(500) })
  374. const card = screen.getByText('card body').parentElement as HTMLElement
  375. Object.defineProperty(card, 'offsetHeight', { value: 120 })
  376. act(() => { fireEvent.resize(window) })
  377. expect(card.style.top).toBe('172px')
  378. })
  379. it('repositions on capture-phase scroll while open and stops listening after close', () => {
  380. const { wrapper } = mount()
  381. fireEvent.pointerEnter(wrapper)
  382. act(() => { vi.advanceTimersByTime(500) })
  383. stubAnchorRect(screen.getByText('row'), { top: 90, right: 300 })
  384. act(() => { fireEvent.scroll(document) })
  385. const card = screen.getByText('card body').parentElement as HTMLElement
  386. expect(card.style.left).toBe('308px')
  387. expect(card.style.top).toBe('90px')
  388. fireEvent.pointerLeave(wrapper)
  389. act(() => { vi.advanceTimersByTime(POINTER_GRACE_MS) })
  390. expect(screen.queryByText('card body')).toBeNull()
  391. })
  392. it('unmount clears a pending open timer', () => {
  393. const { view, wrapper } = mount()
  394. fireEvent.pointerEnter(wrapper)
  395. view.unmount()
  396. act(() => { vi.advanceTimersByTime(1000) })
  397. expect(screen.queryByText('card body')).toBeNull()
  398. })
  399. })