ci-workflow.spec.ts 50 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670671672673674675676677678679680681682683684685686687688689690691692693694695696697698699700701702703704705706707708709710711712713714715716717718719720721722723724725726727728729730731732733734735736737738739740741742743744745746747748749750751752753754755756757758759760761762763764765766767768769770771772773774775776777778779780781782783784785786787788789790791792793794795796797798799800801802803804805806807808809810811812813814815816817818819820821822823824825826827828829830831832833834835836837838839840841842843844845846847848849850851852853854855856857858859860861862863864865866867868869870871872873874875876877878879880881882883884885886887888889890891892893894895896897898899900901902903904905906907908909910911912913914915916917918919920921922923
  1. import { readFileSync } from 'node:fs'
  2. import { resolve } from 'node:path'
  3. import * as yaml from 'js-yaml'
  4. import { describe, expect, it } from 'vitest'
  5. const root = resolve(import.meta.dirname, '..')
  6. const runnerPrivatePnpmDestination = /^\$\{\{ runner\.temp \}\}\/setup-pnpm-\$\{\{ github\.run_id \}\}-\$\{\{ github\.run_attempt \}\}$/
  7. const nativeWindowsPnpmDestination = '${{ runner.temp }}/setup-pnpm-js-${{ github.run_id }}-${{ github.run_attempt }}-${{ github.job }}'
  8. describe('CI workflow', () => {
  9. it('isolates every pnpm action setup destination per runner', () => {
  10. const files = ['.github/workflows/ci.yml', '.github/workflows/ci-master.yml']
  11. const setups: Array<{ jobName: string; step: unknown }> = []
  12. for (const file of files) {
  13. const workflow: unknown = yaml.load(readFileSync(resolve(root, file), 'utf8'))
  14. if (!isRecord(workflow) || !isRecord(workflow.jobs)) throw new TypeError(`${file} must define jobs`)
  15. for (const [jobName, job] of Object.entries(workflow.jobs)) {
  16. if (!isRecord(job) || !Array.isArray(job.steps)) continue
  17. for (const step of job.steps) {
  18. if (!isRecord(step) || typeof step.uses !== 'string' || !step.uses.startsWith('pnpm/action-setup@')) continue
  19. setups.push({ jobName, step })
  20. }
  21. }
  22. }
  23. expect(setups.length).toBeGreaterThan(0)
  24. for (const { jobName, step } of setups) {
  25. const stepDest = (step as { with?: { dest?: unknown } }).with?.dest
  26. if (jobName.startsWith('windows-')) {
  27. expect(stepDest, `${jobName} must use the native Windows pnpm destination`).toBe(nativeWindowsPnpmDestination)
  28. expect(step).not.toMatchObject({ with: { standalone: true } })
  29. } else {
  30. expect(typeof stepDest, `${jobName} must use a runner-and-run-private pnpm destination`).toBe('string')
  31. expect(stepDest as string).toMatch(runnerPrivatePnpmDestination)
  32. }
  33. }
  34. })
  35. it('isolates the python SDK exe pnpm setup destination per job', () => {
  36. const workflow: unknown = yaml.load(readFileSync(resolve(root, '.github/workflows/build-exe-for-python-sdk.yml'), 'utf8'))
  37. if (!isRecord(workflow) || !isRecord(workflow.jobs)) throw new TypeError('build-exe-for-python-sdk.yml must define jobs')
  38. const setups: Array<{ step: unknown }> = []
  39. for (const job of Object.values(workflow.jobs)) {
  40. if (!isRecord(job) || !Array.isArray(job.steps)) continue
  41. for (const step of job.steps) {
  42. if (!isRecord(step) || typeof step.uses !== 'string' || !step.uses.startsWith('pnpm/action-setup@')) continue
  43. setups.push({ step })
  44. }
  45. }
  46. expect(setups.length).toBeGreaterThan(0)
  47. for (const { step } of setups) {
  48. expect(step).toMatchObject({
  49. with: { dest: nativeWindowsPnpmDestination },
  50. })
  51. }
  52. })
  53. it('keeps split native Windows PR jobs with failover, plus a master-only standby', () => {
  54. const workflow = loadWorkflow('.github/workflows/ci.yml')
  55. const masterWorkflow = loadWorkflow('.github/workflows/ci-master.yml')
  56. if (!isRecord(workflow.jobs)
  57. || !isRecord(workflow.jobs['windows-build'])
  58. || !isRecord(workflow.jobs['windows-coverage'])
  59. || !isRecord(workflow.jobs['windows-native-tests'])
  60. || !isRecord(workflow.jobs['windows-observational'])
  61. || !isRecord(workflow.jobs['node-24'])
  62. || !isRecord(workflow.jobs['node-24-coverage'])
  63. || !isRecord(workflow.jobs['node-24-bench'])
  64. || !isRecord(workflow.jobs['node-24-consumers'])
  65. || !isRecord(workflow.jobs['node-compat'])
  66. || !isRecord(workflow.jobs['all-checks-passed'])
  67. || !isRecord(masterWorkflow.jobs)
  68. || !isRecord(masterWorkflow.jobs['serial-windows'])) {
  69. throw new TypeError('CI workflow must define windows-build, windows-coverage, windows-native-tests, windows-observational, node-24, node-24-coverage, node-24-bench, node-24-consumers, node-compat, and all-checks-passed; ci-master must define serial-windows')
  70. }
  71. const windowsBuild = workflow.jobs['windows-build']
  72. const windowsCoverage = workflow.jobs['windows-coverage']
  73. const windowsNativeTests = workflow.jobs['windows-native-tests']
  74. const windowsObservational = workflow.jobs['windows-observational']
  75. const serialWindows = masterWorkflow.jobs['serial-windows']
  76. const node24 = workflow.jobs['node-24']
  77. const node24Coverage = workflow.jobs['node-24-coverage']
  78. const node24Bench = workflow.jobs['node-24-bench']
  79. const node24Consumers = workflow.jobs['node-24-consumers']
  80. const nodeCompat = workflow.jobs['node-compat']
  81. const aggregate = workflow.jobs['all-checks-passed']
  82. if (!Array.isArray(aggregate.needs)) {
  83. throw new TypeError('CI aggregate must define needs')
  84. }
  85. // The split native jobs all resolve their pool through the Windows switch.
  86. for (const [jobName, job] of [['windows-build', windowsBuild], ['windows-coverage', windowsCoverage], ['windows-native-tests', windowsNativeTests], ['windows-observational', windowsObservational]] as const) {
  87. expect(typeof job['runs-on']).toBe('string')
  88. expect(job['runs-on'], `${jobName} runs-on must use the Windows failover switch`).toContain('DSH_CI_FAILOVER_WINDOWS')
  89. expect(job['runs-on'], `${jobName} runs-on must not use the Linux failover switch`).not.toContain('DSH_CI_FAILOVER_LINUX')
  90. expect(job['runs-on']).toContain('self-hosted')
  91. expect(job['runs-on']).toContain('dsh-win-ci')
  92. expect(job['runs-on']).toContain('dsh-windows-2025-16core')
  93. expect(job.if).toBe("github.event_name == 'pull_request'")
  94. }
  95. // windows-build runs the blocking build/site pair.
  96. expect(windowsBuild.name).toBe('windows node 24 / build')
  97. const buildSteps = windowsBuild.steps as unknown[]
  98. const buildCommands = buildSteps.filter((step): step is Record<string, unknown> & { run: string } => (
  99. isRecord(step) && typeof step.run === 'string'
  100. ))
  101. expect(buildCommands.map(step => step.run)).toContain('pnpm run check:ci:windows-blocking')
  102. // The four native Windows installs branch on the workspace filesystem:
  103. // clone (ReFS block clone) only on ReFS, plain install elsewhere. This
  104. // keeps the TS6231 store-path leak (see the Windows ReFS store note) out
  105. // of the self-hosted pool without forcing clone onto hosted NTFS, which
  106. // rejects copy-on-write. The branch must stay, or a hosted fallback would
  107. // fail installs with ERR_PNPM_LINKING_FAILED.
  108. for (const [jobName, job] of [['windows-build', windowsBuild], ['windows-coverage', windowsCoverage], ['windows-native-tests', windowsNativeTests], ['windows-observational', windowsObservational]] as const) {
  109. const steps = job.steps as unknown[]
  110. const install = steps.find((step): step is Record<string, unknown> & { run: string } => (
  111. isRecord(step) && step.name === 'Install (immutable)' && typeof step.run === 'string'
  112. ))
  113. expect(install, `${jobName} must define the filesystem-branched install`).toBeDefined()
  114. expect(install!.run).toContain("$fs -eq 'ReFS'")
  115. expect(install!.run).toContain('--package-import-method=clone')
  116. expect(install!.run).toContain('corepack pnpm install')
  117. // The else branch must keep the plain hosted install as a distinct line
  118. // (not the corepack clone line, which contains the same substring);
  119. // dropping it or making both branches clone would force clone onto
  120. // NTFS, which rejects copy-on-write (ERR_PNPM_LINKING_FAILED). The
  121. // YAML folded block keeps the first statement on line 1 and folds the
  122. // rest with leading two-space indents.
  123. const installLines = install!.run.split('\n').map(line => line.trim())
  124. expect(installLines).toContain('} else {')
  125. expect(installLines.some(line => line === 'pnpm install --frozen-lockfile'), `${jobName} else branch must keep the plain hosted install`).toBe(true)
  126. // The ReFS branch must not use the interpolated empty-flag form, which
  127. // passes a stray "" positional argument to pnpm.
  128. expect(install!.run).not.toContain('$cloneFlag')
  129. }
  130. // windows-coverage uses the lower 4-partition profile.
  131. expect(windowsCoverage.name).toBe('windows node 24 / coverage')
  132. expect(windowsCoverage.env).toMatchObject({ DSH_COVERAGE_PARTITIONS: '4' })
  133. const coverageSteps = windowsCoverage.steps as unknown[]
  134. const coverageCommands = coverageSteps.filter((step): step is Record<string, unknown> & { run: string } => (
  135. isRecord(step) && typeof step.run === 'string'
  136. ))
  137. expect(coverageCommands.map(step => step.run)).toContain('pnpm run check:ci:coverage')
  138. // Windows coverage runs zero-build like the Linux lane: workspace imports
  139. // resolve to src through the tsconfig paths map, and the lib-consuming
  140. // suites (webworker-packer image-loadable, webworker-runtime
  141. // transform-corpus, client ui-trajectory client-bundle) self-skip on
  142. // unbuilt checkouts. The regex catches a regression spelled as
  143. // 'corepack pnpm run build' or folded into a multi-line run block, which
  144. // an exact string match would miss.
  145. expect(coverageCommands.every(step => !/\bpnpm\s+run\s+build(?:\s|$)/.test(step.run))).toBe(true)
  146. // windows-native-tests runs the Windows-specific specs.
  147. expect(windowsNativeTests.name).toBe('windows node 24 / native tests')
  148. const nativeTestSteps = windowsNativeTests.steps as unknown[]
  149. const nativeTestCommands = nativeTestSteps.filter((step): step is Record<string, unknown> & { run: string } => (
  150. isRecord(step) && typeof step.run === 'string'
  151. ))
  152. const nativeTestCommand = nativeTestCommands.map(step => step.run).join('\n')
  153. expect(nativeTestCommand).toContain('--no-file-parallelism')
  154. expect(nativeTestCommand).toContain('--testTimeout 90000')
  155. expect(nativeTestCommand).toContain('tool-pwsh/tests/loader.spec.ts')
  156. expect(nativeTestCommand).toContain('workflow-worker-thread.spec.ts')
  157. // windows-observational is non-blocking.
  158. expect(windowsObservational.name).toBe('windows node 24 / observational')
  159. expect(windowsObservational['continue-on-error']).toBe(true)
  160. // serial-windows: master-only standby, self-hosted, non-blocking, lives in ci-master.
  161. expect(serialWindows.if).toBe("github.event_name == 'push' && github.ref == 'refs/heads/master'")
  162. expect(serialWindows['runs-on']).toEqual(['self-hosted', 'dsh-win-ci', 'windows'])
  163. expect(serialWindows.name).toBe('serial / windows (self-hosted standby)')
  164. // Its store must share the ReFS workspace volume for clone; the install
  165. // must carry the same filesystem branch as the PR jobs.
  166. const serialSteps = serialWindows.steps as unknown[]
  167. const serialStore = serialSteps.find((step): step is Record<string, unknown> & { run: string } => (
  168. isRecord(step) && step.name === 'Configure persistent pnpm store' && typeof step.run === 'string'
  169. ))
  170. expect(serialStore).toBeDefined()
  171. expect(serialStore!.run).toContain('F:\\.pnpm-store')
  172. const serialInstall = serialSteps.find((step): step is Record<string, unknown> & { run: string } => (
  173. isRecord(step) && step.name === 'Install (immutable)' && typeof step.run === 'string'
  174. ))
  175. expect(serialInstall).toBeDefined()
  176. expect(serialInstall!.run).toContain("$fs -eq 'ReFS'")
  177. expect(serialInstall!.run).toContain('--package-import-method=clone')
  178. expect(serialInstall!.run).toContain('corepack pnpm install')
  179. // Distinct else-branch line, as for the PR jobs: the corepack clone line
  180. // contains the plain-install substring too.
  181. expect(serialInstall!.run.split('\n').map(line => line.trim())).toContain('} else {')
  182. expect(serialInstall!.run.split('\n').map(line => line.trim())).toContain('pnpm install --frozen-lockfile')
  183. expect(serialInstall!.run).not.toContain('$cloneFlag')
  184. // The unsharded reference runs the whole coverage inventory at the same
  185. // per-test budget the PR coverage lane grants; the default 5000ms times
  186. // out load-sensitive store scans (e.g. gen-third-party-notices).
  187. const serialGate = serialSteps.find((step): step is Record<string, unknown> & { env?: Record<string, unknown> } => (
  188. isRecord(step) && step.name === 'Run complete unsharded Windows gate inventory serially'
  189. ))
  190. expect(serialGate).toBeDefined()
  191. expect(serialGate!.env).toMatchObject({ DSH_COVERAGE_TEST_TIMEOUT_MS: '90000' })
  192. // windows-coverage is temporarily non-blocking while Windows ACP
  193. // half-close tests are stabilized; observational stays out too.
  194. expect(aggregate.needs).not.toContain('windows')
  195. expect(aggregate.needs).toContain('windows-build')
  196. // The benchmark lane is a required verdict input and runs alone so its
  197. // wall-clock budgets never share a runner with a concurrent aggregate.
  198. expect(aggregate.needs).toContain('node-24-bench')
  199. expect(node24Bench.name).toBe('node 24 / benchmarks')
  200. expect(node24Bench.env).toBeUndefined()
  201. expect(node24Bench.steps).toContainEqual({
  202. name: 'Install benchmark browser and hosted dependencies',
  203. run: 'pnpm --filter @deepseek-ai/dsh-benchmarks exec playwright install --with-deps chromium',
  204. })
  205. expect(JSON.stringify(node24Bench.steps)).not.toContain('DSH_CI_FAILOVER_LINUX')
  206. expect(node24Bench.steps).toContainEqual({
  207. name: 'Run performance benchmarks',
  208. env: { DSH_GATE_VERBOSE: '1' },
  209. run: 'pnpm run check:ci:bench',
  210. })
  211. expect(aggregate.needs).not.toContain('windows-coverage')
  212. expect(aggregate.needs).toContain('windows-native-tests')
  213. expect(aggregate.needs).not.toContain('windows-observational')
  214. expect(aggregate.needs).not.toContain('serial-windows')
  215. // Linux failover is a separate switch: the three enterprise Linux workers
  216. // and the verdict job resolve their pool through DSH_CI_FAILOVER_LINUX,
  217. // never the Windows switch.
  218. for (const [jobName, job] of [['node-24', node24], ['node-24-coverage', node24Coverage], ['node-24-consumers', node24Consumers]] as const) {
  219. expect(typeof job['runs-on']).toBe('string')
  220. expect(job['runs-on'], `${jobName} runs-on must use the Linux failover switch`).toContain('DSH_CI_FAILOVER_LINUX')
  221. expect(job['runs-on'], `${jobName} runs-on must not use the Windows failover switch`).not.toContain('DSH_CI_FAILOVER_WINDOWS')
  222. expect(job['runs-on']).toContain('vm-backup')
  223. }
  224. expect(aggregate['runs-on']).toContain('DSH_CI_FAILOVER_LINUX')
  225. expect(aggregate['runs-on']).not.toContain('DSH_CI_FAILOVER_WINDOWS')
  226. expect(aggregate['runs-on']).toContain('vm-backup')
  227. // The run-gates aggregate lanes stop at the first blocking gate failure so
  228. // a red aggregate does not keep burning runner time on the remaining
  229. // gates. Removing the flag silently reverts to running every independent
  230. // gate to completion.
  231. for (const [jobName, job] of [['node-24', node24], ['node-24-coverage', node24Coverage], ['node-24-consumers', node24Consumers], ['node-compat', nodeCompat]] as const) {
  232. expect(job.env, `${jobName} must enable fail-fast`).toMatchObject({ DSH_GATE_FAIL_FAST: '1' })
  233. }
  234. // The native Windows lanes with run-gates aggregates fail fast for the
  235. // same reason: a failing gate aborts the sibling gate instead of waiting
  236. // out the multi-minute instrumented coverage run.
  237. expect(windowsBuild.env, 'windows-build must enable fail-fast').toMatchObject({ DSH_GATE_FAIL_FAST: '1' })
  238. expect(windowsCoverage.env, 'windows-coverage must enable fail-fast').toMatchObject({ DSH_GATE_FAIL_FAST: '1' })
  239. // The observational lane stays complete: it is continue-on-error by design
  240. // and exists to collect as much Windows-native evidence per run as
  241. // possible, so the first failure must not truncate the rest.
  242. expect(windowsObservational.env).toBeDefined()
  243. expect(windowsObservational.env).not.toMatchObject({ DSH_GATE_FAIL_FAST: '1' })
  244. })
  245. it('runs required benchmarks on standard hosted Linux independently of failover', () => {
  246. const workflow = loadWorkflow('.github/workflows/ci.yml')
  247. const benchmark = workflowJob(workflow, 'node-24-bench')
  248. const aggregate = workflowJob(workflow, 'all-checks-passed')
  249. expect(benchmark['runs-on']).toBe('ubuntu-24.04')
  250. expect(benchmark.if).toBe("github.event_name == 'pull_request'")
  251. expect(benchmark.needs).toBeUndefined()
  252. expect(benchmark['continue-on-error']).toBeUndefined()
  253. expect(benchmark.env).toBeUndefined()
  254. expect(aggregate.needs).toContain('node-24-bench')
  255. })
  256. it('always restores the hosted benchmark pnpm cache', () => {
  257. const benchmark = workflowJob(loadWorkflow('.github/workflows/ci.yml'), 'node-24-bench')
  258. if (!Array.isArray(benchmark.steps)) throw new TypeError('benchmark job must define steps')
  259. const caches = benchmark.steps.filter(step => isRecord(step) && step.uses === 'actions/cache/restore@v4')
  260. expect(caches).toHaveLength(1)
  261. expect(caches[0]).not.toHaveProperty('if')
  262. expect(caches[0]).toMatchObject({
  263. with: {
  264. path: '${{ steps.pnpm-store.outputs.path }}',
  265. key: "${{ runner.os }}-node-${{ env.PRIMARY_NODE_VERSION }}-pnpm-${{ hashFiles('pnpm-lock.yaml') }}",
  266. },
  267. })
  268. })
  269. it('bounds the complete benchmark job to fifteen minutes', () => {
  270. const benchmark = workflowJob(loadWorkflow('.github/workflows/ci.yml'), 'node-24-bench')
  271. expect(benchmark['timeout-minutes']).toBe(15)
  272. expect(benchmark.steps).toContainEqual({
  273. name: 'Run performance benchmarks',
  274. env: { DSH_GATE_VERBOSE: '1' },
  275. run: 'pnpm run check:ci:bench',
  276. })
  277. })
  278. it('gives the Wine Host TypeScript compile the repository heap budget', () => {
  279. const wineGates = readFileSync(resolve(root, 'scripts/wine-windows-gates.sh'), 'utf8')
  280. expect(wineGates).toContain(
  281. 'wine_node "$scratch/logs/host-tsc.log" --max-old-space-size=4096 "$tsc_js" -b tsconfig.host.json --pretty false',
  282. )
  283. })
  284. it('exempts push from cancellation in ci-master, so one master merge does not cancel the running drill', () => {
  285. const workflow = loadWorkflow('.github/workflows/ci-master.yml')
  286. const prWorkflow = loadWorkflow('.github/workflows/ci.yml')
  287. if (!isRecord(workflow.jobs) || !isRecord(workflow.concurrency)) {
  288. throw new TypeError('ci-master workflow must define jobs and a workflow-level concurrency block')
  289. }
  290. if (!isRecord(prWorkflow.jobs)) {
  291. throw new TypeError('ci workflow must define jobs')
  292. }
  293. // Cancellation applies to the whole superseded RUN, so this has to be
  294. // decided at workflow level and gated on the event: a job-level group
  295. // cannot exempt its job from its run being cancelled. Only push is exempt —
  296. // a drill takes longer than the interval between master merges. The negated
  297. // form is load-bearing: `== 'pull_request'` would also stop cancelling
  298. // workflow_dispatch, and a re-dispatched runner benchmark holds up to 12
  299. // larger runners for 15 minutes in this same group on master.
  300. expect(workflow.concurrency['cancel-in-progress']).toBe("${{ github.event_name != 'push' }}")
  301. // The PR-only ci.yml still cancels a superseded run on a new push, so a
  302. // fresh head does not stack a second full 9-job run behind a stale one.
  303. // Unlike ci-master it has no push carve-out: every PR event supersedes.
  304. expect(prWorkflow.concurrency).toMatchObject({
  305. 'cancel-in-progress': true,
  306. })
  307. // The exact event sets are what keep master-only jobs out of the PR check
  308. // panel: ci-master triggers only on push(master) + workflow_dispatch and
  309. // never on pull_request; ci.yml is exactly pull_request-only. Assert the
  310. // full sets so losing the wrong event, or gaining an extra one, fails.
  311. if (!isRecord(workflow.on) || !isRecord(prWorkflow.on)) {
  312. throw new TypeError('both CI workflows must define on')
  313. }
  314. expect(Object.keys(workflow.on).sort()).toEqual(['push', 'workflow_dispatch'])
  315. expect(Object.keys(prWorkflow.on)).toEqual(['pull_request'])
  316. // Neither drill may carry a job-level group: it would not exempt the job
  317. // from run-scoped cancellation.
  318. for (const name of ['serial-linux-selfhosted', 'serial-windows']) {
  319. const job = workflow.jobs[name]
  320. if (!isRecord(job)) throw new TypeError(`${name} must be defined`)
  321. expect(job.concurrency).toBeUndefined()
  322. // Both stay master-push-only; that is what makes the push carve-out safe.
  323. expect(job.if).toBe("github.event_name == 'push' && github.ref == 'refs/heads/master'")
  324. }
  325. // Pin the post-merge runtime, Wine, and standby inventory.
  326. const NOT_PUSH_REACHABLE = new Set([
  327. "github.event_name == 'workflow_dispatch' && inputs.suite == 'larger-runner-benchmark'",
  328. "github.event_name == 'workflow_dispatch' && inputs.suite == 'consolidated-runner-benchmark'",
  329. ])
  330. const pushReachable = Object.entries(workflow.jobs)
  331. .filter(([, job]) => {
  332. if (!isRecord(job)) return false
  333. if (job.if === undefined) return true // unconditional: runs on every event
  334. if (job.if === false) return false // `if: false` parses as a boolean
  335. if (typeof job.if !== 'string') return true // unrecognized shape: surface it
  336. return !NOT_PUSH_REACHABLE.has(job.if.trim())
  337. })
  338. .map(([name]) => name)
  339. .sort()
  340. expect(pushReachable).toEqual(['python-runtime', 'serial-linux-selfhosted', 'serial-windows', 'windows'])
  341. // Why workflow_dispatch must keep cancelling: each benchmark fans out to a
  342. // dozen larger runners at once, in this same group on master. If it stopped
  343. // cancelling, a re-dispatch would queue ahead of a drill instead of
  344. // replacing the stale measurement.
  345. for (const name of ['larger-runner-benchmark', 'consolidated-runner-benchmark']) {
  346. const job = workflow.jobs[name]
  347. if (!isRecord(job) || !isRecord(job.strategy)) {
  348. throw new TypeError(`${name} must define a matrix strategy`)
  349. }
  350. expect(job.strategy['max-parallel']).toBe(12)
  351. expect(job['timeout-minutes']).toBe(15)
  352. }
  353. })
  354. it('redirects the Node compile cache to the data-volume runner temp before the first pnpm call', () => {
  355. const prWorkflow = loadWorkflow('.github/workflows/ci.yml')
  356. const masterWorkflow = loadWorkflow('.github/workflows/ci-master.yml')
  357. const redirectLanes = [
  358. [prWorkflow, 'node-24'],
  359. [prWorkflow, 'node-24-coverage'],
  360. [prWorkflow, 'node-24-consumers'],
  361. [masterWorkflow, 'serial-linux-selfhosted'],
  362. ] as const
  363. for (const [workflow, jobKey] of redirectLanes) {
  364. const job = workflowJob(workflow, jobKey)
  365. if (!Array.isArray(job.steps)) throw new TypeError(`${jobKey} must define steps`)
  366. const redirectStepIndex = job.steps.findIndex((step): step is Record<string, unknown> & { run: string } => (
  367. isRecord(step) && typeof step.run === 'string'
  368. && step.run.includes('NODE_COMPILE_CACHE=${{ runner.temp }}/node-compile-cache')
  369. && step.run.includes('"$GITHUB_ENV"')
  370. ))
  371. // Removing this injection would send every pnpm call in the lane (setup,
  372. // store-path probe, install, and the gate) back to the root partition's
  373. // /tmp; rationale in
  374. // .agents/notes/implemented/process/2026-08-28-ci-node-compile-cache-data-disk.md.
  375. expect(redirectStepIndex, `${jobKey} must inject NODE_COMPILE_CACHE into GITHUB_ENV`).toBeGreaterThan(-1)
  376. const pnpmSetupIndex = job.steps.findIndex((step): step is Record<string, unknown> & { uses: string } => (
  377. isRecord(step) && typeof step.uses === 'string' && step.uses.includes('pnpm/action-setup')
  378. ))
  379. expect(pnpmSetupIndex, `${jobKey} must run pnpm/action-setup`).toBeGreaterThan(-1)
  380. expect(redirectStepIndex, `${jobKey} must redirect before pnpm/action-setup runs pnpm`).toBeLessThan(pnpmSetupIndex)
  381. }
  382. })
  383. it('keeps supported LSP source under native Windows coverage', () => {
  384. const config = readFileSync(resolve(root, 'vitest.config.ts'), 'utf8')
  385. expect(config).not.toContain('packages/lsp/lsp-stdio/src/connection.ts')
  386. expect(config).not.toContain('packages/lsp/lsp-stdio/src/index.ts')
  387. expect(config).not.toContain('packages/lsp/lsp-stdio/src/instance.ts')
  388. })
  389. it('requires release-shaped Python runtime validation on Linux and Windows x64', () => {
  390. const workflow = loadWorkflow('.github/workflows/ci.yml')
  391. const pythonRuntime = workflowJob(workflow, 'python-runtime')
  392. const aggregate = workflowJob(workflow, 'all-checks-passed')
  393. if (!Array.isArray(aggregate.needs)) {
  394. throw new TypeError('CI aggregate must define required job dependencies')
  395. }
  396. expect(pythonRuntime).toMatchObject({
  397. if: "github.event_name == 'pull_request'",
  398. name: 'python runtime / release-shaped matrix',
  399. uses: './.github/workflows/build-exe-for-python-sdk.yml',
  400. with: {
  401. targets: 'node24-linux-x64,node24-win-x64',
  402. ci: true,
  403. },
  404. secrets: {
  405. DEEPSEEK_API_KEY_EXTERNAL: '${{ secrets.DEEPSEEK_API_KEY_EXTERNAL }}',
  406. },
  407. })
  408. expect(aggregate.needs).toContain('python-runtime')
  409. })
  410. it('keeps every Vitest project process-isolated on native Windows', () => {
  411. const config = readFileSync(resolve(root, 'vitest.config.ts'), 'utf8')
  412. expect(config).not.toContain("pool: process.platform === 'win32' ? 'threads' : 'forks'")
  413. expect(config.match(/pool: 'forks'/g)).toHaveLength(2)
  414. })
  415. })
  416. describe('DeepSeek e2e workflow', () => {
  417. it('prepares bubblewrap from the pinned payload without a package transaction', () => {
  418. const workflow = loadWorkflow('.github/workflows/e2e.yml')
  419. const e2e = workflowJob(workflow, 'e2e')
  420. if (!Array.isArray(e2e.steps)) throw new TypeError('DeepSeek e2e workflow must define steps')
  421. const steps = e2e.steps.filter(isRecord)
  422. expect(steps.find(step => step.name === 'Prepare bubblewrap (unrestrict userns)')).toMatchObject({
  423. run: 'bash scripts/prepare-ci-bubblewrap.sh',
  424. })
  425. expect(JSON.stringify(steps)).not.toContain('apt-get')
  426. })
  427. it('bounds profile subprocess fan-out to the tested e2e default', () => {
  428. const workflow = loadWorkflow('.github/workflows/e2e.yml')
  429. const e2e = workflowJob(workflow, 'e2e')
  430. if (!Array.isArray(e2e.steps)) throw new TypeError('DeepSeek e2e workflow must define steps')
  431. const step = e2e.steps.filter(isRecord).find(candidate => candidate.name === 'E2E tests (real DeepSeek API)')
  432. expect(step).toMatchObject({ env: { DSH_E2E_MAX_WORKERS: 4 } })
  433. })
  434. })
  435. describe('E2B e2e workflow', () => {
  436. it('is manual-only and fails loud before running the focused live suite', () => {
  437. const workflow = loadWorkflow('.github/workflows/e2b-e2e.yml')
  438. expect(workflow.on).toEqual({ workflow_dispatch: null })
  439. if (!isRecord(workflow.jobs) || !isRecord(workflow.jobs.e2b) || !Array.isArray(workflow.jobs.e2b.steps)) {
  440. throw new TypeError('E2B e2e workflow must define the e2b job steps')
  441. }
  442. const steps = workflow.jobs.e2b.steps.filter(isRecord)
  443. const preflight = steps.find(step => step.name === 'Preflight (require E2B API key)')
  444. const e2b = steps.find(step => step.name === 'E2B tests (live sandbox)')
  445. expect(preflight).toMatchObject({
  446. env: { E2B_API_KEY: '${{ secrets.E2B_API_KEY_EXTERNAL }}' },
  447. })
  448. expect(preflight?.run).toContain('E2B_API_KEY_EXTERNAL repository secret')
  449. expect(e2b).toMatchObject({
  450. env: {
  451. E2B_API_KEY: '${{ secrets.E2B_API_KEY_EXTERNAL }}',
  452. DSH_E2E_MAX_WORKERS: '1',
  453. DSH_EXAMPLE_MODE: 'lib',
  454. },
  455. })
  456. expect(e2b?.run).toContain('packages/e2b/e2b/tests/composition.e2e.ts')
  457. })
  458. })
  459. describe('Python release workflows', () => {
  460. it('keeps complete wheel validation separate from protected public publication', () => {
  461. const workflow = loadWorkflow('.github/workflows/python-release.yml')
  462. const dispatch = workflowEvent(workflow, 'workflow_dispatch')
  463. const build = workflowJob(workflow, 'build')
  464. const pythonCompat = workflowJob(workflow, 'python-compat')
  465. const validate = workflowJob(workflow, 'validate')
  466. const publishRuntime = workflowJob(workflow, 'publish-runtime')
  467. const publishSdk = workflowJob(workflow, 'publish-sdk')
  468. if (!isRecord(dispatch.inputs)
  469. || !isRecord(dispatch.inputs.publish)
  470. || !Array.isArray(pythonCompat.steps)
  471. || !Array.isArray(validate.steps)
  472. || !Array.isArray(publishRuntime.steps)
  473. || !Array.isArray(publishSdk.steps)) {
  474. throw new TypeError('Python release workflow must define publish input and release steps')
  475. }
  476. expect(dispatch.inputs.publish).toMatchObject({ type: 'boolean', default: false })
  477. if (!isRecord(workflow.on)) throw new TypeError('python-release workflow must define on')
  478. expect(Object.keys(workflow.on)).toEqual(['workflow_dispatch'])
  479. expect(build).toMatchObject({
  480. uses: './.github/workflows/build-exe-for-python-sdk.yml',
  481. with: {
  482. targets: 'node24-linux-x64,node24-linux-arm64,node24-macos-arm64,node24-macos-x64,node24-win-x64',
  483. release: true,
  484. },
  485. })
  486. expect(pythonCompat.strategy).toMatchObject({ matrix: { python: ['3.10', '3.14'] } })
  487. const pythonCompatSteps = JSON.stringify(pythonCompat.steps)
  488. expect(pythonCompatSteps).toContain('dist/deepseek_harness_sdk-$VERSION-py3-none-any.whl')
  489. expect(pythonCompatSteps).toContain('dist/deepseek_harness_runtime_bin-$VERSION-py3-none-manylinux_2_28_x86_64.whl')
  490. expect(pythonCompatSteps).not.toContain('--find-links')
  491. const validateSteps = JSON.stringify(validate.steps)
  492. const authorize = validate.steps.filter(isRecord).find(step => step.name === 'Authorize publication request')
  493. if (!isRecord(authorize) || typeof authorize.run !== 'string') {
  494. throw new TypeError('Python release validation must authorize publication requests')
  495. }
  496. expect(validateSteps).toContain('PUBLIC_PYPI_RELEASE_ENABLED')
  497. expect(authorize).toMatchObject({
  498. env: {
  499. PYPI_PUBLISHER_REPOSITORY: '${{ vars.PYPI_PUBLISHER_REPOSITORY }}',
  500. REPOSITORY: '${{ github.repository }}',
  501. },
  502. })
  503. expect(authorize.run).toContain('[ "$REPOSITORY" = "$PYPI_PUBLISHER_REPOSITORY" ]')
  504. expect(validateSteps).toContain('100000000')
  505. expect(publishRuntime).toMatchObject({
  506. if: "github.event_name == 'workflow_dispatch' && inputs.publish",
  507. needs: 'validate',
  508. environment: 'pypi-runtime',
  509. permissions: { contents: 'read', 'id-token': 'write' },
  510. })
  511. expect(publishSdk).toMatchObject({
  512. if: "github.event_name == 'workflow_dispatch' && inputs.publish",
  513. needs: ['validate', 'publish-runtime'],
  514. environment: 'pypi',
  515. permissions: { contents: 'read', 'id-token': 'write' },
  516. })
  517. const runtimeSteps = publishRuntime.steps.filter(isRecord)
  518. const sdkSteps = publishSdk.steps.filter(isRecord)
  519. const runtimePublish = runtimeSteps.find(step => step.name === 'Publish runtime wheels')
  520. const sdkPublish = sdkSteps.find(step => step.name === 'Publish SDK wheel')
  521. const runtimeHashes = runtimeSteps.find(step => step.name === 'Verify release artifact hashes')
  522. const sdkHashes = sdkSteps.find(step => step.name === 'Verify release artifact hashes')
  523. expect([...runtimeSteps, ...sdkSteps].some(
  524. step => typeof step.uses === 'string' && step.uses.startsWith('actions/checkout@'),
  525. )).toBe(false)
  526. expect([...runtimeSteps, ...sdkSteps].filter(
  527. step => step.uses === 'pypa/gh-action-pypi-publish@release/v1',
  528. )).toHaveLength(2)
  529. expect(runtimePublish).toMatchObject({
  530. with: { 'packages-dir': 'dist/runtime/', attestations: false },
  531. })
  532. expect(sdkPublish).toMatchObject({
  533. with: { 'packages-dir': 'dist/sdk/', attestations: false },
  534. })
  535. expect(runtimeHashes).toMatchObject({ run: 'cd dist && sha256sum -c SHA256SUMS' })
  536. expect(sdkHashes).toMatchObject({ run: 'cd dist && sha256sum -c SHA256SUMS' })
  537. })
  538. it('exposes the native wheel builder to the release caller with normalized versions', () => {
  539. const workflow = loadWorkflow('.github/workflows/build-exe-for-python-sdk.yml')
  540. expect(Object.keys(workflow.on as Record<string, unknown>).sort()).toEqual(['workflow_call', 'workflow_dispatch'])
  541. const call = workflowEvent(workflow, 'workflow_call')
  542. const plan = workflowJob(workflow, 'plan')
  543. const build = workflowJob(workflow, 'build')
  544. if (!isRecord(call.inputs) || !isRecord(call.secrets) || !Array.isArray(plan.steps) || !Array.isArray(build.steps)) {
  545. throw new TypeError('Python wheel builder must define workflow_call inputs and plan steps')
  546. }
  547. const buildSteps: unknown[] = build.steps
  548. const manylinuxAddon = buildSteps.find(step => isRecord(step) && step.name === 'Rebuild Linux node-pty against manylinux 2.28')
  549. const macosCheck = buildSteps.find(step => isRecord(step) && step.name === 'Check macOS payload architecture and deployment target')
  550. const manylinuxSmoke = buildSteps.find(step => isRecord(step) && step.name === 'Run wheel in a manylinux 2.28 container')
  551. const cleanVenvPosix = buildSteps.find(step => isRecord(step) && step.name === 'Install local SDK and runtime wheels into a clean venv (POSIX)')
  552. const cleanVenvWindows = buildSteps.find(step => isRecord(step) && step.name === 'Install local SDK and runtime wheels into a clean venv (Windows)')
  553. const installedKeylessPosix = buildSteps.find(step => isRecord(step) && step.name === 'Run installed-wheel keyless black-box tests (POSIX)')
  554. const installedKeylessWindows = buildSteps.find(step => isRecord(step) && step.name === 'Run installed-wheel keyless black-box tests (Windows)')
  555. const realApiPreflightPosix = buildSteps.find(step => isRecord(step) && step.name === 'Preflight installed-wheel real API test (POSIX)')
  556. const realApiPreflightWindows = buildSteps.find(step => isRecord(step) && step.name === 'Preflight installed-wheel real API test (Windows)')
  557. const installedRealApiPosix = buildSteps.find(step => isRecord(step) && step.name === 'Run installed-wheel real API black-box test (POSIX)')
  558. const installedRealApiWindows = buildSteps.find(step => isRecord(step) && step.name === 'Run installed-wheel real API black-box test (Windows)')
  559. if (!isRecord(macosCheck) || typeof macosCheck.run !== 'string'
  560. || !isRecord(cleanVenvPosix) || !isRecord(cleanVenvWindows)
  561. || !isRecord(installedKeylessPosix) || !isRecord(installedKeylessWindows)
  562. || !isRecord(realApiPreflightPosix) || !isRecord(realApiPreflightWindows)
  563. || !isRecord(installedRealApiPosix) || !isRecord(installedRealApiWindows)) {
  564. throw new TypeError('Python wheel builder must define native POSIX and Windows installed-wheel steps')
  565. }
  566. expect(call.inputs).toHaveProperty('targets')
  567. expect(call.inputs).toMatchObject({
  568. ci: { type: 'boolean', default: false },
  569. release: { type: 'boolean', default: false },
  570. })
  571. expect(call.secrets).toMatchObject({
  572. DEEPSEEK_API_KEY_EXTERNAL: { required: false },
  573. })
  574. expect(workflow.concurrency).toMatchObject({
  575. group: 'build-single-exe-${{ github.workflow }}-${{ github.ref }}',
  576. })
  577. expect(build.defaults).toBeUndefined()
  578. expect(plan.if).toContain('inputs.ci')
  579. expect(plan.if).toContain('inputs.release')
  580. expect(JSON.stringify(plan.steps)).toContain('pep440_version')
  581. const workflowJson = JSON.stringify(workflow)
  582. expect(workflowJson).toContain('macosx_14_0_arm64')
  583. expect(workflowJson).toContain('macosx_14_0_x86_64')
  584. expect(workflowJson).toContain('node24-macos-x64')
  585. expect(workflowJson).toContain('macos-15-intel')
  586. expect(workflowJson).toContain('win_amd64')
  587. expect(workflowJson).toContain('node24-win-x64')
  588. expect(workflowJson).toContain('windows-2025')
  589. expect(workflowJson).toContain('dist-python/$SDK_WHEEL')
  590. expect(workflowJson).toContain('dist-python/$RUNTIME_WHEEL')
  591. expect(workflowJson).toContain('/work/dist-python/$SDK_WHEEL')
  592. expect(workflowJson).toContain('/work/dist-python/$RUNTIME_WHEEL')
  593. expect(workflowJson).not.toContain('--find-links dist-python')
  594. expect(workflowJson).not.toContain('--find-links /work/dist-python')
  595. expect(workflowJson).not.toContain('cygpath')
  596. expect(manylinuxAddon).toMatchObject({ if: "runner.os == 'Linux'" })
  597. expect(JSON.stringify(manylinuxAddon)).toContain('manylinux_2_28_x86_64')
  598. expect(JSON.stringify(manylinuxAddon)).toContain('manylinux_2_28_aarch64')
  599. expect(JSON.stringify(manylinuxAddon)).toContain('npm_config_build_from_source=true pnpm run install')
  600. expect(JSON.stringify(manylinuxAddon)).toContain('pnpm_setup_root')
  601. expect(JSON.stringify(manylinuxAddon)).toContain('$pnpm_setup_root:$pnpm_setup_root:ro')
  602. expect(JSON.stringify(manylinuxAddon)).toContain('node-pty-glibc-versions.txt')
  603. expect(JSON.stringify(manylinuxAddon)).toContain('le 2.28')
  604. expect(macosCheck).toMatchObject({ if: "runner.os == 'macOS'" })
  605. expect(macosCheck.run).toContain('scripts/check-macos-deployment-target.py')
  606. expect(macosCheck.run).toContain('lipo "$payload" -verify_arch')
  607. expect(macosCheck.run).toContain('$EXE-rg')
  608. expect(macosCheck.run).toContain('$EXE-spawn-helper')
  609. expect(JSON.stringify(installedKeylessPosix)).toContain('--scenario all')
  610. expect(JSON.stringify(installedKeylessPosix)).toContain('env -u PYTHONPATH')
  611. expect(JSON.stringify(installedKeylessWindows)).toContain('--scenario all --installed-wheel')
  612. expect(installedKeylessWindows).toMatchObject({ if: "runner.os == 'Windows'", shell: 'pwsh' })
  613. expect(cleanVenvWindows).toMatchObject({ if: "runner.os == 'Windows'", shell: 'pwsh' })
  614. expect(JSON.stringify(cleanVenvWindows)).toContain('Scripts\\\\python.exe')
  615. expect(realApiPreflightPosix).toMatchObject({
  616. env: { DEEPSEEK_API_KEY: '${{ secrets.DEEPSEEK_API_KEY_EXTERNAL }}' },
  617. })
  618. expect(String(realApiPreflightPosix.if)).toContain('inputs.ci')
  619. expect(String(realApiPreflightPosix.if)).toContain('head.repo.fork')
  620. expect(String(realApiPreflightPosix.if)).toContain('dependabot[bot]')
  621. expect(realApiPreflightWindows).toMatchObject({ shell: 'pwsh' })
  622. expect(installedRealApiPosix).toMatchObject({
  623. env: {
  624. DEEPSEEK_API_KEY: '${{ secrets.DEEPSEEK_API_KEY_EXTERNAL }}',
  625. DEEPSEEK_BASE_URL: 'https://api.deepseek.com',
  626. },
  627. })
  628. expect(JSON.stringify(installedRealApiPosix)).toContain('--scenario sdk-live')
  629. expect(JSON.stringify(installedRealApiPosix)).toContain('-u DSH_RUNTIME_MODE')
  630. expect(installedRealApiWindows).toMatchObject({ shell: 'pwsh' })
  631. expect(JSON.stringify(installedRealApiWindows)).toContain('--scenario sdk-live --installed-wheel')
  632. expect(manylinuxSmoke).toMatchObject({ if: "runner.os == 'Linux'" })
  633. expect(JSON.stringify(manylinuxSmoke)).toContain('-e DSH_TELEMETRY_DISABLED')
  634. })
  635. it('uses the shared macOS deployment-target check in GitLab', () => {
  636. const workflow = loadWorkflow('.gitlab-ci.yml')
  637. const runtimeWheel = workflow['.runtime-wheel']
  638. if (!isRecord(runtimeWheel) || !Array.isArray(runtimeWheel.script)) {
  639. throw new TypeError('GitLab CI must define the runtime wheel script')
  640. }
  641. const runtimeScript: unknown[] = runtimeWheel.script
  642. const macosCheck = runtimeScript.find(
  643. step => typeof step === 'string' && step.includes('${PLATFORM#macos-}'),
  644. )
  645. if (typeof macosCheck !== 'string') {
  646. throw new TypeError('GitLab CI must check the macOS deployment target')
  647. }
  648. expect(macosCheck).toContain('scripts/check-macos-deployment-target.py')
  649. expect(macosCheck).toContain('lipo "$payload" -verify_arch')
  650. expect(macosCheck).toContain('"$EXE" "$EXE-rg" "$EXE-spawn-helper"')
  651. })
  652. it('builds the macOS x64 wheel on the matching GitLab runner', () => {
  653. const workflow = loadWorkflow('.gitlab-ci.yml')
  654. const macosX64 = workflow['runtime-macos-x64']
  655. const publish = workflow['publish-python']
  656. if (!isRecord(macosX64) || !isRecord(publish) || !Array.isArray(publish.needs)) {
  657. throw new TypeError('GitLab CI must define the macOS x64 runtime and publication jobs')
  658. }
  659. expect(macosX64.tags).toEqual(['macos-x64'])
  660. expect(macosX64.variables).toMatchObject({ PKG_TARGET: 'node24-macos-x64', PLATFORM: 'macos-x64' })
  661. expect(publish.needs).toContainEqual({ job: 'runtime-macos-x64', artifacts: true })
  662. expect(JSON.stringify(publish.script)).toContain('macosx_14_0_x86_64.whl')
  663. })
  664. it('builds and black-box tests the Windows x64 wheel in GitLab', () => {
  665. const workflow = loadWorkflow('.gitlab-ci.yml')
  666. const windows = workflow['runtime-windows-x64']
  667. const publish = workflow['publish-python']
  668. if (!isRecord(windows) || !Array.isArray(windows.before_script) || !Array.isArray(windows.script)
  669. || !isRecord(publish) || !Array.isArray(publish.needs)) {
  670. throw new TypeError('GitLab CI must define the Windows runtime and aggregate publication jobs')
  671. }
  672. expect(windows.tags).toEqual(['windows-x64'])
  673. expect(windows.variables).toMatchObject({ PKG_TARGET: 'node24-win-x64', PLATFORM: 'win-x64' })
  674. expect(JSON.stringify(windows.before_script)).toContain('.ci-python\\\\Scripts')
  675. expect(JSON.stringify(windows.before_script)).toContain('[IO.Path]::PathSeparator')
  676. expect(JSON.stringify(windows.script)).toContain('win_amd64.whl')
  677. expect(JSON.stringify(windows.script)).toContain('--scenario all --installed-wheel')
  678. expect(publish.needs).toContainEqual({ job: 'runtime-windows-x64', artifacts: true })
  679. })
  680. })
  681. describe('Issue lifecycle workflow', () => {
  682. it('runs the lifecycle job on every PR/review event but gates token and board steps', () => {
  683. const lifecycle = loadWorkflow('.github/workflows/issue-lifecycle.yml')
  684. const policy = loadWorkflow('.github/workflows/issue-policy.yml')
  685. const lifecycleJob = workflowJob(lifecycle, 'lifecycle')
  686. if (!Array.isArray(lifecycleJob.steps)) throw new TypeError('Issue lifecycle job must define steps')
  687. // The job has no job-level `if`, so it is listed on every pull_request /
  688. // pull_request_review event and reports success instead of a gray skip. The
  689. // write-capable steps are gated at step level so approved/commented reviews
  690. // never mint a Project/Issue App token nor touch the board.
  691. expect(lifecycle.on).toHaveProperty('pull_request')
  692. expect(lifecycle.on).toHaveProperty('pull_request_review')
  693. expect(lifecycleJob.if).toBeUndefined()
  694. // Keep the subscription-type gates: issue-lifecycle does not re-subscribe
  695. // ready_for_review (issue-policy owns that) and only reacts to submitted
  696. // review events.
  697. const lifecyclePullRequest = workflowEvent(lifecycle, 'pull_request')
  698. const lifecycleReview = workflowEvent(lifecycle, 'pull_request_review')
  699. expect(lifecyclePullRequest.types).toContain('opened')
  700. expect(lifecyclePullRequest.types).not.toContain('ready_for_review')
  701. expect(lifecyclePullRequest.types).toContain('review_requested')
  702. expect(lifecycleReview.types).toEqual(['submitted'])
  703. const gated = "${{ github.event_name != 'pull_request_review' || github.event.review.state == 'changes_requested' }}"
  704. const steps = lifecycleJob.steps.filter(isRecord)
  705. const tokenStep = steps.find(s => s.name === 'Create project token')
  706. const handleStep = steps.find(s => s.name === 'Handle repository event')
  707. expect(tokenStep).toMatchObject({ if: gated })
  708. expect(handleStep).toMatchObject({ if: gated })
  709. // issue-policy owns PR validation; it is read-only and a real gate.
  710. const policyPullRequest = workflowEvent(policy, 'pull_request')
  711. expect(policyPullRequest.types).toContain('ready_for_review')
  712. })
  713. it('uses a read-only Project token only for human pull request policy metadata', () => {
  714. const policy = loadWorkflow('.github/workflows/issue-policy.yml')
  715. const policyJob = workflowJob(policy, 'policy')
  716. if (!Array.isArray(policyJob.steps)) throw new TypeError('Issue policy job must define steps')
  717. const steps = policyJob.steps.filter(isRecord)
  718. const tokenStep = steps.find(step => step.name === 'Create Project read token')
  719. const validateStep = steps.find(step => step.name === 'Validate pull request')
  720. const humanPullRequest =
  721. "${{ github.event.pull_request.user.type != 'Bot' && github.event.pull_request.user.type != 'App' }}"
  722. expect(tokenStep).toMatchObject({
  723. id: 'app-token',
  724. if: humanPullRequest,
  725. uses: 'actions/create-github-app-token@bcd2ba49218906704ab6c1aa796996da409d3eb1',
  726. with: {
  727. 'client-id': '${{ vars.DSH_ISSUE_APP_CLIENT_ID }}',
  728. 'private-key': '${{ secrets.DSH_ISSUE_APP_PRIVATE_KEY }}',
  729. owner: 'deepseek-harness',
  730. repositories: 'deepseek-harness',
  731. 'permission-issues': 'read',
  732. 'permission-organization-projects': 'read',
  733. },
  734. })
  735. expect(validateStep).toMatchObject({
  736. if: humanPullRequest,
  737. env: {
  738. GITHUB_TOKEN: '${{ github.token }}',
  739. PROJECT_TOKEN: '${{ steps.app-token.outputs.token }}',
  740. },
  741. })
  742. })
  743. })
  744. describe('npm release workflows', () => {
  745. it('keeps publication dispatch-only and pack in the PR workflow', () => {
  746. // pack stays in the PR/master release workflows so a PR proves the set packs.
  747. for (const file of ['release.yml', 'release-vendor.yml']) {
  748. const workflow = loadWorkflow(`.github/workflows/${file}`)
  749. if (!isRecord(workflow.jobs)) throw new TypeError(`${file} must define jobs`)
  750. expect(Object.keys(workflow.jobs).sort()).toEqual(file === 'release.yml' ? ['dependencies', 'pack'] : ['pack'])
  751. }
  752. // publication is workflow_dispatch-only (never a PR check) and keeps the
  753. // npm-publish environment plus the shared dist-tag group.
  754. for (const file of ['release-publish.yml', 'release-vendor-publish.yml']) {
  755. const workflow = loadWorkflow(`.github/workflows/${file}`)
  756. if (!isRecord(workflow.on) || !isRecord(workflow.jobs)) throw new TypeError(`${file} must define on and jobs`)
  757. expect(Object.keys(workflow.on)).toEqual(['workflow_dispatch'])
  758. const publish = workflow.jobs.publish
  759. if (!isRecord(publish)) throw new TypeError(`${file} must define a publish job`)
  760. expect(publish.environment).toBe('npm-publish')
  761. expect(publish.concurrency).toMatchObject({ group: 'Release-publish' })
  762. }
  763. })
  764. it('runs dependency policy and npm layout checks in the DSH release workflow', () => {
  765. const workflow = loadWorkflow('.github/workflows/release.yml')
  766. const dependencies = workflowJob(workflow, 'dependencies')
  767. if (!isRecord(workflow.on) || !Array.isArray(dependencies.steps)) {
  768. throw new TypeError('DSH release workflow must define triggers and dependency steps')
  769. }
  770. const commands = dependencies.steps.flatMap(step =>
  771. isRecord(step) && typeof step.run === 'string' ? [step.run] : [])
  772. expect(Object.keys(workflow.on).sort()).toEqual(['pull_request', 'push', 'workflow_dispatch'])
  773. expect(commands).toContain('pnpm run verify-package-dependencies')
  774. expect(commands).toContain('pnpm run verify-npm-install-layout')
  775. })
  776. })
  777. describe('Documentation site publication', () => {
  778. it('keeps Pages deployment dispatch-only from a dsh-v* tag', () => {
  779. const workflow = loadWorkflow('.github/workflows/docs-pages.yml')
  780. const build = workflowJob(workflow, 'build')
  781. const deploy = workflowJob(workflow, 'deploy')
  782. if (!isRecord(workflow.on) || !isRecord(workflow.env) || !Array.isArray(build.steps)) {
  783. throw new TypeError('Documentation deployment must define on, env, and build steps')
  784. }
  785. // The site presents a released snapshot: a merge must never publish it, and
  786. // publication must never appear as a PR check.
  787. expect(Object.keys(workflow.on)).toEqual(['workflow_dispatch'])
  788. // RELEASE_PUBLISH makes release:verify reject every ref that is not a dsh-v*
  789. // tag naming this tree's version, so the site and the npm sequence share one
  790. // definition of a released version.
  791. const steps = build.steps.filter(isRecord)
  792. const verify = steps.find(step => step.name === 'Verify release version')
  793. const checkout = steps.find(
  794. step => typeof step.uses === 'string' && step.uses.startsWith('actions/checkout@'),
  795. )
  796. expect(verify).toMatchObject({
  797. env: { RELEASE_PUBLISH: 'true' },
  798. run: 'pnpm run release:verify --family dsh',
  799. })
  800. // Complete history: the release scripts read tags.
  801. expect(checkout).toMatchObject({ with: { 'fetch-depth': 0 } })
  802. // Projected source links stay on the public repository's master. That
  803. // repository advances only to each release commit, so its master never
  804. // carries unreleased work, while it retains only the most recent tags:
  805. // following the dispatched tag would leave every source link on a deploy
  806. // from an older tag unresolvable.
  807. expect(workflow.env.DOCS_REPOSITORY_REF).toBe('master')
  808. // The environment owns the deployment tag policy and the required reviewers.
  809. expect(deploy.environment).toMatchObject({ name: 'github-pages' })
  810. })
  811. })
  812. describe('Git hooks', () => {
  813. it('leaves frozen Agent Note sidecars to the archive verifier', () => {
  814. const lefthook = loadWorkflow('lefthook.yml')
  815. for (const hookName of ['pre-commit', 'pre-merge-commit']) {
  816. const hook = lefthook[hookName]
  817. if (!isRecord(hook) || !Array.isArray(hook.jobs)) {
  818. throw new TypeError(`lefthook must define ${hookName} jobs`)
  819. }
  820. const pairing: unknown = hook.jobs.find(
  821. (job: unknown) => isRecord(job) && job.name === 'translation pairing (staged records)',
  822. )
  823. expect(pairing).toMatchObject({ exclude: ['.agents/notes/archived/**'] })
  824. }
  825. })
  826. })
  827. function loadWorkflow(path: string): Record<string, unknown> {
  828. const workflow: unknown = yaml.load(readFileSync(resolve(root, path), 'utf8'))
  829. if (!isRecord(workflow)) throw new TypeError(`${path} must define a workflow`)
  830. return workflow
  831. }
  832. function workflowEvent(workflow: Record<string, unknown>, event: string): Record<string, unknown> {
  833. if (!isRecord(workflow.on) || !isRecord(workflow.on[event])) {
  834. throw new TypeError(`workflow must define the ${event} event`)
  835. }
  836. return workflow.on[event]
  837. }
  838. function workflowJob(workflow: Record<string, unknown>, job: string): Record<string, unknown> {
  839. if (!isRecord(workflow.jobs) || !isRecord(workflow.jobs[job])) {
  840. throw new TypeError(`workflow must define the ${job} job`)
  841. }
  842. return workflow.jobs[job]
  843. }
  844. function isRecord(value: unknown): value is Record<string, unknown> {
  845. return typeof value === 'object' && value !== null && !Array.isArray(value)
  846. }