ci-workflow.spec.ts 16 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318
  1. import { readFileSync } from 'node:fs'
  2. import { resolve } from 'node:path'
  3. import * as yaml from 'js-yaml'
  4. import { describe, expect, it } from 'vitest'
  5. const root = resolve(import.meta.dirname, '..')
  6. const runnerPrivatePnpmDestination = '${{ runner.temp }}/setup-pnpm'
  7. describe('CI workflow', () => {
  8. it('isolates every pnpm action setup destination per runner', () => {
  9. const workflow: unknown = yaml.load(readFileSync(resolve(root, '.github/workflows/ci.yml'), 'utf8'))
  10. if (!isRecord(workflow) || !isRecord(workflow.jobs)) throw new TypeError('CI workflow must define jobs')
  11. const setups = Object.entries(workflow.jobs).flatMap(([jobName, job]) => {
  12. if (!isRecord(job) || !Array.isArray(job.steps)) return []
  13. return job.steps.flatMap((step) => {
  14. if (!isRecord(step) || typeof step.uses !== 'string' || !step.uses.startsWith('pnpm/action-setup@')) return []
  15. return [{ jobName, step }]
  16. })
  17. })
  18. expect(setups.length).toBeGreaterThan(0)
  19. for (const { jobName, step } of setups) {
  20. expect(step, `${jobName} must not share pnpm/action-setup's default destination`).toMatchObject({
  21. with: { dest: runnerPrivatePnpmDestination },
  22. })
  23. }
  24. })
  25. it('keeps a required Wine Windows job, a non-blocking native Windows job with failover, and a master-only standby', () => {
  26. const workflow = loadWorkflow('.github/workflows/ci.yml')
  27. if (!isRecord(workflow.jobs)
  28. || !isRecord(workflow.jobs.windows)
  29. || !isRecord(workflow.jobs['windows-native'])
  30. || !isRecord(workflow.jobs['wine-apt-cache'])
  31. || !isRecord(workflow.jobs['serial-windows'])
  32. || !isRecord(workflow.jobs['all-checks-passed'])) {
  33. throw new TypeError('CI workflow must define windows, windows-native, wine-apt-cache, serial-windows, and all-checks-passed jobs')
  34. }
  35. const windows = workflow.jobs.windows
  36. const windowsNative = workflow.jobs['windows-native']
  37. const wineAptCache = workflow.jobs['wine-apt-cache']
  38. const serialWindows = workflow.jobs['serial-windows']
  39. const aggregate = workflow.jobs['all-checks-passed']
  40. if (!Array.isArray(windows.steps) || !Array.isArray(aggregate.needs)) {
  41. throw new TypeError('Windows job must define steps and the aggregate must define needs')
  42. }
  43. const commandSteps = windows.steps.filter((step): step is Record<string, unknown> & { run: string } => (
  44. isRecord(step) && typeof step.run === 'string'
  45. ))
  46. // Required PR job: Wine on ubuntu-latest, runs wine-windows-gates.sh.
  47. expect(windows['runs-on']).toBe('ubuntu-latest')
  48. expect(windows.name).toBe('windows node 24 / wine blocking')
  49. expect(windows.if).toBe("github.event_name == 'pull_request'")
  50. expect(commandSteps.some(step => step.run.includes('wine-windows-gates.sh'))).toBe(true)
  51. // windows-native: non-blocking native job with failover, runs windows-complete.
  52. expect(typeof windowsNative['runs-on']).toBe('string')
  53. expect(windowsNative['runs-on']).toContain('DSH_CI_FAILOVER')
  54. expect(windowsNative['runs-on']).toContain('self-hosted')
  55. expect(windowsNative['runs-on']).toContain('dsh-win-ci')
  56. expect(windowsNative['runs-on']).toContain('dsh-windows-2025-16core')
  57. expect(windowsNative.name).toBe('windows node 24 / native complete')
  58. expect(windowsNative.if).toBe("github.event_name == 'pull_request'")
  59. const nativeCommandSteps = (windowsNative.steps as unknown[]).filter((step): step is Record<string, unknown> & { run: string } => (
  60. isRecord(step) && typeof step.run === 'string'
  61. ))
  62. expect(nativeCommandSteps.map(step => step.run)).toContain('pnpm run check:ci:windows-complete')
  63. // wine-apt-cache: master-only, seeds the Wine apt cache.
  64. expect(wineAptCache.if).toBe("github.event_name == 'push' && github.ref == 'refs/heads/master'")
  65. expect(wineAptCache['runs-on']).toBe('ubuntu-latest')
  66. // serial-windows: master-only standby, self-hosted, non-blocking.
  67. expect(serialWindows.if).toBe("github.event_name == 'push' && github.ref == 'refs/heads/master'")
  68. expect(serialWindows['runs-on']).toEqual(['self-hosted', 'dsh-win-ci', 'windows'])
  69. expect(serialWindows.name).toBe('serial / windows (self-hosted standby)')
  70. // Aggregate: Wine `windows` required, native `windows-native` excluded.
  71. expect(aggregate.needs).toContain('windows')
  72. expect(aggregate.needs).not.toContain('windows-native')
  73. expect(aggregate.needs).not.toContain('serial-windows')
  74. })
  75. it('keeps supported LSP source under native Windows coverage', () => {
  76. const config = readFileSync(resolve(root, 'vitest.config.ts'), 'utf8')
  77. expect(config).not.toContain('packages/lsp/lsp-local/src/connection.ts')
  78. expect(config).not.toContain('packages/lsp/lsp-local/src/index.ts')
  79. expect(config).not.toContain('packages/lsp/lsp-local/src/instance.ts')
  80. })
  81. it('keeps every Vitest project process-isolated on native Windows', () => {
  82. const config = readFileSync(resolve(root, 'vitest.config.ts'), 'utf8')
  83. expect(config).not.toContain("pool: process.platform === 'win32' ? 'threads' : 'forks'")
  84. expect(config.match(/pool: 'forks'/g)).toHaveLength(2)
  85. })
  86. })
  87. describe('E2B e2e workflow', () => {
  88. it('is manual-only and fails loud before running the focused live suite', () => {
  89. const workflow = loadWorkflow('.github/workflows/e2b-e2e.yml')
  90. expect(workflow.on).toEqual({ workflow_dispatch: null })
  91. if (!isRecord(workflow.jobs) || !isRecord(workflow.jobs.e2b) || !Array.isArray(workflow.jobs.e2b.steps)) {
  92. throw new TypeError('E2B e2e workflow must define the e2b job steps')
  93. }
  94. const steps = workflow.jobs.e2b.steps.filter(isRecord)
  95. const preflight = steps.find(step => step.name === 'Preflight (require E2B API key)')
  96. const e2b = steps.find(step => step.name === 'E2B tests (live sandbox)')
  97. expect(preflight).toMatchObject({
  98. env: { E2B_API_KEY: '${{ secrets.E2B_API_KEY_EXTERNAL }}' },
  99. })
  100. expect(preflight?.run).toContain('E2B_API_KEY_EXTERNAL repository secret')
  101. expect(e2b).toMatchObject({
  102. env: {
  103. E2B_API_KEY: '${{ secrets.E2B_API_KEY_EXTERNAL }}',
  104. DSH_E2E_MAX_WORKERS: '1',
  105. DSH_EXAMPLE_MODE: 'lib',
  106. },
  107. })
  108. expect(e2b?.run).toContain('packages/e2b/e2b/tests/composition.e2e.ts')
  109. })
  110. })
  111. describe('Python release workflows', () => {
  112. it('keeps complete wheel validation separate from protected public publication', () => {
  113. const workflow = loadWorkflow('.github/workflows/python-release.yml')
  114. const dispatch = workflowEvent(workflow, 'workflow_dispatch')
  115. const pullRequest = workflowEvent(workflow, 'pull_request')
  116. const build = workflowJob(workflow, 'build')
  117. const pythonCompat = workflowJob(workflow, 'python-compat')
  118. const validate = workflowJob(workflow, 'validate')
  119. const publishRuntime = workflowJob(workflow, 'publish-runtime')
  120. const publishSdk = workflowJob(workflow, 'publish-sdk')
  121. if (!isRecord(dispatch.inputs)
  122. || !isRecord(dispatch.inputs.publish)
  123. || !Array.isArray(pythonCompat.steps)
  124. || !Array.isArray(validate.steps)
  125. || !Array.isArray(publishRuntime.steps)
  126. || !Array.isArray(publishSdk.steps)) {
  127. throw new TypeError('Python release workflow must define publish input and release steps')
  128. }
  129. expect(dispatch.inputs.publish).toMatchObject({ type: 'boolean', default: false })
  130. expect(pullRequest).toEqual({ types: ['labeled'] })
  131. expect(build).toMatchObject({
  132. if: "github.event_name == 'workflow_dispatch' || github.event.label.name == 'python-release-dry-run'",
  133. uses: './.github/workflows/build-exe-for-python-sdk.yml',
  134. with: {
  135. targets: 'node24-linux-x64,node24-linux-arm64,node24-macos-arm64',
  136. release: true,
  137. },
  138. })
  139. expect(pythonCompat.strategy).toMatchObject({ matrix: { python: ['3.10', '3.14'] } })
  140. expect(JSON.stringify(pythonCompat.steps)).toContain('deepseek-harness-sdk==${{ steps.compatibility-version.outputs.version }}')
  141. const validateSteps = JSON.stringify(validate.steps)
  142. const authorize = validate.steps.filter(isRecord).find(step => step.name === 'Authorize publication request')
  143. if (!isRecord(authorize) || typeof authorize.run !== 'string') {
  144. throw new TypeError('Python release validation must authorize publication requests')
  145. }
  146. expect(validateSteps).toContain('PUBLIC_PYPI_RELEASE_ENABLED')
  147. expect(authorize).toMatchObject({
  148. env: {
  149. PYPI_PUBLISHER_REPOSITORY: '${{ vars.PYPI_PUBLISHER_REPOSITORY }}',
  150. REPOSITORY: '${{ github.repository }}',
  151. },
  152. })
  153. expect(authorize.run).toContain('[ "$REPOSITORY" = "$PYPI_PUBLISHER_REPOSITORY" ]')
  154. expect(validateSteps).toContain('100000000')
  155. expect(publishRuntime).toMatchObject({
  156. if: "github.event_name == 'workflow_dispatch' && inputs.publish",
  157. needs: 'validate',
  158. environment: 'pypi-runtime',
  159. permissions: { contents: 'read', 'id-token': 'write' },
  160. })
  161. expect(publishSdk).toMatchObject({
  162. if: "github.event_name == 'workflow_dispatch' && inputs.publish",
  163. needs: ['validate', 'publish-runtime'],
  164. environment: 'pypi',
  165. permissions: { contents: 'read', 'id-token': 'write' },
  166. })
  167. const runtimeSteps = publishRuntime.steps.filter(isRecord)
  168. const sdkSteps = publishSdk.steps.filter(isRecord)
  169. const runtimePublish = runtimeSteps.find(step => step.name === 'Publish runtime wheels')
  170. const sdkPublish = sdkSteps.find(step => step.name === 'Publish SDK wheel')
  171. const runtimeHashes = runtimeSteps.find(step => step.name === 'Verify release artifact hashes')
  172. const sdkHashes = sdkSteps.find(step => step.name === 'Verify release artifact hashes')
  173. expect([...runtimeSteps, ...sdkSteps].some(
  174. step => typeof step.uses === 'string' && step.uses.startsWith('actions/checkout@'),
  175. )).toBe(false)
  176. expect([...runtimeSteps, ...sdkSteps].filter(
  177. step => step.uses === 'pypa/gh-action-pypi-publish@release/v1',
  178. )).toHaveLength(2)
  179. expect(runtimePublish).toMatchObject({
  180. with: { 'packages-dir': 'dist/runtime/', attestations: false },
  181. })
  182. expect(sdkPublish).toMatchObject({
  183. with: { 'packages-dir': 'dist/sdk/', attestations: false },
  184. })
  185. expect(runtimeHashes).toMatchObject({ run: 'cd dist && sha256sum -c SHA256SUMS' })
  186. expect(sdkHashes).toMatchObject({ run: 'cd dist && sha256sum -c SHA256SUMS' })
  187. })
  188. it('exposes the native wheel builder to the release caller with normalized versions', () => {
  189. const workflow = loadWorkflow('.github/workflows/build-exe-for-python-sdk.yml')
  190. const call = workflowEvent(workflow, 'workflow_call')
  191. const plan = workflowJob(workflow, 'plan')
  192. const build = workflowJob(workflow, 'build')
  193. if (!isRecord(call.inputs) || !Array.isArray(plan.steps) || !Array.isArray(build.steps)) {
  194. throw new TypeError('Python wheel builder must define workflow_call inputs and plan steps')
  195. }
  196. const buildSteps: unknown[] = build.steps
  197. const manylinuxAddon = buildSteps.find(step => isRecord(step) && step.name === 'Rebuild Linux node-pty against manylinux 2.28')
  198. const macosCheck = buildSteps.find(step => isRecord(step) && step.name === 'Check macOS deployment target')
  199. const manylinuxSmoke = buildSteps.find(step => isRecord(step) && step.name === 'Run wheel in a manylinux 2.28 container')
  200. expect(call.inputs).toHaveProperty('targets')
  201. expect(call.inputs).toMatchObject({ release: { type: 'boolean', default: false } })
  202. expect(plan.if).toContain('inputs.release')
  203. expect(JSON.stringify(plan.steps)).toContain('pep440_version')
  204. expect(JSON.stringify(workflow)).toContain('macosx_14_0_arm64')
  205. expect(manylinuxAddon).toMatchObject({ if: "runner.os == 'Linux'" })
  206. expect(JSON.stringify(manylinuxAddon)).toContain('manylinux_2_28_x86_64')
  207. expect(JSON.stringify(manylinuxAddon)).toContain('manylinux_2_28_aarch64')
  208. expect(JSON.stringify(manylinuxAddon)).toContain('$HOME/setup-pnpm:$HOME/setup-pnpm:ro')
  209. expect(JSON.stringify(manylinuxAddon)).toContain('node-pty-glibc-versions.txt')
  210. expect(JSON.stringify(manylinuxAddon)).toContain('le 2.28')
  211. expect(macosCheck).toMatchObject({ if: "runner.os == 'macOS'" })
  212. expect(JSON.stringify(macosCheck)).toContain('scripts/check-macos-deployment-target.py')
  213. expect(JSON.stringify(macosCheck)).toContain('$EXE-spawn-helper')
  214. expect(manylinuxSmoke).toMatchObject({ if: "runner.os == 'Linux'" })
  215. expect(JSON.stringify(manylinuxSmoke)).toContain('-e DSH_TELEMETRY_DISABLED')
  216. })
  217. it('uses the shared macOS deployment-target check in GitLab', () => {
  218. const workflow = loadWorkflow('.gitlab-ci.yml')
  219. const runtimeWheel = workflow['.runtime-wheel']
  220. if (!isRecord(runtimeWheel) || !Array.isArray(runtimeWheel.script)) {
  221. throw new TypeError('GitLab CI must define the runtime wheel script')
  222. }
  223. const runtimeScript: unknown[] = runtimeWheel.script
  224. const macosCheck = runtimeScript.find(
  225. step => typeof step === 'string' && step.includes('PLATFORM" = macos-arm64'),
  226. )
  227. if (typeof macosCheck !== 'string') {
  228. throw new TypeError('GitLab CI must check the macOS deployment target')
  229. }
  230. expect(macosCheck).toContain('scripts/check-macos-deployment-target.py')
  231. expect(macosCheck).toContain('"$EXE" "$EXE-spawn-helper"')
  232. })
  233. })
  234. describe('Issue lifecycle workflow', () => {
  235. it('uses explicit review handoff events without rerunning when a draft becomes ready', () => {
  236. const lifecycle = loadWorkflow('.github/workflows/issue-lifecycle.yml')
  237. const lifecyclePullRequest = workflowEvent(lifecycle, 'pull_request')
  238. const lifecycleReview = workflowEvent(lifecycle, 'pull_request_review')
  239. const lifecycleJob = workflowJob(lifecycle, 'lifecycle')
  240. const policy = loadWorkflow('.github/workflows/issue-policy.yml')
  241. const policyPullRequest = workflowEvent(policy, 'pull_request')
  242. expect(lifecyclePullRequest.types).not.toContain('ready_for_review')
  243. expect(lifecyclePullRequest.types).toContain('review_requested')
  244. expect(lifecycleReview.types).toEqual(['submitted'])
  245. expect(lifecycleJob.if).toBe(
  246. "${{ github.event_name != 'pull_request_review' || (github.event.action == 'submitted' && github.event.review.state == 'changes_requested') }}",
  247. )
  248. expect(policyPullRequest.types).toContain('ready_for_review')
  249. })
  250. })
  251. describe('Git hooks', () => {
  252. it('leaves frozen Agent Note sidecars to the archive verifier', () => {
  253. const lefthook = loadWorkflow('lefthook.yml')
  254. for (const hookName of ['pre-commit', 'pre-merge-commit']) {
  255. const hook = lefthook[hookName]
  256. if (!isRecord(hook) || !Array.isArray(hook.jobs)) {
  257. throw new TypeError(`lefthook must define ${hookName} jobs`)
  258. }
  259. const pairing: unknown = hook.jobs.find(
  260. (job: unknown) => isRecord(job) && job.name === 'translation pairing (staged records)',
  261. )
  262. expect(pairing).toMatchObject({ exclude: ['.agents/notes/archived/**'] })
  263. }
  264. })
  265. })
  266. function loadWorkflow(path: string): Record<string, unknown> {
  267. const workflow: unknown = yaml.load(readFileSync(resolve(root, path), 'utf8'))
  268. if (!isRecord(workflow)) throw new TypeError(`${path} must define a workflow`)
  269. return workflow
  270. }
  271. function workflowEvent(workflow: Record<string, unknown>, event: string): Record<string, unknown> {
  272. if (!isRecord(workflow.on) || !isRecord(workflow.on[event])) {
  273. throw new TypeError(`workflow must define the ${event} event`)
  274. }
  275. return workflow.on[event]
  276. }
  277. function workflowJob(workflow: Record<string, unknown>, job: string): Record<string, unknown> {
  278. if (!isRecord(workflow.jobs) || !isRecord(workflow.jobs[job])) {
  279. throw new TypeError(`workflow must define the ${job} job`)
  280. }
  281. return workflow.jobs[job]
  282. }
  283. function isRecord(value: unknown): value is Record<string, unknown> {
  284. return typeof value === 'object' && value !== null && !Array.isArray(value)
  285. }