| 1234567891011121314151617181920212223242526272829303132333435363738394041424344454647484950515253545556575859606162636465666768697071727374757677787980818283848586878889909192939495969798991001011021031041051061071081091101111121131141151161171181191201211221231241251261271281291301311321331341351361371381391401411421431441451461471481491501511521531541551561571581591601611621631641651661671681691701711721731741751761771781791801811821831841851861871881891901911921931941951961971981992002012022032042052062072082092102112122132142152162172182192202212222232242252262272282292302312322332342352362372382392402412422432442452462472482492502512522532542552562572582592602612622632642652662672682692702712722732742752762772782792802812822832842852862872882892902912922932942952962972982993003013023033043053063073083093103113123133143153163173183193203213223233243253263273283293303313323333343353363373383393403413423433443453463473483493503513523533543553563573583593603613623633643653663673683693703713723733743753763773783793803813823833843853863873883893903913923933943953963973983994004014024034044054064074084094104114124134144154164174184194204214224234244254264274284294304314324334344354364374384394404414424434444454464474484494504514524534544554564574584594604614624634644654664674684694704714724734744754764774784794804814824834844854864874884894904914924934944954964974984995005015025035045055065075085095105115125135145155165175185195205215225235245255265275285295305315325335345355365375385395405415425435445455465475485495505515525535545555565575585595605615625635645655665675685695705715725735745755765775785795805815825835845855865875885895905915925935945955965975985996006016026036046056066076086096106116126136146156166176186196206216226236246256266276286296306316326336346356366376386396406416426436446456466476486496506516526536546556566576586596606616626636646656666676686696706716726736746756766776786796806816826836846856866876886896906916926936946956966976986997007017027037047057067077087097107117127137147157167177187197207217227237247257267277287297307317327337347357367377387397407417427437447457467477487497507517527537547557567577587597607617627637647657667677687697707717727737747757767777787797807817827837847857867877887897907917927937947957967977987998008018028038048058068078088098108118128138148158168178188198208218228238248258268278288298308318328338348358368378388398408418428438448458468478488498508518528538548558568578588598608618628638648658668678688698708718728738748758768778788798808818828838848858868878888898908918928938948958968978988999009019029039049059069079089099109119129139149159169179189199209219229239249259269279289299309319329339349359369379389399409419429439449459469479489499509519529539549559569579589599609619629639649659669679689699709719729739749759769779789799809819829839849859869879889899909919929939949959969979989991000100110021003100410051006100710081009101010111012101310141015101610171018101910201021102210231024102510261027102810291030103110321033103410351036103710381039104010411042104310441045104610471048104910501051105210531054105510561057105810591060106110621063106410651066106710681069107010711072107310741075107610771078107910801081108210831084108510861087108810891090109110921093109410951096109710981099110011011102110311041105110611071108110911101111111211131114111511161117111811191120112111221123112411251126112711281129113011311132113311341135113611371138113911401141114211431144114511461147114811491150115111521153115411551156115711581159116011611162 |
- import { spawn as nodeSpawn, spawnSync as nodeSpawnSync } from 'node:child_process'
- import { mkdtempSync, readFileSync, rmSync, statSync, unlinkSync } from 'node:fs'
- import { tmpdir } from 'node:os'
- import { dirname, join } from 'node:path'
- import { afterAll, describe, expect, it, vi } from 'vitest'
- import {
- childEnv,
- killGroup,
- OutputCollector,
- spawnSubprocess,
- taskkillProcessTree,
- } from '../src/spawn.ts'
- import type { SubprocessHandle, SubprocessOutputReader } from '@deepseek-ai/dsh-subprocess'
- import { MAX_TIMER_DELAY_MS } from '@deepseek-ai/dsh-timeout'
- vi.mock('node:child_process', async (importOriginal) => {
- const actual = await importOriginal<typeof import('node:child_process')>()
- return { ...actual, spawnSync: vi.fn(actual.spawnSync) }
- })
- /**
- * Translate the suite's POSIX command strings into node one-liners on Windows,
- * where no bash exists; the translated commands keep the same observable
- * stdout/stderr/exit-code contract the bash originals pin on POSIX.
- * @param command - the bash `-c` command string used by the test.
- * @returns the argv to spawn.
- */
- function shellArgv(command: string): string[] {
- if (process.platform !== 'win32') return ['bash', '-c', command]
- const node = (script: string): string[] => [process.execPath, '-e', script]
- switch (command) {
- case 'true': return node('')
- case 'echo hello': return node('console.log("hello")')
- case 'echo hi': return node('console.log("hi")')
- case 'echo oops >&2': return node('console.error("oops")')
- case 'echo err >&2': return node('console.error("err")')
- case 'echo out; echo err >&2': return node('console.log("out"); console.error("err")')
- case 'echo out; echo to-parent >&2': return node('console.log("out"); console.error("to-parent")')
- case 'echo to-parent; echo err >&2': return node('console.log("to-parent"); console.error("err")')
- case 'exit 42': return node('process.exit(42)')
- case 'exit 7': return node('process.exit(7)')
- case 'pwd': return node('console.log(process.cwd())')
- case 'sleep 60': return node('setTimeout(() => {}, 60000)')
- case 'cat': return node('process.stdin.pipe(process.stdout)')
- case 'unused': return node('')
- case 'echo "${TERM:-unset}"': return node('console.log(process.env.TERM ?? "unset")')
- case 'echo "$EXTRA_ONE/$EXTRA_TWO"': return node('console.log(process.env.EXTRA_ONE + "/" + process.env.EXTRA_TWO)')
- case 'echo "$EXPLICIT_OVERRIDE_PASSWORD"': return node('console.log(process.env.EXPLICIT_OVERRIDE_PASSWORD)')
- case 'echo "${SUBPROCESS_TOMBSTONE_PROBE:-absent}"': return node('console.log(process.env.SUBPROCESS_TOMBSTONE_PROBE ?? "absent")')
- case 'echo "[${DSH_STALE:-absent}|$DSH_SHELL|$DSH_SESSION_ID]"':
- return node('console.log("[" + [process.env.DSH_STALE ?? "absent", process.env.DSH_SHELL, process.env.DSH_SESSION_ID].join("|") + "]")')
- case 'echo "[${DSH_TEST_API_KEY:-absent}|${DSH_TEST_TOKEN:-absent}|${SUBPROCESS_TEST_PASSWORD:-absent}|${DSH_TEST_PLAIN:-absent}]"':
- return node('console.log("[" + [process.env.DSH_TEST_API_KEY ?? "absent", process.env.DSH_TEST_TOKEN ?? "absent", process.env.SUBPROCESS_TEST_PASSWORD ?? "absent", process.env.DSH_TEST_PLAIN ?? "absent"].join("|") + "]")')
- case 'printf "%.0sx" $(seq 1 500)': return node('process.stdout.write("x".repeat(500))')
- case 'printf "%.0sx" $(seq 1 500); printf "%.0se" $(seq 1 500) >&2':
- return node('process.stdout.write("x".repeat(500)); process.stderr.write("e".repeat(500))')
- case 'for i in $(seq 1 200); do printf "line-%04d\\n" $i; done':
- return node('for (let i = 1; i <= 200; i++) console.log("line-" + String(i).padStart(4, "0"))')
- default:
- throw new Error(`spawn.spec: no win32 node translation for ${JSON.stringify(command)}`)
- }
- }
- const { failNextClose, failNextUnlink } = vi.hoisted(() => ({
- failNextClose: { value: false },
- failNextUnlink: { value: false },
- }))
- vi.mock('node:fs', async (importOriginal) => {
- const actual = await importOriginal<typeof import('node:fs')>()
- return {
- ...actual,
- closeSync(fd: number): void {
- if (failNextClose.value) {
- failNextClose.value = false
- throw Object.assign(new Error('simulated EIO on close'), { code: 'EIO' })
- }
- actual.closeSync(fd)
- },
- unlinkSync(path: Parameters<typeof actual.unlinkSync>[0]): void {
- if (failNextUnlink.value) {
- failNextUnlink.value = false
- throw Object.assign(new Error('simulated EIO on unlink'), { code: 'EIO' })
- }
- actual.unlinkSync(path)
- },
- }
- })
- const spillDir = mkdtempSync(join(tmpdir(), 'dsh-subprocess-spec-'))
- /** The per-process default spill dir captured by the default-spill test. */
- let defaultSpillDir: string | undefined
- afterAll(() => {
- rmSync(spillDir, { recursive: true, force: true })
- if (defaultSpillDir !== undefined) rmSync(defaultSpillDir, { recursive: true, force: true })
- })
- type SpecOverrides = Partial<Parameters<typeof spawnSubprocess>[0]> & {
- stdoutMaxBytes?: number
- stderrMaxBytes?: number
- maxSpillBytes?: number
- stdin?: string
- }
- function spec(command: string, overrides: SpecOverrides = {}) {
- const { stdoutMaxBytes = 64_000, stderrMaxBytes = 64_000, maxSpillBytes = 64 * 1024 * 1024, stdin, ...rest } = overrides
- return {
- argv: shellArgv(command),
- cwd: process.cwd(),
- stdio: {
- stdin: stdin !== undefined ? { data: stdin } : 'ignore' as const,
- stdout: { maxBytes: stdoutMaxBytes, spill: { maxBytes: maxSpillBytes } },
- stderr: { maxBytes: stderrMaxBytes, spill: { maxBytes: maxSpillBytes } },
- },
- graceMs: 3_000,
- ...rest,
- }
- }
- /** Poll until a pid no longer exists, or is only a zombie on Linux. */
- async function waitGone(pid: number, timeoutMs = 5_000): Promise<void> {
- const deadline = Date.now() + timeoutMs
- while (Date.now() < deadline) {
- try {
- process.kill(pid, 0)
- } catch {
- return
- }
- if (process.platform === 'linux') {
- try {
- const stat = readFileSync(`/proc/${pid}/stat`, 'utf8')
- const state = stat.slice(stat.lastIndexOf(')') + 2, stat.lastIndexOf(')') + 3)
- if (state === 'Z' || state === 'X') return
- } catch (error: unknown) {
- if ((error as NodeJS.ErrnoException).code === 'ENOENT') return
- throw error
- }
- }
- await new Promise(resolve => setTimeout(resolve, 20))
- }
- throw new Error(`pid ${pid} still alive after ${timeoutMs}ms`)
- }
- async function waitForStdout(running: SubprocessHandle, expected: string, timeoutMs = 5_000): Promise<void> {
- const deadline = Date.now() + timeoutMs
- while (Date.now() < deadline) {
- if (running.collected.stdout!.readFrom(0).text.includes(expected)) return
- await new Promise(resolve => setTimeout(resolve, 20))
- }
- throw new Error(`stdout did not include ${JSON.stringify(expected)} after ${timeoutMs}ms`)
- }
- /** Await settlement and project both collected streams like a batch outcome. */
- async function finish(running: SubprocessHandle) {
- const outcome = await running.done
- const final = (reader: SubprocessOutputReader | undefined) => {
- const read = reader!.readFrom(0)
- return { text: read.text, truncated: read.lossy, ...read.spillPath !== undefined ? { spillPath: read.spillPath } : {} }
- }
- return { ...outcome, stdout: final(running.collected.stdout), stderr: final(running.collected.stderr) }
- }
- async function waitForPidFile(path: string, timeoutMs = 5_000): Promise<number> {
- const deadline = Date.now() + timeoutMs
- while (Date.now() < deadline) {
- try {
- const pid = Number(readFileSync(path, 'utf8').trim())
- if (Number.isSafeInteger(pid) && pid > 0) return pid
- } catch {
- // The child shell has not written the pid file yet.
- }
- await new Promise(resolve => setTimeout(resolve, 20))
- }
- throw new Error(`pid file ${path} was not written after ${timeoutMs}ms`)
- }
- describe('spawnSubprocess', () => {
- it.each([0, -1, Number.NaN, Number.POSITIVE_INFINITY, MAX_TIMER_DELAY_MS + 1])(
- 'rejects an invalid grace before spawning: %s',
- (graceMs) => {
- expect(() => spawnSubprocess(spec('true', { graceMs })))
- .toThrow(`subprocess graceMs must be a positive finite number no greater than ${MAX_TIMER_DELAY_MS}`)
- },
- )
- it('captures stdout on success', async () => {
- const result = await finish(spawnSubprocess(spec('echo hello')))
- expect(result.exitCode).toBe(0)
- expect(result.signal).toBeNull()
- expect(result.stdout.text).toBe('hello\n')
- expect(result.stdout.truncated).toBe(false)
- expect(result.stderr.text).toBe('')
- })
- it('captures stderr separately', async () => {
- const result = await finish(spawnSubprocess(spec('echo oops >&2')))
- expect(result.exitCode).toBe(0)
- expect(result.stdout.text).toBe('')
- expect(result.stderr.text).toBe('oops\n')
- })
- it('captures both streams', async () => {
- const result = await finish(spawnSubprocess(spec('echo out; echo err >&2')))
- expect(result.stdout.text).toBe('out\n')
- expect(result.stderr.text).toBe('err\n')
- })
- it('reports non-zero exit codes', async () => {
- const result = await finish(spawnSubprocess(spec('exit 42')))
- expect(result.exitCode).toBe(42)
- expect(result.signal).toBeNull()
- })
- it('passes the ambient TERM through untouched (terminal policy is the caller\'s)', async () => {
- const result = await finish(spawnSubprocess(spec('echo "${TERM:-unset}"', {
- env: { TERM: 'callers-choice' },
- })))
- expect(result.stdout.text).toBe('callers-choice\n')
- })
- it.skipIf(process.platform === 'win32')('runs in the requested cwd', async () => {
- const result = await finish(spawnSubprocess(spec('pwd', { cwd: '/tmp' })))
- expect(result.stdout.text.trim()).toMatch(/\/tmp$/)
- })
- it('kills the process group with SIGTERM when the signal fires', async () => {
- // spawnSubprocess owns no timer: it kills on abort. The bash executor drives the timeout
- // by firing this signal via a deadline (see executor.spec.ts); here we
- // assert the kill itself lands as SIGTERM.
- const controller = new AbortController()
- const start = Date.now()
- const running = spawnSubprocess(spec('sleep 60', { signal: controller.signal }))
- setTimeout(() => { controller.abort('deadline') }, 100)
- const result = await running.done
- expect(Date.now() - start).toBeLessThan(5_000)
- // Windows teardown terminates through taskkill, which reports no signal.
- expect(result.signal).toBe(process.platform === 'win32' ? null : 'SIGTERM')
- expect(result.exitCode).toBe(process.platform === 'win32' ? 1 : null)
- })
- it.skipIf(process.platform === 'win32')('terminate() escalates to SIGKILL when SIGTERM is trapped', async () => {
- const running = spawnSubprocess(spec('trap \'\' TERM; echo ready; while :; do sleep 60 & wait $!; done', { graceMs: 200 }))
- await waitForStdout(running, 'ready\n')
- running.terminate()
- const result = await running.done
- expect(result.signal).toBe('SIGKILL')
- })
- it('cancels escalation when the terminated group vanishes before collected pipes drain', async () => {
- const pidFile = join(spillDir, `escaped-pipe-holder-${Date.now()}.pid`)
- const graceMs = 160
- const childScript = `
- const { spawn } = require('node:child_process')
- const { writeFileSync } = require('node:fs')
- const helper = spawn(process.execPath, ['-e', 'setInterval(() => {}, 1000)'], {
- detached: true,
- stdio: ['ignore', 1, 2],
- })
- writeFileSync(${JSON.stringify(pidFile)}, String(helper.pid))
- helper.unref()
- setInterval(() => {}, 1000)
- `
- const running = spawnSubprocess({
- ...spec('unused', { graceMs }),
- argv: [process.execPath, '-e', childScript],
- })
- const helper = await waitForPidFile(pidFile)
- const realKill: typeof process.kill = process.kill.bind(process)
- let termAt = 0
- let forceSignals = 0
- const killSpy = vi.spyOn(process, 'kill').mockImplementation((target, signal) => {
- if (target !== -running.pid) return realKill(target, signal)
- if (signal === 'SIGTERM') {
- termAt = Date.now()
- return realKill(target, signal)
- }
- if (signal === 'SIGKILL') {
- forceSignals += 1
- return true
- }
- if (signal === 0 && termAt !== 0 && Date.now() - termAt < graceMs / 2) {
- throw Object.assign(new Error('simulated vanished process group'), { code: 'ESRCH' })
- }
- return true // Before TERM the original group is live; later its pgid is reused.
- })
- try {
- running.terminate()
- await running.done
- expect(forceSignals).toBe(0)
- } finally {
- killSpy.mockRestore()
- try {
- process.kill(helper, 'SIGKILL')
- } catch {
- // taskkill already took the helper down on Windows.
- }
- await waitGone(helper)
- }
- })
- it.skipIf(process.platform === 'win32')('terminates the whole process group (grandchildren die too)', async () => {
- // The subshell writes the sleep's pid then waits on it; terminating the
- // group must take the sleep down with bash.
- const pidFile = join(spillDir, `grandchild-${Date.now()}.pid`)
- const running = spawnSubprocess(spec(`sleep 60 & echo $! > ${pidFile}; wait`))
- const grandchild = await waitForPidFile(pidFile)
- expect(grandchild).toBeGreaterThan(0)
- running.terminate()
- const result = await running.done
- expect(result.signal).toBe('SIGTERM')
- await waitGone(grandchild)
- })
- it('aborts via AbortSignal mid-run', async () => {
- const controller = new AbortController()
- const running = spawnSubprocess(spec('sleep 60', { signal: controller.signal }))
- setTimeout(() => { controller.abort('user cancelled') }, 50)
- const result = await running.done
- expect(result.signal).toBe(process.platform === 'win32' ? null : 'SIGTERM')
- })
- it('throws when the signal is already aborted before spawn', () => {
- const controller = new AbortController()
- controller.abort('too late')
- expect(() => spawnSubprocess(spec('echo hi', { signal: controller.signal })))
- .toThrow(/aborted before spawn: too late/)
- })
- it('rejects with a spawn error for a nonexistent cwd', async () => {
- await expect(spawnSubprocess(spec('echo hi', { cwd: '/nonexistent-dir-dsh-test' })).done)
- .rejects.toThrow(/ENOENT/)
- })
- it('terminate() is idempotent (second call does not restart escalation)', async () => {
- const running = spawnSubprocess(spec('sleep 60'))
- running.terminate()
- running.terminate()
- const result = await running.done
- expect(result.signal).toBe(process.platform === 'win32' ? null : 'SIGTERM')
- })
- it.skipIf(process.platform === 'win32')('does not wait for a Linux group that has only zombie members', async () => {
- const pidFile = join(spillDir, `zombie-group-${Date.now()}.pid`)
- const running = spawnSubprocess(spec(`sleep 60 & echo $! > ${pidFile}; echo leader-done`, { graceMs: 100 }), {
- platform: 'linux',
- linuxProcessGroupHasLiveMembers: () => false,
- })
- const descendant = await waitForPidFile(pidFile)
- try {
- await running.done
- await expect(running.waitForExit()).resolves.toBe(true)
- } finally {
- // The confirmed-absent verdict is a permanent no-more-signals boundary,
- // so terminate() must stay inert here; reap the live survivor directly.
- process.kill(descendant, 'SIGKILL')
- await waitGone(descendant)
- }
- })
- it.skipIf(process.platform === 'win32')('bounds inherited-pipe draining after the shell exits', async () => {
- const pidFile = join(spillDir, `pipe-holder-${Date.now()}.pid`)
- const started = Date.now()
- const running = spawnSubprocess(spec(`sleep 60 & echo $! > ${pidFile}; echo shell-done`, { graceMs: 100 }))
- const descendant = await waitForPidFile(pidFile)
- try {
- const result = await finish(running)
- expect(Date.now() - started).toBeLessThan(1_000)
- expect(result.exitCode).toBe(0)
- expect(result.stdout.text).toBe('shell-done\n')
- } finally {
- process.kill(descendant, 'SIGKILL')
- await waitGone(descendant)
- }
- })
- })
- describe('stdin and extra env (set by in-process plugins)', () => {
- it('writes stdin to the command and closes it', async () => {
- const result = await finish(spawnSubprocess(spec('cat', { stdin: 'hello from stdin\n' })))
- expect(result.exitCode).toBe(0)
- expect(result.stdout.text).toBe('hello from stdin\n')
- })
- it('a command that reads stdin sees EOF when none is supplied', async () => {
- // No stdin → fd 0 is /dev/null, so `cat` reads EOF and exits 0 with no
- // output (it does NOT block).
- const result = await finish(spawnSubprocess(spec('cat')))
- expect(result.exitCode).toBe(0)
- expect(result.stdout.text).toBe('')
- })
- it.skipIf(process.platform === 'win32')('gives fd 0 the exact pre-seam type: /dev/null when no stdin, a pipe when supplied', async () => {
- // With no bytes, fd 0 remains the pre-spawn `ignore` default (/dev/null, a character device).
- // Supplied bytes use Node's spawn pipe, which is an AF_UNIX socket rather than a FIFO.
- const none = await finish(spawnSubprocess(spec('test -c /dev/stdin && echo char || echo other')))
- expect(none.stdout.text).toBe('char\n')
- const piped = await finish(spawnSubprocess(spec('test -S /dev/stdin && echo socket || echo other', { stdin: 'x' })))
- expect(piped.stdout.text).toBe('socket\n')
- })
- it('merges ordinary extra env entries onto the scrubbed environment', async () => {
- const result = await finish(spawnSubprocess(spec('echo "$EXTRA_ONE/$EXTRA_TWO"', {
- env: { EXTRA_ONE: 'alpha', EXTRA_TWO: 'beta' },
- })))
- expect(result.stdout.text).toBe('alpha/beta\n')
- })
- it('lets an explicit tombstone remove an ordinary ambient env entry', async () => {
- process.env.SUBPROCESS_TOMBSTONE_PROBE = 'ambient-value'
- try {
- const result = await finish(spawnSubprocess(spec(
- 'echo "${SUBPROCESS_TOMBSTONE_PROBE:-absent}"',
- { env: { SUBPROCESS_TOMBSTONE_PROBE: undefined } },
- )))
- expect(result.stdout.text).toBe('absent\n')
- } finally {
- delete process.env.SUBPROCESS_TOMBSTONE_PROBE
- }
- })
- it('an explicit extra env entry overrides the credential scrub', async () => {
- // EXPLICIT_OVERRIDE_PASSWORD matches the credential scrub pattern, yet an explicit
- // entry is still honored — the scrub only drops AMBIENT process.env creds.
- const result = await finish(spawnSubprocess(spec('echo "$EXPLICIT_OVERRIDE_PASSWORD"', {
- env: { EXPLICIT_OVERRIDE_PASSWORD: 'explicit-wins' },
- })))
- expect(result.stdout.text).toBe('explicit-wins\n')
- })
- it('does not crash or reject when the child ignores a large stdin (EPIPE)', async () => {
- // The child exits without reading, so closing a stdin pipe holding ~1 MiB triggers EPIPE.
- // The handler swallows that write error and `done` reports the child's real exit.
- const big = 'x'.repeat(1024 * 1024)
- const result = await finish(spawnSubprocess(spec('exit 7', { stdin: big })))
- expect(result.exitCode).toBe(7)
- })
- })
- describe('output truncation and spill', () => {
- it('applies stdout and stderr caps independently', async () => {
- const result = await finish(spawnSubprocess(
- spec('printf "%.0sx" $(seq 1 500); printf "%.0se" $(seq 1 500) >&2', {
- stdoutMaxBytes: 500,
- stderrMaxBytes: 100,
- }),
- { spillDir },
- ))
- expect(result.stdout.truncated).toBe(false)
- expect(result.stdout.text).toBe('x'.repeat(500))
- expect(result.stderr.truncated).toBe(true)
- expect(result.stderr.text.length).toBeLessThanOrEqual(100)
- })
- it('keeps the tail and spills the full stream to disk', async () => {
- // 200 numbered lines of ~10 bytes; cap at 500 bytes keeps a late tail.
- const result = await finish(spawnSubprocess(
- spec('for i in $(seq 1 200); do printf "line-%04d\\n" $i; done', { stdoutMaxBytes: 500, stderrMaxBytes: 500 }),
- { spillDir },
- ))
- expect(result.stdout.truncated).toBe(true)
- expect(result.stdout.text.length).toBeLessThanOrEqual(500)
- expect(result.stdout.text).toContain('line-0200')
- expect(result.stdout.text).not.toContain('line-0001')
- expect(result.stdout.spillPath).toBeDefined()
- const full = readFileSync(result.stdout.spillPath!, 'utf8')
- expect(full).toContain('line-0001')
- expect(full).toContain('line-0200')
- })
- it('does not truncate output exactly at the cap', async () => {
- const result = await finish(spawnSubprocess(
- spec('printf "%.0sx" $(seq 1 500)', { stdoutMaxBytes: 500, stderrMaxBytes: 500 }),
- { spillDir },
- ))
- expect(result.stdout.truncated).toBe(false)
- expect(result.stdout.text.length).toBe(500)
- expect(result.stdout.spillPath).toBeUndefined()
- })
- it('settles with the tail and no spill path when final spill close fails', async () => {
- failNextClose.value = true
- const result = await finish(spawnSubprocess(
- spec('for i in $(seq 1 200); do printf "line-%04d\\n" $i; done', { stdoutMaxBytes: 500, stderrMaxBytes: 500 }),
- { spillDir },
- ))
- expect(failNextClose.value).toBe(false)
- expect(result.exitCode).toBe(0)
- expect(result.stdout.truncated).toBe(true)
- expect(result.stdout.text).toContain('line-0200')
- expect(result.stdout.spillPath).toBeUndefined()
- })
- })
- describe('OutputCollector', () => {
- it('keeps the tail of a single oversized chunk', () => {
- const collector = new OutputCollector(10, 100, 'test', spillDir)
- collector.push(Buffer.from('0123456789abcdef'))
- const out = collector.finalize()
- expect(out.text).toBe('6789abcdef')
- expect(out.truncated).toBe(true)
- expect(readFileSync(out.spillPath!, 'utf8')).toBe('0123456789abcdef')
- })
- it('retains a byte-exact tail across uneven chunk boundaries', () => {
- // A diagnostic tail must be exactly the LAST maxBytes regardless of
- // chunking; dropping only whole chunks would under-retain.
- const collector = new OutputCollector(10, undefined, 'exact-tail', spillDir)
- collector.push(Buffer.from('aaaa'))
- collector.push(Buffer.from('bbbbbb'))
- collector.push(Buffer.from('cc'))
- const out = collector.finalize()
- expect(out.text).toBe('aabbbbbbcc')
- expect(Buffer.byteLength(out.text)).toBe(10)
- expect(out.truncated).toBe(true)
- })
- it('readFrom returns increments and flags lossy reads', () => {
- const collector = new OutputCollector(10, 100, 'test', spillDir)
- collector.push(Buffer.from('aaaaa'))
- const first = collector.readFrom(0)
- expect(first.text).toBe('aaaaa')
- expect(first.lossy).toBe(false)
- expect(first.nextOffset).toBe(5)
- collector.push(Buffer.from('bbbbb'))
- const second = collector.readFrom(first.nextOffset)
- expect(second.text).toBe('bbbbb')
- expect(second.lossy).toBe(false)
- // Push enough to slide the window past the last offset.
- collector.push(Buffer.from('c'.repeat(20)))
- const third = collector.readFrom(second.nextOffset)
- expect(third.lossy).toBe(true)
- expect(third.text).toBe('c'.repeat(10))
- expect(third.spillPath).toBeDefined()
- })
- it('contains close failures and drops the spill path', () => {
- const collector = new OutputCollector(4, 100, 'closefail', spillDir)
- collector.push(Buffer.from('aaaa'))
- collector.push(Buffer.from('bbbb'))
- expect(collector.readFrom(0).spillPath).toBeDefined()
- failNextClose.value = true
- let out: ReturnType<typeof collector.finalize>
- expect(() => { out = collector.finalize() }).not.toThrow()
- expect(failNextClose.value).toBe(false)
- expect(out!.text).toBe('bbbb')
- expect(out!.truncated).toBe(true)
- expect(out!.spillPath).toBeUndefined()
- })
- it('discards a spill that exceeds its configured cap', () => {
- const collector = new OutputCollector(4, 8, 'bounded', spillDir)
- collector.push(Buffer.from('aaaa'))
- collector.push(Buffer.from('bbbb'))
- const spillPath = collector.readFrom(0).spillPath!
- expect(readFileSync(spillPath, 'utf8')).toBe('aaaabbbb')
- collector.push(Buffer.from('c'))
- collector.push(Buffer.from('dddd'))
- const out = collector.finalize()
- expect(out.text).toBe('dddd')
- expect(out.truncated).toBe(true)
- expect(out.spillPath).toBeUndefined()
- expect(() => readFileSync(spillPath)).toThrow()
- })
- it('does not create a spill when the first overflowing chunk exceeds the cap', () => {
- const collector = new OutputCollector(4, 4, 'no-spill', spillDir)
- collector.push(Buffer.from('abcdefgh'))
- const out = collector.finalize()
- expect(out.text).toBe('efgh')
- expect(out.truncated).toBe(true)
- expect(out.spillPath).toBeUndefined()
- })
- it('contains cleanup failures while disabling an oversize spill', () => {
- const collector = new OutputCollector(4, 8, 'cleanup-fail', spillDir)
- collector.push(Buffer.from('aaaa'))
- collector.push(Buffer.from('bbbb'))
- const spillPath = collector.readFrom(0).spillPath!
- failNextClose.value = true
- failNextUnlink.value = true
- expect(() => { collector.push(Buffer.from('c')) }).not.toThrow()
- expect(failNextClose.value).toBe(false)
- expect(failNextUnlink.value).toBe(false)
- expect(collector.finalize().spillPath).toBeUndefined()
- unlinkSync(spillPath)
- })
- })
- describe('killGroup', () => {
- it('ignores non-positive pids', () => {
- expect(() => { killGroup(-1, 'SIGTERM') }).not.toThrow()
- expect(() => { killGroup(0, 'SIGTERM') }).not.toThrow()
- })
- it('swallows ESRCH for vanished groups', async () => {
- const running = spawnSubprocess(spec('true'))
- await running.done
- expect(() => { killGroup(running.pid, 'SIGTERM') }).not.toThrow()
- })
- })
- describe('stdio dispositions', () => {
- it("'pipe' exposes raw streams for caller-owned protocol decoding", async () => {
- const running = spawnSubprocess({
- ...spec('cat'),
- stdio: { stdin: 'pipe', stdout: 'pipe', stderr: { maxBytes: 1000 } },
- })
- expect(running.stdin).toBeDefined()
- expect(running.stdout).toBeDefined()
- expect(running.stderr).toBeUndefined()
- expect(running.collected.stdout).toBeUndefined()
- expect(running.collected.stderr).toBeDefined()
- const echoed = new Promise<string>((resolve) => {
- let text = ''
- running.stdout!.on('data', (chunk: Buffer) => { text += chunk.toString('utf8') })
- running.stdout!.on('end', () => { resolve(text) })
- })
- running.stdin!.end('through the pipe\n')
- const outcome = await running.done
- expect(outcome.exitCode).toBe(0)
- expect(await echoed).toBe('through the pipe\n')
- })
- it('a collect mode without spill keeps only the in-memory tail (no file)', async () => {
- const running = spawnSubprocess({
- ...spec('for i in $(seq 1 200); do printf "line-%04d\\n" $i; done'),
- stdio: { stdin: 'ignore', stdout: { maxBytes: 100 }, stderr: { maxBytes: 100 } },
- }, { spillDir })
- await running.done
- const read = running.collected.stdout!.readFrom(0)
- expect(read.lossy).toBe(true)
- expect(read.text).toContain('line-0200')
- expect(read.spillPath).toBeUndefined()
- })
- })
- describe('windows tree semantics (injected platform)', () => {
- it('hides the child window without changing output, exit, stdio, or tree-root options', async () => {
- let options: Parameters<typeof nodeSpawn>[2]
- const result = await finish(spawnSubprocess(spec('echo hello'), {
- spillDir,
- platform: 'win32',
- spawn: (program, args, spawnOptions) => {
- options = spawnOptions
- return nodeSpawn(program, args, spawnOptions)
- },
- }))
- expect(options!).toMatchObject({
- windowsHide: true,
- detached: false,
- stdio: ['ignore', 'pipe', 'pipe'],
- })
- expect(result).toMatchObject({
- exitCode: 0,
- signal: null,
- stdout: { text: 'hello\n', truncated: false },
- stderr: { text: '', truncated: false },
- })
- })
- it('host-exit termination routes through taskkill immediately', async () => {
- const killed: number[] = []
- const running = spawnSubprocess(spec('exec sleep 60', { graceMs: 60_000 }), {
- spillDir,
- platform: 'win32',
- taskkill: (pid) => {
- killed.push(pid)
- try {
- process.kill(pid, 'SIGKILL')
- } catch {
- // Already gone — matches taskkill's tolerated not-found status.
- }
- },
- })
- running.terminateForHostExit()
- await running.done
- expect(killed).toEqual([running.pid])
- })
- it('terminate routes through taskkill by root pid', async () => {
- const killed: number[] = []
- const running = spawnSubprocess(spec('exec sleep 60', { graceMs: 100 }), {
- spillDir,
- platform: 'win32',
- taskkill: (pid) => {
- killed.push(pid)
- // Simulate the forced tree termination taskkill performs.
- try {
- process.kill(pid, 'SIGKILL')
- } catch {
- // Already gone — matches taskkill's tolerated not-found status.
- }
- },
- })
- running.terminate()
- const outcome = await running.done
- expect(killed).toContain(running.pid)
- expect(outcome.signal).toBe(process.platform === 'win32' ? null : 'SIGKILL')
- })
- it('waitForExit falls back to direct-child liveness where groups do not exist', async () => {
- const running = spawnSubprocess(spec('true'), { spillDir, platform: 'win32', taskkill: () => {} })
- await running.done
- await expect(running.waitForExit()).resolves.toBe(true)
- })
- })
- describe('waitForExit', () => {
- it.skipIf(process.platform === 'win32')('waits for the whole detached tree, not just the shell', async () => {
- const pidFile = join(spillDir, `tree-wait-${Date.now()}.pid`)
- const running = spawnSubprocess(spec(`sleep 60 & echo $! > ${pidFile}; wait`))
- const grandchild = await waitForPidFile(pidFile)
- running.terminate()
- await running.done
- await expect(running.waitForExit()).resolves.toBe(true)
- await expect(waitGone(grandchild, 100)).resolves.toBeUndefined()
- })
- it('an aborted wait reports false while the tree lives', async () => {
- const running = spawnSubprocess(spec('sleep 60'))
- const controller = new AbortController()
- controller.abort()
- await expect(running.waitForExit(controller.signal)).resolves.toBe(false)
- running.terminate()
- await running.done
- })
- })
- describe.skipIf(process.platform === 'win32')('synchronous host-exit termination', () => {
- it('force-kills the current process tree without waiting for the normal grace', async () => {
- const running = spawnSubprocess(spec('trap "" TERM; sleep 60', { graceMs: 60_000 }))
- running.terminateForHostExit()
- await expect(running.done).resolves.toMatchObject({ exitCode: null, signal: 'SIGKILL' })
- await expect(running.waitForExit()).resolves.toBe(true)
- const kill = vi.spyOn(process, 'kill')
- try {
- running.terminateForHostExit()
- expect(kill).not.toHaveBeenCalled()
- } finally {
- kill.mockRestore()
- }
- })
- })
- describe.skipIf(process.platform === 'win32')('tree-survivor escalation (terminate and bounded waits reach helpers the leader left behind)', () => {
- it('terminate() SIGKILLs a TERM-trapping descendant after the direct child settles', async () => {
- // The leader spawns a TERM-trapping helper with all stdio detached from
- // the collected pipes, then exits: the helper holds the GROUP alive while
- // the direct child settles. The escalation must still reach it.
- const pidFile = join(spillDir, `survivor-${Date.now()}.pid`)
- const running = spawnSubprocess(spec(
- `bash -c 'trap "" TERM; echo $$ > ${pidFile}; sleep 60' >/dev/null 2>&1 & disown; wait_placeholder=; exit 0`,
- { graceMs: 300 },
- ))
- const helper = await waitForPidFile(pidFile)
- await running.done // direct child settled; helper survives in the group
- expect(() => process.kill(helper, 0)).not.toThrow()
- running.terminate() // SIGTERM (trapped) → grace → SIGKILL the group
- await expect(running.waitForExit()).resolves.toBe(true)
- await waitGone(helper)
- })
- it('a bounded waitForExit reports false while a survivor lives, true after escalation', async () => {
- const pidFile = join(spillDir, `survivor-wait-${Date.now()}.pid`)
- const running = spawnSubprocess(spec(
- `bash -c 'trap "" TERM; echo $$ > ${pidFile}; sleep 60' >/dev/null 2>&1 & disown; exit 0`,
- { graceMs: 200 },
- ))
- const helper = await waitForPidFile(pidFile)
- await running.done
- // A consumer-owned teardown tier bounds its wait and reads the verdict.
- const bound = new AbortController()
- const timer = setTimeout(() => { bound.abort() }, 100)
- await expect(running.waitForExit(bound.signal)).resolves.toBe(false)
- clearTimeout(timer)
- running.terminate()
- await expect(running.waitForExit()).resolves.toBe(true)
- await expect(waitGone(helper)).resolves.toBeUndefined()
- })
- it('service teardown awaits tree survivors, not just handle settlement', async () => {
- const { Context } = await import('@deepseek-ai/cordis')
- const { default: LocalSubprocessRuntime } = await import('@deepseek-ai/dsh-subprocess-local')
- const ctx = new Context()
- const fiber = await ctx.plugin(LocalSubprocessRuntime)
- ;(ctx.subprocess as InstanceType<typeof LocalSubprocessRuntime>).internals = { spillDir }
- const pidFile = join(spillDir, `survivor-svc-${Date.now()}.pid`)
- const running = ctx.subprocess.spawn(spec(
- `bash -c 'trap "" TERM; echo $$ > ${pidFile}; sleep 60' >/dev/null 2>&1 & disown; exit 0`,
- { graceMs: 200 },
- ))
- const helper = await waitForPidFile(pidFile)
- await running.done
- await fiber.dispose()
- // Teardown itself waited for the survivor to become quiescent.
- await expect(waitGone(helper)).resolves.toBeUndefined()
- })
- })
- describe('coverage seams', () => {
- it('hides the taskkill helper window', () => {
- const taskkill = vi.mocked(nodeSpawnSync)
- taskkill.mockReturnValueOnce({} as never)
- taskkillProcessTree(77)
- expect(taskkill).toHaveBeenLastCalledWith(
- 'taskkill',
- ['/PID', '77', '/T', '/F'],
- { stdio: 'ignore', windowsHide: true },
- )
- })
- it('taskkillProcessTree ignores non-positive pids and contains a missing binary', () => {
- expect(() => { taskkillProcessTree(-1) }).not.toThrow()
- expect(() => { taskkillProcessTree(0) }).not.toThrow()
- // On POSIX there is no taskkill; spawnSync reports the failure in its
- // result and the function stays silent — the same containment Windows
- // relies on for an already-absent tree.
- expect(() => { taskkillProcessTree(2 ** 30) }).not.toThrow()
- })
- it('covers the injected POSIX group paths on any host', async () => {
- // Windows has no POSIX groups, so the tree-liveness probe, group
- // signalling, and the SIGKILL escalation timer only run here through the
- // injected platform; the mock keeps the group alive through TERM and
- // terminates the direct child when the escalation tier delivers SIGKILL.
- const running = spawnSubprocess(spec('sleep 60', { graceMs: 100 }), {
- platform: 'linux',
- linuxProcessGroupHasLiveMembers: () => false,
- })
- const realKill = process.kill.bind(process)
- const killSpy = vi.spyOn(process, 'kill').mockImplementation((target, signal) => {
- if (typeof target === 'number' && target < 0) {
- if (signal === 0) return true
- if (signal === 'SIGKILL') realKill(running.pid, 'SIGKILL')
- return true
- }
- return realKill(target, signal)
- })
- try {
- running.terminate()
- await running.done
- await expect(running.waitForExit()).resolves.toBe(true)
- } finally {
- killSpy.mockRestore()
- }
- })
- it('treats a vanished group probe as quiescent without signalling', async () => {
- const running = spawnSubprocess(spec('sleep 60'), { platform: 'linux' })
- const realKill = process.kill.bind(process)
- const killSpy = vi.spyOn(process, 'kill').mockImplementation((target, signal) => {
- if (typeof target === 'number' && target < 0) {
- throw Object.assign(new Error('simulated absent group'), { code: 'ESRCH' })
- }
- return realKill(target, signal)
- })
- try {
- running.terminate()
- await new Promise(resolve => setTimeout(resolve, 20))
- realKill(running.pid, 'SIGKILL')
- await running.done
- await expect(running.waitForExit()).resolves.toBe(true)
- } finally {
- killSpy.mockRestore()
- }
- })
- it('childEnv keeps the POSIX spread on non-Windows hosts', () => {
- const platform = vi.spyOn(process, 'platform', 'get').mockReturnValue('linux')
- try {
- expect(childEnv({ DSH_X: '1' }).DSH_X).toBe('1')
- } finally {
- platform.mockRestore()
- }
- })
- it('settles through the pipe-drain timer when a descendant holds a collected pipe', async () => {
- // The leader spawns a detached grandchild inheriting the collected stdout
- // pipe, then exits: `close` cannot settle while the grandchild holds the
- // pipe, so the bounded pipe-drain timer must settle the outcome.
- const pidFile = join(spillDir, `pipe-drain-${Date.now()}.pid`)
- const childScript = `
- const { spawn } = require('node:child_process')
- const { writeFileSync } = require('node:fs')
- const helper = spawn(process.execPath, ['-e', 'setInterval(() => {}, 1000)'], {
- detached: true,
- stdio: ['ignore', 1, 2],
- })
- writeFileSync(${JSON.stringify(pidFile)}, String(helper.pid))
- helper.unref()
- `
- const running = spawnSubprocess({
- ...spec('unused', { graceMs: 100 }),
- argv: [process.execPath, '-e', childScript],
- })
- // The drain timer starts when the child's stdio closes, which can precede
- // the pid file becoming visible; measure from before that wait so the
- // lower bound cannot be eroded by the pid-file handoff.
- const started = Date.now()
- const helper = await waitForPidFile(pidFile)
- const outcome = await running.done
- expect(outcome.exitCode).toBe(0)
- expect(Date.now() - started).toBeGreaterThanOrEqual(90)
- try {
- process.kill(helper, 'SIGKILL')
- } catch {
- // Already gone; the drain bound is the point under test.
- }
- await waitGone(helper)
- })
- it('a spawn-failed handle rejects done while waitForExit reports gone', async () => {
- const running = spawnSubprocess(spec('true', { cwd: '/nonexistent-dir-dsh-dispose-test' }))
- await expect(running.done).rejects.toThrow()
- await expect(running.waitForExit()).resolves.toBe(true)
- })
- it("an 'inherit' stdout with collected stderr wires only the requested collector", async () => {
- const running = spawnSubprocess({
- ...spec('echo to-parent; echo err >&2'),
- stdio: { stdin: 'ignore', stdout: 'inherit', stderr: { maxBytes: 1000 } },
- })
- const outcome = await running.done
- expect(outcome.exitCode).toBe(0)
- expect(running.stdout).toBeUndefined()
- expect(running.collected.stdout).toBeUndefined()
- expect(running.collected.stderr!.readFrom(0).text).toBe('err\n')
- })
- it("an 'inherit' stderr with collected stdout wires only the requested collector", async () => {
- const running = spawnSubprocess({
- ...spec('echo out; echo to-parent >&2'),
- stdio: { stdin: 'ignore', stdout: { maxBytes: 1000 }, stderr: 'inherit' },
- })
- const outcome = await running.done
- expect(outcome.exitCode).toBe(0)
- expect(running.stderr).toBeUndefined()
- expect(running.collected.stderr).toBeUndefined()
- expect(running.collected.stdout!.readFrom(0).text).toBe('out\n')
- })
- it('terminate() after the tree died delivers no termination signal', async () => {
- const running = spawnSubprocess(spec('true'))
- await running.done
- const spy = vi.spyOn(process, 'kill')
- try {
- running.terminate()
- const delivered = spy.mock.calls.filter(([, sig]) => sig !== 0)
- expect(delivered).toEqual([])
- } finally {
- spy.mockRestore()
- }
- await running.waitForExit()
- })
- it('repeated terminate after exit never probes or signals a reused process group', async () => {
- const running = spawnSubprocess(spec('sleep 60'))
- running.terminate()
- await running.done
- await running.waitForExit()
- const spy = vi.spyOn(process, 'kill').mockImplementation(() => true)
- try {
- running.terminate()
- expect(spy).not.toHaveBeenCalled()
- } finally {
- spy.mockRestore()
- }
- })
- it('waitForExit on a failed spawn reports exited immediately', async () => {
- const running = spawnSubprocess(spec('true', { cwd: '/nonexistent-dir-dsh-spawn-test' }))
- await expect(running.done).rejects.toThrow()
- await expect(running.waitForExit()).resolves.toBe(true)
- })
- it('a batch-stdin handle exposes no stdin surface', async () => {
- const running = spawnSubprocess(spec('cat', { stdin: 'batch\n' }))
- expect(running.stdin).toBeUndefined()
- await running.done
- expect(running.collected.stdout!.readFrom(0).text).toBe('batch\n')
- })
- })
- describe('coverage seams 2', () => {
- it('win32 treeAlive reports alive for a live child and gone after taskkill', async () => {
- let killedPid = 0
- const running = spawnSubprocess(spec('sleep 60'), {
- spillDir,
- platform: 'win32',
- taskkill: (pid) => {
- killedPid = pid
- try {
- process.kill(pid, 'SIGKILL')
- } catch {
- // Already gone.
- }
- },
- })
- const aborted = new AbortController()
- aborted.abort()
- await expect(running.waitForExit(aborted.signal)).resolves.toBe(false) // alive branch
- running.terminate()
- await running.done
- expect(killedPid).toBe(running.pid)
- await expect(running.waitForExit()).resolves.toBe(true)
- })
- it('an inert win32 taskkill leaves the tree alive for a bounded wait to report', async () => {
- // An inert taskkill simulates a tree that never reports exit: terminate()
- // delivers nothing, so a bounded consumer wait must come back false.
- const running = spawnSubprocess(spec('sleep 60'), { spillDir, platform: 'win32', taskkill: () => {} })
- running.terminate()
- const bound = new AbortController()
- const timer = setTimeout(() => { bound.abort() }, 60)
- await expect(running.waitForExit(bound.signal)).resolves.toBe(false)
- clearTimeout(timer)
- // Real cleanup: the injected platform spawned without detachment, so the
- // child is a plain (group-less) POSIX process — kill it directly.
- process.kill(running.pid, 'SIGKILL')
- await running.done
- })
- it("stderr: 'pipe' exposes the raw stream", async () => {
- const running = spawnSubprocess({
- ...spec('echo err >&2'),
- stdio: { stdin: 'ignore', stdout: { maxBytes: 1000 }, stderr: 'pipe' },
- })
- expect(running.stderr).toBeDefined()
- const text = new Promise<string>((resolve) => {
- let out = ''
- running.stderr!.on('data', (chunk: Buffer) => { out += chunk.toString('utf8') })
- running.stderr!.on('end', () => { resolve(out) })
- })
- await running.done
- expect(await text).toBe('err\n')
- })
- })
- describe('argv validation', () => {
- it('rejects an empty argv before spawning', () => {
- expect(() => spawnSubprocess({ ...spec('true'), argv: [] })).toThrow(/non-empty program name/)
- })
- it('rejects an empty program name before spawning', () => {
- expect(() => spawnSubprocess({ ...spec('true'), argv: [''] })).toThrow(/non-empty program name/)
- })
- it.skipIf(process.platform === 'win32')('spawns argv verbatim without shell interpretation', async () => {
- const result = await finish(spawnSubprocess({ ...spec('unused'), argv: ['printf', '%s', '$HOME'] }))
- expect(result.stdout.text).toBe('$HOME')
- })
- })
- describe('abort edge cases', () => {
- it('reports a fallback reason for reason-less pre-aborted signals', () => {
- // Real AbortControllers always set a DOMException reason; signal-like
- // objects from other libraries may not — the fallback covers them.
- const bare = {
- aborted: true,
- reason: undefined,
- addEventListener() {},
- removeEventListener() {},
- } as unknown as AbortSignal
- expect(() => spawnSubprocess(spec('echo hi', { signal: bare })))
- .toThrow(/aborted before spawn: aborted/)
- })
- it.skipIf(process.platform === 'win32')('reports the terminating signal of an externally self-killed command', async () => {
- // spawnSubprocess reports the raw signal; whether it counts as timeout/cancel is the
- // executor's classification (a self-kill is neither) — see executor.spec.ts.
- const result = await finish(spawnSubprocess(spec('kill -TERM $$')))
- expect(result.signal).toBe('SIGTERM')
- })
- })
- describe('environment and spill-file hardening', () => {
- it('scrubs credential-shaped and ambient DSH env vars from child processes', async () => {
- process.env.DSH_TEST_API_KEY = 'super-secret'
- process.env.DSH_TEST_TOKEN = 'also-secret'
- process.env.SUBPROCESS_TEST_PASSWORD = 'password-secret'
- process.env.DSH_TEST_PLAIN = 'visible'
- try {
- const result = await finish(spawnSubprocess(spec(
- 'echo "[${DSH_TEST_API_KEY:-absent}|${DSH_TEST_TOKEN:-absent}|${SUBPROCESS_TEST_PASSWORD:-absent}|${DSH_TEST_PLAIN:-absent}]"',
- )))
- expect(result.stdout.text.trim()).toBe('[absent|absent|absent|absent]')
- } finally {
- delete process.env.DSH_TEST_API_KEY
- delete process.env.DSH_TEST_TOKEN
- delete process.env.SUBPROCESS_TEST_PASSWORD
- delete process.env.DSH_TEST_PLAIN
- }
- })
- it('forwards explicit DSH_* env entries while scrubbing ambient ones', async () => {
- // Both facts through one explicit map: the ambient DSH_STALE is dropped by
- // the scrub, and the deliberately supplied current values merge after it.
- process.env.DSH_STALE = 'old-value'
- try {
- const result = await finish(spawnSubprocess(spec('echo "[${DSH_STALE:-absent}|$DSH_SHELL|$DSH_SESSION_ID]"', {
- env: { DSH_SHELL: '1', DSH_SESSION_ID: 'current-session' },
- })))
- expect(result.stdout.text.trim()).toBe('[absent|1|current-session]')
- } finally {
- delete process.env.DSH_STALE
- }
- })
- it.skipIf(process.platform === 'win32')('creates spill files with owner-only permissions and random names', async () => {
- const result = await finish(spawnSubprocess(
- spec('for i in $(seq 1 200); do printf "line-%04d\\n" $i; done', { stdoutMaxBytes: 500, stderrMaxBytes: 500 }),
- { spillDir },
- ))
- const path = result.stdout.spillPath!
- expect(path).toMatch(/dsh-subprocess-\d+-\d+-[0-9a-f]{12}-stdout\.log$/)
- const mode = statSync(path).mode & 0o777
- expect(mode).toBe(0o600)
- })
- it.skipIf(process.platform === 'win32')('defaults spills into a private per-process directory', async () => {
- const result = await finish(spawnSubprocess(
- spec('for i in $(seq 1 200); do printf "line-%04d\\n" $i; done', { stdoutMaxBytes: 500, stderrMaxBytes: 500 }),
- ))
- const dir = dirname(result.stdout.spillPath!)
- defaultSpillDir = dir
- expect(dir).toMatch(/dsh-subprocess-/)
- const mode = statSync(dir).mode & 0o777
- expect(mode).toBe(0o700)
- })
- it('killGroup never throws, even for EPERM-style failures', () => {
- const spy = vi.spyOn(process, 'kill').mockImplementation(() => {
- throw Object.assign(new Error('EPERM'), { code: 'EPERM' })
- })
- try {
- expect(() => { killGroup(12345, 'SIGTERM') }).not.toThrow()
- } finally {
- spy.mockRestore()
- }
- })
- it('honors AbortSignal on background-style runs (no timeout)', async () => {
- const controller = new AbortController()
- const running = spawnSubprocess(spec('sleep 60', { signal: controller.signal }))
- setTimeout(() => { controller.abort() }, 50)
- const result = await running.done
- expect(result.signal).toBe(process.platform === 'win32' ? null : 'SIGTERM')
- })
- })
|