1
0

model.client.spec.ts 27 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569
  1. /** Browser view ownership across slow RPCs, remounts and transport generations. */
  2. import { setImmediate } from 'node:timers/promises'
  3. import { afterEach, expect, it, vi } from 'vitest'
  4. import { RemoteStream, RemoteStreamCarrierError, type ClientRemote, type RemoteStreamOptions } from '@deepseek-ai/dsh-api-gateway/client'
  5. import { createSnapshotStore } from '@deepseek-ai/dsh-client-store'
  6. import { RemoteError, type RemoteResult } from '@deepseek-ai/dsh-typert-protocol'
  7. import type {} from '@deepseek-ai/dsh-api-terminal-controller/remote'
  8. import type { SessionId } from '@deepseek-ai/dsh-session/types'
  9. import { TerminalView, type TerminalRemote } from '../src/client/model.ts'
  10. import type { TerminalEnvironment, TerminalFrame, WebTerminalId, WebTerminalInfo } from '../src/types.ts'
  11. const sessionId = 'session' as SessionId
  12. const info: WebTerminalInfo = { id: 'terminal' as WebTerminalId, shell: { name: 'bash', path: '/bin/bash', args: ['-i'] }, title: 'bash', cwd: '/workspace', rows: 24, cols: 80, state: 'running', exitCode: null }
  13. const environment: TerminalEnvironment = {
  14. cwd: info.cwd, maxInputBytes: 1000, maxCols: 200, maxRows: 100, scrollback: 100,
  15. }
  16. const success = <T>(value: T): RemoteResult<T> => ({ ok: true, value })
  17. const cleanups: (() => void | Promise<void>)[] = []
  18. afterEach(async () => { for (const close of cleanups.splice(0).reverse()) await close() })
  19. function untilAborted(signal?: AbortSignal): Promise<void> {
  20. return new Promise((resolve) => {
  21. if (signal?.aborted) resolve()
  22. else signal?.addEventListener('abort', () => { resolve() }, { once: true })
  23. })
  24. }
  25. function failure(message: string): RemoteResult<never> {
  26. return { ok: false, error: new RemoteError('gateway/bad-request', message, {}) }
  27. }
  28. function fixture(prepareStream?: <Item>(stream: RemoteStream<Item>) => void) {
  29. const remote: TerminalRemote = {
  30. retain: vi.fn<TerminalRemote['retain']>(async function* (_session, _id, signal) {
  31. yield { type: 'retained' }
  32. await new Promise<void>((resolve) => {
  33. if (signal?.aborted) resolve()
  34. else signal?.addEventListener('abort', () => { resolve() }, { once: true })
  35. })
  36. }),
  37. shells: vi.fn<TerminalRemote['shells']>(async () => success([info.shell])),
  38. environment: vi.fn<TerminalRemote['environment']>(async () => success(environment)), list: vi.fn<TerminalRemote['list']>(async () => success([])),
  39. create: vi.fn<TerminalRemote['create']>(async (_sessionId, request) => success({ ...info, id: request.id })),
  40. close: vi.fn<TerminalRemote['close']>(async () => success(undefined)), rename: vi.fn<TerminalRemote['rename']>(async () => success(undefined)),
  41. write: vi.fn<TerminalRemote['write']>(async () => success(undefined)), resize: vi.fn<TerminalRemote['resize']>(async () => success(undefined)),
  42. follow: vi.fn<TerminalRemote['follow']>(async function* (_sessionId, id, attachmentId, signal) {
  43. yield { type: 'snapshot', sequence: 0, screen: 'ready', info: { ...info, id, controllerId: attachmentId } }
  44. await untilAborted(signal)
  45. }),
  46. }
  47. const options: RemoteStreamOptions<unknown>[] = []
  48. const streams: { dispose(): Promise<void>; restart(): void }[] = []
  49. const generation = createSnapshotStore<ReturnType<ConstructorParameters<typeof RemoteStream>[0]['generation']['getSnapshot']>>(undefined)
  50. const gateway: Pick<ClientRemote, '$stream'> = {
  51. $stream: (option) => {
  52. options.push(option)
  53. const stream = new RemoteStream({ generation }, option)
  54. streams.push(stream)
  55. prepareStream?.(stream)
  56. return stream
  57. },
  58. }
  59. cleanups.push(async () => { await Promise.all(streams.map(stream => stream.dispose())) })
  60. const model = new TerminalView(sessionId, remote, gateway, info.id)
  61. cleanups.push(() => model.dispose())
  62. return { model, remote, gateway, options, streams, generation }
  63. }
  64. async function mount(model: TerminalView) {
  65. const detach = model.mount()
  66. await model.refresh()
  67. return detach
  68. }
  69. function acknowledge(model: TerminalView): void {
  70. const render = model.state.getSnapshot().render
  71. if (render !== undefined) model.acknowledge(render.revision)
  72. }
  73. async function connected(model: TerminalView): Promise<void> {
  74. await mount(model)
  75. await expect.poll(() => model.state.getSnapshot().writable).toBe(true)
  76. acknowledge(model)
  77. }
  78. it('does not let a late input failure downgrade a newer connection', async () => {
  79. const { model, remote } = fixture()
  80. await mount(model)
  81. await expect.poll(() => model.state.getSnapshot().writable).toBe(true)
  82. acknowledge(model)
  83. const input = Promise.withResolvers<RemoteResult<void>>()
  84. vi.mocked(remote.write).mockReturnValueOnce(input.promise)
  85. model.write('x')
  86. await expect.poll(() => vi.mocked(remote.write).mock.calls.length).toBe(1)
  87. model.connect()
  88. await expect.poll(() => vi.mocked(remote.follow).mock.calls.length).toBe(2)
  89. await expect.poll(() => model.state.getSnapshot().writable).toBe(true)
  90. model.write('current input')
  91. input.reject(new Error('old attachment was replaced'))
  92. await expect.poll(() => vi.mocked(remote.write).mock.calls.some(call => call[3] === 'current input')).toBe(true)
  93. expect(model.state.getSnapshot()).toMatchObject({ phase: 'connected', writable: true, error: undefined })
  94. })
  95. it('waits for render acknowledgement before publishing subsequent output', async () => {
  96. const { model, remote } = fixture()
  97. vi.mocked(remote.follow).mockImplementation(async function* (_sessionId, id, controllerId, signal) {
  98. const frames: TerminalFrame[] = [
  99. { type: 'snapshot', sequence: 0, screen: '', info: { ...info, id, controllerId } },
  100. { type: 'output', sequence: 1, data: 'first' },
  101. { type: 'output', sequence: 2, data: 'second' },
  102. ]
  103. for (const frame of frames) yield frame
  104. await untilAborted(signal)
  105. })
  106. await mount(model)
  107. await expect.poll(() => model.state.getSnapshot().render?.frame.type).toBe('snapshot')
  108. acknowledge(model)
  109. await expect.poll(() => model.state.getSnapshot().render?.frame).toMatchObject({ type: 'output', sequence: 1 })
  110. acknowledge(model)
  111. await expect.poll(() => model.state.getSnapshot().render?.frame).toMatchObject({ type: 'output', sequence: 2 })
  112. })
  113. it('serializes input and resizes, clamps geometry, and suppresses unchanged sizes', async () => {
  114. const { model, remote } = fixture()
  115. await connected(model)
  116. const input = Promise.withResolvers<RemoteResult<void>>()
  117. vi.mocked(remote.write).mockReturnValueOnce(input.promise)
  118. model.resize(80, 24)
  119. model.write('first')
  120. model.write('second')
  121. model.resize(500, 300)
  122. await expect.poll(() => vi.mocked(remote.write).mock.calls.length).toBe(1)
  123. expect(remote.resize).not.toHaveBeenCalled()
  124. input.resolve(success(undefined))
  125. await expect.poll(() => vi.mocked(remote.resize).mock.calls.length).toBe(1)
  126. const attachmentId = vi.mocked(remote.follow).mock.calls[0]![2]
  127. const id = model.state.getSnapshot().info!.id
  128. expect(vi.mocked(remote.write).mock.calls.map(call => call[3])).toEqual(['first', 'second'])
  129. expect(remote.resize).toHaveBeenCalledWith(sessionId, id, attachmentId, 200, 100)
  130. model.resize(90, 24)
  131. await expect.poll(() => vi.mocked(remote.resize).mock.calls.length).toBe(2)
  132. })
  133. it('bounds queued input by UTF-8 bytes and releases the byte budget after settlement', async () => {
  134. const { model, remote } = fixture()
  135. vi.mocked(remote.environment).mockResolvedValue(success({ ...environment, maxInputBytes: 6 }))
  136. await connected(model)
  137. const input = Promise.withResolvers<RemoteResult<void>>()
  138. vi.mocked(remote.write).mockReturnValueOnce(input.promise)
  139. model.write('界界')
  140. await expect.poll(() => vi.mocked(remote.write).mock.calls.length).toBe(1)
  141. model.write('a')
  142. expect(model.state.getSnapshot()).toMatchObject({ phase: 'failed', issue: 'inputFull' })
  143. input.resolve(success(undefined))
  144. model.connect()
  145. await expect.poll(() => model.state.getSnapshot().writable).toBe(true)
  146. model.write('界界')
  147. await expect.poll(() => vi.mocked(remote.write).mock.calls.length).toBe(2)
  148. expect(vi.mocked(remote.write).mock.calls.map(call => call[3])).toEqual(['界界', '界界'])
  149. })
  150. it('drops queued commands from a detached attachment and ignores its late resize failure', async () => {
  151. const { model, remote } = fixture()
  152. await connected(model)
  153. const input = Promise.withResolvers<RemoteResult<void>>()
  154. vi.mocked(remote.resize).mockReturnValueOnce(input.promise)
  155. model.resize(100, 30)
  156. await expect.poll(() => vi.mocked(remote.resize).mock.calls.length).toBe(1)
  157. model.write('stale')
  158. model.resize(110, 35)
  159. model.connect()
  160. await expect.poll(() => model.state.getSnapshot().writable).toBe(true)
  161. model.write('current')
  162. input.resolve(failure('old attachment'))
  163. await expect.poll(() => vi.mocked(remote.write).mock.calls.length).toBe(1)
  164. expect(vi.mocked(remote.write).mock.calls[0]?.[3]).toBe('current')
  165. expect(remote.resize).toHaveBeenCalledOnce()
  166. expect(model.state.getSnapshot().phase).toBe('connected')
  167. })
  168. it('publishes current input and resize failures and can reconnect for another attempt', async () => {
  169. const { model, remote } = fixture()
  170. await connected(model)
  171. vi.mocked(remote.write).mockResolvedValueOnce(failure('input refused'))
  172. model.write('x')
  173. await expect.poll(() => model.state.getSnapshot().error).toBe('input refused')
  174. model.connect()
  175. await expect.poll(() => model.state.getSnapshot().writable).toBe(true)
  176. vi.mocked(remote.resize).mockResolvedValueOnce(failure('resize refused'))
  177. model.resize(100, 30)
  178. await expect.poll(() => model.state.getSnapshot().error).toBe('resize refused')
  179. })
  180. it('treats carrier loss as disconnected only for the active attachment', async () => {
  181. const { model, options } = fixture()
  182. await connected(model)
  183. const first = options[0]!
  184. first.carrierFailed?.(new RemoteStreamCarrierError('offline'))
  185. expect(model.state.getSnapshot()).toMatchObject({ phase: 'disconnected', writable: false })
  186. model.connect()
  187. await expect.poll(() => model.state.getSnapshot().writable).toBe(true)
  188. first.carrierFailed?.(new RemoteStreamCarrierError('late old failure'))
  189. expect(model.state.getSnapshot().phase).toBe('connected')
  190. })
  191. it.each([
  192. ['output before snapshot', [{ type: 'output', sequence: 1, data: 'orphan' }], 'missing its screen snapshot'],
  193. ['sequence gap', [{ type: 'snapshot', sequence: 4, screen: '', info }, { type: 'output', sequence: 6, data: 'gap' }], 'sequence has a gap'],
  194. ['repeated snapshot', [{ type: 'snapshot', sequence: 4, screen: '', info }, { type: 'snapshot', sequence: 4, screen: '', info }], 'Unexpected terminal screen snapshot'],
  195. ] satisfies readonly (readonly [string, readonly TerminalFrame[], string])[])('refuses a malformed output stream: %s', async (_name, frames, message) => {
  196. const { model, remote } = fixture()
  197. vi.mocked(remote.follow).mockImplementation(async function* () { yield* frames })
  198. await mount(model)
  199. if (frames[0]?.type === 'snapshot') {
  200. await expect.poll(() => model.state.getSnapshot().render).toBeDefined()
  201. acknowledge(model)
  202. }
  203. await expect.poll(() => model.state.getSnapshot().error).toContain(message)
  204. expect(model.state.getSnapshot().writable).toBe(false)
  205. })
  206. it('retains an exited screen and closes controls when its stream ends', async () => {
  207. const { model, remote } = fixture()
  208. vi.mocked(remote.follow).mockImplementation(async function* (_sessionId, id, controllerId) {
  209. yield { type: 'snapshot', sequence: 0, screen: 'last screen', info: { ...info, id, controllerId } }
  210. yield { type: 'state', info: { ...info, id, controllerId, state: 'exited', exitCode: 3 } }
  211. })
  212. await connected(model)
  213. await expect.poll(() => model.state.getSnapshot().phase).toBe('closed')
  214. expect(model.state.getSnapshot()).toMatchObject({ writable: false, info: { state: 'exited', exitCode: 3 }, render: { frame: { screen: 'last screen' } } })
  215. })
  216. it('reports an attachment ending while the shell is still running and permits manual reconnect', async () => {
  217. const { model, remote } = fixture()
  218. vi.mocked(remote.follow).mockImplementationOnce(async function* (_sessionId, id, controllerId) {
  219. yield { type: 'snapshot', sequence: 0, screen: '', info: { ...info, id, controllerId } }
  220. })
  221. await connected(model)
  222. await expect.poll(() => model.state.getSnapshot().issue).toBe('attachmentEnded')
  223. model.connect()
  224. await expect.poll(() => model.state.getSnapshot().writable).toBe(true)
  225. })
  226. it('publishes remote control transfer without replacing the retained screen', async () => {
  227. const { model, remote } = fixture()
  228. vi.mocked(remote.follow).mockImplementation(async function* (_sessionId, id, controllerId, signal) {
  229. yield { type: 'snapshot', sequence: 0, screen: 'retained', info: { ...info, id, controllerId } }
  230. yield { type: 'state', info: { ...info, id } }
  231. await untilAborted(signal)
  232. })
  233. await connected(model)
  234. await expect.poll(() => model.state.getSnapshot().writable).toBe(false)
  235. expect(model.state.getSnapshot().render?.frame).toMatchObject({ type: 'snapshot', screen: 'retained' })
  236. })
  237. /** Pause delivery after the real Gateway iterator settles, before the model observes it. */
  238. function deliveryBarrier() {
  239. const ready = Promise.withResolvers<undefined>()
  240. const release = Promise.withResolvers<undefined>()
  241. let held = false
  242. function prepare<Item>(stream: RemoteStream<Item>): void {
  243. if (held) return
  244. held = true
  245. const iterator = stream[Symbol.asyncIterator]()
  246. let first = true
  247. vi.spyOn(stream, Symbol.asyncIterator).mockReturnValue({
  248. async next() {
  249. if (!first) return iterator.next()
  250. first = false
  251. try {
  252. return await iterator.next()
  253. } finally {
  254. ready.resolve(undefined)
  255. await release.promise
  256. }
  257. },
  258. async return() { return iterator.return!() },
  259. })
  260. }
  261. cleanups.push(() => { release.resolve(undefined) })
  262. return { ready: ready.promise, release: () => { release.resolve(undefined) }, prepare }
  263. }
  264. it('ignores an already delivered screen when its attachment is replaced before the model receives it', async () => {
  265. const barrier = deliveryBarrier()
  266. const { model, remote } = fixture(barrier.prepare)
  267. await mount(model)
  268. await barrier.ready
  269. model.connect()
  270. await expect.poll(() => model.state.getSnapshot().writable).toBe(true)
  271. const current = model.state.getSnapshot()
  272. barrier.release()
  273. await model.rename('settled')
  274. expect(model.state.getSnapshot().render).toBe(current.render)
  275. expect(remote.follow).toHaveBeenCalledTimes(2)
  276. })
  277. it('ignores an already settled stream error after a newer attachment has become writable', async () => {
  278. const barrier = deliveryBarrier()
  279. const { model, remote } = fixture(barrier.prepare)
  280. vi.mocked(remote.follow).mockImplementationOnce(async function* () {
  281. yield* []
  282. throw new Error('retired attachment failed')
  283. })
  284. await mount(model)
  285. await barrier.ready
  286. model.connect()
  287. await expect.poll(() => model.state.getSnapshot().writable).toBe(true)
  288. barrier.release()
  289. await model.rename('settled')
  290. expect(model.state.getSnapshot()).toMatchObject({ phase: 'connected', writable: true, error: undefined })
  291. })
  292. it('releases a pending screen render on carrier generation cancellation and accepts the replacement screen', async () => {
  293. const { model, remote, streams } = fixture()
  294. await mount(model)
  295. await expect.poll(() => model.state.getSnapshot().render).toBeDefined()
  296. const revision = model.state.getSnapshot().render!.revision
  297. streams[0]!.restart()
  298. await expect.poll(() => model.state.getSnapshot().render?.revision).toBe(revision + 1)
  299. expect(remote.follow).toHaveBeenCalledTimes(2)
  300. expect(model.state.getSnapshot().writable).toBe(true)
  301. })
  302. it('does not wait for the DOM callback of a screen whose generation was already cancelled at delivery', async () => {
  303. const barrier = deliveryBarrier()
  304. const { model, remote, streams } = fixture(barrier.prepare)
  305. await mount(model)
  306. await barrier.ready
  307. streams[0]!.restart()
  308. barrier.release()
  309. await expect.poll(() => model.state.getSnapshot().render?.revision).toBe(2)
  310. expect(remote.follow).toHaveBeenCalledTimes(2)
  311. expect(model.state.getSnapshot().writable).toBe(true)
  312. })
  313. it.each(['write', 'resize'] as const)('keeps a fresh attachment writable when a pending %s fails after automatic transport recovery', async (operation) => {
  314. const { model, remote, generation } = fixture()
  315. generation.set({ id: 1, host: { home: '/home/fixture' } })
  316. const disconnected = Promise.withResolvers<undefined>()
  317. vi.mocked(remote.follow).mockImplementationOnce(async function* (_sessionId, id, controllerId, signal) {
  318. yield { type: 'snapshot', sequence: 0, screen: 'before disconnect', info: { ...info, id, controllerId } }
  319. await Promise.race([disconnected.promise, untilAborted(signal)])
  320. if (signal?.aborted) return
  321. throw new RemoteStreamCarrierError('connection lost')
  322. })
  323. await connected(model)
  324. const pending = Promise.withResolvers<RemoteResult<void>>()
  325. if (operation === 'write') {
  326. vi.mocked(remote.write).mockReturnValueOnce(pending.promise)
  327. model.write('old input')
  328. } else {
  329. vi.mocked(remote.resize).mockReturnValueOnce(pending.promise)
  330. model.resize(100, 30)
  331. }
  332. await expect.poll(() => vi.mocked(remote[operation]).mock.calls.length).toBe(1)
  333. const oldAttachmentId = vi.mocked(remote.follow).mock.calls[0]![2]
  334. generation.set(undefined)
  335. disconnected.resolve(undefined)
  336. await expect.poll(() => model.state.getSnapshot().phase).toBe('disconnected')
  337. expect(model.state.getSnapshot().writable).toBe(false)
  338. expect(remote.follow).toHaveBeenCalledOnce()
  339. generation.set({ id: 2, host: { home: '/home/fixture' } })
  340. await expect.poll(() => model.state.getSnapshot().writable).toBe(true)
  341. expect(remote.follow).toHaveBeenCalledTimes(2)
  342. const attachmentId = vi.mocked(remote.follow).mock.calls[1]![2]
  343. expect(attachmentId).not.toBe(oldAttachmentId)
  344. expect(model.state.getSnapshot().info?.controllerId).toBe(attachmentId)
  345. expect(model.state.getSnapshot().render?.frame).toMatchObject({ type: 'snapshot', screen: 'ready' })
  346. model.write('fresh input')
  347. pending.reject(new Error('old attachment was replaced'))
  348. await expect.poll(() => vi.mocked(remote.write).mock.calls.some(call => call[3] === 'fresh input')).toBe(true)
  349. expect(model.state.getSnapshot()).toMatchObject({ phase: 'connected', writable: true, error: undefined })
  350. expect(vi.mocked(remote.write).mock.calls.at(-1)?.[2]).toBe(attachmentId)
  351. expect(remote.create).toHaveBeenCalledOnce()
  352. expect(remote.close).not.toHaveBeenCalled()
  353. })
  354. it('ignores controls before discovery and reconnects an existing process after remount', async () => {
  355. const { model, remote } = fixture()
  356. model.connect()
  357. model.write('early')
  358. model.resize(100, 30)
  359. model.acknowledge(100)
  360. expect(remote.follow).not.toHaveBeenCalled()
  361. expect(remote.write).not.toHaveBeenCalled()
  362. expect(remote.resize).not.toHaveBeenCalled()
  363. const unmount = await mount(model)
  364. await expect.poll(() => model.state.getSnapshot().writable).toBe(true)
  365. unmount()
  366. model.connect()
  367. model.write('detached')
  368. model.resize(100, 30)
  369. expect(remote.follow).toHaveBeenCalledOnce()
  370. expect(remote.write).not.toHaveBeenCalled()
  371. expect(remote.resize).not.toHaveBeenCalled()
  372. model.mount()
  373. await expect.poll(() => remote.follow).toHaveBeenCalledTimes(2)
  374. await expect.poll(() => model.state.getSnapshot().writable).toBe(true)
  375. expect(remote.create).toHaveBeenCalledOnce()
  376. })
  377. it('keeps controls inert when process metadata or the attachment is unavailable', async () => {
  378. const { model, remote } = fixture()
  379. await connected(model)
  380. const state = model.state.getSnapshot()
  381. model.state.set({ ...state, info: undefined })
  382. model.write('missing metadata')
  383. model.resize(100, 30)
  384. expect(remote.write).not.toHaveBeenCalled()
  385. expect(remote.resize).not.toHaveBeenCalled()
  386. model.state.set({ ...state, environment: undefined })
  387. model.resize(100, 30)
  388. await expect.poll(() => remote.resize).toHaveBeenCalledOnce()
  389. expect(vi.mocked(remote.resize).mock.calls[0]?.slice(-2)).toEqual([100, 30])
  390. model.write('unknown budget')
  391. expect(model.state.getSnapshot().issue).toBe('inputFull')
  392. expect(remote.write).not.toHaveBeenCalled()
  393. })
  394. it('renames an existing terminal, skips unchanged names, and exposes rename failures', async () => {
  395. const { model, remote } = fixture()
  396. await connected(model)
  397. await model.rename(` ${info.title} `)
  398. expect(remote.rename).not.toHaveBeenCalled()
  399. await model.rename(' Build ')
  400. expect(model.state.getSnapshot()).toMatchObject({ title: 'Build', info: { title: 'Build' } })
  401. vi.mocked(remote.rename).mockRejectedValueOnce('rename connection lost')
  402. await model.rename('Other')
  403. expect(model.state.getSnapshot()).toMatchObject({ phase: 'failed', error: 'rename connection lost', title: 'Build' })
  404. await model.dispose()
  405. await model.rename('Ignored')
  406. expect(remote.rename).toHaveBeenCalledTimes(2)
  407. })
  408. it('classifies a discovery carrier failure as disconnected and supports explicit retry', async () => {
  409. const { model, remote } = fixture()
  410. vi.mocked(remote.environment).mockRejectedValueOnce(new RemoteStreamCarrierError('offline'))
  411. await model.refresh()
  412. expect(model.state.getSnapshot()).toMatchObject({ phase: 'disconnected', error: 'offline' })
  413. expect(remote.create).not.toHaveBeenCalled()
  414. await model.refresh()
  415. expect(model.state.getSnapshot().info?.id).toBe(info.id)
  416. expect(remote.create).toHaveBeenCalledOnce()
  417. })
  418. it('retains state when disposal overtakes successful allocation or a failed discovery', async () => {
  419. for (const operation of ['creation', 'discovery'] as const) {
  420. const { model, remote } = fixture()
  421. const creation = Promise.withResolvers<RemoteResult<WebTerminalInfo>>()
  422. const discovery = Promise.withResolvers<RemoteResult<TerminalEnvironment>>()
  423. if (operation === 'creation') vi.mocked(remote.create).mockReturnValueOnce(creation.promise)
  424. else vi.mocked(remote.environment).mockReturnValueOnce(discovery.promise)
  425. const loading = model.refresh()
  426. if (operation === 'creation') await expect.poll(() => remote.create).toHaveBeenCalledOnce()
  427. await model.dispose()
  428. const before = model.state.getSnapshot()
  429. if (operation === 'creation') creation.resolve(success(info))
  430. else discovery.reject(new Error('late discovery failure'))
  431. await loading
  432. expect(model.state.getSnapshot()).toBe(before)
  433. expect(remote.follow).not.toHaveBeenCalled()
  434. }
  435. })
  436. it('ignores a successful rename after the view is disposed', async () => {
  437. const { model, remote } = fixture()
  438. await connected(model)
  439. const rename = Promise.withResolvers<RemoteResult<void>>()
  440. vi.mocked(remote.rename).mockReturnValueOnce(rename.promise)
  441. const pending = model.rename('Late')
  442. await model.dispose()
  443. const before = model.state.getSnapshot()
  444. rename.resolve(success(undefined))
  445. await pending
  446. expect(model.state.getSnapshot()).toBe(before)
  447. })
  448. it('allows retry after failed process cleanup and never reconnects while close is pending', async () => {
  449. const { model, remote } = fixture()
  450. await connected(model)
  451. const closing = Promise.withResolvers<RemoteResult<void>>()
  452. vi.mocked(remote.close).mockReturnValueOnce(closing.promise)
  453. const first = model.close()
  454. expect(model.close()).toBe(first)
  455. model.connect()
  456. expect(remote.follow).toHaveBeenCalledOnce()
  457. closing.resolve(failure('close refused'))
  458. await expect(first).rejects.toThrow('close refused')
  459. expect(model.state.getSnapshot()).toMatchObject({ phase: 'failed', error: 'close refused' })
  460. await model.close()
  461. expect(model.state.getSnapshot()).toMatchObject({ phase: 'closed', writable: false })
  462. expect(remote.close).toHaveBeenCalledTimes(2)
  463. })
  464. it('does not publish a close result or reconnect after disposal', async () => {
  465. const { model, remote } = fixture()
  466. await connected(model)
  467. const closing = Promise.withResolvers<RemoteResult<void>>()
  468. vi.mocked(remote.close).mockReturnValueOnce(closing.promise)
  469. const pending = model.close()
  470. await model.dispose()
  471. const before = model.state.getSnapshot()
  472. closing.resolve(success(undefined))
  473. await pending
  474. model.mount()
  475. model.connect()
  476. expect(model.state.getSnapshot()).toBe(before)
  477. expect(remote.follow).toHaveBeenCalledOnce()
  478. })
  479. it.each(['write', 'resize'] as const)('keeps the output connection when %s loses control before its state frame arrives', async (operation) => {
  480. const { model, remote } = fixture()
  481. const transfer = Promise.withResolvers<undefined>()
  482. const response = Promise.withResolvers<RemoteResult<void>>()
  483. cleanups.push(() => { transfer.resolve(undefined); response.resolve(success(undefined)) })
  484. vi.mocked(remote.follow).mockImplementation(async function* (_session, id, controllerId, signal) {
  485. yield { type: 'snapshot', sequence: 0, screen: 'retained screen', info: { ...info, id, controllerId } }
  486. await transfer.promise
  487. yield { type: 'state', info: { ...info, id } }
  488. await untilAborted(signal)
  489. })
  490. await connected(model)
  491. vi.mocked(remote[operation]).mockReturnValueOnce(response.promise)
  492. if (operation === 'write') model.write('before transfer')
  493. else model.resize(100, 30)
  494. model.write('queued before transfer')
  495. await expect.poll(() => vi.mocked(remote[operation]).mock.calls.length).toBe(1)
  496. response.resolve({ ok: false, error: new RemoteError('terminal/control-unavailable', 'Another window owns input', { reason: 'read-only' }) })
  497. await expect.poll(() => model.state.getSnapshot().writable).toBe(false)
  498. expect(model.state.getSnapshot()).toMatchObject({ phase: 'connected', error: undefined, issue: undefined, render: { frame: { screen: 'retained screen' } } })
  499. transfer.resolve(undefined)
  500. await expect.poll(() => model.state.getSnapshot().info?.controllerId).toBeUndefined()
  501. expect(remote.follow).toHaveBeenCalledOnce()
  502. expect(vi.mocked(remote.write).mock.calls.some(call => call[3] === 'queued before transfer')).toBe(false)
  503. })
  504. it('keeps an exited screen when a pending input is refused after the exit state arrives', async () => {
  505. const { model, remote } = fixture()
  506. const exit = Promise.withResolvers<undefined>()
  507. const response = Promise.withResolvers<RemoteResult<void>>()
  508. cleanups.push(() => { exit.resolve(undefined); response.resolve(success(undefined)) })
  509. vi.mocked(remote.follow).mockImplementation(async function* (_session, id, controllerId, signal) {
  510. yield { type: 'snapshot', sequence: 0, screen: 'final screen', info: { ...info, id, controllerId } }
  511. await exit.promise
  512. yield { type: 'state', info: { ...info, id, state: 'exited', exitCode: 0 } }
  513. await untilAborted(signal)
  514. })
  515. await connected(model)
  516. vi.mocked(remote.write).mockReturnValueOnce(response.promise)
  517. model.write('exit race')
  518. await expect.poll(() => vi.mocked(remote.write).mock.calls.length).toBe(1)
  519. exit.resolve(undefined)
  520. await expect.poll(() => model.state.getSnapshot().info?.state).toBe('exited')
  521. response.resolve({ ok: false, error: new RemoteError('terminal/control-unavailable', 'Terminal is not running', { reason: 'not-running' }) })
  522. await setImmediate()
  523. expect(model.state.getSnapshot()).toMatchObject({ phase: 'connected', writable: false, error: undefined, issue: undefined, render: { frame: { screen: 'final screen' } } })
  524. })
  525. it('exposes a localized quota error and clears it after a successful retry', async () => {
  526. const { model, remote } = fixture()
  527. vi.mocked(remote.create).mockResolvedValueOnce({ ok: false, error: new RemoteError('terminal/limit-reached', 'Session terminal limit reached', { limit: 8 }) })
  528. await model.refresh()
  529. expect(model.state.getSnapshot()).toMatchObject({ phase: 'failed', issue: 'terminalLimit' })
  530. await connected(model)
  531. expect(model.state.getSnapshot()).toMatchObject({ phase: 'connected', issue: undefined, error: undefined })
  532. })