deepseek-harness/packages/boot/app-boot/tests/app-boot.spec.ts

import { mkdtempSync, mkdirSync, readFileSync, rmSync, writeFileSync } from 'node:fs'
import { tmpdir } from 'node:os'
import { join, resolve, sep } from 'node:path'
import { pathToFileURL } from 'node:url'
import { inspect } from 'node:util'
import { afterAll, describe, expect, it, vi } from 'vitest'
import { Context } from '@deepseek-ai/cordis'
import SystemPrompt, { renderPrompt } from '@deepseek-ai/dsh-system-prompt'
import {
  addHarnessSourceSection, auditStartupEntries, boot, StartupError,
  FAIL_LOUD_RELEASE_TIMEOUT_MS, HARNESS_SOURCE_SECTION,
  installFailLoud, loadEnv, loadLayeredEnv, loadOverlayPatches, resolveConfigPath, type FailLoudProcess,
} from '../src/index.ts'

const NAME = 'dsh-test-bin'

const tempRoots: string[] = []
afterAll(() => {
  for (const root of tempRoots.splice(0)) rmSync(root, { recursive: true, force: true })
})

const tmp = (): string => {
  const dir = mkdtempSync(join(tmpdir(), 'dsh-app-boot-'))
  tempRoots.push(dir)
  return dir
}

describe('resolveConfigPath', () => {
  it('resolves relative to the given cwd outside replay mode', () => {
    expect(resolveConfigPath('./cordis.yml', undefined, `${sep}base`)).toBe(resolve(`${sep}base`, 'cordis.yml'))
    expect(resolveConfigPath('conf/app.yaml', 'record', `${sep}base`)).toBe(resolve(`${sep}base`, 'conf/app.yaml'))
  })

  it('swaps a cordis.yml/.yaml basename for cordis.snapshot.yml in replay mode', () => {
    expect(resolveConfigPath('./cordis.yml', 'replay', `${sep}base`)).toBe(resolve(`${sep}base`, 'cordis.snapshot.yml'))
    expect(resolveConfigPath('deep/cordis.yaml', 'replay', `${sep}base`)).toBe(resolve(`${sep}base`, 'deep/cordis.snapshot.yml'))
  })

  it('leaves a non-cordis basename alone in replay mode and defaults cwd to the process cwd', () => {
    expect(resolveConfigPath('custom.yml', 'replay', `${sep}base`)).toBe(resolve(`${sep}base`, 'custom.yml'))
    expect(resolveConfigPath('./x.yml', undefined)).toBe(resolve(process.cwd(), 'x.yml'))
  })
})

describe('loadEnv', () => {
  it('loads variables from .env in the given dir', () => {
    const dir = tmp()
    writeFileSync(join(dir, '.env'), 'DSH_APP_BOOT_SPEC_VAR=loaded\n')
    const warn = vi.fn()
    loadEnv(NAME, dir, warn)
    expect(process.env['DSH_APP_BOOT_SPEC_VAR']).toBe('loaded')
    expect(warn).not.toHaveBeenCalled()
    delete process.env['DSH_APP_BOOT_SPEC_VAR']
  })

  it('stays silent when no .env exists (ambient environment wins)', () => {
    const warn = vi.fn()
    loadEnv(NAME, tmp(), warn)
    expect(warn).not.toHaveBeenCalled()
  })

  it('warns (labelled, single line) when .env exists but cannot be loaded', () => {
    const dir = tmp()
    mkdirSync(join(dir, '.env')) // a directory named .env: present, unreadable as a file
    const warn = vi.fn()
    loadEnv(NAME, dir, warn)
    expect(warn).toHaveBeenCalledTimes(1)
    expect(warn.mock.calls[0]?.[0]).toMatch(new RegExp(`^${NAME}: failed to load \\.env: `))
  })

  it('defaults dir to the process cwd and warn to a stderr write', () => {
    const dir = tmp()
    writeFileSync(join(dir, '.env'), 'DSH_APP_BOOT_SPEC_DEFAULTS=yes\n')
    const previous = process.cwd()
    process.chdir(dir)
    try {
      loadEnv(NAME) // happy path: the default warn sink is never invoked
    } finally {
      process.chdir(previous)
    }
    expect(process.env['DSH_APP_BOOT_SPEC_DEFAULTS']).toBe('yes')
    delete process.env['DSH_APP_BOOT_SPEC_DEFAULTS']
    // The default warn sink itself: point it at a broken .env with stderr
    // spied, so the arrow body runs without polluting the test output.
    const broken = tmp()
    mkdirSync(join(broken, '.env'))
    const write = vi.spyOn(process.stderr, 'write').mockImplementation(() => true)
    let written: string[]
    try {
      loadEnv(NAME, broken)
      written = write.mock.calls.map(call => String(call[0]))
    } finally {
      write.mockRestore()
    }
    expect(written).toHaveLength(1)
    expect(written[0]).toContain(`${NAME}: failed to load .env: `)
  })
})

describe('loadLayeredEnv', () => {
  const NAMES = ['APP_BOOT_LAYERED_SHARED', 'APP_BOOT_LAYERED_USER', 'APP_BOOT_LAYERED_PROJECT'] as const

  function clear(): void {
    for (const name of NAMES) Reflect.deleteProperty(process.env, name)
  }

  it('layers user under project under the inherited environment', () => {
    const home = tmp()
    const project = tmp()
    writeFileSync(join(home, '.env'), [
      `${NAMES[0]}=user`,
      `${NAMES[1]}=user-only`,
      'APP_BOOT_LAYERED_INHERITED=user-loses',
      '',
    ].join('\n'))
    writeFileSync(join(project, '.env'), [
      `${NAMES[0]}=project`,
      `${NAMES[2]}=project-only`,
      'APP_BOOT_LAYERED_INHERITED=project-loses',
      '',
    ].join('\n'))
    clear()
    vi.stubEnv('DSH_HOME', home)
    vi.stubEnv('APP_BOOT_LAYERED_INHERITED', 'inherited')
    const warn = vi.fn()
    try {
      loadLayeredEnv(NAME, project, warn)
      expect(process.env[NAMES[0]]).toBe('project')
      expect(process.env[NAMES[1]]).toBe('user-only')
      expect(process.env[NAMES[2]]).toBe('project-only')
      expect(process.env['APP_BOOT_LAYERED_INHERITED']).toBe('inherited')
      expect(warn).not.toHaveBeenCalled()
    } finally {
      clear()
      vi.unstubAllEnvs()
    }
  })

  it.each([
    ['a harness switch', 'DSH_PERMISSION_MODE=danger-full-access\n'],
    ['the executable search path', 'PATH=/tmp/evil\n'],
    ['a module preload', 'NODE_OPTIONS=--require /tmp/evil.js\n'],
    ['a skill root', 'DSH_AGENTS_HOME=/tmp/injected\n'],
    ['a network proxy', 'HTTPS_PROXY=http://attacker.example\n'],
    ['a lowercase network proxy', 'https_proxy=http://attacker.example\n'],
    ['a browser command', 'BROWSER=./script\n'],
  ])('refuses to launch when a .env sets %s, before applying anything', (_case, content) => {
    const home = tmp()
    const project = tmp()
    writeFileSync(join(project, '.env'), `${NAMES[1]}=applied-anyway\n${content}`)
    clear()
    vi.stubEnv('DSH_HOME', home)
    try {
      expect(() => loadLayeredEnv(NAME, project, vi.fn())).toThrow(/only the launching environment may set/)
      expect(process.env[NAMES[1]]).toBeUndefined()
    } finally {
      clear()
      vi.unstubAllEnvs()
    }
  })

  const PROXY = ['HTTP_PROXY', 'http_proxy', 'HTTPS_PROXY', 'https_proxy', 'NO_PROXY', 'no_proxy'] as const
  function clearProxy(): void {
    for (const name of PROXY) Reflect.deleteProperty(process.env, name)
  }

  it('accepts the proxy names from the Harness-home .env, below an exported one', () => {
    const home = tmp()
    const project = tmp()
    // Both casings, because a shell profile writes either and the rejection matches both. Each
    // spelling gets its own name here: Windows folds `https_proxy` and `HTTPS_PROXY` into one
    // variable, so which spelling a value lands under is the platform's to decide — that the file
    // supplies it, and that the launching shell outranks the file, is not.
    writeFileSync(join(home, '.env'), 'HTTP_PROXY=http://from-home:8080\nno_proxy=example.com\nHTTPS_PROXY=http://from-home:8443\n')
    clear(); clearProxy()
    vi.stubEnv('DSH_HOME', home)
    vi.stubEnv('HTTPS_PROXY', 'http://exported:8080')
    try {
      const snapshot = loadLayeredEnv(NAME, project, vi.fn())
      expect(snapshot.get('HTTP_PROXY')).toEqual({ value: 'http://from-home:8080', source: 'user-env', path: join(home, '.env') })
      expect(snapshot.get('no_proxy')).toEqual({ value: 'example.com', source: 'user-env', path: join(home, '.env') })
      // The launching shell still outranks the file for the same variable.
      expect(snapshot.get('HTTPS_PROXY')).toEqual({ value: 'http://exported:8080', source: 'process' })
      expect(process.env.HTTP_PROXY).toBe('http://from-home:8080')
      expect(process.env.HTTPS_PROXY).toBe('http://exported:8080')
    } finally {
      clear(); clearProxy()
      vi.unstubAllEnvs()
    }
  })

  it('still refuses every other bootstrap name in the Harness-home .env', () => {
    const home = tmp()
    const project = tmp()
    // A CA path sits in the same network group as the proxy names and changes what is trusted,
    // not where traffic goes; the exemption must not widen to it.
    writeFileSync(join(home, '.env'), 'SSL_CERT_FILE=/tmp/ca.pem\n')
    clear()
    vi.stubEnv('DSH_HOME', home)
    try {
      expect(() => loadLayeredEnv(NAME, project, vi.fn())).toThrow(/only the launching environment may set/)
    } finally {
      clear()
      vi.unstubAllEnvs()
    }
  })

  it('names the Harness-home file as the way out when a project .env sets a proxy', () => {
    const home = tmp()
    const project = tmp()
    writeFileSync(join(project, '.env'), 'HTTP_PROXY=http://attacker.example\n')
    clear(); clearProxy()
    vi.stubEnv('DSH_HOME', home)
    try {
      expect(() => loadLayeredEnv(NAME, project, vi.fn()))
        .toThrow(`export HTTP_PROXY, or put it in ${join(home, '.env')}, which does not travel with a repository`)
      expect(process.env.HTTP_PROXY).toBeUndefined()
    } finally {
      clear(); clearProxy()
      vi.unstubAllEnvs()
    }
  })

  it('treats the invoking directory as the Harness home when they are the same directory', () => {
    const home = tmp()
    writeFileSync(join(home, '.env'), 'HTTP_PROXY=http://from-home:8080\n')
    clear(); clearProxy()
    vi.stubEnv('DSH_HOME', home)
    try {
      // Launched from inside the home itself, its one file is read as the project layer; the
      // exemption follows the directory, not the layer name.
      expect(loadLayeredEnv(NAME, home, vi.fn()).get('HTTP_PROXY')?.value).toBe('http://from-home:8080')
    } finally {
      clear(); clearProxy()
      vi.unstubAllEnvs()
    }
  })

  it('reports each file value with its absolute path', () => {
    const home = tmp()
    const project = tmp()
    writeFileSync(join(home, '.env'), `${NAMES[1]}=u\n`)
    writeFileSync(join(project, '.env'), `${NAMES[2]}=p\n`)
    clear()
    vi.stubEnv('DSH_HOME', home)
    try {
      const snapshot = loadLayeredEnv(NAME, project, vi.fn())
      expect(snapshot.get(NAMES[1])).toEqual({ value: 'u', source: 'user-env', path: join(home, '.env') })
      expect(snapshot.get(NAMES[2])).toEqual({ value: 'p', source: 'project-env', path: join(project, '.env') })
      expect(snapshot.getFrom(NAMES[2], ['process', 'user-env'])).toBeUndefined()
    } finally {
      clear()
      vi.unstubAllEnvs()
    }
  })

  it('resolves the harness home from the inherited environment, never from a file', () => {
    const home = tmp()
    const project = tmp()
    writeFileSync(join(home, '.env'), `${NAMES[1]}=real-home\n`)
    writeFileSync(join(project, '.env'), `${NAMES[2]}=set-by-project\n`)
    clear()
    vi.stubEnv('DSH_HOME', home)
    try {
      loadLayeredEnv(NAME, project, vi.fn())
      expect(process.env[NAMES[1]]).toBe('real-home')
      expect(process.env[NAMES[2]]).toBe('set-by-project')
    } finally {
      clear()
      vi.unstubAllEnvs()
    }
  })

  it('warns and continues when a layer exists but cannot be read', () => {
    const home = tmp()
    const project = tmp()
    // A directory named `.env` is a present-but-unreadable layer.
    mkdirSync(join(home, '.env'))
    writeFileSync(join(project, '.env'), `${NAMES[2]}=project-only\n`)
    clear()
    vi.stubEnv('DSH_HOME', home)
    const warn = vi.fn()
    try {
      const snapshot = loadLayeredEnv(NAME, project, warn)
      expect(warn).toHaveBeenCalledWith(expect.stringContaining(`${NAME}: failed to load .env`))
      expect(snapshot.get(NAMES[1])).toBeUndefined()
      expect(snapshot.get(NAMES[2])).toEqual({ value: 'project-only', source: 'project-env', path: join(project, '.env') })
      expect(process.env[NAMES[2]]).toBe('project-only')
    } finally {
      clear()
      vi.unstubAllEnvs()
    }
  })

  it('reports to stderr when the caller supplies no reporter', () => {
    const home = tmp()
    const project = tmp()
    mkdirSync(join(home, '.env'))
    writeFileSync(join(project, '.env'), `${NAMES[2]}=project-only\n`)
    clear()
    vi.stubEnv('DSH_HOME', home)
    const write = vi.spyOn(process.stderr, 'write').mockReturnValue(true)
    try {
      const snapshot = loadLayeredEnv(NAME, project)
      expect(write).toHaveBeenCalledWith(expect.stringContaining(`${NAME}: failed to load .env`))
      expect(snapshot.get(NAMES[2])).toEqual({ value: 'project-only', source: 'project-env', path: join(project, '.env') })
      expect(process.env[NAMES[2]]).toBe('project-only')
    } finally {
      write.mockRestore()
      clear()
      vi.unstubAllEnvs()
    }
  })

  it('passes over an absent layer without reporting it', () => {
    const home = tmp()
    const project = tmp()
    writeFileSync(join(project, '.env'), `${NAMES[2]}=project-only\n`)
    clear()
    vi.stubEnv('DSH_HOME', home)
    const warn = vi.fn()
    try {
      const snapshot = loadLayeredEnv(NAME, project, warn)
      expect(warn).not.toHaveBeenCalled()
      expect(snapshot.get(NAMES[2])).toEqual({ value: 'project-only', source: 'project-env', path: join(project, '.env') })
    } finally {
      clear()
      vi.unstubAllEnvs()
    }
  })

  it('carries only the inherited environment when neither file exists', () => {
    const home = tmp()
    const project = tmp()
    clear()
    vi.stubEnv('DSH_HOME', home)
    vi.stubEnv('APP_BOOT_LAYERED_INHERITED', 'inherited')
    try {
      const snapshot = loadLayeredEnv(NAME, project, vi.fn())
      expect(snapshot.get('APP_BOOT_LAYERED_INHERITED')).toEqual({ value: 'inherited', source: 'process' })
    } finally {
      clear()
      vi.unstubAllEnvs()
    }
  })

  it('reads a harness home that is also the invocation directory exactly once', () => {
    const both = tmp()
    writeFileSync(join(both, '.env'), `${NAMES[2]}=one-file\n`)
    clear()
    vi.stubEnv('DSH_HOME', both)
    try {
      const snapshot = loadLayeredEnv(NAME, both, vi.fn())
      expect(snapshot.get(NAMES[2])).toEqual({ value: 'one-file', source: 'project-env', path: join(both, '.env') })
    } finally {
      clear()
      vi.unstubAllEnvs()
    }
  })
})

describe('installFailLoud', () => {
  function fakeProc(): FailLoudProcess & { handlers: Array<(err: unknown) => void>; written: string[]; exits: number[] } {
    const handlers: Array<(err: unknown) => void> = []
    const written: string[] = []
    const exits: number[] = []
    return {
      handlers, written, exits,
      on: (_event, handler) => { handlers.push(handler) },
      off: (_event, handler) => { handlers.splice(handlers.indexOf(handler), 1) },
      stderr: { write: (chunk: string) => { written.push(chunk) } },
      exit: (code: number) => { exits.push(code) },
    }
  }

  it('writes one labelled line with the stack and exits 1 on an Error rejection', () => {
    const proc = fakeProc()
    installFailLoud(NAME, proc)
    const error = new Error('boom')
    proc.handlers[0]!(error)
    expect(proc.written[0]).toContain(`${NAME}: fatal load failure: `)
    expect(proc.written[0]).toContain(error.stack)
    expect(proc.exits).toEqual([1])
  })

  // One rejection is reported per install: the first is the diagnosis, so each
  // formatting case needs its own handler rather than reusing a latched one.
  it('stringifies a non-Error rejection and an Error without a stack falls back to its message', () => {
    const plain = fakeProc()
    installFailLoud(NAME, plain)
    plain.handlers[0]!('plain failure')
    expect(plain.written[0]).toContain('plain failure')
    expect(plain.exits).toEqual([1])

    const stackless = new Error('no stack')
    delete (stackless as { stack?: string }).stack
    const bare = fakeProc()
    installFailLoud(NAME, bare)
    bare.handlers[0]!(stackless)
    expect(bare.written[0]).toContain('no stack')
    expect(bare.exits).toEqual([1])
  })

  it('returns an uninstaller that removes the handler (and defaults to the real process)', () => {
    const proc = fakeProc()
    const uninstall = installFailLoud(NAME, proc)
    expect(proc.handlers).toHaveLength(1)
    uninstall()
    expect(proc.handlers).toHaveLength(0)
    // Default-proc arm: install on the real process, then immediately uninstall
    // so the suite leaks no handler and can never exit the runner.
    const before = process.listenerCount('unhandledRejection')
    const uninstallReal = installFailLoud(NAME)
    expect(process.listenerCount('unhandledRejection')).toBe(before + 1)
    uninstallReal()
    expect(process.listenerCount('unhandledRejection')).toBe(before)
  })

  it('does not report an activation rejection shared by entries in the boot audit', async () => {
    const proc = fakeProc()
    installFailLoud(NAME, proc)
    const error = new Error('assembled activation failure')
    const warn = vi.fn()
    const audit = auditStartupEntries({
      loader: {
        entries: () => ['broken-a', 'broken-b'].map(name => ({
          options: { id: name, name },
          fiber: {
            state: 3,
            inject: {},
            ctx: { get: () => undefined },
            await: async () => { throw error },
          },
        })),
      },
    } as unknown as Context, NAME, warn)
    await Promise.resolve()
    await Promise.resolve()
    proc.handlers[0]!(error)
    expect(proc.written).toEqual([])
    expect(proc.exits).toEqual([])
    await audit
    expect(warn).toHaveBeenCalledWith(expect.stringContaining('assembled activation failure'))
    proc.handlers[0]!(error)
    expect(proc.exits).toEqual([1])
  })

  // The Loader mounts entries concurrently, so a terminal-owning surface can
  // already hold raw mode when a sibling entry rejects. Exiting without running
  // its teardown strands the terminal on the user's shell.
  it('awaits the release hook before exiting so the terminal owner can restore it', async () => {
    const proc = fakeProc()
    const order: string[] = []
    installFailLoud(NAME, proc, async () => {
      await Promise.resolve()
      order.push('released')
    })
    proc.handlers[0]!(new Error('sibling entry rejected'))
    expect(proc.written[0]).toContain(`${NAME}: fatal load failure: `)
    // The release is in flight, so the exit has not committed yet.
    expect(proc.exits).toEqual([])
    await vi.waitFor(() => { expect(proc.exits).toEqual([1]) })
    expect(order).toEqual(['released'])
  })

  it('still exits when the release hook rejects', async () => {
    const proc = fakeProc()
    installFailLoud(NAME, proc, () => Promise.reject(new Error('terminal stop failed')))
    proc.handlers[0]!(new Error('boom'))
    await vi.waitFor(() => { expect(proc.exits).toEqual([1]) })
  })

  it('exits without waiting when a release hook never settles', async () => {
    vi.useFakeTimers()
    try {
      const proc = fakeProc()
      installFailLoud(NAME, proc, () => new Promise<void>(() => {}))
      proc.handlers[0]!(new Error('boom'))
      expect(proc.exits).toEqual([])
      await vi.advanceTimersByTimeAsync(FAIL_LOUD_RELEASE_TIMEOUT_MS)
      expect(proc.exits).toEqual([1])
    } finally {
      vi.useRealTimers()
    }
  })

  // Loader failures arrive in bursts, and teardown's own disposers may reject.
  // Only the first rejection is the diagnosis; the handler must stay installed
  // so a later one cannot become uncaught and kill the process mid-teardown.
  it('reports only the first rejection and keeps handling later ones during the release', async () => {
    const proc = fakeProc()
    let released = false
    installFailLoud(NAME, proc, async () => {
      await Promise.resolve()
      released = true
    })
    proc.handlers[0]!(new Error('first rejection'))
    proc.handlers[0]!(new Error('second rejection'))
    expect(proc.handlers).toHaveLength(1)
    expect(proc.written).toHaveLength(1)
    expect(proc.written[0]).toContain('first rejection')
    await vi.waitFor(() => { expect(proc.exits).toEqual([1]) })
    expect(released).toBe(true)
  })
})

describe('auditStartupEntries', () => {
  const requiredIds = [
    'agent-loop',
    'webserver',
    'modules',
    'connection',
    'headless-runner',
    'acp',
    'sdk-jsonrpc-server',
  ]

  interface FakeEntry {
    fiber?: {
      state: number
      inject: Record<string, unknown>
      ctx: { get(name: string): unknown }
      await(): Promise<unknown>
    }
    disabled?: boolean
    options: { id: string; name: string }
  }

  const ctxWith = (entries: FakeEntry[]): Context => ({
    loader: { entries: () => entries.values() },
  }) as unknown as Context

  const fiber = (
    state: number,
    error?: unknown,
    inject: Record<string, unknown> = {},
    services: string[] = [],
  ): NonNullable<FakeEntry['fiber']> => ({
    state,
    inject,
    ctx: { get: name => services.includes(name) ? {} : undefined },
    await: error === undefined ? async () => undefined : async () => { throw error },
  })

  it('ignores active, disabled, and absent required entries', async () => {
    const warn = vi.fn()
    await expect(auditStartupEntries(ctxWith([]), NAME, warn)).resolves.toBeUndefined()
    for (const disabled of [false, true]) {
      await expect(auditStartupEntries(ctxWith(requiredIds.map(id => ({
        fiber: disabled ? fiber(3, new Error('disabled failure')) : fiber(2),
        disabled,
        options: { id, name: './required.mjs' },
      }))), NAME, warn)).resolves.toBeUndefined()
    }
    expect(warn).not.toHaveBeenCalled()
  })

  it('warns once for optional import, apply, and dependency failures', async () => {
    const warn = vi.fn()
    const original = new Error('todo apply failure')
    await auditStartupEntries(ctxWith([
      { options: { id: 'missing-tool', name: './missing.mjs' } },
      { fiber: fiber(3, original), options: { id: 'tool-todo', name: '@deepseek-ai/dsh-tool-todo' } },
      {
        fiber: fiber(0, undefined, { ready: {}, missing: {} }, ['ready']),
        options: { id: 'waiting-tool', name: './waiting.mjs' },
      },
    ]), NAME, warn)
    expect(warn).toHaveBeenCalledOnce()
    expect(warn).toHaveBeenCalledWith([
      `${NAME}: warning: 3 entries did not activate`,
      'missing-tool (./missing.mjs): failed to import',
      `tool-todo (@deepseek-ai/dsh-tool-todo): ${original.stack!}`,
      'waiting-tool (./waiting.mjs): pending (waiting for service: missing)',
      '',
    ].join('\n'))
  })

  it.each([
    { id: 'tool-todo', required: false },
    { id: 'webserver', required: true },
  ])('reports a throwing disabled expression on $id (required: $required)', async ({ id, required }) => {
    const error = new Error('disabled evaluation failed')
    const warn = vi.fn()
    const result = auditStartupEntries(ctxWith([{
      options: { id, name: './plugin.mjs' },
      get disabled(): boolean { throw error },
    }]), NAME, warn)
    const detail = `${id} (./plugin.mjs): disabled expression failed: ${error.stack!}`
    if (required) {
      await expect(result).rejects.toThrow(`  ${id} (required)\n    Package: ./plugin.mjs\n    disabled expression failed: ${error.stack!.replaceAll('\n', '\n    ')}`)
      expect(warn).not.toHaveBeenCalled()
    } else {
      await expect(result).resolves.toBeUndefined()
      expect(warn).toHaveBeenCalledExactlyOnceWith(`${NAME}: warning: 1 entry did not activate\n${detail}\n`)
    }
  })

  it('preserves nested activation causes and aggregate member failures', async () => {
    const warn = vi.fn()
    const original = new Error('tool discovery failed')
    const aggregate = new AggregateError([original, 'transport closed'], 'connection failed', {
      cause: new Error('server rejected discovery'),
    })
    const wrapper = new Error('plugin activation failed', { cause: aggregate })
    await auditStartupEntries(ctxWith([
      { fiber: fiber(3, wrapper), options: { id: 'wrapped-plugin', name: './wrapped.mjs' } },
    ]), NAME, warn)
    expect(warn).toHaveBeenCalledWith([
      `${NAME}: warning: 1 entry did not activate`,
      `wrapped-plugin (./wrapped.mjs): ${wrapper.stack!}`,
      aggregate.stack!,
      (aggregate.cause as Error).stack!,
      original.stack!,
      'transport closed',
      '',
    ].join('\n'))
  })

  it('describes nested, stackless, non-error, pending, and unexpected failures', async () => {
    const warn = vi.fn()
    const circular = new Error('circular failure')
    ;(circular as { cause?: unknown }).cause = circular
    const stackless = new Error('stackless failure')
    delete (stackless as { stack?: string }).stack
    const deepestWithStack = new Error('deep failure with stack')
    const deepestWithoutStack = new Error('deep failure without stack')
    delete (deepestWithoutStack as { stack?: string }).stack
    const wrappedStack = new Error('wrapped stack', { cause: deepestWithStack })
    const wrappedStackless = new Error('wrapped stackless', { cause: deepestWithoutStack })
    const wrappedValue = new Error('wrapped value', { cause: 'plain cause' })

    await auditStartupEntries(ctxWith([
      { fiber: fiber(3, circular), options: { id: 'circular', name: './circular.mjs' } },
      { fiber: fiber(3, stackless), options: { id: 'stackless', name: './stackless.mjs' } },
      {
        fiber: fiber(3, wrappedStack),
        options: { id: 'deep-stack', name: './deep-stack.mjs' },
      },
      {
        fiber: fiber(3, wrappedStackless),
        options: { id: 'deep-stackless', name: './deep-stackless.mjs' },
      },
      {
        fiber: fiber(3, wrappedValue),
        options: { id: 'plain-cause', name: './plain-cause.mjs' },
      },
      { fiber: fiber(3, 42), options: { id: 'number-error', name: './number-error.mjs' } },
      {
        fiber: fiber(0, undefined, { first: {}, second: {} }),
        options: { id: 'multiple-dependencies', name: './multiple-dependencies.mjs' },
      },
      {
        fiber: fiber(0),
        options: { id: 'unknown-dependency', name: './unknown-dependency.mjs' },
      },
      { fiber: fiber(1), options: { id: 'unexpected-state', name: './unexpected-state.mjs' } },
    ]), NAME, warn)

    expect(warn).toHaveBeenCalledOnce()
    const diagnostic = String(warn.mock.calls[0]![0])
    expect(diagnostic).toContain(`${NAME}: warning: 9 entries did not activate`)
    expect(diagnostic).toContain(`circular (./circular.mjs): ${circular.stack!}`)
    expect(diagnostic).toContain('stackless (./stackless.mjs): stackless failure')
    expect(diagnostic).toContain(`deep-stack (./deep-stack.mjs): ${wrappedStack.stack!}\n${deepestWithStack.stack!}`)
    expect(diagnostic).toContain(`deep-stackless (./deep-stackless.mjs): ${wrappedStackless.stack!}\ndeep failure without stack`)
    expect(diagnostic).toContain(`plain-cause (./plain-cause.mjs): ${wrappedValue.stack!}\nplain cause`)
    expect(diagnostic).toContain('number-error (./number-error.mjs): 42')
    expect(diagnostic).toContain('multiple-dependencies (./multiple-dependencies.mjs): pending (waiting for services: first, second)')
    expect(diagnostic).toContain('unknown-dependency (./unknown-dependency.mjs): pending (waiting for services: unknown)')
    expect(diagnostic).toContain('unexpected-state (./unexpected-state.mjs): fiber state 1')
  })

  it.each(requiredIds)('combines required %s and optional failures without a separate warning', async (id) => {
    const warn = vi.fn()
    const requiredError = new Error('address already in use')
    const optionalError = new Error('todo unavailable')
    const error = await auditStartupEntries(ctxWith([
      { fiber: fiber(3, requiredError), options: { id, name: './required.mjs' } },
      { fiber: fiber(3, optionalError), options: { id: 'tool-todo', name: '@deepseek-ai/dsh-tool-todo' } },
    ]), NAME, warn).catch((error: unknown) => error)
    expect(error).toBeInstanceOf(StartupError)
    expect((error as Error).message).toContain(`${NAME}: startup failed: 1 required plugin did not activate`)
    expect((error as Error).message).toContain(`  ${id} (required)\n    Package: ./required.mjs`)
    expect((error as Error).message).toContain('  tool-todo\n    Package: @deepseek-ai/dsh-tool-todo')
    expect(((error as Error).cause as AggregateError).errors).toEqual([requiredError, optionalError])
    expect(warn).not.toHaveBeenCalled()
  })

  it('omits an error cause when required plugins are only waiting for services', async () => {
    const error = await auditStartupEntries(ctxWith([
      { fiber: fiber(0, undefined, { webRuntime: {} }), options: { id: 'connection', name: './connection.mjs' } },
    ]), NAME, vi.fn()).catch((error: unknown) => error)
    expect(error).toBeInstanceOf(StartupError)
    expect(Object.hasOwn(error as StartupError, 'cause')).toBe(false)
    expect(inspect(error)).not.toContain('AggregateError')
    expect((error as StartupError).message).toContain('Plugins waiting for services (1):')
  })

  it('keeps diagnostic metadata available without expanding it in ordinary error inspection', () => {
    const entries = [{
      id: 'connection', module: './connection.mjs', required: true, fiberState: 0,
      outcome: { kind: 'pending' as const, missing: ['webRuntime'] },
    }]
    const error = new StartupError('waiting for webRuntime', entries)
    const startup = { configurationPath: '/private/cordis.yml', messages: [
      { ts: 1, name: 'loader', type: 'warn', args: ['raw diagnostic argument'] },
    ] }
    error.startup = startup
    expect(error.entries).toBe(entries)
    expect(error.startup).toBe(startup)
    const output = inspect(error)
    expect(output).toContain('waiting for webRuntime')
    expect(output).not.toContain('connection.mjs')
    expect(output).not.toContain('/private/cordis.yml')
    expect(output).not.toContain('raw diagnostic argument')
    const full = inspect(error, { showHidden: true, depth: null })
    expect(full).toContain('connection.mjs')
    expect(full).toContain('/private/cordis.yml')
    expect(full).toContain('raw diagnostic argument')
  })

  it('retains nested and shared errors in a fatal diagnostic without duplicating them', async () => {
    const leaf = new Error('leaf failure')
    leaf.stack = 'Error: leaf failure\n    at plugin.mjs:1:2'
    const aggregate = new AggregateError([leaf, 'plain failure'], 'activation failed', { cause: leaf })
    aggregate.stack = 'AggregateError: activation failed\n    at plugin.mjs:3:4'
    const error = await auditStartupEntries(ctxWith([
      { fiber: fiber(3, aggregate), options: { id: 'webserver', name: './plugin.mjs' } },
    ]), NAME, vi.fn()).catch((error: unknown) => error)
    expect((error as Error).message).toContain('AggregateError: activation failed')
    expect((error as Error).message).toContain('    Error: leaf failure\n        at plugin.mjs:1:2')
    expect((error as Error).message.match(/leaf failure/gu)).toHaveLength(1)
    expect((error as Error).message).toContain('    plain failure')
    expect(((error as Error).cause as AggregateError).errors).toEqual([aggregate])
  })

  it('groups original failure stacks and pending services in one startup diagnostic', async () => {
    const original = new Error('listen EADDRINUSE: address already in use 127.0.0.1:3080')
    original.stack = `${original.name}: ${original.message}\n    at Server.listen (node:net:1:2)`
    const warn = vi.fn()
    const error = await auditStartupEntries(ctxWith([
      { fiber: fiber(0, undefined, { webServer: {} }), options: { id: 'web-runtime', name: './web.mjs' } },
      { fiber: fiber(3, original), options: { id: 'webserver', name: '@deepseek-ai/dsh-host-webserver' } },
      { fiber: fiber(0, undefined, { webRuntime: {} }), options: { id: 'connection', name: './connection.mjs' } },
      { fiber: fiber(0), options: { id: 'unknown', name: './unknown.mjs' } },
    ]), NAME, warn).catch((error: unknown) => error)
    expect(error).toBeInstanceOf(StartupError)
    expect((error as Error).message).toMatchInlineSnapshot(`
      "dsh-test-bin: startup failed: 2 required plugins did not activate

      Failed plugins (1):
        webserver (required)
          Package: @deepseek-ai/dsh-host-webserver
          Error: listen EADDRINUSE: address already in use 127.0.0.1:3080
              at Server.listen (node:net:1:2)

      Plugins waiting for services (3):
        Plugin                 Missing services
        connection (required)  webRuntime
        web-runtime            webServer
        unknown                unknown"
    `)
    expect(warn).not.toHaveBeenCalled()
  })

  it('rejects a required entry pending on an injected service', async () => {
    await expect(auditStartupEntries(ctxWith([{
      fiber: fiber(0, undefined, { headlessStartup: {} }),
      options: { id: 'headless-runner', name: '@deepseek-ai/dsh-headless' },
    }]), NAME, vi.fn())).rejects.toThrow(
      'headless-runner (required)  headlessStartup',
    )
  })
})

describe('loadOverlayPatches', () => {
  it('loads expressions and rejects missing, malformed, non-array, and non-mapping overlays', () => {
    const dir = tmp()
    const valid = join(dir, 'valid.yml')
    writeFileSync(valid, '- id: target\n  config:\n    value: !!js process.env.VALUE\n')
    expect(loadOverlayPatches(NAME, valid)).toEqual([{ id: 'target', config: { value: { __jsExpr: 'process.env.VALUE' } } }])
    expect(() => loadOverlayPatches(NAME, join(dir, 'missing.yml'))).toThrow(`${NAME}: failed to read overlay`)
    const malformed = join(dir, 'malformed.yml')
    writeFileSync(malformed, ': bad')
    expect(() => loadOverlayPatches(NAME, malformed)).toThrow(`${NAME}: failed to parse overlay`)
    const mapping = join(dir, 'mapping.yml')
    writeFileSync(mapping, 'id: target\n')
    expect(() => loadOverlayPatches(NAME, mapping)).toThrow('must be a top-level YAML array')
    const scalar = join(dir, 'scalar.yml')
    writeFileSync(scalar, '- scalar\n')
    expect(() => loadOverlayPatches(NAME, scalar)).toThrow('entry 1')
  })
})

describe('boot', () => {
  it('retains import errors and inactive-entry metadata after disposing the startup tree', async () => {
    const dir = tmp()
    const config = join(dir, 'cordis.yml')
    writeFileSync(config, '- id: webserver\n  name: ./missing.mjs\n')
    const failure = await boot(NAME, config).catch((error: unknown) => error)
    expect(failure).toBeInstanceOf(StartupError)
    const error = failure as StartupError
    expect(error.entries).toEqual([{
      id: 'webserver', module: './missing.mjs', required: true, fiberState: undefined,
      outcome: { kind: 'failed', error: 'failed to import' },
    }])
    expect(error.startup?.configurationPath).toBe(config)
    expect(error.startup?.messages.some(message => message.args.some(arg => arg instanceof Error && arg.message.includes('missing.mjs')))).toBe(true)
  })

  it('retains warnings and errors from asynchronous failed-startup cleanup', async () => {
    const dir = tmp()
    const marker = join(dir, 'cleanup.txt')
    writeFileSync(join(dir, 'cleanup.mjs'), `
      import { writeFileSync } from 'node:fs'
      export function apply(ctx) {
        ctx.effect(() => async () => {
          await Promise.resolve()
          writeFileSync(${JSON.stringify(marker)}, 'ran')
          ctx.logger.warn('plugin cleanup warning')
          throw new Error('plugin cleanup error')
        })
      }
    `)
    const config = join(dir, 'cordis.yml')
    writeFileSync(config, '- id: cleanup\n  name: ./cleanup.mjs\n- id: webserver\n  name: ./missing.mjs\n')
    let root!: Context
    const failure = await boot(NAME, config, undefined, (ctx) => {
      root = ctx
      ctx.effect(() => async () => {
        await Promise.resolve()
        ctx.logger.warn('root cleanup warning')
      })
    }).catch((error: unknown) => error)
    expect(failure).toBeInstanceOf(StartupError)
    expect(readFileSync(marker, 'utf8')).toBe('ran')
    const messages = (failure as StartupError).startup!.messages
    const args = messages.flatMap(message => message.args)
    expect(args).toContain('plugin cleanup warning')
    expect(args).toContain('root cleanup warning')
    expect(args.some(value => value instanceof Error && value.message.includes('plugin cleanup error'))).toBe(true)
    const count = messages.length
    root.logger.warn('after boot rejected')
    expect(messages).toHaveLength(count)
  })

  it('stops collecting startup diagnostics after a successful boot', async () => {
    const dir = tmp()
    const config = join(dir, 'cordis.yml')
    writeFileSync(config, '[]\n')
    let exporters = 0
    const messages: unknown[][] = []
    const ctx = await boot(NAME, config, undefined, (host) => {
      host.logger.exporter({ levels: { default: 2 }, export: ({ args }) => { messages.push(args) } })
      exporters = host.logger.exporters.size
      host.logger.info('startup information')
      host.logger.warn('startup warning')
    })
    try {
      expect(ctx.logger.exporters.size).toBe(exporters - 1)
      ctx.logger.warn('warning after startup')
      expect(messages).toEqual([['startup information'], ['startup warning'], ['warning after startup']])
    } finally {
      await ctx.fiber.dispose()
    }
  })

  it('boots a leaf config through the real Loader and settles the tree', async () => {
    const dir = tmp()
    writeFileSync(join(dir, 'noop.mjs'), 'export const name = "noop"\nexport function apply() {}\n')
    writeFileSync(join(dir, 'cordis.yml'), '- id: noop\n  name: ./noop.mjs\n')
    const ctx = await boot(NAME, join(dir, 'cordis.yml'))
    try {
      const entries = [...ctx.loader.entries()]
      expect(entries.some(entry => entry.options.name === './noop.mjs' && entry.fiber !== undefined)).toBe(true)
    } finally {
      await ctx.fiber.dispose()
    }
  })

  it('can resolve bare plugins from the harness when the config project shadows their package name', async () => {
    const dir = tmp()
    const harness = tmp()
    const absolutePlugin = join(dir, 'absolute.mjs')
    const shadow = join(dir, 'node_modules', '@deepseek-ai', 'dsh-system-prompt')
    const harnessPlugin = join(harness, 'node_modules', '@deepseek-ai', 'dsh-system-prompt')
    mkdirSync(shadow, { recursive: true })
    mkdirSync(harnessPlugin, { recursive: true })
    writeFileSync(join(shadow, 'package.json'), JSON.stringify({
      name: '@deepseek-ai/dsh-system-prompt',
      type: 'module',
      exports: './index.mjs',
    }))
    writeFileSync(join(shadow, 'index.mjs'), [
      'export function apply(ctx) {',
      '  ctx.provide("shadowPluginLoaded", true)',
      '}',
      '',
    ].join('\n'))
    writeFileSync(join(harnessPlugin, 'package.json'), JSON.stringify({
      name: '@deepseek-ai/dsh-system-prompt',
      type: 'module',
      exports: './index.mjs',
    }))
    writeFileSync(join(harnessPlugin, 'index.mjs'), [
      'export function apply(ctx) {',
      '  ctx.provide("harnessPluginLoaded", true)',
      '}',
      '',
    ].join('\n'))
    writeFileSync(join(dir, 'relative.mjs'), 'export function apply(ctx) { ctx.provide("relativePluginLoaded", true) }\n')
    writeFileSync(absolutePlugin, 'export function apply(ctx) { ctx.provide("absolutePluginLoaded", true) }\n')
    const entries = [
      '- id: prompt',
      "  name: '@deepseek-ai/dsh-system-prompt'",
      '- id: relative',
      "  name: './relative.mjs'",
    ]
    const configOwnedPath = join(dir, 'config-owned.cordis.yml')
    writeFileSync(configOwnedPath, [...entries, ''].join('\n'))
    const hostOwnedPath = join(dir, 'host-owned.cordis.yml')
    writeFileSync(hostOwnedPath, [
      ...entries,
      '- id: absolute',
      `  name: ${JSON.stringify(absolutePlugin)}`,
      '',
    ].join('\n'))
    const configOwned = await boot(NAME, configOwnedPath)
    try {
      expect(configOwned.get('shadowPluginLoaded')).toBe(true)
      expect(configOwned.get('systemPrompt')).toBeUndefined()
      expect(configOwned.get('relativePluginLoaded')).toBe(true)
    } finally {
      await configOwned.fiber.dispose()
    }
    const harnessBaseUrl = pathToFileURL(join(harness, 'entry.mjs')).href
    const ctx = await boot(NAME, hostOwnedPath, undefined, undefined, harnessBaseUrl)
    try {
      expect(ctx.get('harnessPluginLoaded')).toBe(true)
      expect(ctx.get('shadowPluginLoaded')).toBeUndefined()
      expect(ctx.get('relativePluginLoaded')).toBe(true)
      expect(ctx.get('absolutePluginLoaded')).toBe(true)
    } finally {
      await ctx.fiber.dispose()
    }
  })

  it('runs host preparation before the Loader tree mounts', async () => {
    const dir = tmp()
    writeFileSync(join(dir, 'noop.mjs'), 'export const name = "noop"\nexport function apply() {}\n')
    writeFileSync(join(dir, 'cordis.yml'), '- id: noop\n  name: ./noop.mjs\n')
    const prepared: Context[] = []
    const ctx = await boot(NAME, join(dir, 'cordis.yml'), undefined, (hostCtx) => {
      expect(hostCtx.loader).toBeDefined()
      expect([...hostCtx.loader.entries()]).toEqual([])
      prepared.push(hostCtx)
    })
    try {
      expect(prepared).toEqual([ctx])
    } finally {
      await ctx.fiber.dispose()
    }
  })

  it('exposes dshHomePath to Loader config expressions', async () => {
    const dir = tmp()
    const dshHome = join(dir, 'home')
    vi.stubEnv('DSH_HOME', dshHome)
    writeFileSync(join(dir, 'capture.mjs'), [
      'export const name = "capture"',
      'export function apply(ctx, config) {',
      '  ctx.provide("capturedPath", config.path)',
      '}',
      '',
    ].join('\n'))
    writeFileSync(join(dir, 'cordis.yml'), [
      '- id: capture',
      '  name: ./capture.mjs',
      '  config:',
      "    path: !!js dshHomePath('sessions')",
      '',
    ].join('\n'))
    let ctx: Context | undefined
    try {
      ctx = await boot(NAME, join(dir, 'cordis.yml'))
      expect(ctx.get('capturedPath')).toBe(join(dshHome, 'sessions'))
    } finally {
      await ctx?.fiber.dispose()
      vi.unstubAllEnvs()
    }
  })

  it('returns instead of asserting over a tree a surface disposed mid-startup', async () => {
    // A surface can dispose the root fiber while boot() is still awaiting the
    // Loader, before the last entry settles. The Loader service goes with the
    // tree, so reading it for the post-boot assertions would crash an app that
    // exited exactly as the user asked.
    const dir = tmp()
    writeFileSync(join(dir, 'exiting.mjs'), [
      'export const name = "exiting"',
      'export function apply(ctx) {',
      '  void ctx.root.fiber.dispose()',
      '}',
      '',
    ].join('\n'))
    writeFileSync(join(dir, 'delayed.mjs'), [
      'await new Promise(resolve => setTimeout(resolve, 10))',
      'export function apply() {}',
      '',
    ].join('\n'))
    writeFileSync(join(dir, 'cordis.yml'), [
      '- id: exiting',
      '  name: ./exiting.mjs',
      '- id: delayed',
      '  name: ./delayed.mjs',
      '',
    ].join('\n'))
    const ctx = await boot(NAME, join(dir, 'cordis.yml'))
    expect(ctx.get('loader')).toBeUndefined()
  })

  it('returns when disposal completes before root entry creation returns', async () => {
    const dir = tmp()
    writeFileSync(join(dir, 'cordis.yml'), '[]\n')
    const ctx = await boot(NAME, join(dir, 'cordis.yml'), [], (ctx) => {
      const create = ctx.loader.create.bind(ctx.loader)
      vi.spyOn(ctx.loader, 'create').mockImplementation(async (...args) => {
        const id = await create(...args)
        await ctx.fiber.dispose()
        return id
      })
    })
    expect(ctx.get('loader')).toBeUndefined()
  })

  it('keeps successful entries and warns about optional import, config, disabled, sync apply, async apply, and dependency failures', async () => {
    const dir = tmp()
    const configPath = join(dir, 'cordis.yml')
    const config = [
      '- id: good',
      '  name: ./good.mjs',
      '- id: import-failure',
      '  name: ./missing.mjs',
      '- id: invalid-config',
      '  name: ./noop.mjs',
      '  config:',
      '    value: !!js "JSON.parse(\'invalid\')"',
      '- id: disabled-failure',
      '  name: ./noop.mjs',
      '  disabled: !!js "JSON.parse(\'invalid\')"',
      '- id: sync-failure',
      '  name: ./sync-failure.mjs',
      '- id: async-failure',
      '  name: ./async-failure.mjs',
      '- id: waiting',
      '  name: ./waiting.mjs',
      '',
    ].join('\n')
    writeFileSync(join(dir, 'good.mjs'), 'export function apply(ctx) { ctx.provide("goodStarted", true) }\n')
    writeFileSync(join(dir, 'noop.mjs'), 'export function apply() {}\n')
    writeFileSync(join(dir, 'sync-failure.mjs'), 'export function apply() { throw new Error("sync apply failure") }\n')
    writeFileSync(join(dir, 'async-failure.mjs'), 'export async function apply() { throw new Error("async apply failure") }\n')
    writeFileSync(join(dir, 'waiting.mjs'), 'export const inject = ["neverProvided"]\nexport function apply() {}\n')
    writeFileSync(configPath, config)

    const write = vi.spyOn(process.stderr, 'write').mockImplementation(() => true)
    let ctx: Context | undefined
    try {
      ctx = await boot(NAME, configPath)
      expect(ctx.get('goodStarted')).toBe(true)
      const entries = [...ctx.loader.entries()]
      expect(entries.find(entry => entry.options.id === 'good')?.fiber?.state).toBe(2)
      expect(entries.find(entry => entry.options.id === 'import-failure')?.fiber).toBeUndefined()
      expect(entries.find(entry => entry.options.id === 'disabled-failure')?.fiber).toBeUndefined()
      for (const id of ['invalid-config', 'sync-failure', 'async-failure']) {
        expect(entries.find(entry => entry.options.id === id)?.fiber?.state).toBe(3)
      }
      expect(entries.find(entry => entry.options.id === 'waiting')?.fiber?.state).toBe(0)
      const warning = write.mock.calls.map(call => String(call[0])).join('')
      expect(warning).toContain(`${NAME}: warning: 6 entries did not activate`)
      expect(warning).toContain('import-failure (./missing.mjs): failed to import')
      expect(warning).toContain('disabled-failure (./noop.mjs): disabled expression failed: SyntaxError')
      expect(warning).toContain('SyntaxError: Unexpected token')
      expect(warning).toContain('sync apply failure')
      expect(warning).toContain('async apply failure')
      expect(warning).toContain('waiting for service: neverProvided')
      expect(readFileSync(configPath, 'utf8')).toBe(config)
    } finally {
      write.mockRestore()
      await ctx?.fiber.dispose()
    }
  })

  it.each([
    ['missing', undefined, 'config file not found'],
    ['malformed', 'invalid: [unclosed\n', 'unexpected end'],
    ['non-array', 'entries: []\n', 'top-level array'],
  ])('rejects a %s root configuration', async (_kind, content, message) => {
    const dir = tmp()
    const configPath = join(dir, 'cordis.yml')
    if (content !== undefined) writeFileSync(configPath, content)
    let ctx: Context | undefined
    try {
      await expect(boot(NAME, configPath).then((value) => { ctx = value })).rejects.toThrow(message)
    } finally {
      await ctx?.fiber.dispose()
    }
  })

  it.each([
    ['import', undefined, '', 'failed to import'],
    ['config schema', 'export const Config = { "~standard": { version: 1, vendor: "app-boot-test", validate() { return { issues: [{ message: "schema failure" }] } } } }\nexport function apply() {}\n', '', 'schema failure'],
    ['config expression', 'export function apply() {}\n', '  config: { value: !!js "JSON.parse(\'invalid\')" }\n', 'SyntaxError'],
    ['disabled expression', 'export function apply() {}\n', '  disabled: !!js "JSON.parse(\'invalid\')"\n', 'disabled expression failed: SyntaxError'],
    ['sync apply', 'export function apply() { throw new Error("sync failure") }\n', '', 'sync failure'],
    ['async apply', 'export async function apply() { await Promise.resolve(); throw new Error("async failure") }\n', '', 'async failure'],
    ['missing dependency', 'export const inject = ["missingRequiredService"]\nexport function apply() {}\n', '', 'missingRequiredService'],
  ])('disposes startup after a required %s failure', async (_kind, source, config, message) => {
    const dir = tmp()
    if (source !== undefined) writeFileSync(join(dir, 'required.mjs'), source)
    writeFileSync(join(dir, 'cordis.yml'), `- id: webserver\n  name: ./required.mjs\n${config}`)
    let disposed = false
    await expect(boot(NAME, join(dir, 'cordis.yml'), undefined, (ctx) => {
      ctx.effect(() => () => { disposed = true })
    })).rejects.toThrow(message)
    expect(disposed).toBe(true)
  })

  it('disposes successful entries and rejects when a required entry fails', async () => {
    const dir = tmp()
    let disposed = false
    writeFileSync(join(dir, 'good.mjs'), [
      'export function apply(ctx) {',
      '  globalThis.__DSH_REQUIRED_TEST_DISPOSED__ = false',
      '  ctx.effect(() => () => { globalThis.__DSH_REQUIRED_TEST_DISPOSED__ = true })',
      '}',
      '',
    ].join('\n'))
    writeFileSync(join(dir, 'required-failure.mjs'), 'export function apply() { throw new Error("required apply failure") }\n')
    writeFileSync(join(dir, 'cordis.yml'), [
      '- id: good',
      '  name: ./good.mjs',
      '- id: webserver',
      '  name: ./required-failure.mjs',
      '',
    ].join('\n'))

    await expect(boot(NAME, join(dir, 'cordis.yml'))).rejects.toThrow(new RegExp([
      'startup failed: 1 required plugin did not activate',
      String.raw`webserver \(required\)`,
      'required apply failure',
    ].join(String.raw`[\s\S]*`)))
    disposed = (globalThis as { __DSH_REQUIRED_TEST_DISPOSED__?: boolean }).__DSH_REQUIRED_TEST_DISPOSED__ ?? false
    delete (globalThis as { __DSH_REQUIRED_TEST_DISPOSED__?: boolean }).__DSH_REQUIRED_TEST_DISPOSED__
    expect(disposed).toBe(true)
  })

  it('falls back to the deepest cause message when its stack was erased', async () => {
    const dir = tmp()
    const deepest = new Error('stackless deep failure')
    delete (deepest as { stack?: string }).stack
    await expect(boot(NAME, join(dir, 'cordis.yml'), undefined, () => {
      throw new Error('wrapped setup failure', { cause: deepest })
    })).rejects.toThrow(
      `${NAME}: host preparation failed: wrapped setup failure\nstackless deep failure`,
    )
  })

  it('reports a non-Error rejection from host preparation', async () => {
    await expect(boot(NAME, join(tmp(), 'cordis.yml'), [], () => {
      throw 'host refused'
    })).rejects.toThrow(`${NAME}: host preparation failed: host refused`)
  })

  it.each([false, true])('rejects and disposes when an error cause is cyclic (indirect: %s)', async (indirect) => {
    const failure = new Error('cyclic setup failure')
    const next = indirect ? new Error('nested failure', { cause: failure }) : failure
    let reads = 0
    Object.defineProperty(failure, 'cause', {
      get() {
        // Bound a regressed synchronous traversal so it cannot hang the test worker.
        if (++reads > 10) throw new Error('cause traversal did not terminate')
        return next
      },
    })
    const dispose = vi.fn()
    await expect(boot(NAME, join(tmp(), 'cordis.yml'), [], (ctx) => {
      ctx.effect(() => dispose)
      throw failure
    })).rejects.toThrow(`${NAME}: host preparation failed: cyclic setup failure`)
    expect(dispose).toHaveBeenCalledOnce()
  })

  it('expands a stackless aggregate at the deepest activation cause', async () => {
    const dir = tmp()
    const aggregate = new AggregateError([
      new Error('first aggregate member'),
      'second aggregate member',
    ], 'aggregate activation failure')
    delete (aggregate as { stack?: string }).stack
    try {
      await boot(NAME, join(dir, 'cordis.yml'), undefined, () => {
        throw new Error('wrapped aggregate failure', { cause: aggregate })
      })
      expect.fail('boot should reject the aggregate activation failure')
    } catch (error) {
      expect(error).toBeInstanceOf(Error)
      const message = (error as Error).message
      expect(message).toContain(`${NAME}: host preparation failed: wrapped aggregate failure`)
      expect(message).toContain('aggregate activation failure')
      expect(message).toContain('first aggregate member')
      expect(message).toContain('second aggregate member')
    }
  })

})

describe('addHarnessSourceSection', () => {
  const SOURCE_ROOT = `${sep}opt${sep}harness-src`
  const EXPECTED = `The DeepSeek Harness implementation checkout is at ${SOURCE_ROOT}. The checkout location and current working directory are separate values and may differ; never infer the working directory from this path. Use pwd to determine the current working directory. Use this checkout only to inspect or extend DSH itself.`

  it('distinguishes the source path from the current workdir after reusable instructions', async () => {
    const ctx = new Context()
    try {
      await ctx.plugin(SystemPrompt, { personaPrefix: 'You are a coding agent.' })
      ctx.systemPrompt.section({
        name: 'tools:sdk', order: ctx.systemPrompt.getSectionOrder('TOOLS_SDK'), text: 'Reusable tool SDK.',
      })
      const dispose = addHarnessSourceSection(ctx, SOURCE_ROOT)
      expect(dispose).toBeTypeOf('function')
      const systemPrompt = ctx.get('systemPrompt')!
      const rendered = renderPrompt(await systemPrompt.assemble())
      expect(rendered).toContain(EXPECTED)
      // The >= 0 guards keep a drifted opener/persona string from a false pass
      // through `-1 < n`.
      const identityAt = rendered.indexOf('You are an AI agent powered by DeepSeek Harness.')
      const sourceAt = rendered.indexOf(EXPECTED)
      const personaAt = rendered.indexOf('You are a coding agent.')
      expect(identityAt).toBeGreaterThanOrEqual(0)
      expect(personaAt).toBeGreaterThanOrEqual(0)
      const sdkAt = rendered.indexOf('Reusable tool SDK.')
      expect(personaAt).toBeGreaterThan(identityAt)
      expect(sdkAt).toBeGreaterThan(personaAt)
      expect(sdkAt).toBeLessThan(sourceAt)
    } finally {
      await ctx.fiber.dispose()
    }
  })

  it('is a no-op returning undefined when no systemPrompt service is mounted', async () => {
    const ctx = new Context()
    try {
      expect(addHarnessSourceSection(ctx, SOURCE_ROOT)).toBeUndefined()
    } finally {
      await ctx.fiber.dispose()
    }
  })

  it('disposes the section it added, so a systemPrompt reload leaves no residue', async () => {
    const ctx = new Context()
    try {
      await ctx.plugin(SystemPrompt, {})
      const systemPrompt = ctx.get('systemPrompt')!
      const dispose = addHarnessSourceSection(ctx, SOURCE_ROOT)!
      const present = await systemPrompt.assemble()
      expect(present.sections.some(section => section.name === HARNESS_SOURCE_SECTION)).toBe(true)
      dispose()
      const gone = await systemPrompt.assemble()
      expect(gone.sections.some(section => section.name === HARNESS_SOURCE_SECTION)).toBe(false)
    } finally {
      await ctx.fiber.dispose()
    }
  })
})