| 123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670671672673674675676677678679680681682683684685686687688689690691692693694695696697698699700701702703704705706707708709710711712713714715716717718719720721722723724725726727728729730731732733734735736737738739740741742743744745746747748749750751752753 |
- import { createUserMessage } from '@deepseek-ai/dsh-llm'
- import { afterEach, describe, expect, it, vi } from 'vitest'
- import { mkdtempSync, rmSync, writeFileSync, chmodSync, existsSync, readFileSync } from 'node:fs'
- import { tmpdir } from 'node:os'
- import { join } from 'node:path'
- import { Context } from '@deepseek-ai/cordis'
- import { SessionId, type SessionEvent } from '@deepseek-ai/dsh-session'
- import JsonlSessionPersistence from '@deepseek-ai/dsh-session-persistence-jsonl'
- import { defineContentToolFixture } from '@deepseek-ai/dsh-tools'
- import type { Agent } from '@deepseek-ai/dsh-agent'
- import AgentLoop from '@deepseek-ai/dsh-agent-loop'
- import { mountAgentLoopTestDependencies } from '@deepseek-ai/dsh-agent-loop-testkit'
- import { LocalBashExecutor } from '@deepseek-ai/dsh-bash-local'
- import LocalSubprocessRuntime from '@deepseek-ai/dsh-subprocess-local'
- import { scopeTarget } from '@deepseek-ai/dsh-scope'
- import SubagentRuntime, { SubagentRunId } from '@deepseek-ai/dsh-subagent'
- import * as HooksClaude from '@deepseek-ai/dsh-hooks-claude-code'
- import { MockAdapter, textResponse, toolCallResponse } from '../../../core/agent-loop/tests/mock-adapter.ts'
- const testToolSignal = new AbortController().signal
- /** Targeted branch coverage for the CC bridge: option arms, warn paths, no-agent
- * fallbacks, contextFrom-empty, and the detached-listener catch handlers. */
- const dirs: string[] = []
- afterEach(() => { for (const d of dirs.splice(0)) rmSync(d, { recursive: true, force: true }) })
- function subagentCarrier(ctx: Context) {
- return scopeTarget(ctx as unknown as SubagentRuntime, undefined)
- }
- function dir(): string { const d = mkdtempSync(join(tmpdir(), 'dsh-hc-cov-')); dirs.push(d); return d }
- function sh(d: string, name: string, body: string): string {
- const p = join(d, name); writeFileSync(p, body); chmodSync(p, 0o755); return p
- }
- function hooks(d: string, h: unknown): string {
- writeFileSync(join(d, 'hooks.json'), JSON.stringify({ hooks: h })); return join(d, 'hooks.json')
- }
- type HarnessOpts = { pluginRoot?: string; projectDir?: string; stderrSummaryMaxChars?: number; sessionRoot?: string }
- async function harness(configPath: string, adapter: MockAdapter, opts: HarnessOpts = {}): Promise<Context> {
- const ctx = new Context()
- await mountAgentLoopTestDependencies(ctx)
- if (opts.sessionRoot !== undefined) await ctx.plugin(JsonlSessionPersistence, { root: opts.sessionRoot })
- await ctx.plugin(AgentLoop, { agents: [] })
- await ctx.plugin(LocalSubprocessRuntime)
- await ctx.plugin(LocalBashExecutor, { timeoutMs: 10_000 })
- await ctx.plugin(HooksClaude, { configPath, ...opts })
- ctx.llm.registerAdapter(['mock'], adapter)
- return ctx
- }
- function waitForIdle(_ctx: Context, agent: Agent): Promise<void> {
- return agent.whenIdle()
- }
- function events(agent: Agent): readonly SessionEvent[] { return agent.session.snapshotEvents() }
- /** Poll until `predicate` holds or the deadline passes — robust to detached
- * emit-listener hooks firing on a `.then` (a fixed sleep flakes under load). */
- async function waitFor(predicate: () => boolean, timeout = 5000, interval = 10): Promise<void> {
- const deadline = Date.now() + timeout
- while (!predicate()) {
- if (Date.now() > deadline) throw new Error('waitFor: condition not met before deadline')
- await new Promise(r => setTimeout(r, interval))
- }
- }
- export type CoverageGroup = 'config' | 'stop' | 'context' | 'edge-paths'
- /** Register independently schedulable slices of the hooks-claude-code coverage matrix. */
- export function defineCoverageCases(group: CoverageGroup): void {
- if (group === 'config') describe('hooks-claude-code coverage — config option arms + substitution + skip warning', () => {
- it('degrades transcript_path to the empty string even with persistence mounted', async () => {
- const d = dir()
- const cap = join(d, 'payload')
- const path = hooks(d, { PreToolUse: [{ hooks: [{ type: 'command', command: sh(d, 'capture.sh', `#!/usr/bin/env bash\ncat > "${cap}"\n`) }] }] })
- const adapter = new MockAdapter([toolCallResponse('c1', 'echo', {}), textResponse('done')])
- const ctx = await harness(path, adapter, { sessionRoot: dir() })
- ctx.tools.register(defineContentToolFixture({ name: 'echo', description: 'e', parameters: {}, async execute() { return [{ type: 'text', text: 'ok' }] } }))
- const agent = await ctx.agentLoop.create(SessionId('transcript'), { provider: 'mock', model: 'mock' })
- agent.followup(createUserMessage({ content: [{ type: 'text', text: 'go' }], source: { kind: 'user' } }))
- await waitForIdle(ctx, agent)
- // The persistence seam exposes no artifact paths, so the field stays ''
- // even with a persistence backend mounted.
- expect((JSON.parse(readFileSync(cap, 'utf8')) as { transcript_path: string }).transcript_path).toBe('')
- }, 15_000) // The real agent/hook subprocess loop needs process startup and teardown headroom.
- it('honors pluginRoot + projectDir substitution and warns on a skipped non-command hook', async () => {
- const d = dir()
- // ${CLAUDE_PLUGIN_ROOT} resolves to d; the script writes its own cwd-independent marker.
- const marker = join(d, 'ran')
- sh(d, 'h.sh', `#!/usr/bin/env bash\ntouch "${marker}"\n`)
- const path = hooks(d, {
- PreToolUse: [{ hooks: [
- { type: 'prompt', prompt: 'skipme' }, // skipped → warn loop
- { type: 'command', command: '${CLAUDE_PLUGIN_ROOT}/h.sh' }, // substituted
- ] }],
- })
- const warn = vi.fn()
- const adapter = new MockAdapter([toolCallResponse('c1', 'echo', {}), textResponse('done')])
- const ctx = await harness(path, adapter, { pluginRoot: d, projectDir: d })
- ctx.logger.warn = warn as never
- ctx.tools.register(defineContentToolFixture({ name: 'echo', description: 'e', parameters: {}, async execute() { return [{ type: 'text', text: 'ok' }] } }))
- const agent = await ctx.agentLoop.create(SessionId('a1'), { provider: 'mock', model: 'mock' })
- agent.followup(createUserMessage({ content: [{ type: 'text', text: 'go' }], source: { kind: 'user' } }))
- await waitForIdle(ctx, agent)
- expect(existsSync(marker)).toBe(true) // substituted command ran
- }, 15_000) // Real agent and hook subprocess startup can exceed Vitest's default under coverage concurrency.
- it('warns and honors updatedInput as a no-op (input rewrite deferred)', async () => {
- const d = dir()
- const s = sh(d, 'u.sh', '#!/usr/bin/env bash\necho \'{"hookSpecificOutput":{"hookEventName":"PreToolUse","permissionDecision":"allow","updatedInput":{"command":"rewritten"}}}\'\n')
- const path = hooks(d, { PreToolUse: [{ hooks: [{ type: 'command', command: s }] }] })
- const warn = vi.fn()
- const adapter = new MockAdapter([toolCallResponse('c1', 'echo', { command: 'original' }), textResponse('done')])
- const ctx = await harness(path, adapter)
- ctx.logger.warn = warn as never
- let sawArgs: unknown
- ctx.tools.register(defineContentToolFixture({ name: 'echo', description: 'e', parameters: { command: { type: 'string' } }, async execute(args) { sawArgs = args; return [{ type: 'text', text: 'ok' }] } }))
- const agent = await ctx.agentLoop.create(SessionId('a1'), { provider: 'mock', model: 'mock' })
- agent.followup(createUserMessage({ content: [{ type: 'text', text: 'go' }], source: { kind: 'user' } }))
- await waitForIdle(ctx, agent)
- // updatedInput is NOT honored — the tool ran with the ORIGINAL args.
- expect((sawArgs as { command?: string }).command).toBe('original')
- expect(warn).toHaveBeenCalledWith(expect.stringContaining('updatedInput'))
- })
- })
- if (group === 'config') describe('hooks-claude-code coverage — empty/no-op outcomes and no-agent paths', () => {
- it('a clean exit-0 hook with no output is a no-op (contextFrom empty → next())', async () => {
- const d = dir()
- const s = sh(d, 'noop.sh', '#!/usr/bin/env bash\nexit 0\n')
- const path = hooks(d, { UserPromptSubmit: [{ hooks: [{ type: 'command', command: s }] }] })
- const adapter = new MockAdapter([textResponse('ran')])
- const ctx = await harness(path, adapter)
- const agent = await ctx.agentLoop.create(SessionId('a1'), { provider: 'mock', model: 'mock' })
- agent.followup(createUserMessage({ content: [{ type: 'text', text: 'go' }], source: { kind: 'user' } }))
- await waitForIdle(ctx, agent)
- // The prompt proceeded unchanged; no injected context.
- expect(adapter.requests).toHaveLength(1)
- expect(events(agent).some(e => e.type === 'user/message' && e.data.source.kind !== 'user')).toBe(false)
- })
- it('a PreToolUse hook fires for a no-agent direct tool call (no session/turn to record into)', async () => {
- const d = dir()
- const s = sh(d, 'deny.sh', '#!/usr/bin/env bash\necho "no" >&2\nexit 2\n')
- const path = hooks(d, { PreToolUse: [{ hooks: [{ type: 'command', command: s }] }] })
- const ctx = await harness(path, new MockAdapter([]))
- let ran = false
- ctx.tools.register(defineContentToolFixture({ name: 'echo', description: 'e', parameters: {}, async execute() { ran = true; return [{ type: 'text', text: 'x' }] } }))
- const { ToolCallId } = await import('@deepseek-ai/dsh-llm')
- const result = await ctx.tools.execute({ signal: testToolSignal, callId: ToolCallId('c1'), name: 'echo', arguments: {} })
- expect(ran).toBe(false)
- expect(result.isError).toBe(true)
- })
- it('a long stderr is truncated in the hook/result summary', async () => {
- const d = dir()
- const s = sh(d, 'long.sh', '#!/usr/bin/env bash\nprintf "x%.0s" {1..600} >&2\nexit 2\n')
- const path = hooks(d, { PreToolUse: [{ hooks: [{ type: 'command', command: s }] }] })
- const adapter = new MockAdapter([toolCallResponse('c1', 'echo', {}), textResponse('done')])
- const ctx = await harness(path, adapter)
- ctx.tools.register(defineContentToolFixture({ name: 'echo', description: 'e', parameters: {}, async execute() { return [{ type: 'text', text: 'ok' }] } }))
- const agent = await ctx.agentLoop.create(SessionId('a1'), { provider: 'mock', model: 'mock' })
- agent.followup(createUserMessage({ content: [{ type: 'text', text: 'go' }], source: { kind: 'user' } }))
- await waitForIdle(ctx, agent)
- const res = events(agent).find(e => e.type === 'hook/result')
- expect(res?.type === 'hook/result' && res.data.stderrSummary?.endsWith('…')).toBe(true)
- expect(res?.type === 'hook/result' && res.data.stderrSummary?.length).toBe(501) // default 500-char cap + ellipsis
- })
- it('rejects a non-positive or fractional stderrSummaryMaxChars at load', async () => {
- const d = dir()
- const path = hooks(d, {})
- for (const bad of [0, -5, 1.5, Number.NaN]) {
- const adapter = new MockAdapter([])
- await expect(harness(path, adapter, { stderrSummaryMaxChars: bad }))
- .rejects.toThrow(/hooks-claude-code: stderrSummaryMaxChars must be a positive integer/)
- }
- })
- it('the stderr summary cap is plugin config (stderrSummaryMaxChars)', async () => {
- const d = dir()
- const s = sh(d, 'long.sh', '#!/usr/bin/env bash\nprintf "x%.0s" {1..600} >&2\nexit 2\n')
- const path = hooks(d, { PreToolUse: [{ hooks: [{ type: 'command', command: s }] }] })
- const adapter = new MockAdapter([toolCallResponse('c1', 'echo', {}), textResponse('done')])
- const ctx = await harness(path, adapter, { stderrSummaryMaxChars: 40 })
- ctx.tools.register(defineContentToolFixture({ name: 'echo', description: 'e', parameters: {}, async execute() { return [{ type: 'text', text: 'ok' }] } }))
- const agent = await ctx.agentLoop.create(SessionId('a1'), { provider: 'mock', model: 'mock' })
- agent.followup(createUserMessage({ content: [{ type: 'text', text: 'go' }], source: { kind: 'user' } }))
- await waitForIdle(ctx, agent)
- const res = events(agent).find(e => e.type === 'hook/result')
- expect(res?.type === 'hook/result' && res.data.stderrSummary).toBe('x'.repeat(40) + '…')
- })
- })
- if (group === 'stop') describe('hooks-claude-code coverage — Stop continuation + subagent inject/catch', () => {
- it('a Stop hook that blocks (exit 2) forces the turn to continue (CC dialect)', async () => {
- const d = dir()
- const marker = join(d, 'fired')
- const s = sh(d, 'stop.sh', `#!/usr/bin/env bash\nif [ -e "${marker}" ]; then exit 0; fi\ntouch "${marker}"\necho "continue please" >&2\nexit 2\n`)
- const path = hooks(d, { Stop: [{ hooks: [{ type: 'command', command: s }] }] })
- const adapter = new MockAdapter([textResponse('one'), textResponse('two')])
- const ctx = await harness(path, adapter)
- const agent = await ctx.agentLoop.create(SessionId('a1'), { provider: 'mock', model: 'mock' })
- agent.followup(createUserMessage({ content: [{ type: 'text', text: 'go' }], source: { kind: 'user' } }))
- await waitForIdle(ctx, agent)
- expect(adapter.requests).toHaveLength(2)
- expect(JSON.stringify(adapter.requests[1]!.messages)).toContain('continue please')
- })
- it('a Stop hook that blocks with EMPTY stderr still forces continuation (no reason required)', async () => {
- // A blocking Stop hook with no stderr yields `deny` without a reason. The block still forces
- // continuation; the script self-limits to one block to avoid a loop.
- const d = dir()
- const marker = join(d, 'fired')
- const s = sh(d, 'stop.sh', `#!/usr/bin/env bash\nif [ -e "${marker}" ]; then exit 0; fi\ntouch "${marker}"\nexit 2\n`)
- const path = hooks(d, { Stop: [{ hooks: [{ type: 'command', command: s }] }] })
- const adapter = new MockAdapter([textResponse('one'), textResponse('two')])
- const ctx = await harness(path, adapter)
- const agent = await ctx.agentLoop.create(SessionId('a1'), { provider: 'mock', model: 'mock' })
- agent.followup(createUserMessage({ content: [{ type: 'text', text: 'go' }], source: { kind: 'user' } }))
- await waitForIdle(ctx, agent)
- // A second model request ran → the empty-reason block forced continuation.
- expect(adapter.requests).toHaveLength(2)
- // The steering carried the fallback reason (no stderr to use).
- expect(JSON.stringify(adapter.requests[1]!.messages)).toContain('blocked by Stop hook')
- })
- it('SubagentStart additionalContext is injected into a REGISTERED live child', async () => {
- const d = dir()
- const s = sh(d, 'sa.sh', '#!/usr/bin/env bash\necho \'{"hookSpecificOutput":{"hookEventName":"SubagentStart","additionalContext":"child guidance"}}\'\n')
- const path = hooks(d, { SubagentStart: [{ hooks: [{ type: 'command', command: s }] }] })
- const ctx = await harness(path, new MockAdapter([]))
- const injected: string[] = []
- const child = {
- id: SessionId('child-x'),
- inject: (input: { content: Array<{ type: string; text?: string }> }) => {
- injected.push(input.content.map(block => block.text ?? '').join(''))
- },
- session: { id: SessionId('child-x'), header: { id: 'child-x' } },
- } as unknown as Parameters<typeof ctx.agents.register>[0]
- ctx.agents.register(child)
- ctx.emit(subagentCarrier(ctx), 'subagent/start', { runId: SubagentRunId('run-x'), provider: 'p', id: SessionId('child-x'), local: true })
- await waitFor(() => injected.includes('child guidance'))
- expect(injected).toContain('child guidance')
- })
- it('a throwing SubagentStart/SubagentStop hook run is contained (logged)', async () => {
- const d = dir()
- // A hook command that does not exist makes runHook resolve a non-blocking
- // error (not a throw), so to hit the .catch we make the .then throw: register
- // a child whose inject throws for SubagentStart.
- const s = sh(d, 'sa.sh', '#!/usr/bin/env bash\necho \'{"hookSpecificOutput":{"hookEventName":"SubagentStart","additionalContext":"x"}}\'\n')
- const path = hooks(d, { SubagentStart: [{ hooks: [{ type: 'command', command: s }] }] })
- const ctx = await harness(path, new MockAdapter([]))
- const warn = vi.fn(); ctx.logger.warn = warn as never
- const child = { id: SessionId('child-y'), inject: () => { throw new Error('inject boom') }, session: { id: SessionId('child-y'), header: { id: 'child-y' } } } as unknown as Parameters<typeof ctx.agents.register>[0]
- ctx.agents.register(child)
- ctx.emit(subagentCarrier(ctx), 'subagent/start', { runId: SubagentRunId('run-y'), provider: 'p', id: SessionId('child-y'), local: true })
- await waitFor(() => warn.mock.calls.some(c => String(c[0]).includes('SubagentStart hook failed')))
- expect(warn).toHaveBeenCalledWith(expect.stringContaining('SubagentStart hook failed'))
- })
- })
- if (group === 'stop') describe('hooks-claude-code coverage — default reasons + sparse payloads', () => {
- it('PreToolUse deny with EMPTY stderr uses the default reason', async () => {
- const d = dir()
- const s = sh(d, 'deny.sh', '#!/usr/bin/env bash\nexit 2\n') // exit 2, no stderr
- const path = hooks(d, { PreToolUse: [{ hooks: [{ type: 'command', command: s }] }] })
- const adapter = new MockAdapter([toolCallResponse('c1', 'echo', {}), textResponse('done')])
- const ctx = await harness(path, adapter)
- ctx.tools.register(defineContentToolFixture({ name: 'echo', description: 'e', parameters: {}, async execute() { return [{ type: 'text', text: 'x' }] } }))
- const agent = await ctx.agentLoop.create(SessionId('a1'), { provider: 'mock', model: 'mock' })
- agent.followup(createUserMessage({ content: [{ type: 'text', text: 'go' }], source: { kind: 'user' } }))
- await waitForIdle(ctx, agent)
- const result = events(agent).find(e => e.type === 'tool/result')
- expect(result?.type === 'tool/result' && result.data.message.content[0].content.some(b => b.type === 'text' && b.text.includes('blocked by PreToolUse hook'))).toBe(true)
- })
- it('PostToolUse deny with EMPTY stderr + no context uses the default feedback', async () => {
- const d = dir()
- const s = sh(d, 'block.sh', '#!/usr/bin/env bash\nexit 2\n')
- const path = hooks(d, { PostToolUse: [{ hooks: [{ type: 'command', command: s }] }] })
- const adapter = new MockAdapter([toolCallResponse('c1', 'echo', {}), textResponse('done')])
- const ctx = await harness(path, adapter)
- ctx.tools.register(defineContentToolFixture({ name: 'echo', description: 'e', parameters: {}, async execute() { return [{ type: 'text', text: 'ok' }] } }))
- const agent = await ctx.agentLoop.create(SessionId('a1'), { provider: 'mock', model: 'mock' })
- agent.followup(createUserMessage({ content: [{ type: 'text', text: 'go' }], source: { kind: 'user' } }))
- await waitForIdle(ctx, agent)
- const result = events(agent).find(e => e.type === 'tool/result')
- expect(result?.type === 'tool/result' && result.data.message.content[0].content.some(b => b.type === 'text' && b.text.includes('blocked by PostToolUse hook'))).toBe(true)
- })
- it('SubagentStop with no registered child runs the hook cleanly (fire-and-forget)', async () => {
- const d = dir()
- // The agents registry has no entry for the id, so the child lookup yields
- // undefined and the payload falls back to base(undefined) — assert the
- // observe-only SubagentStop run still executes the hook without crashing.
- const marker = join(d, 'stopran')
- const s = sh(d, 'stop.sh', `#!/usr/bin/env bash\ntouch "${marker}"\n`)
- const path = hooks(d, { SubagentStop: [{ hooks: [{ type: 'command', command: s }] }] })
- const ctx = await harness(path, new MockAdapter([]))
- ctx.emit(subagentCarrier(ctx), 'subagent/end', { runId: SubagentRunId('run-z'), provider: 'p', id: SessionId('child-z'), local: false, stopReason: 'completed' })
- await waitFor(() => existsSync(marker))
- expect(existsSync(marker)).toBe(true)
- })
- })
- if (group === 'edge-paths') describe('hooks-claude-code coverage — more default/sparse arms', () => {
- it('UserPromptSubmit deny with EMPTY stderr uses the default block reason', async () => {
- const d = dir()
- const s = sh(d, 'block.sh', '#!/usr/bin/env bash\nexit 2\n')
- const path = hooks(d, { UserPromptSubmit: [{ hooks: [{ type: 'command', command: s }] }] })
- const adapter = new MockAdapter([textResponse('no')])
- const ctx = await harness(path, adapter)
- const agent = await ctx.agentLoop.create(SessionId('a1'), { provider: 'mock', model: 'mock' })
- agent.followup(createUserMessage({ content: [{ type: 'text', text: 'go' }], source: { kind: 'user' } }))
- await waitForIdle(ctx, agent)
- expect(events(agent).filter(e => e.type === 'turn/start' || e.type === 'hook/invoked'
- || e.type === 'hook/result' || e.type === 'turn/end').map(e => e.type))
- .toEqual(['turn/start', 'hook/invoked', 'hook/result', 'turn/end'])
- })
- it('a PreToolUse ask with NO reason omits the reason (false arm)', async () => {
- const d = dir()
- const s = sh(d, 'ask.sh', '#!/usr/bin/env bash\necho \'{"hookSpecificOutput":{"hookEventName":"PreToolUse","permissionDecision":"ask"}}\'\n')
- const path = hooks(d, { PreToolUse: [{ hooks: [{ type: 'command', command: s }] }] })
- const adapter = new MockAdapter([toolCallResponse('c1', 'echo', {}), textResponse('done')])
- const ctx = await harness(path, adapter)
- let ran = false
- ctx.tools.register(defineContentToolFixture({ name: 'echo', description: 'e', parameters: {}, async execute() { ran = true; return [{ type: 'text', text: 'x' }] } }))
- const agent = await ctx.agentLoop.create(SessionId('a1'), { provider: 'mock', model: 'mock' })
- agent.followup(createUserMessage({ content: [{ type: 'text', text: 'go' }], source: { kind: 'user' } }))
- await waitForIdle(ctx, agent)
- // ask (no reason) → degrades to deny with the registry's generic message.
- expect(ran).toBe(false)
- expect(events(agent).some(e => e.type === 'tool/result' && e.data.message.content[0].isError)).toBe(true)
- })
- it('a recorded clean exit-0 hook with no stderr omits exitCode-extra/stderrSummary fields', async () => {
- const d = dir()
- const s = sh(d, 'noop.sh', '#!/usr/bin/env bash\nexit 0\n')
- const path = hooks(d, { PreToolUse: [{ hooks: [{ type: 'command', command: s }] }] })
- const adapter = new MockAdapter([toolCallResponse('c1', 'echo', {}), textResponse('done')])
- const ctx = await harness(path, adapter)
- ctx.tools.register(defineContentToolFixture({ name: 'echo', description: 'e', parameters: {}, async execute() { return [{ type: 'text', text: 'ok' }] } }))
- const agent = await ctx.agentLoop.create(SessionId('a1'), { provider: 'mock', model: 'mock' })
- agent.followup(createUserMessage({ content: [{ type: 'text', text: 'go' }], source: { kind: 'user' } }))
- await waitForIdle(ctx, agent)
- const res = events(agent).find(e => e.type === 'hook/result')
- expect(res?.type === 'hook/result' && res.data.exitCode).toBe(0)
- expect(res?.type === 'hook/result' && 'stderrSummary' in res.data).toBe(false)
- })
- })
- if (group === 'edge-paths') describe('hooks-claude-code coverage — schema-bypass apply + unspawnable hook', () => {
- it('a direct apply() (schema bypass) with only configPath runs', async () => {
- const d = dir()
- const marker = join(d, 'ran')
- const s = sh(d, 'h.sh', `#!/usr/bin/env bash\ntouch "${marker}"\n`)
- hooks(d, { UserPromptSubmit: [{ hooks: [{ type: 'command', command: s }] }] })
- const adapter = new MockAdapter([textResponse('ok')])
- const ctx = new Context()
- await mountAgentLoopTestDependencies(ctx)
- await ctx.plugin(AgentLoop, { agents: [] })
- await ctx.plugin(LocalSubprocessRuntime)
- await ctx.plugin(LocalBashExecutor, { timeoutMs: 10_000 })
- // Direct apply with only configPath — bypasses schemastery's defaults, so
- // the bridge must run on the raw minimal config (the per-hook timeout is
- // the protocol lib's reference default, not a config knob).
- HooksClaude.apply(ctx, { configPath: join(d, 'hooks.json') })
- ctx.llm.registerAdapter(['mock'], adapter)
- const agent = await ctx.agentLoop.create(SessionId('a1'), { provider: 'mock', model: 'mock' })
- agent.followup(createUserMessage({ content: [{ type: 'text', text: 'go' }], source: { kind: 'user' } }))
- await waitForIdle(ctx, agent)
- expect(existsSync(marker)).toBe(true)
- })
- it('a non-zero non-2 hook exit (e.g. a command-not-found 127) is a non-blocking error; the tool still runs', async () => {
- const d = dir()
- // `bash -c` of a missing program exits 127 — a non-blocking error (not 0, not
- // 2 → no decision), so the tool proceeds; the hook/result records exit 127.
- const path = hooks(d, { PreToolUse: [{ hooks: [{ type: 'command', command: '/nonexistent/definitely/not/a/command' }] }] })
- const adapter = new MockAdapter([toolCallResponse('c1', 'echo', {}), textResponse('done')])
- const ctx = await harness(path, adapter)
- let ran = false
- ctx.tools.register(defineContentToolFixture({ name: 'echo', description: 'e', parameters: {}, async execute() { ran = true; return [{ type: 'text', text: 'ok' }] } }))
- const agent = await ctx.agentLoop.create(SessionId('a1'), { provider: 'mock', model: 'mock' })
- agent.followup(createUserMessage({ content: [{ type: 'text', text: 'go' }], source: { kind: 'user' } }))
- await waitForIdle(ctx, agent)
- expect(ran).toBe(true)
- const res = events(agent).find(e => e.type === 'hook/result')
- expect(res?.type === 'hook/result' && res.data.exitCode).toBe(127)
- })
- it('a PostToolUse deny with empty stderr + no context uses the default feedback (no context arm)', async () => {
- const d = dir()
- const s = sh(d, 'block.sh', '#!/usr/bin/env bash\nexit 2\n')
- const path = hooks(d, { PostToolUse: [{ hooks: [{ type: 'command', command: s }] }] })
- const adapter = new MockAdapter([toolCallResponse('c1', 'echo', {}), textResponse('done')])
- const ctx = await harness(path, adapter)
- ctx.tools.register(defineContentToolFixture({ name: 'echo', description: 'e', parameters: {}, async execute() { return [{ type: 'text', text: 'ok' }] } }))
- const agent = await ctx.agentLoop.create(SessionId('a1'), { provider: 'mock', model: 'mock' })
- agent.followup(createUserMessage({ content: [{ type: 'text', text: 'go' }], source: { kind: 'user' } }))
- await waitForIdle(ctx, agent)
- const result = events(agent).find(e => e.type === 'tool/result')
- expect(result?.type === 'tool/result' && result.data.message.content[0].isError).toBe(true)
- })
- })
- if (group === 'context') describe('hooks-claude-code coverage — continue:false, context arm, no-cwd', () => {
- it('a {"continue":false} hook is RECORDED as decision "stop" but does not halt the run (TODO(hook-continue-false))', async () => {
- // The extension points cannot yet honor `continue:false` as a hard halt. The log must still record the
- // stop decision while execution and the turn continue normally.
- const d = dir()
- const s = sh(d, 'stop.sh', '#!/usr/bin/env bash\necho \'{"continue":false,"stopReason":"halt"}\'\n')
- const path = hooks(d, { PreToolUse: [{ hooks: [{ type: 'command', command: s }] }] })
- const adapter = new MockAdapter([toolCallResponse('c1', 'echo', {}), textResponse('done')])
- const ctx = await harness(path, adapter)
- let ran = false
- ctx.tools.register(defineContentToolFixture({ name: 'echo', description: 'e', parameters: {}, async execute() { ran = true; return [{ type: 'text', text: 'ok' }] } }))
- const agent = await ctx.agentLoop.create(SessionId('a1'), { provider: 'mock', model: 'mock' })
- agent.followup(createUserMessage({ content: [{ type: 'text', text: 'go' }], source: { kind: 'user' } }))
- await waitForIdle(ctx, agent)
- const res = events(agent).find(e => e.type === 'hook/result')
- expect(res?.type === 'hook/result' && res.data.decision).toBe('stop') // recorded
- expect(ran).toBe(true) // NOT honored: the tool still ran (halt is deferred)
- const turnEnd = events(agent).findLast(e => e.type === 'turn/end')
- expect(turnEnd?.type === 'turn/end' && turnEnd.data.reason.kind).toBe('completed') // ran to completion
- })
- it('a PostToolUse hook that BOTH blocks AND attaches additionalContext', async () => {
- const d = dir()
- const s = sh(d, 'b.sh', '#!/usr/bin/env bash\necho \'{"decision":"block","reason":"bad","hookSpecificOutput":{"hookEventName":"PostToolUse","additionalContext":"context too"}}\'\n')
- const path = hooks(d, { PostToolUse: [{ hooks: [{ type: 'command', command: s }] }] })
- const adapter = new MockAdapter([toolCallResponse('c1', 'echo', {}), textResponse('done')])
- const ctx = await harness(path, adapter)
- ctx.tools.register(defineContentToolFixture({ name: 'echo', description: 'e', parameters: {}, async execute() { return [{ type: 'text', text: 'ok' }] } }))
- const agent = await ctx.agentLoop.create(SessionId('a1'), { provider: 'mock', model: 'mock' })
- agent.followup(createUserMessage({ content: [{ type: 'text', text: 'go' }], source: { kind: 'user' } }))
- await waitForIdle(ctx, agent)
- const result = events(agent).find(e => e.type === 'tool/result')
- expect(result?.type === 'tool/result' && result.data.message.content[0].isError).toBe(true)
- expect(result?.type === 'tool/result' && result.data.message.content[0].content.some(b => b.type === 'text' && b.text.includes('bad'))).toBe(true)
- // additionalContext also injected (the block + context arm).
- expect(events(agent).some(e => e.type === 'user/message' && e.data.source.kind !== 'user' && e.data.content.some(b => b.type === 'text' && b.text.includes('context too')))).toBe(true)
- })
- it('a PreToolUse hook whose hookSpecificOutput names a DIFFERENT event does NOT deny the tool', async () => {
- // The block's hookEventName (UserPromptSubmit) mismatches the firing event
- // (PreToolUse), so its permissionDecision:"deny" is discarded — the tool runs.
- const d = dir()
- const s = sh(d, 'x.sh', '#!/usr/bin/env bash\necho \'{"hookSpecificOutput":{"hookEventName":"UserPromptSubmit","permissionDecision":"deny"}}\'\n')
- const path = hooks(d, { PreToolUse: [{ hooks: [{ type: 'command', command: s }] }] })
- const adapter = new MockAdapter([toolCallResponse('c1', 'echo', {}), textResponse('done')])
- const ctx = await harness(path, adapter)
- let ran = false
- ctx.tools.register(defineContentToolFixture({ name: 'echo', description: 'e', parameters: {}, async execute() { ran = true; return [{ type: 'text', text: 'ok' }] } }))
- const agent = await ctx.agentLoop.create(SessionId('a1'), { provider: 'mock', model: 'mock' })
- agent.followup(createUserMessage({ content: [{ type: 'text', text: 'go' }], source: { kind: 'user' } }))
- await waitForIdle(ctx, agent)
- expect(ran).toBe(true) // the mismatched deny was discarded → the tool ran
- })
- it('defaults CLAUDE_PROJECT_DIR to the session workspace when no projectDir is configured', async () => {
- // The default ACP wiring sets no projectDir. A stock CC hook that references
- // $CLAUDE_PROJECT_DIR (shell expansion) must still get the session workspace,
- // not an empty string. The hook echoes the var as additionalContext.
- const d = dir()
- const workspace = dir()
- const s = sh(d, 'ctx.sh', '#!/usr/bin/env bash\nprintf \'{"hookSpecificOutput":{"hookEventName":"UserPromptSubmit","additionalContext":"dir=%s"}}\' "$CLAUDE_PROJECT_DIR"\n')
- const path = hooks(d, { UserPromptSubmit: [{ hooks: [{ type: 'command', command: s }] }] })
- const adapter = new MockAdapter([textResponse('ran')])
- const ctx = await harness(path, adapter) // NB: no projectDir
- // The factory create() path honors meta.cwd (the plain agentLoop.create() does not).
- const { SessionId } = await import('@deepseek-ai/dsh-session')
- const handle = await ctx.agents.create({ sessionId: SessionId('s1'), meta: { cwd: workspace }, agentOptions: { provider: 'mock', model: 'mock' } })
- handle.agent.followup(createUserMessage({ content: [{ type: 'text', text: 'go' }], source: { kind: 'user' } }))
- await waitForIdle(ctx, handle.agent)
- expect(events(handle.agent).some(e => e.type === 'user/message'
- && e.data.content.some(b => b.type === 'text' && b.text.includes(`dir=${workspace}`)))).toBe(true)
- await handle.dispose()
- })
- it('a context-only UserPromptSubmit hook DELEGATES so a later listener can still block', async () => {
- // A context-only hook delegates with `next()` and folds its context, so a downstream policy
- // listener can still veto the prompt.
- const d = dir()
- const s = sh(d, 'ctx.sh', '#!/usr/bin/env bash\necho \'{"hookSpecificOutput":{"hookEventName":"UserPromptSubmit","additionalContext":"bridge ctx"}}\'\n')
- const path = hooks(d, { UserPromptSubmit: [{ hooks: [{ type: 'command', command: s }] }] })
- const adapter = new MockAdapter([textResponse('should not run')])
- const ctx = await harness(path, adapter)
- // A later listener that blocks every prompt (registered AFTER the bridge).
- ctx.on('agent/pre-step', async () => ({
- kind: 'reject' as const,
- }))
- const agent = await ctx.agentLoop.create(SessionId('a1'), { provider: 'mock', model: 'mock' })
- agent.followup(createUserMessage({ content: [{ type: 'text', text: 'go' }], source: { kind: 'user' } }))
- await waitForIdle(ctx, agent)
- // the downstream block won: the model was never called, no user/message was
- // recorded, and the (sole, fully-blocked) prompt closed the turn `rejected`
- expect(adapter.requests).toHaveLength(0)
- expect(events(agent).some(e => e.type === 'user/message' && e.data.source.kind !== 'user')).toBe(false)
- expect(events(agent).filter(e => e.type === 'turn/start' || e.type === 'hook/invoked'
- || e.type === 'hook/result' || e.type === 'turn/end').map(e => e.type))
- .toEqual(['turn/start', 'hook/invoked', 'hook/result', 'turn/end'])
- })
- it('preserves separate bridge and downstream prompt contexts with framing and metadata', async () => {
- // Both the bridge hook and a later pre-step listener attach context; the
- // request must see both as separately sourced durable events.
- const d = dir()
- const s = sh(d, 'ctx.sh', '#!/usr/bin/env bash\necho \'{"hookSpecificOutput":{"hookEventName":"UserPromptSubmit","additionalContext":"from-bridge"}}\'\n')
- const path = hooks(d, { UserPromptSubmit: [{ hooks: [{ type: 'command', command: s }] }] })
- const adapter = new MockAdapter([textResponse('ok')])
- const ctx = await harness(path, adapter)
- ctx.on('agent/pre-step', async ({ messages }) => ({
- kind: 'enter' as const,
- messages: [{
- ...messages[0]!,
- content: [{ type: 'text' as const, text: 'rewritten-prompt' }],
- }, createUserMessage({
- content: [{ type: 'text' as const, text: 'from-downstream' }],
- source: { kind: 'plugin' as const, plugin: 'policy' },
- })],
- }))
- const agent = await ctx.agentLoop.create(SessionId('a1'), { provider: 'mock', model: 'mock' })
- agent.followup(createUserMessage({ content: [{ type: 'text', text: 'go' }], source: { kind: 'user' } }))
- await waitForIdle(ctx, agent)
- const req = JSON.stringify(adapter.requests[0]!.messages)
- expect(req).toContain('from-bridge')
- expect(req).toContain('from-downstream')
- expect(req).toContain('rewritten-prompt') // downstream content rewrite preserved
- // the original prompt was replaced by the downstream rewrite
- const userMsg = events(agent).find(e => e.type === 'user/message')
- expect(userMsg?.type === 'user/message' && userMsg.data.content.some(b => b.type === 'text' && b.text === 'rewritten-prompt')).toBe(true)
- const contexts = events(agent).filter(event => event.type === 'user/message' && event.data.source.kind !== 'user')
- expect(contexts.map(event => event.type === 'user/message' && event.data.source)).toEqual([
- { kind: 'plugin', plugin: 'policy' },
- { kind: 'plugin', plugin: 'hooks-claude-code' },
- ])
- })
- it('folds the bridge PostToolUse context onto a downstream canonical value replacement', async () => {
- // The bridge hook adds context; a later post-execute listener accepts with a
- // canonical replacement. Both the replacement and the bridge context survive.
- const d = dir()
- const s = sh(d, 'ctx.sh', '#!/usr/bin/env bash\necho \'{"hookSpecificOutput":{"hookEventName":"PostToolUse","additionalContext":"bridge-note"}}\'\n')
- const path = hooks(d, { PostToolUse: [{ hooks: [{ type: 'command', command: s }] }] })
- const adapter = new MockAdapter([toolCallResponse('c1', 'echo', {}), textResponse('done')])
- const ctx = await harness(path, adapter)
- ctx.tools.register(defineContentToolFixture({ name: 'echo', description: 'e', parameters: {}, async execute() { return [{ type: 'text', text: 'ok' }] } }))
- ctx.on('tools/post-execute', async () => ({ kind: 'accept' as const, value: [{ type: 'text' as const, text: 'rewritten-result' }] }))
- const agent = await ctx.agentLoop.create(SessionId('a1'), { provider: 'mock', model: 'mock' })
- agent.followup(createUserMessage({ content: [{ type: 'text', text: 'go' }], source: { kind: 'user' } }))
- await waitForIdle(ctx, agent)
- const result = events(agent).find(e => e.type === 'tool/result')
- expect(result?.type === 'tool/result' && result.data.message.content[0].content.some(b => b.type === 'text' && b.text === 'rewritten-result')).toBe(true)
- expect(events(agent).some(e => e.type === 'user/message' && e.data.source.kind !== 'user' && e.data.content.some(b => b.type === 'text' && b.text.includes('bridge-note')))).toBe(true)
- })
- it('keeps bridge and downstream PostToolUse contexts as separate sourced events', async () => {
- const d = dir()
- const s = sh(d, 'ctx.sh', '#!/usr/bin/env bash\necho \'{"hookSpecificOutput":{"hookEventName":"PostToolUse","additionalContext":"bridge-note"}}\'\n')
- const path = hooks(d, { PostToolUse: [{ hooks: [{ type: 'command', command: s }] }] })
- const adapter = new MockAdapter([toolCallResponse('c1', 'echo', {}), textResponse('done')])
- const ctx = await harness(path, adapter)
- ctx.tools.register(defineContentToolFixture({ name: 'echo', description: 'e', parameters: {}, async execute() { return [{ type: 'text', text: 'ok' }] } }))
- ctx.on('tools/post-execute', async () => ({
- kind: 'accept' as const,
- additionalContexts: [createUserMessage({
- content: [{ type: 'text' as const, text: 'downstream-note' }],
- source: { kind: 'plugin' as const, plugin: 'policy' },
- })],
- }))
- const agent = await ctx.agentLoop.create(SessionId('a1'), { provider: 'mock', model: 'mock' })
- agent.followup(createUserMessage({ content: [{ type: 'text', text: 'go' }], source: { kind: 'user' } }))
- await waitForIdle(ctx, agent)
- const contexts = events(agent).filter(event => event.type === 'user/message' && event.data.source.kind !== 'user')
- expect(contexts.map(event => event.type === 'user/message' && event.data.source)).toEqual([
- { kind: 'plugin', plugin: 'hooks-claude-code' },
- { kind: 'plugin', plugin: 'policy' },
- ])
- })
- it('folds the bridge PostToolUse context onto a downstream listener BLOCK', async () => {
- // The bridge hook only adds context; a later post-execute listener blocks the
- // result. The block wins AND carries the bridge context (concatContext on the
- // block arm).
- const d = dir()
- const s = sh(d, 'ctx.sh', '#!/usr/bin/env bash\necho \'{"hookSpecificOutput":{"hookEventName":"PostToolUse","additionalContext":"bridge-note"}}\'\n')
- const path = hooks(d, { PostToolUse: [{ hooks: [{ type: 'command', command: s }] }] })
- const adapter = new MockAdapter([toolCallResponse('c1', 'echo', {}), textResponse('done')])
- const ctx = await harness(path, adapter)
- ctx.tools.register(defineContentToolFixture({ name: 'echo', description: 'e', parameters: {}, async execute() { return [{ type: 'text', text: 'ok' }] } }))
- ctx.on('tools/post-execute', async () => ({ kind: 'block' as const, feedback: [{ type: 'text' as const, text: 'downstream-block' }] }))
- const agent = await ctx.agentLoop.create(SessionId('a1'), { provider: 'mock', model: 'mock' })
- agent.followup(createUserMessage({ content: [{ type: 'text', text: 'go' }], source: { kind: 'user' } }))
- await waitForIdle(ctx, agent)
- const result = events(agent).find(e => e.type === 'tool/result')
- expect(result?.type === 'tool/result' && result.data.message.content[0].isError).toBe(true)
- expect(result?.type === 'tool/result' && result.data.message.content[0].content.some(b => b.type === 'text' && b.text.includes('downstream-block'))).toBe(true)
- // the bridge's context still landed (folded onto the block)
- expect(events(agent).some(e => e.type === 'user/message' && e.data.source.kind !== 'user' && e.data.content.some(b => b.type === 'text' && b.text.includes('bridge-note')))).toBe(true)
- })
- })
- if (group === 'edge-paths') describe('hooks-claude-code coverage — executor reject + no-open-turn', () => {
- it('when the bash executor REJECTS a hook run, the hook/result omits exitCode (non-blocking)', async () => {
- const d = dir()
- const s = sh(d, 'h.sh', '#!/usr/bin/env bash\nexit 0\n')
- const path = hooks(d, { PreToolUse: [{ hooks: [{ type: 'command', command: s }] }] })
- const adapter = new MockAdapter([toolCallResponse('c1', 'echo', {}), textResponse('done')])
- const ctx = await harness(path, adapter)
- // Force the executor to reject (an infrastructure fault) so runHook's catch
- // yields a HookOutput with exitCode undefined → the `exitCode` spread false arm.
- const bash = ctx.shell
- bash.run = (() => Promise.reject(new Error('executor down')))
- ctx.tools.register(defineContentToolFixture({ name: 'echo', description: 'e', parameters: {}, async execute() { return [{ type: 'text', text: 'ok' }] } }))
- const agent = await ctx.agentLoop.create(SessionId('a1'), { provider: 'mock', model: 'mock' })
- agent.followup(createUserMessage({ content: [{ type: 'text', text: 'go' }], source: { kind: 'user' } }))
- await waitForIdle(ctx, agent)
- const res = events(agent).find(e => e.type === 'hook/result')
- expect(res?.type === 'hook/result' && 'exitCode' in res.data).toBe(false)
- })
- })
- if (group === 'edge-paths') describe('hooks-claude-code coverage — detached-listener catch handlers', () => {
- it('a throwing SessionStart inject is contained (logged, agent still runs)', async () => {
- const d = dir()
- const s = sh(d, 'start.sh', '#!/usr/bin/env bash\necho \'{"hookSpecificOutput":{"hookEventName":"SessionStart","additionalContext":"x"}}\'\n')
- const path = hooks(d, { SessionStart: [{ hooks: [{ type: 'command', command: s }] }] })
- const adapter = new MockAdapter([textResponse('ok')])
- const ctx = await harness(path, adapter)
- const agent = await ctx.agentLoop.create(SessionId('a1'), { provider: 'mock', model: 'mock' })
- // Make inject throw, forcing the SessionStart .catch path.
- const original = agent.inject.bind(agent)
- let threw = false
- agent.inject = (() => { threw = true; throw new Error('inject boom') })
- await waitFor(() => threw)
- expect(threw).toBe(true)
- agent.inject = original
- agent.followup(createUserMessage({ content: [{ type: 'text', text: 'go' }], source: { kind: 'user' } }))
- await waitForIdle(ctx, agent)
- expect(adapter.requests).toHaveLength(1) // loop survived the thrown inject
- })
- })
- if (group === 'stop') describe('hooks-claude-code coverage — hook runs in the session cwd, not the server cwd', () => {
- it('runs an agent-scoped hook in the session workspace even when the executor default differs', async () => {
- // The server launch directory and session cwd deliberately differ. The marker proves the
- // bridge passes `session/new.cwd` instead of falling back to the executor default.
- const serverDir = dir()
- const sessionDir = dir()
- const marker = join(sessionDir, 'where')
- // The hook is invoked with cwd = session dir, so a relative marker path lands there.
- hooks(serverDir, { PreToolUse: [{ hooks: [{ type: 'command', command: 'pwd > where' }] }] })
- const adapter = new MockAdapter([toolCallResponse('c1', 'echo', {}), textResponse('done')])
- const ctx = new Context()
- await mountAgentLoopTestDependencies(ctx)
- await ctx.plugin(AgentLoop, { agents: [] })
- // Executor default cwd = serverDir (deliberately NOT the session cwd).
- await ctx.plugin(LocalSubprocessRuntime)
- await ctx.plugin(LocalBashExecutor, { timeoutMs: 10_000, cwd: serverDir })
- await ctx.plugin(HooksClaude, { configPath: join(serverDir, 'hooks.json') })
- ctx.llm.registerAdapter(['mock'], adapter)
- ctx.tools.register(defineContentToolFixture({ name: 'echo', description: 'e', parameters: {}, async execute() { return [{ type: 'text', text: 'ok' }] } }))
- const { SessionId } = await import('@deepseek-ai/dsh-session')
- const handle = await ctx.agents.create({ sessionId: SessionId('s1'), meta: { cwd: sessionDir }, agentOptions: { provider: 'mock', model: 'mock' } })
- handle.agent.followup(createUserMessage({ content: [{ type: 'text', text: 'go' }], source: { kind: 'user' } }))
- await waitForIdle(ctx, handle.agent)
- expect(existsSync(marker)).toBe(true) // the marker landed in the SESSION dir
- const { readFileSync } = await import('node:fs')
- const where = readFileSync(marker, 'utf8').trim()
- // `pwd` may resolve symlinks (/var → /private/var etc.), so compare basenames.
- expect(where.endsWith(sessionDir.split('/').pop()!)).toBe(true)
- await handle.dispose()
- })
- it('runs a SubagentStop hook in the CHILD session workspace, not the server cwd', async () => {
- const serverDir = dir()
- const childDir = dir()
- const marker = join(childDir, 'stopwhere')
- const payload = join(childDir, 'stoppayload')
- hooks(serverDir, { SubagentStop: [{ hooks: [{ type: 'command', command: 'cat > stoppayload.tmp; mv stoppayload.tmp stoppayload; pwd > stopwhere' }] }] })
- const ctx = new Context()
- await mountAgentLoopTestDependencies(ctx)
- await ctx.plugin(AgentLoop, { agents: [] })
- // Executor default cwd = serverDir (deliberately NOT the child session cwd).
- await ctx.plugin(LocalSubprocessRuntime)
- await ctx.plugin(LocalBashExecutor, { timeoutMs: 10_000, cwd: serverDir })
- await ctx.plugin(HooksClaude, { configPath: join(serverDir, 'hooks.json') })
- ctx.llm.registerAdapter(['mock'], new MockAdapter([]))
- const { SessionId } = await import('@deepseek-ai/dsh-session')
- const childHandle = await ctx.agents.create({ sessionId: SessionId('child-stop-session'), meta: { cwd: childDir }, agentOptions: { provider: 'mock', model: 'mock' } })
- const runId = SubagentRunId('run-stop')
- const identity = { runId, provider: 'inproc', id: childHandle.agent.id, local: true }
- // Start is the registry-backed capture edge; end deliberately follows
- // handle disposal, matching continuable Activation settlement.
- ctx.emit(subagentCarrier(ctx), 'subagent/start', identity)
- await childHandle.dispose()
- expect(ctx.agents.get(childHandle.agent.id)).toBeUndefined()
- ctx.emit(subagentCarrier(ctx), 'subagent/end', { ...identity, stopReason: 'completed' })
- await waitFor(() => existsSync(marker))
- expect(existsSync(marker)).toBe(true) // the marker landed in the CHILD dir
- const where = readFileSync(marker, 'utf8').trim()
- const input = JSON.parse(readFileSync(payload, 'utf8')) as { cwd: string; session_id: string }
- // `pwd` may resolve symlinks (/var → /private/var etc.), so compare basenames.
- expect(where.endsWith(childDir.split('/').pop()!)).toBe(true)
- expect(input).toMatchObject({ cwd: childDir, session_id: childHandle.agent.id })
- })
- })
- if (group === 'config') describe('hooks-claude-code coverage — systemMessage is warned, not surfaced', () => {
- it('a hook emitting a systemMessage is logged as not-yet-surfaced', async () => {
- const d = dir()
- const s = sh(d, 'sm.sh', '#!/usr/bin/env bash\necho \'{"systemMessage":"heads up"}\'\n')
- const path = hooks(d, { UserPromptSubmit: [{ hooks: [{ type: 'command', command: s }] }] })
- const adapter = new MockAdapter([textResponse('ok')])
- const ctx = await harness(path, adapter)
- const warn = vi.fn(); ctx.logger.warn = warn as never
- const agent = await ctx.agentLoop.create(SessionId('a1'), { provider: 'mock', model: 'mock' })
- agent.followup(createUserMessage({ content: [{ type: 'text', text: 'go' }], source: { kind: 'user' } }))
- await waitForIdle(ctx, agent)
- expect(warn).toHaveBeenCalledWith(expect.stringContaining('systemMessage'))
- // Not surfaced: the systemMessage text never reaches the model request.
- expect(JSON.stringify(adapter.requests[0]!.messages)).not.toContain('heads up')
- })
- })
- if (group === 'edge-paths') describe('hooks-claude-code coverage — SessionStart timing is best-effort (no-wait)', () => {
- it('does NOT crash or block when the prompt is sent immediately (context is best-effort, may miss the first request)', async () => {
- // Session-start injection is detached, so an immediate prompt need not observe it. Assert only
- // the guaranteed behavior—no crash and a completed turn—without pre-waiting away the race.
- const d = dir()
- const s = sh(d, 'start.sh', '#!/usr/bin/env bash\necho \'{"hookSpecificOutput":{"hookEventName":"SessionStart","additionalContext":"late ctx"}}\'\n')
- const path = hooks(d, { SessionStart: [{ hooks: [{ type: 'command', command: s }] }] })
- const adapter = new MockAdapter([textResponse('ok')])
- const ctx = await harness(path, adapter)
- const agent = await ctx.agentLoop.create(SessionId('a1'), { provider: 'mock', model: 'mock' })
- // Send immediately — do NOT wait for the session-start inject.
- agent.followup(createUserMessage({ content: [{ type: 'text', text: 'go' }], source: { kind: 'user' } }))
- await waitForIdle(ctx, agent)
- expect(adapter.requests).toHaveLength(1) // the turn ran regardless of hook timing
- })
- })
- }
|