|
@@ -148,7 +148,9 @@ final whole-branch review. When you fill a reviewer template:
|
|
|
- Do not pre-judge findings for the reviewer — never instruct a reviewer to
|
|
- Do not pre-judge findings for the reviewer — never instruct a reviewer to
|
|
|
ignore or not flag a specific issue. If you believe a finding would be a
|
|
ignore or not flag a specific issue. If you believe a finding would be a
|
|
|
false positive, let the reviewer raise it and adjudicate it in the review
|
|
false positive, let the reviewer raise it and adjudicate it in the review
|
|
|
- loop.
|
|
|
|
|
|
|
+ loop. If the prompt you are writing contains "do not flag," "don't treat X
|
|
|
|
|
+ as a defect," "at most Minor," or "the plan chose" — stop: you are
|
|
|
|
|
+ pre-judging, usually to spare yourself a review loop.
|
|
|
- Include the spec/design's global constraints that bind the task (version
|
|
- Include the spec/design's global constraints that bind the task (version
|
|
|
floors, naming and copy rules, platform requirements) in the requirements
|
|
floors, naming and copy rules, platform requirements) in the requirements
|
|
|
you paste — a reviewer can only enforce what you hand them.
|
|
you paste — a reviewer can only enforce what you hand them.
|