hai/gstack
1
0
Fork 0
mirror of https://github.com/garrytan/gstack.git synced 2026-05-22 04:38:24 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix: move prompt temp file outside workingDirectory to prevent race condition

Browse Source 
The .prompt-tmp file was written inside workingDirectory, which gets deleted
by afterAll cleanup. With --concurrent --retry, afterAll can interleave with
retries, causing "No such file or directory" crashes at 0s (seen in
review-design-lite and office-hours-spec-review).

Fix: write prompt file to os.tmpdir() with a unique suffix so it survives
directory cleanup. Also convert review-design-lite from describeE2E to
describeIfSelected for proper diff-based test selection.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Garry Tan
2026-03-21 13:59:24 -07:00
parent 7bed81f650
commit 08f4937134
2 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
test/helpers/session-runner.ts
View File

@@ -161,8 +161,10 @@ export async function runSkillTest(options: {
'--allowed-tools', ...allowedTools, '--allowed-tools', ...allowedTools,
]; ];
// Write prompt to a temp file and pipe it via shell to avoid stdin buffering issues // Write prompt to a temp file OUTSIDE workingDirectory to avoid race conditions
const promptFile = path.join(workingDirectory, '.prompt-tmp'); // where afterAll cleanup deletes the dir before cat reads the file (especially
// with --concurrent --retry). Using os.tmpdir() + unique suffix keeps it stable.
const promptFile = path.join(os.tmpdir(), `.prompt-${process.pid}-${Date.now()}-${Math.random().toString(36).slice(2)}`);
fs.writeFileSync(promptFile, prompt); fs.writeFileSync(promptFile, prompt);
const proc = Bun.spawn(['sh', '-c', `cat "${promptFile}" | claude ${args.map(a => `"${a}"`).join(' ')}`], { const proc = Bun.spawn(['sh', '-c', `cat "${promptFile}" | claude ${args.map(a => `"${a}"`).join(' ')}`], {

4
test/skill-e2e-review.test.ts
View File

@@ -2,7 +2,7 @@ import { describe, test, expect, beforeAll, afterAll } from 'bun:test';
import { runSkillTest } from './helpers/session-runner'; import { runSkillTest } from './helpers/session-runner';
import { import {
ROOT, browseBin, runId, evalsEnabled, selectedTests, ROOT, browseBin, runId, evalsEnabled, selectedTests,
describeIfSelected, describeE2E, testConcurrentIfSelected, describeIfSelected, testConcurrentIfSelected,
copyDirSync, setupBrowseShims, logCost, recordE2E, copyDirSync, setupBrowseShims, logCost, recordE2E,
createEvalCollector, finalizeEvalCollector, createEvalCollector, finalizeEvalCollector,
} from './helpers/e2e-helpers'; } from './helpers/e2e-helpers';
@@ -161,7 +161,7 @@ The diff adds a new "returned" status to the Order model. Your job is to check i
// --- Review: Design review lite E2E --- // --- Review: Design review lite E2E ---
describeE2E('Review design lite E2E', () => { describeIfSelected('Review design lite E2E', ['review-design-lite'], () => {
let designDir: string; let designDir: string;
beforeAll(() => { beforeAll(() => {