hai/gstack
1
0
Fork 0
mirror of https://github.com/garrytan/gstack.git synced 2026-05-20 11:19:56 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix: contributor mode eval marked FAIL due to expected browse error

Browse Source 
The test intentionally runs a nonexistent binary to trigger contributor
mode. The session runner's browse error detection catches "no such file
or directory...browse" and sets browseErrors, causing recordE2E to mark
passed=false. Override passed to check only exitReason since the browse
error is the expected scenario.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Garry Tan
2026-03-16 01:32:24 -05:00
parent f9c834f1f9
commit 7bbfd6ca04
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
test/skill-e2e.test.ts
View File

@@ -312,7 +312,11 @@ File a contributor report about this issue. Then tell me what you filed.`,
}); });
logCost('contributor mode', result); logCost('contributor mode', result);
recordE2E('contributor mode report', 'Skill E2E tests', result); // Override passed: this test intentionally triggers a browse error (nonexistent binary)
// so browseErrors will be non-empty — that's expected, not a failure
recordE2E('contributor mode report', 'Skill E2E tests', result, {
passed: result.exitReason === 'success',
});
// Verify a contributor log was created with expected format // Verify a contributor log was created with expected format
const logFiles = fs.readdirSync(logsDir).filter(f => f.endsWith('.md')); const logFiles = fs.readdirSync(logsDir).filter(f => f.endsWith('.md'));