refactor: BENEFITS_FROM resolver delegates to INVOKE_SKILL

Eliminate duplicated skip-list logic by having generateBenefitsFrom
call generateInvokeSkill internally. The wrapper (AskUserQuestion,
design doc re-check) stays in BENEFITS_FROM. The loading instructions
(read file, skip sections, error handling) come from INVOKE_SKILL.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Garry Tan
2026-03-29 13:20:41 -07:00
parent 7b64da7813
commit 843d4624e0
4 changed files with 35 additions and 29 deletions

View File

@@ -413,10 +413,11 @@ If they choose A:
Say: "Running /office-hours inline. Once the design doc is ready, I'll pick up
the review right where we left off."
Read the office-hours skill file from disk using the Read tool:
`~/.claude/skills/gstack/office-hours/SKILL.md`
Read the `/office-hours` skill file at `~/.claude/skills/gstack/office-hours/SKILL.md` using the Read tool.
Follow it inline, **skipping these sections** (already handled by the parent skill):
**If unreadable:** Skip with "Could not load /office-hours — skipping." and continue.
Follow its instructions from top to bottom, **skipping these sections** (already handled by the parent skill):
- Preamble (run first)
- AskUserQuestion Format
- Completeness Principle — Boil the Lake
@@ -424,9 +425,13 @@ Follow it inline, **skipping these sections** (already handled by the parent ski
- Contributor Mode
- Completion Status Protocol
- Telemetry (run last)
- Step 0: Detect platform and base branch
- Review Readiness Dashboard
- Plan File Review Report
- Prerequisite Skill Offer
- Plan Status Footer
If the Read fails (file not found), say:
"Could not load /office-hours — proceeding with standard review."
Execute every other section at full depth. When the loaded skill's instructions are complete, continue with the next step below.
After /office-hours completes, re-run the design doc check:
```bash