mirror of
https://github.com/garrytan/gstack.git
synced 2026-05-20 19:29:56 +08:00
fix: zsh glob compatibility in skill preamble (v0.11.7.0) (#386)
* fix(preamble): make .pending-* glob pattern zsh-compatible (fixes #313) **Problem:** When running gstack skills in zsh, users see this error: (eval):22: no matches found: /Users/.../.gstack/analytics/.pending-* **Root Cause:** The Preamble code in gen-skill-docs.ts (line 167) contains: for _PF in ~/.gstack/analytics/.pending-*; do ... In zsh, glob patterns that don't match any files cause an error: 'no matches found: pattern' In bash, the loop simply iterates zero times. This breaks all gstack skills for zsh users (common on macOS). **Solution:** Check if any .pending-* files exist BEFORE attempting the for loop: [ -n "$(ls ~/.gstack/analytics/.pending-* 2>/dev/null)" ] && for ... This approach: - ✅ Works in both bash and zsh - ✅ Silently skips the loop when no pending files exist (normal case) - ✅ Executes the loop when pending files are present - ✅ Uses ls with error suppression (2>/dev/null) for portability **Testing:** - ✅ No pending files: loop skipped, no error - ✅ Pending files exist: loop runs normally - ✅ Compatible with bash and zsh - ✅ TypeScript syntax check passes **Impact:** Fixes all gstack skills for zsh users (macOS default shell). Fixes #313 * test: add zsh glob safety test + regenerate SKILL.md files Adds a test verifying the .pending-* glob in preamble is guarded by an ls check (zsh-compatible). Regenerates all SKILL.md files to propagate the fix from the previous commit. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * chore: regenerate SKILL.md files after merge with main New skills from main (benchmark, autoplan, canary, cso, land-and-deploy, setup-deploy) now include the zsh-compatible .pending-* glob guard. * fix: use find instead of ls for zsh glob safety Codex adversarial review caught that $(ls .pending-* 2>/dev/null) still triggers zsh NOMATCH error because the shell expands the glob before ls runs. Using find avoids shell glob expansion entirely. * chore: bump version and changelog (v0.11.7.0) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * chore: update codex agent skill descriptions Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Hiten Shah <hnshah@gmail.com> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
10
CHANGELOG.md
10
CHANGELOG.md
@@ -1,5 +1,15 @@
|
||||
# Changelog
|
||||
|
||||
## [0.11.8.0] - 2026-03-23 — zsh Compatibility Fix
|
||||
|
||||
### Fixed
|
||||
|
||||
- **gstack skills now work in zsh without errors.** Every skill preamble used a `.pending-*` glob pattern that triggered zsh's "no matches found" error on every invocation (the common case where no pending telemetry files exist). Replaced shell glob with `find` to avoid zsh's NOMATCH behavior entirely. Thanks to @hnshah for the initial report and fix in PR #332. Fixes #313.
|
||||
|
||||
### Added
|
||||
|
||||
- **Regression test for zsh glob safety.** New test verifies all generated SKILL.md files use `find` instead of bare shell globs for `.pending-*` pattern matching.
|
||||
|
||||
## [0.11.7.0] - 2026-03-23 — /review → /ship Handoff Fix
|
||||
|
||||
### Fixed
|
||||
|
||||
Reference in New Issue
Block a user