hai/gstack
1
0
Fork 0
mirror of https://github.com/garrytan/gstack.git synced 2026-05-13 07:53:04 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix: gbrain-sync orchestrator resolves brain-sync sibling via import.meta.dir

Browse Source 
Codex M9: runBrainSyncPush hardcoded ~/.claude/skills/gstack/bin/gstack-brain-sync,
so any host that wasn't Claude Code (Codex CLI, dev workspace) hit the existsSync
guard and silently skipped curated-artifact push. Replace with the sibling-resolution
pattern already in runMemoryIngest at line 193.

Regression test asserts the orchestrator no longer takes the lying-skip path when
HOME has no ~/.claude/skills/gstack tree.
This commit is contained in:
Garry Tan
2026-05-03 20:03:25 -07:00
parent bf65487162
commit 9c638da2fd
2 changed files with 23 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
test/gstack-gbrain-sync.test.ts
View File

@@ -137,4 +137,26 @@ describe("gstack-gbrain-sync CLI", () => {
expect(state.last_stages.length).toBe(0);
rmSync(home, { recursive: true, force: true });
});
it("brain-sync stage resolves the sibling binary, not a HOME-rooted path", () => {
// Regression for Codex M9: pre-fix the orchestrator looked up
// ~/.claude/skills/gstack/bin/gstack-brain-sync, which silently no-op'd
// on Codex installs and dev workspaces with the misleading summary
// "skipped (gstack-brain-sync not installed)". Post-fix it resolves
// a sibling via import.meta.dir and actually invokes the script.
const home = makeTestHome();
const gstackHome = join(home, ".gstack");
mkdirSync(gstackHome, { recursive: true });
const r = runScript(
["--incremental", "--no-code", "--no-memory", "--quiet"],
{ HOME: home, GSTACK_HOME: gstackHome },
);
// Don't assert exit code (sibling spawn may legitimately error in a
// sandboxed test). Assert only that we did NOT take the lying-skip path.
const combined = r.stdout + r.stderr;
expect(combined).not.toContain("skipped (gstack-brain-sync not installed)");
rmSync(home, { recursive: true, force: true });
});
});