hai/gstack
1
0
Fork 0
mirror of https://github.com/garrytan/gstack.git synced 2026-05-20 11:19:56 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix: review log architecture — close gaps, fix orphans, add attribution

Browse Source 
- Ship Step 3.5 now logs its code review to the review log (via:"ship")
- Remove eng review gate — ship runs its own review in Step 3.5
- Dashboard Outside Voice row mapped to codex-plan-review
- Dashboard shows via source attribution (e.g., "via /autoplan")
- land-and-deploy checks all 8 review skill types (was 5)
- codex-review log gets commit field for staleness detection
- autoplan uses placeholder tokens instead of hardcoded "clean"
- Document autoplan-voices as audit-trail-only in review.ts
- E2E test for dashboard via attribution
This commit is contained in:
Garry Tan
2026-03-26 07:33:10 -06:00
parent 2b85b1df46
commit d5b6f89b07
14 changed files with 197 additions and 59 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
land-and-deploy/SKILL.md
View File

@@ -400,7 +400,8 @@ Collect evidence for each check below. Track warnings (yellow) and blockers (red
```
Parse the output. For each review skill (plan-eng-review, plan-ceo-review,
plan-design-review, design-review-lite, codex-review):
plan-design-review, design-review-lite, codex-review, review, adversarial-review,
codex-plan-review):
1. Find the most recent entry within the last 7 days.
2. Extract its `commit` field.
@@ -547,7 +548,7 @@ Use AskUserQuestion:
- C) Merge anyway — I understand the risks (Completeness: 3/10)
If the user chooses B: **STOP.** List exactly what needs to be done:
- If reviews are stale: "Re-run /plan-eng-review (or /review) to review current code."
- If reviews are stale: "Re-run `/plan-eng-review`, `/review`, or `/autoplan` to review current code."
- If E2E not run: "Run `bun run test:e2e` to verify."
- If docs not updated: "Run /document-release to update documentation."
- If PR body stale: "Update the PR body to reflect current changes."

5
land-and-deploy/SKILL.md.tmpl
View File

@@ -132,7 +132,8 @@ Collect evidence for each check below. Track warnings (yellow) and blockers (red
```
Parse the output. For each review skill (plan-eng-review, plan-ceo-review,
plan-design-review, design-review-lite, codex-review):
plan-design-review, design-review-lite, codex-review, review, adversarial-review,
codex-plan-review):
1. Find the most recent entry within the last 7 days.
2. Extract its `commit` field.
@@ -279,7 +280,7 @@ Use AskUserQuestion:
- C) Merge anyway — I understand the risks (Completeness: 3/10)
If the user chooses B: **STOP.** List exactly what needs to be done:
- If reviews are stale: "Re-run /plan-eng-review (or /review) to review current code."
- If reviews are stale: "Re-run `/plan-eng-review`, `/review`, or `/autoplan` to review current code."
- If E2E not run: "Run `bun run test:e2e` to verify."
- If docs not updated: "Run /document-release to update documentation."
- If PR body stale: "Update the PR body to reflect current changes."