hai/gstack
1
0
Fork 0
mirror of https://github.com/garrytan/gstack.git synced 2026-05-16 01:02:13 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix: Playwright browser access in CI Docker container

Browse Source 
Two issues preventing browse E2E from working in CI:
1. Playwright installed Chromium as root but container runs as runner —
   browser binaries were inaccessible. Fix: set PLAYWRIGHT_BROWSERS_PATH
   to /opt/playwright-browsers and chmod a+rX.
2. Browse binary needs ~/.gstack/ writable for server lock files.
   Fix: pre-create /home/runner/.gstack/ owned by runner.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Garry Tan
2026-03-23 16:40:31 -07:00
parent 55246b5cd8
commit eb4e20c6c4
2 changed files with 7 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
.github/docker/Dockerfile.ci vendored
View File

@@ -30,7 +30,6 @@ RUN curl -fsSL https://bun.sh/install | bash
RUN npm i -g @anthropic-ai/claude-code RUN npm i -g @anthropic-ai/claude-code
# Playwright system deps (Chromium) — needed for browse E2E tests # Playwright system deps (Chromium) — needed for browse E2E tests
# Install deps first (large layer, changes rarely), then Playwright + browser
RUN npx playwright install-deps chromium RUN npx playwright install-deps chromium
# Pre-install dependencies (cached layer — only rebuilds when package.json changes) # Pre-install dependencies (cached layer — only rebuilds when package.json changes)
@@ -38,8 +37,10 @@ COPY package.json /workspace/
WORKDIR /workspace WORKDIR /workspace
RUN bun install && rm -rf /tmp/* RUN bun install && rm -rf /tmp/*
# Install Playwright Chromium browser (uses deps installed above) # Install Playwright Chromium to a shared location accessible by all users
RUN npx playwright install chromium ENV PLAYWRIGHT_BROWSERS_PATH=/opt/playwright-browsers
RUN npx playwright install chromium \
&& chmod -R a+rX /opt/playwright-browsers
# Verify everything works # Verify everything works
RUN bun --version && node --version && claude --version && jq --version && gh --version \ RUN bun --version && node --version && claude --version && jq --version && gh --version \
@@ -55,4 +56,5 @@ RUN mv /workspace/node_modules /opt/node_modules_cache \
# Create a non-root user for eval runs (GH Actions overrides USER, so # Create a non-root user for eval runs (GH Actions overrides USER, so
# the workflow must set options.user or use gosu/su-exec at runtime). # the workflow must set options.user or use gosu/su-exec at runtime).
RUN useradd -m -s /bin/bash runner \ RUN useradd -m -s /bin/bash runner \
&& chmod -R a+rX /opt/node_modules_cache && chmod -R a+rX /opt/node_modules_cache \
&& mkdir -p /home/runner/.gstack && chown -R runner:runner /home/runner/.gstack

1
.github/workflows/evals.yml vendored
View File

@@ -116,6 +116,7 @@ jobs:
OPENAI_API_KEY: ${{ secrets.OPENAI_API_KEY }} OPENAI_API_KEY: ${{ secrets.OPENAI_API_KEY }}
GEMINI_API_KEY: ${{ secrets.GEMINI_API_KEY }} GEMINI_API_KEY: ${{ secrets.GEMINI_API_KEY }}
EVALS_CONCURRENCY: "40" EVALS_CONCURRENCY: "40"
PLAYWRIGHT_BROWSERS_PATH: /opt/playwright-browsers
run: EVALS=1 bun test --retry 2 --concurrent --max-concurrency 40 ${{ matrix.suite.file }} run: EVALS=1 bun test --retry 2 --concurrent --max-concurrency 40 ${{ matrix.suite.file }}
- name: Upload eval results - name: Upload eval results