mirror of
https://github.com/garrytan/gstack.git
synced 2026-05-17 09:41:28 +08:00
* fix(browse): sanitize lone Unicode surrogates at commandResult chokepoint + /batch envelope (#1440) Page captures with mixed-script Unicode round-trip cleanly to the Claude API. Two new utilities in browse/src/sanitize.ts: stripLoneSurrogates for raw UTF-16 strings, stripLoneSurrogateEscapes for \uXXXX JSON escape text. sanitizeBody picks the right pass based on cr.json. buildCommandResponse is extracted from handleCommand (now exported) and applies sanitization before new Response(). /batch was bypassing this chokepoint via direct JSON.stringify, so it sanitizes each cr.result before pushing AND wraps the envelope with stripLoneSurrogateEscapes. Defense in depth wraps at getCleanText, getCleanTextWithStripping, html, accessibility, and snapshot.ts return points so downstream consumers (datamarking, envelope wrapping) see sanitized text before the response is built. 25 new unit tests across sanitize.test.ts and build-command-response.test.ts. content-security.test.ts updated to accept either pre- or post-sanitize form of the snapshot scoped branch (source-level regression check). Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * feat: bug fix wave v1.36.0.0 — Implementation Tasks, allowlist patterns, surrogate-safe page captures (#1440 #1452 #1454) Three filed issues land together: #1440 — Page captures from real-world HTML hit 'API Error 400: no low surrogate in string'. Sanitizers + buildCommandResponse extraction shipped in the prior commit; this commit adds the migration script that patches existing brain-allowlist/privacy-map/gitattributes installs and the supporting tests. #1452 — Federation sync was silently skipping root-level design and test-plan docs. bin/gstack-artifacts-init adds two patterns to all three managed blocks (.brain-allowlist, .brain-privacy-map.json, .gitattributes). Idempotent migration v1.36.0.0.sh repairs existing installs in place via jq (preserves JSON validity) — no commit + push from the migration. #1454 — All four review skills (CEO/design/eng/DX) emit an Implementation Tasks markdown section AND write a jq-built JSONL artifact per phase. /autoplan reads all four files, scopes by current branch + 5-commit window, dedupes on exact (component, sorted(files), title), and renders an aggregated list in the Final Approval Gate. New tests: - browse/test/sanitize.test.ts (18 cases) - browse/test/build-command-response.test.ts (7 cases) - test/artifacts-init-migration.test.ts (7 cases) VERSION → 1.36.0.0. Skips the v1.34.x slot taken by 'gstack consumable as submodule' and the v1.35.0.0 slot taken by /document-generate. #1428 was shipped separately by v1.34.2.0 with a different approach; follow-up #1503 filed for the bare-path filesystem boundary concern surfaced during our analysis. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * chore: bump to v1.38.1.0 VERSION + package.json + CHANGELOG header + migration filename + test reference all consistently at v1.38.1.0. Migration renamed: gstack-upgrade/migrations/v1.38.0.0.sh -> v1.38.1.0.sh. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
103 lines
3.6 KiB
Bash
Executable File
103 lines
3.6 KiB
Bash
Executable File
#!/usr/bin/env bash
|
|
# Migration: v1.38.1.0 — add root-level design + test-plan patterns to
|
|
# .brain-allowlist, .brain-privacy-map.json, and .gitattributes (#1452).
|
|
#
|
|
# Why a migration: gstack-artifacts-init regenerates these files but also
|
|
# does `git commit + push` on ~/.gstack/, which would clobber user state on
|
|
# upgrade. Instead, we do targeted per-file in-place repairs.
|
|
#
|
|
# Per-file independent — if one file is missing we still repair the others.
|
|
#
|
|
# Idempotent: each insertion is gated on `not already present` so re-running
|
|
# the migration is a no-op.
|
|
|
|
# No `set -e` — we intentionally tolerate per-file failures so other repairs
|
|
# still run. `set -u` is fine.
|
|
set -u
|
|
|
|
GSTACK_HOME="${HOME}/.gstack"
|
|
ALLOWLIST="${GSTACK_HOME}/.brain-allowlist"
|
|
PRIVACY="${GSTACK_HOME}/.brain-privacy-map.json"
|
|
GITATTRS="${GSTACK_HOME}/.gitattributes"
|
|
|
|
MIGRATION_DIR="${GSTACK_HOME}/.migrations"
|
|
DONE="${MIGRATION_DIR}/v1.38.1.0.done"
|
|
|
|
mkdir -p "${MIGRATION_DIR}" 2>/dev/null || true
|
|
if [ -f "${DONE}" ]; then
|
|
exit 0
|
|
fi
|
|
|
|
NEW_PATTERNS=(
|
|
'projects/*/*-design-*.md'
|
|
'projects/*/*-test-plan-*.md'
|
|
)
|
|
|
|
added_any=0
|
|
|
|
# ----- .brain-allowlist ---------------------------------------------------
|
|
if [ -f "${ALLOWLIST}" ]; then
|
|
for PATTERN in "${NEW_PATTERNS[@]}"; do
|
|
if ! grep -Fq -- "${PATTERN}" "${ALLOWLIST}" 2>/dev/null; then
|
|
# Insert before USER ADDITIONS marker. BSD sed (-i.bak) compat for macOS;
|
|
# the backup file is removed afterward.
|
|
if grep -q '^# ---- USER ADDITIONS BELOW' "${ALLOWLIST}" 2>/dev/null; then
|
|
sed -i.bak "/^# ---- USER ADDITIONS BELOW/i\\
|
|
${PATTERN}
|
|
" "${ALLOWLIST}" && rm -f "${ALLOWLIST}.bak"
|
|
added_any=1
|
|
else
|
|
# Marker missing — append at end of file as a fallback. User may have
|
|
# custom-edited the file; better to add than skip silently.
|
|
printf '%s\n' "${PATTERN}" >> "${ALLOWLIST}"
|
|
added_any=1
|
|
fi
|
|
fi
|
|
done
|
|
fi
|
|
|
|
# ----- .brain-privacy-map.json -------------------------------------------
|
|
# Uses jq to preserve JSON validity. Skips with a warning if jq is missing.
|
|
if [ -f "${PRIVACY}" ]; then
|
|
if command -v jq >/dev/null 2>&1; then
|
|
for PATTERN in "${NEW_PATTERNS[@]}"; do
|
|
if ! jq -e --arg p "${PATTERN}" 'map(select(.pattern == $p)) | length > 0' "${PRIVACY}" >/dev/null 2>&1; then
|
|
if jq --arg p "${PATTERN}" '. += [{"pattern": $p, "class": "artifact"}]' "${PRIVACY}" > "${PRIVACY}.tmp" 2>/dev/null; then
|
|
mv "${PRIVACY}.tmp" "${PRIVACY}"
|
|
added_any=1
|
|
else
|
|
rm -f "${PRIVACY}.tmp"
|
|
echo " [v1.38.1.0] WARN: jq failed to patch ${PRIVACY}; skipping pattern ${PATTERN}." >&2
|
|
fi
|
|
fi
|
|
done
|
|
else
|
|
echo " [v1.38.1.0] WARN: jq not found; skipping privacy-map repair. Install jq and re-run gstack-upgrade, or run gstack-artifacts-init manually." >&2
|
|
fi
|
|
fi
|
|
|
|
# ----- .gitattributes -----------------------------------------------------
|
|
if [ -f "${GITATTRS}" ]; then
|
|
for PATTERN in "${NEW_PATTERNS[@]}"; do
|
|
RULE="${PATTERN} merge=union"
|
|
if ! grep -Fq -- "${RULE}" "${GITATTRS}" 2>/dev/null; then
|
|
printf '%s\n' "${RULE}" >> "${GITATTRS}"
|
|
added_any=1
|
|
fi
|
|
done
|
|
fi
|
|
|
|
# Mark done. Even if no patches were applied (already-current install), we
|
|
# write the touchfile so the migration runs once.
|
|
touch "${DONE}"
|
|
|
|
if [ "${added_any}" = "1" ]; then
|
|
echo " [v1.38.1.0] allowlist/privacy-map/gitattributes patched for root-level design + test-plan artifacts (idempotent)" >&2
|
|
fi
|
|
|
|
# NEVER `git commit + push` from this migration. The user controls when the
|
|
# patches ship into their federated artifacts repo (next gstack-brain-sync
|
|
# --once or a manual commit).
|
|
|
|
exit 0
|