mirror of
https://github.com/garrytan/gstack.git
synced 2026-05-12 07:27:26 +08:00
* fix: cookie import picker returns JSON instead of HTML jsonResponse() was defined at module scope but referenced `url` which only existed as a parameter of handleCookiePickerRoute(). Every API call crashed, the catch block also crashed, and Bun returned a default HTML page that the frontend couldn't parse as JSON. Thread port via corsOrigin() helper and options objects. Add route-level tests to prevent this class of bug from shipping again. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * feat: add help command to browse server Agents that don't have SKILL.md loaded (or misread flags) had no way to self-discover the CLI. The help command returns a formatted reference of all commands and snapshot flags. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * feat: version-aware find-browse with META signal protocol Agents in other workspaces found stale browse binaries that were missing newer flags. find-browse now compares the local binary's git SHA against origin/main via git ls-remote (4hr cache), and emits META:UPDATE_AVAILABLE when behind. SKILL.md setup checks parse META signals and prompt the user to update. - New compiled binary: browse/dist/find-browse (TypeScript, testable) - Bash shim at browse/bin/find-browse delegates to compiled binary - .version file written at build time with git commit SHA - Build script compiles both browse and find-browse binaries - Graceful degradation: offline, missing .version, corrupt cache all skip check Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * chore: clean up .bun-build temp files after compile bun build --compile leaves ~58MB temp files in the working directory. Add rm -f .*.bun-build to the build script to clean up after each build. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix: make help command reachable by removing it from META_COMMANDS help was in META_COMMANDS, so it dispatched to handleMetaCommand() which threw "Unknown meta command: help". Removing it from the set lets the dedicated else-if handler in handleCommand() execute correctly. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * chore: bump version and changelog (v0.3.2) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * feat: add shared Greptile comment triage reference doc Shared reference for fetching, filtering, and classifying Greptile review comments on GitHub PRs. Used by both /review and /ship skills. Includes parallel API fetching, suppressions check, classification logic, reply APIs, and history file writes. * feat: make /review and /ship Greptile-aware /review: Step 2.5 fetches and classifies Greptile comments, Step 5 resolves them with AskUserQuestion for valid issues and false positives. /ship: Step 3.75 triages Greptile comments between pre-landing review and version bump. Adds Greptile Review section to PR body in Step 8. Re-runs tests if any Greptile fixes are applied. * feat: add Greptile batting average to /retro Reads ~/.gstack/greptile-history.md, computes signal ratio (valid catches vs false positives), includes in metrics table, JSON snapshot, and Code Quality Signals narrative. * docs: add Greptile integration section to README Personal endorsement, two-layer review narrative, full UX walkthrough transcript, skills table updates. Add Greptile training feedback loop to TODO.md future ideas. * feat: add local dev mode for testing skills from within the repo bin/dev-setup creates .claude/skills/gstack symlink to the working tree so Claude Code discovers skills locally. bin/dev-teardown cleans up. DEVELOPING_GSTACK.md documents the workflow. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix: narrow gitignore to .claude/skills/ instead of all .claude/ Avoids ignoring legitimate Claude Code config like settings.json or CLAUDE.md. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * docs: rename DEVELOPING_GSTACK.md to CONTRIBUTING.md Rewritten as a contributor-friendly guide instead of a dry plan doc. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * docs: explain why dev-setup is needed in CONTRIBUTING.md quick start Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * feat: add browser interaction guidance to CLAUDE.md Prevents Claude from using mcp__claude-in-chrome__* tools instead of /browse. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * feat: add shared config module for project-local browse state Centralizes path resolution (git root detection, state dir, log paths) into config.ts. Both cli.ts and server.ts import from it, eliminating duplicated PORT_OFFSET/BROWSE_PORT/STATE_FILE logic. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * feat: rewrite port selection to use random ports Replace CONDUCTOR_PORT magic offset and 9400-9409 scan with random port 10000-60000. Atomic state file writes, log paths from config module, binaryVersion field for auto-restart on update. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * feat: move browse state from /tmp to project-local .gstack/ CLI now uses config module for state paths, passes BROWSE_STATE_FILE to spawned server. Adds version mismatch auto-restart, legacy /tmp cleanup with PID verification, and removes stale global install fallback. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix: update crash log path reference to .gstack/ Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * test: add config tests and update CLI lifecycle test 14 new tests for config resolution, ensureStateDir, readVersionHash, resolveServerScript, and version mismatch detection. Remove obsolete CONDUCTOR_PORT/BROWSE_PORT filtering from commands.test.ts. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * docs: update BROWSER.md and TODO.md for project-local state Replace /tmp paths with .gstack/, remove CONDUCTOR_PORT docs, document random port selection and per-project isolation. Add server bundling TODO. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * docs: update README, CHANGELOG, and CONTRIBUTING for v0.3.2 - README: replace Conductor-aware language with project-local isolation, add Greptile setup note - CHANGELOG: comprehensive v0.3.2 entry with all state management changes - CONTRIBUTING: add instructions for testing branches in other repos Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * feat: add diff-aware mode to /qa — auto-tests affected pages from branch diff When on a feature branch, /qa now reads git diff main, identifies affected pages/routes from changed files, and tests them automatically. No URL required. The most natural flow: write code, /ship, /qa. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * chore: update CHANGELOG for complete v0.3.2 coverage Add missing entries: diff-aware QA mode, Greptile integration, local dev mode, crash log path fix, README/SKILL.md updates. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
106 lines
2.9 KiB
TypeScript
106 lines
2.9 KiB
TypeScript
/**
|
|
* Shared config for browse CLI + server.
|
|
*
|
|
* Resolution:
|
|
* 1. BROWSE_STATE_FILE env → derive stateDir from parent
|
|
* 2. git rev-parse --show-toplevel → projectDir/.gstack/
|
|
* 3. process.cwd() fallback (non-git environments)
|
|
*
|
|
* The CLI computes the config and passes BROWSE_STATE_FILE to the
|
|
* spawned server. The server derives all paths from that env var.
|
|
*/
|
|
|
|
import * as fs from 'fs';
|
|
import * as path from 'path';
|
|
|
|
export interface BrowseConfig {
|
|
projectDir: string;
|
|
stateDir: string;
|
|
stateFile: string;
|
|
consoleLog: string;
|
|
networkLog: string;
|
|
dialogLog: string;
|
|
}
|
|
|
|
/**
|
|
* Detect the git repository root, or null if not in a repo / git unavailable.
|
|
*/
|
|
export function getGitRoot(): string | null {
|
|
try {
|
|
const proc = Bun.spawnSync(['git', 'rev-parse', '--show-toplevel'], {
|
|
stdout: 'pipe',
|
|
stderr: 'pipe',
|
|
timeout: 2_000, // Don't hang if .git is broken
|
|
});
|
|
if (proc.exitCode !== 0) return null;
|
|
return proc.stdout.toString().trim() || null;
|
|
} catch {
|
|
return null;
|
|
}
|
|
}
|
|
|
|
/**
|
|
* Resolve all browse config paths.
|
|
*
|
|
* If BROWSE_STATE_FILE is set (e.g. by CLI when spawning server, or by
|
|
* tests for isolation), all paths are derived from it. Otherwise, the
|
|
* project root is detected via git or cwd.
|
|
*/
|
|
export function resolveConfig(
|
|
env: Record<string, string | undefined> = process.env,
|
|
): BrowseConfig {
|
|
let stateFile: string;
|
|
let stateDir: string;
|
|
let projectDir: string;
|
|
|
|
if (env.BROWSE_STATE_FILE) {
|
|
stateFile = env.BROWSE_STATE_FILE;
|
|
stateDir = path.dirname(stateFile);
|
|
projectDir = path.dirname(stateDir); // parent of .gstack/
|
|
} else {
|
|
projectDir = getGitRoot() || process.cwd();
|
|
stateDir = path.join(projectDir, '.gstack');
|
|
stateFile = path.join(stateDir, 'browse.json');
|
|
}
|
|
|
|
return {
|
|
projectDir,
|
|
stateDir,
|
|
stateFile,
|
|
consoleLog: path.join(stateDir, 'browse-console.log'),
|
|
networkLog: path.join(stateDir, 'browse-network.log'),
|
|
dialogLog: path.join(stateDir, 'browse-dialog.log'),
|
|
};
|
|
}
|
|
|
|
/**
|
|
* Create the .gstack/ state directory if it doesn't exist.
|
|
* Throws with a clear message on permission errors.
|
|
*/
|
|
export function ensureStateDir(config: BrowseConfig): void {
|
|
try {
|
|
fs.mkdirSync(config.stateDir, { recursive: true });
|
|
} catch (err: any) {
|
|
if (err.code === 'EACCES') {
|
|
throw new Error(`Cannot create state directory ${config.stateDir}: permission denied`);
|
|
}
|
|
if (err.code === 'ENOTDIR') {
|
|
throw new Error(`Cannot create state directory ${config.stateDir}: a file exists at that path`);
|
|
}
|
|
throw err;
|
|
}
|
|
}
|
|
|
|
/**
|
|
* Read the binary version (git SHA) from browse/dist/.version.
|
|
* Returns null if the file doesn't exist or can't be read.
|
|
*/
|
|
export function readVersionHash(execPath: string = process.execPath): string | null {
|
|
try {
|
|
const versionFile = path.resolve(path.dirname(execPath), '.version');
|
|
return fs.readFileSync(versionFile, 'utf-8').trim() || null;
|
|
} catch {
|
|
return null;
|
|
}
|
|
}
|