Browse Source

Add phrase-level pre-judging triggers to reviewer prompt rule

Resumed the offending eval controller session and asked it why it
pre-judged despite the rule being in context. Its retrospective: the
motive was avoiding a review loop, the abstract rule was read but not
applied at the moment it governs, and a phrase-level trigger ('do not
flag', 'at most Minor', 'don't treat X as a defect', 'the plan chose')
would have fired where the principle did not.
Jesse Vincent 3 months ago
parent
commit
d55cdce32c
1 changed files with 3 additions and 1 deletions
  1. 3 1
      skills/subagent-driven-development/SKILL.md

+ 3 - 1
skills/subagent-driven-development/SKILL.md

@@ -148,7 +148,9 @@ final whole-branch review. When you fill a reviewer template:
 - Do not pre-judge findings for the reviewer — never instruct a reviewer to
   ignore or not flag a specific issue. If you believe a finding would be a
   false positive, let the reviewer raise it and adjudicate it in the review
-  loop.
+  loop. If the prompt you are writing contains "do not flag," "don't treat X
+  as a defect," "at most Minor," or "the plan chose" — stop: you are
+  pre-judging, usually to spare yourself a review loop.
 - Include the spec/design's global constraints that bind the task (version
   floors, naming and copy rules, platform requirements) in the requirements
   you paste — a reviewer can only enforce what you hand them.