mirror of
https://github.com/garrytan/gstack.git
synced 2026-05-08 21:49:45 +08:00
* feat: gstack-gbrain-mcp-verify helper for remote MCP probe
Probes a remote gbrain MCP endpoint with bearer auth. POSTs initialize,
classifies failures into NETWORK / AUTH / MALFORMED with one-line
remediation hints, and runs a tools/list capability probe to detect
sources_add MCP support (forward-compat for when gbrain ships URL ingest).
Token consumed from GBRAIN_MCP_TOKEN env, never argv. Required to set
both 'application/json' AND 'text/event-stream' in Accept; that gotcha
costs 10 minutes of debugging when missed (regression-tested).
Live-verified against wintermute (gbrain v0.27.1).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* feat: gstack-artifacts-init + gstack-artifacts-url helpers
artifacts-init replaces brain-init with provider choice (gh / glab /
manual), per-user gstack-artifacts-$USER repo, HTTPS-canonical storage in
~/.gstack-artifacts-remote.txt, and a "send this to your brain admin"
hookup printout. Always prints the command, never auto-executes — gbrain
v0.26.x has no admin-scope MCP probe (codex Finding #3).
artifacts-url centralizes HTTPS↔SSH/host/owner-repo conversion so callers
don't each string-mangle (codex Finding #10). The remote-conflict check in
artifacts-init compares at the canonical level so re-running with HTTPS
input doesn't trip on a stored SSH URL for the same logical repo.
The "URL form not supported" branch prints a two-line clone-then-path
form for gbrain v0.26.x; the supported branch is a one-liner with --url
ready for when gbrain ships URL ingest.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* feat: extend gstack-gbrain-detect with mcp_mode + artifacts_remote
Adds two new fields to detect's JSON output:
- gbrain_mcp_mode: local-stdio | remote-http | none
Resolved via 3-tier fallback (codex Finding D3): claude mcp get --json
→ claude mcp list text-grep → ~/.claude.json jq read. If Anthropic moves
the file format, the first two tiers absorb it.
- gstack_artifacts_remote: HTTPS URL from ~/.gstack-artifacts-remote.txt
Falls back to ~/.gstack-brain-remote.txt during the v1.27.0.0 migration
window so detect doesn't return empty between upgrade and migration.
Existing detect tests still pass (15/15). New 19 tests cover every fallback
tier independently, plus a schema regression for /sync-gbrain compat.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* feat: setup-gbrain Path 4 (remote MCP) + artifacts rename
Path 4 lets users paste an HTTPS MCP URL + bearer token and registers it
as an HTTP-transport MCP without needing a local gbrain CLI install. The
flow:
- Step 2 gains a fourth option (Remote gbrain MCP)
- Step 4 adds Path 4 sub-flow: collect URL, secret-read bearer, verify
via gstack-gbrain-mcp-verify (NETWORK / AUTH / MALFORMED classifier)
- Step 5 (local doctor), Step 7.5 (transcript ingest), Step 5a's stdio
branch all skip on Path 4
- Step 5a adds an HTTP+bearer registration form: claude mcp add
--transport http --header "Authorization: Bearer ..."
- Step 7 renamed "session memory sync" → "artifacts sync" and now calls
gstack-artifacts-init (which always prints the brain-admin hookup
command — no auto-execute, codex Finding #3)
- Step 8 CLAUDE.md block branches: remote-http includes URL + server
version (never the token); local-stdio keeps engine + config-file
- Step 9 smoke test on Path 4 prints the curl-equivalent for
post-restart verification (MCP tools aren't visible mid-session)
- Step 10 verdict block has separate templates per mode
Idempotency: re-running with gbrain_mcp_mode=remote-http already in
detect output skips Step 2 entirely and goes to verification.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* refactor: rename gbrain_sync_mode → artifacts_sync_mode (v1.27.0.0 prep)
Hard rename, no dual-read alias (codex Finding D4). The on-disk migration
script (Phase C, separate commit) renames the config key in users'
~/.gstack/config.yaml and any CLAUDE.md blocks.
Touched call sites:
- bin/gstack-config defaults + validation + list/defaults output
- bin/gstack-gbrain-detect (gstack_brain_sync_mode field still emitted
with the same name for downstream-tool compat; reads new key)
- bin/gstack-brain-sync, bin/gstack-brain-enqueue, bin/gstack-brain-uninstall
- bin/gstack-timeline-log (comment ref)
- scripts/resolvers/preamble/generate-brain-sync-block.ts: renames key,
branches on gbrain_mcp_mode=remote-http to emit "ARTIFACTS_SYNC:
remote-mode (managed by brain server <host>)" instead of the local
mode/queue/last_push line (codex Finding #11)
- bin/gstack-brain-restore + bin/gstack-gbrain-source-wireup: read
~/.gstack-artifacts-remote.txt with ~/.gstack-brain-remote.txt fallback
during the migration window
- bin/gstack-artifacts-init: tolerant of unrecognized URL forms (local
paths, file://, self-hosted gitea) so test infrastructure and unusual
remotes work without canonicalization
- test/brain-sync.test.ts: gstack-brain-init → gstack-artifacts-init
- test/skill-e2e-brain-privacy-gate.test.ts: artifacts_sync_mode keys
- test/gen-skill-docs.test.ts: budget 35K → 36.5K for the new MCP-mode
probe in the preamble resolver
- health/SKILL.md.tmpl, sync-gbrain/SKILL.md.tmpl: comment + verdict line
Hard delete:
- bin/gstack-brain-init (replaced by bin/gstack-artifacts-init in v1.27.0.0)
- test/gstack-brain-init-gh-mock.test.ts (replaced by gstack-artifacts-init.test.ts)
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* chore: regenerate SKILL.md files after artifacts-sync rename
Mechanical regen via \`bun run gen:skill-docs --host all\`. All */SKILL.md
files reflect the renamed config key (gbrain_sync_mode →
artifacts_sync_mode), the renamed remote-helper file
(~/.gstack-artifacts-remote.txt with brain fallback), the renamed init
script (gstack-artifacts-init), and the new ARTIFACTS_SYNC: remote-mode
status line that fires when a remote-http MCP is registered.
Golden fixtures (test/fixtures/golden/*-ship-SKILL.md) refreshed to match
the regenerated default-ship output.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* feat: v1.27.0.0 migration — gstack-brain → gstack-artifacts rename
Journaled, interruption-safe migration. Six steps, each writes to
~/.gstack/.migrations/v1.27.0.0.journal on success; re-entry resumes
from the next un-done step. On final success, journal is replaced by
~/.gstack/.migrations/v1.27.0.0.done.
Steps:
1. gh_repo_renamed gh/glab repo rename gstack-brain-$USER →
gstack-artifacts-$USER (idempotent: detects
already-renamed and skips)
2. remote_txt_renamed mv ~/.gstack-brain-remote.txt → artifacts file,
rewriting URL path to match the new repo name
3. config_key_renamed sed -i in ~/.gstack/config.yaml flips
gbrain_sync_mode → artifacts_sync_mode
4. claude_md_block sed flips "- Memory sync:" → "- Artifacts sync:"
in cwd CLAUDE.md and ~/.gstack/CLAUDE.md
5. sources_swapped gbrain sources add NEW (verify) → remove OLD
(codex Finding #6: add-before-remove ordering,
no downtime window). On remote-MCP mode, prints
commands for the brain admin instead of executing.
6. done touchfile + delete journal
User opt-out: any "n" or "skip-for-now" answer at the initial prompt
writes a marker file that prevents re-prompting; user can re-invoke
via /setup-gbrain --rerun-migration.
11 unit tests cover: nothing-to-migrate, GitHub happy path, idempotent
re-run, journal-resume mid-flight, remote-MCP print-only path,
add-before-remove ordering verification, add-fail → old source stays
registered, CLAUDE.md field rewrite.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* test: regression suite + E2E for v1.27.0.0 rename
Three new regression tests guard the rename's blast radius (per codex
Findings #1, #8, #9, #12):
- test/no-stale-gstack-brain-refs.test.ts: greps bin/, scripts/, *.tmpl,
test/ for forbidden identifiers (gstack-brain-init, gbrain_sync_mode);
fails CI if any non-allowlisted file references them.
- test/post-rename-doc-regen.test.ts: confirms gen-skill-docs output has
no stale references in any */SKILL.md (the cross-product blind spot).
- test/setup-gbrain-path4-structure.test.ts: structural lint over the
Path 4 prose contract — STOP gates after verify failure, never-write-
token rules, mode-aware CLAUDE.md block, bearer always via env-var.
Two new gate-tier E2E tests (deterministic stub HTTP server, fixed inputs):
- test/skill-e2e-setup-gbrain-remote.test.ts: Path 4 happy path. Stubs
an HTTP MCP server, drives the skill via Agent SDK with a stubbed
bearer, asserts claude.json gets the http MCP entry, CLAUDE.md gets
the remote-http block, the secret token NEVER leaks to CLAUDE.md.
- test/skill-e2e-setup-gbrain-bad-token.test.ts: stub server returns 401;
asserts the AUTH classifier hint surfaces, no MCP registration occurs,
CLAUDE.md is unchanged. Regression guard for the "verify failed → STOP"
rule.
touchfiles.ts: setup-gbrain-remote and setup-gbrain-bad-token added at
gate-tier so CI catches Path 4 regressions on every PR.
Plus a few comment refs flipped: bin/gstack-jsonl-merge, bin/gstack-timeline-log
(legacy gstack-brain-init mentions in headers).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* release: v1.27.0.0 — /setup-gbrain Path 4 + brain → artifacts rename
Bumps VERSION 1.26.4.0 → 1.27.0.0 (MINOR per CLAUDE.md scale-aware bump
guidance: ~1500 line net change including a new path in /setup-gbrain,
two new bin helpers, a journaled migration, 59 new tests, and a config
key rename across the codebase).
CHANGELOG entry covers: Path 4 (Remote MCP) end-to-end, the brain →
artifacts rename, the journaled migration, the verify-helper error
classifier, the artifacts-init multi-host provider choice. Includes
the canonical Garry-voice headline + numbers table + audience close
per the release-summary format.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* test: demote setup-gbrain Path 4 E2E to periodic-tier
The Agent SDK E2E tests for Path 4 (skill-e2e-setup-gbrain-remote and
skill-e2e-setup-gbrain-bad-token) are inherently non-deterministic —
the model interprets "follow Path 4 only" prompts flexibly and can
skip Step 8 (CLAUDE.md write) or shortcut past the verify helper, which
makes the gate-tier assertions flaky.
The deterministic gate coverage for Path 4 is in
test/setup-gbrain-path4-structure.test.ts: a fast structural lint that
catches AUQ-pacing regressions and prose contract drift in <200ms with
zero token spend. That test is the right tool for catching the failure
mode the gate-tier was meant to guard against.
The Agent SDK E2E tests stay available on-demand for periodic-tier runs
(EVALS=1 EVALS_TIER=periodic bun test test/skill-e2e-setup-gbrain-*.test.ts).
Also tightened the verify-error assertion to the literal field shape
("error_class": "AUTH") instead of a substring match that false-matches
the parent claude session's "needs-auth" MCP discovery markers.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* chore: sync package.json version to 1.27.0.0
VERSION was bumped to 1.27.0.0 in f6ec11eb but package.json was not
updated in the same commit. The gen-skill-docs.test.ts assertion
"package.json version matches VERSION file" caught the drift.
This is the DRIFT_STALE_PKG case the /ship Step 12 idempotency check
is designed for; the fix is the documented sync-only repair (no
re-bump, package.json synced to existing VERSION).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
189 lines
7.1 KiB
Bash
Executable File
189 lines
7.1 KiB
Bash
Executable File
#!/usr/bin/env bash
|
|
# gstack-gbrain-detect — emit current gbrain/gstack-brain state as JSON.
|
|
#
|
|
# Usage:
|
|
# gstack-gbrain-detect
|
|
#
|
|
# Output (always valid JSON, even when every check is false):
|
|
# {
|
|
# "gbrain_on_path": true|false,
|
|
# "gbrain_version": "0.18.2" | null,
|
|
# "gbrain_config_exists": true|false,
|
|
# "gbrain_engine": "pglite"|"postgres" | null,
|
|
# "gbrain_doctor_ok": true|false,
|
|
# "gbrain_mcp_mode": "local-stdio"|"remote-http"|"none",
|
|
# "gstack_brain_sync_mode": "off"|"artifacts-only"|"full",
|
|
# "gstack_brain_git": true|false,
|
|
# "gstack_artifacts_remote": "https://..." | ""
|
|
# }
|
|
#
|
|
# The /setup-gbrain skill reads this once at startup to decide which path
|
|
# branches are live and which steps can be skipped. Never modifies state;
|
|
# pure introspection. Exits 0 unless `jq` is missing.
|
|
#
|
|
# Env:
|
|
# GSTACK_HOME — override ~/.gstack for gstack-brain-* state lookups.
|
|
set -euo pipefail
|
|
|
|
STATE_DIR="${GSTACK_HOME:-$HOME/.gstack}"
|
|
SCRIPT_DIR="$(cd "$(dirname "$0")" && pwd)"
|
|
CONFIG_BIN="$SCRIPT_DIR/gstack-config"
|
|
GBRAIN_CONFIG="$HOME/.gbrain/config.json"
|
|
|
|
die() { echo "gstack-gbrain-detect: $*" >&2; exit 2; }
|
|
|
|
require_jq() {
|
|
command -v jq >/dev/null 2>&1 || die "jq is required. Install with: brew install jq"
|
|
}
|
|
require_jq
|
|
|
|
# --- gbrain binary presence + version ---
|
|
gbrain_on_path=false
|
|
gbrain_version=null
|
|
if command -v gbrain >/dev/null 2>&1; then
|
|
gbrain_on_path=true
|
|
# Format versions as JSON strings; gbrain --version may print other chatter.
|
|
v=$(gbrain --version 2>/dev/null | head -1 | tr -d '[:space:]' || true)
|
|
if [ -n "$v" ]; then
|
|
gbrain_version=$(jq -Rn --arg v "$v" '$v')
|
|
fi
|
|
fi
|
|
|
|
# --- gbrain config file ---
|
|
gbrain_config_exists=false
|
|
gbrain_engine=null
|
|
if [ -f "$GBRAIN_CONFIG" ]; then
|
|
gbrain_config_exists=true
|
|
# Engine is defensively parsed; an invalid config returns null, not a crash.
|
|
engine_raw=$(jq -r '.engine // empty' "$GBRAIN_CONFIG" 2>/dev/null || true)
|
|
case "$engine_raw" in
|
|
pglite|postgres) gbrain_engine=$(jq -Rn --arg e "$engine_raw" '$e') ;;
|
|
esac
|
|
fi
|
|
|
|
# --- gbrain doctor health ---
|
|
# Doctor is wrapped in `timeout 5s` to match the /health D6 pattern and avoid
|
|
# the detect step hanging the skill when gbrain is broken or its DB is
|
|
# unreachable. Any nonzero exit or non-"ok"/"warnings" status → false.
|
|
gbrain_doctor_ok=false
|
|
if [ "$gbrain_on_path" = "true" ]; then
|
|
# Use `timeout` if available; some minimal macs use gtimeout from coreutils.
|
|
timeout_bin=""
|
|
if command -v timeout >/dev/null 2>&1; then timeout_bin="timeout 5s"
|
|
elif command -v gtimeout >/dev/null 2>&1; then timeout_bin="gtimeout 5s"
|
|
fi
|
|
if doctor_json=$(eval "$timeout_bin gbrain doctor --json" 2>/dev/null); then
|
|
status=$(echo "$doctor_json" | jq -r '.status // empty' 2>/dev/null || true)
|
|
case "$status" in
|
|
ok|warnings) gbrain_doctor_ok=true ;;
|
|
esac
|
|
fi
|
|
fi
|
|
|
|
# --- artifacts sync state (renamed from gbrain_sync_mode in v1.27.0.0) ---
|
|
gstack_brain_sync_mode="off"
|
|
if [ -x "$CONFIG_BIN" ]; then
|
|
mode=$("$CONFIG_BIN" get artifacts_sync_mode 2>/dev/null || true)
|
|
case "$mode" in
|
|
off|artifacts-only|full) gstack_brain_sync_mode="$mode" ;;
|
|
esac
|
|
fi
|
|
|
|
gstack_brain_git=false
|
|
if [ -d "$STATE_DIR/.git" ]; then
|
|
gstack_brain_git=true
|
|
fi
|
|
|
|
# --- gbrain_mcp_mode: local-stdio | remote-http | none ---
|
|
# Defense-in-depth fallback chain (intentional ordering, do not reorder):
|
|
# 1. `claude mcp get gbrain --json` — public CLI surface, structured output
|
|
# 2. `claude mcp list` text-grep — older claude versions without --json
|
|
# 3. `~/.claude.json` jq read — last resort if `claude` isn't on PATH
|
|
# Fallback chain logged because if Anthropic moves the file or renames keys,
|
|
# the third tier breaks silently; the first two tiers should catch it.
|
|
gbrain_mcp_mode="none"
|
|
if command -v claude >/dev/null 2>&1; then
|
|
# Tier 1: claude mcp get --json
|
|
if mcp_get_json=$(claude mcp get gbrain --json 2>/dev/null); then
|
|
if echo "$mcp_get_json" | jq -e '.' >/dev/null 2>&1; then
|
|
mtype=$(echo "$mcp_get_json" | jq -r '.type // .transport // empty' 2>/dev/null)
|
|
mcommand=$(echo "$mcp_get_json" | jq -r '.command // empty' 2>/dev/null)
|
|
murl=$(echo "$mcp_get_json" | jq -r '.url // empty' 2>/dev/null)
|
|
case "$mtype" in
|
|
http|sse) gbrain_mcp_mode="remote-http" ;;
|
|
stdio) gbrain_mcp_mode="local-stdio" ;;
|
|
*)
|
|
# Newer claude versions may emit just url + command; infer.
|
|
if [ -n "$murl" ]; then gbrain_mcp_mode="remote-http"
|
|
elif [ -n "$mcommand" ]; then gbrain_mcp_mode="local-stdio"
|
|
fi
|
|
;;
|
|
esac
|
|
fi
|
|
fi
|
|
# Tier 2: claude mcp list text-grep (only if Tier 1 didn't resolve)
|
|
if [ "$gbrain_mcp_mode" = "none" ]; then
|
|
if mcp_list=$(claude mcp list 2>/dev/null); then
|
|
gbrain_line=$(echo "$mcp_list" | grep -E '^gbrain:' || true)
|
|
if [ -n "$gbrain_line" ]; then
|
|
if echo "$gbrain_line" | grep -q 'http\|HTTP'; then
|
|
gbrain_mcp_mode="remote-http"
|
|
else
|
|
gbrain_mcp_mode="local-stdio"
|
|
fi
|
|
fi
|
|
fi
|
|
fi
|
|
fi
|
|
# Tier 3: ~/.claude.json jq read (only if claude binary or earlier tiers failed)
|
|
if [ "$gbrain_mcp_mode" = "none" ]; then
|
|
if [ -f "$HOME/.claude.json" ]; then
|
|
# Look for a gbrain MCP server entry. Type field disambiguates http vs stdio.
|
|
mtype=$(jq -r '.mcpServers.gbrain.type // .mcpServers.gbrain.transport // empty' "$HOME/.claude.json" 2>/dev/null)
|
|
murl=$(jq -r '.mcpServers.gbrain.url // empty' "$HOME/.claude.json" 2>/dev/null)
|
|
mcommand=$(jq -r '.mcpServers.gbrain.command // empty' "$HOME/.claude.json" 2>/dev/null)
|
|
case "$mtype" in
|
|
url|http|sse) gbrain_mcp_mode="remote-http" ;;
|
|
stdio) gbrain_mcp_mode="local-stdio" ;;
|
|
*)
|
|
if [ -n "$murl" ]; then gbrain_mcp_mode="remote-http"
|
|
elif [ -n "$mcommand" ]; then gbrain_mcp_mode="local-stdio"
|
|
fi
|
|
;;
|
|
esac
|
|
fi
|
|
fi
|
|
|
|
# --- artifacts remote URL (post-rename) with brain-* fallback during the
|
|
# migration window (gstack-upgrade migration runs the rename). ---
|
|
gstack_artifacts_remote=""
|
|
if [ -f "$HOME/.gstack-artifacts-remote.txt" ]; then
|
|
gstack_artifacts_remote=$(head -1 "$HOME/.gstack-artifacts-remote.txt" 2>/dev/null | tr -d '[:space:]' || true)
|
|
elif [ -f "$HOME/.gstack-brain-remote.txt" ]; then
|
|
# Pre-migration fallback. Migration v1.27.0.0 will mv this to the new path.
|
|
gstack_artifacts_remote=$(head -1 "$HOME/.gstack-brain-remote.txt" 2>/dev/null | tr -d '[:space:]' || true)
|
|
fi
|
|
|
|
# Emit single-object JSON.
|
|
jq -n \
|
|
--argjson on_path "$gbrain_on_path" \
|
|
--argjson version "$gbrain_version" \
|
|
--argjson config_exists "$gbrain_config_exists" \
|
|
--argjson engine "$gbrain_engine" \
|
|
--argjson doctor_ok "$gbrain_doctor_ok" \
|
|
--arg mcp_mode "$gbrain_mcp_mode" \
|
|
--arg sync_mode "$gstack_brain_sync_mode" \
|
|
--argjson brain_git "$gstack_brain_git" \
|
|
--arg artifacts_remote "$gstack_artifacts_remote" \
|
|
'{
|
|
gbrain_on_path: $on_path,
|
|
gbrain_version: $version,
|
|
gbrain_config_exists: $config_exists,
|
|
gbrain_engine: $engine,
|
|
gbrain_doctor_ok: $doctor_ok,
|
|
gbrain_mcp_mode: $mcp_mode,
|
|
gstack_brain_sync_mode: $sync_mode,
|
|
gstack_brain_git: $brain_git,
|
|
gstack_artifacts_remote: $artifacts_remote
|
|
}'
|